Repository navigation
fix: preserve prompt height beside generated image previews - #18200
Conversation
🎭 Playwright: ✅ 2064 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3a851363c48b233b3b576131dff6e1e92b0e1573
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.95 MB gzip 🔴 +245 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • 🔴 +698 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.87 MB (baseline 3.87 MB) • 🟢 -51 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 73 added / 73 removed / 228 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T11:31:09.290Z",
"gitSha": "ed1b464d218882b26b9ed9f9fd8688a222fa8b05",
"branch": "fix/flux-prompt-height",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.2720000000295,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.396000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.941,
"heapDeltaBytes": 14624164,
"heapUsedBytes": 76629756,
"domNodes": -263,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 12.655,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1990.7889999999497,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.259,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.25100000000003,
"heapDeltaBytes": -5556784,
"heapUsedBytes": 56674136,
"domNodes": -264,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.422,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1707.8329999999937,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.833000000000002,
"layouts": 14,
"layoutDurationMs": 4.0809999999999995,
"taskDurationMs": 773.079,
"heapDeltaBytes": -2382648,
"heapUsedBytes": 59976856,
"domNodes": -262,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 134.135,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1708.9260000000195,
"styleRecalcs": 73,
"styleRecalcDurationMs": 23.814999999999994,
"layouts": 14,
"layoutDurationMs": 3.854,
"taskDurationMs": 710.379,
"heapDeltaBytes": 774200,
"heapUsedBytes": 63107572,
"domNodes": -264,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 125.89900000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.3009999999726,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.95,
"layouts": 6,
"layoutDurationMs": 1.1300000000000001,
"taskDurationMs": 331.804,
"heapDeltaBytes": 2150304,
"heapUsedBytes": 64481640,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 14.062000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.278000000064,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.232999999999999,
"layouts": 6,
"layoutDurationMs": 1.179,
"taskDurationMs": 305.23,
"heapDeltaBytes": 2204436,
"heapUsedBytes": 64303140,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.184000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 582.6940000000036,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.738999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.51599999999996,
"heapDeltaBytes": 18218708,
"heapUsedBytes": 80328492,
"domNodes": 17,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 138.66400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 557.5129999999717,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.411000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.37700000000007,
"heapDeltaBytes": 18486464,
"heapUsedBytes": 80492036,
"domNodes": 19,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 136.75699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.817000000004,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.4670000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.6469999999999,
"heapDeltaBytes": 1452576,
"heapUsedBytes": 83128472,
"domNodes": -245,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.108999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2026.006999999936,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.206999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.179,
"heapDeltaBytes": 2103788,
"heapUsedBytes": 83257224,
"domNodes": -246,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 34.272,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2365.804999999966,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.771999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1541.2700000000002,
"heapDeltaBytes": -1248764,
"heapUsedBytes": 81157668,
"domNodes": -254,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 744.584,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2222.1640000000207,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.932,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1470.0279999999998,
"heapDeltaBytes": -12416832,
"heapUsedBytes": 68470908,
"domNodes": -222,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 712.565,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3340.1620000000207,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.913999999999996,
"layouts": 60,
"layoutDurationMs": 13.466,
"taskDurationMs": 1528.0489999999998,
"heapDeltaBytes": 10555816,
"heapUsedBytes": 74070484,
"domNodes": -252,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 667.899,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3284.091999999987,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.216000000000003,
"layouts": 60,
"layoutDurationMs": 13.129,
"taskDurationMs": 1524.821,
"heapDeltaBytes": -9883060,
"heapUsedBytes": 74138184,
"domNodes": -249,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 675.645,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2699.9779999999873,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.584,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1789.9919999999997,
"heapDeltaBytes": 22878304,
"heapUsedBytes": 88648508,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 900.428,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2587.9169999999476,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.203,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1605.778,
"heapDeltaBytes": -17449152,
"heapUsedBytes": 73613764,
"domNodes": -227,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 858.162,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.1130000000135,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.967999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.2610000000001,
"heapDeltaBytes": 20183168,
"heapUsedBytes": 84116744,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.437999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2050.438999999983,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.364000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.741,
"heapDeltaBytes": -8691496,
"heapUsedBytes": 79921444,
"domNodes": -252,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 37.519999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 539.5399999999881,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.662,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.01000000000005,
"heapDeltaBytes": 13246120,
"heapUsedBytes": 76670616,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 123.839,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 546.8999999999369,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.89,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.24,
"heapDeltaBytes": 14094268,
"heapUsedBytes": 77363648,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 125.111,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2054.468999999983,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.554999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.44499999999994,
"heapDeltaBytes": 688032,
"heapUsedBytes": 63834264,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.765,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.0529999999417,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.195000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.42,
"heapDeltaBytes": 15539640,
"heapUsedBytes": 78984396,
"domNodes": -275,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.643,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.0509999999595,
"styleRecalcs": 78,
"styleRecalcDurationMs": 25.116,
"layouts": 18,
"layoutDurationMs": 4.709,
"taskDurationMs": 723.7009999999999,
"heapDeltaBytes": -7121264,
"heapUsedBytes": 62597820,
"domNodes": -275,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 94.861,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.0060000000212,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.537000000000006,
"layouts": 18,
"layoutDurationMs": 5.492999999999999,
"taskDurationMs": 727.015,
"heapDeltaBytes": -6787064,
"heapUsedBytes": 62835716,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 99.42399999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1318.0059999999685,
"styleRecalcs": 17,
"styleRecalcDurationMs": 23.989000000000004,
"layouts": 5,
"layoutDurationMs": 10.230999999999998,
"taskDurationMs": 830.2830000000001,
"heapDeltaBytes": 20274592,
"heapUsedBytes": 103725608,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 28.487,
"eventListeners": 2383,
"totalBlockingTimeMs": 104,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8401.537000000018,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.42999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5268.18,
"heapDeltaBytes": -5059336,
"heapUsedBytes": 76398612,
"domNodes": -244,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2382.11,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8298.861999999986,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.731,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5002.617000000001,
"heapDeltaBytes": -11782940,
"heapUsedBytes": 68204800,
"domNodes": -220,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 2282.5389999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14843.58800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14717.305999999999,
"heapDeltaBytes": -50865612,
"heapUsedBytes": 185384020,
"domNodes": -8061,
"jsHeapTotalBytes": -11251712,
"scriptDurationMs": 226.13500000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14552.282999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14434.824000000002,
"heapDeltaBytes": -59918948,
"heapUsedBytes": 179359904,
"domNodes": -8061,
"jsHeapTotalBytes": -15175680,
"scriptDurationMs": 209.32099999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17333.27900000006,
"styleRecalcs": 120,
"styleRecalcDurationMs": 17.610999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17238.931,
"heapDeltaBytes": -36506524,
"heapUsedBytes": 180205568,
"domNodes": -8061,
"jsHeapTotalBytes": -11255808,
"scriptDurationMs": 758.266,
"eventListeners": -14928,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17153.44499999992,
"styleRecalcs": 119,
"styleRecalcDurationMs": 16.477999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17103.006999999998,
"heapDeltaBytes": -21919732,
"heapUsedBytes": 189227488,
"domNodes": -8061,
"jsHeapTotalBytes": -11907072,
"scriptDurationMs": 739.532,
"eventListeners": -14928,
"totalBlockingTimeMs": 29,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5358.02799999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.06700000000002,
"layouts": 20,
"layoutDurationMs": 34.83800000000001,
"taskDurationMs": 5342.768,
"heapDeltaBytes": -35270584,
"heapUsedBytes": 176114784,
"domNodes": -8061,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 116.62599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 317,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5360.828000000083,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.000999999999976,
"layouts": 20,
"layoutDurationMs": 23.385,
"taskDurationMs": 5344.987999999999,
"heapDeltaBytes": -20314664,
"heapUsedBytes": 190042484,
"domNodes": -8061,
"jsHeapTotalBytes": 19095552,
"scriptDurationMs": 91.88799999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 303,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7238.222000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7202.7789999999995,
"heapDeltaBytes": 32252312,
"heapUsedBytes": 195192468,
"domNodes": 0,
"jsHeapTotalBytes": -22282240,
"scriptDurationMs": 127.94599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7417.895999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7374.256999999999,
"heapDeltaBytes": 4934860,
"heapUsedBytes": 185363620,
"domNodes": 0,
"jsHeapTotalBytes": -18350080,
"scriptDurationMs": 110.33699999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 458.8049999999839,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.859999999999996,
"layouts": 4,
"layoutDurationMs": 2.15,
"taskDurationMs": 115.549,
"heapDeltaBytes": 5159964,
"heapUsedBytes": 67088608,
"domNodes": 149,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 12.939,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 439.6280000000843,
"styleRecalcs": 12,
"styleRecalcDurationMs": 16.177999999999997,
"layouts": 3,
"layoutDurationMs": 0.8470000000000001,
"taskDurationMs": 93.415,
"heapDeltaBytes": 4905440,
"heapUsedBytes": 69972248,
"domNodes": 121,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.467000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe node layout now uses shared image-preview dimensions and accounts for expandable widgets during rendering and resizing. Tests cover preview height changes, resize reconciliation, screenshots, reload persistence, and prompt retention. ChangesImage preview sizing
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18200 +/- ##
==========================================
+ Coverage 82.94% 83.92% +0.97%
==========================================
Files 2954 2261 -693
Lines 145496 128543 -16953
Branches 37479 32758 -4721
==========================================
- Hits 120685 107876 -12809
+ Misses 23541 20377 -3164
+ Partials 1270 290 -980
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 706 files with indirect coverage changes 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested
I found one blocking correctness issue: the new preview reserve is driven by registered widget IDs rather than the widgets that are actually visible. An image node with only a hidden advanced expanding widget therefore grows by 232px and switches its preview to shrink-0, even though no expanding widget row is rendered. The predicate and its negative-control test need to use the same processed visibility source as WidgetGrid.
I also left two non-blocking implementation/test findings inline:
- the 232px reserve has two owners even though it participates in persisted resize geometry;
- the new inverse resize path has no behavioral coverage.
The test-file header also needs a small factual cleanup: it still says the root cause is undecided and that a test.fail() case reproduces the regression, but this PR removes the only test.fail() and implements the sizing fix.
Checked and cleared
- Promoted previews and extension-only
hasLayoutSizewidgets follow unchanged pre-existing paths outside the PR's stated direct-image/registry scope. - The isolated per-test
setViewportSize()call follows established browser-suite precedent and does not need extra describe structure. - The two post-run screenshots were already duplicate artifacts at the exact merge base, so that is not introduced here. The new ten-pixel antialiasing tolerance cannot hide the target 185px/232px geometry change, and functional value/height assertions remain.
- The six local Fallow radius reports are unchanged from the exact merge base; CI Fallow likewise reported no new findings.
- The taller 1024×720 case keeps the prompt visible; partial viewport/minimap overlap is the expected pannable-canvas tradeoff. The 1440×1000 multiline case is fully visible.
- The initial head's local pre-generation screenshot differed by 31 antialiased pixels only. The follow-up screenshot-alignment head resolves it and the exact-head case passes.
- Existing issue/review feedback contained no actionable findings; CodeRabbit approved the final head.
Coverage and checks
All four final-head changed files and the exact merge-base diff were reviewed across correctness, maintainability, idiomaticity, tests, and documentation lanes. pnpm typecheck, pnpm typecheck:browser, changed-file ESLint/oxfmt, git diff --check, 22 focused LGraphNode unit tests, all five exact-head Flux browser cases, the image-grid resize browser test, and two extra visual viewport/content cases passed. Oxlint exited 0 with five unrelated baseline warnings. CI had no failed final-head checks at review time; two checks were still running.
| const hasExpandingWidget = computed(() => | ||
| renderedWidgetIds.value.some((id) => { | ||
| const type = widgetValueStore.getWidget(id)?.type | ||
| return type !== undefined && shouldExpand(type) |
There was a problem hiding this comment.
[P1] Base growth on a visible expanding row, not the registered ID list
renderedWidgetIds includes advanced widgets even when showAdvanced is false, while WidgetGrid omits them after processed visibility. On an image node with only a hidden advanced expanding widget, this condition is therefore true: the node gains 232px and the preview becomes shrink-0 even though no expanding row is rendered. Please derive this predicate from the same processed visibility source as WidgetGrid, and add a negative-control test for that state.
There was a problem hiding this comment.
Hidden advanced rows excluded; re-review needed.
Full context for agent readers
Addressed in the repaired head: useProcessedWidgets now excludes hidden advanced expanding rows from preview-height reservation. The hidden-row component case fails before this fix; all 25 component cases pass. Leaving this thread open for your re-review.
There was a problem hiding this comment.
Tracked as FE-2581. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
| import NodeSlots from './NodeSlots.vue' | ||
| import NodeWidgets from './NodeWidgets.vue' | ||
|
|
||
| const IMAGE_PREVIEW_MIN_HEIGHT = 232 |
There was a problem hiding this comment.
[P2] Give the preview reserve one owner
232 duplicates ImagePreview's min-h-55, NodeContent's mt-2, and this parent's gap-1, then feeds that duplicated value into persisted resize geometry. If any spacing changes, saved node heights can drift. Please centralize the complete reserve and use that source for both preview sizing and resize reconciliation.
There was a problem hiding this comment.
Spacing and reserve now share constants.
Full context for agent readers
Addressed in the repaired head: imagePreviewLayout.ts defines the content minimum, image margin and row gap. Rendered styles and the computed reserve consume those same values. Leaving this thread open for your re-review.
There was a problem hiding this comment.
Tracked as FE-2581. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
| width: Math.max(result.size.width, MIN_NODE_WIDTH), | ||
| height: removeNodeTitleHeight(result.size.height) | ||
| height: | ||
| removeNodeTitleHeight(result.size.height) - imagePreviewGrowth.value |
There was a problem hiding this comment.
[P2] Cover the new inverse resize path
This subtraction now affects requestedSize and the durable setSize() path, but the new cases never resize while preview growth is active. A sign error or double subtraction would still pass the generation and reload assertions. Please add a behavioral case that resizes an image node with a visible expanding widget and verifies the stable persisted size after the transient preview allowance is removed or restored.
There was a problem hiding this comment.
Resize persistence covered; wrong-sign mutation fails.
Full context for agent readers
Addressed in the repaired head: the new browser case resizes, reloads and regenerates, asserting that exported authored size remains stable as transient previews disappear and return. Changing inverse-resize subtraction to addition fails the case; restoring subtraction passes. All seven targeted browser checks, source/browser types and hooks pass. Leaving this thread open for your re-review.
There was a problem hiding this comment.
Tracked as FE-2581. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
I re-reviewed the cumulative head and found all prior findings addressed:
- Preview growth now uses the same processed-widget visibility model as
WidgetGrid. Hidden advanced rows no longer reserve height, while visible expanding rows still do. imagePreviewLayout.tsis now the single owner for the 220px content minimum, 8px margin, 4px row gap, and derived 232px reserve. Rendering and resize reconciliation consume those constants.- The new component and browser cases exercise nonzero preview growth through resize, preview removal, reload, and preview restoration while checking that authored size stays stable.
- The stale test header no longer refers to an undecided root cause or a removed
test.fail().
I found no new issues in the follow-up diff.
Verification
- Removing the visibility guard makes the advanced-widget case fail at 362px instead of 130px. Restoring the guard passes.
- Changing resize subtraction to addition makes the component case fail at 702px instead of 238px. Restoring subtraction passes.
- All 25
LGraphNodecomponent tests pass. - Source and browser typechecks, changed-file ESLint and formatting, type-aware Oxlint, and
git diff --checkpass. Oxlint reports five unrelated baseline warnings. - Playwright discovers all six Flux cases. Exact-head CI completed all 104 checks with no failures or pending checks, including all 16 Chromium shards and
e2e-status.
dante01yoon
left a comment
There was a problem hiding this comment.
Verdict: approve — no blocking findings on this head.
I read the current head against @DrJKL's CHANGES_REQUESTED round and confirmed the three settled points rather than restating them: hasExpandingWidget now derives from useProcessedWidgets (same visibility model as WidgetGrid), imagePreviewLayout.ts is the single owner of 220 + 8 + 4 = 232, and the new browser case exercises resize across preview removal and restoration. I focused on what those rounds did not cover.
What I checked independently, all of which holds:
- No runaway growth across repeated generations.
useVueElementTrackingfeeds the measured DOM height intolayoutStore.reportContentSize, which writes a separatecontentSizesmap, not the authoredsize.refreshNodeGeometrythen exposesrenderedSize = max(size, contentSize). So the +232 lands in rendered geometry (correct — the DOM really is taller) while the persistedsizestays flat, which is exactly what the new browser case asserts viagetExportedWorkflow(). - The inverse resize cannot persist a negative or under-minimum height.
useNodeResize.measureMinContentHeight()probes with--node-height: 0px, and with the wrapper nowshrink-0that probe includes the full 232px reserve.newHeightis clamped to that floor before the callback runs, soremoveNodeTitleHeight(h) - 232bottoms out at the non-preview content minimum rather than going negative. Good that the clamp and the reserve agree; it is worth keeping them together if either moves. - The
min-h-55→ inlinemin-heightswap is safe..image-previewhas no competing CSS rule anywhere in the repo (it is only used as a test/selector hook), so raising specificity to an inline style overrides nothing. gap-1→rowGapis equivalent here. The body isflex-col, so the droppedcolumn-gaphas no rendered effect.- A flat 232px reserve cannot under-count against promoted previews.
usePromotedPreviewsonly produces rows for aSubgraphNodehost, andnodeMediareturnsundefinedforSubgraphNode, sonodeMedia?.type === 'image' && hasExpandingWidgetand a non-emptypromotedPreviewscannot co-occur. Theshrink-0branch therefore always wraps exactly one preview. nodeMediacannot be an image with zero urls (it returnsundefinedwhen!urls?.length), so the reserve can never add 232px of empty space to a node that renders no preview.
All 106 CI checks on this head are successful or skipped; none failed.
Two non-blocking notes inline.
Validation I did not run: read-only review through the GitHub API — I did not execute the component or Playwright suites locally, so the run counts in the description and in the prior review rounds are author/reviewer-reported here.
| }) | ||
|
|
||
| const hasRenderableWidgets = computed(() => renderedWidgetIds.value.length > 0) | ||
| const { processedWidgets } = useProcessedWidgets( |
There was a problem hiding this comment.
suggestion: this makes computeProcessedWidgets run twice per node.
NodeWidgets.vue:69 already calls useProcessedWidgets(...) for the same node, and this adds a second independent instance in the parent. useProcessedWidgets is side-effect free, so this is correct — but processedWidgets is a computed over nodeData, widgetIds, showAdvanced, isGraphReady and the root graph, so every widget or setting change now recomputes the full processed-widget model twice for every rendered node. On a large graph that is a real per-frame cost on a hot path, and the two copies can only ever agree.
Deriving hasExpandingWidget from the same instance the grid uses would avoid it — e.g. have NodeWidgets expose the predicate (a defineExpose or an emitted/v-model-style flag), or lift the single useProcessedWidgets call into the parent and pass processedWidgets down. Not blocking; the current behaviour is right, this is only about doing the work once.
There was a problem hiding this comment.
Tracked as FE-2581. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
|
|
||
| import { downloadFile } from '@/base/common/downloadUtil' | ||
| import Button from '@/components/ui/button/Button.vue' | ||
| import { IMAGE_PREVIEW_CONTENT_MIN_HEIGHT } from '@/renderer/extensions/vueNodes/components/imagePreviewLayout' |
There was a problem hiding this comment.
nit-pick (non-blocking): this import breaks the surrounding ordering and uses a different specifier style from its siblings.
It lands between @/components/ui/button/Button.vue and @/components/ui/skeleton/Skeleton.vue, splitting the @/components/ui/... group. The same pattern appears in LGraphNode.vue:286 (useProcessedWidgets inserted between useNodePointerInteractions and useNodeZIndex) and in LGraphNode.test.ts, where resizeNodeLayout is appended after getNodeByLocatorId.
Also, imagePreviewLayout.ts is a sibling of this file, and NodeContent.vue / LGraphNode.vue both import it as ./imagePreviewLayout while this one spells out @/renderer/extensions/vueNodes/components/imagePreviewLayout. Matching the relative form would keep the three consumers consistent.
There was a problem hiding this comment.
Tracked as FE-2581. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: nonblocking follow-ups
I found no blocker on the current head. Dante's two inline comments are valid, so I have not duplicated them:
- The parent and
NodeWidgetscreate separateuseProcessedWidgetsinstances. The duplicate projection is lazy and dependency-driven rather than running for every node on every frame, but image-output nodes with widgets can still recompute the same full model twice. Lifting one processed model into the parent would remove that duplicate ownership and work. - The new imports break the repository's documented grouping/order. ESLint and oxfmt pass because neither enforces import order. The sibling alias versus relative specifier is not independently inconsistent because nearby components use both forms.
I left two additional P3 comments inline. The PR description also has stale validation counts: the current head has six Flux cases and 25 LGraphNode component tests, not five and 22. Including the existing image-grid case makes seven browser cases, so the statement that the parent repeated "all six" is also stale.
Prior findings and checked items
- The four prior DrJKL findings remain fixed: visible-widget projection, shared preview-layout constants, resize persistence coverage, and the corrected test header.
- The six local Fallow radius advisories are unchanged exact-merge-base code, not findings introduced by this PR.
- No new correctness defect was found in preview growth, persisted versus rendered size, minimum-height clamping, repeated generation, promoted previews, or empty-media handling.
Coverage and checks
Standard correctness, maintainability, idiomaticity, tests, and documentation lanes reviewed the full cumulative diff. Source and browser typechecks, changed-file ESLint and formatting, type-aware Oxlint, git diff --check, and all 25 focused component tests pass. Oxlint reports five unrelated baseline warnings. Playwright discovers all six Flux cases. Exact-head CI has 106 completed checks with no failures or pending checks.
| import { getNodeByLocatorId } from '@/utils/graphTraversalUtil' | ||
| import { resizeNodeLayout } from '@/renderer/core/layout/operations/graphLayoutAttachment' | ||
|
|
||
| interface ResizeResult { |
There was a problem hiding this comment.
[P3] Reuse the exported resize callback payload
This local ResizeResult duplicates ResizeCallbackPayload, which useNodeResize.ts already exports and its own test imports. If the real callback contract changes, this mock can keep compiling against a stale shape. Please delete the parallel interface and type this callback with the exported payload (or derive the callback parameter from useNodeResize).
There was a problem hiding this comment.
Tracked as FE-2581. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
| const initialSize = await savedSize() | ||
| expect(initialSize).toBeDefined() | ||
|
|
||
| await runGeneration(comfyPage, exec, ws, nodeId) |
There was a problem hiding this comment.
[P3] Give the lifecycle phases named Playwright steps
This case generates a preview, resizes and persists, reloads to remove the preview, then regenerates to restore it. Without test.step boundaries, a trace failure reports only the long test title and the reader must reconstruct which phase failed. Please wrap the resize/persist, reload/removal, and restoration sections in named steps.
There was a problem hiding this comment.
Tracked as FE-2581. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
## Summary Completes the four non-blocking review follow-ups left open when Comfy-Org#18200 merged. ## Changes - **What**: Shares the processed widget model between `LGraphNode` and `NodeWidgets` while preserving `NodeWidgets`' standalone fallback mode; aligns the imports called out in review; reuses `ResizeCallbackPayload`; and names the Playwright resize lifecycle steps. - **Related PR**: Comfy-Org#18200 ## Review Focus Confirm the supplied processed-widget model remains the single evaluated projection in `LGraphNode`, while builder-mode callers continue using `NodeWidgets`' lazy fallback. Validation completed before the host resource-safety stop: - Final source `vue-tsc --noEmit` passed. - Final focused component suites passed: 40 tests across `NodeWidgets`, `LGraphNode`, and `LGraphNodePreview`. - Browser typecheck passed before the final source-only compatibility adjustment. - Playwright discovered all six Flux cases. - Changed-file ESLint and type-aware Oxlint passed before the final `NodeWidgets` compatibility adjustment. Per the owner's host-overload directive, local checks were not rerun after the review follow-ups; the Checks tab is authoritative. ## Screenshots Not applicable; this refactor does not change UI behavior. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com>
|
|
|
|
Backports #18200 (preserves prompt height beside generated image previews) to core/1.54. The automated backport conflicted only in the release branch test file because 1.54 uses the older widget render-state API. This adapts that fixture without changing production behavior. Validation: - LGraphNode unit suite: 24 passed - typecheck passed - formatting passed - pre-push Knip/Fallow gate passed - existing Flux.2 browser regression remains included for black-box coverage
…ge previews (#18200) (#19179) ## Summary Backport #18200 to the 1.54 release line. ## Validation - Production changes cherry-picked cleanly. - Resolved the sole test conflict by preserving the 1.54 graph traversal mock while retaining the new resize callback assertions. - Local focused test collection is blocked by the borrowed dependency tree missing `vuefire`; hosted CI is the release-native validation gate. Source: #18200
Backports #18200 (preserves prompt height beside generated image previews) to cloud/1.54. The automated backport conflicted only in the release branch test file because 1.54 uses the older widget render-state API. This adapts that fixture without changing production behavior. Validation: - Same target-native implementation as the validated core/1.54 backport - LGraphNode unit suite: 24 passed - typecheck passed - formatting passed - existing Flux.2 browser regression remains included for black-box coverage
…age previews (#18200) (#19180) ## Summary Backport #18200 to the 1.54 release line. ## Validation - Production changes cherry-picked cleanly. - Resolved the sole test conflict by preserving the 1.54 graph traversal mock while retaining the new resize callback assertions. - Local focused test collection is blocked by the borrowed dependency tree missing `vuefire`; hosted CI is the release-native validation gate. Source: #18200
Summary
Keep expanding prompt widgets usable when an image preview appears after generation.
Changes
Review Focus
Preview height allocation and authored versus rendered node size. This fixes the reproduced prompt-collapse symptom, not every reported workflow-overwrite issue in the Flux incident and its reproduction task. Those incidents and release acceptance remain open with the program completion owner.
Full context for agent readers
Validated on Node 26.8.2: five Flux repeated-generation browser cases plus the existing image-grid vertical/horizontal resize case; 22 LGraphNode component tests; main/browser typechecks; targeted lint/format and commit hooks. The parent independently repeated all six browser cases and inspected the after-second-generation screenshot. The initial broad preview allocation failed image-grid resizing and was corrected before publication.
The preview allowance is 220px minimum image height + 8px preview margin + 4px content gap. It applies only when the widget registry says a rendered widget expands. No backend or persisted workflow schema changes.
Tracking: program task claude-handoff-9 retains the original incident, stale-document overwrite discrimination and core/1.54 plus cloud/1.54 qualification. Backport labels require independent release-target qualification; this source PR alone is not release completion.