Repository navigation
fix(agent): show onboarding after first scoped consent - #19061
Conversation
|
Warning Review paused — included plan limit reachedKeep your review moving with free on-demand reviews.
On-demand reviews are free for the next 13 days.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Promotion and pricing detailsOn-demand reviews are free for the next 13 days. After that, they cost $0.25 per reviewed file. Review limit detailsOr wait 2 minutes for your next included review. Limit details: You’ve used all 8 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2140 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 608e850215a6fcb6cbf95c900573aef322a84b1d
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10 MB gzip 🟢 -596 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.99 MB (baseline 3.99 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 576 kB (baseline 576 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • 🟢 -1.76 kBBundles that do not match a named category
Status: 74 added / 74 removed / 227 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-27T05:20:35.273Z",
"gitSha": "f45137759918470346e245f054ad4be8d06a3453",
"branch": "fix/pm-1308-consent-onboarding",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.7219999999916,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.655000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.927,
"heapDeltaBytes": -2303296,
"heapUsedBytes": 60199976,
"domNodes": -228,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.978,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2016.6309999999612,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.3679999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.768,
"heapDeltaBytes": 10191612,
"heapUsedBytes": 72430888,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.191999999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.3839999999582,
"styleRecalcs": 73,
"styleRecalcDurationMs": 19.022000000000002,
"layouts": 12,
"layoutDurationMs": 5.029,
"taskDurationMs": 889.1650000000001,
"heapDeltaBytes": -4079252,
"heapUsedBytes": 58383624,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 178.53900000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1823.3690000000706,
"styleRecalcs": 71,
"styleRecalcDurationMs": 18.848,
"layouts": 12,
"layoutDurationMs": 4.293,
"taskDurationMs": 857.7970000000001,
"heapDeltaBytes": 19352180,
"heapUsedBytes": 81774544,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 174.78199999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.6470000000418,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.592,
"layouts": 6,
"layoutDurationMs": 1.1350000000000002,
"taskDurationMs": 335.442,
"heapDeltaBytes": 2653560,
"heapUsedBytes": 70166060,
"domNodes": 53,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.495000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.8479999999518,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.34,
"layouts": 6,
"layoutDurationMs": 1.3469999999999998,
"taskDurationMs": 387.16200000000003,
"heapDeltaBytes": 2095476,
"heapUsedBytes": 64619296,
"domNodes": 53,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 15.090999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 711.6070000000718,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.211,
"heapDeltaBytes": 18427804,
"heapUsedBytes": 80848152,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 171.014,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 686.0869999999295,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.4280000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.90400000000005,
"heapDeltaBytes": 19320692,
"heapUsedBytes": 86954036,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 168.10500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1232.15399999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 887.7450000000001,
"heapDeltaBytes": -13663544,
"heapUsedBytes": 72507428,
"domNodes": -259,
"jsHeapTotalBytes": 18743296,
"scriptDurationMs": 71.548,
"eventListeners": -185,
"totalBlockingTimeMs": 581,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1225.108999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 910.8499999999999,
"heapDeltaBytes": -15302848,
"heapUsedBytes": 72575504,
"domNodes": -259,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 68.94699999999997,
"eventListeners": -185,
"totalBlockingTimeMs": 556,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.4920000000261,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.6619999999998,
"heapDeltaBytes": 14437180,
"heapUsedBytes": 91331692,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.22199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 874.3910000000596,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.0450000000003,
"heapDeltaBytes": 14457232,
"heapUsedBytes": 90015912,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.45700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 258,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10055.430999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9195.113,
"heapDeltaBytes": 3145988,
"heapUsedBytes": 86022040,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7781.402999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1402,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11397.776000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10353.913,
"heapDeltaBytes": 7336248,
"heapUsedBytes": 81482516,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 8616.427,
"eventListeners": 0,
"totalBlockingTimeMs": 1605,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10920.818999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9909.798,
"heapDeltaBytes": -1493160,
"heapUsedBytes": 81449472,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8212.321000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 1359,
"frameDurationMs": 20.00000000000006,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10868.070999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9952.273,
"heapDeltaBytes": 5102304,
"heapUsedBytes": 82295988,
"domNodes": -228,
"jsHeapTotalBytes": 2613248,
"scriptDurationMs": 8250.580999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 1257,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2055.7000000000016,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.699999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.6880000000001,
"heapDeltaBytes": -5358108,
"heapUsedBytes": 76162468,
"domNodes": -228,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 33.418000000000006,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.5450000000756,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.907000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.4609999999999,
"heapDeltaBytes": -2180696,
"heapUsedBytes": 79368856,
"domNodes": -228,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 31.502000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2529.922000000056,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.530000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1669.4969999999998,
"heapDeltaBytes": 23169720,
"heapUsedBytes": 87479680,
"domNodes": -228,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 868.0740000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2616.669999999999,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.527999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1667.0620000000001,
"heapDeltaBytes": 3096344,
"heapUsedBytes": 85150040,
"domNodes": -228,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 878.7339999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3662.5909999999067,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.192999999999998,
"layouts": 60,
"layoutDurationMs": 13.914,
"taskDurationMs": 1751.1200000000003,
"heapDeltaBytes": 8180156,
"heapUsedBytes": 74349392,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 814.439,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3733.8600000000497,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.16,
"layouts": 60,
"layoutDurationMs": 14.366,
"taskDurationMs": 1839.141,
"heapDeltaBytes": -15133252,
"heapUsedBytes": 74182576,
"domNodes": -228,
"jsHeapTotalBytes": 6057984,
"scriptDurationMs": 872.181,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3183.172000000013,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.932,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2030.5140000000001,
"heapDeltaBytes": -10366528,
"heapUsedBytes": 75359476,
"domNodes": 0,
"jsHeapTotalBytes": 7593984,
"scriptDurationMs": 1037.541,
"eventListeners": 180,
"totalBlockingTimeMs": 25,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3169.8880000000145,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.957000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1991.225,
"heapDeltaBytes": 25172672,
"heapUsedBytes": 91633124,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1018.5249999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2026.4100000000553,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.723,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.2029999999999,
"heapDeltaBytes": -4508432,
"heapUsedBytes": 83971956,
"domNodes": -228,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 35.486000000000004,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2035.2460000000292,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0550000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.0400000000001,
"heapDeltaBytes": -14034088,
"heapUsedBytes": 73992172,
"domNodes": -228,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 33.266000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 647.685000000024,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.362000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.078,
"heapDeltaBytes": 13838800,
"heapUsedBytes": 77413196,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 156.39600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.4509999999254,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.079,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.26300000000003,
"heapDeltaBytes": 13265296,
"heapUsedBytes": 76972492,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.422,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1991.2780000000794,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.968000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.03000000000003,
"heapDeltaBytes": 5470160,
"heapUsedBytes": 68362152,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.771,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1995.4159999999774,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.932,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.20900000000006,
"heapDeltaBytes": -1030740,
"heapUsedBytes": 61816460,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.627000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.328999999978,
"styleRecalcs": 72,
"styleRecalcDurationMs": 19.423,
"layouts": 16,
"layoutDurationMs": 6.172000000000001,
"taskDurationMs": 805.309,
"heapDeltaBytes": -10534536,
"heapUsedBytes": 59245908,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 118.48799999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.3150000000232,
"styleRecalcs": 73,
"styleRecalcDurationMs": 18.8,
"layouts": 16,
"layoutDurationMs": 6.104,
"taskDurationMs": 806.612,
"heapDeltaBytes": 15024260,
"heapUsedBytes": 78588936,
"domNodes": -244,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 116.479,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.8270000000257,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.303999999999995,
"layouts": 5,
"layoutDurationMs": 12.943999999999997,
"taskDurationMs": 891.7499999999998,
"heapDeltaBytes": -6276368,
"heapUsedBytes": 81601012,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.16200000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9298.823999999968,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.327000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6254.057000000001,
"heapDeltaBytes": 4389444,
"heapUsedBytes": 85817760,
"domNodes": -228,
"jsHeapTotalBytes": -1089536,
"scriptDurationMs": 3020.927,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8941.641000000003,
"styleRecalcs": 249,
"styleRecalcDurationMs": 32.847,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5982.334,
"heapDeltaBytes": 8290572,
"heapUsedBytes": 89797048,
"domNodes": -228,
"jsHeapTotalBytes": 4939776,
"scriptDurationMs": 2878.036,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17154.495999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16705.402,
"heapDeltaBytes": -47855244,
"heapUsedBytes": 177255124,
"domNodes": -8049,
"jsHeapTotalBytes": -14426112,
"scriptDurationMs": 269.505,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16804.74600000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16231.173000000003,
"heapDeltaBytes": -46404512,
"heapUsedBytes": 178668516,
"domNodes": -8049,
"jsHeapTotalBytes": -17047552,
"scriptDurationMs": 251.41599999999997,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20784.428000000047,
"styleRecalcs": 160,
"styleRecalcDurationMs": 17.79,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20587.963000000003,
"heapDeltaBytes": -68070844,
"heapUsedBytes": 169220256,
"domNodes": -8049,
"jsHeapTotalBytes": -16449536,
"scriptDurationMs": 962.485,
"eventListeners": -14923,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21134.29099999996,
"styleRecalcs": 166,
"styleRecalcDurationMs": 17.857000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20857.998000000003,
"heapDeltaBytes": -48925568,
"heapUsedBytes": 169702464,
"domNodes": -8049,
"jsHeapTotalBytes": -18096128,
"scriptDurationMs": 976.884,
"eventListeners": -14923,
"totalBlockingTimeMs": 136,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6155.760999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.86699999999999,
"layouts": 20,
"layoutDurationMs": 23.305999999999994,
"taskDurationMs": 6056.727000000001,
"heapDeltaBytes": -34112656,
"heapUsedBytes": 183786436,
"domNodes": -8049,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 104.46900000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 381,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6160.555000000045,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.349,
"layouts": 20,
"layoutDurationMs": 22.598999999999993,
"taskDurationMs": 6090.796000000001,
"heapDeltaBytes": -41228340,
"heapUsedBytes": 183625656,
"domNodes": -8049,
"jsHeapTotalBytes": 15196160,
"scriptDurationMs": 107.54499999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 427,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8495.938000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8284.311000000002,
"heapDeltaBytes": -5468580,
"heapUsedBytes": 170254904,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 126.50099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8462.467999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8311.839000000002,
"heapDeltaBytes": 14520532,
"heapUsedBytes": 184314460,
"domNodes": 0,
"jsHeapTotalBytes": -21233664,
"scriptDurationMs": 136.18599999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 116.7760000000726,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.305,
"layouts": 4,
"layoutDurationMs": 1.793,
"taskDurationMs": 99.41300000000003,
"heapDeltaBytes": 3331392,
"heapUsedBytes": 65371664,
"domNodes": 99,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.629000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 469.42300000000614,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.663,
"layouts": 4,
"layoutDurationMs": 2.088,
"taskDurationMs": 119.639,
"heapDeltaBytes": 5041052,
"heapUsedBytes": 66870752,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.408000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19061 +/- ##
==========================================
+ Coverage 84.04% 84.95% +0.90%
==========================================
Files 3160 2311 -849
Lines 154583 133265 -21318
Branches 40059 34117 -5942
==========================================
- Hits 129926 113214 -16712
+ Misses 23053 19733 -3320
+ Partials 1604 318 -1286
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 854 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
|
…onsent (#19061) (#19069) Backport of #19061 to `core/1.54`. Manual backport because automation encountered a context-only conflict in `AgentPanelRoot.test.ts`; resolved by retaining the four upstream regression tests in the release branch’s existing onboarding suite. Production code cherry-picked cleanly. Justification: release backport of an already-reviewed and merged fix; validation is delegated to this PR’s exact-branch CI because local dependency installation exhausted the runner disk.
…consent (#19061) (#19070) Backport of #19061 to `cloud/1.54`. Manual backport because automation encountered a context-only conflict in `AgentPanelRoot.test.ts`; resolved by retaining the four upstream regression tests in the release branch’s existing onboarding suite. Production code cherry-picked cleanly. Justification: release backport of an already-reviewed and merged fix; validation is delegated to this PR’s exact-branch CI because local dependency installation exhausted the runner disk.
|
|
|
|
|
|
|
|
|
|
|
|
…onsent (#19061) (#19083) Backport of #19061 to `core/1.55`. The automated backport (label-driven) hit a merge conflict in `AgentPanelRoot.test.ts` because `core/1.55` lacks an unrelated, unbackported feature ("replay tour from header" / the `Take the tour` button) whose test bodies sat as unchanged context around #19061's own new tests in the merge-commit diff. Manually resolved by keeping only the two tests #19061 actually added (`shows the scoped coach after first consent despite a legacy seen flag`, `still carries the legacy seen flag for an already-consented scope`) and dropping the two tests belonging to that unbackported feature, which do not apply here (their target UI, the `Take the tour` button, does not exist on `core/1.55`). Verified on this branch: - `pnpm exec vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts` — 260 passed - `pnpm exec vue-tsc --noEmit` — clean - lint-staged (oxfmt/oxlint/eslint) via commit hook — clean <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729?thread_ts=1789700733.927729&cid=C0BGH348Z0C)_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1 --- _Generated by [Claude Code](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1)_ Co-authored-by: Christian Byrne <cbyrne@comfy.org>
…consent (#19061) (#19084) Backport of #19061 to `cloud/1.55`. Same conflict/resolution as #19083 (the core/1.55 backport): the automated backport hit a merge conflict in `AgentPanelRoot.test.ts` because `cloud/1.55` also lacks the unrelated, unbackported "replay tour from header" (`Take the tour` button) feature whose tests sat as unchanged context around #19061's own new tests in the merge-commit diff. Resolved by keeping only the two tests #19061 actually added and dropping the two tests belonging to that unbackported feature. Verified on this branch: - `pnpm exec vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts` — 260 passed - `pnpm exec vue-tsc --noEmit` — clean - lint-staged (oxfmt/oxlint/eslint) via commit hook — clean <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729?thread_ts=1789700733.927729&cid=C0BGH348Z0C)_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1 --- _Generated by [Claude Code](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1)_ Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Summary
Linear: PM-1301, PM-1308
Replaces the repro-only #18094 with the confirmed fix.
Test plan
pnpm exec vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts(309 passed)pnpm typecheck:appvia pre-commitJustification: narrow state-migration fix with focused regression coverage; requested as part of the PM-1308 thread takeover.