Skip to content

fix(agent): stop retrying a permanently refused CRDT doc subscribe - #18704

Merged
christian-byrne merged 9 commits into
mainfrom
claude/schema-version-mismatch-gate
Sep 28, 2026
Merged

christian-byrne merged 9 commits into
mainfrom
claude/schema-version-mismatch-gate

Conversation

@claude

@claude claude Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Summary

The CRDT doc-subscribe lifecycle retried every doc_subscribed {ok:false} refusal with the same bounded exponential backoff, regardless of the refusal's error code. When the doc-host classifies a resync as schema_version_mismatch (a terminal, permanent refusal for a document this build can never read — the backend half of this landed in cloud#10215), retrying cannot change the outcome, so the frontend kept retrying indefinitely instead of failing fast, and the workflow canvas eventually went stale with no specific explanation.

Changes

  • What: AgentCrdtDocLifecycle.onSubscribeRefused now takes the refusal's error code. schema_version_mismatch latches the same give-up exit an unanswered subscribe ack already times out into (stops the retry loop, reports it once via reportError); every other code keeps the existing bounded-backoff retry unchanged. useAgentCrdtFollower passes the code through and, only for schema_version_mismatch, invokes a new optional onSyncError event so the panel can tell the person their canvas is out of sync. AgentPanelRoot.vue wires that into the existing toast surface.

Review Focus

Confirm the permanent-refusal path (schema_version_mismatch) stays fail-closed (no further retries until a reconnect) while every other refusal code retains its bounded retry — see the new tests in agentCrdtDocLifecycle.test.ts and useAgentCrdtFollower.test.ts.

Related

Testing

  • pnpm exec vitest run src/workbench/extensions/agent/crdt/agentCrdtDocLifecycle.test.ts src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts — 363 passed
  • pnpm typecheck — passed
  • pnpm exec oxlint / pnpm exec eslint / pnpm exec oxfmt --check on changed files — passed (also enforced by the pre-commit hook)
  • pnpm exec knip — no new dead code/exports

Screenshots (if applicable)

Not applicable — the change is a retry/error-code gate plus a toast that reuses the existing toast surface; covered by unit tests.

🤖 Generated with Claude Code

https://claude.ai/code/session_01YLFTHrz4bPiD5ZHomCADTP


Generated by Claude Code

@claude
claude Bot requested a review from a team September 24, 2026 09:06
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 1ba298b8-80b6-4e34-b859-737c09327a21

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2144 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2123 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/28/2026, 02:51:23 AM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 74e47713db1c15ce49aa09733718e242df5e7dc6

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle: 10 MB gzip 🟢 -3.75 kB

Details

Summary

  • Raw size: 42.4 MB baseline 42.4 MB — 🟢 -11.1 kB
  • Gzip: 10 MB baseline 10 MB — 🟢 -3.75 kB
  • Brotli: 7.05 MB baseline 7.05 MB — 🟢 -3.24 kB
  • Bundles: 455 current • 455 baseline • 162 added / 162 removed

Category Glance
Data & Services 🟢 -6.9 kB (4 MB) · Graph Workspace 🟢 -3.29 kB (1.45 MB) · Other 🟢 -905 B (17.9 MB) · Vendor & Third-Party ⚪ 0 B (17.4 MB) · Panels & Settings ⚪ 0 B (639 kB) · Utilities & Hooks ⚪ 0 B (578 kB) · + 5 more

App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-CJx7G6DB.js (removed) 3.77 kB — 🟢 -3.77 kB 🟢 -1.9 kB 🟢 -1.64 kB
assets/index-D8AF1Aaz.js (new) — 3.77 kB 🔴 +3.77 kB 🔴 +1.9 kB 🔴 +1.65 kB

Status: 1 added / 1 removed

Graph Workspace — 1.45 MB (baseline 1.45 MB) • 🟢 -3.29 kB

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-sTPBJHKd.js (removed) 1.44 MB — 🟢 -1.44 MB 🟢 -317 kB 🟢 -237 kB
assets/GraphView-CEMpBKuz.js (new) — 1.44 MB 🔴 +1.44 MB 🔴 +316 kB 🔴 +236 kB
assets/WidgetCompositor-d8ma66oM.js (new) — 8.5 kB 🔴 +8.5 kB 🔴 +2.8 kB 🔴 +2.48 kB
assets/WidgetCompositor-de0w6EOI.js (removed) 8.5 kB — 🟢 -8.5 kB 🟢 -2.8 kB 🟢 -2.48 kB

Status: 2 added / 2 removed / 1 unchanged

Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-4d-yHFEj.js (new) — 26.7 kB 🔴 +26.7 kB 🔴 +6.7 kB 🔴 +5.93 kB
assets/CloudSurveyView-rPlc2tY-.js (removed) 26.7 kB — 🟢 -26.7 kB 🟢 -6.7 kB 🟢 -5.93 kB
assets/CloudLayoutView-BLh_kWAN.js (removed) 21.7 kB — 🟢 -21.7 kB 🟢 -6.56 kB 🟢 -5.74 kB
assets/CloudLayoutView-DTVtbi5W.js (new) — 21.7 kB 🔴 +21.7 kB 🔴 +6.56 kB 🔴 +5.73 kB
assets/useCloudAuthPage-CgdF1HJf.js (new) — 11 kB 🔴 +11 kB 🔴 +4.18 kB 🔴 +3.54 kB
assets/useCloudAuthPage-DHv881t7.js (removed) 11 kB — 🟢 -11 kB 🟢 -4.18 kB 🟢 -3.55 kB
assets/CloudLoginView-fiQSWsXa.js (removed) 8.79 kB — 🟢 -8.79 kB 🟢 -2.57 kB 🟢 -2.28 kB
assets/CloudLoginView-XlDo93t2.js (new) — 8.79 kB 🔴 +8.79 kB 🔴 +2.57 kB 🔴 +2.27 kB
assets/UserCheckView-B5qnaN7p.js (new) — 8.6 kB 🔴 +8.6 kB 🔴 +2.17 kB 🔴 +1.9 kB
assets/UserCheckView-CNcoCuty.js (removed) 8.6 kB — 🟢 -8.6 kB 🟢 -2.18 kB 🟢 -1.9 kB
assets/CloudSignupView-BR3mLrm6.js (removed) 6.98 kB — 🟢 -6.98 kB 🟢 -2.28 kB 🟢 -2 kB
assets/CloudSignupView-CvJNbZyT.js (new) — 6.98 kB 🔴 +6.98 kB 🔴 +2.28 kB 🔴 +1.99 kB
assets/WidgetTextPreview-B2Z28O3M.js (removed) 6.06 kB — 🟢 -6.06 kB 🟢 -2.13 kB 🟢 -1.9 kB
assets/WidgetTextPreview-CDYKN9he.js (new) — 6.06 kB 🔴 +6.06 kB 🔴 +2.13 kB 🔴 +1.89 kB
assets/CloudSubscriptionRedirectView-Cqd8Re6n.js (removed) 5.67 kB — 🟢 -5.67 kB 🟢 -1.92 kB 🟢 -1.69 kB
assets/CloudSubscriptionRedirectView-D2OxO4VR.js (new) — 5.67 kB 🔴 +5.67 kB 🔴 +1.92 kB 🔴 +1.69 kB
assets/UserSelectView-Dbk4pS_l.js (new) — 5.64 kB 🔴 +5.64 kB 🔴 +2 kB 🔴 +1.75 kB
assets/UserSelectView-Ico5yIgt.js (removed) 5.64 kB — 🟢 -5.64 kB 🟢 -2 kB 🟢 -1.75 kB
assets/CloudForgotPasswordView-BacLaZvP.js (removed) 5.04 kB — 🟢 -5.04 kB 🟢 -1.73 kB 🟢 -1.51 kB
assets/CloudForgotPasswordView-CwngJnnM.js (new) — 5.04 kB 🔴 +5.04 kB 🔴 +1.73 kB 🔴 +1.5 kB
assets/CloudAuthTimeoutView-BFsgpIVC.js (removed) 4.43 kB — 🟢 -4.43 kB 🟢 -1.54 kB 🟢 -1.33 kB
assets/CloudAuthTimeoutView-DvAZgRTF.js (new) — 4.43 kB 🔴 +4.43 kB 🔴 +1.54 kB 🔴 +1.34 kB
assets/WidgetResolutionPreview-D4xSoUe6.js (new) — 3.78 kB 🔴 +3.78 kB 🔴 +1.49 kB 🔴 +1.33 kB
assets/WidgetResolutionPreview-DRX9H0GP.js (removed) 3.78 kB — 🟢 -3.78 kB 🟢 -1.49 kB 🟢 -1.33 kB
assets/OAuthLayoutView-ex1OdmE4.js (removed) 1.32 kB — 🟢 -1.32 kB 🟢 -707 B 🟢 -596 B
assets/OAuthLayoutView-KursqUaN.js (new) — 1.32 kB 🔴 +1.32 kB 🔴 +707 B 🔴 +595 B
assets/WidgetTextPreview-C66XNzHD.js (removed) 131 B — 🟢 -131 B 🟢 -100 B 🟢 -91 B
assets/WidgetTextPreview-D0CKc-lE.js (new) — 131 B 🔴 +131 B 🔴 +100 B 🔴 +89 B

Status: 14 added / 14 removed / 4 unchanged

Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-BgQrVhNN.js (removed) 49.9 kB — 🟢 -49.9 kB 🟢 -10.1 kB 🟢 -8.93 kB
assets/KeybindingPanel-DM7QaNAy.js (new) — 49.9 kB 🔴 +49.9 kB 🔴 +10.1 kB 🔴 +8.94 kB
assets/CreditsPanel-BO8-ptG7.js (new) — 39.5 kB 🔴 +39.5 kB 🔴 +9.56 kB 🔴 +8.38 kB
assets/CreditsPanel-DpfAlRvq.js (removed) 39.5 kB — 🟢 -39.5 kB 🟢 -9.56 kB 🟢 -8.39 kB
assets/SecretsPanel-B84cCMzO.js (new) — 33.9 kB 🔴 +33.9 kB 🔴 +7.89 kB 🔴 +6.92 kB
assets/SecretsPanel-CjFb7cgp.js (removed) 33.9 kB — 🟢 -33.9 kB 🟢 -7.89 kB 🟢 -6.94 kB
assets/AboutPanel-Dk1ZUHyM.js (removed) 11.4 kB — 🟢 -11.4 kB 🟢 -3.15 kB 🟢 -2.82 kB
assets/AboutPanel-ZmR2urzq.js (new) — 11.4 kB 🔴 +11.4 kB 🔴 +3.14 kB 🔴 +2.82 kB
assets/ExtensionPanel-BxhIS7Xc.js (removed) 9.31 kB — 🟢 -9.31 kB 🟢 -2.51 kB 🟢 -2.23 kB
assets/ExtensionPanel-CGc-tEsh.js (new) — 9.31 kB 🔴 +9.31 kB 🔴 +2.51 kB 🔴 +2.23 kB
assets/ServerConfigPanel-CjpFb1zh.js (removed) 6.11 kB — 🟢 -6.11 kB 🟢 -1.94 kB 🟢 -1.72 kB
assets/ServerConfigPanel-oF-ypgqZ.js (new) — 6.11 kB 🔴 +6.11 kB 🔴 +1.94 kB 🔴 +1.72 kB
assets/UserPanel-CtyaAPMd.js (new) — 5.72 kB 🔴 +5.72 kB 🔴 +1.77 kB 🔴 +1.53 kB
assets/UserPanel-DoRuQwTf.js (removed) 5.72 kB — 🟢 -5.72 kB 🟢 -1.77 kB 🟢 -1.53 kB
assets/refreshRemoteConfig-CN4Z_GSl.js (removed) 4.6 kB — 🟢 -4.6 kB 🟢 -1.62 kB 🟢 -1.44 kB
assets/refreshRemoteConfig-DoKeX2EE.js (new) — 4.6 kB 🔴 +4.6 kB 🔴 +1.62 kB 🔴 +1.44 kB
assets/CreditsPanel-D5g29TUt.js (new) — 116 B 🔴 +116 B 🔴 +95 B 🔴 +85 B
assets/CreditsPanel-mUvfJ1Uv.js (removed) 116 B — 🟢 -116 B 🟢 -95 B 🟢 -90 B
assets/refreshRemoteConfig-BFlsNJl7.js (new) — 110 B 🔴 +110 B 🔴 +89 B 🔴 +92 B
assets/refreshRemoteConfig-DN5O3r2E.js (removed) 110 B — 🟢 -110 B 🟢 -89 B 🟢 -83 B

Status: 10 added / 10 removed / 18 unchanged

User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/SignUpForm-DEN_UTif.js (new) — 21.4 kB 🔴 +21.4 kB 🔴 +7.07 kB 🔴 +6.09 kB
assets/SignUpForm-HnA3zwlZ.js (removed) 21.4 kB — 🟢 -21.4 kB 🟢 -7.07 kB 🟢 -6.1 kB
assets/PasswordFields-BJVAx4vJ.js (new) — 6.15 kB 🔴 +6.15 kB 🔴 +1.85 kB 🔴 +1.62 kB
assets/PasswordFields-DuF_cUAx.js (removed) 6.15 kB — 🟢 -6.15 kB 🟢 -1.85 kB 🟢 -1.61 kB
assets/auth-daeRVKjP.js (new) — 4.91 kB 🔴 +4.91 kB 🔴 +1.64 kB 🔴 +1.39 kB
assets/auth-Y3z7d2ZG.js (removed) 4.91 kB — 🟢 -4.91 kB 🟢 -1.64 kB 🟢 -1.39 kB
assets/UpdatePasswordContent-fcbjpBSI.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -842 B 🟢 -735 B
assets/UpdatePasswordContent-gojGROfJ.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +842 B 🔴 +733 B
assets/authStore-Bt6x9CGq.js (new) — 126 B 🔴 +126 B 🔴 +103 B 🔴 +104 B
assets/authStore-DNRK1IvY.js (removed) 126 B — 🟢 -126 B 🟢 -103 B 🟢 -105 B
assets/workspaceAuthStore-DGkjim09.js (removed) 108 B — 🟢 -108 B 🟢 -99 B 🟢 -111 B
assets/workspaceAuthStore-qe_6cell.js (new) — 108 B 🔴 +108 B 🔴 +99 B 🔴 +103 B
assets/auth-DU6ua26M.js (new) — 105 B 🔴 +105 B 🔴 +96 B 🔴 +89 B
assets/auth-HHS7wP1R.js (removed) 105 B — 🟢 -105 B 🟢 -96 B 🟢 -81 B

Status: 7 added / 7 removed / 4 unchanged

Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-D0RLPtj4.js (removed) 90.8 kB — 🟢 -90.8 kB 🟢 -19.3 kB 🟢 -16.5 kB
assets/ComfyHubPublishDialog-QSX7rtr-.js (new) — 90.8 kB 🔴 +90.8 kB 🔴 +19.3 kB 🔴 +16.5 kB
assets/useShareDialog-CZYfecZh.js (new) — 23.9 kB 🔴 +23.9 kB 🔴 +5.73 kB 🔴 +5.08 kB
assets/useShareDialog-DYj53p7S.js (removed) 23.9 kB — 🟢 -23.9 kB 🟢 -5.73 kB 🟢 -5.07 kB
assets/feedbackDialog-BgwPIAwW.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.87 kB 🟢 -1.59 kB
assets/feedbackDialog-BOJ8ii3j.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.86 kB 🔴 +1.59 kB
assets/useRangeEditor-DYsi6x5Q.js (removed) 3.29 kB — 🟢 -3.29 kB 🟢 -1.14 kB 🟢 -1.04 kB
assets/useRangeEditor-Iua4Ki9n.js (new) — 3.29 kB 🔴 +3.29 kB 🔴 +1.14 kB 🔴 +1.03 kB
assets/useLayerEditor-Dr44giSl.js (new) — 1.19 kB 🔴 +1.19 kB 🔴 +563 B 🔴 +516 B
assets/useLayerEditor-GPNzDf49.js (removed) 1.19 kB — 🟢 -1.19 kB 🟢 -563 B 🟢 -490 B
assets/ComfyHubPublishDialog-83SLiGpQ.js (new) — 143 B 🔴 +143 B 🔴 +105 B 🔴 +89 B
assets/ComfyHubPublishDialog-D-x9LIt8.js (removed) 143 B — 🟢 -143 B 🟢 -105 B 🟢 -92 B
assets/useSubscriptionDialog-BWU9_FNA.js (removed) 107 B — 🟢 -107 B 🟢 -101 B 🟢 -85 B
assets/useSubscriptionDialog-CwdvTMlz.js (new) — 107 B 🔴 +107 B 🔴 +101 B 🔴 +97 B

Status: 7 added / 7 removed / 1 unchanged

UI Components — 125 kB (baseline 125 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useMoreOptionsMenu-50VuNBmR.js (new) — 48 kB 🔴 +48 kB 🔴 +11.6 kB 🔴 +10 kB
assets/useMoreOptionsMenu-DkKK1kqS.js (removed) 48 kB — 🟢 -48 kB 🟢 -11.6 kB 🟢 -10 kB
assets/ComfyQueueButton-CWAAzOdK.js (new) — 13.7 kB 🔴 +13.7 kB 🔴 +3.7 kB 🔴 +3.29 kB
assets/ComfyQueueButton-VEKQRB1t.js (removed) 13.7 kB — 🟢 -13.7 kB 🟢 -3.7 kB 🟢 -3.29 kB
assets/useTerminalTabs-BFSRIMxS.js (new) — 11.8 kB 🔴 +11.8 kB 🔴 +3.7 kB 🔴 +3.29 kB
assets/useTerminalTabs-CKVpW35f.js (removed) 11.8 kB — 🟢 -11.8 kB 🟢 -3.7 kB 🟢 -3.29 kB
assets/InviteMembersForm-B4x3ABFG.js (new) — 10.5 kB 🔴 +10.5 kB 🔴 +3.15 kB 🔴 +2.82 kB
assets/InviteMembersForm-DoEgN49v.js (removed) 10.5 kB — 🟢 -10.5 kB 🟢 -3.15 kB 🟢 -2.8 kB
assets/SubscribeButton-C6dhOnxF.js (new) — 2.15 kB 🔴 +2.15 kB 🔴 +968 B 🔴 +849 B
assets/SubscribeButton-sZEUEu9i.js (removed) 2.15 kB — 🟢 -2.15 kB 🟢 -969 B 🟢 -848 B
assets/cloudFeedbackTopbarButton-BhUtLvyc.js (new) — 701 B 🔴 +701 B 🔴 +420 B 🔴 +379 B
assets/cloudFeedbackTopbarButton-D5Cia7pi.js (removed) 701 B — 🟢 -701 B 🟢 -421 B 🟢 -373 B
assets/ComfyQueueButton-Bd4UFSWK.js (new) — 128 B 🔴 +128 B 🔴 +99 B 🔴 +92 B
assets/ComfyQueueButton-C0hayMyi.js (removed) 128 B — 🟢 -128 B 🟢 -99 B 🟢 -90 B

Status: 7 added / 7 removed / 9 unchanged

Data & Services — 4 MB (baseline 4.01 MB) • 🟢 -6.9 kB

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/settingStore-DhgXtKY1.js (removed) 3.7 MB — 🟢 -3.7 MB 🟢 -886 kB 🟢 -667 kB
assets/settingStore-BiYUyYKM.js (new) — 3.7 MB 🔴 +3.7 MB 🔴 +884 kB 🔴 +665 kB
assets/api-D5YVlHXk.js (removed) 161 kB — 🟢 -161 kB 🟢 -37.6 kB 🟢 -31.8 kB
assets/api-oYlbwIT3.js (new) — 161 kB 🔴 +161 kB 🔴 +37.6 kB 🔴 +31.8 kB
assets/load3dService-Daz8JVVR.js (new) — 87.3 kB 🔴 +87.3 kB 🔴 +20.4 kB 🔴 +17.6 kB
assets/load3dService-DEBFt0HI.js (removed) 87.3 kB — 🟢 -87.3 kB 🟢 -20.4 kB 🟢 -17.7 kB
assets/releaseStore-BAule5oL.js (new) — 24.9 kB 🔴 +24.9 kB 🔴 +7.39 kB 🔴 +6.49 kB
assets/releaseStore-Dlz8Jaf6.js (removed) 24.9 kB — 🟢 -24.9 kB 🟢 -7.39 kB 🟢 -6.5 kB
assets/workflowShareService-Cql9JOle.js (new) — 17.2 kB 🔴 +17.2 kB 🔴 +5.12 kB 🔴 +4.53 kB
assets/workflowShareService-w4yfaN53.js (removed) 17.2 kB — 🟢 -17.2 kB 🟢 -5.12 kB 🟢 -4.53 kB
assets/userStore-Bar-FAGF.js (removed) 5.47 kB — 🟢 -5.47 kB 🟢 -2.02 kB 🟢 -1.81 kB
assets/userStore-DsrRbsyO.js (new) — 5.47 kB 🔴 +5.47 kB 🔴 +2.02 kB 🔴 +1.81 kB
assets/audioService-BNtND1E1.js (new) — 1.71 kB 🔴 +1.71 kB 🔴 +828 B 🔴 +723 B
assets/audioService-CueEnRWN.js (removed) 1.71 kB — 🟢 -1.71 kB 🟢 -830 B 🟢 -724 B
assets/dialogService-BgrBLdKM.js (new) — 97 B 🔴 +97 B 🔴 +96 B 🔴 +96 B
assets/dialogService-c8IdMft9.js (removed) 97 B — 🟢 -97 B 🟢 -96 B 🟢 -80 B
assets/releaseStore-DmR4Y5oB.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +90 B
assets/releaseStore-DO2qrOTs.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -85 B
assets/settingStore-C8cLT3P3.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +84 B
assets/settingStore-k0axTpbs.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -82 B
assets/assetsStore-BB7lP2FB.js (new) — 94 B 🔴 +94 B 🔴 +92 B 🔴 +85 B
assets/assetsStore-DAwJqOtD.js (removed) 94 B — 🟢 -94 B 🟢 -92 B 🟢 -87 B
assets/api-CQ20R2GC.js (new) — 62 B 🔴 +62 B 🔴 +74 B 🔴 +66 B
assets/api-CUwGLwT8.js (removed) 62 B — 🟢 -62 B 🟢 -74 B 🟢 -66 B

Status: 12 added / 12 removed / 3 unchanged

Utilities & Hooks — 578 kB (baseline 578 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-CRlX6rlU.js (new) — 246 kB 🔴 +246 kB 🔴 +55.7 kB 🔴 +45.4 kB
assets/useConflictDetection-hTa3DDl9.js (removed) 246 kB — 🟢 -246 kB 🟢 -55.7 kB 🟢 -45.4 kB
assets/useLayerEditorSession-D1BtbGKU.js (new) — 159 kB 🔴 +159 kB 🔴 +41 kB 🔴 +34.5 kB
assets/useLayerEditorSession-DOctqhbq.js (removed) 159 kB — 🟢 -159 kB 🟢 -41 kB 🟢 -34.5 kB
assets/useLoad3d-BcWqGNVy.js (new) — 26.6 kB 🔴 +26.6 kB 🔴 +6.03 kB 🔴 +5.33 kB
assets/useLoad3d-jF4kIjV_.js (removed) 26.6 kB — 🟢 -26.6 kB 🟢 -6.03 kB 🟢 -5.33 kB
assets/useLoad3dViewer-B7cu_ZJj.js (new) — 21.9 kB 🔴 +21.9 kB 🔴 +5.25 kB 🔴 +4.6 kB
assets/useLoad3dViewer-CMKduVrH.js (removed) 21.9 kB — 🟢 -21.9 kB 🟢 -5.25 kB 🟢 -4.61 kB
assets/useImageCrop-Cm2YiDwy.js (new) — 15.3 kB 🔴 +15.3 kB 🔴 +3.54 kB 🔴 +3.08 kB
assets/useImageCrop-CWO2bWES.js (removed) 15.3 kB — 🟢 -15.3 kB 🟢 -3.54 kB 🟢 -3.08 kB
assets/useFeatureFlags-BRp5xh5e.js (removed) 11.7 kB — 🟢 -11.7 kB 🟢 -3.48 kB 🟢 -2.93 kB
assets/useFeatureFlags-D6G_dE4I.js (new) — 11.7 kB 🔴 +11.7 kB 🔴 +3.48 kB 🔴 +2.93 kB
assets/useDowngradeToPersonal-CO7yVUa-.js (new) — 11 kB 🔴 +11 kB 🔴 +2.78 kB 🔴 +2.39 kB
assets/useDowngradeToPersonal-DafgZUh5.js (removed) 11 kB — 🟢 -11 kB 🟢 -2.78 kB 🟢 -2.39 kB
assets/useExternalLink-nizK1Wan.js (removed) 10.2 kB — 🟢 -10.2 kB 🟢 -3.51 kB 🟢 -3.04 kB
assets/useExternalLink-RrYpwIfk.js (new) — 10.2 kB 🔴 +10.2 kB 🔴 +3.5 kB 🔴 +3.04 kB
assets/usePricingTableUrlLoader-CU9-xWS9.js (new) — 4.81 kB 🔴 +4.81 kB 🔴 +1.66 kB 🔴 +1.42 kB
assets/usePricingTableUrlLoader-lhn0PGg7.js (removed) 4.81 kB — 🟢 -4.81 kB 🟢 -1.66 kB 🟢 -1.41 kB
assets/downloadUtil-s_0WuXct.js (new) — 3.67 kB 🔴 +3.67 kB 🔴 +1.41 kB 🔴 +1.15 kB
assets/downloadUtil-zMR6YsJk.js (removed) 3.67 kB — 🟢 -3.67 kB 🟢 -1.41 kB 🟢 -1.17 kB
assets/useCompositorLayers-DnWVNxfv.js (removed) 2.93 kB — 🟢 -2.93 kB 🟢 -861 B 🟢 -780 B
assets/useCompositorLayers-rw6uBlVH.js (new) — 2.93 kB 🔴 +2.93 kB 🔴 +860 B 🔴 +780 B
assets/useScheduledPlanChange-FNKprUIq.js (new) — 2.4 kB 🔴 +2.4 kB 🔴 +960 B 🔴 +835 B
assets/useScheduledPlanChange-ZSi2iQtE.js (removed) 2.4 kB — 🟢 -2.4 kB 🟢 -962 B 🟢 -835 B
assets/useUpstreamValue-BiHud0l0.js (new) — 1.97 kB 🔴 +1.97 kB 🔴 +753 B 🔴 +663 B
assets/useUpstreamValue-CsSLYUBp.js (removed) 1.97 kB — 🟢 -1.97 kB 🟢 -752 B 🟢 -663 B
assets/useWorkspaceTierLabel-BfwoaE5j.js (removed) 1.97 kB — 🟢 -1.97 kB 🟢 -843 B 🟢 -711 B
assets/useWorkspaceTierLabel-D1Fgrx9t.js (new) — 1.97 kB 🔴 +1.97 kB 🔴 +843 B 🔴 +714 B
assets/useSessionCookie-BlYXSDcU.js (new) — 688 B 🔴 +688 B 🔴 +354 B 🔴 +308 B
assets/useSessionCookie-C1o9bzkX.js (removed) 688 B — 🟢 -688 B 🟢 -354 B 🟢 -307 B
assets/useLoad3d--JhcApR9.js (new) — 364 B 🔴 +364 B 🔴 +180 B 🔴 +158 B
assets/useLoad3d-BDPOdbXh.js (removed) 364 B — 🟢 -364 B 🟢 -180 B 🟢 -158 B
assets/useSessionCookie-B68FMXwK.js (new) — 101 B 🔴 +101 B 🔴 +86 B 🔴 +81 B
assets/useSessionCookie-CwFwnhiB.js (removed) 101 B — 🟢 -101 B 🟢 -86 B 🟢 -80 B
assets/useFeatureFlags-CmxFtoyQ.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +82 B
assets/useFeatureFlags-sI_w46EK.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -86 B
assets/useLoad3dViewer-Cw3_AKs2.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +91 B
assets/useLoad3dViewer-D3hfuaoY.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -82 B
assets/useCurrentUser-CWaCX4fP.js (new) — 93 B 🔴 +93 B 🔴 +94 B 🔴 +87 B
assets/useCurrentUser-QfqHPQ7r.js (removed) 93 B — 🟢 -93 B 🟢 -94 B 🟢 -85 B

Status: 20 added / 20 removed / 16 unchanged

Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 17.9 MB (baseline 17.9 MB) • 🟢 -905 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/main-DiN-PA6s.js (new) — 230 kB 🔴 +230 kB 🔴 +67.3 kB 🔴 +56.4 kB
assets/main-CjUEfefF.js (removed) 230 kB — 🟢 -230 kB 🟢 -67.2 kB 🟢 -56.3 kB
assets/core-WDodna-O.js (removed) 119 kB — 🟢 -119 kB 🟢 -31.6 kB 🟢 -26.7 kB
assets/core-dEQJG-bA.js (new) — 118 kB 🔴 +118 kB 🔴 +31.2 kB 🔴 +26.3 kB
assets/WorkspaceSettingsPanelContent-D85oJ1sS.js (removed) 116 kB — 🟢 -116 kB 🟢 -22.8 kB 🟢 -18.9 kB
assets/WorkspaceSettingsPanelContent-DRuGg0zf.js (new) — 116 kB 🔴 +116 kB 🔴 +22.8 kB 🔴 +18.9 kB
assets/SubscriptionTransitionPreviewWorkspace-DkTKEM8j.js (new) — 115 kB 🔴 +115 kB 🔴 +22.9 kB 🔴 +19.4 kB
assets/SubscriptionTransitionPreviewWorkspace-DnMfi8iM.js (removed) 115 kB — 🟢 -115 kB 🟢 -22.9 kB 🟢 -19.4 kB
assets/WidgetSelect-BYR9OZQp.js (removed) 89.2 kB — 🟢 -89.2 kB 🟢 -20.3 kB 🟢 -17.3 kB
assets/WidgetSelect-CtkXyyzS.js (new) — 89.2 kB 🔴 +89.2 kB 🔴 +20.3 kB 🔴 +17.3 kB
assets/Load3D-C7LETC-n.js (new) — 82.4 kB 🔴 +82.4 kB 🔴 +13.6 kB 🔴 +11.4 kB
assets/Load3D-jmQZno7B.js (removed) 82.4 kB — 🟢 -82.4 kB 🟢 -13.6 kB 🟢 -11.5 kB
assets/WidgetVideoEdit-CThWCBLq.js (new) — 74.3 kB 🔴 +74.3 kB 🔴 +17.7 kB 🔴 +15.5 kB
assets/WidgetVideoEdit-DcdnsiVc.js (removed) 74.3 kB — 🟢 -74.3 kB 🟢 -17.7 kB 🟢 -15.5 kB
assets/CameraInfo-BnxqaFje.js (new) — 67.3 kB 🔴 +67.3 kB 🔴 +14.6 kB 🔴 +12.9 kB
assets/CameraInfo-DoB0v4Ha.js (removed) 67.3 kB — 🟢 -67.3 kB 🟢 -14.6 kB 🟢 -12.8 kB
assets/Preview3d-1aowBCT1.js (new) — 52.6 kB 🔴 +52.6 kB 🔴 +8.6 kB 🔴 +7.51 kB
assets/Preview3d-9rI-H1NU.js (removed) 52.6 kB — 🟢 -52.6 kB 🟢 -8.6 kB 🟢 -7.5 kB
assets/SubscriptionRequiredDialogContentUnified-BbNqzO_A.js (new) — 52.4 kB 🔴 +52.4 kB 🔴 +11 kB 🔴 +9.65 kB
assets/SubscriptionRequiredDialogContentUnified-DghEDwJA.js (removed) 52.4 kB — 🟢 -52.4 kB 🟢 -11 kB 🟢 -9.65 kB
assets/Viewport3d-C4Ul1aRz.js (removed) 47.7 kB — 🟢 -47.7 kB 🟢 -10.2 kB 🟢 -9.04 kB
assets/Viewport3d-UMRcDn3v.js (new) — 47.7 kB 🔴 +47.7 kB 🔴 +10.2 kB 🔴 +9.04 kB
assets/main-B7-QqJNw.js (new) — 46.7 kB 🔴 +46.7 kB 🔴 +14 kB 🔴 +12 kB
assets/main-DZ8ogqwb.js (removed) 46.7 kB — 🟢 -46.7 kB 🟢 -14 kB 🟢 -12.1 kB
assets/LayerEditorContent-CySJMoEG.js (removed) 45.4 kB — 🟢 -45.4 kB 🟢 -10.6 kB 🟢 -9.26 kB
assets/LayerEditorContent-DmNdhGBm.js (new) — 45.4 kB 🔴 +45.4 kB 🔴 +10.6 kB 🔴 +9.26 kB
assets/WidgetBoundingBoxes-Bbb4YQbb.js (new) — 33.8 kB 🔴 +33.8 kB 🔴 +9.17 kB 🔴 +8.13 kB
assets/WidgetBoundingBoxes-T0mSBOiU.js (removed) 33.8 kB — 🟢 -33.8 kB 🟢 -9.17 kB 🟢 -8.13 kB
assets/WidgetPainter-DbHWmAI1.js (removed) 32.1 kB — 🟢 -32.1 kB 🟢 -7.88 kB 🟢 -6.97 kB
assets/WidgetPainter-dLg3hGr0.js (new) — 32.1 kB 🔴 +32.1 kB 🔴 +7.88 kB 🔴 +6.96 kB
assets/Load3dViewerContent-BzHZhRyZ.js (removed) 30.6 kB — 🟢 -30.6 kB 🟢 -6.21 kB 🟢 -5.37 kB
assets/Load3dViewerContent-DozV1mef.js (new) — 30.6 kB 🔴 +30.6 kB 🔴 +6.21 kB 🔴 +5.37 kB
assets/HdrViewerContent-BpnFWFDh.js (removed) 29.8 kB — 🟢 -29.8 kB 🟢 -8.26 kB 🟢 -7.28 kB
assets/HdrViewerContent-CJ3qox4e.js (new) — 29.8 kB 🔴 +29.8 kB 🔴 +8.26 kB 🔴 +7.28 kB
assets/SubscriptionRequiredDialogContent-BSslTeoW.js (new) — 27.2 kB 🔴 +27.2 kB 🔴 +6.38 kB 🔴 +5.62 kB
assets/SubscriptionRequiredDialogContent-EfCnXrgp.js (removed) 27.2 kB — 🟢 -27.2 kB 🟢 -6.39 kB 🟢 -5.63 kB
assets/SubscriptionRequiredDialogContentWorkspace-BFHTX9RA.js (removed) 26.5 kB — 🟢 -26.5 kB 🟢 -6.08 kB 🟢 -5.37 kB
assets/SubscriptionRequiredDialogContentWorkspace-CrWGF5fY.js (new) — 26.5 kB 🔴 +26.5 kB 🔴 +6.08 kB 🔴 +5.36 kB
assets/load3d-C3H3Qeoq.js (removed) 22.8 kB — 🟢 -22.8 kB 🟢 -5.64 kB 🟢 -4.89 kB
assets/load3d-uQMIz9tb.js (new) — 22.8 kB 🔴 +22.8 kB 🔴 +5.63 kB 🔴 +4.88 kB
assets/SignInContent-7eLjA52P.js (new) — 21 kB 🔴 +21 kB 🔴 +5.32 kB 🔴 +4.66 kB
assets/SignInContent-ChhQThBF.js (removed) 21 kB — 🟢 -21 kB 🟢 -5.32 kB 🟢 -4.65 kB
assets/CurrentUserPopoverWorkspace-r2iDWRCG.js (removed) 18 kB — 🟢 -18 kB 🟢 -4.23 kB 🟢 -3.75 kB
assets/CurrentUserPopoverWorkspace-sUHHLeic.js (new) — 18 kB 🔴 +18 kB 🔴 +4.23 kB 🔴 +3.74 kB
assets/i18n-D-t_bkMv.js (new) — 17.1 kB 🔴 +17.1 kB 🔴 +4.61 kB 🔴 +3.86 kB
assets/i18n-D8gDP6gJ.js (removed) 17.1 kB — 🟢 -17.1 kB 🟢 -4.61 kB 🟢 -3.87 kB
assets/WidgetRecordAudio-OaGFy5Zh.js (new) — 16.5 kB 🔴 +16.5 kB 🔴 +4.59 kB 🔴 +4.11 kB
assets/WidgetRecordAudio-XXPjZpxx.js (removed) 16.5 kB — 🟢 -16.5 kB 🟢 -4.59 kB 🟢 -4.09 kB
assets/WidgetInputNumber-D6FD5chU.js (removed) 13.9 kB — 🟢 -13.9 kB 🟢 -3.63 kB 🟢 -3.21 kB
assets/WidgetInputNumber-h7pnvJJk.js (new) — 13.9 kB 🔴 +13.9 kB 🔴 +3.63 kB 🔴 +3.21 kB
assets/WidgetRange-CddETCTw.js (new) — 13.7 kB 🔴 +13.7 kB 🔴 +3.55 kB 🔴 +3.13 kB
assets/WidgetRange-CijW4MY7.js (removed) 13.7 kB — 🟢 -13.7 kB 🟢 -3.55 kB 🟢 -3.13 kB
assets/WaveAudioPlayer-C6xBLMvd.js (new) — 13.6 kB 🔴 +13.6 kB 🔴 +3.62 kB 🔴 +3.18 kB
assets/WaveAudioPlayer-CTJ4XFBI.js (removed) 13.6 kB — 🟢 -13.6 kB 🟢 -3.63 kB 🟢 -3.18 kB
assets/WidgetCurve--8cZN8HE.js (removed) 11.2 kB — 🟢 -11.2 kB 🟢 -3.48 kB 🟢 -3.16 kB
assets/WidgetCurve-DAM7dWsc.js (new) — 11.2 kB 🔴 +11.2 kB 🔴 +3.48 kB 🔴 +3.14 kB
assets/AudioPreviewPlayer-CSH6Wmmb.js (removed) 10.6 kB — 🟢 -10.6 kB 🟢 -3.05 kB 🟢 -2.72 kB
assets/AudioPreviewPlayer-D3959aSq.js (new) — 10.6 kB 🔴 +10.6 kB 🔴 +3.04 kB 🔴 +2.72 kB
assets/TeamWorkspacesDialogContent-BzjeZAfN.js (new) — 10.4 kB 🔴 +10.4 kB 🔴 +2.99 kB 🔴 +2.64 kB
assets/TeamWorkspacesDialogContent-CT0sUp3G.js (removed) 10.4 kB — 🟢 -10.4 kB 🟢 -2.99 kB 🟢 -2.64 kB
assets/onboardingCloudRoutes-C0TwdoqE.js (removed) 9.93 kB — 🟢 -9.93 kB 🟢 -2.82 kB 🟢 -2.42 kB
assets/onboardingCloudRoutes-CQoc2Wl1.js (new) — 9.93 kB 🔴 +9.93 kB 🔴 +2.81 kB 🔴 +2.41 kB
assets/InviteMemberDialogContent-BKQ_z_-M.js (new) — 9.64 kB 🔴 +9.64 kB 🔴 +2.86 kB 🔴 +2.55 kB
assets/InviteMemberDialogContent-C6AFhYWd.js (removed) 9.64 kB — 🟢 -9.64 kB 🟢 -2.86 kB 🟢 -2.56 kB
assets/WidgetImageCompare-Bat-1rfM.js (new) — 9.41 kB 🔴 +9.41 kB 🔴 +2.85 kB 🔴 +2.53 kB
assets/WidgetImageCompare-CAV03FpD.js (removed) 9.41 kB — 🟢 -9.41 kB 🟢 -2.85 kB 🟢 -2.53 kB
assets/nodeTemplates-axslCWgb.js (removed) 8.63 kB — 🟢 -8.63 kB 🟢 -2.97 kB 🟢 -2.62 kB
assets/nodeTemplates-q1uoreYh.js (new) — 8.63 kB 🔴 +8.63 kB 🔴 +2.97 kB 🔴 +2.61 kB
assets/WidgetImageCrop-B5bJilvW.js (removed) 8.49 kB — 🟢 -8.49 kB 🟢 -2.66 kB 🟢 -2.34 kB
assets/WidgetImageCrop-oC09uJOu.js (new) — 8.49 kB 🔴 +8.49 kB 🔴 +2.65 kB 🔴 +2.36 kB
assets/SetMemberCreditLimitDialogContent-BZ2UYYB7.js (new) — 8.47 kB 🔴 +8.47 kB 🔴 +2.34 kB 🔴 +2.05 kB
assets/SetMemberCreditLimitDialogContent-D5DdfE-1.js (removed) 8.47 kB — 🟢 -8.47 kB 🟢 -2.34 kB 🟢 -2.06 kB
assets/CloudRunButtonWrapper-BB7YNEHG.js (removed) 8.11 kB — 🟢 -8.11 kB 🟢 -2.44 kB 🟢 -2.15 kB
assets/CloudRunButtonWrapper-BKB6wggQ.js (new) — 8.11 kB 🔴 +8.11 kB 🔴 +2.44 kB 🔴 +2.14 kB
assets/WorkspaceSwitcherPopover-CfXGVTaY.js (removed) 8.08 kB — 🟢 -8.08 kB 🟢 -2.39 kB 🟢 -2.13 kB
assets/WorkspaceSwitcherPopover-DxE96K-b.js (new) — 8.08 kB 🔴 +8.08 kB 🔴 +2.39 kB 🔴 +2.13 kB
assets/launchCancellationFlow-BvQleEPf.js (new) — 7.99 kB 🔴 +7.99 kB 🔴 +2.39 kB 🔴 +2.1 kB
assets/launchCancellationFlow-DT0m0Teh.js (removed) 7.99 kB — 🟢 -7.99 kB 🟢 -2.4 kB 🟢 -2.1 kB
assets/Load3DConfiguration-CJTuXNcs.js (new) — 7.96 kB 🔴 +7.96 kB 🔴 +2.48 kB 🔴 +2.19 kB
assets/Load3DConfiguration-D2SBbomm.js (removed) 7.96 kB — 🟢 -7.96 kB 🟢 -2.49 kB 🟢 -2.18 kB
assets/NightlySurveyController-BznCD3Su.js (removed) 7.5 kB — 🟢 -7.5 kB 🟢 -2.55 kB 🟢 -2.25 kB
assets/NightlySurveyController-f3oQG5C3.js (new) — 7.5 kB 🔴 +7.5 kB 🔴 +2.55 kB 🔴 +2.25 kB
assets/LayoutDefault-BOxoK2Wp.js (new) — 7.41 kB 🔴 +7.41 kB 🔴 +2.43 kB 🔴 +2.14 kB
assets/LayoutDefault-L8leJdif.js (removed) 7.41 kB — 🟢 -7.41 kB 🟢 -2.44 kB 🟢 -2.13 kB
assets/missingModelMetadata-CGmjeQWZ.js (new) — 6.52 kB 🔴 +6.52 kB 🔴 +2.22 kB 🔴 +1.94 kB
assets/missingModelMetadata-CJ_YONcY.js (removed) 6.52 kB — 🟢 -6.52 kB 🟢 -2.22 kB 🟢 -1.94 kB
assets/WidgetWithControl-kPp9Wfdn.js (new) — 6.47 kB 🔴 +6.47 kB 🔴 +2.65 kB 🔴 +2.33 kB
assets/WidgetWithControl-RVVCmxkn.js (removed) 6.47 kB — 🟢 -6.47 kB 🟢 -2.65 kB 🟢 -2.37 kB
assets/CancelSubscriptionDialogContent-Ch6OBHO4.js (removed) 6.05 kB — 🟢 -6.05 kB 🟢 -2 kB 🟢 -1.76 kB
assets/CancelSubscriptionDialogContent-NP2OpzeK.js (new) — 6.05 kB 🔴 +6.05 kB 🔴 +2 kB 🔴 +1.76 kB
assets/main-CGTTusVD.js (new) — 5.97 kB 🔴 +5.97 kB 🔴 +1.93 kB 🔴 +1.61 kB
assets/main-CPI3I1G9.js (removed) 5.97 kB — 🟢 -5.97 kB 🟢 -1.92 kB 🟢 -1.61 kB
assets/load3dPreviewExtensions-CM_o1eXM.js (removed) 5.88 kB — 🟢 -5.88 kB 🟢 -1.81 kB 🟢 -1.6 kB
assets/load3dPreviewExtensions-DJvqqd9P.js (new) — 5.88 kB 🔴 +5.88 kB 🔴 +1.81 kB 🔴 +1.6 kB
assets/ApiNodesSignInContent-C5KN7CYC.js (new) — 5.68 kB 🔴 +5.68 kB 🔴 +2.02 kB 🔴 +1.79 kB
assets/ApiNodesSignInContent-DuAPl8ZQ.js (removed) 5.68 kB — 🟢 -5.68 kB 🟢 -2.02 kB 🟢 -1.79 kB
assets/CreateWorkspaceDialogContent-Bi3Wl7-q.js (new) — 5.11 kB 🔴 +5.11 kB 🔴 +1.79 kB 🔴 +1.55 kB
assets/CreateWorkspaceDialogContent-Dlu-ZTry.js (removed) 5.11 kB — 🟢 -5.11 kB 🟢 -1.79 kB 🟢 -1.54 kB
assets/ChangeMemberRoleDialogContent-DMqnKso_.js (new) — 4.96 kB 🔴 +4.96 kB 🔴 +1.63 kB 🔴 +1.43 kB
assets/ChangeMemberRoleDialogContent-DnqGKN3X.js (removed) 4.96 kB — 🟢 -4.96 kB 🟢 -1.64 kB 🟢 -1.42 kB
assets/EditWorkspaceDialogContent-BOFvr7iX.js (new) — 4.92 kB 🔴 +4.92 kB 🔴 +1.76 kB 🔴 +1.53 kB
assets/EditWorkspaceDialogContent-BQ3Pj_95.js (removed) 4.92 kB — 🟢 -4.92 kB 🟢 -1.76 kB 🟢 -1.52 kB
assets/WidgetTextarea-BllAMAOv.js (new) — 4.83 kB 🔴 +4.83 kB 🔴 +1.88 kB 🔴 +1.65 kB
assets/WidgetTextarea-D0uIH-yb.js (removed) 4.83 kB — 🟢 -4.83 kB 🟢 -1.88 kB 🟢 -1.65 kB
assets/saveMesh-BjuNHlbx.js (new) — 4.66 kB 🔴 +4.66 kB 🔴 +1.5 kB 🔴 +1.32 kB
assets/saveMesh-D3nVpa-e.js (removed) 4.66 kB — 🟢 -4.66 kB 🟢 -1.5 kB 🟢 -1.32 kB
assets/ValueControlPopover-C27ZQ7Sp.js (new) — 4.49 kB 🔴 +4.49 kB 🔴 +1.55 kB 🔴 +1.38 kB
assets/ValueControlPopover-DfuGOYqD.js (removed) 4.49 kB — 🟢 -4.49 kB 🟢 -1.55 kB 🟢 -1.38 kB
assets/GlobalToast-BAGL6uIk.js (removed) 3.89 kB — 🟢 -3.89 kB 🟢 -1.53 kB 🟢 -1.33 kB
assets/GlobalToast-BniM3jk0.js (new) — 3.89 kB 🔴 +3.89 kB 🔴 +1.54 kB 🔴 +1.32 kB
assets/DeleteWorkspaceDialogContent-0b4w11R6.js (removed) 3.84 kB — 🟢 -3.84 kB 🟢 -1.43 kB 🟢 -1.23 kB
assets/DeleteWorkspaceDialogContent-CixzjEpR.js (new) — 3.84 kB 🔴 +3.84 kB 🔴 +1.43 kB 🔴 +1.24 kB
assets/RemoveMemberDialogContent-BQTHDyRM.js (removed) 3.75 kB — 🟢 -3.75 kB 🟢 -1.38 kB 🟢 -1.19 kB
assets/RemoveMemberDialogContent-Da1iSwZX.js (new) — 3.75 kB 🔴 +3.75 kB 🔴 +1.38 kB 🔴 +1.19 kB
assets/RevokeInviteDialogContent-Dl_rRoOf.js (new) — 3.66 kB 🔴 +3.66 kB 🔴 +1.38 kB 🔴 +1.21 kB
assets/RevokeInviteDialogContent-Du7Fu3Cp.js (removed) 3.66 kB — 🟢 -3.66 kB 🟢 -1.38 kB 🟢 -1.21 kB
assets/LeaveWorkspaceDialogContent-FcVeXs-c.js (removed) 3.66 kB — 🟢 -3.66 kB 🟢 -1.38 kB 🟢 -1.18 kB
assets/LeaveWorkspaceDialogContent-pFMzoMk-.js (new) — 3.66 kB 🔴 +3.66 kB 🔴 +1.38 kB 🔴 +1.18 kB
assets/InviteMemberUpsellDialogContent-Bd2H92PK.js (new) — 3.46 kB 🔴 +3.46 kB 🔴 +1.23 kB 🔴 +1.09 kB
assets/InviteMemberUpsellDialogContent-DB-nL3mS.js (removed) 3.46 kB — 🟢 -3.46 kB 🟢 -1.23 kB 🟢 -1.09 kB
assets/SubscribeToRun-BgO1h-AA.js (new) — 3.34 kB 🔴 +3.34 kB 🔴 +1.42 kB 🔴 +1.22 kB
assets/SubscribeToRun-C_LkCWL3.js (removed) 3.34 kB — 🟢 -3.34 kB 🟢 -1.42 kB 🟢 -1.22 kB
assets/Media3DTop-BYRpxc2m.js (removed) 3.23 kB — 🟢 -3.23 kB 🟢 -1.28 kB 🟢 -1.12 kB
assets/Media3DTop-CLyuZiTI.js (new) — 3.23 kB 🔴 +3.23 kB 🔴 +1.28 kB 🔴 +1.12 kB
assets/load3dAdvanced-C35Fq64o.js (removed) 2.87 kB — 🟢 -2.87 kB 🟢 -1.11 kB 🟢 -968 B
assets/load3dAdvanced-iPRI5ja1.js (new) — 2.87 kB 🔴 +2.87 kB 🔴 +1.11 kB 🔴 +967 B
assets/signInSchema-DNjKcM9F.js (removed) 2.85 kB — 🟢 -2.85 kB 🟢 -1.02 kB 🟢 -864 B
assets/signInSchema-DRrOP9PN.js (new) — 2.85 kB 🔴 +2.85 kB 🔴 +1.02 kB 🔴 +861 B
assets/LocalRunButtonWrapper-BSLM4XwG.js (new) — 2.49 kB 🔴 +2.49 kB 🔴 +1.14 kB 🔴 +998 B
assets/LocalRunButtonWrapper-CKudqgjs.js (removed) 2.49 kB — 🟢 -2.49 kB 🟢 -1.14 kB 🟢 -1.02 kB
assets/paymentReturnUrl-C5_XeOF9.js (new) — 1.9 kB 🔴 +1.9 kB 🔴 +944 B 🔴 +740 B
assets/paymentReturnUrl-L4xI55Yq.js (removed) 1.9 kB — 🟢 -1.9 kB 🟢 -944 B 🟢 -741 B
assets/inviteLinks-D8hhEl3D.js (new) — 1.83 kB 🔴 +1.83 kB 🔴 +1.03 kB 🔴 +798 B
assets/inviteLinks-Y18oYuwM.js (removed) 1.83 kB — 🟢 -1.83 kB 🟢 -1.03 kB 🟢 -798 B
assets/MediaAudioTop-fjsKDe-j.js (new) — 1.62 kB 🔴 +1.62 kB 🔴 +809 B 🔴 +670 B
assets/MediaAudioTop-XDm0VMN_.js (removed) 1.62 kB — 🟢 -1.62 kB 🟢 -807 B 🟢 -669 B
assets/cameraInfo-BtMFboB1.js (new) — 1.1 kB 🔴 +1.1 kB 🔴 +573 B 🔴 +492 B
assets/cameraInfo-CYekc6bC.js (removed) 1.1 kB — 🟢 -1.1 kB 🟢 -575 B 🟢 -493 B
assets/Load3DAdvanced-AuSEKOvv.js (removed) 761 B — 🟢 -761 B 🟢 -423 B 🟢 -362 B
assets/Load3DAdvanced-P_p9thPk.js (new) — 761 B 🔴 +761 B 🔴 +422 B 🔴 +359 B
assets/nightlyBadges-CHj1hDya.js (removed) 411 B — 🟢 -411 B 🟢 -272 B 🟢 -230 B
assets/nightlyBadges-D9lQOoXh.js (new) — 411 B 🔴 +411 B 🔴 +271 B 🔴 +231 B
assets/Load3dViewerContent-B1e1YdfK.js (removed) 137 B — 🟢 -137 B 🟢 -103 B 🟢 -92 B
assets/Load3dViewerContent-DMgbKgHk.js (new) — 137 B 🔴 +137 B 🔴 +103 B 🔴 +100 B
assets/AudioPreviewPlayer-BN8AFQwt.js (removed) 134 B — 🟢 -134 B 🟢 -101 B 🟢 -91 B
assets/AudioPreviewPlayer-Csa8paY8.js (new) — 134 B 🔴 +134 B 🔴 +101 B 🔴 +95 B
assets/missingModelMetadata-ClZM1MMt.js (new) — 125 B 🔴 +125 B 🔴 +103 B 🔴 +107 B
assets/missingModelMetadata-mJ4OYYqX.js (removed) 125 B — 🟢 -125 B 🟢 -103 B 🟢 -106 B
assets/Load3DAdvanced-B1Kmphks.js (removed) 122 B — 🟢 -122 B 🟢 -97 B 🟢 -89 B
assets/Load3DAdvanced-C7q9tYCa.js (new) — 122 B 🔴 +122 B 🔴 +97 B 🔴 +88 B
assets/LayoutDefault-0-oUU4yo.js (removed) 119 B — 🟢 -119 B 🟢 -92 B 🟢 -87 B
assets/LayoutDefault-B6yXGwIF.js (new) — 119 B 🔴 +119 B 🔴 +92 B 🔴 +93 B
assets/WidgetLegacy-B0idH5NH.js (removed) 117 B — 🟢 -117 B 🟢 -106 B 🟢 -107 B
assets/WidgetLegacy-DuPhhASJ.js (new) — 117 B 🔴 +117 B 🔴 +106 B 🔴 +105 B
assets/workflowDraftStoreV2-BPMgUslk.js (new) — 112 B 🔴 +112 B 🔴 +101 B 🔴 +109 B
assets/workflowDraftStoreV2-DIk5Jjnv.js (removed) 112 B — 🟢 -112 B 🟢 -101 B 🟢 -107 B
assets/CameraInfo-CKv7s-C7.js (removed) 110 B — 🟢 -110 B 🟢 -93 B 🟢 -90 B
assets/CameraInfo-SgKTtJdM.js (new) — 110 B 🔴 +110 B 🔴 +93 B 🔴 +89 B
assets/Load3D-CsfYhs8S.js (removed) 98 B — 🟢 -98 B 🟢 -89 B 🟢 -82 B
assets/Load3D-DhzAx83Y.js (new) — 98 B 🔴 +98 B 🔴 +89 B 🔴 +78 B
assets/i18n-D2Q-5xAj.js (removed) 97 B — 🟢 -97 B 🟢 -92 B 🟢 -101 B
assets/i18n-DS8-h1sP.js (new) — 97 B 🔴 +97 B 🔴 +92 B 🔴 +84 B
assets/changeTracker-C7KKtrNW.js (new) — 92 B 🔴 +92 B 🔴 +94 B 🔴 +87 B
assets/changeTracker-JWJ8v2b0.js (removed) 92 B — 🟢 -92 B 🟢 -94 B 🟢 -87 B

Status: 82 added / 82 removed / 219 unchanged

⚡ Performance

⏳ Performance tests in progress…

The CRDT doc-subscribe lifecycle retried every subscribe refusal with
the same exponential backoff regardless of error code, so a
schema_version_mismatch refusal (the doc-host's terminal classification
for a document this build can never read) retried forever instead of
failing fast. Gate on the refusal code: schema_version_mismatch now
latches the same give-up exit an unanswered ack times out into and
surfaces a toast; every other code keeps the existing bounded retry.
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 24, 2026
@claude
claude Bot force-pushed the claude/schema-version-mismatch-gate branch from e6c968a to 4020736 Compare September 24, 2026 09:08
Fallow flagged onSubscribed() at cyclomatic 12 / CRAP 43.1 after this PR
added the schema_version_mismatch check and onSyncError call. Pull that
branch (and the code/message derivation) into a standalone helper,
matching the module's existing pattern of pure top-level handlers
(notifyAgentMaterialization, emitPendingMaterializations). No behavior
change.
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #18704      +/-   ##
==========================================
+ Coverage   84.11%   85.03%   +0.92%     
==========================================
  Files        3164     2315     -849     
  Lines      154880   133574   -21306     
  Branches    42062    36550    -5512     
==========================================
- Hits       130280   113587   -16693     
+ Misses      22996    19669    -3327     
+ Partials     1604      318    -1286     
Flag Coverage Δ
billing-web-unit ?
unit 81.37% <100.00%> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/AgentPanelRoot.vue 91.59% <100.00%> (+0.01%) ⬆️
...nch/extensions/agent/crdt/agentCrdtDocLifecycle.ts 99.46% <100.00%> (+0.11%) ⬆️
src/workbench/extensions/agent/crdt/devPanelLog.ts 86.86% <ø> (ø)
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 98.00% <100.00%> (+0.04%) ⬆️
...h/extensions/agent/crdt/workflowSyncErrorDetail.ts 100.00% <100.00%> (ø)

... and 858 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 25, 2026
@christian-byrne christian-byrne self-assigned this Sep 25, 2026
@christian-byrne christian-byrne added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.54 Backport PRs for core 1.54 cloud/1.54 Backport PRs for cloud 1.54 core/1.55 Backport PRs for core 1.55 cloud/1.55 Backport PRs for cloud 1.55 labels Sep 25, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 8 finding(s).

Severity Count
🟡 Medium 5
🟢 Low 3

Panel: 8/8 reviewers contributed findings.

- giveUpPermanently is now idempotent (guards on already-latched
  gaveUp) so a redelivered/duplicate refusal frame cannot re-run the
  report/toast a second time.
- giveUpPermanently now cancels any already-armed subscribeRetryTimer
  from an earlier retryable refusal, so it cannot outlive the
  permanent latch and fire a resubscribe anyway.
- useAgentCrdtFollower re-imports SCHEMA_VERSION_MISMATCH_CODE instead
  of re-spelling the literal, and runs releaseHeldOps/abortIfUnbound
  before notifying onSyncError (matching onDocReset's cleanup-before-
  notify order), so a throw from consumer code can no longer strand an
  in-flight op batch.
- AgentPanelRoot's permanent-desync toast is now sticky (life: 0)
  instead of auto-dismissing after 5s, and its detail always leads
  with the localized copy, appending the doc-host's raw message
  (clamped to 200 chars) as extra context instead of replacing it.

Not fixed, left unresolved for review:
- Gating the latch on which subscribe attempt a refusal answers: the
  wire frame (docFrameClient.ts DocSubscribed) carries no per-attempt
  correlation id, and answers are not guaranteed to arrive in send
  order, so no same-file heuristic can reliably tell a stale answer
  from a current one. Confirmed a same-file heuristic (gate on whether
  an ack is currently outstanding) breaks the existing
  useAgentCrdtFollower.test.ts:766 contract test. Needs a wire-level
  fix spanning the relay/backend.
- Making the permanent latch survive a reconnect: agentCrdtDocLifecycle
  .test.ts already has a dedicated, intentional regression test ("a
  reconnect releases the permanent give-up latch") asserting the
  opposite behavior. Reversing it is a product decision, not a small
  addition.
@DrJKL DrJKL added the agent Comfy Agent product, integration, tests or product documentation label Sep 25, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against current main (0f8c42c035) and against the backend that produces the code this gate branches on, because the whole change hangs on one wire string.

The premise checks out, and the code string is real

schema_version_mismatch is genuinely reachable end-to-end, which is worth recording since nothing on main referenced the string before this PR:

  • cloud services/agent/server/events_doc_frames.go → socketDocCode() returns ("schema_version_mismatch", "the document schema is incompatible with this document service; retrying will not help"), and that pair goes straight onto the refusal frame via docSubscribedRejection().
  • cloud services/ingest/server/services/websocket/doc_relay.go → docErrorCode() threads the agent's 422 code through verbatim rather than collapsing it, with a comment naming schema_version_mismatch specifically.
  • DocSubscribedFrame.Reason carries the JSON tag message, so the detail.message this PR reads is the right field.

And the classification really is terminal rather than a collapsed transient: a stored document at an older schema is accepted by staleSchemaSubscribe(), not refused, and PM-1604's own backend test is pm1604_subgraph_resync_schema_misclassification_test.go — a misclassification fix. The backend has already excluded the recoverable cases before the FE ever sees this code, so latching on it does not trade a spin for a silent give-up. That was the thing most worth checking here and it holds.

Two implementation traps are handled, and both are non-obvious enough to call out: giveUpPermanently() cancels an already-armed retryable backoff (whose callback checks only workflowId()), and it de-dupes a redelivered refusal frame. Both have tests. No new write path to the shared doc, so KEEP-ALIVE #6 is intact.

1. The permanent-code set is under-inclusive, and the codes it misses are the ones that spin hardest

catalog_mismatch sits in the same switch arm one line above schema_version_mismatch in socketDocCode(), with the identical contract: "the document was minted under a different widget catalog; retrying will not help". Ingest's docErrorCode() says it even more bluntly for the 422 case — "retrying cannot fix it, and a client that retries a permanent failure just amplifies it". unsupported (docSurfaceOffReason, sent by doc_relay.go when the doc surface is off for the deployment) is permanent for the life of the connection too.

After this PR both still take the retry ladder, and the ladder's exhaustion is not a stopping state. scheduleSubscribeRetry() returns at this.subscribeRetryAttempt >= SUBSCRIBE_RETRY_MAX_ATTEMPTS without setting gaveUp and without arming a timer — pinned by the existing test in agentCrdtDocLifecycle.test.ts ("refusal exhaustion"), which asserts exactly shouldDeferSubscribe() === false, onGaveUp not called, reportError not called. Because onSocketActivity in useAgentCrdtFollower.ts only bails while shouldDeferSubscribe() is true, and the bridge cleared sentWorkflowId on the refusal so hasPendingSubscribe stays true, every subsequent ComfyUI status frame re-drives bridge.reconcile() and re-sends the subscribe with no backoff at all — indefinitely, and silently.

So for catalog_mismatch the behaviour this PR is named after survives untouched. Suggest a set rather than a constant:

export const PERMANENT_SUBSCRIBE_REFUSAL_CODES: ReadonlySet<string> = new Set([
  'schema_version_mismatch',
  'catalog_mismatch'
])

2. Please separate "stop retrying" from "tell the person"

giveUpPermanently() currently couples three things: the latch, reportError, and onGaveUp() → the sticky toast. That coupling is why (1) cannot simply be widened: unsupported most needs the latch (it is the code every user on a deployment with the doc surface off will receive, on every panel open), and most needs no toast — "This workflow was created with an incompatible document version" would be actively wrong copy for it.

giveUpPermanently(code, { notify: boolean }), or keeping the notify decision at the handleSubscribeRefusal() seam where it already lives, would let the latch cover every permanent code while the toast stays scoped to the one that really is a document-version desync.

3. A flaky socket stacks unbounded sticky toasts

onReconnected() → clearForRetarget() sets gaveUp = false. The reconnect resubscribes, the host refuses again with the same permanent code, and giveUpPermanently() runs from scratch: another reportError, another onGaveUp(), another life: 0 toast. Nothing dismisses the previous one, so N reconnects leave N stacked permanent-error toasts and N telemetry events for one unchanged fact.

Releasing the latch on reconnect is right — a new socket may reach a redeployed host. Re-notifying on it is not. Remembering the workflow id last notified (and re-arming on retarget / doc_reset rather than on a bare reconnect) would keep the toast once-per-lineage, which is what "permanent" implies.

4. Nit: the retryable-code fixture uses a code the server never sends

dispatchFrame('doc_subscribed', { ok: false, code: 'doc_not_found' }) — the wire code for that case is not_found (the docstore.ErrNotFound arm in both socketDocCode() and docErrorCode()). Any non-matching string exercises the retryable arm, so nothing is broken; but the fixture is the closest thing this repo has to a written record of the refusal vocabulary, and it is worth it being accurate — especially given (1), where a reader checking "did anyone look at the other codes?" will look here first.

5. PR body: "retried indefinitely" is true, but not for the reason a reader will check

The ladder is bounded — 6 attempts, ~31.5 s. The unbounded retry is the status-frame path in (1). A reader who checks SUBSCRIBE_RETRY_MAX_ATTEMPTS first will conclude the premise is wrong and stop. Worth one sentence naming the actual mechanism.

Disposition against the FE-2504 rewrite

4 of 9 files overlap #18700 — AgentPanelRoot.vue, crdt/devPanelLog.ts, crdt/useAgentCrdtFollower.ts, crdt/useAgentCrdtFollower.test.ts — all modified, none deleted. The gate itself (agentCrdtDocLifecycle.ts, workflowSyncErrorDetail.ts, docFrameClient.ts) is not touched by the rewrite at all, so the fix survives it; only the onSyncError wiring through useAgentCrdtFollower.ts into AgentPanelRoot.vue will need re-deriving, and AgentPanelRoot.vue loses 126 lines there.

Not merging this yet, and the reason is not the diff: src/workbench/extensions/agent/crdt/** is inside the informal freeze, and this is new behaviour (a new gate, a new event, a new toast) rather than a test extraction. There is a documented route — a named owner plus an exceptions row stating what happens to the fix when the refactor lands — and two such rows already exist for #18404 and #18766. This needs that decision, from Christian or Alex, not a quiet merge. Findings 1–3 are worth fixing either way, since 1 leaves the named behaviour unfixed for a sibling code.

…ying on reconnect

Widens the permanent-refusal latch from a single schema_version_mismatch
constant to PERMANENT_SUBSCRIBE_REFUSAL_CODES (schema_version_mismatch,
catalog_mismatch, unsupported), so the sibling codes stop hitting the
infinite-retry bug this gate exists to fix. giveUpPermanently() now takes
a notify flag so unsupported (doc surface off for the whole deployment)
latches without toasting every user, and the lifecycle remembers the last
notified workflow id so a flaky socket reconnecting to the same workflow
with the same permanent code reports once, not once per reconnect;
retarget/doc_reset re-arm it. Also fixes a test fixture using the wrong
wire code (doc_not_found instead of not_found).

Addresses review comments from christian-byrne on PR #18704.
knip flags PERMANENT_SUBSCRIBE_REFUSAL_CODES as an unused export now that
nothing outside agentCrdtDocLifecycle.ts imports it.
@claude
claude Bot requested a review from christian-byrne September 26, 2026 05:21
@claude

claude Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the precise backend citations, Christian — socketDocCode(), docErrorCode(), and docSurfaceOffReason made these easy to ground.

All 3 design findings plus the nit are addressed in 6ae63be:

  1. catalog_mismatch/unsupported not latched — replaced the single SCHEMA_VERSION_MISMATCH_CODE constant with PERMANENT_SUBSCRIBE_REFUSAL_CODES (schema_version_mismatch, catalog_mismatch, unsupported), used via .has(code) at the one remaining call site.
  2. unsupported must latch without notifying — giveUpPermanently(code, notify) now gates reportError/onGaveUp on a notify flag decided per code (unsupported → false), with the decision flowing back through onSubscribeRefused()'s return value into handleSubscribeRefusal()'s existing {shouldNotify, message} seam.
  3. re-notifying on every reconnect — the lifecycle now remembers the last-notified workflow id and skips reportError/onGaveUp for a repeat of the same permanent code on the same workflow; onReconnected() still releases the gaveUp latch (unchanged), but only clearForRetarget()/doc_reset re-arm the notified-id memory.
  4. nit — fixed the doc_not_found → not_found test fixture.

New/updated tests cover all of the above in agentCrdtDocLifecycle.test.ts and useAgentCrdtFollower.test.ts; typecheck, lint, format, and fallow audit are clean (no new complexity findings).

Per this repo's AGENTS.md PR-review-comment convention, I only resolved the nit thread (trivial, single-interpretation) and left the 3 design-finding threads unresolved with a reply each — requested your re-review to close those out.


Generated by Claude Code

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permanent-refusal notification state still has a blocking recovery bug. The existing stale-ack race thread remains applicable and is not duplicated here; the other two comments are non-blocking follow-ups.

…race, thread refusal code

Christian's second review (pr18704-f2, blocking): a successful confirm
after a permanent refusal left `lastNotifiedGiveUpWorkflowId` pointing at
the workflow, so a LATER independent permanent refusal for the same
workflow was silently suppressed (no reportError, no onGaveUp, no toast).
`onSubscribeConfirmed()` now calls `resetNotifiedGiveUp()`, ending the
notification-dedupe episode on actual recovery while still leaving it
latched across a reconnect that never recovers.

Stale-ack race (root-caused, previously left open for a human call): an
ack-timeout resubscribe can leave an older subscribe attempt outstanding
while a newer one (same lineage) confirms first. A delayed permanent
refusal answering that older attempt then arrived and gave up on an
otherwise healthy channel, tearing down the stale probe the confirm had
just armed. Root cause: the latch had no notion of which attempt an
incoming answer belonged to. Fix: track `confirmedSinceLastSend`, set on
`onSubscribeConfirmed()` and cleared on the next `onSubscribeSent()`. A
confirm and a permanent refusal can never both answer the same subscribe,
so a permanent refusal arriving while this is true must be a stale answer
to a superseded attempt - `onSubscribeRefused` now discards it before
touching any timer. This is scoped to the permanent-refusal path only: the
existing "a confirm between refusals restarts the backoff" contract for
retryable refusals is untouched, and the general "giveUpPermanently
cancels an already-armed retryable backoff" contract still holds when no
confirm intervened.

f3 (non-blocking): `onSyncError` collapsed every permanent refusal code to
the same localized copy, so `catalog_mismatch` reached the
"incompatible document version" message written for
`schema_version_mismatch`. `handleSubscribeRefusal`/`onSyncError` now
thread the refusal `code` through, and `formatWorkflowSyncErrorDetail`
picks a dedicated `workflowSyncFailedDetailCatalogMismatch` copy for it.

f5 (non-blocking): added a narrow AgentPanelRoot.vue component test
proving the onSyncError wiring end-to-end (error toast, formatted detail,
life: 0) - the follower and formatter each had unit coverage, but nothing
asserted they were actually connected. Fixed the test harness's `ws.emit`
helper to dispatch a real CustomEvent (the CRDT doc-frame pipeline checks
`instanceof CustomEvent` before reading `.detail`), which the new test
needed to reach the follower at all; verified the new test by temporarily
removing the onSyncError wiring and observing it fail, then restored it.
@claude
claude Bot force-pushed the claude/schema-version-mismatch-gate branch from e3aaf47 to e6f668a Compare September 27, 2026 05:46
@DrJKL DrJKL added agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 27, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed at 0a94625 after merging current main. The schema-refusal path remains fail-closed, focused tests cover the lifecycle and UI wiring, and the reconnect tradeoff is documented. Local focused suite: 436 passed; typecheck, lint, format, Knip, and Fallow gates pass.

@christian-byrne

Copy link
Copy Markdown
Contributor

Exact-head landing judgment: 0a94625f has all checks terminal with no adverse result and a fresh human approval. It is one commit behind current main (aaaac2b1), with zero changed-file overlap per the merge-readiness guard, so the untested delta cannot interact with this PR. Proceeding under the documented zero-overlap exception.

@christian-byrne
christian-byrne merged commit 377e772 into main Sep 28, 2026
111 checks passed
@christian-byrne
christian-byrne deleted the claude/schema-version-mismatch-gate branch September 28, 2026 02:53
@comfy-pr-bot

Copy link
Copy Markdown
Member

⚠️ Backport to core/1.54 failed

Reason: Merge conflicts detected during cherry-pick of 377e772

The auto-backport could not be completed automatically. Please backport
manually onto branch backport-18704-to-core-1.54 (from origin/core/1.54) and
open a PR to core/1.54.

This may be a stacking conflict rather than a real one. #19155, #18983 are still open against core/1.54. If this PR sits on top of any of them, the conflict will disappear once they merge — wait for that, then remove and re-add the needs-backport label to re-run this workflow.

📄 Conflicting files
src/workbench/extensions/agent/AgentPanelRoot.vue
src/workbench/extensions/agent/crdt/agentCrdtDocLifecycle.test.ts
src/workbench/extensions/agent/crdt/agentCrdtDocLifecycle.ts
src/workbench/extensions/agent/crdt/devPanelLog.ts
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts
🤖 Prompt for AI Agents
Backport PR #18704 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/18704) to core/1.54.
Cherry-pick merge commit 377e7725acc3dea85c8e40a92891f91c9527d06e onto new branch
backport-18704-to-core-1.54 from origin/core/1.54.
Resolve conflicts in: src/workbench/extensions/agent/AgentPanelRoot.vue src/workbench/extensions/agent/crdt/agentCrdtDocLifecycle.test.ts src/workbench/extensions/agent/crdt/agentCrdtDocLifecycle.ts src/workbench/extensions/agent/crdt/devPanelLog.ts src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts .

> **This may be a stacking conflict rather than a real one.** #19155, #18983 are still open against `core/1.54`. If this PR sits on top of any of them, the conflict will disappear once they merge — wait for that, then remove and re-add the `needs-backport` label to re-run this workflow.

For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport core/1.54] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @claude[bot]

@comfy-pr-bot

Copy link
Copy Markdown
Member

⚠️ Backport to cloud/1.54 failed

Reason: Merge conflicts detected during cherry-pick of 377e772

The auto-backport could not be completed automatically. Please backport
manually onto branch backport-18704-to-cloud-1.54 (from origin/cloud/1.54) and
open a PR to cloud/1.54.

This may be a stacking conflict rather than a real one. #19158, #18984 are still open against cloud/1.54. If this PR sits on top of any of them, the conflict will disappear once they merge — wait for that, then remove and re-add the needs-backport label to re-run this workflow.

📄 Conflicting files
src/workbench/extensions/agent/AgentPanelRoot.vue
src/workbench/extensions/agent/crdt/agentCrdtDocLifecycle.test.ts
src/workbench/extensions/agent/crdt/agentCrdtDocLifecycle.ts
src/workbench/extensions/agent/crdt/devPanelLog.ts
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts
🤖 Prompt for AI Agents
Backport PR #18704 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/18704) to cloud/1.54.
Cherry-pick merge commit 377e7725acc3dea85c8e40a92891f91c9527d06e onto new branch
backport-18704-to-cloud-1.54 from origin/cloud/1.54.
Resolve conflicts in: src/workbench/extensions/agent/AgentPanelRoot.vue src/workbench/extensions/agent/crdt/agentCrdtDocLifecycle.test.ts src/workbench/extensions/agent/crdt/agentCrdtDocLifecycle.ts src/workbench/extensions/agent/crdt/devPanelLog.ts src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts .

> **This may be a stacking conflict rather than a real one.** #19158, #18984 are still open against `cloud/1.54`. If this PR sits on top of any of them, the conflict will disappear once they merge — wait for that, then remove and re-add the `needs-backport` label to re-run this workflow.

For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport cloud/1.54] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @claude[bot]

@comfy-pr-bot

Copy link
Copy Markdown
Member

⚠️ Backport to core/1.55 failed

Reason: Merge conflicts detected during cherry-pick of 377e772

The auto-backport could not be completed automatically. Please backport
manually onto branch backport-18704-to-core-1.55 (from origin/core/1.55) and
open a PR to core/1.55.

This may be a stacking conflict rather than a real one. #19157, #18668 are still open against core/1.55. If this PR sits on top of any of them, the conflict will disappear once they merge — wait for that, then remove and re-add the needs-backport label to re-run this workflow.

📄 Conflicting files
src/workbench/extensions/agent/AgentPanelRoot.vue
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts
🤖 Prompt for AI Agents
Backport PR #18704 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/18704) to core/1.55.
Cherry-pick merge commit 377e7725acc3dea85c8e40a92891f91c9527d06e onto new branch
backport-18704-to-core-1.55 from origin/core/1.55.
Resolve conflicts in: src/workbench/extensions/agent/AgentPanelRoot.vue src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts .

> **This may be a stacking conflict rather than a real one.** #19157, #18668 are still open against `core/1.55`. If this PR sits on top of any of them, the conflict will disappear once they merge — wait for that, then remove and re-add the `needs-backport` label to re-run this workflow.

For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport core/1.55] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @claude[bot]

@comfy-pr-bot

Copy link
Copy Markdown
Member

⚠️ Backport to cloud/1.55 failed

Reason: Merge conflicts detected during cherry-pick of 377e772

The auto-backport could not be completed automatically. Please backport
manually onto branch backport-18704-to-cloud-1.55 (from origin/cloud/1.55) and
open a PR to cloud/1.55.

This may be a stacking conflict rather than a real one. #19156 are still open against cloud/1.55. If this PR sits on top of any of them, the conflict will disappear once they merge — wait for that, then remove and re-add the needs-backport label to re-run this workflow.

📄 Conflicting files
src/workbench/extensions/agent/AgentPanelRoot.vue
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts
🤖 Prompt for AI Agents
Backport PR #18704 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/18704) to cloud/1.55.
Cherry-pick merge commit 377e7725acc3dea85c8e40a92891f91c9527d06e onto new branch
backport-18704-to-cloud-1.55 from origin/cloud/1.55.
Resolve conflicts in: src/workbench/extensions/agent/AgentPanelRoot.vue src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts .

> **This may be a stacking conflict rather than a real one.** #19156 are still open against `cloud/1.55`. If this PR sits on top of any of them, the conflict will disappear once they merge — wait for that, then remove and re-add the `needs-backport` label to re-run this workflow.

For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport cloud/1.55] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @claude[bot]

christian-byrne pushed a commit that referenced this pull request Sep 28, 2026
…CRDT doc subscribe (#18704)

Manual backport of #18704, preserving the 1.55 composition-root and reset implementations while integrating the permanent-refusal lifecycle, notification, and retry reset.
christian-byrne pushed a commit that referenced this pull request Sep 28, 2026
… CRDT doc subscribe (#18704)

Manual backport of #18704, preserving the 1.55 composition-root and reset implementations while integrating the permanent-refusal lifecycle, notification, and retry reset.
@christian-byrne christian-byrne removed core/1.54 Backport PRs for core 1.54 cloud/1.54 Backport PRs for cloud 1.54 labels Sep 28, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor

Release follow-up: automated backports failed on all four targets. Core/cloud 1.54 do not contain the CRDT lifecycle files this retry gate changes, so this fix is not applicable there. Target-native 1.55 adaptations are open as #19182 (core/1.55) and #19183 (cloud/1.55); both retain the 1.55 reset path while adding the permanent-refusal gate and durable sync-error notification. Local validation: 381 focused tests, full workspace typecheck, formatting, and pre-push dependency checks passed.

christian-byrne pushed a commit that referenced this pull request Sep 28, 2026
…ackport #18704 to the 1.55 release branch with its native reset path.\nPreserve the permanent schema-mismatch refusal gate, durable sync-error\nnotification, and reset of the one-shot give-up latch.
christian-byrne pushed a commit that referenced this pull request Sep 28, 2026
Backport #18704 to the 1.55 release branch with its native reset path. Preserve the permanent schema-mismatch refusal gate, durable sync-error notification, and reset of the one-shot give-up latch.
christian-byrne pushed a commit that referenced this pull request Sep 28, 2026
…ackport #18704 to the 1.55 release branch with its native reset path.\nPreserve the permanent schema-mismatch refusal gate, durable sync-error\nnotification, and reset of the one-shot give-up latch.
christian-byrne pushed a commit that referenced this pull request Sep 28, 2026
Backport #18704 to the 1.55 release branch with its native reset path. Preserve the permanent schema-mismatch refusal gate, durable sync-error notification, and reset of the one-shot give-up latch.
christian-byrne added a commit that referenced this pull request Sep 28, 2026
…CRDT doc subscribe (#18704) (#19165)

Manual backport of #18704. The 1.55 release line contains the affected
CRDT lifecycle; conflicts in the agent panel and follower were resolved
to the tested source fix.

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
christian-byrne added a commit that referenced this pull request Sep 28, 2026
… CRDT doc subscribe (#18704) (#19166)

Manual backport of #18704. The 1.55 release line contains the affected
CRDT lifecycle; conflicts in the agent panel and follower were resolved
to the tested source fix.

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
@christian-byrne christian-byrne removed needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.55 Backport PRs for core 1.55 cloud/1.55 Backport PRs for cloud 1.55 labels Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants