Repository navigation
feat(agent): update consent card launch video - #18765
Conversation
Point the consent card, its story, and the browser test at the new agent-consent-v2 media on media.comfy.org. The new video is silent, like the previous one, because the card plays it muted.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe agent consent dialog and story now reference v2 WebM, MP4, and poster assets. The browser test expects the v2 MP4 fallback URL. ChangesAgent consent assets
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The consent card, preview, and fallback test agree on the v2 filenames; no material merge-blocking risk is apparent. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9548e89a47d013249c16ac36944be258e11a1161
Full docs: ADR-DEVEX-LINT-0015 🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2130 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 10 MB gzip 🔴 +302 kBDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.73 kB) • 🔴 +38 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.43 MB) • 🔴 +22.3 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 134 kB (baseline 124 kB) • 🔴 +9.77 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 39.4 kB (baseline 27.8 kB) • 🔴 +11.6 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +690 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 125 kB (baseline 117 kB) • 🔴 +8.01 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.97 MB (baseline 3.6 MB) • 🔴 +368 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 576 kB (baseline 559 kB) • 🔴 +17.6 kBHelpers, composables, and utility bundles
Status: 30 added / 30 removed / 6 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -686 kBExternal libraries and shared vendor chunks
Status: 12 added / 12 removed / 6 unchanged Other — 17.9 MB (baseline 16.4 MB) • 🔴 +1.49 MBBundles that do not match a named category
Status: 179 added / 174 removed / 122 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T02:13:23.028Z",
"gitSha": "bcad7a70cd7f51dabf7877047c045afdd3901133",
"branch": "uy/DES-1204/consent-card-launch-video",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.1460000000343,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.324,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.8379999999999,
"heapDeltaBytes": -1192480,
"heapUsedBytes": 60498764,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.038999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2009.0679999999566,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.84,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.70400000000006,
"heapDeltaBytes": -1148776,
"heapUsedBytes": 61281884,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 8.785999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1842.0849999999973,
"styleRecalcs": 72,
"styleRecalcDurationMs": 18.467000000000002,
"layouts": 12,
"layoutDurationMs": 4.524,
"taskDurationMs": 865.596,
"heapDeltaBytes": -6331392,
"heapUsedBytes": 56253572,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 171.99,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.5830000000142,
"styleRecalcs": 70,
"styleRecalcDurationMs": 18.634999999999998,
"layouts": 12,
"layoutDurationMs": 4.518,
"taskDurationMs": 868.266,
"heapDeltaBytes": -3284796,
"heapUsedBytes": 59178012,
"domNodes": -228,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 168.72199999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.7989999999481,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.942,
"layouts": 6,
"layoutDurationMs": 1.2610000000000001,
"taskDurationMs": 341.772,
"heapDeltaBytes": 2155836,
"heapUsedBytes": 64551892,
"domNodes": 53,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.248,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.629999999981,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.505,
"layouts": 6,
"layoutDurationMs": 1.0610000000000002,
"taskDurationMs": 322.678,
"heapDeltaBytes": 1820316,
"heapUsedBytes": 64369116,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.056999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 692.942999999957,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.307,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.4,
"heapDeltaBytes": 18322128,
"heapUsedBytes": 80734900,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 169.00500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 682.9609999999775,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.2109999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.81899999999996,
"heapDeltaBytes": 18233644,
"heapUsedBytes": 80673600,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 165.75699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1228.3760000000257,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 919.2360000000001,
"heapDeltaBytes": -14183412,
"heapUsedBytes": 73447216,
"domNodes": -259,
"jsHeapTotalBytes": 18743296,
"scriptDurationMs": 70.008,
"eventListeners": -185,
"totalBlockingTimeMs": 562,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1211.2210000000232,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 871.999,
"heapDeltaBytes": 34720092,
"heapUsedBytes": 107448560,
"domNodes": 0,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 71.883,
"eventListeners": 0,
"totalBlockingTimeMs": 606,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 830.2099999999655,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.7509999999999,
"heapDeltaBytes": 13073284,
"heapUsedBytes": 90146760,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.06799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.8419999999951,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.0869999999995,
"heapDeltaBytes": 13776048,
"heapUsedBytes": 90371380,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.609,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10861.965999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9899.080999999998,
"heapDeltaBytes": -2704416,
"heapUsedBytes": 80372508,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8144.651,
"eventListeners": 0,
"totalBlockingTimeMs": 1243,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9636.036999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8930.116,
"heapDeltaBytes": -1467884,
"heapUsedBytes": 80689784,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 7604.206,
"eventListeners": 0,
"totalBlockingTimeMs": 1286,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10434.887000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9482.219000000001,
"heapDeltaBytes": 4390636,
"heapUsedBytes": 86312724,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7808.027,
"eventListeners": 0,
"totalBlockingTimeMs": 1089,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10624.375999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9674.508000000002,
"heapDeltaBytes": -11190268,
"heapUsedBytes": 71269408,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 7995.6849999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 1223,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2055.467999999962,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.894999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 617.371,
"heapDeltaBytes": -4536828,
"heapUsedBytes": 76669040,
"domNodes": -228,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 34.469,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2035.3299999999308,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.595000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.6569999999999,
"heapDeltaBytes": -4992260,
"heapUsedBytes": 75698456,
"domNodes": -228,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 30.002000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2497.4449999999706,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.165000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1691.7169999999996,
"heapDeltaBytes": -14276792,
"heapUsedBytes": 67857064,
"domNodes": -198,
"jsHeapTotalBytes": 1863680,
"scriptDurationMs": 880.0349999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2702.3130000000037,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.227,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1767.323,
"heapDeltaBytes": -15254676,
"heapUsedBytes": 67148052,
"domNodes": -228,
"jsHeapTotalBytes": 2387968,
"scriptDurationMs": 932.5029999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3681.1630000000264,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.543999999999997,
"layouts": 60,
"layoutDurationMs": 13.446,
"taskDurationMs": 1711.192,
"heapDeltaBytes": 7972760,
"heapUsedBytes": 74106640,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 796.451,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3645.4670000000533,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.989000000000003,
"layouts": 60,
"layoutDurationMs": 13.466000000000001,
"taskDurationMs": 1719.983,
"heapDeltaBytes": -8939096,
"heapUsedBytes": 73900536,
"domNodes": -228,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 781.9910000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3162.8089999999816,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.310000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1928.0920000000003,
"heapDeltaBytes": 25788576,
"heapUsedBytes": 91985732,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 982.2299999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3145.573000000013,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.353999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1931.9660000000001,
"heapDeltaBytes": 29678280,
"heapUsedBytes": 97761004,
"domNodes": 0,
"jsHeapTotalBytes": 2252800,
"scriptDurationMs": 1000.1170000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2043.8540000000103,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.4269999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.059,
"heapDeltaBytes": -13880268,
"heapUsedBytes": 74889924,
"domNodes": -228,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 33.83000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2038.9779999999291,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.204000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.352,
"heapDeltaBytes": -5531148,
"heapUsedBytes": 83081816,
"domNodes": -228,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 33.456,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 622.6429999999823,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.280999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.354,
"heapDeltaBytes": 13551544,
"heapUsedBytes": 77039308,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.756,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 604.893000000061,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.028999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.17199999999997,
"heapDeltaBytes": 13159488,
"heapUsedBytes": 76748808,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.465,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1996.8660000000114,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.353000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.356,
"heapDeltaBytes": 642864,
"heapUsedBytes": 63359876,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.183,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2020.7020000000284,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.450999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.359,
"heapDeltaBytes": -6276716,
"heapUsedBytes": 56473172,
"domNodes": -244,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.616999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.2120000000127,
"styleRecalcs": 73,
"styleRecalcDurationMs": 18.208999999999996,
"layouts": 16,
"layoutDurationMs": 5.558000000000001,
"taskDurationMs": 819.594,
"heapDeltaBytes": 9163280,
"heapUsedBytes": 72774924,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 114.145,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.0130000000418,
"styleRecalcs": 59,
"styleRecalcDurationMs": 17.466,
"layouts": 16,
"layoutDurationMs": 5.945,
"taskDurationMs": 668.632,
"heapDeltaBytes": 1888576,
"heapUsedBytes": 65141684,
"domNodes": -244,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.54,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.2189999999691,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.075000000000003,
"layouts": 5,
"layoutDurationMs": 13.406,
"taskDurationMs": 906.565,
"heapDeltaBytes": -6281352,
"heapUsedBytes": 82053120,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.782000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8750.963000000012,
"styleRecalcs": 249,
"styleRecalcDurationMs": 31.62,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5956.067,
"heapDeltaBytes": -4609640,
"heapUsedBytes": 76428072,
"domNodes": -228,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 2833.7490000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8695.86700000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.933000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5784.998,
"heapDeltaBytes": 7351088,
"heapUsedBytes": 88524796,
"domNodes": -228,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 2820.236,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16906.604000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16596.527,
"heapDeltaBytes": -47325508,
"heapUsedBytes": 177845808,
"domNodes": -8049,
"jsHeapTotalBytes": -16523264,
"scriptDurationMs": 261.715,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16801.146000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16329.788,
"heapDeltaBytes": -42278704,
"heapUsedBytes": 195151172,
"domNodes": -8049,
"jsHeapTotalBytes": -15925248,
"scriptDurationMs": 287.094,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20293.588999999996,
"styleRecalcs": 161,
"styleRecalcDurationMs": 16.946000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20041.916,
"heapDeltaBytes": -70995228,
"heapUsedBytes": 169045272,
"domNodes": -8049,
"jsHeapTotalBytes": -20865024,
"scriptDurationMs": 877.6080000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 25,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20377.786000000015,
"styleRecalcs": 158,
"styleRecalcDurationMs": 15.948000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20083.178,
"heapDeltaBytes": -45236324,
"heapUsedBytes": 192034916,
"domNodes": -8049,
"jsHeapTotalBytes": -17043456,
"scriptDurationMs": 850.4300000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6159.917000000064,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.148,
"layouts": 20,
"layoutDurationMs": 23.647000000000002,
"taskDurationMs": 6040.347,
"heapDeltaBytes": -47038820,
"heapUsedBytes": 180229108,
"domNodes": -8049,
"jsHeapTotalBytes": 9895936,
"scriptDurationMs": 107.77300000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 494,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6061.510999999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.959,
"layouts": 20,
"layoutDurationMs": 23.328000000000003,
"taskDurationMs": 6010.215,
"heapDeltaBytes": -41348172,
"heapUsedBytes": 183590184,
"domNodes": -8049,
"jsHeapTotalBytes": 15982592,
"scriptDurationMs": 103.076,
"eventListeners": -14923,
"totalBlockingTimeMs": 398,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8405.379000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8238.879999999997,
"heapDeltaBytes": -6969196,
"heapUsedBytes": 184934352,
"domNodes": 0,
"jsHeapTotalBytes": -25952256,
"scriptDurationMs": 130.22100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8443.439000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8234.623999999998,
"heapDeltaBytes": 21283896,
"heapUsedBytes": 178865196,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 124.71,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 480.36500000000615,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.019000000000002,
"layouts": 3,
"layoutDurationMs": 1.484,
"taskDurationMs": 127.665,
"heapDeltaBytes": 5102412,
"heapUsedBytes": 66992356,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.714000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 103.94799999994575,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.066,
"layouts": 3,
"layoutDurationMs": 1.4780000000000002,
"taskDurationMs": 74.21900000000001,
"heapDeltaBytes": 3012044,
"heapUsedBytes": 64251320,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.890999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18765 +/- ##
==========================================
+ Coverage 83.85% 84.87% +1.02%
==========================================
Files 3052 2302 -750
Lines 151005 132182 -18823
Branches 39099 35695 -3404
==========================================
- Hits 126624 112193 -14431
+ Misses 22967 19690 -3277
+ Partials 1414 299 -1115
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 775 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
## Summary Linear issue: [DES-1204](https://linear.app/comfyorg/issue/DES-1204/des-update-launch-video-file-in-the-consent-card) The Comfy Agent consent card now plays the new launch video. ## Changes - **What**: - The consent card shows the new Comfy Agent launch video. It replaces the previous video. - The new video is 45 seconds long. The previous video was 22 seconds long. - The video is on the Comfy media server, not in this repository. The card uses three files: a WebM video, an MP4 video for older iPhones, and a still image that shows before the video starts. - The card plays the video muted. For this reason, the video files have no sound track. - The card layout does not change. ## Review Focus - The three files have new names (`agent-consent-v2-*`). As a result, the new video shows only after this PR merges. No browser shows an old cached copy. - The previous video files stay on the media server. The current release continues to use them. - Each new video file is approximately 5 MB. This is approximately 2 MB more than before, because the new video is two times longer. - The browser test now expects the new MP4 file name. The Storybook preview also uses the new files. ## Screenshots (if applicable) New Video https://media.comfy.org/website/comfy-agent/agent-consent-v2-1280.mp4
## Summary Linear issue: [DES-1204](https://linear.app/comfyorg/issue/DES-1204/des-update-launch-video-file-in-the-consent-card) The Comfy Agent consent card now plays the new launch video. ## Changes - **What**: - The consent card shows the new Comfy Agent launch video. It replaces the previous video. - The new video is 45 seconds long. The previous video was 22 seconds long. - The video is on the Comfy media server, not in this repository. The card uses three files: a WebM video, an MP4 video for older iPhones, and a still image that shows before the video starts. - The card plays the video muted. For this reason, the video files have no sound track. - The card layout does not change. ## Review Focus - The three files have new names (`agent-consent-v2-*`). As a result, the new video shows only after this PR merges. No browser shows an old cached copy. - The previous video files stay on the media server. The current release continues to use them. - Each new video file is approximately 5 MB. This is approximately 2 MB more than before, because the new video is two times longer. - The browser test now expects the new MP4 file name. The Storybook preview also uses the new files. ## Screenshots (if applicable) New Video https://media.comfy.org/website/comfy-agent/agent-consent-v2-1280.mp4
Summary
Linear issue: DES-1204
The Comfy Agent consent card now plays the new launch video.
Changes
Review Focus
agent-consent-v2-*). As a result, the new video shows only after this PR merges. No browser shows an old cached copy.Screenshots (if applicable)
New Video
https://media.comfy.org/website/comfy-agent/agent-consent-v2-1280.mp4