Repository navigation
[backport core/1.54] fix: restore Impact, WAS Pause, and RefMod compatibility - #18471
Conversation
Fix the Impact Preview Bridge, WAS Pause, and MiniMax RefMod compatibility failures reported on frontend v1.53.7. - First commit adds `legacyDoNotReplicate` specs with `test.fail()` at the known failure points. All four cases failed as expected before the fixes. - Second commit restores extension value setters, live disabled getters, and overridden node serialization. It removes the expected-failure markers without changing the assertions. - Follow-up commits separate the renderer tests and extract extension behavior into `DevToolsWASPause`, `DevToolsRefModLoader`, and `DevToolsPreviewBridge`. The specs keep the interactions and outcome assertions. - Review cleanup moves workflow loading out of the mask-editor helper and renames the DevTools extension to `legacyCompatibility.js`. The specs reproduce each pack's extension API usage without installing the packs. They cover mask registration after Save, Resume clicks in both renderers, and RefMod values and hidden slots after reload. MiniMax's corresponding upstream repair is Luisacaotica/ComfyUI-MiniMaxH3Mod#20. Extension migration: no changes are required to the existing value-setter and `serialize()` wrappers reproduced here. Live `disabled` getters remain supported; when their nonreactive inputs change, request a node-level foreground redraw with `node.setDirtyCanvas(true)` so Vue receives the new state. These fixes preserve legacy extension behavior during the migration described by [ADR-ECS-0008](https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/docs/adr/ECS-0008-entity-component-system.md) and [ADR-ECS-WIDGETS-0023](https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/docs/adr/ECS-WIDGETS-0023-widget-entities-with-a-legacy-layer.md), both Proposed. <details> <summary>Impact Preview Bridge: mask saves bypass the image setter</summary> The report was that Preview Bridge no longer outputs masks. Investigation traced mask saves through `setNodeWidgetValue()` in `src/core/graph/widgets/nodeWidgetValues.ts`. Preview Bridge installs an asynchronous `image.value` setter that registers the new image and updates the preview ID. For a registered widget, `setNodeWidgetValue()` wrote directly to `widgetValueStore`, then invoked callbacks without assigning `widget.value`. The store changed, but the extension's registration side effect never ran, leaving the old preview ID in the execution prompt. `legacyPreviewBridgeMaskSave.spec.ts` loads `DevToolsPreviewBridge`, whose web extension installs a reduced version of that accessor. A separate `source_image` upload widget supplies the preview through the existing mask-editor helper. The spec draws a mask, clicks Save, and exports the API prompt. Before the fix, the prompt still contained `$preview-before-mask`. After the fix, it contains `$preview-after-mask`, and the accessor records the generated masked-image path. The fix preserves the store write and also assigns `widget.value` before the existing callbacks. This restores extension setter side effects while retaining support for independently registered widget state. This proves that the mask-save path reaches an asynchronous extension setter. It does not run Impact's backend or verify its final mask tensor. </details> <details> <summary>WAS Pause: widget adoption freezes the button's disabled state</summary> The Pause node is from WAS. Its button defines a custom `disabled` getter over the held-node state, with a no-op setter. When execution pauses, WAS updates that state and requests a node redraw. `adoptConcreteWidget()` in `src/lib/litegraph/src/widgets/widgetMap.ts` merged the extension accessor with the concrete widget accessor. The merged getter called the extension getter but discarded its return value, returning the stored disabled state instead. Changes to the held-node state therefore left the button disabled. Vue had an additional problem: its button reads reactive widget state, while WAS's held-node collection is not reactive. `DevToolsWASPause` owns the plain widget object, getter, no-op setter, and pause-event handler. The handler targets one node and unregisters when that node is removed. `legacyPauseButtonGetter.spec.ts` creates the node and delivers the pause event. Before the fix, a classic-canvas click did not resume the node, and the Vue button stayed disabled. After the fix, both renderer cases click Resume and observe the callback's state change. The fix retains the extension's `disabled` getter. For Vue nodes, a foreground `node.setDirtyCanvas()` request also synchronizes that getter's current value into the reactive widget state. Renderer changes refresh the live disabled state alongside visibility. This covers pausing in classic mode before enabling Nodes 2.0, when the stored state would otherwise remain stale. The transition regression fails before that refresh and passes afterward. Synchronization uses redraw and renderer-transition events rather than polling every frame. The reproduction exercises button enablement, repeated pause/resume cycles, and renderer switching, not a real WAS execution queue. While Vue is active, synchronization depends on the extension requesting a node-level foreground redraw. </details> <details> <summary>MiniMax RefMod: graph saves bypass the schema-order serialization wrapper</summary> The report combined eight visible slots after reload with values replaced by `NaN`. RefMod displays model and strength widgets in an interleaved order, but its serialized values must follow the backend schema order. It wraps `serialize()` and `configure()` to temporarily restore that schema order, then restores the display order. `serialiseStoredNodes()` in `src/lib/litegraph/src/LGraph.ts` called `serializeFromStoreState()` directly. That bypassed the extension's `serialize()` wrapper. Saving in display order and loading in schema order shifted values into the wrong widgets. A model string in a numeric slot explains the reported `NaN`; corrupted default values also make unused slots appear populated. `DevToolsRefModLoader` defines eight model/strength pairs in its backend schema. Its web extension installs the ordering wrappers and visibility behavior during node creation. `legacyRefModSerialization.spec.ts` loads a workflow asset, then saves and reloads a selected `voice.refmod` model with strength `0.65`. Before the fix, the model restored as `0.65`. After the fix, the model and strength retain their values, and the eighth slot stays hidden. The fix calls overridden `serialize()` methods while retaining `serializeFromStoreState()` for nodes using the default serializer. MiniMax's upstream PR linked above addresses the same bypass by wrapping the newer serialization method in the extension. The test proves the positional corruption and corrected round trip. It does not assert the full pack's exact `NaN` display, execute the model loader, or repair workflows already saved with corrupted values. </details> CI isolation: the new Preview Bridge test left uploaded images in the shared backend. That changed the Load Image selector arrows in the MP4/MOV/M4V import screenshots. All three passed on a clean backend and failed after running Preview Bridge. The reproduction now uploads into a unique subfolder and registers each returned filename for teardown. Media-import tests use a fixed image-option list through the existing object-info fixture, so concurrent uploads cannot change their screenshots. No screenshot expectations changed. Validation: - Renderer-transition follow-up: classic pause to Vue Resume fails before the transition refresh and passes afterward. All 15 repeated Pause cases and all 42 legacy-compatibility and renderer-toggle cases pass against the rebuilt production frontend. - Extracted reproductions: all 4 fail at the original assertions against a pre-fix production build and pass with the fixes. - Full `legacyDoNotReplicate` suite: 38 passed against the production build with DevTools extensions loaded. - Related mask-editor and legacy-widget tests: 28 passed, 2 screenshot comparisons failed. Both screenshot failures also occur with the mask-editor helper changes removed; no snapshots were updated. - Review cleanup: 77 of 80 affected browser tests passed. The remaining three screenshot failures also reproduce on the unchanged previous PR head, with byte-identical actual images: both mask-editor opening cases and the PNG prompt-parameters import. - Preview Bridge plus the three video-import cases passed all 40 repetitions on two workers. Both legacy-widget cases passed. The backend image list was identical before and after the isolated Preview Bridge test. - Latest related unit run: 54 files passed; 784 tests passed, 7 existing expected failures, 5 skipped. - Adversarial review added a default-serializer regression test. Replacing the dispatch with unconditional `adapter.serialize()` makes that test fail; the restored implementation passes. A late-installed normalizing-setter mismatch was reproduced on both the base and PR branches and is outside this fix. - Fallow passed with measured widget-adoption coverage and zero new findings; the estimate-only run reported CRAP 31.6 for `adoptConcreteWidget`. - Production build, typechecks, DevTools Python compilation, and changed-file lint and formatting passed. Full lint passed before the test-fixture extraction with existing warnings. Run these specs against a backend serving `pnpm build` output with `tools/devtools` installed. Vite's dev server deliberately returns an empty extension list. That explained the earlier comparer and hidden ARIA dialog failures; both pass with the production build. --------- Co-authored-by: Amp <amp@ampcode.com>
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1946 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T07:07:18.750Z",
"gitSha": "988a3feda5f778045d0f2627c821649028191b92",
"branch": "backport-18301-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.0830000000246,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.891000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.433,
"heapDeltaBytes": -10960960,
"heapUsedBytes": 58953072,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.989,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2047.0279999999548,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.664000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.59900000000005,
"heapDeltaBytes": -12629992,
"heapUsedBytes": 57607580,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.166000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1851.9339999999715,
"styleRecalcs": 74,
"styleRecalcDurationMs": 21.242000000000004,
"layouts": 14,
"layoutDurationMs": 3.192,
"taskDurationMs": 763.544,
"heapDeltaBytes": 3696076,
"heapUsedBytes": 74586452,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 118.908,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1782.652999999982,
"styleRecalcs": 76,
"styleRecalcDurationMs": 21.56,
"layouts": 14,
"layoutDurationMs": 3.226,
"taskDurationMs": 743.7719999999999,
"heapDeltaBytes": -1054476,
"heapUsedBytes": 69805420,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 121.11900000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.328999999962,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.888999999999998,
"layouts": 6,
"layoutDurationMs": 0.9159999999999999,
"taskDurationMs": 310.49399999999997,
"heapDeltaBytes": 4704708,
"heapUsedBytes": 75782020,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.123000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.8950000000077,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.579,
"layouts": 6,
"layoutDurationMs": 0.9480000000000001,
"taskDurationMs": 312.988,
"heapDeltaBytes": 4563148,
"heapUsedBytes": 75640332,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.978,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 564.5489999999995,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.224,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.09400000000005,
"heapDeltaBytes": -8210256,
"heapUsedBytes": 63149796,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 128.53099999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 545.5349999999726,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.791,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.84700000000004,
"heapDeltaBytes": 18413232,
"heapUsedBytes": 88989920,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 125.563,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.1380000000368,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.527000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.141,
"heapDeltaBytes": 7088692,
"heapUsedBytes": 83524108,
"domNodes": -274,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 23.489000000000004,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2020.7850000000462,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.262000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.421,
"heapDeltaBytes": 10823192,
"heapUsedBytes": 87539244,
"domNodes": -269,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 22.604,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2150.927999999965,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.761000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1379.029,
"heapDeltaBytes": 338456,
"heapUsedBytes": 77603520,
"domNodes": -238,
"jsHeapTotalBytes": 905216,
"scriptDurationMs": 637.4730000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2119.36199999991,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.716999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1349.875,
"heapDeltaBytes": 4495988,
"heapUsedBytes": 81420440,
"domNodes": -273,
"jsHeapTotalBytes": -929792,
"scriptDurationMs": 633.3839999999999,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3223.8989999999603,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.287999999999998,
"layouts": 60,
"layoutDurationMs": 9.681,
"taskDurationMs": 1429.2949999999998,
"heapDeltaBytes": -4075492,
"heapUsedBytes": 74694356,
"domNodes": -288,
"jsHeapTotalBytes": 3039232,
"scriptDurationMs": 581.52,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3204.4539999999415,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.432,
"layouts": 60,
"layoutDurationMs": 10.032,
"taskDurationMs": 1447.4550000000002,
"heapDeltaBytes": -3601784,
"heapUsedBytes": 74566088,
"domNodes": -290,
"jsHeapTotalBytes": 4087808,
"scriptDurationMs": 602.4209999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2344.982000000016,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.6910000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1520.361,
"heapDeltaBytes": 17775044,
"heapUsedBytes": 98209400,
"domNodes": 12,
"jsHeapTotalBytes": 6709248,
"scriptDurationMs": 713.5640000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2314.9660000000267,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.5329999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1579.704,
"heapDeltaBytes": -7592716,
"heapUsedBytes": 72836140,
"domNodes": -252,
"jsHeapTotalBytes": -368640,
"scriptDurationMs": 736.148,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.3259999999982,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.790000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.205,
"heapDeltaBytes": 8914940,
"heapUsedBytes": 86926248,
"domNodes": -273,
"jsHeapTotalBytes": -2465792,
"scriptDurationMs": 28.831999999999997,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.8359999999311,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.398000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.25299999999993,
"heapDeltaBytes": 21728184,
"heapUsedBytes": 88273856,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.213,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 541.4279999999962,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.14599999999996,
"heapDeltaBytes": 14807812,
"heapUsedBytes": 88022788,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 108.18700000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.7149999999929,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.097000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.7830000000001,
"heapDeltaBytes": 13929244,
"heapUsedBytes": 86335944,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 111.889,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.0129999999722,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.833,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.43799999999993,
"heapDeltaBytes": -4874524,
"heapUsedBytes": 68401056,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.496000000000002,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2003.971999999976,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.026000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.617,
"heapDeltaBytes": -7820748,
"heapUsedBytes": 64589280,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.925999999999998,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.7149999999974,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.549999999999997,
"layouts": 18,
"layoutDurationMs": 3.536,
"taskDurationMs": 672.728,
"heapDeltaBytes": -9796700,
"heapUsedBytes": 62733408,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 78.64,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.2409999999727,
"styleRecalcs": 76,
"styleRecalcDurationMs": 20.351000000000003,
"layouts": 18,
"layoutDurationMs": 3.941,
"taskDurationMs": 695.629,
"heapDeltaBytes": -15039476,
"heapUsedBytes": 57988736,
"domNodes": -297,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 77.80199999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 984.7209999999791,
"styleRecalcs": 21,
"styleRecalcDurationMs": 26.594,
"layouts": 17,
"layoutDurationMs": 11.998,
"taskDurationMs": 806.6899999999999,
"heapDeltaBytes": 21930920,
"heapUsedBytes": 106463436,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 22.941999999999997,
"eventListeners": 2385,
"totalBlockingTimeMs": 137,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8190.8240000000205,
"styleRecalcs": 249,
"styleRecalcDurationMs": 24.943,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4723.133,
"heapDeltaBytes": -8295608,
"heapUsedBytes": 67967068,
"domNodes": -277,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 2095.233,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8194.598999999926,
"styleRecalcs": 249,
"styleRecalcDurationMs": 25.486999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4693.927,
"heapDeltaBytes": -8388264,
"heapUsedBytes": 67839940,
"domNodes": -275,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 2048.917,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12621.197999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11731.387999999999,
"heapDeltaBytes": -34382544,
"heapUsedBytes": 178068660,
"domNodes": -8068,
"jsHeapTotalBytes": -16953344,
"scriptDurationMs": 158.314,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13018.101999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12329.310000000001,
"heapDeltaBytes": -27770732,
"heapUsedBytes": 183474344,
"domNodes": -8068,
"jsHeapTotalBytes": -9863168,
"scriptDurationMs": 171.45099999999996,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15501.690000000053,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.004999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14941.338,
"heapDeltaBytes": -73377172,
"heapUsedBytes": 164984780,
"domNodes": -8068,
"jsHeapTotalBytes": -16678912,
"scriptDurationMs": 772.0559999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 84,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15333.585000000085,
"styleRecalcs": 72,
"styleRecalcDurationMs": 11.957999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14856.518999999998,
"heapDeltaBytes": -52194852,
"heapUsedBytes": 164989240,
"domNodes": -8068,
"jsHeapTotalBytes": -9756672,
"scriptDurationMs": 733.2,
"eventListeners": -14931,
"totalBlockingTimeMs": 10,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4531.470000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.56700000000002,
"layouts": 20,
"layoutDurationMs": 25.676000000000005,
"taskDurationMs": 4358.2609999999995,
"heapDeltaBytes": -40631080,
"heapUsedBytes": 177401932,
"domNodes": -8068,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 87.27399999999999,
"eventListeners": -14933,
"totalBlockingTimeMs": 183,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4453.003999999964,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.66200000000002,
"layouts": 20,
"layoutDurationMs": 19.354999999999997,
"taskDurationMs": 4322.853,
"heapDeltaBytes": -40564488,
"heapUsedBytes": 177473628,
"domNodes": -8068,
"jsHeapTotalBytes": 11530240,
"scriptDurationMs": 85.873,
"eventListeners": -14928,
"totalBlockingTimeMs": 35,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6294.693999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6057.173000000001,
"heapDeltaBytes": 12098940,
"heapUsedBytes": 176921904,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 77.289,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6307.366000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5955.356999999999,
"heapDeltaBytes": 2013464,
"heapUsedBytes": 176905640,
"domNodes": 0,
"jsHeapTotalBytes": -27262976,
"scriptDurationMs": 96.49500000000005,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 438.036000000011,
"styleRecalcs": 13,
"styleRecalcDurationMs": 13.468,
"layouts": 2,
"layoutDurationMs": 0.48899999999999993,
"taskDurationMs": 88.152,
"heapDeltaBytes": 4778868,
"heapUsedBytes": 73142624,
"domNodes": 122,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.8660000000000005,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 91.98200000002998,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.054000000000002,
"layouts": 2,
"layoutDurationMs": 1.327,
"taskDurationMs": 58.71699999999999,
"heapDeltaBytes": 2987080,
"heapUsedBytes": 72082524,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.099,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #18471 +/- ##
==========================================
Coverage 83.62% 83.62%
==========================================
Files 2097 2098 +1
Lines 123870 123893 +23
Branches 33405 33409 +4
==========================================
+ Hits 103583 103607 +24
+ Misses 20108 20107 -1
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Manual backport of #18301 to
core/1.54.Cherry-picked from upstream merge commit
1344a91e0e5fd03ce2131bacf30d1faca7dcd26a.Why
Restores extension value-setter side effects for Impact Preview Bridge, live
disabledgetters for WAS Pause across both renderers, and overridden node serialization used by MiniMax RefMod.Conflict resolution
browser_tests/tests/loadWorkflowInMedia.spec.ts— retained the target branch's settings setup and added the source PR's fixed Load Image object-info options so concurrent uploads cannot alter media snapshots.src/components/graph/GraphCanvas.vue— retained the target branch's renderer transition flow and added only the live-disabled refresh. The target does not contain main's newer widget-visibility synchronization layer.src/lib/litegraph/src/types/widgets.ts— added the optionalsyncLiveDisabledcontract without introducing main-only visibility APIs.src/lib/litegraph/src/widgets/BaseWidget.ts— added live-disabled synchronization to the target branch's existing store-backed widget implementation.src/lib/litegraph/src/widgets/widgetMap.ts— preserved the target branch's accessor-merging algorithm and made a foreigndisabledgetter authoritative, matching the source fix without replacing older extension semantics.The six PRs listed by the failed automation were checked. Their changed files are unrelated to this backport; waiting for the four still-open PRs would not remove these conflicts.
Validation
pnpm test:unit src/lib/litegraph/src/LGraph.serialise.test.ts src/lib/litegraph/src/widgets/widgetMap.test.ts src/core/graph/widgets/nodeWidgetValues.test.ts— 3 files, 31 tests passedpnpm lint— passed in the commit hookpnpm typecheck— passed in the commit hookpnpm typecheck:browser— passed in the commit hookpnpm build— passed (existing ineffective-dynamic-import warnings only)pnpm exec oxfmt --check <changed source files>— passedpython -m py_compile tools/devtools/nodes/inputs.py— passedpnpm knip— passed in the push hookThe three DevTools-backed Playwright regressions require a production frontend and the ComfyUI CI backend image. The orb could not access the cached private image and began the documented ~10 GB source fallback; that environment setup did not complete in a practical window, so those tests were not rerun here. They passed on the source PR.
Oracle reviewed the public LiteGraph/widget conflict resolutions and found no compatibility blocker or missing shim.
Original PR: #18301
Original commit:
1344a91e0e5fd03ce2131bacf30d1faca7dcd26a