Repository navigation
[backport core/1.54] FE-2033: fix(agent): project define_subgraph definitions cleanly - #18407
Conversation
) - Projects nested `define_subgraph` definitions without cmp-private bookkeeping. - Reuses the app's existing subgraph creation lifecycle before host materialization. - Focused tests and all requested gates are green. Justification: Christian's full integration/admin-merge grant, explicitly confirmed by the [release coordinator](https://ampcode.com/threads/T-01a0a6f4-ce4d-71c8-aa44-be96c230a4e5), authorizes only [c962fcd](c962fcd) after successful hosted checks. The [current-head substantive review](#17458 (review)) finds the mandatory-lookup objection addressed; it is an author-identity COMMENT, not non-author approval. The newer main delta contains only browser documentation/spec changes. This exact-merge compatibility decision supersedes the older program guard's current-main-ancestry and separate-human-approval prerequisites; that guard is not recorded as passing. All 102 checks were terminal before this update: 86 successful and 16 skipped. No reviewer state or thread is dismissed or resolved, and no runtime or release acceptance is claimed. Fresh readback remains required immediately before merge. <details><summary>Full context for agent readers</summary> ## What changed The cmp `define_subgraph` applier writes the normal Yjs definition shape plus `__definition_digest`, a private replay/conflict key. `agentSubgraphDefinitions.ts` now removes that key recursively from root and nested `ExportedSubgraph` projections; its regression tests prove the private field is absent from the projected `ExportedSubgraph` before LiteGraph consumes it. The lifecycle probe found that [the stacked follower change](#17202) already supplies the required frontend lifecycle. Before reconciling root nodes, `reconcileAgentAdapters` registers each missing definition with `rootGraph.createSubgraph`. `LGraph.createSubgraph` normalizes definitions, registers the `Subgraph`, dispatches `subgraph-created`, and configures nested definitions in dependency order. The app event handler then calls `registerNewSubgraph`, which registers the definition id with the `LiteGraph.createNode` factory. Host nodes are subsequently created through that factory and registered by the normal ECS adapter path. Existing integration tests cover: - one `subgraph-created` event per newly observed definition; - a real `SubgraphNode` host created through the registered factory; - no live mutation when a later payload reuses an already registered id; - nested-definition registration, including partially registered trees; - rollback removes a failed definition from `rootGraph.subgraphs` and leaves its host unmaterialized when configuration fails. This PR therefore makes the minimum compatibility change for [the `define_subgraph` applier](#17454) rather than duplicating lifecycle code already owned by the stacked follower branch. Design reference: [agent-added subgraph lifecycle technical design](https://www.notion.so/3d16d73d365081719b85ed515af98276). ## RED to GREEN evidence RED commit `d3057115eb`: ```text Test Files 1 failed (1) Tests 1 failed | 13 passed (14) Received definition retained __definition_digest. ``` GREEN commit `94bce71459`: ```text Test Files 1 passed (1) Tests 14 passed (14) ``` Follow-up commit `3853b94e20` adds a two-level nested regression test. Before the fix, `drops define_subgraph bookkeeping from nested definitions recursively` failed because both nested digests survived; after the fix, all 15 reader tests pass. ## Gates - Focused CRDT Vitest: 3 files, 64 tests passed. - `pnpm typecheck`: passed. - Scoped ESLint, type-aware oxlint, and oxfmt: passed. - Fallow audit: passed with zero introduced findings. ## Vetoable decisions - Keep this stacked on [the existing-subgraph follower change](#17202); the frontend consumes raw Yjs state rather than importing the cmp operation. - Keep `__definition_digest` cmp-private and exclude it from the live `ExportedSubgraph` projection. - Keep creation-only ownership: once an id exists in `rootGraph.subgraphs`, later definition payloads cannot reconfigure the live subgraph. - Do not add a browser test: the deterministic Vitest integration already crosses Yjs mint/update, follower, ECS adapter, real `LGraph`, lifecycle event, factory registration, and `SubgraphNode` materialization without browser-only behavior. </details> --------- Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 1938 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T08:13:42.961Z",
"gitSha": "653369c4e9f8f2286f331f6bc5ad5d5d63e64fc4",
"branch": "backport-17458-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2045.1470000000427,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.194000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.329,
"heapDeltaBytes": -7462208,
"heapUsedBytes": 62886908,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.842999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2053.937000000019,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.380000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.5,
"heapDeltaBytes": -11441868,
"heapUsedBytes": 57503912,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.984000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1835.930000000019,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.558,
"layouts": 14,
"layoutDurationMs": 3.7680000000000007,
"taskDurationMs": 862.697,
"heapDeltaBytes": 7461136,
"heapUsedBytes": 78219988,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 157.53,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1886.5690000000086,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.5,
"layouts": 14,
"layoutDurationMs": 4.147,
"taskDurationMs": 893.3720000000001,
"heapDeltaBytes": -6655104,
"heapUsedBytes": 62363776,
"domNodes": -279,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 162.238,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.51799999997,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.349,
"layouts": 6,
"layoutDurationMs": 1.058,
"taskDurationMs": 367.053,
"heapDeltaBytes": 4671832,
"heapUsedBytes": 75120664,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.654000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.947000000022,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.884000000000002,
"layouts": 6,
"layoutDurationMs": 0.972,
"taskDurationMs": 355.96700000000004,
"heapDeltaBytes": 4575196,
"heapUsedBytes": 75849840,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.55,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 660.5209999999602,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.77,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.98499999999996,
"heapDeltaBytes": 18399328,
"heapUsedBytes": 83294572,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 163.622,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 643.5490000000073,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.927000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.98199999999997,
"heapDeltaBytes": 18769476,
"heapUsedBytes": 88352432,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 164.69899999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2072.8300000000104,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.921000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 657.8030000000001,
"heapDeltaBytes": 8724324,
"heapUsedBytes": 85227440,
"domNodes": -271,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 37.26399999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2056.2909999999874,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.262999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.6320000000001,
"heapDeltaBytes": 6752996,
"heapUsedBytes": 82908728,
"domNodes": -274,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 37.49799999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2366.5619999999876,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.212999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1745.164,
"heapDeltaBytes": 8353220,
"heapUsedBytes": 85687444,
"domNodes": -276,
"jsHeapTotalBytes": -405504,
"scriptDurationMs": 858.9519999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2289.3040000000155,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.963,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1709.0739999999998,
"heapDeltaBytes": -8761052,
"heapUsedBytes": 68756724,
"domNodes": -282,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 845.386,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3591.054999999983,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.411000000000003,
"layouts": 60,
"layoutDurationMs": 11.843,
"taskDurationMs": 1687.8320000000003,
"heapDeltaBytes": 9907040,
"heapUsedBytes": 76754400,
"domNodes": -277,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 768.867,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3571.5249999999514,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.520000000000001,
"layouts": 60,
"layoutDurationMs": 11.693,
"taskDurationMs": 1729.0349999999999,
"heapDeltaBytes": 10912624,
"heapUsedBytes": 77528096,
"domNodes": -282,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 809.7610000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3110.437999999988,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.934000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1947.908,
"heapDeltaBytes": 22460332,
"heapUsedBytes": 89985568,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 978.1869999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3150.8119999999735,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.691999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1940.544,
"heapDeltaBytes": 25285520,
"heapUsedBytes": 92516516,
"domNodes": -278,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 966.4999999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2006.9449999999733,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.396,
"heapDeltaBytes": 21801148,
"heapUsedBytes": 88137952,
"domNodes": -11,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.339000000000006,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.7340000000386,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.259999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 621.4060000000001,
"heapDeltaBytes": 5366624,
"heapUsedBytes": 82045296,
"domNodes": -276,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 36.763000000000005,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.5099999999802,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.967,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.53499999999997,
"heapDeltaBytes": 14580216,
"heapUsedBytes": 86309028,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 141.523,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.4459999999954,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.287,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.54800000000006,
"heapDeltaBytes": 14998476,
"heapUsedBytes": 87234600,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 143.793,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.7830000000085,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.080999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.152,
"heapDeltaBytes": -521640,
"heapUsedBytes": 71543344,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.1739999999999995,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2034.63899999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.722000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.48500000000007,
"heapDeltaBytes": -5725788,
"heapUsedBytes": 67054460,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.098999999999998,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.4579999999505,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.509,
"layouts": 18,
"layoutDurationMs": 4.975999999999999,
"taskDurationMs": 808.7180000000001,
"heapDeltaBytes": 2108744,
"heapUsedBytes": 68242736,
"domNodes": -297,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 111.983,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.671000000038,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.606,
"layouts": 18,
"layoutDurationMs": 5.231999999999999,
"taskDurationMs": 831.4019999999999,
"heapDeltaBytes": -9127640,
"heapUsedBytes": 62878824,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 113.66999999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1415.7329999999888,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.135000000000005,
"layouts": 15,
"layoutDurationMs": 17.688000000000002,
"taskDurationMs": 987.2440000000003,
"heapDeltaBytes": 21369208,
"heapUsedBytes": 106404592,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 32.37,
"eventListeners": 2385,
"totalBlockingTimeMs": 154,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8557.67800000001,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.197,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5930.011,
"heapDeltaBytes": 9514464,
"heapUsedBytes": 85151744,
"domNodes": -270,
"jsHeapTotalBytes": -667648,
"scriptDurationMs": 2733.056,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8348.66999999997,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.501000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5761.366,
"heapDeltaBytes": 23662284,
"heapUsedBytes": 89212088,
"domNodes": -268,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2712.345,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16856.524999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16396.262,
"heapDeltaBytes": -59570804,
"heapUsedBytes": 178270456,
"domNodes": -8068,
"jsHeapTotalBytes": -16408576,
"scriptDurationMs": 311.40900000000005,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17280.55299999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16652.141,
"heapDeltaBytes": -39207404,
"heapUsedBytes": 178876468,
"domNodes": -8068,
"jsHeapTotalBytes": -7110656,
"scriptDurationMs": 272.194,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20949.405000000013,
"styleRecalcs": 173,
"styleRecalcDurationMs": 17.540999999999972,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20587.183999999997,
"heapDeltaBytes": -48053248,
"heapUsedBytes": 167085096,
"domNodes": -8068,
"jsHeapTotalBytes": -17592320,
"scriptDurationMs": 918.224,
"eventListeners": -14929,
"totalBlockingTimeMs": 76,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21027.010000000017,
"styleRecalcs": 171,
"styleRecalcDurationMs": 17.286999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20701.945000000003,
"heapDeltaBytes": -36438604,
"heapUsedBytes": 178752444,
"domNodes": -8068,
"jsHeapTotalBytes": -21524480,
"scriptDurationMs": 903.174,
"eventListeners": -14929,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6228.030999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.90400000000002,
"layouts": 20,
"layoutDurationMs": 22.075999999999997,
"taskDurationMs": 6073.68,
"heapDeltaBytes": -55268856,
"heapUsedBytes": 183248748,
"domNodes": -8068,
"jsHeapTotalBytes": 8495104,
"scriptDurationMs": 113.798,
"eventListeners": -14927,
"totalBlockingTimeMs": 380,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6248.336999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.04900000000004,
"layouts": 20,
"layoutDurationMs": 22.04199999999999,
"taskDurationMs": 6116.336999999999,
"heapDeltaBytes": -43517580,
"heapUsedBytes": 184120972,
"domNodes": -8068,
"jsHeapTotalBytes": 8495104,
"scriptDurationMs": 119.899,
"eventListeners": -14929,
"totalBlockingTimeMs": 406,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8627.84099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8371.927999999998,
"heapDeltaBytes": 659672,
"heapUsedBytes": 178479636,
"domNodes": 0,
"jsHeapTotalBytes": -18612224,
"scriptDurationMs": 140.84400000000008,
"eventListeners": -16,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8942.937999999913,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8456.361,
"heapDeltaBytes": 18929488,
"heapUsedBytes": 178400916,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 141.0800000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 109.91999999998825,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.502,
"layouts": 3,
"layoutDurationMs": 1.7890000000000001,
"taskDurationMs": 79.35400000000001,
"heapDeltaBytes": 3043376,
"heapUsedBytes": 71550800,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.283999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 89.9499999999307,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.119999999999997,
"layouts": 2,
"layoutDurationMs": 0.7800000000000001,
"taskDurationMs": 60.842000000000006,
"heapDeltaBytes": 2991996,
"heapUsedBytes": 72155656,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.636999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #18407 +/- ##
==========================================
Coverage 83.56% 83.56%
==========================================
Files 2094 2094
Lines 123648 123683 +35
Branches 31499 31512 +13
==========================================
+ Hits 103325 103360 +35
Misses 20144 20144
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…Image node bypassing upload (#18464) Automated backport of #18180 to `core/1.54`. The bot's auto-backport (`comfy-pr-bot`) failed on this branch with merge conflicts in: - `src/extensions/core/load3d/Load3DConfiguration.test.ts` - `src/extensions/core/load3d/Load3DConfiguration.ts` - `src/utils/createAnnotatedPath.test.ts` ## Root cause of the conflict Not a stacking conflict against any of the PRs the bot listed as still-open on `core/1.54` (#18417, #18410, #18407, #18369, #18354, #18334, #17872) — none of them touch these files. The real cause is that `core/1.54` never received an **already-merged, unrelated** PR: #17537 ("Load3D preview capture stale after agent-driven model_file change"), which is not on the bot's open-PR list and is not itself labeled for backport. That PR: - added a `DEFAULT_GIZMO`/`GizmoConfig` block to `Load3DConfiguration.ts` right next to the `parseAnnotatedFilename` helper that #18180 deletes (textual adjacency, not a real dependency — I did not port the gizmo code, since it's out of scope here and `core/1.54` has no other reference to it), and added `ComfyApi`/`ComfyApp` test imports unused on this branch (dropped), - moved the `ResultItem` type from `@/schemas/apiSchema` to `@/platform/remote/comfyui/execution/types` on `main`, which `core/1.54` hasn't picked up (kept the branch's existing `@/schemas/apiSchema` import), and - added an `app.getRandParam()` call inside `nodeOutputStore.ts` (already present on `core/1.54` from an earlier point, unrelated to #18180) whose test mock in `nodeOutputStore.test.ts` was missing `getRandParam`, only surfaced now because #18180's new test is the first to exercise `getNodeImageUrls()` on this file — added the missing mock entry. Resolved by taking #18180's actual change (removing the local `parseAnnotatedFilename` in favor of the shared `parseAnnotatedPath` util) while leaving everything from #17537 out, since it isn't part of this branch. ## Verification - `pnpm exec vitest run` on the touched spec files (`Load3DConfiguration.test.ts`, `createAnnotatedPath.test.ts`, `nodeOutputStore.test.ts`, `imageUtil.test.ts`) — all pass (113/113) - `pnpm typecheck` — clean - `pnpm exec eslint` on changed files — no errors (2 pre-existing `apiSchema` deprecation warnings, unrelated to this change) - `pnpm exec oxfmt --check` on changed files — clean - The new Playwright e2e (`assetPanelDragOntoLoadImageWidget.spec.ts`) was not run locally (no backend available), consistent with the original PR's own review notes. <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-org.slack.com/archives/C0BGH348Z0C/p1789875316334739)_ --- _Generated by [Claude Code](https://claude.ai/code/session_01Ws2BqUcMwaeUuPpKdYNxPV)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
Backport of #17458 to
core/1.54Automatically created by backport workflow.