Repository navigation
FE-2033: fix(agent): project define_subgraph definitions cleanly - #17458
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe change hardens subgraph definition projection by recursively removing unsafe and bookkeeping keys. It preserves registered node and link order, validates projected definitions, and expands typed CRDT tests for nested, invalid, duplicate, and unsupported records. ChangesSubgraph projection hardening
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Suggested reviewers: Merge Risk: 🟡 Moderate · up to Named-widget values may still bypass unsafe-key sanitization in projected subgraph data, so this security-related concern should be resolved before merging. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2090 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.96 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 123 kB (baseline 123 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.91 MB (baseline 3.91 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 302 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T07:42:02.420Z",
"gitSha": "300c850e577117d933788766942f03b5733e9fe5",
"branch": "christian-byrne/agent-define-subgraph-lifecycle",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1993.7999999999647,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.675,
"heapDeltaBytes": -4791188,
"heapUsedBytes": 57626960,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.4590000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 1992.9130000000441,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.551000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.07599999999996,
"heapDeltaBytes": -6204760,
"heapUsedBytes": 56163756,
"domNodes": -259,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.8599999999999985,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.5419999999795,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.936000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.24,
"heapDeltaBytes": -3569568,
"heapUsedBytes": 58743488,
"domNodes": -258,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 102.17399999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1716.874999999959,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.071000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.252,
"heapDeltaBytes": 9997884,
"heapUsedBytes": 77452636,
"domNodes": -257,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 103.80300000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.760999999995,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.98,
"layouts": 6,
"layoutDurationMs": 0.977,
"taskDurationMs": 258.529,
"heapDeltaBytes": 2173684,
"heapUsedBytes": 64500520,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.674,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.0250000000342,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.266,
"layouts": 6,
"layoutDurationMs": 0.8999999999999999,
"taskDurationMs": 258.93899999999996,
"heapDeltaBytes": 3220948,
"heapUsedBytes": 70661428,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.883,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 515.7350000000065,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.731,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 314.42900000000003,
"heapDeltaBytes": 18885976,
"heapUsedBytes": 86131588,
"domNodes": 19,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 113.11399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 515.9350000000131,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.527999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.29400000000004,
"heapDeltaBytes": 18267548,
"heapUsedBytes": 86181004,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 116.62199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1047.9159999999865,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.902,
"heapDeltaBytes": -18184972,
"heapUsedBytes": 72246440,
"domNodes": -291,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 43.729000000000006,
"eventListeners": -217,
"totalBlockingTimeMs": 407,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1035.383999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 693.3710000000001,
"heapDeltaBytes": -17527652,
"heapUsedBytes": 72681680,
"domNodes": -294,
"jsHeapTotalBytes": 19529728,
"scriptDurationMs": 45.766,
"eventListeners": -217,
"totalBlockingTimeMs": 393,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 748.2029999999895,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.5659999999998,
"heapDeltaBytes": 15447156,
"heapUsedBytes": 92157788,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 107.978,
"eventListeners": 0,
"totalBlockingTimeMs": 121,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 728.8130000000592,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 317.2389999999998,
"heapDeltaBytes": 14609552,
"heapUsedBytes": 90975012,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 96.64900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 113,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6517.356000000007,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.7120000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5657.697,
"heapDeltaBytes": 3053960,
"heapUsedBytes": 85029124,
"domNodes": -16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 4556.446,
"eventListeners": 0,
"totalBlockingTimeMs": 70,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6288.653000000011,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.6510000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5595.813999999999,
"heapDeltaBytes": 3441092,
"heapUsedBytes": 85413908,
"domNodes": -14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 4317.634,
"eventListeners": 0,
"totalBlockingTimeMs": 48,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6451.121000000001,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.4160000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5693.111,
"heapDeltaBytes": -5336920,
"heapUsedBytes": 71392700,
"domNodes": -268,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 4382.063,
"eventListeners": -174,
"totalBlockingTimeMs": 40,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6420.5529999999835,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5750000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5767.936000000001,
"heapDeltaBytes": -13807656,
"heapUsedBytes": 68322200,
"domNodes": -16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 4499.731,
"eventListeners": 0,
"totalBlockingTimeMs": 41,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2009.3760000000316,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.267,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.7410000000001,
"heapDeltaBytes": -9364516,
"heapUsedBytes": 78450692,
"domNodes": -244,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 28.301000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2023.5400000000254,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.203000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.8210000000001,
"heapDeltaBytes": -1719432,
"heapUsedBytes": 79329148,
"domNodes": -243,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 28.005000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2125.440000000026,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.987000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1233.0130000000001,
"heapDeltaBytes": 21848680,
"heapUsedBytes": 85873120,
"domNodes": -240,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 609.2370000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2103.939999999966,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.397,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1174.6729999999998,
"heapDeltaBytes": 16777124,
"heapUsedBytes": 80828860,
"domNodes": -238,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 583.12,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3117.658000000006,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.179,
"layouts": 60,
"layoutDurationMs": 10.03,
"taskDurationMs": 1237.884,
"heapDeltaBytes": -16216248,
"heapUsedBytes": 73882792,
"domNodes": -253,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 525.907,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3122.109000000023,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.661999999999999,
"layouts": 60,
"layoutDurationMs": 9.927999999999999,
"taskDurationMs": 1235.053,
"heapDeltaBytes": 9460492,
"heapUsedBytes": 74579452,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 548.339,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2112.856000000022,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.233999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1224.436,
"heapDeltaBytes": 17278220,
"heapUsedBytes": 87321844,
"domNodes": 10,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 638.221,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2213.184999999953,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.058999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1371.361,
"heapDeltaBytes": -9092396,
"heapUsedBytes": 82390312,
"domNodes": -246,
"jsHeapTotalBytes": 1495040,
"scriptDurationMs": 647.2470000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.956000000012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.383999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.632,
"heapDeltaBytes": 20210888,
"heapUsedBytes": 84124952,
"domNodes": -237,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 23.836000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2017.488999999955,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.9429999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.50100000000003,
"heapDeltaBytes": -4981448,
"heapUsedBytes": 84052404,
"domNodes": -247,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 23.741000000000007,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 477.3899999999571,
"styleRecalcs": 49,
"styleRecalcDurationMs": 8.201,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 288.426,
"heapDeltaBytes": 13749264,
"heapUsedBytes": 83512472,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 97.917,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 479.8150000000305,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.712999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.67499999999995,
"heapDeltaBytes": 13654960,
"heapUsedBytes": 83508888,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 103.22200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.0730000000049,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.3870000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.85699999999997,
"heapDeltaBytes": -3898552,
"heapUsedBytes": 59219200,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.398999999999997,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1994.1969999999856,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.676999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.77399999999994,
"heapDeltaBytes": -5312304,
"heapUsedBytes": 64571248,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.6049999999999995,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.395999999978,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.812,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.7639999999999,
"heapDeltaBytes": -7680088,
"heapUsedBytes": 62055680,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 68.867,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.676999999956,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.166999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.97,
"heapDeltaBytes": -6870092,
"heapUsedBytes": 62927372,
"domNodes": -274,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 69.797,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 880.9049999999843,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.108999999999995,
"layouts": 5,
"layoutDurationMs": 8.427000000000001,
"taskDurationMs": 691.7489999999999,
"heapDeltaBytes": -6271888,
"heapUsedBytes": 81604388,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 21.339999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 103,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8179.221999999982,
"styleRecalcs": 252,
"styleRecalcDurationMs": 25.096999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4118.222000000001,
"heapDeltaBytes": -11637212,
"heapUsedBytes": 68838604,
"domNodes": -207,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 1882.4889999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8157.372999999893,
"styleRecalcs": 250,
"styleRecalcDurationMs": 25.645,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4108.048,
"heapDeltaBytes": -7399472,
"heapUsedBytes": 80084896,
"domNodes": -240,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 1856.829,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 8449.663999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7482.316,
"heapDeltaBytes": -39843308,
"heapUsedBytes": 187942852,
"domNodes": -8062,
"jsHeapTotalBytes": -14094336,
"scriptDurationMs": 123.584,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 11291.634000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10594.444,
"heapDeltaBytes": -37507892,
"heapUsedBytes": 182212804,
"domNodes": -8062,
"jsHeapTotalBytes": -10481664,
"scriptDurationMs": 161.94599999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14247.176999999965,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.089000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13577.157,
"heapDeltaBytes": -34460616,
"heapUsedBytes": 185461592,
"domNodes": -8062,
"jsHeapTotalBytes": -13946880,
"scriptDurationMs": 675.941,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14551.016000000003,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.696999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13974.693,
"heapDeltaBytes": -44328960,
"heapUsedBytes": 169244980,
"domNodes": -8062,
"jsHeapTotalBytes": -13352960,
"scriptDurationMs": 708.765,
"eventListeners": -14928,
"totalBlockingTimeMs": 17,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4281.211999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.190999999999995,
"layouts": 20,
"layoutDurationMs": 22.05199999999999,
"taskDurationMs": 4177.1140000000005,
"heapDeltaBytes": -43324428,
"heapUsedBytes": 169801316,
"domNodes": -8062,
"jsHeapTotalBytes": 11288576,
"scriptDurationMs": 74.025,
"eventListeners": -14929,
"totalBlockingTimeMs": 122,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4213.530999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.13500000000002,
"layouts": 20,
"layoutDurationMs": 20.135,
"taskDurationMs": 4093.1769999999988,
"heapDeltaBytes": -37315504,
"heapUsedBytes": 188367804,
"domNodes": -8062,
"jsHeapTotalBytes": 13885440,
"scriptDurationMs": 68.726,
"eventListeners": -14928,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5876.656000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5390.017999999999,
"heapDeltaBytes": 5967892,
"heapUsedBytes": 183147944,
"domNodes": 0,
"jsHeapTotalBytes": -26738688,
"scriptDurationMs": 86.17099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6080.112999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5513.987999999999,
"heapDeltaBytes": 864836,
"heapUsedBytes": 189073276,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 106.42200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 448.695999999984,
"styleRecalcs": 22,
"styleRecalcDurationMs": 21.656000000000002,
"layouts": 5,
"layoutDurationMs": 2.102,
"taskDurationMs": 112.364,
"heapDeltaBytes": 5280588,
"heapUsedBytes": 67231348,
"domNodes": 155,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.241,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 438.73599999994894,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.059,
"layouts": 4,
"layoutDurationMs": 1.607,
"taskDurationMs": 88.66300000000001,
"heapDeltaBytes": 5058352,
"heapUsedBytes": 70719864,
"domNodes": 148,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.145999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 88a0f2a6bb413187b29488c160b2336bfd3bc4d8
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 3 |
Panel: 8/8 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #17458 +/- ##
==========================================
+ Coverage 83.33% 84.33% +0.99%
==========================================
Files 2985 2283 -702
Lines 147034 129860 -17174
Branches 38007 35094 -2913
==========================================
- Hits 122533 109511 -13022
+ Misses 23219 20054 -3165
+ Partials 1282 295 -987
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 708 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
- P2: Nested subgraph definitions still expose
__definition_digest. - The base does already provide lifecycle routing, synchronous factory registration, and registered-id immutability.
- Requested gates pass at the pinned head; the nested reviewer probe fails as described below.
Full context for agent readers
Findings
- P2 —
src/workbench/extensions/agent/crdt/agentSubgraphDefinitions.ts:93:readDefinitionfilters only the top-level Y.Map. Thedefinitionsfield falls through toplain(value), so nesteddefinitions.subgraphs[*].__definition_digestsurvives projection and is then passed intoLGraph.createSubgraphby the base branch's flattening lifecycle. Recursively project or sanitize nested definitions and add the asymmetric nested case to the regression test.
Scope and lifecycle verification
Reviewed exact PR head 94bce714593d1f6a05e33e61512c8d816f2b16ec against base 003300bc46c38f7a880b67bb16aa0cdbafa55306. The diff changes only digest filtering and its test.
The PR body's base-branch claim is correct: reconcileAgentAdapters registers missing definitions through rootGraph.createSubgraph before node reconciliation; LGraph emits subgraph-created; the app handler synchronously registers the node factory; and the materializer skips definitions whose IDs are already in rootGraph.subgraphs. Reviewer probes confirmed the lifecycle event occurs before host materialization and a changed later payload does not alter the registered object or its nodes. Definitions that fail registration remain pending and do not become placeholders.
Verification
pnpm install --frozen-lockfileunder bundled Node v25.9.0: passed (Done in 3.6s).pnpm vitest run src/workbench/extensions/agent/crdt: passed, 36 files and 530 tests.pnpm typecheck: passed (vue-tsc --noEmit, exit 0).pnpm lint: passed, 0 errors and 225 warnings.- Reviewer-only nested digest probe: failed, 1 failed / 14 skipped; received
"cmp-owned-digest"for nested__definition_digest. - Reviewer-only lifecycle and re-delivery probes: passed, 2 passed / 38 skipped.
- All reviewer-only probes were removed; final worktree is clean.
Not verified
The exact requested source ~/.nvm/nvm.sh && nvm use 25 prefix could not run because this orb has no ~/.nvm/nvm.sh; I used the repository-provisioned Node v25.9.0 binary directly. No browser test was run because this is non-UI behavior and the focused real-LGraph Vitest probes exercised the affected lifecycle.
Addresses review feedback: #17458 (comment)
Addresses review feedback: #17458 (comment)
christian-byrne
left a comment
There was a problem hiding this comment.
No blocking findings. All four contract probes passed.
Full context for agent readers
- Reviewed exact head
53056857d60337730aeb7abe3f744b9c4eee499eagainstchristian-byrne/agent-subgraph-s1-s2-follower. - Confirmed all four prior review threads are resolved and re-read each fix.
- CRDT suite: 36 files, 532 tests passed.
- Reviewer probes passed: nested private-key stripping through two definition levels; changed-payload re-delivery preserves the registered object and interior nodes;
subgraph-createdprecedes host materialization; named widget values are visible duringonConfigure. These exercise the real Yjs projection,LGraph.createSubgraph, registration listener, and node classes rather than mocking the units under test. pnpm typecheck: passed.pnpm lint: passed with 0 errors and 225 pre-existing warnings.- Browser coverage is deterministic and feasible by combining
browser_tests/fixtures/ws.tswith the typed agent request/response fixture, then asserting the created host is a real subgraph node after adefine_subgraphframe. It is useful integration coverage, but not required to establish the projection and lifecycle contracts already exercised against real LiteGraph objects here. - Fresh checkout remained clean; no branch changes or pushes.
003300b to
7513e71
Compare
Addresses review feedback: #17458 (comment)
Addresses review feedback: #17458 (comment)
5305685 to
b60b0d7
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Approved at c889d108ce653a056d7484a8c8afadcc80e82bf3. I found no correctness defect in the shipped-code fix. Root and nested private keys are removed before the existing creation-only lifecycle runs, and focused lifecycle probes confirmed registration order and replay behavior.
Non-blocking follow-ups are tracked in Linear: FE-2294, FE-2296, FE-2304, FE-2312.
Findings without an anchorable line
- P2, FE-2312: The PR description says configuration failure rolls back without partial live state. The stacked-base implementation removes the failed entry from
rootGraph.subgraphs, but its own materializer comment records that thesubgraph-createdhandler may already have left a node factory bound to the failedSubgraph. This is pre-existing base behavior, not a defect introduced by this fix. FE-2312 tracks complete factory rollback and its regression test.
Existing findings checked at the current head
- Vacuous optional lookup: fixed. The seeded definition is asserted before mutation.
- Root-only nested filtering: fixed. The recursive test reaches two nested definition levels.
- Literal private-key denylist: fixed. Projection now follows the cmp
__*convention and tests an unknown future key. - Independent nested-filter report: fixed by the same recursive projection proof.
Checked and cleared
- The
__*filter is not a frontend-only invented contract. The linked cmp implementation'sprojectDefinitiondropsk.startsWith('__')and recursively applies that projector to nested subgraphs. - The claim that the digest does not reach LiteGraph holds.
readSubgraphDefinitionsis the direct value source passed to reconciliation, and no downstream step restores removed fields. - The named historical commits resolve and match the described RED/GREEN sequence. Exact-head local checks and CI were also green; no evidence contradicted the listed historical totals.
- The current implementation clones plain values and does not mutate the source Yjs document. FE-2304 only adds a durable regression assertion for that property.
Coverage and verification
Standard depth. Five independent lanes ran: correctness, maintainability, idiomaticity, tests, and documentation. The review covered both changed files and traced the cmp projector, CRDT consumers, LGraph.createSubgraph, event registration, replay, nested registration, and rollback boundaries.
Local checks at the exact head:
pnpm typecheck: passed.- Focused Vitest: 1 file, 19 tests passed.
- Focused lifecycle Vitest: 4 tests passed.
- Scoped ESLint, type-aware oxlint, and oxfmt: passed.
git diff --check: passed.- Fallow audit: passed and covered both changed files; 15 inherited dependency findings were excluded by the new-only gate.
Exact-head CI snapshot before posting: 87 check runs completed, 76 successful and 11 skipped, with no failed, cancelled, or pending runs. The combined commit status was successful.
Ledger reconciliation: 13 candidates received = 3 inline + 1 body + 3 merged + 6 rejected.
| ) | ||
| } | ||
|
|
||
| export function projectSubgraphDefinition( |
There was a problem hiding this comment.
P3, non-blocking, FE-2294: This helper is exported only so its unit test can call it; every production consumer enters through readSubgraphDefinitions. The export also advertises an unchecked conversion from any Y.Map<unknown> to ExportedSubgraph. FE-2294 tracks keeping the helper private and testing through the production boundary.
| describe('projectSubgraphDefinition', () => { | ||
| it('projects ordered records and nested definitions', () => { | ||
| const nested = createTestSubgraphData({ | ||
| nodes: [interiorNode(3)] as never |
There was a problem hiding this comment.
P3, non-blocking, FE-2296: The added cases use as never for incomplete node/link fixtures and later use non-null assertions after matchers that do not narrow. That hides serialized-shape drift from TypeScript. FE-2296 tracks typed fixtures and real narrowing.
| source.set('__definition_digest', 'private') | ||
| source.set('__proto__', { polluted: true }) | ||
|
|
||
| expect(projectSubgraphDefinition(source)).toEqual({ id: 'definition' }) |
There was a problem hiding this comment.
P3, non-blocking, FE-2304: The output assertions are good, but none re-reads the root and nested Yjs source after projection. An in-place sanitizer could satisfy all current expectations while mutating shared CRDT state. The current implementation clones correctly; FE-2304 tracks the missing immutability regression.
The base branch was changed.
A changed link still present in the doc but unreadable (cmp re-minted it onto an undeclared promoted slot) was neither connected nor removed, leaving the previous live topology attached. Addresses review feedback: #17202 (comment)
A live SubgraphNode host routed through reconcileNode (or delete + addNode) loses its promoted widgets because updateNode replaces the host's input list in place, dropping the widgetId/_subgraphSlot bindings. Route every follower path (reconcile frame, node update, replaced widget storage, changed-widget fallback) through upsertNode: a live host gets setWidget by promoted name; anything else keeps addNode/reconcileNode. GraphMutationBatch gains hasNode so the adapter can tell a live host from a new one. Addresses review feedback: - #17202 (comment) - #17202 (comment) - #17202 (comment)
isLiveHost only checked that the live node existed, so a plain node replaced under the same id by a host-typed map was treated as an incumbent host and merely field-resynced, leaving a non-SubgraphNode with no promoted widgets. Require the live node's registered type to equal the payload type via a new GraphMutationBatch.getNodeType, so a type change forces the add/reconcile rebuild path. Tests S1p (plain -> host) and S1q (host -> plain). Addresses #17202 (comment)
|
Conflicts resolved in 2d385be. Worker tests and normal hooks passed. Fresh hosted checks and human review remain pending; this is not product acceptance. Full context for agent readersMerged main at 83ae7db into the existing branch without rewriting history. The other parent is the prior published head. The difference from main remains only The integration preserves main's Verification on the controller-approved isolated worker, with at most two test workers and no desktop checks or services:
Fresh hosted checks are still running and the PR retains Glossary: CRDT means conflict-free replicated data type, the shared document representation. A digest is an internal definition fingerprint, not exported workflow content. |
christian-byrne
left a comment
There was a problem hiding this comment.
Current-head disposition: no blocking source finding. The prior mandatory-lookup objection is addressed: storedDefinition() asserts Y.Map before every relevant mutation; recursive and snapshot cases inject private fields unconditionally, assert sanitized root/nested output, preserve nested order, and prove source-state fidelity. The named-widget mutation probes remain separate sanitizer discrimination evidence, not evidence for the lookup itself.
This is a substantive agent re-review at c962fcd735793adc70d046cf1f829639168bee2d, posted as COMMENT because the authenticated principal authored the PR. It does not self-approve, dismiss the original reviewer’s state, or waive pending hosted checks. The original reviewer retains thread-resolution authority.
|
@christian-byrne Successfully backported to #18407 |
|
@christian-byrne Successfully backported to #18408 |
define_subgraphdefinitions without cmp-private bookkeeping.Justification: Christian's full integration/admin-merge grant, explicitly confirmed by the release coordinator, authorizes only c962fcd after successful hosted checks. The current-head substantive review finds the mandatory-lookup objection addressed; it is an author-identity COMMENT, not non-author approval. The newer main delta contains only browser documentation/spec changes. This exact-merge compatibility decision supersedes the older program guard's current-main-ancestry and separate-human-approval prerequisites; that guard is not recorded as passing. All 102 checks were terminal before this update: 86 successful and 16 skipped. No reviewer state or thread is dismissed or resolved, and no runtime or release acceptance is claimed. Fresh readback remains required immediately before merge.
Full context for agent readers
What changed
The cmp
define_subgraphapplier writes the normal Yjs definition shape plus__definition_digest, a private replay/conflict key.agentSubgraphDefinitions.tsnow removes that key recursively from root and nestedExportedSubgraphprojections; its regression tests prove the private field is absent from the projectedExportedSubgraphbefore LiteGraph consumes it.The lifecycle probe found that the stacked follower change already supplies the required frontend lifecycle. Before reconciling root nodes,
reconcileAgentAdaptersregisters each missing definition withrootGraph.createSubgraph.LGraph.createSubgraphnormalizes definitions, registers theSubgraph, dispatchessubgraph-created, and configures nested definitions in dependency order. The app event handler then callsregisterNewSubgraph, which registers the definition id with theLiteGraph.createNodefactory. Host nodes are subsequently created through that factory and registered by the normal ECS adapter path.Existing integration tests cover:
subgraph-createdevent per newly observed definition;SubgraphNodehost created through the registered factory;rootGraph.subgraphsand leaves its host unmaterialized when configuration fails.This PR therefore makes the minimum compatibility change for the
define_subgraphapplier rather than duplicating lifecycle code already owned by the stacked follower branch.Design reference: agent-added subgraph lifecycle technical design.
RED to GREEN evidence
RED commit
d3057115eb:GREEN commit
94bce71459:Follow-up commit
3853b94e20adds a two-level nested regression test. Before the fix,drops define_subgraph bookkeeping from nested definitions recursivelyfailed because both nested digests survived; after the fix, all 15 reader tests pass.Gates
pnpm typecheck: passed.Vetoable decisions
__definition_digestcmp-private and exclude it from the liveExportedSubgraphprojection.rootGraph.subgraphs, later definition payloads cannot reconfigure the live subgraph.LGraph, lifecycle event, factory registration, andSubgraphNodematerialization without browser-only behavior.