Repository navigation
fix: keep promoted subgraph widgets present across a rewire - #18074
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2182 passed, 0 failed📊 Browser Reports
📦 Bundle: 10.1 MB gzip 🔴 +38 BDetailsSummary
Category Glance App Entry Points — 3.84 kB (baseline 3.84 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 133 kB (baseline 133 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 643 kB (baseline 643 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 49.9 kB (baseline 49.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 7 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 150 kB (baseline 150 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 9 unchanged Data & Services — 4.11 MB (baseline 4.11 MB) • 🔴 +182 BStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 584 kB (baseline 584 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 20 added / 20 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BBundles that do not match a named category
Status: 76 added / 76 removed / 229 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T01:46:35.289Z",
"gitSha": "2c273afdf9d532bc86918db4cbb20eba988fdfc3",
"branch": "test/pm-1328-subgraph-widget-duplication",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.650999999977,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.2440000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.6449999999999,
"heapDeltaBytes": 297256,
"heapUsedBytes": 67061004,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.313000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2020.2039999999215,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.1519999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.38700000000006,
"heapDeltaBytes": -4279176,
"heapUsedBytes": 54793336,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.050000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1852.0429999999806,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.055999999999997,
"layouts": 12,
"layoutDurationMs": 5.031,
"taskDurationMs": 823.7429999999999,
"heapDeltaBytes": -3065028,
"heapUsedBytes": 63717536,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 174.611,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1781.3160000000607,
"styleRecalcs": 52,
"styleRecalcDurationMs": 15.088000000000001,
"layouts": 12,
"layoutDurationMs": 4.127000000000001,
"taskDurationMs": 758.235,
"heapDeltaBytes": 18867972,
"heapUsedBytes": 72592444,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 154.893,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018691,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.613000000043,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.268999999999998,
"layouts": 6,
"layoutDurationMs": 1.278,
"taskDurationMs": 339.01899999999995,
"heapDeltaBytes": -411688,
"heapUsedBytes": 60234548,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.722,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.2940000000099,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.707000000000003,
"layouts": 6,
"layoutDurationMs": 1.139,
"taskDurationMs": 332.257,
"heapDeltaBytes": 3473028,
"heapUsedBytes": 69949104,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.790999999999995,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 684.8370000000159,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.863,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.08400000000006,
"heapDeltaBytes": -7662004,
"heapUsedBytes": 59750148,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 163.439,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926843,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 688.4110000000874,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.6050000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.051,
"heapDeltaBytes": -34733452,
"heapUsedBytes": 67879560,
"domNodes": -252,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 164.70800000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926822,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1157.4039999999854,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 805.589,
"heapDeltaBytes": 15432380,
"heapUsedBytes": 84085768,
"domNodes": 0,
"jsHeapTotalBytes": 7241728,
"scriptDurationMs": 65.103,
"eventListeners": 0,
"totalBlockingTimeMs": 521,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1152.8780000001007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 807.957,
"heapDeltaBytes": 41341692,
"heapUsedBytes": 109634788,
"domNodes": 0,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 70.21,
"eventListeners": 0,
"totalBlockingTimeMs": 528,
"frameDurationMs": 34.84848484848485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.6180000000113,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.803,
"heapDeltaBytes": -15179608,
"heapUsedBytes": 82509044,
"domNodes": 0,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 169.25599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 863.9160000000174,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.9739999999999,
"heapDeltaBytes": -15098092,
"heapUsedBytes": 82850956,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 165.265,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9690.502999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8953.905999999999,
"heapDeltaBytes": 3658568,
"heapUsedBytes": 72028108,
"domNodes": -142,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 7558.395999999999,
"eventListeners": -70,
"totalBlockingTimeMs": 1323,
"frameDurationMs": 35.33905109489051,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10349.505000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9407.927000000001,
"heapDeltaBytes": 7425468,
"heapUsedBytes": 83987768,
"domNodes": -142,
"jsHeapTotalBytes": -6688768,
"scriptDurationMs": 7688.773999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 997,
"frameDurationMs": 32.18971962616822,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9659.064999999999,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5229999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8828.634000000002,
"heapDeltaBytes": 16083208,
"heapUsedBytes": 84286236,
"domNodes": -142,
"jsHeapTotalBytes": -6950912,
"scriptDurationMs": 7213.923000000001,
"eventListeners": -70,
"totalBlockingTimeMs": 852,
"frameDurationMs": 32.165333333333336,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10189.759999999978,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05099999999999896,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9279.207000000002,
"heapDeltaBytes": -2365276,
"heapUsedBytes": 74357580,
"domNodes": -142,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 7612.756,
"eventListeners": -78,
"totalBlockingTimeMs": 940,
"frameDurationMs": 31.722429906542054,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2010.7360000000085,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.105999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.2520000000001,
"heapDeltaBytes": -2666948,
"heapUsedBytes": 70455636,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.961000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2043.423999999959,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.313,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.3960000000001,
"heapDeltaBytes": -40331252,
"heapUsedBytes": 82437996,
"domNodes": -328,
"jsHeapTotalBytes": -3506176,
"scriptDurationMs": 34.289,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2575.6169999999656,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.408000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1681.256,
"heapDeltaBytes": -37631872,
"heapUsedBytes": 86287672,
"domNodes": -328,
"jsHeapTotalBytes": -2756608,
"scriptDurationMs": 850.796,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.774509803921568,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2477.5810000001,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.663000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1640.7700000000002,
"heapDeltaBytes": -8709732,
"heapUsedBytes": 78017884,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 855.121,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.779591836734696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3674.893000000054,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.406999999999998,
"layouts": 60,
"layoutDurationMs": 14.154,
"taskDurationMs": 1746.8040000000003,
"heapDeltaBytes": -11960808,
"heapUsedBytes": 76970968,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 798.962,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66651583710407,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3685.86700000003,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.152999999999999,
"layouts": 60,
"layoutDurationMs": 14.237,
"taskDurationMs": 1721.6410000000003,
"heapDeltaBytes": -11031604,
"heapUsedBytes": 76606848,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 793.0120000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66561085972851,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3071.3119999999776,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.718000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1727.3759999999997,
"heapDeltaBytes": 19176836,
"heapUsedBytes": 84054520,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 951.169,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757692307692306,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3135.116000000039,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.169999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1910.4789999999998,
"heapDeltaBytes": 1783048,
"heapUsedBytes": 88907512,
"domNodes": 0,
"jsHeapTotalBytes": 978944,
"scriptDurationMs": 962.2080000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755913978494625,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2008.6740000000418,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.000999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.885,
"heapDeltaBytes": -508708,
"heapUsedBytes": 87080648,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 32.057,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.7119999999459,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.8440000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.566,
"heapDeltaBytes": -458112,
"heapUsedBytes": 87213456,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 31.37799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 619.1000000000031,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.034000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.39099999999996,
"heapDeltaBytes": 9739424,
"heapUsedBytes": 63693736,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 144.861,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.8890000000374,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.151000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.39300000000003,
"heapDeltaBytes": 9734848,
"heapUsedBytes": 63712808,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 140.44,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.9519999999798,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.435999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.234,
"heapDeltaBytes": 22270136,
"heapUsedBytes": 76524520,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.973000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.9790000000012,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.116,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.52500000000003,
"heapDeltaBytes": 837724,
"heapUsedBytes": 70134716,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.04599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.7749999999837,
"styleRecalcs": 78,
"styleRecalcDurationMs": 17.351,
"layouts": 16,
"layoutDurationMs": 5.238,
"taskDurationMs": 745.3219999999999,
"heapDeltaBytes": -6817816,
"heapUsedBytes": 61899092,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 112.94099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.1299999999746,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.706000000000003,
"layouts": 16,
"layoutDurationMs": 5.853,
"taskDurationMs": 752.6659999999999,
"heapDeltaBytes": 16128308,
"heapUsedBytes": 77444068,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.96800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.6070000000127,
"styleRecalcs": 15,
"styleRecalcDurationMs": 29.202999999999992,
"layouts": 5,
"layoutDurationMs": 12.777999999999997,
"taskDurationMs": 898.7980000000002,
"heapDeltaBytes": 23951688,
"heapUsedBytes": 109290392,
"domNodes": 13747,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 29.41699999999999,
"eventListeners": 2383,
"totalBlockingTimeMs": 127,
"frameDurationMs": 19.675000000000004,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8554.648999999983,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.765,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5833.267,
"heapDeltaBytes": -46847684,
"heapUsedBytes": 75577540,
"domNodes": -328,
"jsHeapTotalBytes": -2527232,
"scriptDurationMs": 2747.637,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698828125,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8619.756999999936,
"styleRecalcs": 249,
"styleRecalcDurationMs": 32.404,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5704.172,
"heapDeltaBytes": -39355072,
"heapUsedBytes": 83308264,
"domNodes": -328,
"jsHeapTotalBytes": -1740800,
"scriptDurationMs": 2662.6749999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69845261121857,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16797.090000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16173.331,
"heapDeltaBytes": -36550972,
"heapUsedBytes": 188386636,
"domNodes": -3045,
"jsHeapTotalBytes": 4071424,
"scriptDurationMs": 297.891,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.47338983050848,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 17325.984000000062,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16653.317000000003,
"heapDeltaBytes": -40376900,
"heapUsedBytes": 169746680,
"domNodes": -3045,
"jsHeapTotalBytes": 7163904,
"scriptDurationMs": 292.157,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.34915254237288,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 20453.079,
"styleRecalcs": 171,
"styleRecalcDurationMs": 17.917000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19960.385,
"heapDeltaBytes": -6953968,
"heapUsedBytes": 192191528,
"domNodes": -3045,
"jsHeapTotalBytes": 8658944,
"scriptDurationMs": 932.673,
"eventListeners": -14915,
"totalBlockingTimeMs": 11,
"frameDurationMs": 36.48092691622103,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 21036.17200000008,
"styleRecalcs": 165,
"styleRecalcDurationMs": 19.282999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20667.885000000002,
"heapDeltaBytes": -18824072,
"heapUsedBytes": 180614984,
"domNodes": -3045,
"jsHeapTotalBytes": 7872512,
"scriptDurationMs": 882.6080000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 31,
"frameDurationMs": 38.6625,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6286.727000000042,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.58700000000002,
"layouts": 20,
"layoutDurationMs": 25.619000000000003,
"taskDurationMs": 6077.199,
"heapDeltaBytes": -6117824,
"heapUsedBytes": 202457808,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 107.52799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.49774011299435,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6369.321000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.83099999999999,
"layouts": 20,
"layoutDurationMs": 27.536999999999992,
"taskDurationMs": 6278.089999999999,
"heapDeltaBytes": 1344280,
"heapUsedBytes": 207923428,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 119.29599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.68545454545453,
"p95FrameDurationMs": 83.20000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8623.565999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8331.276000000002,
"heapDeltaBytes": -28379808,
"heapUsedBytes": 189645040,
"domNodes": -3045,
"jsHeapTotalBytes": 7520256,
"scriptDurationMs": 130.75699999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.81739130434782,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8920.10199999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8632.618,
"heapDeltaBytes": -42021808,
"heapUsedBytes": 190017204,
"domNodes": -3045,
"jsHeapTotalBytes": 6430720,
"scriptDurationMs": 142.75700000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.06724738675958,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 480.70400000005975,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.557000000000002,
"layouts": 3,
"layoutDurationMs": 1.177,
"taskDurationMs": 146.85199999999998,
"heapDeltaBytes": -41396812,
"heapUsedBytes": 57819872,
"domNodes": -131,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 10.054,
"eventListeners": -90,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24137931034483,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 132.63400000005277,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.495000000000001,
"layouts": 4,
"layoutDurationMs": 2.0010000000000003,
"taskDurationMs": 95.64100000000003,
"heapDeltaBytes": 3826068,
"heapUsedBytes": 57247572,
"domNodes": -138,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.021,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 827.5039999999763,
"styleRecalcs": 78,
"styleRecalcDurationMs": 101.086,
"layouts": 76,
"layoutDurationMs": 24.91,
"taskDurationMs": 799.8080000000001,
"heapDeltaBytes": 17105508,
"heapUsedBytes": 87509632,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 323.945,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667999999999992,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 899.9000000000024,
"styleRecalcs": 78,
"styleRecalcDurationMs": 106.13799999999999,
"layouts": 76,
"layoutDurationMs": 26.451999999999998,
"taskDurationMs": 868.089,
"heapDeltaBytes": 17744972,
"heapUsedBytes": 88469720,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 353.174,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664814814814807,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1413.2230000000163,
"styleRecalcs": 78,
"styleRecalcDurationMs": 261.115,
"layouts": 76,
"layoutDurationMs": 29.610999999999997,
"taskDurationMs": 1395.629,
"heapDeltaBytes": -19243056,
"heapUsedBytes": 107660416,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 464.5570000000001,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.931645569620258,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1394.1330000000107,
"styleRecalcs": 78,
"styleRecalcDurationMs": 283.286,
"layouts": 76,
"layoutDurationMs": 29.25,
"taskDurationMs": 1362.7680000000003,
"heapDeltaBytes": 7571928,
"heapUsedBytes": 112937136,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 444.435,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.181818181818183,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 87bc8b4266c7f0254deb316c8aa1ba5e1d37fc31
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
CI investigation:
|
|
A second check also failed: 🤖 Generated with Claude Code |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18074 +/- ##
==========================================
+ Coverage 84.51% 85.24% +0.73%
==========================================
Files 3365 2366 -999
Lines 162262 136031 -26231
Branches 42278 36692 -5586
==========================================
- Hits 137134 115959 -21175
+ Misses 23208 19708 -3500
+ Partials 1920 364 -1556
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1005 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Fix plan (not implemented — needs a decision, see below)Christian asked whether the real fix (not just these repro tests) is trivial. Short answer: no, for reasons worth spelling out precisely rather than guessing at a patch. What's confirmed now, more precisely than the RCA summary above: the promoted widget's id is deterministic ( I also checked Symptom splitThe confirmed mechanism above only explains the disappearing widget (PM-1253/1254 — the rewired widget itself). It does not explain duplication (PM-1328's literal complaint — sibling, untouched widgets rendering twice). Recommend treating these as two workstreams rather than one fix. Disappear-fix option (contained, but not risk-free)In Risk: this changes the synchronous timing of Duplication mechanism — still openNot yet found. Needs tracing exactly which reactive dependency actually drives Status: no code change pushed. 🤖 Generated with Claude Code |
|
Note on the red "Check for AI agent co-author trailers" check: it scans the whole PR, and the first commit ( 🤖 Generated with Claude Code |
6a2728c to
c62274a
Compare
Adds failing repro tests (test.fail/it.fails) documenting the confirmed root cause of a reported bug: rewiring the link behind a promoted subgraph widget desyncs SubgraphNode.widgets from the widget-value store for one tick (SubgraphNode.ts ensureWidgetRemoved defers store cleanup via queueMicrotask), which the Vue widget grid reads from both sources and can render inconsistently. - src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts: real-class Vitest repro (it.fails) proving hostNode.widgets.length drops for one tick immediately after the interior rewire, independent of any rendering layer. - browser_tests/tests/subgraph/subgraphPromotedWidgetRewireDuplication.spec.ts: e2e repro (test.fail) covering two distinct trigger paths as separate cases - interior rewire (confirmed mechanism) and external boundary wire (dragging a new node directly onto the host's promoted widget socket, a different code path) - plus undo checks and screenshot evidence. Not yet run end-to-end in this environment: the CI container image pull (ghcr.io) is blocked by this sandbox's network policy, so the spec is verified via typecheck, lint, and `playwright test --list` only. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01U6aDANuoAYDtxd9WiCk44Q
Rewiring the interior link behind a promoted subgraph widget (e.g. a new node wired into a subgraph's promoted text widget) used to demote the widget synchronously in SubgraphNode's 'input-disconnected' handler while deferring the matching widget-value-store cleanup to a queueMicrotask, leaving hostNode.widgets and the store's tracked id count disagreeing for one tick. The Vue widget grid reads its render order from the store and its liveness check from hostNode.widgets, so it could observe that disagreement during an ordinary rewire. Defer the demotion itself by a microtask instead, cancelled by a same-tick reconnect (the 'input-connected' listener clears the pending token), so a rewire never drops the widget at all. A genuine disconnect with no reconnect still fully demotes once the microtask runs. This changes the synchronous timing of `node.widgets` immediately after a disconnect: two existing tests asserted synchronously and now await one microtask tick, matching the new deferred-demotion behavior. Also adds coverage for a hypothesized second mechanism (a promoted DOM-hosted widget and a store-projected row co-existing for the same input): checked and refuted against the real rebuild/rewire/configure sequence, kept as regression coverage.
The deferred-demotion fix changed when a genuine disconnect becomes observable on hostNode.widgets (one microtask later). Three tests outside the previously updated file asserted the old synchronous timing: promotionUtils' explicit demoteWidget retraction and two useErrorClearingHooks promoted-media cases. Each now awaits one microtask after the demote-triggering action, mirroring the updates already made in SubgraphWidgetPromotion.test.ts. Also documents a change-tracker caveat on the e2e spec's undo tests: a Vue slot drag-connect is not captured as its own undo snapshot, so undo may target an earlier snapshot than the wire action.
…undo target CI confirmed the same-tick demotion fix resolves both duplication repro scenarios (reported as 'expected to fail, but passed'), so the test.fail markers are removed, including the pre-existing one in subgraphPromotion.spec.ts (#14495). The external-boundary undo test now captures the post-connect state before undoing, since the drag-connect suppresses the change tracker's mouseup capture and undo otherwise targets a pre-promotion snapshot.
The external-boundary undo test pinned the post-connect state with clickEmptySpace() because a Vue slot drag-connect used to leave no undo snapshot of its own. Since #18117 the drop records one directly, so the pin click is redundant, and it had also become unclickable in CI (the workflow tab bar overlays the default empty-space position and intercepts the click, timing the test out). Remove the pin click and update the spec header's stale caveat about the missing snapshot.
…uite The rewire-desync suite was written against the abstract BaseWidget constructor, which main replaced with LegacyWidget across this file when it removed the @ts-expect-error suppressions. Bring the suite's own helper in line with that refactor.
c62274a to
bcc85a9
Compare
…dget CI showed undo in the external-boundary test restoring a state captured between the two explicit promotions: the change tracker snapshots on window mouseup, which fires before the click handlers that apply promotions, so its activeState lagged the built baseline by one action and the slot drop (#18117) pushed that stale state as the undo target. Click empty canvas once the baseline is fully built so the drop pushes the settled state, and a single undo restores all four promoted widgets.
This comment has been minimized.
This comment has been minimized.
The external-boundary undo test assumed a specific undo snapshot, but which snapshot undo targets depends on change-tracker capture timing the test does not control: captures fire on window mouseup, before the click handlers that apply promotions, so the entry pushed by the slot drop can lag the built baseline by one action. The previous attempt to pin the snapshot with an extra canvas click made the run time out instead. Drop the extra interaction and restate the assertion as the invariant both reported symptoms violate: whatever state undo restores, the host's model holds no duplicate widgets and the grid renders exactly one row per model widget, none otherwise.
christian-byrne
left a comment
There was a problem hiding this comment.
Verified the exact head is green and review threads are resolved. This preserves promoted subgraph controls across rewires and closes the associated regression.
|
|
…copy for payment_failed renewals (#19677) (#19748) *PR Created by the Glary-Bot Agent* --- Manual backport of #19677 to `cloud/1.55`, from the v1.56.2 backport-status report. Companion to #19746 (`core/1.55`). Cherry-picked from upstream merge commit `13a9333e54`. Requested in [#frontend-releases](https://comfy-organization.slack.com/archives/C09K9TPU2G7/p1790847308032919) as a cherry-pick "carrier" backport, one per target branch. #19677 is the only PR the report flags for `cloud/1.55` that is actually backportable, so this carrier carries one commit — see "Why this carrier holds one commit" below. ## Why For a `payment_failed` renewal the run button is already locked, but the settings banner said "Update payment to avoid a pause" — copy describing a warning stage that does not exist, because the backend never sets `paused` on renewal failure (BE-6970). `payment_failed` now reads as paused, and the member paused banner gets the informational grey icon. ## Conflict resolution Identical to #19746: `BillingStatusBanner.vue` and `BillingStatusBanner.test.ts` are **byte-identical** between `core/1.55` and `cloud/1.55` at their bases (verified by blob hash), so this is the same resolution. `cloud/1.55` predates main's refactor of this banner into per-kind view factories, and has no renewal-invoice support: `BannerView` has no `payInvoiceUrl`, the template has no Pay invoice button, there is no `payInvoice` string, and `useBillingContext` does not expose `renewalInvoice`. The upstream diff was applied as behaviour, not as text. - **`BillingStatusBanner.vue`** — kept this branch's single `switch`-based `banner` computed rather than main's `pausedView()`/`paymentFailedView()` factories. Accept-theirs would have produced a broken hybrid and dragged in an unrelated `isEnterprisePlan` ending-copy change not on this branch. `paymentFailed` now shares the `paused` case, and `paused` is muted for members. The Pay invoice branch is omitted — that feature does not exist here. - **`BillingStatusBanner.test.ts`** — dropped upstream's edits to the `renewal invoice` describe block; that block does not exist on this branch. Kept the renamed payment_failed test and its updated paused-copy assertions. - **`src/locales/en/main.json`** — removed the now-unused `billingStatus.warning` strings. This file is *not* identical between the 1.55 branches, so the conflict was resolved in place rather than by reusing the `core/1.55` blob; the `billingStatus` sub-tree is identical (verified by hash) and the banner was the strings' only consumer. Semantics preserved exactly: upstream's `pausedView()` is `{ muted: !canManage, title: paused.title, body: canManage ? paused.body : paused.memberBody, action: canManage ? 'updatePayment' : null, dismissible: false }`, and the merged `case 'paused'/'paymentFailed'` arm reproduces that. `useBillingBanner` gates `paymentFailed` on `canManage`, so the newly-gated `action` and `muted` resolve to the same values upstream produces. No backport-only compatibility shim was needed; no public API shape or callback signature changed. The resulting net diff is identical to #19746 (3 files, +7/−24). ## Validation - `pnpm test:unit BillingStatusBanner.test.ts` — 20/20 passing - `pnpm typecheck` — exit 0 - `pnpm exec oxfmt --check` on changed files — clean - Rendered verification was done on the identical `core/1.55` component tree (see #19746 for screenshots and the live-DOM icon-class/colour table): `payment_failed` owner flips from "Payment failed / …avoid a pause" to "Subscription paused / …Update payment to resume", and the paused **member** icon flips from amber `icon-[lucide--triangle-alert]` `rgb(252,191,100)` to grey `icon-[lucide--circle-alert]` `rgb(73,74,80)`, with the paused owner unchanged. No E2E added — matching upstream, which notes Playwright cannot put a real workspace into these billing states. ## Why this carrier holds one commit The report flagged four PRs as "❗ Need backport". Two cannot be carried: - **#19053** ("restore live turn after panel remount", PM-1776) — **not merged.** Only `refs/pull/19053/head` exists; it is 69 commits ahead of `main` with no squash commit, which is why the report listed it without a `(#NNNNN)` suffix. There is nothing to cherry-pick. - **#19240** ("say when the open workflow is deleted") — flagged for `cloud/1.55`, but its **prerequisite is missing on every target branch.** Its mechanism marks the target unavailable so the in-chat notice from #18866 renders. Neither `markWorkflowTargetUnavailable`/`targetUnavailable` nor the `targetWorkflowUnavailable` string exists on `core/1.54`, `cloud/1.54`, `core/1.55` or `cloud/1.55`, and the 1.55 branches still use the older `WorkflowTargetSelection` model instead of `TargetTracking` — so the cherry-pick does not even apply here. Carrying it would set a state nothing renders, a silent no-op defeating the fix. It needs #18866 backported first. #18074 is labelled `core/1.54` + `cloud/1.54` only, so it is not in this branch's scope. Original PR: #19677 / Original commit: `13a9333e5426d6e2e2f5f61d3da72a8184176a75` Justification: Standing Agent release-backport grant; independent exact-head audit found faithful cloud/1.55 adaptation, all hosted checks are terminal green at aed7958, and the live target advanced by three commits with zero changed-file overlap. REVIEW_REQUIRED alone is not an added approval requirement for this grant. Co-authored-by: Dante <bunggl@naver.com>
<!-- ccr-slack-attribution --> _Requested by **Jo Zhang, Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789707519592879?thread_ts=1789707519.592879&cid=C0BGH348Z0C)_ A subgraph node shows several "promoted" widgets from the nodes hidden inside it (like width, height, seed). When you rewire the connection behind just one of those widgets, the others could flicker, duplicate, or vanish for a moment, and the wired-in widget itself could disappear. This PR fixes that and adds tests at both levels: unit tests prove the mechanism, and the browser-level repro tests — which this PR's own CI confirmed now pass with the fix — are kept as plain regression tests. - Fixes #14495 This started as a REPRO-ONLY PR for a reported bug: wiring a new node into a subgraph's promoted "prompt" widget makes the subgraph's *other* promoted widgets render duplicated, and a closely related report has the rewired widget itself disappear with redo misplacing the wire. Investigation traced a confirmed mechanism for the disappearing half at the data-model layer (see Summary). Once that mechanism was nailed down precisely enough to fix without guessing, and a second, more contained duplication theory was checked and refuted, it became worth landing the fix and the validating tests in the same PR rather than leaving a fully-diagnosed, small, well-scoped bug unfixed. - **Authored by:** interactive session, Claude Code - **Verified:** `pnpm exec vitest run src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts` — 51 passed, 0 failed (was 50 passed / 1 expected fail before the fix; that case now passes for real and was flipped from `it.fails` to `it`). `pnpm exec vitest run src/lib/litegraph/src/subgraph/ src/renderer/extensions/vueNodes/widgets/utils/multilineTextarea.promoted.test.ts src/stores/widgetValueStore.test.ts src/stores/domWidgetStore.test.ts` — 413 passed, 0 failed. `pnpm typecheck`, `pnpm lint`, `pnpm knip` — clean. E2E confirmation came from this PR's own CI (see Summary). Re-verified after the 2026-10-01 rebase onto main: same scoped suites green, typecheck/lint/knip clean. - **Deviations:** none remaining. The previous push deliberately left the e2e `test.fail()` cases unflipped pending CI evidence; that evidence has now arrived (see "E2E confirmation" below) and they are flipped to plain `test()` in this push, exactly per the plan recorded in the earlier Test plan. - **Type:** fix + test — a small, contained timing fix plus the tests that prove it, validate/refute an alternate duplication theory, and lock in the browser-level symptom as regression coverage - **Slots into:** a subgraph promoted-widget-promotion bug investigation; no project or epic, ad-hoc follow-up to that investigation - **Not in scope:** `createPromotedMultilineWidget`'s visibility/suppression path — that's PR #18085's territory (a sibling investigation into the same widget family) Rewiring the interior link behind a promoted widget (e.g. dragging a new node onto an already-promoted widget's socket) removes the old link before the new one lands. `SubgraphInputNode`'s `'input-disconnected'` handler used to demote the widget **synchronously** — clearing `input.widgetId`/`.widget`/`._widget` immediately — while deferring the matching `widgetValueStore` cleanup to a `queueMicrotask`. For one tick, `hostNode.widgets.length` (synchronous) and the store's tracked id count for that node (deferred) disagreed. The Vue widget grid (`useProcessedWidgets`/`computeProcessedWidgets`) reads its render *order* from the store and its liveness *filter* from `hostNode.widgets` — i.e. from both sides of that exact disagreement. The fix defers the demotion itself by a microtask (mirroring the already-deferred store cleanup), tracked with a per-input cancellation token. The `'input-connected'` listener clears that token on a same-tick reconnect, so a rewire never drops the widget from `hostNode.widgets` at all. A genuine disconnect with no reconnect still fully demotes once the microtask runs — nothing about final-state behavior changes, only the timing of an in-between state that used to be observable. **Deliberate timing-change note** (per this repo's own ecosystem-impact rule for changes touching `node.widgets` access): this changes when a disconnect becomes observable on `hostNode.widgets` — previously synchronous, now one microtask tick later for a genuine disconnect. Two existing tests in `SubgraphWidgetPromotion.test.ts` asserted this synchronously with no `await`; both were updated to `await Promise.resolve()` after the disconnecting call, with a comment explaining why. No public API shape or callback signature changed — only internal timing. - `SubgraphWidgetPromotion.test.ts`, "keeps every promoted widget present while rewiring the interior link behind one of them" (previously `it.fails`, now a plain `it`): builds a host with 4 promoted widgets from 4 different interior nodes, rewires the link behind one of them onto a *new* interior node mid-test, and asserts `hostNode.widgets.length` stays at 4 throughout — including immediately after the disconnect step, before the reconnect lands. - `SubgraphWidgetPromotion.test.ts`, "Promoted textarea dual-registration (PM-1328 duplication lead)": tests a second, independently-raised theory for the duplication symptom — that a promoted textarea's DOM-hosted widget (a `DOMWidgetImpl` living in `useDomWidgetStore`, materialized by `createPromotedHostWidget`) and a store-projected row could both end up registered for the same input, which would duplicate a row in the widget grid. Built a minimal `SubgraphNode` subclass wired the same way the app's real subclass is, exercised it across a rewire and a `configure()` reconfigure. **Both pass as-is — the theory is refuted.** `_projectPromotedWidget`'s `if (input._widget) return input._widget` guard is unconditional across every call site and there's no observable window where `input.widgetId` is set while `input._widget` isn't. Kept as regression coverage. [35419314544](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35419314544)) CI on the previous head answered the open question the `test.fail()` repros were posted to ask — the fix **does** resolve the browser-level symptom end-to-end: - Both `subgraphPromotedWidgetRewireDuplication.spec.ts` repro scenarios (interior rewire and external boundary wire) were reported "Expected to fail, but passed" on every run and retry (video job + shard 12, 4/4 retries). Flipped to plain `test()` regression tests, and retitled to describe the behavior they now guarantee. - `subgraphPromotion.spec.ts` "Promoted STRING widget edit survives a rebind of the interior link" — a *pre-existing* `test.fail()` for #14495 — also passed on all 4 shard-12 attempts. Flipped to plain `test()`; hence "Fixes #14495" above. - The external-boundary undo test went through two CI-informed revisions after the rebase: which snapshot undo targets depends on change-tracker capture timing the test cannot control (captures fire on window mouseup, before the click handlers that apply promotions, so the entry pushed by the slot drop — #18117 — can lag the built baseline by one action), and an attempt to pin the snapshot with an extra canvas click timed out in CI. The test now asserts the invariant both reported symptoms violate instead of a fixed widget set: whatever state undo restores, the host's model holds no duplicate widgets and the grid renders exactly one row per model widget, none otherwise. - [x] Watch this PR's `playwright-video-new-tests` CI check: the `test.fail()` cases were reported as unexpectedly passed (run 35419314544) - [x] Flip those cases (and the pre-existing #14495 one) to plain `test()` - [x] Make the external-boundary undo test deterministic (it now asserts render/model consistency after undo instead of assuming which snapshot undo targets) - [ ] CI green on the rebased head (the "Check for AI agent co-author trailers" check was removed from main in #19393; the first commit still carries trailers, and rewording it remains a maintainer call since it rewrites shared history) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01U6aDANuoAYDtxd9WiCk44Q --------- (cherry picked from commit 9ee67cb) (The two conflicting test files are byte-identical between core/1.54 and cloud/1.54 at their merge base, so this is the same resolution as the core/1.54 carrier. `SubgraphNode.ts` differs slightly between the two branches but the fix applied cleanly to both.)
<!-- ccr-slack-attribution --> _Requested by **Jo Zhang, Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789707519592879?thread_ts=1789707519.592879&cid=C0BGH348Z0C)_ A subgraph node shows several "promoted" widgets from the nodes hidden inside it (like width, height, seed). When you rewire the connection behind just one of those widgets, the others could flicker, duplicate, or vanish for a moment, and the wired-in widget itself could disappear. This PR fixes that and adds tests at both levels: unit tests prove the mechanism, and the browser-level repro tests — which this PR's own CI confirmed now pass with the fix — are kept as plain regression tests. - Fixes #14495 This started as a REPRO-ONLY PR for a reported bug: wiring a new node into a subgraph's promoted "prompt" widget makes the subgraph's *other* promoted widgets render duplicated, and a closely related report has the rewired widget itself disappear with redo misplacing the wire. Investigation traced a confirmed mechanism for the disappearing half at the data-model layer (see Summary). Once that mechanism was nailed down precisely enough to fix without guessing, and a second, more contained duplication theory was checked and refuted, it became worth landing the fix and the validating tests in the same PR rather than leaving a fully-diagnosed, small, well-scoped bug unfixed. - **Authored by:** interactive session, Claude Code - **Verified:** `pnpm exec vitest run src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts` — 51 passed, 0 failed (was 50 passed / 1 expected fail before the fix; that case now passes for real and was flipped from `it.fails` to `it`). `pnpm exec vitest run src/lib/litegraph/src/subgraph/ src/renderer/extensions/vueNodes/widgets/utils/multilineTextarea.promoted.test.ts src/stores/widgetValueStore.test.ts src/stores/domWidgetStore.test.ts` — 413 passed, 0 failed. `pnpm typecheck`, `pnpm lint`, `pnpm knip` — clean. E2E confirmation came from this PR's own CI (see Summary). Re-verified after the 2026-10-01 rebase onto main: same scoped suites green, typecheck/lint/knip clean. - **Deviations:** none remaining. The previous push deliberately left the e2e `test.fail()` cases unflipped pending CI evidence; that evidence has now arrived (see "E2E confirmation" below) and they are flipped to plain `test()` in this push, exactly per the plan recorded in the earlier Test plan. - **Type:** fix + test — a small, contained timing fix plus the tests that prove it, validate/refute an alternate duplication theory, and lock in the browser-level symptom as regression coverage - **Slots into:** a subgraph promoted-widget-promotion bug investigation; no project or epic, ad-hoc follow-up to that investigation - **Not in scope:** `createPromotedMultilineWidget`'s visibility/suppression path — that's PR #18085's territory (a sibling investigation into the same widget family) Rewiring the interior link behind a promoted widget (e.g. dragging a new node onto an already-promoted widget's socket) removes the old link before the new one lands. `SubgraphInputNode`'s `'input-disconnected'` handler used to demote the widget **synchronously** — clearing `input.widgetId`/`.widget`/`._widget` immediately — while deferring the matching `widgetValueStore` cleanup to a `queueMicrotask`. For one tick, `hostNode.widgets.length` (synchronous) and the store's tracked id count for that node (deferred) disagreed. The Vue widget grid (`useProcessedWidgets`/`computeProcessedWidgets`) reads its render *order* from the store and its liveness *filter* from `hostNode.widgets` — i.e. from both sides of that exact disagreement. The fix defers the demotion itself by a microtask (mirroring the already-deferred store cleanup), tracked with a per-input cancellation token. The `'input-connected'` listener clears that token on a same-tick reconnect, so a rewire never drops the widget from `hostNode.widgets` at all. A genuine disconnect with no reconnect still fully demotes once the microtask runs — nothing about final-state behavior changes, only the timing of an in-between state that used to be observable. **Deliberate timing-change note** (per this repo's own ecosystem-impact rule for changes touching `node.widgets` access): this changes when a disconnect becomes observable on `hostNode.widgets` — previously synchronous, now one microtask tick later for a genuine disconnect. Two existing tests in `SubgraphWidgetPromotion.test.ts` asserted this synchronously with no `await`; both were updated to `await Promise.resolve()` after the disconnecting call, with a comment explaining why. No public API shape or callback signature changed — only internal timing. - `SubgraphWidgetPromotion.test.ts`, "keeps every promoted widget present while rewiring the interior link behind one of them" (previously `it.fails`, now a plain `it`): builds a host with 4 promoted widgets from 4 different interior nodes, rewires the link behind one of them onto a *new* interior node mid-test, and asserts `hostNode.widgets.length` stays at 4 throughout — including immediately after the disconnect step, before the reconnect lands. - `SubgraphWidgetPromotion.test.ts`, "Promoted textarea dual-registration (PM-1328 duplication lead)": tests a second, independently-raised theory for the duplication symptom — that a promoted textarea's DOM-hosted widget (a `DOMWidgetImpl` living in `useDomWidgetStore`, materialized by `createPromotedHostWidget`) and a store-projected row could both end up registered for the same input, which would duplicate a row in the widget grid. Built a minimal `SubgraphNode` subclass wired the same way the app's real subclass is, exercised it across a rewire and a `configure()` reconfigure. **Both pass as-is — the theory is refuted.** `_projectPromotedWidget`'s `if (input._widget) return input._widget` guard is unconditional across every call site and there's no observable window where `input.widgetId` is set while `input._widget` isn't. Kept as regression coverage. [35419314544](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35419314544)) CI on the previous head answered the open question the `test.fail()` repros were posted to ask — the fix **does** resolve the browser-level symptom end-to-end: - Both `subgraphPromotedWidgetRewireDuplication.spec.ts` repro scenarios (interior rewire and external boundary wire) were reported "Expected to fail, but passed" on every run and retry (video job + shard 12, 4/4 retries). Flipped to plain `test()` regression tests, and retitled to describe the behavior they now guarantee. - `subgraphPromotion.spec.ts` "Promoted STRING widget edit survives a rebind of the interior link" — a *pre-existing* `test.fail()` for #14495 — also passed on all 4 shard-12 attempts. Flipped to plain `test()`; hence "Fixes #14495" above. - The external-boundary undo test went through two CI-informed revisions after the rebase: which snapshot undo targets depends on change-tracker capture timing the test cannot control (captures fire on window mouseup, before the click handlers that apply promotions, so the entry pushed by the slot drop — #18117 — can lag the built baseline by one action), and an attempt to pin the snapshot with an extra canvas click timed out in CI. The test now asserts the invariant both reported symptoms violate instead of a fixed widget set: whatever state undo restores, the host's model holds no duplicate widgets and the grid renders exactly one row per model widget, none otherwise. - [x] Watch this PR's `playwright-video-new-tests` CI check: the `test.fail()` cases were reported as unexpectedly passed (run 35419314544) - [x] Flip those cases (and the pre-existing #14495 one) to plain `test()` - [x] Make the external-boundary undo test deterministic (it now asserts render/model consistency after undo instead of assuming which snapshot undo targets) - [ ] CI green on the rebased head (the "Check for AI agent co-author trailers" check was removed from main in #19393; the first commit still carries trailers, and rewording it remains a maintainer call since it rewrites shared history) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01U6aDANuoAYDtxd9WiCk44Q --------- (cherry picked from commit 9ee67cb) ## Backport adaptation (core/1.54) The fix itself (`SubgraphNode.ts`, `interfaces.ts`) cherry-picked clean and is byte-identical to upstream. Only two test files conflicted, both because the cherry-pick's context included neighbouring code that is not on this branch: - `useErrorClearingHooks.test.ts` — the conflict hunk also carried an unrelated test, "retires an absorbed promoted media error when its host is deleted", which main gained from a different, unbackported PR. Dropped that test and applied only this PR's change to the test that does exist here: make "keeps promoted missing media until the last fanout consumer is deleted" async and await the deferred demotion. - `SubgraphWidgetPromotion.test.ts` — import-only conflict. Accepted the three new imports (`WidgetValue`, `createPromotedMultilineWidget`, `useDomWidgetStore`) required by the new PM-1328 describe block; verified all three modules and symbols exist on this branch. The new block also uses `LegacyWidget`, which main imports from the litegraph barrel in a neighbouring non-conflicting import hunk, so this branch's version of that hunk won and left it out; the test failed with `ReferenceError: LegacyWidget is not defined` until it was added to the barrel import. `LegacyWidget` already exists and is exported from the barrel on this branch. No backport-only compatibility shim was needed and no public API shape or callback signature changed. The deliberate timing change this PR documents (a genuine disconnect becomes observable on `hostNode.widgets` one microtask later) is carried as-is.
Review repairs for the six findings raised on the cloud/1.54 carrier #19750. All of them are properties of #18074's design, not of the backport: the carrier's hunks are byte-identical to upstream. Deferring the demotion by a microtask moved three things that used to run synchronously after the slot was cleared to running before it, or to running against a slot something else had already torn down. - The store-reclamation check ran before `input.widgetId` was cleared, so the `some()` predicate always matched the input being demoted and `deleteWidget(id)` was unreachable on a genuine disconnect. The entry and its node-widget-order entry leaked for the host, and a later re-promotion of the same slot name resurrected the stale value via registerWidget's same-type reuse. The check now runs after the clearing, and keys on `_widget` so a slot re-promoted to the same id still counts. - `input-connected` cleared the pending-demotion token before the `!e.detail.widget || !e.detail.node` guard. SubgraphInput.connect dispatches that event with no widget/node when the new interior target has no widget locator, so a same-tick rewire onto one cancelled the demotion and then returned without promoting a replacement, stranding widgetId/.widget/._widget on a widget whose interior source is gone. The token is now cleared only once a replacement is actually being promoted. - configure(), onRemoved() and the 'removing-input' handler tear the slot down without clearing the token, and an AbortSignal cannot cancel an already-queued microtask. The queued callback re-ran the teardown against stale state, dispatching a spurious 'widget-demoted' that makes createPromotionErrorReconciler.removeHostWidgetCandidate drop a live candidate, and breaking the invariant that onRemoved() dispatches no demotion events. The callback now detects that the slot changed. - demotePromotedInput deleted the store entry synchronously right after linkedInput.disconnect(), leaving one tick in which host.widgets held the projection while getWidget(id) was already undefined. The deferred teardown reclaims it on that path; the explicit delete stays on the removeInput branch, which queues no demotion. Two assertions could not fail on the symptom they cover: - `toBeLessThanOrEqual(1)` mid-rewire is satisfied by 0, which is exactly the "rewired widget disappears" symptom (PM-1254). Now `toBe(1)`. Verified: with the deferral removed, the old assertion passes and the new one fails. - the undo spec derived its expected render count from the live model, so a widget missing from both model and DOM passed. The three promoted widgets the wire action never touched are now asserted against the fixed PROMOTED_WIDGET_NAMES set; only the rewired one, whose promoted state legitimately varies with the restored snapshot, stays model-derived. Each production fix is proven by reverting it individually against the new tests: the store-reclaim ordering reds 3 tests, the token placement reds 1, the stale-slot guard reds 2, and the demotePromotedInput change reds 1.
Supersedes the approach in 5988061, which the e2e suite rejected. Two of its four production changes were wrong, and the unit tests I wrote for them were wrong in the same direction, so only the black-box harness caught it. What the harness showed, at 00b9c34: - subgraphPromotion.spec.ts "Promoted STRING widget edit survives a rebind of the interior link" went red. That is the test #18074 un-test.fail()-ed, and it depends on the widgetValueStore entry SURVIVING a demotion: a rebind disconnects and reconnects across two ticks, so the deferred teardown cannot tell it from a terminal disconnect, and the retained entry is what restores the user's edit when the slot is re-promoted under the same id. - subgraphPromotedWidgetRewireDuplication.spec.ts went red on the undo case. So the 🟠 High finding at SubgraphNode.ts:360 does not hold as stated. The `some()` predicate is not always-true: `removeInput` splices the input out of `this.inputs`, so what the predicate actually asks is "does this slot still exist", and deleteWidget is correctly unreachable while it does. Making it reachable reds #14495 — measured, both as a unit test and in the browser. The repair is therefore a clarity change with no behaviour change: the two conditions are now named (`slotStillExists`, `anotherSlotHoldsId`), evaluated after the clearing so the second one means what it says, and pinned from both sides — reclaiming on every disconnect reds the retention test and #14495, never reclaiming reds promotionAfterReplacement.test.ts. The stale-slot guard is also narrowed. `this.inputs.includes(input)` is the right question for store reclamation but the wrong one for skipping the teardown, so the guard is now identity on `input._widget`, which is what configure() and onRemoved() clear via _clearPromotedWidget. Unchanged from the superseded commit, both still proven red-on-revert: - 'input-connected' clears the pending-demotion token only after the `!e.detail.widget || !e.detail.node` guard. SubgraphInput.connect dispatches that event with no widget/node when the new interior target has no widget locator, so a same-tick rewire onto one cancelled the demotion and returned without promoting a replacement, stranding a phantom promoted widget. - demotePromotedInput no longer deletes the store entry synchronously on the disconnect branch; it queues behind the deferred teardown, closing the tick in which host.widgets held a projection whose entry was already gone. The removeInput branch keeps the synchronous delete, since nothing defers there. Test changes: - the mid-rewire assertions are `toBe(1)`, not `toBeLessThanOrEqual(1)`, which 0 satisfies — i.e. the PM-1254 disappearance symptom. Verified by removing the deferral: the old assertion passes on the defect, the new one fails. - four new unit tests: entry retained across a disconnect and value restored on re-promotion; demotion still happens when a same-tick rewire lands on a widgetless interior input; no demotion event when the node is removed or the host reconfigured in the same tick. - the undo spec's tautological assertion is NOT fixed. Replacing it with the fixed PROMOTED_WIDGET_NAMES set reds: 'height' is genuinely absent from the host model after one undo on the external-boundary path, reproduced in CI (first attempt and both retries) and locally, and forcing a change-tracker capture before the wire does not fix it. Either the newest snapshot predates the last promotion or configure() fails to restore it; separating those owns the fix. The assertion is left as-is with the measurement recorded on it, so it reads as a known gap instead of as coverage.
…oss a rewire (#18074) (#19750) *PR Created by the Glary-Bot Agent* --- Manual backport of #18074 to `cloud/1.54`, from the v1.56.2 backport-status report. Companion to #19749 (`core/1.54`). Cherry-picked from upstream merge commit `9ee67cb17b`. Requested in [#frontend-releases](https://comfy-organization.slack.com/archives/C09K9TPU2G7/p1790847308032919) as a cherry-pick "carrier" backport, one per target branch. #18074 is the only PR the report flags for `cloud/1.54` that is actually backportable, so this carrier carries one commit — see "Why this carrier holds one commit" below. ## Why Rewiring the interior link behind one promoted subgraph widget (e.g. dragging a new node onto an already-promoted widget's socket) could drop or visually duplicate the host node's *other* promoted widgets, and make the rewired widget itself disappear. `SubgraphInputNode`'s `'input-disconnected'` handler demoted the widget **synchronously** while deferring the matching `widgetValueStore` cleanup to a `queueMicrotask`. For one tick `hostNode.widgets.length` and the store's tracked id count disagreed — and the Vue widget grid reads its render *order* from the store and its liveness *filter* from `hostNode.widgets`, i.e. from both sides of that disagreement. The fix defers the demotion itself by a microtask with a per-input cancellation token, which `'input-connected'` clears on a same-tick reconnect, so a rewire never drops the widget at all. - Fixes #14495 ## Conflict resolution **The fix itself (`SubgraphNode.ts`, `interfaces.ts`) cherry-picked clean.** `SubgraphNode.ts` differs slightly between `core/1.54` and `cloud/1.54`, but the fix applied cleanly to both and the resulting hunks are identical. Only two test files conflicted — the same two as on #19749, and those two files are **byte-identical between `core/1.54` and `cloud/1.54` at their merge base** (verified by blob hash), so this is the same resolution, reusing the exact same resolved blobs: - **`useErrorClearingHooks.test.ts`** — the conflict hunk also carried an unrelated test, "retires an absorbed promoted media error when its host is deleted", which `main` gained from a different, unbackported PR. Dropped that test and applied only this PR's change to the test that does exist here: make "keeps promoted missing media until the last fanout consumer is deleted" `async` and `await` the now-deferred demotion. - **`SubgraphWidgetPromotion.test.ts`** — import-only conflict. Accepted the three new imports (`WidgetValue`, `createPromotedMultilineWidget`, `useDomWidgetStore`) required by the new PM-1328 describe block, after verifying all three modules and symbols exist on this branch. The new block also uses `LegacyWidget`, which `main` imports from the litegraph barrel in a *neighbouring non-conflicting* import hunk — so this branch's version won and left it out, failing with `ReferenceError: LegacyWidget is not defined` until it was added to the barrel import. `LegacyWidget` already exists and is exported from the barrel here, so this is an import fix, not new code. No backport-only compatibility shim was needed, and no public API shape or callback signature changed. The deliberate timing change this PR documents — a genuine disconnect becomes observable on `hostNode.widgets` one microtask later — is carried as-is rather than shimmed: the surrounding machinery (`SubgraphInputNode.ts`, `SubgraphInputEventMap.ts`) is byte-identical between this branch and `main`, so a literal cherry-pick cannot recreate the original bug for an old-contract consumer, and deviating would leave this branch running demotion logic `main`'s CI has never exercised. Changed-file set is **exactly** the same 7 files as upstream `9ee67cb17b` — no unrelated drift smuggled in. ## Validation - `pnpm test:unit` on the suites upstream used to validate the fix — **527/527 passing across 24 files** (`src/lib/litegraph/src/subgraph/`, `useErrorClearingHooks.test.ts`, `promotionUtils.test.ts`, `multilineTextarea.promoted.test.ts`, `widgetValueStore.test.ts`, `domWidgetStore.test.ts`). This includes the PR's own regression case, "keeps every promoted widget present while rewiring the interior link behind one of them", which asserts `hostNode.widgets.length` stays at 4 throughout a rewire — i.e. the exact mechanism, proven fixed on this branch. - `pnpm typecheck` — exit 0 - `pnpm exec eslint` on changed files — **0 errors**, 6 warnings, all pre-existing `import-x/no-restricted-paths` on `src/lib/` (upstream carries the same; `pnpm lint` sets no `--max-warnings`) - `pnpm exec oxfmt --check` on changed files — clean ###⚠️ Please let CI run the E2E before merging This PR lands `subgraphPromotedWidgetRewireDuplication.spec.ts` and flips `test.fail()` → `test()` in `subgraphPromotion.spec.ts`. Upstream justified those flips with CI evidence gathered on `main` ([run 35419314544](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35419314544)); **there is no equivalent evidence for `cloud/1.54` yet**, and the Playwright suite needs a live ComfyUI backend plus a built frontend, which I could not stand up in the sandbox. The unit-level regression above proves the mechanism on this branch, but per `SKILL.md` ("NEVER merge a backport PR without all CI checks passing") the flipped e2e should be confirmed green here before merge. Kept as a draft for that reason. ## Why this carrier holds one commit The report flagged four PRs as "❗ Need backport". Two cannot be carried: - **#19053** ("restore live turn after panel remount", PM-1776) — **not merged.** Only `refs/pull/19053/head` exists; it is 69 commits ahead of `main` with no squash commit, which is why the report listed it without a `(#NNNNN)` suffix. There is nothing to cherry-pick. - **#19240** ("say when the open workflow is deleted") — flagged for `cloud/1.54`, but its **prerequisite is missing.** Its mechanism marks the target unavailable so the in-chat notice from #18866 renders. This branch has the `TargetTracking` model but **no** `markWorkflowTargetUnavailable`/`targetUnavailable` and no `targetWorkflowUnavailable` string — the only "unavailable" path here is an unrelated *toast* fired on navigation failure (`agent.targetNavigationUnavailable`), a different mechanism for a different trigger. Carrying #19240 alone would set a state nothing renders — a silent no-op defeating the fix. It needs #18866 backported first. (Same gap on all four target branches.) #19677 is labelled `core/1.55` + `cloud/1.55` only, so it is not in this branch's scope. Original PR: #18074 / Original commit: `9ee67cb17b` --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
|
Backport disposition: no manual 1.54 port.
Full context for agent readersMerge commit |
Requested by Jo Zhang, Christian Byrne · Slack thread
ELI5
A subgraph node shows several "promoted" widgets from the nodes hidden inside it (like width, height, seed). When you rewire the connection behind just one of those widgets, the others could flicker, duplicate, or vanish for a moment, and the wired-in widget itself could disappear. This PR fixes that and adds tests at both levels: unit tests prove the mechanism, and the browser-level repro tests — which this PR's own CI confirmed now pass with the fix — are kept as plain regression tests.
Motivation
This started as a REPRO-ONLY PR for a reported bug: wiring a new node into a subgraph's promoted "prompt" widget makes the subgraph's other promoted widgets render duplicated, and a closely related report has the rewired widget itself disappear with redo misplacing the wire. Investigation traced a confirmed mechanism for the disappearing half at the data-model layer (see Summary). Once that mechanism was nailed down precisely enough to fix without guessing, and a second, more contained duplication theory was checked and refuted, it became worth landing the fix and the validating tests in the same PR rather than leaving a fully-diagnosed, small, well-scoped bug unfixed.
Provenance
pnpm exec vitest run src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts— 51 passed, 0 failed (was 50 passed / 1 expected fail before the fix; that case now passes for real and was flipped fromit.failstoit).pnpm exec vitest run src/lib/litegraph/src/subgraph/ src/renderer/extensions/vueNodes/widgets/utils/multilineTextarea.promoted.test.ts src/stores/widgetValueStore.test.ts src/stores/domWidgetStore.test.ts— 413 passed, 0 failed.pnpm typecheck,pnpm lint,pnpm knip— clean. E2E confirmation came from this PR's own CI (see Summary). Re-verified after the 2026-10-01 rebase onto main: same scoped suites green, typecheck/lint/knip clean.test.fail()cases unflipped pending CI evidence; that evidence has now arrived (see "E2E confirmation" below) and they are flipped to plaintest()in this push, exactly per the plan recorded in the earlier Test plan.Reviewer context
createPromotedMultilineWidget's visibility/suppression path — that's PR test: add failing repros for promoted widget external-link rendering #18085's territory (a sibling investigation into the same widget family)Summary
The fix (
src/lib/litegraph/src/subgraph/SubgraphNode.ts)Rewiring the interior link behind a promoted widget (e.g. dragging a new node onto an already-promoted widget's socket) removes the old link before the new one lands.
SubgraphInputNode's'input-disconnected'handler used to demote the widget synchronously — clearinginput.widgetId/.widget/._widgetimmediately — while deferring the matchingwidgetValueStorecleanup to aqueueMicrotask. For one tick,hostNode.widgets.length(synchronous) and the store's tracked id count for that node (deferred) disagreed. The Vue widget grid (useProcessedWidgets/computeProcessedWidgets) reads its render order from the store and its liveness filter fromhostNode.widgets— i.e. from both sides of that exact disagreement.The fix defers the demotion itself by a microtask (mirroring the already-deferred store cleanup), tracked with a per-input cancellation token. The
'input-connected'listener clears that token on a same-tick reconnect, so a rewire never drops the widget fromhostNode.widgetsat all. A genuine disconnect with no reconnect still fully demotes once the microtask runs — nothing about final-state behavior changes, only the timing of an in-between state that used to be observable.Deliberate timing-change note (per this repo's own ecosystem-impact rule for changes touching
node.widgetsaccess): this changes when a disconnect becomes observable onhostNode.widgets— previously synchronous, now one microtask tick later for a genuine disconnect. Two existing tests inSubgraphWidgetPromotion.test.tsasserted this synchronously with noawait; both were updated toawait Promise.resolve()after the disconnecting call, with a comment explaining why. No public API shape or callback signature changed — only internal timing.New tests
SubgraphWidgetPromotion.test.ts, "keeps every promoted widget present while rewiring the interior link behind one of them" (previouslyit.fails, now a plainit): builds a host with 4 promoted widgets from 4 different interior nodes, rewires the link behind one of them onto a new interior node mid-test, and assertshostNode.widgets.lengthstays at 4 throughout — including immediately after the disconnect step, before the reconnect lands.SubgraphWidgetPromotion.test.ts, "Promoted textarea dual-registration (PM-1328 duplication lead)": tests a second, independently-raised theory for the duplication symptom — that a promoted textarea's DOM-hosted widget (aDOMWidgetImplliving inuseDomWidgetStore, materialized bycreatePromotedHostWidget) and a store-projected row could both end up registered for the same input, which would duplicate a row in the widget grid. Built a minimalSubgraphNodesubclass wired the same way the app's real subclass is, exercised it across a rewire and aconfigure()reconfigure. Both pass as-is — the theory is refuted._projectPromotedWidget'sif (input._widget) return input._widgetguard is unconditional across every call site and there's no observable window whereinput.widgetIdis set whileinput._widgetisn't. Kept as regression coverage.E2E confirmation (CI run 35419314544)
CI on the previous head answered the open question the
test.fail()repros were posted to ask — the fix does resolve the browser-level symptom end-to-end:subgraphPromotedWidgetRewireDuplication.spec.tsrepro scenarios (interior rewire and external boundary wire) were reported "Expected to fail, but passed" on every run and retry (video job + shard 12, 4/4 retries). Flipped to plaintest()regression tests, and retitled to describe the behavior they now guarantee.subgraphPromotion.spec.ts"Promoted STRING widget edit survives a rebind of the interior link" — a pre-existingtest.fail()for Regression: edits to a promoted STRING widget on a subgraph host node are not written back into the subgraph; value reverts on disconnect/reconnect #14495 — also passed on all 4 shard-12 attempts. Flipped to plaintest(); hence "Fixes Regression: edits to a promoted STRING widget on a subgraph host node are not written back into the subgraph; value reverts on disconnect/reconnect #14495" above.Test plan
playwright-video-new-testsCI check: thetest.fail()cases were reported as unexpectedly passed (run 35419314544)test()🤖 Generated with Claude Code
https://claude.ai/code/session_01U6aDANuoAYDtxd9WiCk44Q