Repository navigation
test(subgraph): pin promoted-widget rewire regressions - #18086
claude[bot] wants to merge 5 commits into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ❌ 2040 passed, 1 failed · 1 flaky❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.92 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 565 kB (baseline 565 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category Status: 298 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T16:46:56.722Z",
"gitSha": "55dcde8144fa280a23581dbc2d6ecafca581fb1e",
"branch": "test/subgraph-promoted-widget-rewire-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.122999999961,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.599,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.93100000000004,
"heapDeltaBytes": 7593328,
"heapUsedBytes": 69335156,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.262,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2003.7070000000767,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.581,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.49999999999994,
"heapDeltaBytes": 3824364,
"heapUsedBytes": 66007720,
"domNodes": -263,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.218999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1873.0390000000057,
"styleRecalcs": 79,
"styleRecalcDurationMs": 29.101999999999997,
"layouts": 14,
"layoutDurationMs": 4.115,
"taskDurationMs": 834.4499999999999,
"heapDeltaBytes": 10481956,
"heapUsedBytes": 72595768,
"domNodes": -265,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 161.14600000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.2370000000374,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.856,
"layouts": 14,
"layoutDurationMs": 3.9779999999999998,
"taskDurationMs": 721.8500000000001,
"heapDeltaBytes": 11402928,
"heapUsedBytes": 73432632,
"domNodes": -265,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 160.21099999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.8860000000263,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.474000000000004,
"layouts": 6,
"layoutDurationMs": 1.154,
"taskDurationMs": 338.151,
"heapDeltaBytes": 2148048,
"heapUsedBytes": 64071304,
"domNodes": 74,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.726000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.7130000000225,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.838,
"layouts": 6,
"layoutDurationMs": 1.0700000000000003,
"taskDurationMs": 326.565,
"heapDeltaBytes": 2155768,
"heapUsedBytes": 64105948,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.727,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 614.5579999999882,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.701,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.093,
"heapDeltaBytes": 18331604,
"heapUsedBytes": 79690008,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 160.005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 606.2799999999697,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.792999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.05,
"heapDeltaBytes": 17894396,
"heapUsedBytes": 79928876,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 159.614,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.7759999999794,
"styleRecalcs": 5,
"styleRecalcDurationMs": 11.447999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.9309999999999,
"heapDeltaBytes": 3297688,
"heapUsedBytes": 82956680,
"domNodes": -248,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 31.216000000000008,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.3819999999841,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.504000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.32800000000003,
"heapDeltaBytes": 3479736,
"heapUsedBytes": 82615644,
"domNodes": -246,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 33.629000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2209.2610000000263,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.314999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1584.1789999999999,
"heapDeltaBytes": -1170496,
"heapUsedBytes": 79472492,
"domNodes": -252,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 821.9839999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2231.198999999947,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.715000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1621.295,
"heapDeltaBytes": -1354292,
"heapUsedBytes": 79100000,
"domNodes": -251,
"jsHeapTotalBytes": 741376,
"scriptDurationMs": 828.264,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3497.433000000001,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.115999999999998,
"layouts": 60,
"layoutDurationMs": 12.547,
"taskDurationMs": 1720.9090000000003,
"heapDeltaBytes": -8769580,
"heapUsedBytes": 73494172,
"domNodes": -261,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 786.912,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3436.786999999981,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.933999999999997,
"layouts": 60,
"layoutDurationMs": 12.617999999999997,
"taskDurationMs": 1625.0110000000002,
"heapDeltaBytes": 9663780,
"heapUsedBytes": 74644580,
"domNodes": 2,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 754.717,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2988.1219999999757,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.464,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1871.836,
"heapDeltaBytes": 19076824,
"heapUsedBytes": 85047740,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 958.3000000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3026.542999999947,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.3130000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1868.2879999999998,
"heapDeltaBytes": 17940008,
"heapUsedBytes": 83774168,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 955.961,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2007.4260000000095,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.302000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.4870000000001,
"heapDeltaBytes": 20111092,
"heapUsedBytes": 84000124,
"domNodes": -256,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.275,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2010.4840000000195,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.817000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.6489999999999,
"heapDeltaBytes": 20169768,
"heapUsedBytes": 84323796,
"domNodes": -252,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.68199999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.5480000000025,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.337,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.355,
"heapDeltaBytes": 13391368,
"heapUsedBytes": 76776480,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 139.173,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.9629999999252,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.089,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.254,
"heapDeltaBytes": 13399760,
"heapUsedBytes": 76700152,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 139.75500000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1991.1800000000426,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.3499999999999,
"heapDeltaBytes": 972636,
"heapUsedBytes": 63869028,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.280000000000003,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.2710000000461,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.709999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.811,
"heapDeltaBytes": 6216436,
"heapUsedBytes": 69514792,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.549,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.06499999999,
"styleRecalcs": 76,
"styleRecalcDurationMs": 26.639000000000003,
"layouts": 18,
"layoutDurationMs": 5.038,
"taskDurationMs": 668.6569999999999,
"heapDeltaBytes": 16876116,
"heapUsedBytes": 79803424,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 107.19400000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.7760000000335,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.371,
"layouts": 18,
"layoutDurationMs": 5.153,
"taskDurationMs": 799.601,
"heapDeltaBytes": 15018712,
"heapUsedBytes": 78262436,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 109.23599999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.4859999999617,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.87,
"layouts": 5,
"layoutDurationMs": 12.732999999999997,
"taskDurationMs": 878.8120000000001,
"heapDeltaBytes": -8356028,
"heapUsedBytes": 84078020,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.111000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8477.112000000034,
"styleRecalcs": 246,
"styleRecalcDurationMs": 32.966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5730.193,
"heapDeltaBytes": -12597836,
"heapUsedBytes": 66550800,
"domNodes": -250,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 2773.0679999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8364.70200000008,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.03,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5583.821999999999,
"heapDeltaBytes": -4699048,
"heapUsedBytes": 75031924,
"domNodes": -246,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 2695.114,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16802.26799999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16422.7,
"heapDeltaBytes": -53709880,
"heapUsedBytes": 176498252,
"domNodes": -8061,
"jsHeapTotalBytes": -13176832,
"scriptDurationMs": 269.254,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16723.77000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16210.618999999997,
"heapDeltaBytes": -31922004,
"heapUsedBytes": 177817492,
"domNodes": -8061,
"jsHeapTotalBytes": -10555392,
"scriptDurationMs": 254.45700000000005,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20830.657000000032,
"styleRecalcs": 161,
"styleRecalcDurationMs": 18.216000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20542.234999999997,
"heapDeltaBytes": -45154560,
"heapUsedBytes": 189984696,
"domNodes": -8061,
"jsHeapTotalBytes": -13447168,
"scriptDurationMs": 903.618,
"eventListeners": -14928,
"totalBlockingTimeMs": 57,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20049.519999999917,
"styleRecalcs": 151,
"styleRecalcDurationMs": 15.566999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19777.303,
"heapDeltaBytes": -51604532,
"heapUsedBytes": 178839460,
"domNodes": -8061,
"jsHeapTotalBytes": -10731520,
"scriptDurationMs": 893.437,
"eventListeners": -14928,
"totalBlockingTimeMs": 74,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6046.979999999962,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.435,
"layouts": 20,
"layoutDurationMs": 22.872000000000003,
"taskDurationMs": 5949.824,
"heapDeltaBytes": -36920732,
"heapUsedBytes": 182327644,
"domNodes": -8061,
"jsHeapTotalBytes": 14745600,
"scriptDurationMs": 113.87799999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 406,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6043.86599999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.67800000000003,
"layouts": 20,
"layoutDurationMs": 21.918000000000006,
"taskDurationMs": 5948.081000000001,
"heapDeltaBytes": -47589180,
"heapUsedBytes": 181862720,
"domNodes": -8061,
"jsHeapTotalBytes": 19648512,
"scriptDurationMs": 105.677,
"eventListeners": -14928,
"totalBlockingTimeMs": 365,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8496.346000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8301.364,
"heapDeltaBytes": -21166604,
"heapUsedBytes": 178077528,
"domNodes": 0,
"jsHeapTotalBytes": -25427968,
"scriptDurationMs": 141.18699999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8385.913000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8221.983999999999,
"heapDeltaBytes": 16913308,
"heapUsedBytes": 190404924,
"domNodes": 0,
"jsHeapTotalBytes": -25427968,
"scriptDurationMs": 140.58400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 137.72800000003826,
"styleRecalcs": 10,
"styleRecalcDurationMs": 24.871,
"layouts": 6,
"layoutDurationMs": 2.685,
"taskDurationMs": 108.575,
"heapDeltaBytes": 3318976,
"heapUsedBytes": 64922820,
"domNodes": 140,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.258,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 102.95000000007803,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.399,
"layouts": 3,
"layoutDurationMs": 0.987,
"taskDurationMs": 72.73299999999999,
"heapDeltaBytes": 3039964,
"heapUsedBytes": 64621280,
"domNodes": 106,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.482,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18086 +/- ##
==========================================
+ Coverage 82.77% 83.80% +1.03%
==========================================
Files 2936 2244 -692
Lines 144482 127676 -16806
Branches 39021 34394 -4627
==========================================
- Hits 119593 107002 -12591
+ Misses 23632 20385 -3247
+ Partials 1257 289 -968
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
69c16b6 to
d7c87d7
Compare
Rewiring the interior node behind a subgraph's promoted input fires SubgraphInput's unconditional input-disconnected event before the reconnect resolves. SubgraphNode's handler demotes the promoted widget synchronously (input.widgetId cleared immediately) but only defers the widget-value-store cleanup via queueMicrotask, leaving a one-tick window where the widget list and the reactive store disagree. - Adds a Vitest unit test proving that synchronous disagreement exists against the real SubgraphNode/SubgraphInputNode classes. - Adds three test.fail() Playwright e2e repros reusing existing fixtures (subgraph.rebindPromotedInput) and existing test assets: a sole promoted widget that does not survive a rewire, sibling promoted widgets that get duplicated when a different promoted widget is rewired, and a promoted "width" widget that disappears on rewire.
d7c87d7 to
7cddbb4
Compare
|
Update on the CI failures ( I don't have access to raw job logs from this environment, but the PR's own Playwright report comment linked hosted HTML reports (Cloudflare Pages), which told me exactly 3 tests failed on Root cause: I located the promoted widgets via Fixed in the latest commit:
I still could not execute Playwright locally (sandbox network policy blocks the Chromium download host), so this is a targeted fix based on the evidence available (the hosted report's pass/fail counts plus the existing proven locator pattern in this file), not a locally-verified rerun. Watching the next CI run on this push. |
|
Standing-down note on Confirmed correct: the locator fix from my previous comment (switching STRING/textarea widget lookups from Still failing: Two live hypotheses, and I can't distinguish between them from here:
Why I'm not iterating further blind: I don't have a way to see the actual assertion/error text. I tried, using a
Both are blocked by this sandbox's own egress policy (403 on the CONNECT, confirmed via the proxy's own status endpoint) — the same class of block I already hit on I've also requested a re-run of the specific failed job via the API once the current run finishes (it refused mid-run: "workflow run containing this job is already running") — if that lands, it'll tell us whether this is a timing flake or deterministic, which narrows the two hypotheses above. Standing down here rather than guessing further changes without evidence. If anyone with normal (non-sandboxed) access can open the |
createPromotedMultilineWidget built its DOM widget without calling
setNodeId(), so its BaseWidget-private _visibility never aliased to the
WidgetValueStore entry _promoteWidget already registered under the same
widgetId. suppression.byConnection changes made through the store (e.g.
via createPromotedWidgetStoreProjection) never reached the textarea's own
connectionSuppressed/hidden getters. Call setNodeId() after construction so
the widget shares the store's visibility record, matching every other
promoted-widget path.
Verified against a real ComfyUI backend + Chromium:
- multilineTextarea.promoted.test.ts: new regression test confirmed red
without the fix, green with it; the file's other 5 tests are unaffected.
- SubgraphWidgetPromotion.test.ts: unaffected (54/54 still pass) - the
microtask-desync it documents is a separate SubgraphNode mechanism this
change does not touch.
- subgraphInteriorWidgetRewireRegressions.spec.ts's own three tests are
driven by that separate SubgraphNode demote/re-promote race, not by this
visibility bug, so this fix alone doesn't flip them. Running them for
real surfaced two independent issues, fixed here:
- "sole widget" and "width" cases used getPromotedWidgetCount(Names)
preconditions that don't hold even on unmodified main (an unrelated
"$$canvas-image-preview" preview exposure inflates the raw count; the
"duplicates siblings" case's getPromotedWidgetNames reflects each
slot's *interior* source name, which is "text" for every
CLIPTextEncode regardless of host disambiguation) - fixed to scope by
getPromotedWidgetCountByName.
- With that precondition fixed, both cases reliably pass end-to-end: a
real mouse-driven disconnect+reconnect spans enough task-queue turns
for input-connected to re-resolve the widget before anything observes
it missing. Flipped from test.fail() to plain assertions.
- "duplicates other promoted widgets" still reproduces for real and
remains pinned with test.fail().
|
Follow-up with a real ComfyUI backend + Chromium available (the earlier sandbox blocked both). Pushed 1. Promoted textarea visibility aliasing — fixed, verified
Added a direct regression test ( Important correction to my last update: this fix does not flip this PR's own three e2e tests or the pre-existing 2. This PR's own 3 e2e tests — ran for real, found the actual stateWith a live backend, all three tests reached a different point than CI's "3/3 fail" report suggested. Two of the three had broken preconditions unrelated to the demote/re-promote bug:
I fixed both preconditions to scope by
This resolves the standing-down comment's hypothesis #2 (self-heal) — confirmed correct for 2 of 3 cases, and unrelated to hypothesis #1 (locator bug), which was a red herring caused by these unrelated precondition bugs. 3. Redo wire drift (38px) — assessed, not trivial, no fix pushedTraced the path: There's already a precedent for exactly this class of invalidation in Suggested next step: add a |
createPromotedMultilineWidget's setNodeId() call re-registered its DOM widget's own generic disabled/label/options/serialize over the store entry _resolveInputWidget had already populated from the real interior widget (registerWidget()'s same-type branch does Object.assign over the existing entry). That widened breakage across the promoted-widget e2e suite (subgraphNested, subgraphPromotion, subgraphSerialization, subgraphResizePreservation) on top of the intended fix. Add BaseWidget.aliasVisibility(), which only points _visibility at the already-registered store entry and never calls registerWidget(), and use it here instead of setNodeId(). The new promoted-widget visibility regression test still passes unchanged.
Both the original setNodeId() call and my aliasVisibility() replacement turned out to correlate with new failures across the wider promoted-widget e2e suite (subgraphNested, subgraphPromotion, subgraphResizePreservation, subgraphSerialization) that don't reproduce on the commit before either change. Since neither approach's exact mechanism explains the breadth of what broke, the safest fix is to stop doing any extra store work in this widget's construction path rather than guess again against a slow CI loop. This reverts multilineTextarea.ts, BaseWidget.ts and widgets.ts to their state before both attempts, and drops the unit test asserting the now-reverted visibility aliasing. The textarea-visibility-suppression bug those changes targeted goes back to being an open issue, alongside the other two documented open issues in this branch's own regression spec.
Add the promoted-textarea visibility/suppression.byConnection bug to this file's existing open-issues doc, alongside the "duplicates" and "redo wire drift" issues it already documents. Both fix attempts (setNodeId-based and aliasVisibility-based) caused widespread regressions elsewhere in the promoted-widget e2e suite and were reverted in 8dd0f43, so the bug is unfixed as of this commit.
CI investigation on this branch's regressionsInvestigated the CI failures reported on this branch after commit e5ccc47 ( What failed
Root causee5ccc47's own fix — Two fix attempts, both reverted
Confirmed final CI state (commit 8dd0f43)
Left for human/future decisionThe promoted-textarea visibility/ 🤖 Generated with Claude Code |
|
Closing as superseded by #18074 (merged 2026-10-01).
The tickets for this bug family are Done. No backport is needed: this PR is test-only and the 1.54 trains it was labelled for are no longer current. |
<!-- ccr-slack-attribution -->
Requested by Christian Byrne
Summary
Pins three related subgraph promoted-widget regressions with failing (
test.fail()) Playwright e2e repros plus a Vitest unit test that proves the underlying timing bug directly againstSubgraphNode.Changes
SubgraphInput's unconditionalinput-disconnectedevent before the reconnect resolves.SubgraphNode's handler (_addSubgraphInputListeners,src/lib/litegraph/src/subgraph/SubgraphNode.ts~325-354) demotes the promoted widget synchronously (input.widgetIdcleared immediately) but only defers the widget-value-store cleanup viaqueueMicrotask, leaving a one-tick window where the widget list and the reactive store disagree about whether the widget still exists.browser_tests/tests/subgraph/subgraphInteriorWidgetRewireRegressions.spec.ts: threetest.fail()e2e repros, each reusing the existingcomfyPage.subgraph.rebindPromotedInput()fixture helper and existing test assets (no new assets added) — a sole promoted widget that does not survive a rewire, sibling promoted widgets that get duplicated in the DOM when a different promoted widget is rewired, and a promoted "width" widget that disappears on rewire. Each attaches a screenshot of the host node after the rewire as visual evidence.src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.tsthat proves the synchronous disagreement directly against the realSubgraphNode/SubgraphInputNodeclasses: immediately after the last interior link disconnects, the widget list already reports the widget gone while the widget-value store still has it registered, and only resolves after a microtask tick.Review Focus
test.fail()idiom as an existing regression test already insubgraphPromotion.spec.ts(~line 201-233) and reuse real, already-exercised fixture code (rebindPromotedInput), andpnpm exec eslint/oxfmt/oxlintall pass cleanly on the new file, but CI will be the first real execution — please watch the first run closely.Screenshots (if applicable)
Each e2e test attaches a screenshot of the host node after the rewire (
testInfo.attach(...)) — visible in the CI run's test report once it executes.🤖 Generated with Claude Code
https://claude.ai/code/session_01WgCgZKjk1bLPcyYppEr9DZ