Repository navigation
fix(agent): give the docked panel landmark a real accessible name - #16904
Conversation
|
Warning Review limit reachedNext included review available in 3 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1908 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.69 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 559 kB (baseline 559 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-04T02:12:45.199Z",
"gitSha": "052f9e0afdba4757544e6a6457bbaf7bceb5df5f",
"branch": "cifix/16875-agent-panel-title-landmark",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2048.59399999998,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.538,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.0260000000001,
"heapDeltaBytes": -11979232,
"heapUsedBytes": 57876788,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.373000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2020.7599999999957,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.161,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.317,
"heapDeltaBytes": 13211816,
"heapUsedBytes": 82958768,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.143999999999998,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.7549999999624,
"styleRecalcs": 74,
"styleRecalcDurationMs": 35.76,
"layouts": 14,
"layoutDurationMs": 4.209999999999999,
"taskDurationMs": 863.472,
"heapDeltaBytes": -12366164,
"heapUsedBytes": 58076464,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 157.17999999999998,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.6979999999667,
"styleRecalcs": 79,
"styleRecalcDurationMs": 43.528,
"layouts": 14,
"layoutDurationMs": 4.4190000000000005,
"taskDurationMs": 863.116,
"heapDeltaBytes": -6940580,
"heapUsedBytes": 63819180,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 157.529,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.1089999999185,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.628,
"layouts": 6,
"layoutDurationMs": 1.1530000000000002,
"taskDurationMs": 352.53299999999996,
"heapDeltaBytes": 5047396,
"heapUsedBytes": 74936996,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.124,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1699.7139999999717,
"styleRecalcs": 30,
"styleRecalcDurationMs": 21.125999999999998,
"layouts": 6,
"layoutDurationMs": 0.9280000000000003,
"taskDurationMs": 351.874,
"heapDeltaBytes": 5096468,
"heapUsedBytes": 75928104,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.799,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 655.1359999999704,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.025999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.24299999999994,
"heapDeltaBytes": 18817876,
"heapUsedBytes": 88510560,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 157.507,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 642.9709999999886,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.308999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.186,
"heapDeltaBytes": -7463236,
"heapUsedBytes": 62988264,
"domNodes": 16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 162.004,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.7210000000046,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.492999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.307,
"heapDeltaBytes": 11226140,
"heapUsedBytes": 87264904,
"domNodes": -267,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 33.04199999999999,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2060.7290000000376,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.103,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.0929999999998,
"heapDeltaBytes": -13646020,
"heapUsedBytes": 87637236,
"domNodes": -264,
"jsHeapTotalBytes": -589824,
"scriptDurationMs": 39.391,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2190.919000000008,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.528,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1574.138,
"heapDeltaBytes": 22282672,
"heapUsedBytes": 88166728,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 785.722,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2291.6460000000143,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.479000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1714.0040000000001,
"heapDeltaBytes": 10494948,
"heapUsedBytes": 87040948,
"domNodes": -270,
"jsHeapTotalBytes": 1171456,
"scriptDurationMs": 870.352,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3510.487000000012,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.223000000000003,
"layouts": 60,
"layoutDurationMs": 11.447,
"taskDurationMs": 1663.694,
"heapDeltaBytes": 9497172,
"heapUsedBytes": 76293592,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 753.269,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3506.2359999999444,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.514999999999999,
"layouts": 60,
"layoutDurationMs": 11.608,
"taskDurationMs": 1645.8179999999998,
"heapDeltaBytes": 8478172,
"heapUsedBytes": 76462676,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 749.9019999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3164.541999999983,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.942000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1960.437,
"heapDeltaBytes": 18557672,
"heapUsedBytes": 85838608,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1000.8489999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3145.9449999999833,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.567999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1965.499,
"heapDeltaBytes": 23660128,
"heapUsedBytes": 91389552,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 999.4210000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.3020000000388,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.758000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.8729999999999,
"heapDeltaBytes": 10977352,
"heapUsedBytes": 87371888,
"domNodes": -270,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 33.62400000000001,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2018.212999999946,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.748999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.0079999999999,
"heapDeltaBytes": 22300164,
"heapUsedBytes": 87919248,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.921000000000003,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.4919999999456,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.928,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.68800000000005,
"heapDeltaBytes": 15112636,
"heapUsedBytes": 88063632,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 142.754,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.6749999999756,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.796,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.482,
"heapDeltaBytes": 15172996,
"heapUsedBytes": 87899556,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.063,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2038.10900000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.250000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.777,
"heapDeltaBytes": -7614792,
"heapUsedBytes": 65142544,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.574000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.4700000000494,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.809000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.255,
"heapDeltaBytes": -7628048,
"heapUsedBytes": 65156872,
"domNodes": -296,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.761999999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.4160000000193,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.715,
"layouts": 18,
"layoutDurationMs": 5.581,
"taskDurationMs": 833.74,
"heapDeltaBytes": 2744372,
"heapUsedBytes": 75695076,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 110.588,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.2219999999934,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.981,
"layouts": 18,
"layoutDurationMs": 5.3340000000000005,
"taskDurationMs": 825.7320000000001,
"heapDeltaBytes": -11866500,
"heapUsedBytes": 60558532,
"domNodes": -296,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 114.62,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.5369999999857,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.381,
"layouts": 14,
"layoutDurationMs": 15.415999999999999,
"taskDurationMs": 922.6969999999999,
"heapDeltaBytes": 21060116,
"heapUsedBytes": 108749108,
"domNodes": 13751,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 31.703999999999997,
"eventListeners": 2387,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8396.51600000002,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.094,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5882.951999999999,
"heapDeltaBytes": -6513536,
"heapUsedBytes": 95013880,
"domNodes": -267,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 2753.65,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8402.141000000029,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.136,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5682.91,
"heapDeltaBytes": -8598336,
"heapUsedBytes": 92958656,
"domNodes": -268,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 2628.21,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17002.429000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16482.175,
"heapDeltaBytes": -29007672,
"heapUsedBytes": 174617040,
"domNodes": -6552,
"jsHeapTotalBytes": -5984256,
"scriptDurationMs": 309.347,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16782.201999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16346.302000000001,
"heapDeltaBytes": -35042420,
"heapUsedBytes": 175721784,
"domNodes": -6548,
"jsHeapTotalBytes": 2072576,
"scriptDurationMs": 293.939,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21095.621999999934,
"styleRecalcs": 174,
"styleRecalcDurationMs": 17.15,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20660.705,
"heapDeltaBytes": -42656716,
"heapUsedBytes": 166972448,
"domNodes": -6548,
"jsHeapTotalBytes": -7503872,
"scriptDurationMs": 910.25,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20644.078000000038,
"styleRecalcs": 169,
"styleRecalcDurationMs": 17.392000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20269.989,
"heapDeltaBytes": -30923556,
"heapUsedBytes": 177345028,
"domNodes": -6577,
"jsHeapTotalBytes": -2580480,
"scriptDurationMs": 913.2900000000002,
"eventListeners": -7467,
"totalBlockingTimeMs": 30,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6108.425000000011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.59299999999998,
"layouts": 20,
"layoutDurationMs": 22.785,
"taskDurationMs": 6003.256,
"heapDeltaBytes": -27304604,
"heapUsedBytes": 181220600,
"domNodes": -6548,
"jsHeapTotalBytes": 11399168,
"scriptDurationMs": 109.32799999999999,
"eventListeners": -7473,
"totalBlockingTimeMs": 465,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6264.238999999975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.289,
"layouts": 20,
"layoutDurationMs": 23.555000000000007,
"taskDurationMs": 6147.826999999999,
"heapDeltaBytes": -28265004,
"heapUsedBytes": 181097592,
"domNodes": -6548,
"jsHeapTotalBytes": 12550144,
"scriptDurationMs": 118.16600000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 490,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8407.834999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8230.949,
"heapDeltaBytes": -2667160,
"heapUsedBytes": 176383824,
"domNodes": 0,
"jsHeapTotalBytes": -13107200,
"scriptDurationMs": 133.11300000000003,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8427.365000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8219.601999999999,
"heapDeltaBytes": 5396180,
"heapUsedBytes": 174466492,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 147.60600000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 120.4890000000205,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.133000000000003,
"layouts": 2,
"layoutDurationMs": 0.64,
"taskDurationMs": 76.077,
"heapDeltaBytes": 3139904,
"heapUsedBytes": 72109728,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.065000000000002,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 451.63099999990663,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.418000000000003,
"layouts": 2,
"layoutDurationMs": 0.43500000000000005,
"taskDurationMs": 94.43300000000002,
"heapDeltaBytes": 4791240,
"heapUsedBytes": 73712816,
"domNodes": 119,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.365999999999998,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
merge-order guard (pr-hygiene sweep, non-blocking): this PR's one-file diff is a strict subset of eight other open PRs that also touch Full context for agent readersFE This PR renders exactly that id, so it is the fix-forward carrier for program rows Overlap computed from |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16904 +/- ##
==========================================
+ Coverage 81.17% 82.73% +1.55%
==========================================
Files 2460 2042 -418
Lines 126655 119178 -7477
Branches 31933 31921 -12
==========================================
- Hits 102807 98597 -4210
+ Misses 23332 20400 -2932
+ Partials 516 181 -335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 426 files with indirect coverage changes 🚀 New features to boost your workflow:
|
`DockedAgentPanel` puts an unconditional `aria-labelledby="agent-panel-title"` on its `role="complementary"` element, but the only node carrying that id lives in the `AgentPanelLoadError` fallback. On the success path `AgentPanelRoot` renders `id="agent-panel-root"` and no title, so the reference dangled and the landmark had no accessible name -- exactly the state `agentPanelLifecycle.spec.ts:84` asserts against. The dock used to be a stub that carried the title itself; #16198 replaced it with the real `AgentPanelRoot` and the id went with it. #16217 added the coverage on 2026-08-29 and merged on that receipt six days later, after the regression had already landed, so `playwright-tests (cloud)` went red on `main` at 590e759. Render the same `agent.title` string from `AgentPanelRoot` so the name resolves whichever of the two branches is mounted.
b4570d0 to
7b98754
Compare
|
Deployment failed for project comfy-home-v1 with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
PR-shepherd dossier — FE #16904 Stage at 2026-09-04T02:2xZ: head
Verification, in both directions, against a real build.
CI at this head agrees: 76 success / 12 skipped / zero failed check-runs, with Merge readiness: everything green except one status that is red on Next stage needed: merge, by whoever holds FE authority. Nothing else is outstanding: no unresolved threads, no conflicts, head contains the current |
|
Correction to this comment: I posted it as a close-as-duplicate while this PR was still open, and it merged at #16903 merged 16 minutes earlier and fixed the same dangling
The smaller fix looks like dropping the |
…#16903 (#16912) - Removes the duplicate `id="agent-panel-title"` that #16904 added to `AgentPanelRoot.vue`. - #16903 (merged 16 min earlier) already fixed the dangling `aria-labelledby` on `PanelHeader.vue:36`; both together mount two elements with the same id on the success path. - Pure revert of 34b6558; no other change. <details><summary>Full context for agent readers</summary> **Why:** `DockedAgentPanel` sets `aria-labelledby="agent-panel-title"` unconditionally. #16903 put the id on the success-path `<h1>` in `PanelHeader.vue`; #16904 independently added an `sr-only <h2>` with the same id in `AgentPanelRoot.vue`. `AgentPanelRoot` renders `AgentPanel` → `PanelHeader`, so after both merges main has two elements with `id="agent-panel-title"` whenever the panel loads successfully. Duplicate ids are invalid HTML and make `aria-labelledby` resolution browser-dependent. **Test coverage:** `browser_tests/tests/agent/agentPanelLifecycle.spec.ts:84` asserts `toHaveCount(1)` and would receive 2, but #16907 marked that test `test.fixme` at 5764cd3 minutes later, so CI no longer surfaces it. Once this lands, re-enabling that test is a candidate follow-up (not included here to keep this a pure revert). **Verification:** `git revert 34b6558` applied cleanly (8 deletions, one file); `rg agent-panel-title src/workbench/extensions/agent/AgentPanelRoot.vue` → 0 matches on this branch; `PanelHeader.vue:36` retains the id. Related: #16903, #16904, #16907. </details> <!-- authored-by:agent desktop-commander -->
) *PR Created by the Glary-Bot Agent* --- ## Summary Re-enables the Agent panel keyboard-accessibility e2e test, which was muted five days ago to unblock CI and left muted after the bug it caught was fixed 29 minutes later. ## Changes - **What**: `test.fixme(` → `test(` on `browser_tests/tests/agent/agentPanelLifecycle.spec.ts:68`. Byte-exact inverse of the disabling commit in Comfy-Org#16907. No assertion touched. ## Review Focus The mute was collateral from two PRs racing on 2026-09-03: | Time | PR | Event | |---|---|---| | 17:25 | Comfy-Org#16217 | Test added, green | | ~19:20 | Comfy-Org#16903 + Comfy-Org#16904 | Both render `id="agent-panel-title"` → **duplicate DOM id** | | 19:48 | Comfy-Org#16907 | Test muted (`toHaveCount(1)` was correctly failing) | | 20:17 | Comfy-Org#16912 | Duplicate id removed — the actual fix, but the mute stayed | So the test did its job: it caught a real a11y regression (a duplicate DOM id that left the `role="complementary"` landmark's `aria-labelledby` ambiguous). Comfy-Org#16912 is an ancestor of this branch, so the cause is gone. On `main` the id now has exactly two renderers — `PanelHeader.vue:36` (success path) and the `errorComponent` in `DockedAgentPanel.vue:48` — which are mutually exclusive. Verified by running it, not just reading it. Against a `pnpm dev:cloud` server on the `cloud` project: **10/10 green** on `--repeat-each=10`, and the full spec goes from 4 passed / 1 skipped to 5 passed. Measured DOM state at the moment of assertion: ```json { "agentPanelTitleIds": 1, "complementaryLandmarks": 1, "landmarkRole": "complementary", "landmarkLabelledBy": "agent-panel-title", "accessibleName": "Comfy Agent" } ``` Two notes for the reviewer: - Lines 85-91 gate for the first time here — they never executed in CI, because line 84 failed on the duplicate id before reaching them. Treat the `playwright-tests (cloud)` run as the receipt rather than my local runs. - The one spec test that fails locally, `preserves the stored preference while the flag is off`, fails identically on unmodified `main`. It is a dev-server artifact: `agentPanel.ts:92` forces `enabled = true` when `import.meta.env.MODE === 'development'`, so "flag off" is not reproducible outside a built bundle. Unrelated to this change. Possible follow-ups, deliberately not done here: a component-level guard asserting exactly one `#agent-panel-title` (cheaper than a single unsharded `@cloud` e2e as the only net for that class of bug — branches doing this already exist), and focus-restoration assertions if this test is meant to be the panel's full keyboard-a11y guard. ## Screenshots Panel opened via `Enter` on the trigger, header title rendering. ## Screenshots  Co-authored-by: glary-bot <glary-bot@comfy.org>
Summary
playwright-tests (cloud)is red onmainat590e7596e9; this restores the accessible name the docked agent panel landmark has been missing since #16198, which is what the newly-landed lifecycle spec asserts.Changes
AgentPanelRootnow renders ansr-only<h2 id="agent-panel-title">carryingt('agent.title').DockedAgentPanelsetsaria-labelledby="agent-panel-title"unconditionally on itsrole="complementary"element, but the only node with that id lives in theAgentPanelLoadErrorfallback, so on the success path the reference dangled and the landmark had no accessible name.Review Focus
This is a red-
mainfix-forward, so the provenance matters more than the diff.The dock used to be the stub shell from #16071, which carried the title itself. #16198 (
f954e479a3) swapped the stub for the realAgentPanelRootand the title went with it, leaving thearia-labelledbydangling. #16217 addedbrowser_tests/tests/agent/agentPanelLifecycle.spec.tson 2026-08-29 and merged on that same six-day-old green receipt at 2026-09-04T00:25:19Z, after the regression had already landed. So the spec is correct and it ismainthat was wrong; the assertion has simply never run against post-#16198 code until now.Verified locally against a
pnpm build:clouddist served on:6209, withPLAYWRIGHT_TEST_URLpointed at it:origin/main@590e7596e9: 1 failed, 5 passed —expect(locator('#agent-panel-title')).toHaveCount(1)received0, byte-identical to run 33822395883The two branches are mutually exclusive (
AgentPanelLoadErroris the async component'serrorComponent), so this cannot produce two nodes with the same id.sr-onlyand theagent.titlestring are both what the fallback already uses, so a screen reader announces the same name on either path.Justification: red
mainfix-forward under the program's red-mainP0 rule; the failing assertion is reproduced and cleared locally before and after, and the change is additive markup with no behavioural surface.