Repository navigation
ci(comfy-multi-player): stop running the stateless probe twice - #16909
christian-byrne wants to merge 1 commit into
Conversation
check:stateless already spawns an explicit vitest run of test/stateless.test.ts, and the package test script is unfiltered vitest run under include: ["test/**/*.test.ts"], so both the CI and publish workflows executed that probe twice per run. Exclude it from the suite step and keep check:stateless as the single merge-blocking behavioral probe; the static lint it carries is unchanged. Fixes Comfy-Org/comfy-multi-player#153
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1916 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-04T02:33:14.218Z",
"gitSha": "bbc9a6daac31b954b76eea8324e0d04dac1edb07",
"branch": "desktop-shard/cmp-153-dedup-stateless-probe",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2001.6859999999497,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.455,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.82400000000007,
"heapDeltaBytes": 517328,
"heapUsedBytes": 71005720,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.862000000000001,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2034.6130000000358,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.52,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.942,
"heapDeltaBytes": 5607656,
"heapUsedBytes": 74404912,
"domNodes": -276,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.747000000000001,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1837.4579999999696,
"styleRecalcs": 76,
"styleRecalcDurationMs": 33.637,
"layouts": 14,
"layoutDurationMs": 4.228,
"taskDurationMs": 832.767,
"heapDeltaBytes": -7745852,
"heapUsedBytes": 62584252,
"domNodes": -277,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 132.459,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.1600000000735,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.019000000000002,
"layouts": 14,
"layoutDurationMs": 3.4140000000000006,
"taskDurationMs": 703.346,
"heapDeltaBytes": -8764120,
"heapUsedBytes": 61578312,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 110.58900000000001,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.798000000057,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.496,
"layouts": 6,
"layoutDurationMs": 1.026,
"taskDurationMs": 309.55,
"heapDeltaBytes": 5062324,
"heapUsedBytes": 75724072,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.023000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.7500000000382,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.163999999999998,
"layouts": 6,
"layoutDurationMs": 0.9259999999999999,
"taskDurationMs": 300.90700000000004,
"heapDeltaBytes": 5032408,
"heapUsedBytes": 75623572,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.732000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 555.9009999999489,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.612,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.965,
"heapDeltaBytes": 17714004,
"heapUsedBytes": 87606760,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 119.29799999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 558.8859999999158,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.295,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.768,
"heapDeltaBytes": -8147932,
"heapUsedBytes": 62619812,
"domNodes": 22,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 119.44200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2060.5150000000094,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.671999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.766,
"heapDeltaBytes": -14339160,
"heapUsedBytes": 87119336,
"domNodes": -264,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 42.548,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2027.8789999999844,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.809000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.00500000000005,
"heapDeltaBytes": -13611868,
"heapUsedBytes": 87981076,
"domNodes": -264,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 33.508,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2102.7820000000474,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.717,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1239.1999999999998,
"heapDeltaBytes": 22312184,
"heapUsedBytes": 88470324,
"domNodes": -268,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 583.6940000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2109.7049999999626,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.366999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1270.7099999999998,
"heapDeltaBytes": 21844912,
"heapUsedBytes": 88186100,
"domNodes": 6,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 600.5370000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3210.8819999999696,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.709999999999997,
"layouts": 60,
"layoutDurationMs": 13.016,
"taskDurationMs": 1389.709,
"heapDeltaBytes": 8161332,
"heapUsedBytes": 75785584,
"domNodes": 6,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 600.967,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3173.5780000000204,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.075000000000005,
"layouts": 60,
"layoutDurationMs": 12.246,
"taskDurationMs": 1343.064,
"heapDeltaBytes": 11691732,
"heapUsedBytes": 79841624,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 584.819,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2226.11500000005,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.695000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1489.337,
"heapDeltaBytes": 13626076,
"heapUsedBytes": 81648368,
"domNodes": -275,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 705.3090000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2378.6389999999074,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.930999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1534.3619999999999,
"heapDeltaBytes": 14923236,
"heapUsedBytes": 82177084,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 746.6550000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2041.005000000041,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.724999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.91200000000003,
"heapDeltaBytes": -15909244,
"heapUsedBytes": 87735116,
"domNodes": -268,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 37.894000000000005,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2001.7560000000003,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.2259999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.827,
"heapDeltaBytes": 22291816,
"heapUsedBytes": 88417480,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.489,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 546.3310000000092,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.590000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.083,
"heapDeltaBytes": 14945216,
"heapUsedBytes": 87746448,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 104.464,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 522.5780000000668,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.6869999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.121,
"heapDeltaBytes": 14878652,
"heapUsedBytes": 87702588,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 101.949,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.9740000000274,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.225000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.7610000000001,
"heapDeltaBytes": 2691388,
"heapUsedBytes": 75603352,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.324000000000001,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1991.9290000000274,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.692000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.213,
"heapDeltaBytes": 1233880,
"heapUsedBytes": 73919736,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.140000000000002,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.5809999999574,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.33,
"layouts": 18,
"layoutDurationMs": 3.691,
"taskDurationMs": 673.221,
"heapDeltaBytes": 3234276,
"heapUsedBytes": 76162248,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 77.61800000000001,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.6329999999161,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.952999999999996,
"layouts": 18,
"layoutDurationMs": 4.029999999999999,
"taskDurationMs": 671.578,
"heapDeltaBytes": 3927452,
"heapUsedBytes": 76864540,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 74.35300000000001,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 966.1070000000791,
"styleRecalcs": 21,
"styleRecalcDurationMs": 25.064999999999998,
"layouts": 17,
"layoutDurationMs": 10.866999999999997,
"taskDurationMs": 723.1650000000001,
"heapDeltaBytes": 21003984,
"heapUsedBytes": 109470224,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 24.18499999999999,
"eventListeners": 2385,
"totalBlockingTimeMs": 112,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8180.124999999975,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.038,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4725.735000000001,
"heapDeltaBytes": 14578956,
"heapUsedBytes": 91023388,
"domNodes": -267,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2099.24,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8185.939000000076,
"styleRecalcs": 251,
"styleRecalcDurationMs": 34.995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4633.611,
"heapDeltaBytes": -12198864,
"heapUsedBytes": 89547952,
"domNodes": -260,
"jsHeapTotalBytes": -102400,
"scriptDurationMs": 2031.063,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13116.018000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12312.339000000002,
"heapDeltaBytes": -30602204,
"heapUsedBytes": 175865328,
"domNodes": -6548,
"jsHeapTotalBytes": 1024000,
"scriptDurationMs": 216.528,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12878.669999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12345.703999999998,
"heapDeltaBytes": -57531896,
"heapUsedBytes": 162259944,
"domNodes": -6548,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 223.232,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16049.230999999963,
"styleRecalcs": 92,
"styleRecalcDurationMs": 15.64600000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15484.629000000003,
"heapDeltaBytes": -51389904,
"heapUsedBytes": 159811020,
"domNodes": -6548,
"jsHeapTotalBytes": -11280384,
"scriptDurationMs": 856.595,
"eventListeners": -7473,
"totalBlockingTimeMs": 132,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16724.886000000082,
"styleRecalcs": 125,
"styleRecalcDurationMs": 18.062999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16172.131,
"heapDeltaBytes": -36379900,
"heapUsedBytes": 166809624,
"domNodes": -6548,
"jsHeapTotalBytes": 1286144,
"scriptDurationMs": 861.717,
"eventListeners": -7469,
"totalBlockingTimeMs": 55,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4688.098999999966,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.615,
"layouts": 20,
"layoutDurationMs": 22.688999999999986,
"taskDurationMs": 4586.0960000000005,
"heapDeltaBytes": -29188816,
"heapUsedBytes": 174989312,
"domNodes": -6548,
"jsHeapTotalBytes": 9756672,
"scriptDurationMs": 106.01500000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 75,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4682.928999999945,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.04199999999999,
"layouts": 20,
"layoutDurationMs": 23.056999999999995,
"taskDurationMs": 4547.631000000001,
"heapDeltaBytes": -20307996,
"heapUsedBytes": 180142360,
"domNodes": -6548,
"jsHeapTotalBytes": 16752640,
"scriptDurationMs": 90.415,
"eventListeners": -7473,
"totalBlockingTimeMs": 68,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6875.770999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6435.785999999998,
"heapDeltaBytes": 13010220,
"heapUsedBytes": 182726980,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 118.27500000000002,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7156.526999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6625.891,
"heapDeltaBytes": 10751904,
"heapUsedBytes": 174618388,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 140.474,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 86.67300000001887,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.985000000000001,
"layouts": 3,
"layoutDurationMs": 1.0929999999999997,
"taskDurationMs": 55.964,
"heapDeltaBytes": 3023344,
"heapUsedBytes": 71822652,
"domNodes": 123,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.504,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 439.3489999999929,
"styleRecalcs": 17,
"styleRecalcDurationMs": 16.509000000000004,
"layouts": 3,
"layoutDurationMs": 1.7779999999999998,
"taskDurationMs": 90.461,
"heapDeltaBytes": 4897960,
"heapUsedBytes": 73865952,
"domNodes": 144,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.8999999999999995,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## christian-byrne/ecw-106-comfy-multi-player-workspace #16909 +/- ##
========================================================================================
+ Coverage 80.79% 82.33% +1.53%
========================================================================================
Files 2475 2057 -418
Lines 128216 120738 -7478
Branches 34553 32726 -1827
========================================================================================
- Hits 103597 99410 -4187
+ Misses 24103 21147 -2956
+ Partials 516 181 -335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Shepherding tick: exact-head checks fully terminal green, head and stacked base both unchanged — nothing to rebase, nothing to fix. Full context for agent readers
|
|
Standalone replacement: governance recovery. Frontend relocation remains deferred. Full context for agent readersThe replacement recovers governance tests and invariant registration into comfy-multi-player main. The duplicate frontend-workflow deletion is accounted for by the already-landed standalone restoration, not copied into the replacement. The replacement body attributes all ten captured comments across the three governance sources, retaining authors, dates and direct links. The earlier instruction to keep this work stacked on the frontend relocation is superseded by Christian's standalone ruling. Historical checks and review-skipped notices are preserved as history, not fresh verification or approvals. The replacement passed its local tests and gates; hosted checks and actual review remain required. This source stays preserved until code, collaboration and late-comment accounting complete. No source branch or review thread is deleted or resolved by this message. |
|
Superseded by merged standalone automation: Full context for agent readersChristian authorized finishing the standalone recovery's source-retirement gap. GitHub now records this source as closed by christian-byrne at 2026-09-21T21:58:40Z, without merge. No rebase or retarget is needed; the old frontend relocation is no longer the destination. Source revision: c07ff94 . The standalone restoration already delivered equivalent workflow behavior: exclude the statelessness probe from the full suite because its dedicated gate runs it separately. Replacement merge: Comfy-Org/comfy-multi-player@5891802 . Current pinned source confirms both halves:
The governance recovery explicitly accounts for this source as superseded, not a literal copy of frontend-specific workflows: Comfy-Org/comfy-multi-player#200 . Its body preserves the original authors, dates and discussion links. Late-comment refresh covered all five issue comments, native reviews and inline comments: no new substantive feedback since the recovery receipt #16909 (comment) and no native reviews or inline findings. The older instruction to wait for frontend relocation is superseded; historical checks are not new verification. The original body, branch and all discussion remain preserved. This receipt does not close the separate tracking issue or authorize publication, deployment or product acceptance. No local checks ran. Glossary: statelessness probe is the test for document-owned state; retirement means closing the redundant source pull request, not deleting history. |
Summary
test/stateless.test.tsruns twice in both comfy-multi-player workflows: once as the explicit probe insidecheck:stateless, and again as part of the unfiltered package test suite. The probe spawns fresh Node subprocesses, so the duplicate is the most expensive kind to pay for twice. This excludes it from the suite step and leavescheck:statelessas the single behavioral probe.Changes
.github/workflows/ci-comfy-multi-player.yaml"Test package" step and thetestline inside.github/workflows/publish-comfy-multi-player.yaml"Verify package" now pass--exclude test/stateless.test.ts.packages/comfy-multi-player/scripts/check-stateless.mjsspawnsvitest run test/stateless.test.ts --reporter=dot, whilepackage.jsonsets"test": "vitest run"andvitest.config.tssetsinclude: ["test/**/*.test.ts"], so the unfiltered run re-collects it.CI wiring only. No package script, no
vitest.config.ts, no test source, and nothing in the probe's subprocess logic is touched.check:statelesskeeps both halves it is unique for, the static purity lint and the explicit behavioral probe, so the statelessness contract stays merge-blocking.Review Focus
The
--separator would have made this a silent no-op.pnpm --filter <pkg> test -- --exclude test/stateless.test.tsforwards a literal--ahead of the flag, and vitest's CLI treats a bare--as end-of-options, so the exclusion is silently ignored and the file still runs. Verified directly:vitest list --filesOnly -- --exclude test/stateless.test.tsreports 58 files in the standalone checkout, the same as an unfiltered list, while the separator-free form reports 57. The form used here has no--; pnpm 11 forwards the flag unchanged (confirmed against a scratch workspace whose script echoesprocess.argv).--excludereplaces vitest's default exclude list rather than extending it. That is harmless here becauseincludeis already narrowed totest/**/*.test.ts, so the dropped**/node_modules/**and**/dist/**defaults cannot match anything the include glob reaches. Worth knowing if the include glob ever widens.Why the suite step gives up the file rather than
check:statelessgiving up its probe. Removing the probe fromcheck-stateless.mjswould leave the statelessness contract covered only implicitly, as one file inside a 70-file suite, and it would be a package script change rather than CI wiring. Keeping the explicit probe preserves the named, greppable, merge-blocking check.Verification
Run in this worktree at
c07ff94640, Node 25.9.0, pnpm 11.13.1:pnpm --filter @comfyorg/comfy-multi-player exec vitest list --filesOnly— 71 files before, 70 with the new flag, and the one dropped file istest/stateless.test.tspnpm --filter @comfyorg/comfy-multi-player test --exclude test/stateless.test.ts— 870 tests, all pass afterrun build(the one failure without a build istest/purity.test.tsassertingdist/index.jsexists, which the workflow's earliertypecheckstep already produces; it passes once built)pnpm --filter @comfyorg/comfy-multi-player run check:stateless— passes, 16 source files linted, probe passed.github/workflows/*.yamlboth parseProvenance
This fixes Comfy-Org/comfy-multi-player#153. It is opened here, based on #16644, rather than on the standalone repo, because #168 deleted that repo's entire
.github/workflows/tree and declared it read-only history. The workflows this touches exist only on the migration branch, so it is the only writable copy. Same routing as #16896.Fixes Comfy-Org/comfy-multi-player#153