Skip to content

ci(comfy-multi-player): stop running the stateless probe twice - #16909

Closed
christian-byrne wants to merge 1 commit into
christian-byrne/ecw-106-comfy-multi-player-workspacefrom
desktop-shard/cmp-153-dedup-stateless-probe
Closed

christian-byrne wants to merge 1 commit into
christian-byrne/ecw-106-comfy-multi-player-workspacefrom
desktop-shard/cmp-153-dedup-stateless-probe

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

test/stateless.test.ts runs twice in both comfy-multi-player workflows: once as the explicit probe inside check:stateless, and again as part of the unfiltered package test suite. The probe spawns fresh Node subprocesses, so the duplicate is the most expensive kind to pay for twice. This excludes it from the suite step and leaves check:stateless as the single behavioral probe.

Changes

  • What: .github/workflows/ci-comfy-multi-player.yaml "Test package" step and the test line inside .github/workflows/publish-comfy-multi-player.yaml "Verify package" now pass --exclude test/stateless.test.ts.
  • Why both reached the same file: packages/comfy-multi-player/scripts/check-stateless.mjs spawns vitest run test/stateless.test.ts --reporter=dot, while package.json sets "test": "vitest run" and vitest.config.ts sets include: ["test/**/*.test.ts"], so the unfiltered run re-collects it.

CI wiring only. No package script, no vitest.config.ts, no test source, and nothing in the probe's subprocess logic is touched. check:stateless keeps both halves it is unique for, the static purity lint and the explicit behavioral probe, so the statelessness contract stays merge-blocking.

Review Focus

The -- separator would have made this a silent no-op. pnpm --filter <pkg> test -- --exclude test/stateless.test.ts forwards a literal -- ahead of the flag, and vitest's CLI treats a bare -- as end-of-options, so the exclusion is silently ignored and the file still runs. Verified directly: vitest list --filesOnly -- --exclude test/stateless.test.ts reports 58 files in the standalone checkout, the same as an unfiltered list, while the separator-free form reports 57. The form used here has no --; pnpm 11 forwards the flag unchanged (confirmed against a scratch workspace whose script echoes process.argv).

--exclude replaces vitest's default exclude list rather than extending it. That is harmless here because include is already narrowed to test/**/*.test.ts, so the dropped **/node_modules/** and **/dist/** defaults cannot match anything the include glob reaches. Worth knowing if the include glob ever widens.

Why the suite step gives up the file rather than check:stateless giving up its probe. Removing the probe from check-stateless.mjs would leave the statelessness contract covered only implicitly, as one file inside a 70-file suite, and it would be a package script change rather than CI wiring. Keeping the explicit probe preserves the named, greppable, merge-blocking check.

Verification

Run in this worktree at c07ff94640, Node 25.9.0, pnpm 11.13.1:

  • pnpm --filter @comfyorg/comfy-multi-player exec vitest list --filesOnly — 71 files before, 70 with the new flag, and the one dropped file is test/stateless.test.ts
  • pnpm --filter @comfyorg/comfy-multi-player test --exclude test/stateless.test.ts — 870 tests, all pass after run build (the one failure without a build is test/purity.test.ts asserting dist/index.js exists, which the workflow's earlier typecheck step already produces; it passes once built)
  • pnpm --filter @comfyorg/comfy-multi-player run check:stateless — passes, 16 source files linted, probe passed
  • .github/workflows/*.yaml both parse

Provenance

This fixes Comfy-Org/comfy-multi-player#153. It is opened here, based on #16644, rather than on the standalone repo, because #168 deleted that repo's entire .github/workflows/ tree and declared it read-only history. The workflows this touches exist only on the migration branch, so it is the only writable copy. Same routing as #16896.

Fixes Comfy-Org/comfy-multi-player#153

check:stateless already spawns an explicit vitest run of test/stateless.test.ts,
and the package test script is unfiltered vitest run under
include: ["test/**/*.test.ts"], so both the CI and publish workflows executed
that probe twice per run. Exclude it from the suite step and keep check:stateless
as the single merge-blocking behavioral probe; the static lint it carries is
unchanged.

Fixes Comfy-Org/comfy-multi-player#153
@christian-byrne christian-byrne self-assigned this Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 6fe46124-3a24-49bc-b879-360c1db52f33

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1916 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1895 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.2 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 112ms TBT · 104.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.1 MB heap
vue-large-graph-idle: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 161.2 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 94ms TBT · 155.7 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 72ms TBT · 169.3 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 431ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 69.3 MB
canvas-idle: DOM nodes -278
canvas-idle: event listeners -182
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 768ms
canvas-mouse-sweep: script duration 122ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.2 MB
canvas-mouse-sweep: DOM nodes -278
canvas-mouse-sweep: event listeners -150
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 13ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 305ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.2 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 354ms
dom-widget-clipping: script duration 119ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.6 MB
dom-widget-clipping: DOM nodes 22
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 531ms
large-graph-idle: script duration 38ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.5 MB
large-graph-idle: DOM nodes -264
large-graph-idle: event listeners -147
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1255ms
large-graph-pan: script duration 592ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.2 MB
large-graph-pan: DOM nodes -131
large-graph-pan: event listeners 6
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1366ms
large-graph-zoom: script duration 593ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.2 MB
large-graph-zoom: DOM nodes 3
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1512ms
legacy-node-drag: script duration 726ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 78.1 MB
legacy-node-drag: DOM nodes -136
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 484ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.0 MB
minimap-idle: DOM nodes -270
minimap-idle: event listeners -70
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 324ms
subgraph-dom-widget-clipping: script duration 103ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.7 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 424ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 71.3 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -228
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 26ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 672ms
subgraph-mouse-sweep: script duration 76ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 73.0 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 25ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 723ms
subgraph-transition-enter: script duration 24ms
subgraph-transition-enter: TBT 112ms
subgraph-transition-enter: heap used 104.4 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4680ms
viewport-pan-sweep: script duration 2065ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 86.1 MB
viewport-pan-sweep: DOM nodes -264
viewport-pan-sweep: event listeners -147
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 12329ms
vue-large-graph-idle: script duration 220ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 161.2 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7475
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 109
vue-large-graph-pan: task duration 15828ms
vue-large-graph-pan: script duration 859ms
vue-large-graph-pan: TBT 94ms
vue-large-graph-pan: heap used 155.7 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7471
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 61ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4567ms
vue-node-resize-workload: script duration 98ms
vue-node-resize-workload: TBT 72ms
vue-node-resize-workload: heap used 169.3 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7473
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6531ms
vue-zoom-out-idle: script duration 129ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.4 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -9
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 73ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.5 MB
workflow-execution: DOM nodes 134
workflow-execution: event listeners 41
Raw data
{
  "timestamp": "2026-09-04T02:33:14.218Z",
  "gitSha": "bbc9a6daac31b954b76eea8324e0d04dac1edb07",
  "branch": "desktop-shard/cmp-153-dedup-stateless-probe",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2001.6859999999497,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.455,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.82400000000007,
      "heapDeltaBytes": 517328,
      "heapUsedBytes": 71005720,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.862000000000001,
      "eventListeners": -182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2034.6130000000358,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.52,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.942,
      "heapDeltaBytes": 5607656,
      "heapUsedBytes": 74404912,
      "domNodes": -276,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 7.747000000000001,
      "eventListeners": -182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1837.4579999999696,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 33.637,
      "layouts": 14,
      "layoutDurationMs": 4.228,
      "taskDurationMs": 832.767,
      "heapDeltaBytes": -7745852,
      "heapUsedBytes": 62584252,
      "domNodes": -277,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 132.459,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1725.1600000000735,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 26.019000000000002,
      "layouts": 14,
      "layoutDurationMs": 3.4140000000000006,
      "taskDurationMs": 703.346,
      "heapDeltaBytes": -8764120,
      "heapUsedBytes": 61578312,
      "domNodes": -279,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 110.58900000000001,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1672.798000000057,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 12.496,
      "layouts": 6,
      "layoutDurationMs": 1.026,
      "taskDurationMs": 309.55,
      "heapDeltaBytes": 5062324,
      "heapUsedBytes": 75724072,
      "domNodes": 78,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.023000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1726.7500000000382,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.163999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.9259999999999999,
      "taskDurationMs": 300.90700000000004,
      "heapDeltaBytes": 5032408,
      "heapUsedBytes": 75623572,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.732000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 555.9009999999489,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 6.612,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 353.965,
      "heapDeltaBytes": 17714004,
      "heapUsedBytes": 87606760,
      "domNodes": 22,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 119.29799999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 558.8859999999158,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 6.295,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 353.768,
      "heapDeltaBytes": -8147932,
      "heapUsedBytes": 62619812,
      "domNodes": 22,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 119.44200000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2060.5150000000094,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.671999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 551.766,
      "heapDeltaBytes": -14339160,
      "heapUsedBytes": 87119336,
      "domNodes": -264,
      "jsHeapTotalBytes": -1376256,
      "scriptDurationMs": 42.548,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2027.8789999999844,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.809000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.00500000000005,
      "heapDeltaBytes": -13611868,
      "heapUsedBytes": 87981076,
      "domNodes": -264,
      "jsHeapTotalBytes": -1376256,
      "scriptDurationMs": 33.508,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2102.7820000000474,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 9.717,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1239.1999999999998,
      "heapDeltaBytes": 22312184,
      "heapUsedBytes": 88470324,
      "domNodes": -268,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 583.6940000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2109.7049999999626,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 9.366999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1270.7099999999998,
      "heapDeltaBytes": 21844912,
      "heapUsedBytes": 88186100,
      "domNodes": 6,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 600.5370000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3210.8819999999696,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 11.709999999999997,
      "layouts": 60,
      "layoutDurationMs": 13.016,
      "taskDurationMs": 1389.709,
      "heapDeltaBytes": 8161332,
      "heapUsedBytes": 75785584,
      "domNodes": 6,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 600.967,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3173.5780000000204,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.075000000000005,
      "layouts": 60,
      "layoutDurationMs": 12.246,
      "taskDurationMs": 1343.064,
      "heapDeltaBytes": 11691732,
      "heapUsedBytes": 79841624,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 584.819,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2226.11500000005,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 5.695000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1489.337,
      "heapDeltaBytes": 13626076,
      "heapUsedBytes": 81648368,
      "domNodes": -275,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 705.3090000000001,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2378.6389999999074,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 5.930999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1534.3619999999999,
      "heapDeltaBytes": 14923236,
      "heapUsedBytes": 82177084,
      "domNodes": 4,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 746.6550000000001,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.005000000041,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.724999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.91200000000003,
      "heapDeltaBytes": -15909244,
      "heapUsedBytes": 87735116,
      "domNodes": -268,
      "jsHeapTotalBytes": -1376256,
      "scriptDurationMs": 37.894000000000005,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2001.7560000000003,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 2.2259999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.827,
      "heapDeltaBytes": 22291816,
      "heapUsedBytes": 88417480,
      "domNodes": -271,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 34.489,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 546.3310000000092,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.590000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 328.083,
      "heapDeltaBytes": 14945216,
      "heapUsedBytes": 87746448,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 104.464,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 522.5780000000668,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.6869999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 320.121,
      "heapDeltaBytes": 14878652,
      "heapUsedBytes": 87702588,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 101.949,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1991.9740000000274,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.225000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 432.7610000000001,
      "heapDeltaBytes": 2691388,
      "heapUsedBytes": 75603352,
      "domNodes": -295,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.324000000000001,
      "eventListeners": -228,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1991.9290000000274,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.692000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.213,
      "heapDeltaBytes": 1233880,
      "heapUsedBytes": 73919736,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 7.140000000000002,
      "eventListeners": -228,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.5809999999574,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.33,
      "layouts": 18,
      "layoutDurationMs": 3.691,
      "taskDurationMs": 673.221,
      "heapDeltaBytes": 3234276,
      "heapUsedBytes": 76162248,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 77.61800000000001,
      "eventListeners": -226,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.6329999999161,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 25.952999999999996,
      "layouts": 18,
      "layoutDurationMs": 4.029999999999999,
      "taskDurationMs": 671.578,
      "heapDeltaBytes": 3927452,
      "heapUsedBytes": 76864540,
      "domNodes": -294,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 74.35300000000001,
      "eventListeners": -226,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 966.1070000000791,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 25.064999999999998,
      "layouts": 17,
      "layoutDurationMs": 10.866999999999997,
      "taskDurationMs": 723.1650000000001,
      "heapDeltaBytes": 21003984,
      "heapUsedBytes": 109470224,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 24.18499999999999,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 112,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8180.124999999975,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 34.038,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4725.735000000001,
      "heapDeltaBytes": 14578956,
      "heapUsedBytes": 91023388,
      "domNodes": -267,
      "jsHeapTotalBytes": -401408,
      "scriptDurationMs": 2099.24,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8185.939000000076,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 34.995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4633.611,
      "heapDeltaBytes": -12198864,
      "heapUsedBytes": 89547952,
      "domNodes": -260,
      "jsHeapTotalBytes": -102400,
      "scriptDurationMs": 2031.063,
      "eventListeners": -132,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13116.018000000055,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12312.339000000002,
      "heapDeltaBytes": -30602204,
      "heapUsedBytes": 175865328,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1024000,
      "scriptDurationMs": 216.528,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12878.669999999944,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12345.703999999998,
      "heapDeltaBytes": -57531896,
      "heapUsedBytes": 162259944,
      "domNodes": -6548,
      "jsHeapTotalBytes": -1581056,
      "scriptDurationMs": 223.232,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16049.230999999963,
      "styleRecalcs": 92,
      "styleRecalcDurationMs": 15.64600000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15484.629000000003,
      "heapDeltaBytes": -51389904,
      "heapUsedBytes": 159811020,
      "domNodes": -6548,
      "jsHeapTotalBytes": -11280384,
      "scriptDurationMs": 856.595,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 132,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16724.886000000082,
      "styleRecalcs": 125,
      "styleRecalcDurationMs": 18.062999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16172.131,
      "heapDeltaBytes": -36379900,
      "heapUsedBytes": 166809624,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1286144,
      "scriptDurationMs": 861.717,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 55,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4688.098999999966,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.615,
      "layouts": 20,
      "layoutDurationMs": 22.688999999999986,
      "taskDurationMs": 4586.0960000000005,
      "heapDeltaBytes": -29188816,
      "heapUsedBytes": 174989312,
      "domNodes": -6548,
      "jsHeapTotalBytes": 9756672,
      "scriptDurationMs": 106.01500000000001,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 75,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4682.928999999945,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 62.04199999999999,
      "layouts": 20,
      "layoutDurationMs": 23.056999999999995,
      "taskDurationMs": 4547.631000000001,
      "heapDeltaBytes": -20307996,
      "heapUsedBytes": 180142360,
      "domNodes": -6548,
      "jsHeapTotalBytes": 16752640,
      "scriptDurationMs": 90.415,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 68,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6875.770999999986,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6435.785999999998,
      "heapDeltaBytes": 13010220,
      "heapUsedBytes": 182726980,
      "domNodes": 0,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 118.27500000000002,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7156.526999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6625.891,
      "heapDeltaBytes": 10751904,
      "heapUsedBytes": 174618388,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 140.474,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 86.67300000001887,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 11.985000000000001,
      "layouts": 3,
      "layoutDurationMs": 1.0929999999999997,
      "taskDurationMs": 55.964,
      "heapDeltaBytes": 3023344,
      "heapUsedBytes": 71822652,
      "domNodes": 123,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.504,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 439.3489999999929,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 16.509000000000004,
      "layouts": 3,
      "layoutDurationMs": 1.7779999999999998,
      "taskDurationMs": 90.461,
      "heapDeltaBytes": 4897960,
      "heapUsedBytes": 73865952,
      "domNodes": 144,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.8999999999999995,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 49592 74336 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.2% 1185
src/LGraphNode.ts 69.4% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.6% 260
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                                   Coverage Diff                                    @@
##           christian-byrne/ecw-106-comfy-multi-player-workspace   #16909      +/-   ##
========================================================================================
+ Coverage                                                 80.79%   82.33%   +1.53%     
========================================================================================
  Files                                                      2475     2057     -418     
  Lines                                                    128216   120738    -7478     
  Branches                                                  34553    32726    -1827     
========================================================================================
- Hits                                                     103597    99410    -4187     
+ Misses                                                    24103    21147    -2956     
+ Partials                                                    516      181     -335     
Flag Coverage Δ
e2e 66.70% <ø> (+0.01%) ⬆️
unit 76.82% <ø> (ø)
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 424 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Shepherding tick: exact-head checks fully terminal green, head and stacked base both unchanged — nothing to rebase, nothing to fix.

Full context for agent readers

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Standalone replacement: governance recovery. Frontend relocation remains deferred.

Full context for agent readers

The replacement recovers governance tests and invariant registration into comfy-multi-player main. The duplicate frontend-workflow deletion is accounted for by the already-landed standalone restoration, not copied into the replacement. The replacement body attributes all ten captured comments across the three governance sources, retaining authors, dates and direct links.

The earlier instruction to keep this work stacked on the frontend relocation is superseded by Christian's standalone ruling. Historical checks and review-skipped notices are preserved as history, not fresh verification or approvals. The replacement passed its local tests and gates; hosted checks and actual review remain required. This source stays preserved until code, collaboration and late-comment accounting complete. No source branch or review thread is deleted or resolved by this message.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Superseded by merged standalone automation:
Comfy-Org/comfy-multi-player#182
Already closed without merge; this records the replacement.

Full context for agent readers

Christian authorized finishing the standalone recovery's source-retirement gap. GitHub now records this source as closed by christian-byrne at 2026-09-21T21:58:40Z, without merge. No rebase or retarget is needed; the old frontend relocation is no longer the destination.

Source revision: c07ff94 . The standalone restoration already delivered equivalent workflow behavior: exclude the statelessness probe from the full suite because its dedicated gate runs it separately. Replacement merge: Comfy-Org/comfy-multi-player@5891802 . Current pinned source confirms both halves:

The governance recovery explicitly accounts for this source as superseded, not a literal copy of frontend-specific workflows: Comfy-Org/comfy-multi-player#200 . Its body preserves the original authors, dates and discussion links.

Late-comment refresh covered all five issue comments, native reviews and inline comments: no new substantive feedback since the recovery receipt #16909 (comment) and no native reviews or inline findings. The older instruction to wait for frontend relocation is superseded; historical checks are not new verification. The original body, branch and all discussion remain preserved. This receipt does not close the separate tracking issue or authorize publication, deployment or product acceptance. No local checks ran.

Glossary: statelessness probe is the test for document-owned state; retirement means closing the redundant source pull request, not deleting history.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-unit Touches Agent-related unit/component tests or their support flag-exempt risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants