Repository navigation
test(agent): re-enable the keyboard-activation a11y e2e - #17132
Conversation
The test was muted by #16907 because #16903 and #16904 landed within minutes of each other and both rendered id="agent-panel-title", so the duplicate id made toHaveCount(1) fail. #16912 removed the duplicate 29 minutes later but left the fixme in place. Verified against a cloud dev server: 10/10 green, with exactly one #agent-panel-title, one complementary landmark, and the landmark resolving its accessible name to "Comfy Agent".
🎭 Playwright: ✅ 1921 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.78 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 128 kB (baseline 128 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 28.9 kB (baseline 28.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 558 kB (baseline 558 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.8 MB (baseline 16.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-07T20:57:35.587Z",
"gitSha": "9167ca10715fd97f2ccaf0eb29692759dd39aece",
"branch": "glary/reenable-agent-panel-a11y-e2e",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2081.9569999999885,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.828999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.163,
"heapDeltaBytes": -12059600,
"heapUsedBytes": 57958320,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.866,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2034.6299999999928,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.942,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.82300000000004,
"heapDeltaBytes": -2900116,
"heapUsedBytes": 67009508,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.776,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1819.3819999999619,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.462,
"layouts": 14,
"layoutDurationMs": 4.16,
"taskDurationMs": 873.3279999999999,
"heapDeltaBytes": 911760,
"heapUsedBytes": 70573296,
"domNodes": -279,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 162.955,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1942.625000000021,
"styleRecalcs": 81,
"styleRecalcDurationMs": 49.15,
"layouts": 14,
"layoutDurationMs": 4.836,
"taskDurationMs": 982.272,
"heapDeltaBytes": -13708028,
"heapUsedBytes": 56857484,
"domNodes": -275,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 172.953,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.7439999999942,
"styleRecalcs": 29,
"styleRecalcDurationMs": 16.41,
"layouts": 6,
"layoutDurationMs": 0.99,
"taskDurationMs": 391.228,
"heapDeltaBytes": 5124196,
"heapUsedBytes": 75933220,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.643999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1697.277999999983,
"styleRecalcs": 30,
"styleRecalcDurationMs": 27.971000000000004,
"layouts": 6,
"layoutDurationMs": 1.322,
"taskDurationMs": 414.49500000000006,
"heapDeltaBytes": 5104936,
"heapUsedBytes": 75926736,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.905,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 665.126999999984,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.108,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.3320000000001,
"heapDeltaBytes": 18799100,
"heapUsedBytes": 88857604,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 171.66799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 686.313000000041,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.552000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.25100000000003,
"heapDeltaBytes": -7565924,
"heapUsedBytes": 62876276,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 163.5,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2061.833999999976,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.941000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 639.192,
"heapDeltaBytes": 11489652,
"heapUsedBytes": 86835340,
"domNodes": -270,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 37.525000000000006,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.1549999999843,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.340999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 670.3090000000001,
"heapDeltaBytes": -15618432,
"heapUsedBytes": 86792224,
"domNodes": -267,
"jsHeapTotalBytes": -327680,
"scriptDurationMs": 33.675999999999995,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2441.2250000000313,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.149999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1671.678,
"heapDeltaBytes": 22627340,
"heapUsedBytes": 88297208,
"domNodes": -270,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 816.5,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2608.3509999999706,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.829,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1744.71,
"heapDeltaBytes": 21878644,
"heapUsedBytes": 88136468,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 886.5350000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3588.4829999999965,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.009,
"layouts": 60,
"layoutDurationMs": 12.091999999999999,
"taskDurationMs": 1734.9409999999998,
"heapDeltaBytes": 11762116,
"heapUsedBytes": 79970880,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 787.109,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3873.100000000022,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.155999999999999,
"layouts": 60,
"layoutDurationMs": 12.867,
"taskDurationMs": 1850.247,
"heapDeltaBytes": 10227804,
"heapUsedBytes": 76601484,
"domNodes": -280,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 830.423,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3168.8629999999876,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.550999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2049.359,
"heapDeltaBytes": -1911132,
"heapUsedBytes": 78678304,
"domNodes": 6,
"jsHeapTotalBytes": 5033984,
"scriptDurationMs": 994.0429999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3102.3440000000164,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.195999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1971.5369999999998,
"heapDeltaBytes": 21687100,
"heapUsedBytes": 89908032,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 966.6439999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2007.7349999999683,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.188000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.562,
"heapDeltaBytes": 22248064,
"heapUsedBytes": 87747340,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.58899999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2031.4050000000634,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.3390000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.29,
"heapDeltaBytes": 10605116,
"heapUsedBytes": 87399588,
"domNodes": -272,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 38.09399999999999,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.6139999999782,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.364999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.206,
"heapDeltaBytes": 14878072,
"heapUsedBytes": 87733332,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 147.20899999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 642.1320000000605,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.130999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.769,
"heapDeltaBytes": 14959908,
"heapUsedBytes": 86907272,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 150.28900000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.2450000000022,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.431000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.294,
"heapDeltaBytes": -12638644,
"heapUsedBytes": 60314860,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.089000000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.8889999999874,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.834000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.782,
"heapDeltaBytes": -8018452,
"heapUsedBytes": 63910928,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.898,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.0300000000138,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.753,
"layouts": 18,
"layoutDurationMs": 5.617000000000001,
"taskDurationMs": 825.0310000000001,
"heapDeltaBytes": -11990388,
"heapUsedBytes": 60871144,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 109.46000000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1793.4169999999767,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.684,
"layouts": 18,
"layoutDurationMs": 5.851,
"taskDurationMs": 926.0939999999999,
"heapDeltaBytes": 1449736,
"heapUsedBytes": 73701596,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 124.30499999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1405.6929999999852,
"styleRecalcs": 21,
"styleRecalcDurationMs": 33.120999999999995,
"layouts": 17,
"layoutDurationMs": 16.184000000000005,
"taskDurationMs": 977.192,
"heapDeltaBytes": 21054412,
"heapUsedBytes": 109263320,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 31.253999999999998,
"eventListeners": 2385,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8641.60099999998,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.056999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5962.383,
"heapDeltaBytes": -9012412,
"heapUsedBytes": 93081652,
"domNodes": -268,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 2723.182,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9590.952000000016,
"styleRecalcs": 248,
"styleRecalcDurationMs": 40.480000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6394.253,
"heapDeltaBytes": -8498724,
"heapUsedBytes": 93575436,
"domNodes": -267,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 2909.761,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18009.680000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17183.903,
"heapDeltaBytes": -30565272,
"heapUsedBytes": 180068300,
"domNodes": -6548,
"jsHeapTotalBytes": 1658880,
"scriptDurationMs": 298.85200000000003,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17627.30900000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17112.078999999998,
"heapDeltaBytes": -37592224,
"heapUsedBytes": 179432428,
"domNodes": -6548,
"jsHeapTotalBytes": 5709824,
"scriptDurationMs": 306.275,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21571.974000000013,
"styleRecalcs": 175,
"styleRecalcDurationMs": 20.010000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21215.882999999998,
"heapDeltaBytes": -7438872,
"heapUsedBytes": 190930340,
"domNodes": -6548,
"jsHeapTotalBytes": 1753088,
"scriptDurationMs": 931.994,
"eventListeners": -7469,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22025.623999999993,
"styleRecalcs": 167,
"styleRecalcDurationMs": 22.10099999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21745.06,
"heapDeltaBytes": -17335852,
"heapUsedBytes": 190211680,
"domNodes": -6548,
"jsHeapTotalBytes": -126976,
"scriptDurationMs": 977.26,
"eventListeners": -7471,
"totalBlockingTimeMs": 55,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6506.143000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.01999999999998,
"layouts": 20,
"layoutDurationMs": 26.118000000000002,
"taskDurationMs": 6400.415000000001,
"heapDeltaBytes": -28590540,
"heapUsedBytes": 180767128,
"domNodes": -6548,
"jsHeapTotalBytes": 10809344,
"scriptDurationMs": 131.131,
"eventListeners": -7471,
"totalBlockingTimeMs": 458,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6282.048000000032,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.366,
"layouts": 20,
"layoutDurationMs": 23.991,
"taskDurationMs": 6183.486999999999,
"heapDeltaBytes": -15609884,
"heapUsedBytes": 190102748,
"domNodes": -6548,
"jsHeapTotalBytes": 15134720,
"scriptDurationMs": 115.573,
"eventListeners": -7471,
"totalBlockingTimeMs": 385,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9110.571999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8680.058,
"heapDeltaBytes": 18227032,
"heapUsedBytes": 175899148,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 152.00099999999995,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9027.97899999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8661.383,
"heapDeltaBytes": 15361356,
"heapUsedBytes": 176161236,
"domNodes": -1,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 145.29999999999998,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 139.69000000003007,
"styleRecalcs": 9,
"styleRecalcDurationMs": 20.198,
"layouts": 4,
"layoutDurationMs": 2.306,
"taskDurationMs": 98.07199999999999,
"heapDeltaBytes": 3318516,
"heapUsedBytes": 71435460,
"domNodes": 148,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.179,
"eventListeners": 38,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 103.56600000000071,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.433,
"layouts": 2,
"layoutDurationMs": 1.51,
"taskDurationMs": 75.565,
"heapDeltaBytes": 3040684,
"heapUsedBytes": 71817632,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.217000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe pull request enables the keyboard activation and complementary landmark lifecycle test by changing it from ChangesAgent panel lifecycle
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change restores automated coverage for keyboard activation and landmark accessibility of the Agent panel without changing product behavior. It is ready to merge. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The changed-file list is available and shows only ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17132 +/- ##
==========================================
+ Coverage 81.42% 82.93% +1.50%
==========================================
Files 2480 2050 -430
Lines 127254 119584 -7670
Branches 32816 30954 -1862
==========================================
- Hits 103620 99176 -4444
+ Misses 23120 20228 -2892
+ Partials 514 180 -334
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
No changes made — the review produced no actionable comments, so there was nothing to act on. Recording the CI result instead, since it settles the one open question in the PR description. All 92 checks complete: 74 success, 18 skipped, 0 failures.
The one that matters is Bundle diff is 0 B across raw/gzip/brotli, as expected for a test-only change. Leaving this as a draft for a human to flip — the two optional follow-ups noted in the description (a component-level guard for the duplicate-id class of bug, and focus-restoration assertions) are deliberately out of scope here and want their own PRs. |
|
Thanks for the review. No changes made — the approval carried no inline comments or review body, so there was nothing to act on. Status: approved by @christian-byrne and CodeRabbit, One thing blocking merge that I can't fix from here: this PR is still marked draft. Could you flip it to ready-for-review (or just merge it)? I opened it as a draft per my own workflow default, and that predates the two approvals. Worth flagging since you authored both ends of this one: the mute in #16907 was correct at the time — the duplicate |
…rs (Comfy-Org#19927) *PR Created by the Glary-Bot Agent* --- Follow-up to an audit of disabled Playwright/Vitest tests. This lands **only** the low-risk housekeeping subset: annotations whose factual claims have gone stale or were wrong. No marker is added, removed or re-scoped, and no product code is touched. The only non-comment line in the whole diff is one test title string: ``` git diff main -U0 | grep -E '^[+-]' | grep -vE '^(\+\+\+|---)' | grep -vE '^[+-]\s*//' - it.fails('excludes a failed-then-actually-completed task from activeDownloads so it is never reconciled (PM-1302)', () => { + it.fails('excludes a failed-then-actually-completed task from activeDownloads (PM-1302)', () => { ``` ## What changed **`src/workbench/extensions/agent/AgentPanelRoot.test.ts`** — described `agentPanelLifecycle.spec.ts` as *"still test.fixme pending FE Comfy-Org#16919"*. Comfy-Org#16919 was **closed unmerged**; Comfy-Org#17132 is what re-enabled the spec (`4a5b183249`), and it carries no `fixme` today. **`browser_tests/tests/agent/agentNestedOutputSentPreview.spec.ts`** — deferred its decision to *"open owner PRs (Comfy-Org#16985, Comfy-Org#17767)"*. Both merged (2026-09-22 / 09-23). PM-1158 then closed on a partial fix (Comfy-Org#18104, image path only) and PM-1157 on this repro, so the **non-image path this test pins is unowned**. The `test.fail()` stays. **`src/stores/assetDownloadStore.test.ts`** — labelled PM-1302 / PM-1309 an `OPEN DESIGN QUESTION`; both are `Done`. Worse, the block contradicted itself: its header says polling *"re-checks `failed` downloads too"*, while the inner comment said `pollStaleDownloads()` *"only walks activeDownloads"* so the task is *"never reconciled"*. Both are false — `pollStaleDownloads()` walks `recheckableDownloads`, which includes `failed` (`assetDownloadStore.ts:23-27, 206-208`), and the passing test at `:350` reconciles a failed download through polling. The `it.fails` marker stays (the gap it pins is still a live product decision); only the false consequence is dropped from its title. ## Why nothing else from the audit is here The audit found 82 marker sites. Everything else was checked and deliberately left alone: - **All 20 `test.fail()` sites are CI-enforced.** Each lives in a spec tagged into a running project (`@cloud` → `cloud`, `@smoke`/`@vue-nodes` → `chromium`). Playwright fails a `test.fail()` that unexpectedly passes, so **main being green proves none of them are stale**. Removing any would be unjustified. - **FE-2040 is `In Review`** with Comfy-Org#17113/Comfy-Org#17116/Comfy-Org#17122/Comfy-Org#17308 unmerged → the four `pointerGestures`/`selection` markers stay. Issues Comfy-Org#18414 and Comfy-Org#7454 are open → those markers stay. - **7 of the 20 `test.fail()` are deliberate fixture self-tests** (`networkIsolation`, `liveCloudBillingRouting`) that assert the guard fixture fails at teardown. Correct as written. I considered adding clarifying comments and dropped it — `AGENTS.md` sets a high bar against non-essential comments. - **The 35 `test.fixme()`** are bodiless placeholder rows in `crossOriginSession/**`, `testIgnore`d from the default config and gated by `expectStepsWritten`. Not removable without deleting the QA plan's tracking rows. - **The 27 conditional `skip`/`skipIf`/`ctx.skip`** are data-, shard- and env-availability guards (one was added by Comfy-Org#15150 precisely so the suite survives event data rolling over). Verified actively skipping: `LGraph.roundTrip.test.ts` reports 5 skips against real fixture shapes. ## Two findings worth a look, not fixed here 1. **PM-1157 / PM-1158 are `Done`, but the defect they describe is still pinned failing.** PM-1157 was closed by Comfy-Org#18201 — the PR that *added the repro*. PM-1158 got a partial fix (Comfy-Org#18104) covering the image path only. The non-image `preview_url` path has no open owner. cc @christian-byrne 2. **The audit's own marker grep missed `it.fails`** (`.failing(` was matched, `.fails(` was not) — 13 sites across 7 files, so the real total is 95, not 82. `assetDownloadStore.test.ts` is the only one of the 13 carrying an external ticket reference; the other 12 reference nothing that can go stale. ## Verification - `pnpm exec vitest run src/stores/assetDownloadStore.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts` → **408 passed, 1 expected fail** (the `it.fails` still failing as designed), run in an interactive tmux session. - Pre-commit hook: `oxfmt`, type-aware `oxlint`, `eslint`, `typecheck:app`, `typecheck:browser` — all green. `typecheck:browser` covers the Playwright spec. - Three `deep-reviewer` rounds; the first caught a genuine error in my own first draft (I had misread `closed_at` as merged and written `Comfy-Org#16919` where `Comfy-Org#17132` belongs). Final verdict PASS. - **Not possible in this sandbox:** no screenshots — the change has no UI surface, and Playwright browsers are not installed (`~/.cache/ms-playwright` holds only ffmpeg) with no torch for a ComfyUI backend, so `agentNestedOutputSentPreview.spec.ts` could not be executed. It is comment-only and covered by `typecheck:browser`. Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
PR Created by the Glary-Bot Agent
Summary
Re-enables the Agent panel keyboard-accessibility e2e test, which was muted five days ago to unblock CI and left muted after the bug it caught was fixed 29 minutes later.
Changes
test.fixme(→test(onbrowser_tests/tests/agent/agentPanelLifecycle.spec.ts:68. Byte-exact inverse of the disabling commit in Temporarily disable agent keyboard accessibility e2e test #16907. No assertion touched.Review Focus
The mute was collateral from two PRs racing on 2026-09-03:
id="agent-panel-title"→ duplicate DOM idtoHaveCount(1)was correctly failing)So the test did its job: it caught a real a11y regression (a duplicate DOM id that left the
role="complementary"landmark'saria-labelledbyambiguous). #16912 is an ancestor of this branch, so the cause is gone. Onmainthe id now has exactly two renderers —PanelHeader.vue:36(success path) and theerrorComponentinDockedAgentPanel.vue:48— which are mutually exclusive.Verified by running it, not just reading it. Against a
pnpm dev:cloudserver on thecloudproject: 10/10 green on--repeat-each=10, and the full spec goes from 4 passed / 1 skipped to 5 passed. Measured DOM state at the moment of assertion:{ "agentPanelTitleIds": 1, "complementaryLandmarks": 1, "landmarkRole": "complementary", "landmarkLabelledBy": "agent-panel-title", "accessibleName": "Comfy Agent" }Two notes for the reviewer:
playwright-tests (cloud)run as the receipt rather than my local runs.preserves the stored preference while the flag is off, fails identically on unmodifiedmain. It is a dev-server artifact:agentPanel.ts:92forcesenabled = truewhenimport.meta.env.MODE === 'development', so "flag off" is not reproducible outside a built bundle. Unrelated to this change.Possible follow-ups, deliberately not done here: a component-level guard asserting exactly one
#agent-panel-title(cheaper than a single unsharded@cloude2e as the only net for that class of bug — branches doing this already exist), and focus-restoration assertions if this test is meant to be the panel's full keyboard-a11y guard.Screenshots
Panel opened via
Enteron the trigger, header title rendering.Screenshots