Repository navigation
test(agent): use data-testid for the agent panel title heading - #16921
Conversation
📦 Bundle: 9.4 MB gzip 🟢 -419 BDetailsSummary
Category Glance App Entry Points — 5.3 kB (baseline 5.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.15 MB (baseline 2.15 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 11 added / 11 removed / 7 unchanged Panels & Settings — 669 kB (baseline 669 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 5 added / 5 removed / 24 unchanged User & Accounts — 61.1 kB (baseline 61.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 8 unchanged Editors & Dialogs — 340 kB (baseline 340 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed / 4 unchanged UI Components — 211 kB (baseline 211 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 17 unchanged Data & Services — 1.36 MB (baseline 1.36 MB) • 🟢 -1.72 kBStores, services, APIs, and repositories
Status: 11 added / 11 removed / 13 unchanged Utilities & Hooks — 2.29 MB (baseline 2.29 MB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 24 added / 24 removed / 38 unchanged Vendor & Third-Party — 14.3 MB (baseline 14.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 19 MB (baseline 19 MB) • ⚪ 0 BBundles that do not match a named category
Status: 77 added / 77 removed / 274 unchanged ⚡ Performance
🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2262 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 38ef604bd5fc04076b090f859b398c9d316ed883
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16921 +/- ##
==========================================
+ Coverage 86.08% 86.87% +0.79%
==========================================
Files 3638 2588 -1050
Lines 173746 145533 -28213
Branches 47902 37810 -10092
==========================================
- Hits 149565 126439 -23126
+ Misses 22172 18708 -3464
+ Partials 2009 386 -1623
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1055 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
pr-hygiene sweep, conflict-risk lens: this PR's file set is a strict subset of #16873, and the two edit the same region of So if #16873 lands after this one it re-introduces the role query this PR is deliberately moving away from, and |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 2 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
2604efc to
d574df2
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
I confirmed that the current head keeps the semantic heading and accessible-name query while checking both the stable test selector and the id used by aria-labelledby. This addresses the earlier accessibility-coverage concern, and the component and test use the same data-testid value.
I ran the focused unit test (6/6), pnpm typecheck, changed-file ESLint, changed-file format checking, pnpm knip, and the diff-scoped Fallow audit. All passed. The current head also has 77 successful checks, 12 expected skips, and no pending or failed checks.
|
Merged |
|
Merged |
da2d82c to
f856aed
Compare
Rebased onto current main. The branch's four commits were replaced by this one because the `PanelHeader.vue` hunk conflicted against main's rewrite of that template; the net diff is byte-identical to the pre-rebase branch (2 files, +4/-3). Proved non-vacuous on current main by mutation rather than by a green run alone: with the `data-testid` deleted from PanelHeader.vue the suite reports `Tests 1 failed | 6 passed`, and with it restored `7 passed`.
|
✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged. |
f856aed to
6ee6577
Compare
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 6ee6577 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
Back-references #16903 and Christian's unresolved review thread: #16903 (comment) ("nit: can use standardized data-test-id").
What
PanelHeader.vue: adds the repository-standarddata-testid="agent-panel-title"to the panel title<h1>(the repo usesdata-testidin 354 files anddata-test-idin none), while retainingid="agent-panel-title"becauseDockedAgentPanel.vuelabels the dock landmark viaaria-labelledby="agent-panel-title".PanelHeader.test.ts: the focused heading coverage now looks the element up through the standardscreen.getByTestId('agent-panel-title')selector and keeps assertingid="agent-panel-title"so the landmark reference stays covered.Evidence
pnpm exec vitest run src/workbench/extensions/agent/components/agent/PanelHeader.test.ts→ 6/6 passed at exact head2604efccddcf1025e22068202e0a36a743bd88b8on FE maina39b1ce9fa.data-testidattribute stashed, exactly the updated heading assertion fails (1 failed | 5 passed); restoring it returns 6/6 green.oxfmt --check(2 files correct format),oxlint(0 warnings, 0 errors),eslint(exit 0),vue-tsc --noEmit(exit 0), pre-pushknip --cacheclean.gh pr list --state allsearches foragent-panel-title,test-id agent, anddata-testid agent panelfound no open carrier for this request (test(agent): re-enable panel keyboard lifecycle coverage #16919 is unrelated keyboard-lifecycle coverage);git ls-remote --headshas no competing testid branch.