Repository navigation
fix(agent): scope operation results to their workflow - #16901
christian-byrne merged 4 commits into
Conversation
|
@christian-byrne is attempting to deploy a commit to the comfy product design Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
Comment |
🎭 Playwright: ✅ 1908 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.69 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 559 kB (baseline 559 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-04T06:51:47.001Z",
"gitSha": "31ed1a7061f33e3a5274798aaa7a1fc4a3f7cccf",
"branch": "fix-workflow-aware-op-settlement",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2102.7349999999387,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.129999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.1620000000001,
"heapDeltaBytes": -12141096,
"heapUsedBytes": 57816768,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 13.895000000000005,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2026.1419999999362,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.819000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.34,
"heapDeltaBytes": -12051344,
"heapUsedBytes": 57840636,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.951,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1939.5510000000513,
"styleRecalcs": 78,
"styleRecalcDurationMs": 45.728,
"layouts": 14,
"layoutDurationMs": 5.386,
"taskDurationMs": 926.5320000000002,
"heapDeltaBytes": -8714740,
"heapUsedBytes": 61795524,
"domNodes": -280,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 155.758,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1860.6439999999793,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.798,
"layouts": 14,
"layoutDurationMs": 4.72,
"taskDurationMs": 900.46,
"heapDeltaBytes": -7687000,
"heapUsedBytes": 62623260,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 148.621,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.0820000000576,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.088000000000005,
"layouts": 6,
"layoutDurationMs": 1.3300000000000003,
"taskDurationMs": 364.522,
"heapDeltaBytes": 5102480,
"heapUsedBytes": 75138076,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.982,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.732000000051,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.991,
"layouts": 6,
"layoutDurationMs": 1.1779999999999997,
"taskDurationMs": 378.50899999999996,
"heapDeltaBytes": 5087452,
"heapUsedBytes": 75613820,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 12.311000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 699.7629999999617,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.639999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.16400000000004,
"heapDeltaBytes": -8157008,
"heapUsedBytes": 62538732,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 159.175,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 737.4119999999493,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.278,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.85900000000004,
"heapDeltaBytes": -7791868,
"heapUsedBytes": 62752356,
"domNodes": 16,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 160.53599999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2064.6330000000717,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.806999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 630.8109999999999,
"heapDeltaBytes": 10902804,
"heapUsedBytes": 86910200,
"domNodes": -270,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 39.964,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2078.7520000000086,
"styleRecalcs": 4,
"styleRecalcDurationMs": 5.864000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 664.0330000000001,
"heapDeltaBytes": -14633064,
"heapUsedBytes": 87067908,
"domNodes": -267,
"jsHeapTotalBytes": -65536,
"scriptDurationMs": 37.346999999999994,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2280.069000000026,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.409,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1607.1879999999999,
"heapDeltaBytes": 17763892,
"heapUsedBytes": 84436124,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 787.2520000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2207.8089999999975,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.397000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1578.4349999999997,
"heapDeltaBytes": 22070724,
"heapUsedBytes": 87753936,
"domNodes": -275,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 765.196,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3563.89200000001,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.259000000000002,
"layouts": 60,
"layoutDurationMs": 13.707999999999998,
"taskDurationMs": 1705.8270000000002,
"heapDeltaBytes": 8477612,
"heapUsedBytes": 76401764,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 773.1519999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3557.2259999999005,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.310999999999998,
"layouts": 60,
"layoutDurationMs": 13.678999999999998,
"taskDurationMs": 1721.43,
"heapDeltaBytes": 12044996,
"heapUsedBytes": 80207828,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 772.5540000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3120.64799999996,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.989000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1993.4940000000001,
"heapDeltaBytes": -1618144,
"heapUsedBytes": 69754016,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 1014.076,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3126.2380000000576,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.812000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1925.479,
"heapDeltaBytes": 21046360,
"heapUsedBytes": 89074724,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 955.0369999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.7930000000788,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.746,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.136,
"heapDeltaBytes": -15768080,
"heapUsedBytes": 87440208,
"domNodes": -268,
"jsHeapTotalBytes": -589824,
"scriptDurationMs": 36.174,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2004.4829999999365,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.0379999999999,
"heapDeltaBytes": 21129928,
"heapUsedBytes": 86671564,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.311,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.3060000000132,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.863000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.759,
"heapDeltaBytes": 14903548,
"heapUsedBytes": 87751960,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 141.33300000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 652.9780000000756,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.057999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.685,
"heapDeltaBytes": 15220564,
"heapUsedBytes": 87752560,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 149.559,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2011.3860000000159,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.122999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.43300000000005,
"heapDeltaBytes": -9280688,
"heapUsedBytes": 63163596,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.702000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.1059999999707,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.142000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.002,
"heapDeltaBytes": -7480840,
"heapUsedBytes": 65303312,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.745999999999997,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.6349999999838,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.45700000000001,
"layouts": 18,
"layoutDurationMs": 5.603999999999999,
"taskDurationMs": 848.4690000000002,
"heapDeltaBytes": -12459916,
"heapUsedBytes": 60332640,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 111.211,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.4880000000558,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.86200000000001,
"layouts": 18,
"layoutDurationMs": 5.5600000000000005,
"taskDurationMs": 824.181,
"heapDeltaBytes": -11769656,
"heapUsedBytes": 61195284,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 104.709,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.708000000046,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.32699999999999,
"layouts": 14,
"layoutDurationMs": 14.284999999999995,
"taskDurationMs": 923.2389999999997,
"heapDeltaBytes": 292532,
"heapUsedBytes": 97543280,
"domNodes": 13751,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 32.191,
"eventListeners": 2387,
"totalBlockingTimeMs": 122,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8707.646000000068,
"styleRecalcs": 246,
"styleRecalcDurationMs": 41.058,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5917.295,
"heapDeltaBytes": 28050424,
"heapUsedBytes": 93317040,
"domNodes": -269,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2717.378,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8409.986000000117,
"styleRecalcs": 248,
"styleRecalcDurationMs": 42.955999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5974.525,
"heapDeltaBytes": 13151420,
"heapUsedBytes": 89271448,
"domNodes": -267,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 2693.2580000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18889.70500000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18518.587,
"heapDeltaBytes": -26333200,
"heapUsedBytes": 177052604,
"domNodes": -6548,
"jsHeapTotalBytes": 3936256,
"scriptDurationMs": 318.83900000000006,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18465.198999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17893.063000000002,
"heapDeltaBytes": -33077920,
"heapUsedBytes": 176905536,
"domNodes": -6548,
"jsHeapTotalBytes": -2785280,
"scriptDurationMs": 311.422,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23675.827000000027,
"styleRecalcs": 175,
"styleRecalcDurationMs": 25.14000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23548.288000000004,
"heapDeltaBytes": -12633488,
"heapUsedBytes": 191006216,
"domNodes": -6548,
"jsHeapTotalBytes": 950272,
"scriptDurationMs": 950.681,
"eventListeners": -7467,
"totalBlockingTimeMs": 112,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 23896.016000000145,
"styleRecalcs": 177,
"styleRecalcDurationMs": 25.61000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23576.331,
"heapDeltaBytes": -12936456,
"heapUsedBytes": 190526480,
"domNodes": -6548,
"jsHeapTotalBytes": 720896,
"scriptDurationMs": 975.866,
"eventListeners": -7467,
"totalBlockingTimeMs": 182,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6728.926000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.97199999999998,
"layouts": 20,
"layoutDurationMs": 25.304999999999993,
"taskDurationMs": 6652.782,
"heapDeltaBytes": -22030052,
"heapUsedBytes": 182143300,
"domNodes": -6548,
"jsHeapTotalBytes": 12943360,
"scriptDurationMs": 131.765,
"eventListeners": -7471,
"totalBlockingTimeMs": 508,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6577.590999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.14100000000002,
"layouts": 20,
"layoutDurationMs": 25.799000000000003,
"taskDurationMs": 6485.178999999999,
"heapDeltaBytes": -17618304,
"heapUsedBytes": 185757608,
"domNodes": -6548,
"jsHeapTotalBytes": 18354176,
"scriptDurationMs": 131.913,
"eventListeners": -7471,
"totalBlockingTimeMs": 404,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9142.657999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8906.508,
"heapDeltaBytes": 8213480,
"heapUsedBytes": 176442692,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 151.15500000000003,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9284.560000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8988.576000000003,
"heapDeltaBytes": 3744268,
"heapUsedBytes": 176676420,
"domNodes": 0,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 150.73500000000007,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 449.0080000000489,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.533999999999995,
"layouts": 3,
"layoutDurationMs": 1.0079999999999998,
"taskDurationMs": 105.162,
"heapDeltaBytes": 4807456,
"heapUsedBytes": 73556844,
"domNodes": 120,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.903,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 104.00000000004184,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.339999999999998,
"layouts": 2,
"layoutDurationMs": 0.6769999999999998,
"taskDurationMs": 72.488,
"heapDeltaBytes": 3024984,
"heapUsedBytes": 71954396,
"domNodes": 108,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.941000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16901 +/- ##
==========================================
+ Coverage 81.16% 82.74% +1.58%
==========================================
Files 2460 2044 -416
Lines 126662 119279 -7383
Branches 31944 32004 +60
==========================================
- Hits 102801 98702 -4099
+ Misses 23345 20396 -2949
+ Partials 516 181 -335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 446 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Lifecycle refresh is green at the exact PR head; the PR remains open for human review.
Full context for agent readersThe branch was nine commits behind when checked. It now contains merge commit Fresh local evidence on Node 25:
Hosted evidence at the same exact head:
The PR remains open and mergeable but unapproved, with one unchanged assignee and no review threads. No reviewer, teammate, or bot was contacted, and no frontend merge was attempted. |
|
Cross-PR lifecycle QA is green.
Full context for agent readersI combined this PR's two functional commits with #16878 head Verification:
Result: 4 files and 211 tests passed. Combined |
christian-byrne
left a comment
There was a problem hiding this comment.
Scoping doc_ops_result to the in-flight batch's workflow is the right call and the parser already guarantees workflow_id on every frame, so the sender-side guard is sound. One issue with how the early return interacts with the stale-credit accounting, plus a coverage suggestion; both are things I can fix on the branch.
Verified against head 9d16828: parseServerDocFrame rejects any frame without a string workflow_id, so detail.workflowId is always populated on the real path; the ?: only serves the sender boundary. Ran opSender.test.ts, crossWorkflowPending.test.ts and useAgentCrdtFollower.test.ts at head (74 passed) and reproduced the credit leak below with a probe test that passes on main and fails on this branch.
Not blocking, pre-existing: the identified-mismatch return (if (!identified.some(...)) return) also leaves stale credits outstanding when an unacknowledged batch's late result arrives identified while a new batch is in flight. Same shape as the issue below but not introduced here, so I left it alone.
Full context for agent readers
Review lane: HPS recurring review thread. Scope of the review: the three source hunks and two test hunks in this PR, cross-checked against docFrameClient.ts (parseServerDocFrame, DocOpsResult) and the stale-credit design in opSender.ts (staleAnonymousBudget, comments at lines 101-107 and 180-182, and the existing test "idle late results drain the stale credits so a fresh batch can settle anonymously").
Repro of the issue: batch 1 on wf-1 goes silent twice and settles unacknowledged (credits = 2). Bind moves to wf-2, batch 2 goes out. Two late wf-1 results arrive carrying workflowId: 'wf-1'. On main they are anonymous at the sender and each drains one credit; on this branch the new guard returns before the drain, credits stay at 2, and wf-2's own anonymous failure is then swallowed twice. Batch 2 rides both 10 s windows, settles unacknowledged although the host answered it, and credits go back to 2, so the leak repeats for the next batch on that workflow.
Fix I will push: fold the workflow-mismatch case into the same branch as the no-in-flight case so both drain a credit before returning, and add a sender test for the sequence above.
|
Review posted at 9d16828: one issue (the new workflow-mismatch return skipped the stale-credit drain), one coverage suggestion. Both fixed in 7bb2aea, pushed to this branch; own threads resolved. CI on 7bb2aea is being monitored and the outcome will follow in a comment. Full context for agent readersIssue: after a batch settles Fix in 7bb2aea: Local verification at 7bb2aea: Left as-is: the identified-mismatch return ( |
|
CI on 7bb2aea is green: 69 success, 18 skipped, 0 failures, run settled at 06:58Z. No fix loop iterations were needed. Full context for agent readersCheck-runs for head |
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Read at 7bb2aea: the workflow-mismatch case now folds into the not-in-flight branch and drains its credit before returning (opSender.ts:179-189), with the sender test covering it, and the cross-workflow test is renamed to the behaviour it now guards. Nothing to add.
|
Adjudication of the deferred stale-credit concern from review 5109912991: valid. Fixed in follow-up PR 17624: drain stale credit on identified-mismatch results. Cross-workflow drain from Full context for agent readersTrace on
Disposition: the concern in the review is a real defect, not addressed by Fix in PR 17624, head |
Cross-workflow anonymous operation results are ignored. The active workflow still accepts its own anonymous result. Focused CRDT tests and typecheck are green. <details><summary>Full context for agent readers</summary> A late `doc_ops_result` carries its source workflow ID, but the follower adapter previously stripped it before passing the result to `createOpSender`. An anonymous result from workflow A could therefore acknowledge workflow B's in-flight batch. This change forwards `workflowId` through `OpsResultView` and drops an explicitly mismatched result before operation-ID or anonymous settlement. Results without a workflow ID retain the existing fallback behavior. Regression coverage includes the sender boundary and the full A-to-B workflow switch path. Source review: #16655 (comment) Verification: - `pnpm test:unit src/workbench/extensions/agent/crdt/opSender.test.ts src/workbench/extensions/agent/crdt/crossWorkflowPending.test.ts` — 28 passed - `pnpm typecheck` — passed - scoped ESLint and oxfmt — passed - pre-push Knip — passed </details> --------- Co-authored-by: Christian Byrne <christian-byrne@users.noreply.github.com> (cherry picked from commit 2c8f128)
Cross-workflow anonymous operation results are ignored. The active workflow still accepts its own anonymous result. Focused CRDT tests and typecheck are green. <details><summary>Full context for agent readers</summary> A late `doc_ops_result` carries its source workflow ID, but the follower adapter previously stripped it before passing the result to `createOpSender`. An anonymous result from workflow A could therefore acknowledge workflow B's in-flight batch. This change forwards `workflowId` through `OpsResultView` and drops an explicitly mismatched result before operation-ID or anonymous settlement. Results without a workflow ID retain the existing fallback behavior. Regression coverage includes the sender boundary and the full A-to-B workflow switch path. Source review: #16655 (comment) Verification: - `pnpm test:unit src/workbench/extensions/agent/crdt/opSender.test.ts src/workbench/extensions/agent/crdt/crossWorkflowPending.test.ts` — 28 passed - `pnpm typecheck` — passed - scoped ESLint and oxfmt — passed - pre-push Knip — passed </details> --------- Co-authored-by: Christian Byrne <christian-byrne@users.noreply.github.com> (cherry picked from commit 2c8f128)
Cross-workflow anonymous operation results are ignored.
The active workflow still accepts its own anonymous result.
Focused CRDT tests and typecheck are green.
Full context for agent readers
A late
doc_ops_resultcarries its source workflow ID, but the follower adapter previously stripped it before passing the result tocreateOpSender. An anonymous result from workflow A could therefore acknowledge workflow B's in-flight batch.This change forwards
workflowIdthroughOpsResultViewand drops an explicitly mismatched result before operation-ID or anonymous settlement. Results without a workflow ID retain the existing fallback behavior.Regression coverage includes the sender boundary and the full A-to-B workflow switch path.
Source review: #16655 (comment)
Verification:
pnpm test:unit src/workbench/extensions/agent/crdt/opSender.test.ts src/workbench/extensions/agent/crdt/crossWorkflowPending.test.ts— 28 passedpnpm typecheck— passed