Repository navigation
test(agent): cover workflow-tab active-identity contract from slice 04 - #16873
christian-byrne wants to merge 3 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughFour workflow-tab browser tests are enabled. They check active-tab selection and identity, closing the active workflow, and retaining the active workflow through reload. ChangesWorkflow tab contract checks
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The workflow-tab tests can proceed through normal checks; no additional confirmed issue is established here. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎭 Playwright: ✅ 2138 passed, 0 failed · 1 flaky📊 Browser Reports
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T08:26:54.772Z",
"gitSha": "31c2d3c8241dda43cd04248ec4271f860ceff959",
"branch": "salvage/workflow-tab-contract-slice04",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.625999999983,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.475,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.3310000000001,
"heapDeltaBytes": 5195836,
"heapUsedBytes": 67248220,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.755999999999997,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2004.5050000001083,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.465,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.346,
"heapDeltaBytes": 6773776,
"heapUsedBytes": 69173492,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 13.691000000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1840.7509999999547,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.772000000000002,
"layouts": 12,
"layoutDurationMs": 4.444,
"taskDurationMs": 854.5500000000001,
"heapDeltaBytes": 14945032,
"heapUsedBytes": 77209420,
"domNodes": -228,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 174.28099999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.5690000000632,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.267,
"layouts": 12,
"layoutDurationMs": 4.6,
"taskDurationMs": 849.7590000000001,
"heapDeltaBytes": 6818392,
"heapUsedBytes": 69225828,
"domNodes": -228,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 174.39400000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1718.9200000000255,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.729999999999999,
"layouts": 6,
"layoutDurationMs": 1.247,
"taskDurationMs": 379.93,
"heapDeltaBytes": 2174252,
"heapUsedBytes": 64341148,
"domNodes": 53,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 16.376,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.0220000001518,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.968,
"layouts": 6,
"layoutDurationMs": 1.1660000000000001,
"taskDurationMs": 326.024,
"heapDeltaBytes": 2045340,
"heapUsedBytes": 63571780,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.879999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 646.427000000017,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.953,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.48699999999997,
"heapDeltaBytes": 18009804,
"heapUsedBytes": 80478144,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 175.582,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 712.6679999998942,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1319999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.96500000000003,
"heapDeltaBytes": 18736396,
"heapUsedBytes": 80982320,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 162.82,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1168.8259999999673,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 836.27,
"heapDeltaBytes": 31312732,
"heapUsedBytes": 100031920,
"domNodes": 0,
"jsHeapTotalBytes": 17985536,
"scriptDurationMs": 73.39000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 561,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1255.971000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 907.6370000000001,
"heapDeltaBytes": -13508492,
"heapUsedBytes": 72677604,
"domNodes": -259,
"jsHeapTotalBytes": 19529728,
"scriptDurationMs": 73.368,
"eventListeners": -185,
"totalBlockingTimeMs": 582,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.0560000000387,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.0049999999998,
"heapDeltaBytes": 15803760,
"heapUsedBytes": 92415592,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.221,
"eventListeners": 0,
"totalBlockingTimeMs": 244,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.0690000000432,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.0370000000005,
"heapDeltaBytes": 14450028,
"heapUsedBytes": 90035568,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 178.985,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11000.900999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10027.073,
"heapDeltaBytes": -10539148,
"heapUsedBytes": 72154492,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8348.664,
"eventListeners": 0,
"totalBlockingTimeMs": 1333,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12057.569999999942,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11046.362000000001,
"heapDeltaBytes": 4404180,
"heapUsedBytes": 86872420,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 9223.556999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1983,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10677.918999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9707.304,
"heapDeltaBytes": -10304256,
"heapUsedBytes": 71988076,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8099.396000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1232,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11384.339000000182,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10311.091,
"heapDeltaBytes": 17171968,
"heapUsedBytes": 94421488,
"domNodes": -228,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 8506.668,
"eventListeners": -164,
"totalBlockingTimeMs": 1493,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2055.4989999999407,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.208,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 643.0669999999999,
"heapDeltaBytes": -6837400,
"heapUsedBytes": 74484572,
"domNodes": -228,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 35.01800000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2040.3309999999237,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.4749999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.17,
"heapDeltaBytes": -6690732,
"heapUsedBytes": 74470528,
"domNodes": -228,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 34.79199999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 3016.635000000065,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.686000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1790.41,
"heapDeltaBytes": 24678312,
"heapUsedBytes": 88849340,
"domNodes": -228,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 916.5190000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2528.3379999998488,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.765,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1711.6470000000002,
"heapDeltaBytes": -16405840,
"heapUsedBytes": 65189648,
"domNodes": -228,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 882.002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3928.512000000069,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.347,
"layouts": 60,
"layoutDurationMs": 15.086,
"taskDurationMs": 1836.643,
"heapDeltaBytes": 8322040,
"heapUsedBytes": 74499460,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 853.013,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3629.6839999999975,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.886,
"layouts": 60,
"layoutDurationMs": 13.475,
"taskDurationMs": 1691.8059999999998,
"heapDeltaBytes": 8429448,
"heapUsedBytes": 74338180,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 807.2969999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3130.314000000112,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.255,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1879.7579999999998,
"heapDeltaBytes": 23219460,
"heapUsedBytes": 91198880,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1025.104,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3131.110000000035,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.2920000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1888.3519999999999,
"heapDeltaBytes": 25938656,
"heapUsedBytes": 92242880,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 981.5440000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2085.6880000000046,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.7459999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.4180000000001,
"heapDeltaBytes": -9524660,
"heapUsedBytes": 79006000,
"domNodes": -228,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 41.025000000000006,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2063.4889999998904,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.4859999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.5169999999998,
"heapDeltaBytes": -8352192,
"heapUsedBytes": 80108132,
"domNodes": -228,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 35.35200000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 678.7949999999228,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.614000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.68,
"heapDeltaBytes": 13181932,
"heapUsedBytes": 82119256,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 153.222,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 565.6180000000859,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.706,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.618,
"heapDeltaBytes": 13269228,
"heapUsedBytes": 76979652,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.951,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2001.9570000000613,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.206999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.29999999999995,
"heapDeltaBytes": 8031724,
"heapUsedBytes": 71595316,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.290000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.575000000079,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.843000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.563,
"heapDeltaBytes": -5252396,
"heapUsedBytes": 58511084,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.009000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.4920000000784,
"styleRecalcs": 59,
"styleRecalcDurationMs": 18.227,
"layouts": 16,
"layoutDurationMs": 6.396,
"taskDurationMs": 819.783,
"heapDeltaBytes": -4850824,
"heapUsedBytes": 57981376,
"domNodes": -244,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 120.73400000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.1270000000804,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.533,
"layouts": 16,
"layoutDurationMs": 5.864999999999999,
"taskDurationMs": 770.423,
"heapDeltaBytes": 8776636,
"heapUsedBytes": 72488512,
"domNodes": -244,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 111.49000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.3669999998838,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.952000000000005,
"layouts": 5,
"layoutDurationMs": 13.349999999999998,
"taskDurationMs": 897.335,
"heapDeltaBytes": 20312976,
"heapUsedBytes": 103877036,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 28.677999999999994,
"eventListeners": 2383,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10030.162000000018,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.21000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6437.499,
"heapDeltaBytes": -51004,
"heapUsedBytes": 80547016,
"domNodes": -228,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 3012.495,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8645.833000000039,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.159,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5875.256,
"heapDeltaBytes": -15026812,
"heapUsedBytes": 66191404,
"domNodes": -228,
"jsHeapTotalBytes": 2125824,
"scriptDurationMs": 2877.3140000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17673.42199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17312.237,
"heapDeltaBytes": -46136728,
"heapUsedBytes": 194085408,
"domNodes": -8049,
"jsHeapTotalBytes": -14798848,
"scriptDurationMs": 278.28200000000004,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17155.025000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16589.972,
"heapDeltaBytes": -56212320,
"heapUsedBytes": 184496240,
"domNodes": -8049,
"jsHeapTotalBytes": -16715776,
"scriptDurationMs": 261.258,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22366.038000000004,
"styleRecalcs": 165,
"styleRecalcDurationMs": 23.49000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22192.137,
"heapDeltaBytes": -31861028,
"heapUsedBytes": 181480356,
"domNodes": -8049,
"jsHeapTotalBytes": -18731008,
"scriptDurationMs": 993.836,
"eventListeners": -14923,
"totalBlockingTimeMs": 166,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20791.64500000002,
"styleRecalcs": 165,
"styleRecalcDurationMs": 16.90899999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20486.173000000003,
"heapDeltaBytes": -44485808,
"heapUsedBytes": 180940524,
"domNodes": -8049,
"jsHeapTotalBytes": -17309696,
"scriptDurationMs": 895.893,
"eventListeners": -14923,
"totalBlockingTimeMs": 50,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6247.867000000042,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.32300000000001,
"layouts": 20,
"layoutDurationMs": 23.623000000000005,
"taskDurationMs": 6216.0650000000005,
"heapDeltaBytes": -28774412,
"heapUsedBytes": 196158928,
"domNodes": -8049,
"jsHeapTotalBytes": 15458304,
"scriptDurationMs": 111.98500000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 399,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6173.139999999876,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.486,
"layouts": 20,
"layoutDurationMs": 22.265000000000008,
"taskDurationMs": 6039.918999999999,
"heapDeltaBytes": -22397356,
"heapUsedBytes": 194969172,
"domNodes": -8049,
"jsHeapTotalBytes": 12648448,
"scriptDurationMs": 108.43200000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 412,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8869.885999999951,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8673.248000000001,
"heapDeltaBytes": -15345440,
"heapUsedBytes": 179056440,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 134.52300000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8503.56799999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8318.837,
"heapDeltaBytes": -1473112,
"heapUsedBytes": 173673252,
"domNodes": 0,
"jsHeapTotalBytes": -25952256,
"scriptDurationMs": 128.865,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 461.31100000002334,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.047,
"layouts": 4,
"layoutDurationMs": 2.1929999999999996,
"taskDurationMs": 124.643,
"heapDeltaBytes": 5008664,
"heapUsedBytes": 66832576,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.552000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 449.4250000000193,
"styleRecalcs": 15,
"styleRecalcDurationMs": 15.107000000000001,
"layouts": 3,
"layoutDurationMs": 1,
"taskDurationMs": 108.599,
"heapDeltaBytes": 4792788,
"heapUsedBytes": 66771060,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.049000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ae1179653d33f61b8f17471a9936911074f309ff
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests.
@@ Coverage Diff @@
## main #16873 +/- ##
==========================================
- Coverage 84.92% 79.53% -5.39%
==========================================
Files 2339 2209 -130
Lines 133042 137098 +4056
Branches 33977 33045 -932
==========================================
- Hits 112986 109041 -3945
- Misses 19711 27880 +8169
+ Partials 345 177 -168
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Landing guard: hold this workflow-tab salvage PR until the larger codegen coverage PR #16217 lands, then rebase it. Full context for agent readersExact heads checked: this PR A synthetic squash-order merge proves why the order matters. Landing PR #16217 first makes this PR conflict in After PR #16217 lands, resolve this PR's rebase to retain exactly one enabled copy of each test:
For the active-close case, preserve PR #16217's stronger selected-tab-name assertion rather than this head's hard-coded No branch was pushed or merged by this hygiene lane. |
e2ce3e3 to
4e4d1cf
Compare
|
Deployment failed for project comfy-home-v1 with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
4e4d1cf to
c61627b
Compare
|
Rebased onto current main Full context for agent readersPrevious head The rebase therefore replayed only the test commit ( The resulting diff against main is 22 deletions in Evidence at the pushed head: Playwright collection lists 20 tests in the file with each of the four target cases collected once and no longer skipped; scoped Why the ecosystem-matrix red was not this PR
The shard itself (job 100933096953) was not cancelled in any ordinary sense. The budget is structurally tight rather than flaky. Rerunning the failed jobs on run 33844375786 re-ran only the cancelled shard and preserved the seven green ones. It passed in 14m49s versus attempt 1's 20m05s, and the run conclusion is Not claimed merge-ready: main has advanced from the rebase base |
c61627b to
2a49748
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 3 |
| 🟢 Low | 4 |
Panel: 8/8 reviewers contributed findings.
Ports the four browser-level tests reserved by closed slice PR #16226 (single commit 063f2b7) onto current main, verbatim: exactly-one-active tab, path-backed active identity after a tab switch, neighbor activation on close, and tab identity across browser reload. All four fixture helpers already exist on main; no production code or fixture changes.
2a49748 to
772c1d8
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested
I found two blocking gaps in the newly enabled coverage:
- The path-backed switch case repeats the existing label-based tab-switch scenario without making a workflow key and full path disagree. A regression that keys active identity by filename still passes.
- The reload case leaves the newest, rightmost tab active, so an implementation that always restores the last tab passes. It also exceeded the repository's 15-second Chromium timeout in all three targeted repeats, each time while waiting for the app after reload.
The earlier fixes for tab creation barriers, selected-tab activation, exact close targeting, neighbor activation, and waiting for persistence are present.
Checks at 772c1d8a29c4b26128d5265a0af0f94d40ae65db: hosted checks are settled with 74 successful and 23 skipped, with no failures or pending checks. pnpm install --frozen-lockfile, both typechecks, changed-file ESLint/Oxlint, full format check, Knip, Fallow audit, and 53 relevant unit tests passed. The first full browser-file run passed 18/20; one failure was cold-start setup, and the reload case timed out. A targeted three-repeat run passed the other three new cases 3/3 each, while the reload case failed 0/3. For comparison, an existing reload test with a 30-second test timeout passed locally in 15.1 seconds.
| await topbar.getTab(0).click() | ||
|
|
||
| await expect.poll(() => topbar.getActiveTabName()).toContain(names[0]) | ||
| await expect(topbar.getActiveTab()).not.toContainText('(2)') |
There was a problem hiding this comment.
This still does not exercise the path-backed identity named by the test. The setup and assertions duplicate Switching tabs changes active workflow below and observe only distinct visible names, so a regression that keys tabs by filename instead of their full paths still passes. Please arrange workflows whose filenames collide but whose paths differ, then assert the selected tab by data-workflow-path, or delete this duplicate case.
| await topbar.getTab(1).click() | ||
| await expect.poll(() => topbar.getTabNames()).toHaveLength(2) | ||
| const activeName = await topbar.getActiveTabName() | ||
| await comfyPage.workflow.waitForDraftPersisted() |
There was a problem hiding this comment.
This case leaves the newly created last tab active, so an implementation that ignores the persisted active index and always restores the last tab still passes. It also timed out in reloadAndWaitForApp() in all three targeted local repeats under this project's 15-second timeout. Please select a non-edge tab, capture its data-workflow-path, assert that same path after reload, and give this reload scenario the established 30-second test timeout used by comparable tests.
DrJKL
left a comment
There was a problem hiding this comment.
Targeted Playwright review
I reviewed the changed spec against the fixture inventory and every Playwright rulebook item. I found three new non-blocking issues, attached inline.
The existing findings were not duplicated:
- The path-identity case does not distinguish filenames from full paths.
- The reload case selects the last tab and times out at the default timeout.
- The
aria-pressedassertion repeats the checked-tab state. The selected-name part was fixed, but the redundant assertion remains.
Previously reported findings checked
- Substring selection: fixed by the negative
(2)assertion. - Draft persistence barrier: the new wait addresses draft storage, but it does not address the separate reload-identity finding linked above.
- Tab-creation barrier: fixed by polling the expected count.
- Text-based close targeting: fixed by exact indexed targeting.
- Redundant active-tab click: fixed.
- Tab-name read before render: fixed by polling the expected count first.
Coverage
- Helper inventory: 493 public async methods across 74 fixture files, plus 161 assertion and matcher references.
- Interaction table: 32 rows, including 20 matches to inventoried helpers.
- Checks A through H: A found the switch and close helper bypasses; D confirmed the existing reload-readiness finding; E confirmed the existing redundant assertion; G found two tests missing step boundaries. B, C, and F were clear. H covered all 23 rulebook items.
- Rulebook: item 8 was hit. Items 1 through 7 and 9 through 23 were clear or not applicable; item 23 included a history check.
- Runtime: no new browser result. The focused command could not connect to port 5173. The earlier current-head run remains the behavioral evidence: the three non-reload cases passed 3/3, while reload timed out 0/3.
| await expect.poll(() => topbar.getTabNames()).toHaveLength(3) | ||
|
|
||
| await topbar.getTab(1).click() | ||
| await expect.poll(() => topbar.getActiveTabName()).toContain('(2)') |
There was a problem hiding this comment.
P2: The direct tab click immediately above bypasses WorkflowHelper.switchToTab(), which also waits for workflow idle. The same raw switch appears at lines 40 and 53. Use the helper for unique names, and give it an exact locator or index form for the default tab so this does not reintroduce substring ambiguity. That keeps switch readiness in the shared action.
| await expect.poll(() => topbar.getActiveTabName()).toContain('(2)') | ||
| const activeTab = topbar.getTab(1) | ||
| await activeTab.hover() | ||
| await activeTab.locator('.close-button').click() |
There was a problem hiding this comment.
P3: This hover plus .close-button recipe duplicates Topbar.closeWorkflowTab(). Its current name-based form cannot preserve the exact indexed target required here, so add an exact locator or index form to the page object and call that instead. The close sequence and selector should have one owner.
|
|
||
| await expect.poll(() => topbar.getTabNames()).toHaveLength(2) | ||
| await expect.poll(() => topbar.getActiveTabName()).not.toBe(activeTabName) | ||
| await expect.poll(() => topbar.getActiveTabName()).toContain('(3)') |
There was a problem hiding this comment.
P3: This case performs five user actions without test.step phases, so its trace does not separate creation, activation, close, and neighbor selection. The first contract case also crosses the check G threshold with two creates and a switch. Split those two cases into short user-facing act-and-assert steps; the other two cases stay below the three-action threshold.
DrJKL
left a comment
There was a problem hiding this comment.
Proposed fixes for the three targeted Playwright comments
All three findings remain at this head. The inline suggestions update two locations in the spec. The proposed patch below adds the indexed helper forms and the step boundaries for the first contract case.
The existing owners are WorkflowHelper.switchToTab() at browser_tests/fixtures/helpers/WorkflowHelper.ts:229-232, which includes the workflow-idle wait, and Topbar.getTab() / closeWorkflowTab() at browser_tests/fixtures/components/Topbar.ts:68-81. This proposed patch adds exact-index forms without changing existing string callers:
diff --git a/browser_tests/fixtures/components/Topbar.ts b/browser_tests/fixtures/components/Topbar.ts
index 608a262f07..44e64c0170 100644
--- a/browser_tests/fixtures/components/Topbar.ts
+++ b/browser_tests/fixtures/components/Topbar.ts
@@ -75,10 +75,11 @@ export class Topbar {
)
}
- async closeWorkflowTab(tabName: string) {
- const tab = this.getWorkflowTab(tabName)
- await tab.hover()
- await tab.locator('.close-button').click()
+ async closeWorkflowTab(tab: string | number) {
+ const tabLocator =
+ typeof tab === 'number' ? this.getTab(tab) : this.getWorkflowTab(tab)
+ await tabLocator.hover()
+ await tabLocator.locator('.close-button').click()
}
getSaveDialog(): Locator {
diff --git a/browser_tests/fixtures/helpers/WorkflowHelper.ts b/browser_tests/fixtures/helpers/WorkflowHelper.ts
index bee3b27e4c..24940f2f26 100644
--- a/browser_tests/fixtures/helpers/WorkflowHelper.ts
+++ b/browser_tests/fixtures/helpers/WorkflowHelper.ts
@@ -226,8 +226,12 @@ export class WorkflowHelper {
)
}
- async switchToTab(tabName: string): Promise<void> {
- await this.comfyPage.menu.topbar.getWorkflowTab(tabName).click()
+ async switchToTab(tab: string | number): Promise<void> {
+ const tabLocator =
+ typeof tab === 'number'
+ ? this.comfyPage.menu.topbar.getTab(tab)
+ : this.comfyPage.menu.topbar.getWorkflowTab(tab)
+ await tabLocator.click()
await this.waitForWorkflowIdle()
}
diff --git a/browser_tests/tests/topbar/workflowTabs.spec.ts b/browser_tests/tests/topbar/workflowTabs.spec.ts
index 8d9be9c63a..7e914dca7b 100644
--- a/browser_tests/tests/topbar/workflowTabs.spec.ts
+++ b/browser_tests/tests/topbar/workflowTabs.spec.ts
@@ -15,19 +15,24 @@ test.describe('Workflow tabs', () => {
comfyPage
}) => {
const topbar = comfyPage.menu.topbar
- await topbar.newWorkflowButton.click()
- await topbar.newWorkflowButton.click()
- await expect.poll(() => topbar.getTabNames()).toHaveLength(3)
- await topbar.getTab(1).click()
- await expect.poll(() => topbar.getActiveTabName()).toContain('(2)')
- await expect(topbar.getActiveTab()).toHaveAttribute(
- 'aria-pressed',
- 'true'
- )
- await expect(
- comfyPage.page.locator('.workflow-tabs .p-togglebutton-checked')
- ).toHaveCount(1)
+ await test.step('Create three workflows', async () => {
+ await topbar.newWorkflowButton.click()
+ await topbar.newWorkflowButton.click()
+ await expect.poll(() => topbar.getTabNames()).toHaveLength(3)
+ })
+
+ await test.step('Select only the middle workflow', async () => {
+ await comfyPage.workflow.switchToTab(1)
+ await expect.poll(() => topbar.getActiveTabName()).toContain('(2)')
+ await expect(topbar.getActiveTab()).toHaveAttribute(
+ 'aria-pressed',
+ 'true'
+ )
+ await expect(
+ comfyPage.page.locator('.workflow-tabs .p-togglebutton-checked')
+ ).toHaveCount(1)
+ })
})This addresses the existing switch-helper comment, close page-object comment, and step-boundary comment. It does not change my prior verdict.
I applied the body patch and all inline suggestions together in an isolated worktree and ran:
pnpm install --frozen-lockfile: passed.pnpm typecheck:browser: passed.- ESLint on all three changed files: passed.
- oxfmt check on all three changed files: passed.
pnpm test:browser --project=chromium --list browser_tests/tests/topbar/workflowTabs.spec.ts: passed; 20 tests collected.
I could not run the focused browser cases because neither the frontend on port 5173 nor the backend on port 8188 was available.
| await topbar.newWorkflowButton.click() | ||
| await expect.poll(() => topbar.getTabNames()).toHaveLength(2) | ||
| const names = await topbar.getTabNames() | ||
| await topbar.getTab(0).click() |
There was a problem hiding this comment.
Proposed exact-index fix for the switch-helper comment, using the indexed helper form from the review body:
| await topbar.getTab(0).click() | |
| await comfyPage.workflow.switchToTab(0) |
| await topbar.newWorkflowButton.click() | ||
| await topbar.newWorkflowButton.click() | ||
| await expect.poll(() => topbar.getTabNames()).toHaveLength(3) | ||
| await topbar.getTab(1).click() | ||
| const activeTabName = await topbar.getActiveTabName() | ||
| await topbar.closeWorkflowTab(activeTabName) | ||
| await expect.poll(() => topbar.getActiveTabName()).toContain('(2)') | ||
| const activeTab = topbar.getTab(1) | ||
| await activeTab.hover() | ||
| await activeTab.locator('.close-button').click() | ||
|
|
||
| await expect.poll(() => topbar.getTabNames()).toHaveLength(2) | ||
| await expect.poll(() => topbar.getActiveTabName()).not.toBe(activeTabName) | ||
| await expect.poll(() => topbar.getActiveTabName()).toContain('(3)') |
There was a problem hiding this comment.
Proposed fix for the switch-helper, close page-object, and step-boundary comments (after applying the helper patch in the review body):
| await topbar.newWorkflowButton.click() | |
| await topbar.newWorkflowButton.click() | |
| await expect.poll(() => topbar.getTabNames()).toHaveLength(3) | |
| await topbar.getTab(1).click() | |
| const activeTabName = await topbar.getActiveTabName() | |
| await topbar.closeWorkflowTab(activeTabName) | |
| await expect.poll(() => topbar.getActiveTabName()).toContain('(2)') | |
| const activeTab = topbar.getTab(1) | |
| await activeTab.hover() | |
| await activeTab.locator('.close-button').click() | |
| await expect.poll(() => topbar.getTabNames()).toHaveLength(2) | |
| await expect.poll(() => topbar.getActiveTabName()).not.toBe(activeTabName) | |
| await expect.poll(() => topbar.getActiveTabName()).toContain('(3)') | |
| await test.step('Create three workflows', async () => { | |
| await topbar.newWorkflowButton.click() | |
| await topbar.newWorkflowButton.click() | |
| await expect.poll(() => topbar.getTabNames()).toHaveLength(3) | |
| }) | |
| await test.step('Select the middle workflow', async () => { | |
| await comfyPage.workflow.switchToTab(1) | |
| await expect.poll(() => topbar.getActiveTabName()).toContain('(2)') | |
| }) | |
| await test.step('Close the middle workflow and activate its neighbor', async () => { | |
| await topbar.closeWorkflowTab(1) | |
| await expect.poll(() => topbar.getTabNames()).toHaveLength(2) | |
| await expect.poll(() => topbar.getActiveTabName()).toContain('(3)') | |
| }) |
|
Merged main at |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
|
Closing as superseded. The three cases this PR un- |
Enables the four workflow-tab contract tests merged in #16217 by removing their stale slice gates. The rebase keeps #16217's stronger active-tab close assertion and leaves exactly one copy of each test.
Full context for agent readers
PR #16217 merged the four tests behind
test.fixmegates. This branch is rebased onto that merge and now removes only the obsolete comment and four gates. It does not duplicate or weaken the tests.Covered behavior:
Source context: salvage dossier
reports/review/salvage/dossiers/fe-16226.mdin the program repo; rowssalv-5andprhyg-20.Evidence
pnpm install --frozen-lockfile— passedpnpm exec oxfmt --check browser_tests/tests/topbar/workflowTabs.spec.ts— passedpnpm exec eslint browser_tests/tests/topbar/workflowTabs.spec.ts— passedPLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test browser_tests/tests/topbar/workflowTabs.spec.ts --list— 20 tests collected; each of the four contract tests appears oncegit diff --check refs/remotes/origin/main...HEAD— passed