Repository navigation
Temporarily disable agent keyboard accessibility e2e test - #16907
Conversation
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎭 Playwright: ✅ 1908 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.69 MB gzip 🟢 -670 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 559 kB (baseline 559 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 20 added / 20 removed / 16 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • 🟢 -2 kBBundles that do not match a named category
Status: 93 added / 93 removed / 203 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-04T02:04:57.521Z",
"gitSha": "6a5b139ff593b91cb1e2e33ad47fa9c82ba71821",
"branch": "christian-byrne-patch-3",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2080.7340000000067,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.520999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.076,
"heapDeltaBytes": -10172104,
"heapUsedBytes": 60320452,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.671999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2051.257000000078,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.774,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.50899999999996,
"heapDeltaBytes": 8579320,
"heapUsedBytes": 78490760,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.426999999999998,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1855.8300000000258,
"styleRecalcs": 79,
"styleRecalcDurationMs": 40.266999999999996,
"layouts": 14,
"layoutDurationMs": 4.863,
"taskDurationMs": 872.5530000000001,
"heapDeltaBytes": -7373308,
"heapUsedBytes": 63236476,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 144.117,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.5850000000091,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.129,
"layouts": 14,
"layoutDurationMs": 4.666,
"taskDurationMs": 869.94,
"heapDeltaBytes": -6633440,
"heapUsedBytes": 63452184,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 146.181,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.3309999999556,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.794,
"layouts": 6,
"layoutDurationMs": 1.125,
"taskDurationMs": 374.659,
"heapDeltaBytes": 4733288,
"heapUsedBytes": 75104724,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.201,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.4160000000002,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.943,
"layouts": 6,
"layoutDurationMs": 1.1340000000000003,
"taskDurationMs": 349.46900000000005,
"heapDeltaBytes": 5050604,
"heapUsedBytes": 75667604,
"domNodes": 79,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.132000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 629.1930000000434,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.398,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.14799999999997,
"heapDeltaBytes": 18206104,
"heapUsedBytes": 88089624,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 154.16299999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 688.0069999999705,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.518999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.72700000000003,
"heapDeltaBytes": -7487536,
"heapUsedBytes": 62915300,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 155.986,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.6150000000257,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.2650000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.773,
"heapDeltaBytes": -14754128,
"heapUsedBytes": 87102648,
"domNodes": -270,
"jsHeapTotalBytes": -851968,
"scriptDurationMs": 34.022000000000006,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.3359999999439,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.5639999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.615,
"heapDeltaBytes": -14563432,
"heapUsedBytes": 86831036,
"domNodes": -268,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 38.38699999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2244.971000000021,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.87,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1608.4530000000002,
"heapDeltaBytes": -13230520,
"heapUsedBytes": 89230980,
"domNodes": -271,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 771.378,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2116.9660000000476,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.061999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1491.996,
"heapDeltaBytes": 17358632,
"heapUsedBytes": 84058968,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 737.4499999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3508.2669999999894,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.391000000000002,
"layouts": 60,
"layoutDurationMs": 12.927999999999999,
"taskDurationMs": 1678.394,
"heapDeltaBytes": 9767568,
"heapUsedBytes": 76386568,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 759.4989999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3498.068000000103,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.679999999999998,
"layouts": 60,
"layoutDurationMs": 12.880999999999998,
"taskDurationMs": 1653.749,
"heapDeltaBytes": 8198868,
"heapUsedBytes": 75836768,
"domNodes": -280,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 746.344,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3025.44800000004,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.918000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1918.501,
"heapDeltaBytes": 21983160,
"heapUsedBytes": 89336100,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 928.5949999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3081.036999999924,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.304999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1886.942,
"heapDeltaBytes": 21668312,
"heapUsedBytes": 89709768,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 934.3059999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.6810000000578,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.6459999999999972,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.5440000000001,
"heapDeltaBytes": 21833096,
"heapUsedBytes": 88313948,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.516000000000005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.634000000021,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.568999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.0360000000001,
"heapDeltaBytes": -15826656,
"heapUsedBytes": 87948656,
"domNodes": -275,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 31.537999999999997,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.9629999999788,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.525,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.489,
"heapDeltaBytes": 15184928,
"heapUsedBytes": 88105372,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 141.823,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.3229999998985,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.951999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.42900000000003,
"heapDeltaBytes": 15163224,
"heapUsedBytes": 87681088,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 141.538,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.0299999999625,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.346,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.668,
"heapDeltaBytes": -13608916,
"heapUsedBytes": 58934768,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.911000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.4489999999896,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.937,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.685,
"heapDeltaBytes": 672292,
"heapUsedBytes": 73712140,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.936999999999999,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.8650000000134,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.992,
"layouts": 18,
"layoutDurationMs": 4.966,
"taskDurationMs": 770.346,
"heapDeltaBytes": -9763496,
"heapUsedBytes": 63155472,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 99.96199999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.7580000000362,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.803,
"layouts": 18,
"layoutDurationMs": 5.0920000000000005,
"taskDurationMs": 787.261,
"heapDeltaBytes": -12084004,
"heapUsedBytes": 60314312,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 101.338,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.2559999999366,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.568000000000005,
"layouts": 15,
"layoutDurationMs": 14.088,
"taskDurationMs": 895.9939999999999,
"heapDeltaBytes": -5482504,
"heapUsedBytes": 86203948,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 29.790000000000003,
"eventListeners": 2387,
"totalBlockingTimeMs": 128,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8373.337999999989,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5684.622,
"heapDeltaBytes": 28078260,
"heapUsedBytes": 93017452,
"domNodes": -269,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 2579.674,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8222.751000000017,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.468,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5576.031,
"heapDeltaBytes": -11387952,
"heapUsedBytes": 89908944,
"domNodes": -268,
"jsHeapTotalBytes": -102400,
"scriptDurationMs": 2509.375,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18103.136000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17277.753999999997,
"heapDeltaBytes": -29893388,
"heapUsedBytes": 177962412,
"domNodes": -6548,
"jsHeapTotalBytes": -3973120,
"scriptDurationMs": 282.872,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18015.795000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17386.964,
"heapDeltaBytes": -38682408,
"heapUsedBytes": 175376840,
"domNodes": -6548,
"jsHeapTotalBytes": -7024640,
"scriptDurationMs": 294.57,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21953.645999999935,
"styleRecalcs": 175,
"styleRecalcDurationMs": 19.264999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21562.469,
"heapDeltaBytes": -50470192,
"heapUsedBytes": 163435996,
"domNodes": -6548,
"jsHeapTotalBytes": -10432512,
"scriptDurationMs": 910.8629999999999,
"eventListeners": -7467,
"totalBlockingTimeMs": 139,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21889.290999999957,
"styleRecalcs": 167,
"styleRecalcDurationMs": 20.83799999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21510.387000000002,
"heapDeltaBytes": -47834284,
"heapUsedBytes": 162916756,
"domNodes": -6548,
"jsHeapTotalBytes": -5812224,
"scriptDurationMs": 939.398,
"eventListeners": -7467,
"totalBlockingTimeMs": 255,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6229.465000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.938,
"layouts": 20,
"layoutDurationMs": 23.3,
"taskDurationMs": 6149.364000000001,
"heapDeltaBytes": -21075716,
"heapUsedBytes": 181693988,
"domNodes": -6548,
"jsHeapTotalBytes": 19111936,
"scriptDurationMs": 116.76800000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 443,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6338.209000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.164,
"layouts": 20,
"layoutDurationMs": 23.17000000000001,
"taskDurationMs": 6229.017999999999,
"heapDeltaBytes": -29607184,
"heapUsedBytes": 180848336,
"domNodes": -6548,
"jsHeapTotalBytes": 11649024,
"scriptDurationMs": 114.11200000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 461,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9126.21200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8728.893,
"heapDeltaBytes": 13539404,
"heapUsedBytes": 177258560,
"domNodes": 0,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 145.87399999999994,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9020.768999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8608.079,
"heapDeltaBytes": 3766060,
"heapUsedBytes": 177224672,
"domNodes": 0,
"jsHeapTotalBytes": -1835008,
"scriptDurationMs": 169.85100000000003,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 112.40399999996953,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.760000000000002,
"layouts": 2,
"layoutDurationMs": 1.41,
"taskDurationMs": 78.05,
"heapDeltaBytes": 3014100,
"heapUsedBytes": 71625256,
"domNodes": 131,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.1160000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 101.88500000003842,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.869,
"layouts": 2,
"layoutDurationMs": 0.7619999999999999,
"taskDurationMs": 66.58000000000001,
"heapDeltaBytes": 3017748,
"heapUsedBytes": 72015296,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.371999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16907 +/- ##
==========================================
+ Coverage 81.16% 82.75% +1.58%
==========================================
Files 2460 2042 -418
Lines 126656 119177 -7479
Branches 31933 30106 -1827
==========================================
- Hits 102804 98622 -4182
+ Misses 23336 20374 -2962
+ Partials 516 181 -335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
question: is disabling this spec still the right move given what landed on main 50 minutes ago? #16903 (merged So the spec is about to fail for a second, different reason than the one this PR was opened against: not a missing landmark name, but a genuinely duplicated DOM id. Disabling it here would green main while leaving that duplicate in place, and duplicate ids make the Details and the fix-forward finding: #16904 comment. |
|
Nevermind, see above comment |
…#16903 (#16912) - Removes the duplicate `id="agent-panel-title"` that #16904 added to `AgentPanelRoot.vue`. - #16903 (merged 16 min earlier) already fixed the dangling `aria-labelledby` on `PanelHeader.vue:36`; both together mount two elements with the same id on the success path. - Pure revert of 34b6558; no other change. <details><summary>Full context for agent readers</summary> **Why:** `DockedAgentPanel` sets `aria-labelledby="agent-panel-title"` unconditionally. #16903 put the id on the success-path `<h1>` in `PanelHeader.vue`; #16904 independently added an `sr-only <h2>` with the same id in `AgentPanelRoot.vue`. `AgentPanelRoot` renders `AgentPanel` → `PanelHeader`, so after both merges main has two elements with `id="agent-panel-title"` whenever the panel loads successfully. Duplicate ids are invalid HTML and make `aria-labelledby` resolution browser-dependent. **Test coverage:** `browser_tests/tests/agent/agentPanelLifecycle.spec.ts:84` asserts `toHaveCount(1)` and would receive 2, but #16907 marked that test `test.fixme` at 5764cd3 minutes later, so CI no longer surfaces it. Once this lands, re-enabling that test is a candidate follow-up (not included here to keep this a pure revert). **Verification:** `git revert 34b6558` applied cleanly (8 deletions, one file); `rg agent-panel-title src/workbench/extensions/agent/AgentPanelRoot.vue` → 0 matches on this branch; `PanelHeader.vue:36` retains the id. Related: #16903, #16904, #16907. </details> <!-- authored-by:agent desktop-commander -->
) *PR Created by the Glary-Bot Agent* --- ## Summary Re-enables the Agent panel keyboard-accessibility e2e test, which was muted five days ago to unblock CI and left muted after the bug it caught was fixed 29 minutes later. ## Changes - **What**: `test.fixme(` → `test(` on `browser_tests/tests/agent/agentPanelLifecycle.spec.ts:68`. Byte-exact inverse of the disabling commit in Comfy-Org#16907. No assertion touched. ## Review Focus The mute was collateral from two PRs racing on 2026-09-03: | Time | PR | Event | |---|---|---| | 17:25 | Comfy-Org#16217 | Test added, green | | ~19:20 | Comfy-Org#16903 + Comfy-Org#16904 | Both render `id="agent-panel-title"` → **duplicate DOM id** | | 19:48 | Comfy-Org#16907 | Test muted (`toHaveCount(1)` was correctly failing) | | 20:17 | Comfy-Org#16912 | Duplicate id removed — the actual fix, but the mute stayed | So the test did its job: it caught a real a11y regression (a duplicate DOM id that left the `role="complementary"` landmark's `aria-labelledby` ambiguous). Comfy-Org#16912 is an ancestor of this branch, so the cause is gone. On `main` the id now has exactly two renderers — `PanelHeader.vue:36` (success path) and the `errorComponent` in `DockedAgentPanel.vue:48` — which are mutually exclusive. Verified by running it, not just reading it. Against a `pnpm dev:cloud` server on the `cloud` project: **10/10 green** on `--repeat-each=10`, and the full spec goes from 4 passed / 1 skipped to 5 passed. Measured DOM state at the moment of assertion: ```json { "agentPanelTitleIds": 1, "complementaryLandmarks": 1, "landmarkRole": "complementary", "landmarkLabelledBy": "agent-panel-title", "accessibleName": "Comfy Agent" } ``` Two notes for the reviewer: - Lines 85-91 gate for the first time here — they never executed in CI, because line 84 failed on the duplicate id before reaching them. Treat the `playwright-tests (cloud)` run as the receipt rather than my local runs. - The one spec test that fails locally, `preserves the stored preference while the flag is off`, fails identically on unmodified `main`. It is a dev-server artifact: `agentPanel.ts:92` forces `enabled = true` when `import.meta.env.MODE === 'development'`, so "flag off" is not reproducible outside a built bundle. Unrelated to this change. Possible follow-ups, deliberately not done here: a component-level guard asserting exactly one `#agent-panel-title` (cheaper than a single unsharded `@cloud` e2e as the only net for that class of bug — branches doing this already exist), and focus-restoration assertions if this test is meant to be the panel's full keyboard-a11y guard. ## Screenshots Panel opened via `Enter` on the trigger, header title rendering. ## Screenshots  Co-authored-by: glary-bot <glary-bot@comfy.org>
A `test.fixme`/`.skip` landed to unblock a red `main` is a promise to come back, and the PR body is the only place that promise survives. #16907 disabled `agentPanelLifecycle.spec.ts` with a completely empty body, so recovering the intent later meant reconstructing the failure direction from commit timestamps. This fails a pull request that newly disables a test unless its body names a tracking issue or follow-up PR, and prints the file and line so the author does not have to hunt for it. Scoped to avoid crying wolf, since a guard that fires on ordinary work gets routed around: - Only DISABLING declarations, matched as a first argument that is a string literal. Playwright's conditional `test.skip(condition, 'reason')` and bare `test.skip()` are runtime controls, not a test taken out of service. - Only lines this PR ADDS. A disable already on the base branch is not this author's debt to justify. - Only test sources, so a doc or changelog mentioning `test.fixme` is inert. Verified against the case that motivated it: replaying #16907's real base and head with its real (empty) body fails and names `agentPanelLifecycle.spec.ts: test.fixme('supports keyboard activation ...`. The same replay over the last six merged spec-touching PRs (#18213, #18201, #18197, #18183, #18159, #18174) passes, as do synthetic cases for conditional skip, bare skip, docs-only mention, and an unrelated edit to a file that already had a disabled test. shellcheck clean.
No description provided.