Skip to content

[backport cloud/1.49] feat(cloud): brand button variants and redesigned auth panels - #14851

Closed
comfy-pr-bot wants to merge 2 commits into
cloud/1.49from
backport-14696-to-cloud-1.49
Closed

comfy-pr-bot wants to merge 2 commits into
cloud/1.49from
backport-14696-to-cloud-1.49

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #14696 to cloud/1.49

Automatically created by backport workflow.

> **Stacked PR 3 of 5** — cloud auth redesign. Merge in order,
bottom-up.
>
> | | PR | What it does |
> |---|---|---|
> | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only
|
> | 2 | #14695 | Button keeps its label for screen readers while loading
|
> | 3 | #14696 | Brand button variants; login, sign-up and
forgot-password rebuilt on them |
> | 4 | #14697 | Logo, content and terms share one left edge |
> | 5 | #14698 | Static hero collage becomes a video carousel |

## Summary

Rebuilds the login, sign-up and forgot-password panels on real
design-system variants instead of a hand-pasted class string.

## Changes

- **What**: Adds the auth copy keys (`cloudNewUser`, `cloudSignUp`,
`freeRunsSuffix`) this PR's views consume, plus `brand-ghost`,
`brand-solid`, `brand-ghost-accent` variants and `brand` / `brand-icon`
sizes to the shared `Button`. The same long class string was previously
pasted at six sites with `size="unset"` — every one of those buttons was
opting out of the design system it was meant to use.
- Extracts `useCloudAuthPage` and `CloudSocialAuthButtons` from the
near-identical login and sign-up views (~85% duplicated markup plus
identical OAuth handlers).
- `SignUpForm` / `PasswordFields` take typed `ButtonVariants` props
instead of opaque class strings. Defaults are unchanged, so the desktop
sign-in dialog and update-password dialog render exactly as before.

## Review Focus

- **Shared-component blast radius**: `SignUpForm` and `PasswordFields`
are also used by `SignInContent.vue` and `UpdatePasswordContent.vue`.
The `h-10` field default is deliberately preserved — those two dialogs
have no test coverage.
- The variants and the views ship together on purpose:
`button.variants.ts` has zero consumers on its own, so splitting them
would merge dead code.

The panel is width-bounded here so this PR is visually valid on its own;
#14697 relocates that constraint onto its own wrapper.

Stacked on the button a11y PR.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 6, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) August 6, 2026 19:03
@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Oxfmt formatting

@github-actions

github-actions Bot commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/06/2026, 07:49:27 PM UTC

Links

🎭 Playwright: ✅ 1565 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1545 / ❌ 0 / ⚠️ 2 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: ❌ Deployment failed
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions
github-actions Bot requested a review from benceruleanlu August 6, 2026 20:10
@MaanilVerma MaanilVerma closed this Aug 7, 2026
auto-merge was automatically disabled August 7, 2026 11:21

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants