Repository navigation
fix: surface failed email sign-in as an inline error - #14943
MaanilVerma wants to merge 2 commits into
Conversation
CloudSignInForm renders a <Message v-if="authError"> banner, but nothing ever wrote a sign-in failure into authError, so the banner was unreachable. The auth actions are wrapped in wrapWithErrorHandlingAsync, which swallows the rejection and resolves undefined, so a wrong-password failure only ever showed up as a falsy value that skipped onAuthSuccess. Extract the message derivation out of reportError into a pure authErrorMessage(), and record it on a lastAuthErrorMessage ref so the inline banner shows the same copy as the toast rather than a second, divergent string. CloudLoginView's local signInWithEmail moves into useCloudAuthPage alongside the social handlers. Social sign-in stays toast-only: no form is mounted there, so an inline banner would render nowhere. Email sign-in reports both inline and via toast; de-duplicating would mean splitting the shared error handler that also fires auth telemetry, which is far wider than this fix.
🎭 Playwright: ✅ 1795 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.68 MB gzip 🔴 +445 BDetailsSummary
Category Glance App Entry Points — 3.67 kB (baseline 3.67 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • 🔴 +397 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 570 kB (baseline 570 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 16 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 4 unchanged Editors & Dialogs — 125 kB (baseline 125 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 67.1 kB (baseline 67.1 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.49 MB (baseline 3.49 MB) • 🔴 +499 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 547 kB (baseline 547 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 20 unchanged Vendor & Third-Party — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 14 MB (baseline 14 MB) • ⚪ 0 BBundles that do not match a named category
Status: 68 added / 68 removed / 218 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-08T17:05:18.933Z",
"gitSha": "3888df05e5e84c364197e4cdc516b9593cea4bc7",
"branch": "fix/cloud-auth-inline-error",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2050.806000000023,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.565000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.206,
"heapDeltaBytes": 5876564,
"heapUsedBytes": 70318248,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 18.934,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2051.3409999999794,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.765,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.65599999999995,
"heapDeltaBytes": 5839276,
"heapUsedBytes": 70269360,
"domNodes": 16,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 18.257999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1955.7019999999739,
"styleRecalcs": 79,
"styleRecalcDurationMs": 45.95100000000001,
"layouts": 12,
"layoutDurationMs": 5.715000000000001,
"taskDurationMs": 920.024,
"heapDeltaBytes": -12016976,
"heapUsedBytes": 52311400,
"domNodes": -279,
"jsHeapTotalBytes": 24092672,
"scriptDurationMs": 128.656,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.4469999999792,
"styleRecalcs": 73,
"styleRecalcDurationMs": 35.829,
"layouts": 12,
"layoutDurationMs": 3.471,
"taskDurationMs": 922.787,
"heapDeltaBytes": -14248652,
"heapUsedBytes": 50144700,
"domNodes": -282,
"jsHeapTotalBytes": 23306240,
"scriptDurationMs": 126.553,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.3350000000105,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.014,
"layouts": 6,
"layoutDurationMs": 0.5109999999999999,
"taskDurationMs": 386.15299999999996,
"heapDeltaBytes": 8719368,
"heapUsedBytes": 73127344,
"domNodes": 77,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 19.912999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.1019999999553,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.93,
"layouts": 6,
"layoutDurationMs": 0.6449999999999999,
"taskDurationMs": 384.125,
"heapDeltaBytes": 8582972,
"heapUsedBytes": 72836056,
"domNodes": 79,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 19.672999999999995,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 594.4359999999733,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.161000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.732,
"heapDeltaBytes": -11076840,
"heapUsedBytes": 53135388,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 55.736999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 590.0629999999865,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.401000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.931,
"heapDeltaBytes": -11306256,
"heapUsedBytes": 53199868,
"domNodes": 16,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 60.172999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.4139999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.132000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 689.7429999999999,
"heapDeltaBytes": 6953468,
"heapUsedBytes": 66871436,
"domNodes": -281,
"jsHeapTotalBytes": 3510272,
"scriptDurationMs": 106.02,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2074.4260000000168,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.246,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 744.254,
"heapDeltaBytes": 7793028,
"heapUsedBytes": 67918748,
"domNodes": -283,
"jsHeapTotalBytes": 2985984,
"scriptDurationMs": 122.694,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2222.556999999995,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.081,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1304.099,
"heapDeltaBytes": 4633488,
"heapUsedBytes": 65190100,
"domNodes": -285,
"jsHeapTotalBytes": 3964928,
"scriptDurationMs": 431.99899999999997,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2303.247000000056,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.291999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1356.7559999999999,
"heapDeltaBytes": -4765144,
"heapUsedBytes": 55734556,
"domNodes": -283,
"jsHeapTotalBytes": 2985984,
"scriptDurationMs": 442.942,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3314.3139999999676,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.322,
"layouts": 60,
"layoutDurationMs": 7.659999999999999,
"taskDurationMs": 1562.1560000000002,
"heapDeltaBytes": 24659564,
"heapUsedBytes": 86937436,
"domNodes": 14,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 552.387,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3296.4079999999285,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.151,
"layouts": 60,
"layoutDurationMs": 7.652,
"taskDurationMs": 1599.1550000000002,
"heapDeltaBytes": 2699428,
"heapUsedBytes": 64878756,
"domNodes": -288,
"jsHeapTotalBytes": 7180288,
"scriptDurationMs": 559.994,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2038.995,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.957999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 696.9810000000001,
"heapDeltaBytes": 7471824,
"heapUsedBytes": 69280972,
"domNodes": -285,
"jsHeapTotalBytes": 2461696,
"scriptDurationMs": 110.514,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.4830000000466,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.929,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 665.2309999999999,
"heapDeltaBytes": 5332920,
"heapUsedBytes": 65867292,
"domNodes": -283,
"jsHeapTotalBytes": 3510272,
"scriptDurationMs": 104.47200000000001,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 622.1709999999803,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.443999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.59000000000003,
"heapDeltaBytes": -10899472,
"heapUsedBytes": 53501848,
"domNodes": 22,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 125.23700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.6509999999989,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.381,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.379,
"heapDeltaBytes": -10612420,
"heapUsedBytes": 53759116,
"domNodes": 18,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 121.716,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.6490000000285,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.227000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.82399999999996,
"heapDeltaBytes": 5947560,
"heapUsedBytes": 70519540,
"domNodes": 20,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 12.808,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1995.867999999973,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.246,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.14900000000006,
"heapDeltaBytes": 5925036,
"heapUsedBytes": 70355520,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 15.297999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.4259999999754,
"styleRecalcs": 76,
"styleRecalcDurationMs": 33.080999999999996,
"layouts": 16,
"layoutDurationMs": 4.064,
"taskDurationMs": 792.8409999999999,
"heapDeltaBytes": -18132116,
"heapUsedBytes": 46082380,
"domNodes": -279,
"jsHeapTotalBytes": 23306240,
"scriptDurationMs": 89.55000000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.5489999999872,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.352000000000004,
"layouts": 16,
"layoutDurationMs": 4.101000000000001,
"taskDurationMs": 783.139,
"heapDeltaBytes": -3366944,
"heapUsedBytes": 61081636,
"domNodes": 63,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 95.78299999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.799999999951,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.680999999999997,
"layouts": 14,
"layoutDurationMs": 12.344000000000001,
"taskDurationMs": 887.6300000000001,
"heapDeltaBytes": 32924964,
"heapUsedBytes": 99364080,
"domNodes": 13673,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 32.137,
"eventListeners": 2375,
"totalBlockingTimeMs": 128,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8502.769,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.598000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4666.738,
"heapDeltaBytes": 16211400,
"heapUsedBytes": 76025716,
"domNodes": -284,
"jsHeapTotalBytes": 6062080,
"scriptDurationMs": 1473.4579999999999,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8336.675000000014,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.36299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4406.082,
"heapDeltaBytes": 11832572,
"heapUsedBytes": 71189300,
"domNodes": -282,
"jsHeapTotalBytes": 5799936,
"scriptDurationMs": 1382.519,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16784.771000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16771.793,
"heapDeltaBytes": -47978816,
"heapUsedBytes": 170395900,
"domNodes": -8312,
"jsHeapTotalBytes": -9637888,
"scriptDurationMs": 524.207,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17403.38399999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17382.588,
"heapDeltaBytes": -42750060,
"heapUsedBytes": 161150572,
"domNodes": -8312,
"jsHeapTotalBytes": -13045760,
"scriptDurationMs": 573.731,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20772.657999999978,
"styleRecalcs": 140,
"styleRecalcDurationMs": 17.292999999999946,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20748.77,
"heapDeltaBytes": -33885192,
"heapUsedBytes": 176781196,
"domNodes": -8312,
"jsHeapTotalBytes": -6303744,
"scriptDurationMs": 915.6939999999998,
"eventListeners": -16381,
"totalBlockingTimeMs": 205,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20772.385999999984,
"styleRecalcs": 143,
"styleRecalcDurationMs": 16.59499999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20724.244,
"heapDeltaBytes": -36827556,
"heapUsedBytes": 171316980,
"domNodes": -8312,
"jsHeapTotalBytes": -7544832,
"scriptDurationMs": 892.362,
"eventListeners": -16383,
"totalBlockingTimeMs": 166,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 446.56800000007024,
"styleRecalcs": 14,
"styleRecalcDurationMs": 22.145000000000003,
"layouts": 3,
"layoutDurationMs": 1.0769999999999997,
"taskDurationMs": 114.783,
"heapDeltaBytes": 5323464,
"heapUsedBytes": 69008764,
"domNodes": 134,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.902000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 510.1640000000316,
"styleRecalcs": 17,
"styleRecalcDurationMs": 26.457,
"layouts": 3,
"layoutDurationMs": 1.3629999999999998,
"taskDurationMs": 142.707,
"heapDeltaBytes": 5224144,
"heapUsedBytes": 68530484,
"domNodes": 145,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.508,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAuthentication errors are classified in ChangesCloud authentication flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CloudSignInForm
participant CloudLoginView
participant useCloudAuthPage
participant useAuthActions
participant PostAuthRedirect
CloudSignInForm->>CloudLoginView: Submit email and password
CloudLoginView->>useCloudAuthPage: signInWithEmail(data)
useCloudAuthPage->>useAuthActions: Authenticate and report errors
alt Sign-in succeeds
useCloudAuthPage->>PostAuthRedirect: Redirect after sign-in
else Sign-in fails
useAuthActions-->>useCloudAuthPage: Return lastAuthErrorMessage
useCloudAuthPage-->>CloudLoginView: Set authError
CloudLoginView-->>CloudSignInForm: Display inline error
end
Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/composables/auth/useAuthActions.ts`:
- Around line 40-42: Update authErrorMessage() and the corresponding handling
around toastErrorHandler() so network TypeError errors, including “Failed to
fetch,” resolve to the localized g.disconnectedFromBackend message before
assigning lastAuthErrorMessage, keeping inline and toast messages consistent.
Add a regression test covering TypeError('Failed to fetch') and verify both
outputs use that translation.
In `@src/platform/cloud/onboarding/components/CloudSignInForm.test.ts`:
- Line 2: Replace the real Pinia setup and hand-written useAuthStore mock in
CloudSignInForm.test.ts with createTestingPinia, configuring it with the
required initial auth state. Update the affected setup and store references to
use the testing Pinia instance while preserving the existing test behavior.
- Around line 50-55: Update the “renders nothing when there is no auth error”
test to assert that the CloudSignInForm error banner or accessible error region
is absent, rather than checking only one message string. Use the rendered
component’s actual banner element or role-based query so any unexpected error
banner causes the test to fail.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 12f46aab-2030-417d-bee4-642137998a45
📒 Files selected for processing (5)
src/composables/auth/useAuthActions.tssrc/platform/cloud/onboarding/CloudLoginView.test.tssrc/platform/cloud/onboarding/CloudLoginView.vuesrc/platform/cloud/onboarding/components/CloudSignInForm.test.tssrc/platform/cloud/onboarding/composables/useCloudAuthPage.ts
| @@ -0,0 +1,57 @@ | |||
| import { render, screen } from '@testing-library/vue' | |||
| import { createPinia, setActivePinia } from 'pinia' | |||
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
Use createTestingPinia for the auth store.
The test creates a real Pinia instance but bypasses it with a hand-written useAuthStore mock. Use createTestingPinia with the required initial auth state instead. This keeps the component test aligned with the store contract.
As per path instructions, changed Vitest tests must use createTestingPinia for stores.
Also applies to: 10-12, 37-39
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/platform/cloud/onboarding/components/CloudSignInForm.test.ts` at line 2,
Replace the real Pinia setup and hand-written useAuthStore mock in
CloudSignInForm.test.ts with createTestingPinia, configuring it with the
required initial auth state. Update the affected setup and store references to
use the testing Pinia instance while preserving the existing test behavior.
Source: Path instructions
| it('renders nothing when there is no auth error', () => { | ||
| renderForm() | ||
|
|
||
| expect( | ||
| screen.queryByText('The password you entered is incorrect.') | ||
| ).not.toBeInTheDocument() |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Assert that the error banner is absent.
This assertion only proves that one specific message is absent. The test passes if the component renders a different error banner.
Assert that the accessible error region is absent, or assert against the actual banner element.
As per path instructions, tests must verify observable failure and success states.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/platform/cloud/onboarding/components/CloudSignInForm.test.ts` around
lines 50 - 55, Update the “renders nothing when there is no auth error” test to
assert that the CloudSignInForm error banner or accessible error region is
absent, rather than checking only one message string. Use the rendered
component’s actual banner element or role-based query so any unexpected error
banner causes the test to fail.
Source: Path instructions
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #14943 +/- ##
==========================================
- Coverage 78.70% 78.66% -0.04%
==========================================
Files 1864 1869 +5
Lines 115371 116480 +1109
Branches 34505 35016 +511
==========================================
+ Hits 90797 91625 +828
- Misses 24036 24295 +259
- Partials 538 560 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 65 files with indirect coverage changes 🚀 New features to boost your workflow:
|
A dropped connection surfaced two different strings for one failure: the toast said 'Disconnected from backend' while the inline banner showed the raw 'Failed to fetch' from the browser, untranslated. Extract the network-error predicate and its copy out of toastErrorHandler so both paths share one definition.
|
Closing this one. The inline banner duplicates the toast that already fires on a failed sign-in, so it adds a second surface for the same failure rather than fixing a gap. |
Summary
A failed email sign-in now shows an error next to the form instead of only a toast that fades.
Changes
What:
CloudSignInFormalready rendered a<Message v-if="authError">, but nothing ever wrote a sign-in failure intoauthError, so that banner was unreachable for the ordinary wrong-password case. The auth actions are wrapped inwrapWithErrorHandlingAsync, which swallows the rejection and resolvesundefined, so the caller only saw a falsy value and the failure surfaced as a corner toast.useCloudAuthPagenow ownssignInWithEmailand writes the failure message intoauthError.The message derivation was extracted out of
reportErrorinto a pureauthErrorMessage()and exposed aslastAuthErrorMessage, so the banner and the toast render identical copy rather than maintaining two strings that drift.CloudLoginViewhad its own localsignInWithEmailduplicating the composable's social-onlysignInWith. Both had the same swallow. They are now one path.Breaking: None.
reportErrorkeeps its signature and behaviour.Review Focus
The
useAuthActions.tshunk is the one to read closely. It restructures shared error handling that 15 modules consume, and while it is intended to be behaviour-preserving, that is worth confirming rather than trusting. The three branches (unauthorized-domain,signup_blocked, generic Firebase) keep their original order and messages;accessErrorstill flips only for the domain family. The 20 pre-existinguseAuthActionstests passed unchanged after the extraction, which is the evidence it did not shift behaviour.Email failures now surface both a toast and an inline banner. That duplication is deliberate. The toast comes from
reportAuthFlowError, the handler baked in at wrap time, and that same handler firestrackAuthFailedtelemetry. Suppressing just the toast would mean splitting that handler and threading a flag through the public API. Social sign-in stays toast-only because no form is mounted to host a banner.Known gap, deliberately out of scope:
CloudSignupView.vue:55binds:auth-errortoSignUpForm, which declares no such prop, so sign-up still has no reachable banner. Fixing that means adding a banner to a form shared with theSignInContentdialog, which is a UI decision rather than a wiring fix.Note this branch and
fix/auth-popup-error-codesboth modifyreportError. Whichever merges second will need a small conflict resolution.Testing
Four tests on
CloudLoginViewcovering the failure surfacing inline, the generic-copy fallback when no message was recorded, no redirect on failure, and redirect with no banner on success. Two on the newCloudSignInForm.test.tsfor the banner rendering and staying absent when there is no error.Each was mutation-checked: deleting the
authErrorassignment fails 2 tests, removing theif (await ...)guard fails 2, forcing the generic message fails 2 pre-existing tests.