Repository navigation
[backport cloud/1.49] fix(ui): keep the button label readable while loading - #14899
comfy-pr-bot wants to merge 1 commit into
Conversation
> **Stacked PR 2 of 5** — cloud auth redesign. Merge in order, bottom-up. > > | | PR | What it does | > |---|---|---| > | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only | > | 2 | #14695 | Button keeps its label for screen readers while loading | > | 3 | #14696 | Brand button variants; login, sign-up and forgot-password rebuilt on them | > | 4 | #14697 | Logo, content and terms share one left edge | > | 5 | #14698 | Static hero collage becomes a video carousel | ## Summary The shared `Button` dropped its label while loading, so assistive tech lost the control name for as long as the request was in flight. ## Changes - **What**: Keeps the label in the accessibility tree via `sr-only`, hides the decorative spinner from screen readers, and marks the control `aria-busy` while loading. Visually unchanged. ## Review Focus `Button.vue` is used app-wide, so the loading change is worth a look beyond the cloud pages — the rendered output is identical, only the accessibility tree differs. This PR is now two files. The locale changes it originally carried moved to the PRs that consume them (auth copy to #14696, carousel keys to #14698), so no intermediate merge renders raw i18n keys. Stacked on #14694.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1783 passed, 0 failed · 4 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-07T09:17:57.579Z",
"gitSha": "e59a82e1f01bc8414eb495c3592eb2b8c0c3becd",
"branch": "backport-14695-to-cloud-1.49",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2048.9539999999806,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.774999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.3,
"heapDeltaBytes": 5297292,
"heapUsedBytes": 73580080,
"domNodes": 20,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 20.232000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2027.5869999999827,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.825999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.461,
"heapDeltaBytes": 5292380,
"heapUsedBytes": 73755596,
"domNodes": 18,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 18.326,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1896.1040000000366,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.908,
"layouts": 12,
"layoutDurationMs": 4.171,
"taskDurationMs": 927.2839999999999,
"heapDeltaBytes": -22372348,
"heapUsedBytes": 45873512,
"domNodes": 60,
"jsHeapTotalBytes": 20430848,
"scriptDurationMs": 127.597,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1892.513000000008,
"styleRecalcs": 74,
"styleRecalcDurationMs": 36.017,
"layouts": 12,
"layoutDurationMs": 3.563,
"taskDurationMs": 926.536,
"heapDeltaBytes": -16112712,
"heapUsedBytes": 52025084,
"domNodes": -285,
"jsHeapTotalBytes": 20430848,
"scriptDurationMs": 127.19599999999997,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.6110000000003,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.665,
"layouts": 6,
"layoutDurationMs": 0.5190000000000001,
"taskDurationMs": 395.22599999999994,
"heapDeltaBytes": 7948992,
"heapUsedBytes": 76114272,
"domNodes": 74,
"jsHeapTotalBytes": 20303872,
"scriptDurationMs": 22.839,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1762.593000000038,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.301,
"layouts": 6,
"layoutDurationMs": 0.654,
"taskDurationMs": 393.51000000000005,
"heapDeltaBytes": 7950504,
"heapUsedBytes": 76021284,
"domNodes": 77,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 21.464,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 593.8249999999812,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.158000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.615,
"heapDeltaBytes": -12361196,
"heapUsedBytes": 55887016,
"domNodes": 18,
"jsHeapTotalBytes": 21090304,
"scriptDurationMs": 60.491,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 578.7649999999758,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.89,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.05,
"heapDeltaBytes": -12139432,
"heapUsedBytes": 56013308,
"domNodes": 20,
"jsHeapTotalBytes": 21352448,
"scriptDurationMs": 60.011,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.617000000011,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.123000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.999,
"heapDeltaBytes": 8574440,
"heapUsedBytes": 67699912,
"domNodes": -284,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 110.88999999999999,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.5719999999592,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.222000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 705.601,
"heapDeltaBytes": 2390952,
"heapUsedBytes": 61931512,
"domNodes": -284,
"jsHeapTotalBytes": 5038080,
"scriptDurationMs": 113.79999999999998,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2181.377999999995,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.713000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1328.608,
"heapDeltaBytes": 5453820,
"heapUsedBytes": 66162152,
"domNodes": -285,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 437.098,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2239.0830000000506,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.296999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1328.492,
"heapDeltaBytes": 5404536,
"heapUsedBytes": 65771952,
"domNodes": -286,
"jsHeapTotalBytes": 4739072,
"scriptDurationMs": 444.30199999999996,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3375.1890000000344,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.498999999999999,
"layouts": 60,
"layoutDurationMs": 7.5440000000000005,
"taskDurationMs": 1639.5689999999997,
"heapDeltaBytes": 6855684,
"heapUsedBytes": 68915432,
"domNodes": -288,
"jsHeapTotalBytes": 8183808,
"scriptDurationMs": 573.414,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3229.849999999942,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.542,
"layouts": 60,
"layoutDurationMs": 7.382000000000001,
"taskDurationMs": 1535.2379999999998,
"heapDeltaBytes": -1021540,
"heapUsedBytes": 60835924,
"domNodes": -287,
"jsHeapTotalBytes": 7921664,
"scriptDurationMs": 541.025,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.1690000000103,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.738000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 713.0289999999999,
"heapDeltaBytes": 8108708,
"heapUsedBytes": 69607844,
"domNodes": -284,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 115.583,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.4060000000181,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.418999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 708.8650000000001,
"heapDeltaBytes": 8136204,
"heapUsedBytes": 69501272,
"domNodes": -283,
"jsHeapTotalBytes": 3727360,
"scriptDurationMs": 116.61600000000001,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.8699999999953,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.269000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.014,
"heapDeltaBytes": -12249176,
"heapUsedBytes": 55945360,
"domNodes": 18,
"jsHeapTotalBytes": 22925312,
"scriptDurationMs": 123.009,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 628.1920000000127,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.970999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.605,
"heapDeltaBytes": -11569764,
"heapUsedBytes": 56652404,
"domNodes": 22,
"jsHeapTotalBytes": 21614592,
"scriptDurationMs": 122.43600000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2010.616999999968,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.176,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.09999999999997,
"heapDeltaBytes": 4998528,
"heapUsedBytes": 73395368,
"domNodes": 20,
"jsHeapTotalBytes": 19779584,
"scriptDurationMs": 15.725000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.4430000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.925000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.723,
"heapDeltaBytes": 4911896,
"heapUsedBytes": 73055212,
"domNodes": 18,
"jsHeapTotalBytes": 20041728,
"scriptDurationMs": 16.865000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.912999999986,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.6,
"layouts": 16,
"layoutDurationMs": 4.7589999999999995,
"taskDurationMs": 808.072,
"heapDeltaBytes": -4311188,
"heapUsedBytes": 63961252,
"domNodes": 64,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 95.974,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.3689999999297,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.916,
"layouts": 16,
"layoutDurationMs": 4.728,
"taskDurationMs": 805.57,
"heapDeltaBytes": -4453744,
"heapUsedBytes": 63873496,
"domNodes": 63,
"jsHeapTotalBytes": 20828160,
"scriptDurationMs": 94.514,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.7690000000016,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.889,
"layouts": 13,
"layoutDurationMs": 12.797999999999996,
"taskDurationMs": 958.2120000000001,
"heapDeltaBytes": 8652692,
"heapUsedBytes": 101180236,
"domNodes": 13673,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 37.12799999999998,
"eventListeners": 2375,
"totalBlockingTimeMs": 134,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8609.61100000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.882,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4810.822,
"heapDeltaBytes": 16954960,
"heapUsedBytes": 76285484,
"domNodes": -284,
"jsHeapTotalBytes": 8114176,
"scriptDurationMs": 1546.049,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8351.314999999999,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.791,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4611.378000000001,
"heapDeltaBytes": 12218680,
"heapUsedBytes": 71563692,
"domNodes": -283,
"jsHeapTotalBytes": 6279168,
"scriptDurationMs": 1424.002,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17375.372999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17337.963,
"heapDeltaBytes": -45772756,
"heapUsedBytes": 167345812,
"domNodes": -8312,
"jsHeapTotalBytes": -10690560,
"scriptDurationMs": 567.765,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17193.877999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17171.644999999997,
"heapDeltaBytes": -45095080,
"heapUsedBytes": 167069348,
"domNodes": -8312,
"jsHeapTotalBytes": -9117696,
"scriptDurationMs": 557.699,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20648.030000000006,
"styleRecalcs": 142,
"styleRecalcDurationMs": 17.461000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20613.703,
"heapDeltaBytes": -29149664,
"heapUsedBytes": 180017096,
"domNodes": -8312,
"jsHeapTotalBytes": -11284480,
"scriptDurationMs": 886.2869999999998,
"eventListeners": -16385,
"totalBlockingTimeMs": 161,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20562.633000000005,
"styleRecalcs": 140,
"styleRecalcDurationMs": 17.47500000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20537.923000000003,
"heapDeltaBytes": -22254228,
"heapUsedBytes": 186423116,
"domNodes": -8312,
"jsHeapTotalBytes": -8138752,
"scriptDurationMs": 841.8070000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 207,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 105.18700000000081,
"styleRecalcs": 10,
"styleRecalcDurationMs": 15.79,
"layouts": 2,
"layoutDurationMs": 0.477,
"taskDurationMs": 87.254,
"heapDeltaBytes": 3420468,
"heapUsedBytes": 70651692,
"domNodes": 121,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.936000000000002,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 453.6480000000438,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.962,
"layouts": 3,
"layoutDurationMs": 1.227,
"taskDurationMs": 119.80300000000001,
"heapDeltaBytes": -15650012,
"heapUsedBytes": 51555912,
"domNodes": 123,
"jsHeapTotalBytes": 6934528,
"scriptDurationMs": 10.101999999999999,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.49 #14899 +/- ##
=============================================
Coverage ? 78.77%
=============================================
Files ? 1791
Lines ? 104561
Branches ? 32070
=============================================
Hits ? 82364
Misses ? 21767
Partials ? 430
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Pull request was closed
Backport of #14695 to
cloud/1.49Automatically created by backport workflow.