Skip to content

[backport cloud/1.49] fix(ui): keep the button label readable while loading - #14846

Closed
comfy-pr-bot wants to merge 1 commit into
cloud/1.49from
backport-14695-to-cloud-1.49
Closed

comfy-pr-bot wants to merge 1 commit into
cloud/1.49from
backport-14695-to-cloud-1.49

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #14695 to cloud/1.49

Automatically created by backport workflow.

> **Stacked PR 2 of 5** — cloud auth redesign. Merge in order,
bottom-up.
>
> | | PR | What it does |
> |---|---|---|
> | 1 | #14694 | Dark theme, brand tokens, PP Formula shipped cloud-only
|
> | 2 | #14695 | Button keeps its label for screen readers while loading
|
> | 3 | #14696 | Brand button variants; login, sign-up and
forgot-password rebuilt on them |
> | 4 | #14697 | Logo, content and terms share one left edge |
> | 5 | #14698 | Static hero collage becomes a video carousel |

## Summary

The shared `Button` dropped its label while loading, so assistive tech
lost the control name for as long as the request was in flight.

## Changes

- **What**: Keeps the label in the accessibility tree via `sr-only`,
hides the decorative spinner from screen readers, and marks the control
`aria-busy` while loading. Visually unchanged.

## Review Focus

`Button.vue` is used app-wide, so the loading change is worth a look
beyond the cloud pages — the rendered output is identical, only the
accessibility tree differs.

This PR is now two files. The locale changes it originally carried moved
to the PRs that consume them (auth copy to #14696, carousel keys to
#14698), so no intermediate merge renders raw i18n keys.

Stacked on #14694.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Aug 6, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) August 6, 2026 16:41
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance

⚠️ Performance tests failed. Check the CI workflow logs.

@github-actions
github-actions Bot requested a review from benceruleanlu August 6, 2026 20:10
@MaanilVerma MaanilVerma closed this Aug 7, 2026
auto-merge was automatically disabled August 7, 2026 04:25

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants