Repository navigation
test: harden 82 Playwright specs for deterministic CI runs - #10967
Conversation
Replace weak nextFrame() readiness signals with proper wait boundaries: - errorsTab: wait for error overlay visibility and dismissal instead of single requestAnimationFrame after QueuePrompt - errorsTab: use toHaveCount(0) for v-if removed panels - errorsTabExecution: remove nextFrame() before overlay assertion - widget: poll node.imgs decode completion before screenshot Amp-Thread-ID: https://ampcode.com/threads/T-019d6ea8-817d-77d7-ae91-435622cbe554 Co-authored-by: Amp <amp@ampcode.com>
🎭 Playwright: ✅ 1029 passed, 0 failed · 1 flaky📊 Browser Reports
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughReplaces many one-shot frame waits and immediate evaluate/assert patterns in the E2E test suite with Playwright retry-safe constructs (expect.poll, locator expectations, contextMenu.waitForHidden); adds/adjusts fixtures and helpers (new getters, dialog click semantics); and adds flake-prevention documentation. No public runtime API changes. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook |
📦 Bundle: 5.13 MB gzip 🔴 +126 BDetailsSummary
Category Glance App Entry Points — 22.3 kB (baseline 22.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.2 MB (baseline 1.2 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 482 kB (baseline 482 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 109 kB (baseline 109 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 60.3 kB (baseline 60.3 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 2.98 MB (baseline 2.98 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 339 kB (baseline 339 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 14 unchanged Vendor & Third-Party — 9.8 MB (baseline 9.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.55 MB (baseline 8.55 MB) • ⚪ 0 BBundles that do not match a named category
Status: 56 added / 56 removed / 79 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-04-10T02:57:18.662Z",
"gitSha": "63dc7b125dc3c0a4394c5b1d65341325ca4fe02c",
"branch": "drjkl/harden-flaky-e2e-tests",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2032.2960000000307,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.334,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.666,
"heapDeltaBytes": 20237360,
"heapUsedBytes": 63184028,
"domNodes": 22,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 29.244,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2032.8430000000708,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.9,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.41900000000004,
"heapDeltaBytes": 20831772,
"heapUsedBytes": 63794860,
"domNodes": 22,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 28.926999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2064.1410000000633,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.563999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.56,
"heapDeltaBytes": 21028268,
"heapUsedBytes": 65167508,
"domNodes": 20,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 33.495,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2186.1690000000067,
"styleRecalcs": 86,
"styleRecalcDurationMs": 54.76,
"layouts": 12,
"layoutDurationMs": 4.239,
"taskDurationMs": 1190.741,
"heapDeltaBytes": 8086024,
"heapUsedBytes": 59464156,
"domNodes": 70,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 160.573,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1816.7909999999665,
"styleRecalcs": 75,
"styleRecalcDurationMs": 40.211,
"layouts": 12,
"layoutDurationMs": 3.66,
"taskDurationMs": 827.1820000000001,
"heapDeltaBytes": 6667704,
"heapUsedBytes": 58375080,
"domNodes": 59,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 139.853,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2075.016000000005,
"styleRecalcs": 83,
"styleRecalcDurationMs": 49.529,
"layouts": 12,
"layoutDurationMs": 3.7640000000000002,
"taskDurationMs": 1053.566,
"heapDeltaBytes": 16229516,
"heapUsedBytes": 59141068,
"domNodes": 68,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 149.635,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.1820000000184,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.428,
"layouts": 6,
"layoutDurationMs": 0.559,
"taskDurationMs": 381.772,
"heapDeltaBytes": 24671056,
"heapUsedBytes": 67583712,
"domNodes": 80,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 35.576,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.8779999999197,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.244999999999997,
"layouts": 6,
"layoutDurationMs": 0.7020000000000002,
"taskDurationMs": 382.235,
"heapDeltaBytes": 24724808,
"heapUsedBytes": 67286016,
"domNodes": 79,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 35.024,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1746.2009999999282,
"styleRecalcs": 30,
"styleRecalcDurationMs": 19.218000000000004,
"layouts": 6,
"layoutDurationMs": 0.7179999999999999,
"taskDurationMs": 373.606,
"heapDeltaBytes": 24635908,
"heapUsedBytes": 67409612,
"domNodes": 78,
"jsHeapTotalBytes": 21233664,
"scriptDurationMs": 33.778,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 594.2339999999717,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.849,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.053,
"heapDeltaBytes": 6513300,
"heapUsedBytes": 49034280,
"domNodes": 22,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 72.368,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 599.1600000000972,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.884,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.467,
"heapDeltaBytes": 6515312,
"heapUsedBytes": 49029164,
"domNodes": 22,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 74.58000000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 593.4819999999945,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.527000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.53799999999995,
"heapDeltaBytes": 6836528,
"heapUsedBytes": 49758064,
"domNodes": 20,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 69.434,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2009.775999999988,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.68,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.3430000000001,
"heapDeltaBytes": 13929280,
"heapUsedBytes": 65702648,
"domNodes": -258,
"jsHeapTotalBytes": 14667776,
"scriptDurationMs": 117.074,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2066.5629999999737,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.473999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 720.038,
"heapDeltaBytes": 18138144,
"heapUsedBytes": 68814164,
"domNodes": -257,
"jsHeapTotalBytes": 15241216,
"scriptDurationMs": 121.323,
"eventListeners": -121,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2042.8600000000188,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.087999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 712.6940000000002,
"heapDeltaBytes": 10045644,
"heapUsedBytes": 70005024,
"domNodes": -255,
"jsHeapTotalBytes": 16035840,
"scriptDurationMs": 122.051,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2147.222999999997,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.078999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1185.885,
"heapDeltaBytes": 17311912,
"heapUsedBytes": 71057696,
"domNodes": -262,
"jsHeapTotalBytes": 18223104,
"scriptDurationMs": 424.845,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2092.475000000036,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.768000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1212.142,
"heapDeltaBytes": 12417064,
"heapUsedBytes": 67274384,
"domNodes": -242,
"jsHeapTotalBytes": 16154624,
"scriptDurationMs": 464.51599999999996,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2178.2180000000153,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.183999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1216.416,
"heapDeltaBytes": 18138268,
"heapUsedBytes": 71399124,
"domNodes": -259,
"jsHeapTotalBytes": 17960960,
"scriptDurationMs": 434.711,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3179.300000000012,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.782,
"layouts": 60,
"layoutDurationMs": 7.691,
"taskDurationMs": 1449.7649999999999,
"heapDeltaBytes": 9525104,
"heapUsedBytes": 64652404,
"domNodes": -267,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 529.871,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3165.012000000047,
"styleRecalcs": 65,
"styleRecalcDurationMs": 17.282,
"layouts": 60,
"layoutDurationMs": 7.884,
"taskDurationMs": 1446.04,
"heapDeltaBytes": 7681836,
"heapUsedBytes": 62461964,
"domNodes": -268,
"jsHeapTotalBytes": 16969728,
"scriptDurationMs": 524.709,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3164.9060000000873,
"styleRecalcs": 65,
"styleRecalcDurationMs": 17.171000000000003,
"layouts": 60,
"layoutDurationMs": 7.948,
"taskDurationMs": 1432.384,
"heapDeltaBytes": 9327624,
"heapUsedBytes": 64474800,
"domNodes": -267,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 523.387,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2038.8829999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.419,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 689.4010000000002,
"heapDeltaBytes": 3974724,
"heapUsedBytes": 56574136,
"domNodes": -260,
"jsHeapTotalBytes": 15503360,
"scriptDurationMs": 121.20700000000001,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2033.6320000000114,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.056,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.967,
"heapDeltaBytes": 3284712,
"heapUsedBytes": 56598728,
"domNodes": -258,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 119.88600000000002,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.4430000000575,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 685.3359999999999,
"heapDeltaBytes": 2946284,
"heapUsedBytes": 56894140,
"domNodes": -263,
"jsHeapTotalBytes": 15134720,
"scriptDurationMs": 112.288,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.7240000000138,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.736,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.37600000000003,
"heapDeltaBytes": 8436788,
"heapUsedBytes": 57768760,
"domNodes": 20,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 133.469,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 570.3210000000354,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.481000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.74699999999996,
"heapDeltaBytes": 6761980,
"heapUsedBytes": 49592032,
"domNodes": 22,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 129.107,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.2729999999965,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.432000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.14500000000004,
"heapDeltaBytes": 8875952,
"heapUsedBytes": 58151188,
"domNodes": 22,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 129.679,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2016.2559999999985,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.639,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.097,
"heapDeltaBytes": -4759068,
"heapUsedBytes": 44545064,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 29.750999999999994,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2036.1710000000812,
"styleRecalcs": 12,
"styleRecalcDurationMs": 13.815000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.786,
"heapDeltaBytes": 19924796,
"heapUsedBytes": 63028512,
"domNodes": 24,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 27.521,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2000.454999999988,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.862999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.65200000000004,
"heapDeltaBytes": 10775284,
"heapUsedBytes": 62740516,
"domNodes": 22,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 28.170999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2017.7309999999693,
"styleRecalcs": 88,
"styleRecalcDurationMs": 52.989,
"layouts": 16,
"layoutDurationMs": 5.039,
"taskDurationMs": 998.0770000000001,
"heapDeltaBytes": 11558808,
"heapUsedBytes": 54650100,
"domNodes": 73,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 111.791,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2031.3190000000532,
"styleRecalcs": 87,
"styleRecalcDurationMs": 49.427,
"layouts": 16,
"layoutDurationMs": 4.489,
"taskDurationMs": 995.2299999999999,
"heapDeltaBytes": 11863432,
"heapUsedBytes": 54971112,
"domNodes": 73,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 111.775,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2006.2580000000025,
"styleRecalcs": 87,
"styleRecalcDurationMs": 49.262,
"layouts": 16,
"layoutDurationMs": 4.532,
"taskDurationMs": 992.1560000000001,
"heapDeltaBytes": 11899864,
"heapUsedBytes": 54971188,
"domNodes": 72,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 113.12,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8289.223999999991,
"styleRecalcs": 251,
"styleRecalcDurationMs": 45.766,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4469.420999999999,
"heapDeltaBytes": 5287764,
"heapUsedBytes": 57285424,
"domNodes": -257,
"jsHeapTotalBytes": 23318528,
"scriptDurationMs": 1565.413,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8228.967000000011,
"styleRecalcs": 252,
"styleRecalcDurationMs": 47.885,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4166.939,
"heapDeltaBytes": 25930104,
"heapUsedBytes": 76221576,
"domNodes": -255,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 1353.888,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8223.790000000008,
"styleRecalcs": 252,
"styleRecalcDurationMs": 47.221000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4331.586,
"heapDeltaBytes": 28180116,
"heapUsedBytes": 78829544,
"domNodes": -256,
"jsHeapTotalBytes": 21630976,
"scriptDurationMs": 1476.616,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12760.717999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12745.065,
"heapDeltaBytes": -18916184,
"heapUsedBytes": 165555548,
"domNodes": -8331,
"jsHeapTotalBytes": 22896640,
"scriptDurationMs": 625.5679999999999,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12849.070999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12827.190000000002,
"heapDeltaBytes": -32657548,
"heapUsedBytes": 164851688,
"domNodes": -8331,
"jsHeapTotalBytes": 26042368,
"scriptDurationMs": 631.3290000000001,
"eventListeners": -16460,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12988.286000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12967.095000000001,
"heapDeltaBytes": -30861488,
"heapUsedBytes": 166032680,
"domNodes": -8331,
"jsHeapTotalBytes": 27353088,
"scriptDurationMs": 664.703,
"eventListeners": -16466,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14824.56099999996,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.859999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14792.146,
"heapDeltaBytes": -19907488,
"heapUsedBytes": 173733872,
"domNodes": -8331,
"jsHeapTotalBytes": 25694208,
"scriptDurationMs": 912.643,
"eventListeners": -16458,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14643.62200000005,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.726999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14618.593,
"heapDeltaBytes": -38535344,
"heapUsedBytes": 172419132,
"domNodes": -5048,
"jsHeapTotalBytes": -5500928,
"scriptDurationMs": 945.761,
"eventListeners": -16458,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14881.934000000001,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.80799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14857.261,
"heapDeltaBytes": -59968036,
"heapUsedBytes": 148224540,
"domNodes": -8331,
"jsHeapTotalBytes": -2007040,
"scriptDurationMs": 924.519,
"eventListeners": -16490,
"totalBlockingTimeMs": 41,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 463.2290000000694,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.858999999999998,
"layouts": 5,
"layoutDurationMs": 1.6640000000000001,
"taskDurationMs": 133.486,
"heapDeltaBytes": 4742360,
"heapUsedBytes": 48999244,
"domNodes": 169,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.092999999999996,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 461.80100000003677,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.097,
"layouts": 5,
"layoutDurationMs": 1.543,
"taskDurationMs": 144.01899999999998,
"heapDeltaBytes": 4547028,
"heapUsedBytes": 48560576,
"domNodes": 158,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 34.74000000000001,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 463.6720000000878,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.476000000000003,
"layouts": 5,
"layoutDurationMs": 1.417,
"taskDurationMs": 126.76599999999996,
"heapDeltaBytes": 4516432,
"heapUsedBytes": 48232872,
"domNodes": 156,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 29.912000000000003,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #10967 +/- ##
=======================================
Coverage 43.23% 43.23%
=======================================
Files 1342 1342
Lines 68409 68409
Branches 18038 18038
=======================================
Hits 29574 29574
Misses 38245 38245
Partials 590 590 🚀 New features to boost your workflow:
|
Apply flake prevention patterns from FLAKE_PREVENTION_RULES.md: - Remove 16 redundant nextFrame() calls before retrying assertions (defaultKeybindings, focusMode, minimap, graphCanvasMenu, selectionToolboxActions, sidebar/workflows) - Replace dialog nextFrame() with proper dismiss waits (builderSaveFlow x10, builderReorder, errorOverlay) - Add nextFrame() before screenshots after setSetting (colorPalette x2, interaction) - Replace immediate assertions with expect.poll() (extensionAPI x3, commands x2, colorPalette toast, subgraphSearch) Amp-Thread-ID: https://ampcode.com/threads/T-019d6ea8-817d-77d7-ae91-435622cbe554 Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
🧹 Nitpick comments (3)
browser_tests/tests/extensionAPI.spec.ts (1)
159-159: Consider converting to polling for consistency.Line 159 remains an immediate assertion while the earlier
changeCountcheck on lines 150-152 was converted to polling. If the initial check needed polling to avoid flakiness, the second check aftertoggleBooleanSettingmight benefit from the same treatment for consistency—though the precedingtoggleBooleanSettingawait may provide sufficient implicit synchronization.Optional: convert to polling for consistency
- expect(await comfyPage.page.evaluate(() => window.changeCount)).toBe(2) + await expect + .poll(() => comfyPage.page.evaluate(() => window.changeCount)) + .toBe(2)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/extensionAPI.spec.ts` at line 159, The direct assertion expecting changeCount to be 2 can be flaky; replace the immediate check "expect(await comfyPage.page.evaluate(() => window.changeCount)).toBe(2)" with a polling/wait approach (e.g., use comfyPage.page.waitForFunction(() => window.changeCount === 2) or your test helper waitForCondition) after awaiting toggleBooleanSetting to ensure the value reaches 2 reliably; locate usages of comfyPage, toggleBooleanSetting, and the page.evaluate call and swap the immediate expect for a wait/poll then assert the resolved value.browser_tests/tests/builderSaveFlow.spec.ts (1)
125-125: Optional: extract a small helper for repeated dismiss-and-wait flow.Same two-step pattern is repeated many times; a helper would reduce duplication and future drift.
♻️ Suggested refactor
+async function closeSaveSuccessDialogAndWaitHidden(appMode: AppModeHelper) { + await appMode.saveAs.closeButton.click() + await expect(appMode.saveAs.successDialog).not.toBeVisible() +} // usage examples - await saveAs.closeButton.click() - await expect(saveAs.successDialog).not.toBeVisible() + await closeSaveSuccessDialogAndWaitHidden(comfyPage.appMode)As per coding guidelines: "Whenever new code is written, ask if there's a simpler way to introduce the same functionality; choose the simpler course."
Also applies to: 147-147, 181-181, 273-273, 285-285, 329-329, 345-345, 361-361
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/builderSaveFlow.spec.ts` at line 125, The test repeats the same "dismiss-and-wait" assertion pattern (e.g., awaiting saveAs.successDialog to not be visible via await expect(saveAs.successDialog).not.toBeVisible()) across multiple lines; extract a small helper function (e.g., dismissAndAwaitHidden or saveDialog.dismissAndWait) that encapsulates the two-step flow (triggering the dismiss and awaiting saveAs.successDialog to be hidden) and replace the repeated occurrences at lines referencing saveAs.successDialog (and their equivalents at the other locations) with calls to that helper to reduce duplication and keep the intent clear.browser_tests/tests/colorPalette.spec.ts (1)
181-181:toBe(0)polling here may still miss delayed error toasts.This can pass on the first check before async error reporting settles. Prefer a short stability window (two checks across a frame) if the intent is “no error toast appears.”
Based on learnings: Refer to `browser_tests/FLAKE_PREVENTION_RULES.md` when triaging or editing flaky browser tests.Suggested change
- await expect.poll(() => comfyPage.toast.getToastErrorCount()).toBe(0) + await expect(async () => { + expect(await comfyPage.toast.getToastErrorCount()).toBe(0) + await comfyPage.nextFrame() + expect(await comfyPage.toast.getToastErrorCount()).toBe(0) + }).toPass({ timeout: 1500 })🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/colorPalette.spec.ts` at line 181, The single polling check using expect.poll(() => comfyPage.toast.getToastErrorCount()).toBe(0) can race with delayed error toasts; change it to a short stability-window check that reads comfyPage.toast.getToastErrorCount() twice across a frame (e.g., read, await a small tick/frame delay, read again) and only succeed if both reads are 0; update the assertion around comfyPage.toast.getToastErrorCount() to perform that two-read stability check (using comfyPage.page.waitForTimeout or a frame/wait helper) before asserting 0.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@browser_tests/tests/builderSaveFlow.spec.ts`:
- Line 125: The test repeats the same "dismiss-and-wait" assertion pattern
(e.g., awaiting saveAs.successDialog to not be visible via await
expect(saveAs.successDialog).not.toBeVisible()) across multiple lines; extract a
small helper function (e.g., dismissAndAwaitHidden or saveDialog.dismissAndWait)
that encapsulates the two-step flow (triggering the dismiss and awaiting
saveAs.successDialog to be hidden) and replace the repeated occurrences at lines
referencing saveAs.successDialog (and their equivalents at the other locations)
with calls to that helper to reduce duplication and keep the intent clear.
In `@browser_tests/tests/colorPalette.spec.ts`:
- Line 181: The single polling check using expect.poll(() =>
comfyPage.toast.getToastErrorCount()).toBe(0) can race with delayed error
toasts; change it to a short stability-window check that reads
comfyPage.toast.getToastErrorCount() twice across a frame (e.g., read, await a
small tick/frame delay, read again) and only succeed if both reads are 0; update
the assertion around comfyPage.toast.getToastErrorCount() to perform that
two-read stability check (using comfyPage.page.waitForTimeout or a frame/wait
helper) before asserting 0.
In `@browser_tests/tests/extensionAPI.spec.ts`:
- Line 159: The direct assertion expecting changeCount to be 2 can be flaky;
replace the immediate check "expect(await comfyPage.page.evaluate(() =>
window.changeCount)).toBe(2)" with a polling/wait approach (e.g., use
comfyPage.page.waitForFunction(() => window.changeCount === 2) or your test
helper waitForCondition) after awaiting toggleBooleanSetting to ensure the value
reaches 2 reliably; locate usages of comfyPage, toggleBooleanSetting, and the
page.evaluate call and swap the immediate expect for a wait/poll then assert the
resolved value.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 797ea17b-7047-4746-939b-7cb385f6a981
📒 Files selected for processing (14)
browser_tests/tests/builderReorder.spec.tsbrowser_tests/tests/builderSaveFlow.spec.tsbrowser_tests/tests/colorPalette.spec.tsbrowser_tests/tests/commands.spec.tsbrowser_tests/tests/defaultKeybindings.spec.tsbrowser_tests/tests/errorOverlay.spec.tsbrowser_tests/tests/extensionAPI.spec.tsbrowser_tests/tests/focusMode.spec.tsbrowser_tests/tests/graphCanvasMenu.spec.tsbrowser_tests/tests/interaction.spec.tsbrowser_tests/tests/minimap.spec.tsbrowser_tests/tests/selectionToolboxActions.spec.tsbrowser_tests/tests/sidebar/workflows.spec.tsbrowser_tests/tests/subgraph/subgraphSearch.spec.ts
💤 Files with no reviewable changes (6)
- browser_tests/tests/focusMode.spec.ts
- browser_tests/tests/graphCanvasMenu.spec.ts
- browser_tests/tests/minimap.spec.ts
- browser_tests/tests/defaultKeybindings.spec.ts
- browser_tests/tests/sidebar/workflows.spec.ts
- browser_tests/tests/selectionToolboxActions.spec.ts
Amp-Thread-ID: https://ampcode.com/threads/T-019d6ed1-119b-73dd-aa1c-2b6691c1d520 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d6ed1-119b-73dd-aa1c-2b6691c1d520 Co-authored-by: Amp <amp@ampcode.com>
- Toggle test: identify target node by proximity (non-deterministic order), use programmatic collapse() for re-expand (canvas click unreliable on collapsed nodes due to DOM widget overlay interference) - Prompt dialog tests: retry dismiss click via toPass() to handle LiteGraph's 256ms graphdialog dismiss guard (Date.now() - clickTime > 256) Amp-Thread-ID: https://ampcode.com/threads/T-019d6f0d-e0c1-74fb-9b6c-2ffbffb7aa15 Co-authored-by: Amp <amp@ampcode.com>
…e-tests Amp-Thread-ID: https://ampcode.com/threads/T-019d6f0d-e0c1-74fb-9b6c-2ffbffb7aa15 Co-authored-by: Amp <amp@ampcode.com> # Conflicts: # browser_tests/tests/subgraph/subgraphSearch.spec.ts
|
Updating Playwright Expectations |
Wait for context menu entry to be hidden after click instead of nextFrame(), confirming the promote action completed before exiting the subgraph. Amp-Thread-ID: https://ampcode.com/threads/T-019d6f0d-e0c1-74fb-9b6c-2ffbffb7aa15 Co-authored-by: Amp <amp@ampcode.com>
…screenshot readiness) Replace ~137 flake-prone assertion sites across 28 E2E spec files: - Immediate graph/link state assertions after drag/drop → expect.poll - nextFrame after context menu clicks → contextMenu.waitForHidden - Fake readiness helpers (mouse click as wait) → poll actual state - Tight poll timeouts (250ms) → 2000ms+ - Immediate count()/evaluate after mutations → retrying assertions - Missing waitForNodes before screenshots - Document 8 common flake patterns in FLAKE_PREVENTION_RULES.md §7 Amp-Thread-ID: https://ampcode.com/threads/T-019d6f7d-be8c-778b-a3e9-c6ff01066d82 Co-authored-by: Amp <amp@ampcode.com>
… vs last interval Amp-Thread-ID: https://ampcode.com/threads/T-019d6f7d-be8c-778b-a3e9-c6ff01066d82 Co-authored-by: Amp <amp@ampcode.com>
…cheduler Amp-Thread-ID: https://ampcode.com/threads/T-019d6f7d-be8c-778b-a3e9-c6ff01066d82 Co-authored-by: Amp <amp@ampcode.com>
| @@ -162,7 +170,6 @@ test.describe('Builder save flow', { tag: ['@ui'] }, () => { | |||
|
|
|||
| // State 1: Disabled "Save as" (no outputs selected) | |||
| const disabledBox = await appMode.footer.saveAsButton.boundingBox() | |||
There was a problem hiding this comment.
issue: disabledBox can be null here -- boundingBox() returns null when the element has no visible layout. The old code had expect(disabledBox).toBeTruthy() as a guard; removing it means the ! assertion on line 185 throws a TypeError instead of a clear test failure. Consider adding await expect.poll(() => appMode.footer.saveAsButton.boundingBox()).not.toBeNull() before capturing the value, or wrapping the capture inside the poll callback.
There was a problem hiding this comment.
Good catch — the disabledBox null guard is already in place (lines 174–175 throw with a clear message). This was addressed in an earlier commit. Let me know if you're seeing something different on your end.
| })) | ||
| ) | ||
|
|
||
| await expect.poll(getGroupPositions).toHaveLength(2) |
There was a problem hiding this comment.
suggestion: (non-blocking) The three sequential expect.poll(getGroupPositions) calls each independently re-fetch positions, so a shift between polls could cause a false pass, and on failure the timeouts cascade (3x default). A single expect(async () => { ... }).toPass() block that fetches once per retry and asserts length + dx + dy together would be tighter.
There was a problem hiding this comment.
Good suggestion — consolidated the three sequential expect.poll(getGroupPositions) calls into a single toPass() block that fetches once per retry and asserts both dx and dy together. Fixed in 17bb341.
| await expect(gutter).toBeVisible() | ||
| const box = await gutter.boundingBox() | ||
| expect(box).not.toBeNull() | ||
| let box: Awaited<ReturnType<typeof gutter.boundingBox>> = null |
There was a problem hiding this comment.
suggestion: (non-blocking) Setting box via side-effect inside the poll callback couples polling with imperative mutation. Consider splitting into two steps: first await expect.poll(() => gutter.boundingBox()).not.toBeNull(), then const box = await gutter.boundingBox()!. Same pattern appears in subgraphSlots.spec.ts and subgraphPromotion.spec.ts.
There was a problem hiding this comment.
Agreed — split into a clean poll-for-not-null followed by a separate capture. No more side-effect mutation inside the poll callback. Fixed in 17bb341.
| await modal.waitFor({ state: 'hidden' }) | ||
| } | ||
|
|
||
| get domWidgets(): Locator { |
There was a problem hiding this comment.
suggestion: (non-blocking) domWidgets is added but has no call-sites in this PR. getDOMWidgetCount() right below duplicates the same .dom-widget selector instead of delegating to this.domWidgets.count(). Same applies to toastErrors in ToastHelper.ts vs getToastErrorCount(). Consider either wiring up the call-sites or deferring these getters to a follow-up.
There was a problem hiding this comment.
domWidgets does have call-sites — it's used in domWidget.spec.ts (lines 45 and 55). Similarly, toastErrors is used in 4 specs (changeTracker, colorPalette, commands, toastNotifications). Neither getDOMWidgetCount nor getToastErrorCount exist — the locator getters are the primary API. No change needed here.
| await expect | ||
| .poll( | ||
| async () => { | ||
| const expanded = await select.getAttribute('aria-expanded') |
There was a problem hiding this comment.
suggestion: (non-blocking) click() inside expect.poll() is a write side-effect in what should be a read-only probe. The PR's own convention elsewhere is expect(async () => { ... }).toPass() for "retry action + assert together". Converting this would be more consistent with the rest of the changes.
There was a problem hiding this comment.
Good catch — converted from expect.poll() (which should be read-only) to toPass() to match the PR's own convention for retry-action-then-assert. Fixed in 17bb341.
- groupCopyPaste: consolidate 3 sequential polls into single toPass() block - sidebarSplitterWidth: split poll-then-capture to avoid side-effect mutation - settingsDialog: convert expect.poll() with click() to toPass() for consistency Amp-Thread-ID: https://ampcode.com/threads/T-019d753c-d73f-722e-960d-46c18505d027 Co-authored-by: Amp <amp@ampcode.com>
When a node is collapsed, DOM widget overlays could intercept pointer events during the timing gap between canvas state update and Vue DOM update. Adding !widgetState.visible to the pointerEvents condition in composeStyle() prevents this by immediately setting pointer-events to none when the widget becomes invisible. Also restores click-to-expand in the E2E test, removing the programmatic workaround from PR #10967. Fixes #11006
## Problem When a node with DOM widget overlays (e.g. CLIPTextEncode) is collapsed, the overlay elements can intercept pointer events intended for the canvas collapse toggler, making click-to-expand unreliable. ## Root Cause `updateWidgets()` runs during `onDrawForeground` (canvas render cycle) and sets `widgetState.visible = false` for collapsed nodes. `v-show` then hides the element with `display: none`. However, there is a timing gap between the canvas state change and Vue's DOM update — during this gap the widget overlay still intercepts pointer events. ## Fix Add `!widgetState.visible` to the `pointerEvents` condition in `composeStyle()`. This immediately sets `pointer-events: none` when the widget becomes invisible, preventing event interception before `v-show` applies `display: none`. Also restores click-to-expand in the E2E test, removing the programmatic `node.collapse()` workaround from PR #10967. - Fixes #11006 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11063-fix-disable-pointer-events-on-non-visible-DOM-widget-overlays-33e6d73d36508179a83cd47121cf933f) by [Unito](https://www.unito.io)
…sset detection (#10856) Cherry-pick of 521019d onto core/1.43. Manual conflict resolution on two files, both limited to the `cleanupFakeModel` helper extraction: - browser_tests/tests/errorOverlay.spec.ts - browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts core/1.43 base still had the inline `expect(cleanupOk).toBeTruthy()` implementation; main's version (post-#10967) uses `expect.poll()` inline; #10856 replaced both with `await cleanupFakeModel(comfyPage)` calling the new helper in ErrorsTabHelper.ts. Conflict resolved by accepting the PR version (helper call) on both files, since the new helper is added in this same commit.
…sset detection (#10856) (#11217) Manual backport of #10856 to `core/1.43`. ## Conflicts resolved Two files had trivial conflicts from the same root cause — #10856 extracted the inline `cleanup_fake_model` block into a shared `cleanupFakeModel` helper in `browser_tests/tests/propertiesPanel/ErrorsTabHelper.ts`: - `browser_tests/tests/errorOverlay.spec.ts` - `browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts` `core/1.43` still carries the original inline `expect(cleanupOk).toBeTruthy()` form. main's version (post-#10967) uses an inline `expect.poll()` instead. #10856 replaces both with `await cleanupFakeModel(comfyPage)` calling the helper added by this same PR. Resolution: accepted the PR version (helper call) on both conflict sites. The helper itself is added as part of this backport, so no runtime behavior is lost. ## Verification - No residual conflict markers - Cherry-picked commit carries the entire #10856 squash (45 files, +3596/-209) ## Original PR summary See #10856 for full behavioral description, test plan, and screenshots. --- Fixes Comfy-Org/ComfyUI#13256 on core/1.43 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11217-backport-core-1-43-fix-exclude-muted-bypassed-nodes-from-missing-asset-detection-10-3426d73d365081f0becbcf7d909f0021) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
…idget overlays (#11063) (#11859) *PR Created by the Glary-Bot Agent* --- Manual backport of #11063 to `core/1.43` for inclusion in `v1.43.16`. Cherry-picked from upstream merge commit `4cf160d66`. ## Why When a node with DOM widget overlays (e.g. CLIPTextEncode) is collapsed, the overlay elements can intercept pointer events intended for the canvas collapse toggler, making click-to-expand unreliable. Adds `!widgetState.visible` to the `pointerEvents` condition in `composeStyle()`, immediately setting `pointer-events: none` when the widget becomes invisible — closing the timing gap before `v-show` applies `display: none`. Fixes upstream issue #11006. ## Conflict resolution - Skipped the change to `browser_tests/tests/interaction.spec.ts`. PR #11063 removed a programmatic-collapse workaround introduced by unrelated PR #10967 (which is **not** on `core/1.43`). On 1.43 the test uses an older `delay(1000) + click` form that doesn't need adjustment — the source fix in `DomWidget.vue` makes the second click reliable on its own. Kept the source + unit-test changes. ## Validation - `pnpm typecheck` ✅ - `pnpm test:unit -- run src/components/graph/widgets/DomWidget.test.ts` ✅ (2/2 passing) - `pnpm exec eslint <changed files>` ✅ (0 errors) - `pnpm exec oxfmt --check` ✅ (clean) Manual end-to-end verification not performed — DOM widget pointer-event timing requires live canvas+widget interaction, not feasible to reproduce reliably in headless. Source identical to upstream `4cf160d66`, baking on `main` for ~3 weeks through `v1.44.x`. Original PR: #11063 / Original commit: `4cf160d66` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11859-backport-core-1-43-fix-disable-pointer-events-on-non-visible-DOM-widget-overlays-11-3556d73d365081cab95ef32c17c0401e) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
## Problem When a node with DOM widget overlays (e.g. CLIPTextEncode) is collapsed, the overlay elements can intercept pointer events intended for the canvas collapse toggler, making click-to-expand unreliable. ## Root Cause `updateWidgets()` runs during `onDrawForeground` (canvas render cycle) and sets `widgetState.visible = false` for collapsed nodes. `v-show` then hides the element with `display: none`. However, there is a timing gap between the canvas state change and Vue's DOM update — during this gap the widget overlay still intercepts pointer events. ## Fix Add `!widgetState.visible` to the `pointerEvents` condition in `composeStyle()`. This immediately sets `pointer-events: none` when the widget becomes invisible, preventing event interception before `v-show` applies `display: none`. Also restores click-to-expand in the E2E test, removing the programmatic `node.collapse()` workaround from PR #10967. - Fixes #11006 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11063-fix-disable-pointer-events-on-non-visible-DOM-widget-overlays-33e6d73d36508179a83cd47121cf933f) by [Unito](https://www.unito.io) (cherry picked from commit 4cf160d)
## Problem When a node with DOM widget overlays (e.g. CLIPTextEncode) is collapsed, the overlay elements can intercept pointer events intended for the canvas collapse toggler, making click-to-expand unreliable. ## Root Cause `updateWidgets()` runs during `onDrawForeground` (canvas render cycle) and sets `widgetState.visible = false` for collapsed nodes. `v-show` then hides the element with `display: none`. However, there is a timing gap between the canvas state change and Vue's DOM update — during this gap the widget overlay still intercepts pointer events. ## Fix Add `!widgetState.visible` to the `pointerEvents` condition in `composeStyle()`. This immediately sets `pointer-events: none` when the widget becomes invisible, preventing event interception before `v-show` applies `display: none`. Also restores click-to-expand in the E2E test, removing the programmatic `node.collapse()` workaround from PR #10967. - Fixes #11006 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11063-fix-disable-pointer-events-on-non-visible-DOM-widget-overlays-33e6d73d36508179a83cd47121cf933f) by [Unito](https://www.unito.io) (cherry picked from commit 4cf160d)
## Summary
Harden 98 E2E spec files and 8 fixtures/helpers for deterministic CI
runs by replacing race-prone patterns with retry-safe alternatives.
No source code changes -- only `browser_tests/` is touched.
## Changes
- **E2E spec hardening** (98 spec files, 6 fixtures, 2 helpers):
| Fix class | Sites | Examples |
|-----------|-------|---------:|
| `expect(await ...)` -> `expect.poll()` | ~153 | interaction,
defaultKeybindings, workflows, featureFlags |
| `const x = await loc.count(); expect(x)` -> `toHaveCount()` | ~19 |
menu, linkInteraction, assets, bottomPanelShortcuts |
| `nextFrame()` -> `waitForHidden()` after menu clicks | ~22 |
contextMenu, rightClickMenu, subgraphHelper |
| Redundant `nextFrame()` removed | many | defaultKeybindings, minimap,
builderSaveFlow |
| `expect(async () => { ... }).toPass()` retry blocks | 5 | interaction
(graphdialog dismiss guard) |
| `force:true` removed from `BaseDialog.close()` | 1 | BaseDialog
fixture |
| ContextMenu `waitForHidden` simplified (check-then-act race removed) |
1 | ContextMenu fixture |
| Non-deterministic node order -> proximity-based selection | 1 |
interaction (toggle dom widget) |
| Tight poll timeout (250ms) -> >=2000ms | 2 | templates |
- **Helper improvements**: Exposed locator getters on
`ComfyPage.domWidgets`, `ToastHelper.toastErrors`, and
`WorkflowsSidebarTab.activeWorkflowLabel` so callers can use retrying
assertions (`toHaveCount()`, `toHaveText()`) directly.
- **Flake pattern catalog**: Added section 7 table to
`browser_tests/FLAKE_PREVENTION_RULES.md` documenting 8 pattern classes
for reviewers and future authors.
- **Docs**: Fixed bad examples in `browser_tests/README.md` to use
`expect.poll()`.
- **Breaking**: None
- **Dependencies**: None
## Review Focus
- All fixes follow the rules in
`browser_tests/FLAKE_PREVENTION_RULES.md`
- No behavioral changes to tests -- only timing/retry strategy is
updated
- The `ContextMenu.waitForHidden` simplification removes a
swallowed-error anti-pattern; both locators now use direct `waitFor({
state: 'hidden' })`
---------
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: github-actions <github-actions@github.com>
## Problem When a node with DOM widget overlays (e.g. CLIPTextEncode) is collapsed, the overlay elements can intercept pointer events intended for the canvas collapse toggler, making click-to-expand unreliable. ## Root Cause `updateWidgets()` runs during `onDrawForeground` (canvas render cycle) and sets `widgetState.visible = false` for collapsed nodes. `v-show` then hides the element with `display: none`. However, there is a timing gap between the canvas state change and Vue's DOM update — during this gap the widget overlay still intercepts pointer events. ## Fix Add `!widgetState.visible` to the `pointerEvents` condition in `composeStyle()`. This immediately sets `pointer-events: none` when the widget becomes invisible, preventing event interception before `v-show` applies `display: none`. Also restores click-to-expand in the E2E test, removing the programmatic `node.collapse()` workaround from PR #10967. - Fixes #11006 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11063-fix-disable-pointer-events-on-non-visible-DOM-widget-overlays-33e6d73d36508179a83cd47121cf933f) by [Unito](https://www.unito.io)
Summary
Harden 98 E2E spec files and 8 fixtures/helpers for deterministic CI runs by replacing race-prone patterns with retry-safe alternatives.
No source code changes -- only
browser_tests/is touched.Changes
E2E spec hardening (98 spec files, 6 fixtures, 2 helpers):
expect(await ...)->expect.poll()const x = await loc.count(); expect(x)->toHaveCount()nextFrame()->waitForHidden()after menu clicksnextFrame()removedexpect(async () => { ... }).toPass()retry blocksforce:trueremoved fromBaseDialog.close()waitForHiddensimplified (check-then-act race removed)Helper improvements: Exposed locator getters on
ComfyPage.domWidgets,ToastHelper.toastErrors, andWorkflowsSidebarTab.activeWorkflowLabelso callers can use retrying assertions (toHaveCount(),toHaveText()) directly.Flake pattern catalog: Added section 7 table to
browser_tests/FLAKE_PREVENTION_RULES.mddocumenting 8 pattern classes for reviewers and future authors.Docs: Fixed bad examples in
browser_tests/README.mdto useexpect.poll().Breaking: None
Dependencies: None
Review Focus
browser_tests/FLAKE_PREVENTION_RULES.mdContextMenu.waitForHiddensimplification removes a swallowed-error anti-pattern; both locators now use directwaitFor({ state: 'hidden' })