Skip to content

fix: exclude muted/bypassed nodes from missing asset detection - #10856

Merged
jaeone94 merged 28 commits into
mainfrom
feat/muted-bypass-missing-asset-filter
Apr 13, 2026
Merged

jaeone94 merged 28 commits into
mainfrom
feat/muted-bypass-missing-asset-filter

Conversation

@jaeone94

@jaeone94 jaeone94 commented Apr 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Muted and bypassed nodes are excluded from execution but were still triggering missing model/media/node warnings. This PR makes the error system mode-aware: muted/bypassed nodes no longer produce missing asset errors, and all error lifecycle events (mode toggle, deletion, paste, undo, tab switch) are handled consistently.

Behavioral notes

  • Tab switch overlay suppression (intentional): Switching back to a workflow with missing assets no longer re-shows the error overlay. This reverses the behavior introduced in test: update E2E to expect missing nodes overlay on tab switch #10190. The error state is still restored silently in the errors tab — users can access it via the properties panel without being interrupted by the overlay on every tab switch.

Changes

1. Scan filtering

  • scanAllModelCandidates, scanAllMediaCandidates, scanMissingNodes: skip nodes with mode === NEVER || BYPASS
  • collectMissingNodes (serialized data): skip error reporting for muted/bypassed nodes while still calling sanitizeNodeName for safe configure()
  • collectEmbeddedModelsWithSource: skip muted/bypassed nodes; workflow-level graphData.models only create candidates when active nodes exist
  • enrichWithEmbeddedMetadata: filter unmatched workflow-level models when all referencing nodes are inactive

2. Realtime mode change handling

  • useErrorClearingHooks.ts chains graph.onTrigger to detect node:property:changed (mode)
  • Deactivation (active → muted/bypassed): remove missing model/media/node errors for the node
  • Activation (muted/bypassed → active): scan the node and add confirmed errors, show overlay
  • Subgraph container deactivation: remove all interior node errors (execution ID prefix match)
  • Subgraph container activation: scan all active interior nodes recursively
  • Subgraph interior mode change: resolve node via localGraph.getNodeById() then compute execution ID from root graph

3. Node deletion

  • graph.onNodeRemoved: remove missing model/media/node errors for the deleted node
  • Handle node.graph === null at callback time by using String(node.id) for root-level nodes

4. Node paste/duplicate

  • graph.onNodeAdded: scan via queueMicrotask (deferred until after node.configure() restores widget values)
  • Guard: skip during ChangeTracker.isLoadingGraph (undo/redo/tab switch handled by pipeline)
  • Guard: skip muted/bypassed nodes

5. Workflow tab switch optimization

  • skipAssetScans option in loadGraphData: skip full pipeline on tab switch
  • Cache missing model/media/node state per workflow via PendingWarnings
  • beforeLoadNewGraph: save current store state to outgoing workflow's pendingWarnings
  • showPendingWarnings: restore cached errors silently (no overlay), always sync missing nodes store (even when null)
  • Preserve UI state (fileSizes, urlInputs) on tab switch by using setMissingModels([]) instead of clearMissingModels()
  • MissingModelRow.vue: fetch file size on mount via fetchModelMetadata memory cache

6. Undo/redo overlay suppression

  • silentAssetErrors option propagated through pipeline → surfaceMissingModels/surfaceMissingMedia { silent } option
  • showPendingWarnings { silent } option for missing nodes overlay
  • changeTracker.ts: pass silentAssetErrors: true on undo/redo

7. Error tab node filtering

  • Selected node filters missing model/media card contents (not just group visibility)
  • isAssetErrorInSelection: resolve execution ID → graph node for selection matching
  • Missing nodes intentionally unfiltered (pack-level scope)
  • hasMissingMediaSelected added to RightSidePanel.vue error tab visibility
  • Download All button: show only when 2+ downloadable models exist

8. New store functions

  • missingModelStore: addMissingModels, removeMissingModelsByNodeId
  • missingMediaStore: addMissingMedia, removeMissingMediaByNodeId
  • missingNodesErrorStore: removeMissingNodesByNodeId
  • missingModelScan: scanNodeModelCandidates (extracted single-node scan)
  • missingMediaScan: scanNodeMediaCandidates (extracted single-node scan)

9. Test infrastructure improvements

  • data-testid on RightSidePanel.vue tabs (panel-tab-{value})
  • Error-related TestIds moved from dialogs to errorsTab namespace in selectors.ts
  • Removed unused TestIdValue type
  • Extracted cleanupFakeModel to shared ErrorsTabHelper.ts
  • Renamed openErrorsTabViaSeeErrors → loadWorkflowAndOpenErrorsTab
  • Added aria-label to pencil edit button and subgraph toggle button

Test plan

Unit tests (41 new)

  • Store functions: addMissing*, removeMissing*ByNodeId
  • executionErrorStore: surfaceMissing* silent option
  • Scan functions: muted/bypassed filtering, scanNodeModelCandidates, scanNodeMediaCandidates
  • workflowService: showPendingWarnings silent, beforeLoadNewGraph caching

E2E tests (17 new in errorsTabModeAware.spec.ts)

Missing nodes

  • Deleting a missing node removes its error from the errors tab
  • Undo after bypass restores error without showing overlay

Missing models

  • Loading a workflow with all nodes bypassed shows no errors
  • Bypassing a node hides its error, un-bypassing restores it
  • Deleting a node with missing model removes its error
  • Undo after bypass restores error without showing overlay
  • Pasting a node with missing model increases referencing node count
  • Pasting a bypassed node does not add a new error
  • Selecting a node filters errors tab to only that node

Missing media

  • Loading a workflow with all nodes bypassed shows no errors
  • Bypassing a node hides its error, un-bypassing restores it
  • Pasting a bypassed node does not add a new error
  • Selecting a node filters errors tab to only that node

Subgraph

  • Bypassing a subgraph hides interior errors, un-bypassing restores them
  • Bypassing a node inside a subgraph hides its error, un-bypassing restores it

Workflow switching

  • Does not resurface error overlay when switching back to workflow with missing nodes
  • Restores missing nodes in errors tab when switching back to workflow

Screenshots

2026-04-12.7.14.23.mov

Follow-up work

  • Extract error-detection computed properties from RightSidePanel.vue into a composable (e.g. useErrorsTabVisibility)

jaeone94 added 6 commits April 5, 2026 23:31
- Skip muted (NEVER) and bypassed (BYPASS) nodes in missing model,
  media, and node scans across all code paths (live graph, embedded
  metadata enrichment, serialized graph collection)
- React to node mode changes: remove errors when deactivated, rescan
  when activated
- Remove missing asset errors on node deletion
- Scan pasted/duplicated nodes for missing assets (deferred to
  microtask so widget values are configured)
- Cache missing model/media/node state per workflow via
  PendingWarnings for tab-switch restore without rescanning
- Skip full scan pipeline on workflow tab switch (skipAssetScans);
  restore cached results silently (no error overlay)
- Suppress error overlay on undo/redo (silentAssetErrors) while
  still updating error state
- Filter error tab groups by selected node so only relevant missing
  asset cards are shown
- Add hasMissingMediaSelected check to RightSidePanel error tab
  visibility

Fixes Comfy-Org/ComfyUI#13256
When a node is selected, missing node/model/media error cards now
show only the entries relevant to that node instead of all entries.
Filtered computed properties regroup candidates per selection.
- Filter missing model/media card contents by selected node;
  missing nodes are intentionally unfiltered (pack-level scope)
- Show Download All button only when 2+ downloadable models exist
- Fetch file sizes on MissingModelRow mount so tab-switch cache
  restores display sizes via fetchModelMetadata memory cache
- Preserve UI state (fileSizes, urlInputs) on tab switch by using
  setMissingModels([]) instead of clearMissingModels()
- Always sanitize unregistered node types before configure, even for
  bypassed nodes, to prevent placeholder errors on subgraph entry
- Skip scanning bypassed nodes in onNodeAdded (triggered by
  useGraphNodeManager init on subgraph entry)
- Resolve mode change events using the local graph that fired the
  event, not the root graph, so subgraph interior nodes are found
- Remove interior node errors when a subgraph container is bypassed
  (prefix match on execution ID)
- Scan all active interior nodes when a subgraph container is
  activated
showPendingWarnings early-returned when pendingWarnings was null,
skipping the surfaceMissingNodes([]) call needed to clear stale
missing node entries from the store after undo.
- missingModelStore: addMissingModels, removeMissingModelsByNodeId
- missingMediaStore: addMissingMedia, removeMissingMediaByNodeId
- missingNodesErrorStore: removeMissingNodesByNodeId
- executionErrorStore: surfaceMissingModels/Media silent option
- missingNodeScan: muted/bypassed node filtering
- missingModelScan: scanNodeModelCandidates direct tests
- missingMediaScan: scanNodeMediaCandidates direct tests
- workflowService: showPendingWarnings silent, beforeLoadNewGraph cache
@coderabbitai

coderabbitai Bot commented Apr 5, 2026 •

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds node-mode–aware scanning and per-node scanner helpers, selection-aware filtering for missing models/media, store actions to add/remove candidates by node ID, hooks to rescan/clear on node changes, pipeline/UI changes to cache/surface pending warnings with a silent option, and updated tests and fixtures.

Changes

Cohort / File(s) Summary
Per-node scanners & mode filtering
src/platform/missingModel/missingModelScan.ts, src/platform/missingMedia/missingMediaScan.ts, src/platform/nodeReplacement/missingNodeScan.ts
Skip nodes with LGraphEventMode.NEVER/BYPASS; extract scanNodeModelCandidates and scanNodeMediaCandidates; adjust enrichment to consider only active nodes.
Missing-asset stores (actions)
src/platform/missingModel/missingModelStore.ts, src/platform/missingMedia/missingMediaStore.ts, src/platform/nodeReplacement/missingNodesErrorStore.ts
Add addMissingModels/addMissingMedia and removeMissingModelsByNodeId/removeMissingMediaByNodeId/removeMissingNodesByNodeId to append/dedupe and remove candidates while cleaning interaction state.
Error-group filtering & UI wiring
src/components/rightSidePanel/errors/useErrorGroups.ts, src/components/rightSidePanel/RightSidePanel.vue, src/components/rightSidePanel/errors/TabErrors.vue
Add selection-aware filtering (isAssetErrorInSelection, filtered group builders); RightSidePanel now reads useMissingMediaStore refs and includes missing-media selection in hasRelevantErrors; TabErrors shows “download all” only when downloadableModels.length > 1.
Graph hooks & clearing logic
src/composables/graph/useErrorClearingHooks.ts
On node add/trigger/remove: scan nodes (including subgraph interiors), add/remove missing-model/media/node-type entries, and resurface overlay on active rescans; pre-clear on removal.
Workflow/app pipelines & pending warnings
src/platform/workflow/core/services/workflowService.ts, src/scripts/app.ts, src/scripts/changeTracker.ts, src/platform/workflow/management/stores/comfyWorkflow.ts
Replace showMissing* options with skipAssetScans/silentAssetErrors; cache missingModel/media in pendingWarnings; showPendingWarnings accepts { silent?: boolean } and syncs missing stores; ComfyApp pipeline functions accept silent.
Execution error surfacing (silent)
src/stores/executionErrorStore.ts, src/stores/executionErrorStore.test.ts
surfaceMissingModels/surfaceMissingMedia gain optional options?: { silent?: boolean }; overlay only opens when !silent; tests added for silent behavior.
Missing-model UI metadata
src/platform/missingModel/components/MissingModelRow.vue
On mount, fetch representative model metadata (file size) and cache into store.fileSizes when absent.
Tests & fixtures
src/platform/*/*.test.ts, browser_tests/assets/missing/*, browser_tests/tests/propertiesPanel/*, browser_tests/fixtures/selectors.ts, browser_tests/tests/*
Extensive test additions/updates covering per-node scanning, mode-aware behavior, add/remove store actions, selection-aware filtering, silent overlay handling, new/updated browser test fixtures and selector namespace changes.
Right-side panel duplication note
src/components/rightSidePanel/RightSidePanel.vue
Integrates useMissingMediaStore refs and adds hasMissingMediaSelected into hasRelevantErrors computation.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Graph as LiteGraph
    participant Hooks as ErrorClearingHooks
    participant Scanner as MissingAssetScanner
    participant Store as MissingAssetStore
    participant UI as RightSidePanel

    User->>Graph: add/modify node (add or mode change)
    Graph->>Hooks: emit node add / onTrigger / remove
    Hooks->>Scanner: scanNode*Candidates(root, node, ...)
    alt node became inactive (NEVER/BYPASS)
        Hooks->>Store: removeMissing*ByNodeId(nodeId)
        Store-->>Hooks: confirm removal
    else node added or active
        Scanner-->>Hooks: return missing candidates
        Hooks->>Store: addMissing*(candidates)
        Store-->>Hooks: updated state
    end
    Store->>UI: state updated (missingModel/media)
    UI->>UI: apply selection-aware filtering
    UI-->>User: update Errors tab visibility and buttons
Loading
sequenceDiagram
    participant Workflow
    participant App as ComfyApp
    participant Graph as LiteGraph
    participant Scanner as MissingAssetScanner
    participant Store as MissingAssetStore
    participant Errors as ExecutionErrorStore

    Workflow->>App: loadGraphData(skipAssetScans?, silentAssetErrors?)
    App->>Graph: load graph
    alt skipAssetScans = false
        Graph->>Scanner: scanAll*Candidates (skips NEVER/BYPASS)
        Scanner-->>Store: setMissing*(candidates)
        Store-->>Workflow: cache in pendingWarnings
        Workflow->>Errors: surfaceMissing*(candidates, { silent: silentAssetErrors })
    else skipAssetScans = true
        App->>Store: setMissing*([]) or reset state
    end
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Possibly related PRs

Suggested labels

enhancement, area:nodes, size:XL

Suggested reviewers

  • christian-byrne

Poem

🐇 I hopped through nodes both mute and loud,

Skipped the bypassed, ignored the shroud,
I cached by workflow and cleared by id,
Filtered selections so fewer alarms cried,
🥕 tiny rabbit cheers — tests green and proud!

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 27.45% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The PR title 'fix: exclude muted/bypassed nodes from missing asset detection' directly and specifically describes the main objective: preventing inactive (muted/bypassed) nodes from triggering missing asset errors.
Linked Issues check ✅ Passed The PR directly addresses issue #13256 by implementing mode-aware error detection that excludes muted/bypassed nodes from missing asset errors. All coding requirements—scan filtering, mode change handling, node lifecycle management, and error tab filtering—align with fixing the reported problem of bypassed loaders incorrectly triggering missing-model errors.
Out of Scope Changes check ✅ Passed All changes are directly related to implementing mode-aware missing asset detection and consistent error lifecycle handling across the specified areas (scans, hooks, stores, UI components, tests). Browser test assets and selectors are appropriately adjusted to support the new mode-filtering behavior.
End-To-End Regression Coverage For Fixes ✅ Passed PR is a bug-fix with substantial E2E test coverage including a comprehensive 467-line test suite validating that bypassed/muted nodes are excluded from missing asset detection.
Adr Compliance For Entity/Litegraph Changes ✅ Passed PR does not modify restricted paths (src/lib/litegraph/, src/ecs/) and does not extend core entity classes with new methods/properties.
Description check ✅ Passed The PR description is comprehensive, well-structured, and addresses all major aspects of the changes including summary, detailed behavioral notes, extensive change documentation, test plan, and follow-up work.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/muted-bypass-missing-asset-filter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Apr 5, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 04/13/2026, 08:47:26 AM UTC

Links

@github-actions

github-actions Bot commented Apr 5, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1101 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1087 / ❌ 0 / ⚠️ 1 / ⏭️ 1)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 11 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions

github-actions Bot commented Apr 5, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: 5.15 MB gzip 🔴 +3.94 kB

Details

Summary

  • Raw size: 23.7 MB baseline 23.7 MB — 🔴 +20.5 kB
  • Gzip: 5.15 MB baseline 5.15 MB — 🔴 +3.94 kB
  • Brotli: 3.99 MB baseline 3.98 MB — 🔴 +2.53 kB
  • Bundles: 251 current • 251 baseline • 123 added / 123 removed

Category Glance
Data & Services 🔴 +10.5 kB (3 MB) · Graph Workspace 🔴 +9.89 kB (1.22 MB) · Other 🔴 +65 B (8.56 MB) · Editors & Dialogs 🔴 +2 B (109 kB) · UI Components 🔴 +1 B (60.3 kB) · App Entry Points 🔴 +1 B (22.3 kB) · + 5 more

App Entry Points — 22.3 kB (baseline 22.3 kB) • 🔴 +1 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-35OV66qo.js (new) — 22.3 kB 🔴 +22.3 kB 🔴 +7.93 kB 🔴 +6.78 kB
assets/index-pJrrVqyb.js (removed) 22.3 kB — 🟢 -22.3 kB 🟢 -7.93 kB 🟢 -6.79 kB

Status: 1 added / 1 removed

Graph Workspace — 1.22 MB (baseline 1.21 MB) • 🔴 +9.89 kB

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-DiKsYIbt.js (new) — 1.22 MB 🔴 +1.22 MB 🔴 +260 kB 🔴 +196 kB
assets/GraphView-Bc5oiC8F.js (removed) 1.21 MB — 🟢 -1.21 MB 🟢 -258 kB 🟢 -195 kB

Status: 1 added / 1 removed

Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-BmXgYeZA.js (removed) 15.7 kB — 🟢 -15.7 kB 🟢 -3.4 kB 🟢 -2.89 kB
assets/CloudSurveyView-C9JzISvT.js (new) — 15.7 kB 🔴 +15.7 kB 🔴 +3.4 kB 🔴 +2.9 kB
assets/CloudLoginView-BQNfGFhI.js (new) — 12 kB 🔴 +12 kB 🔴 +3.36 kB 🔴 +2.96 kB
assets/CloudLoginView-UvkTLFvJ.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.36 kB 🟢 -2.98 kB
assets/CloudSignupView-C4X6I7M6.js (removed) 9.78 kB — 🟢 -9.78 kB 🟢 -2.85 kB 🟢 -2.5 kB
assets/CloudSignupView-D5pL_pnK.js (new) — 9.78 kB 🔴 +9.78 kB 🔴 +2.86 kB 🔴 +2.51 kB
assets/UserCheckView-BeH0G75v.js (removed) 9.04 kB — 🟢 -9.04 kB 🟢 -2.32 kB 🟢 -2.04 kB
assets/UserCheckView-CXFTxv0n.js (new) — 9.04 kB 🔴 +9.04 kB 🔴 +2.32 kB 🔴 +2.03 kB
assets/CloudLayoutView-C0y-7GS2.js (new) — 7.54 kB 🔴 +7.54 kB 🔴 +2.36 kB 🔴 +2.05 kB
assets/CloudLayoutView-TEtz56Fw.js (removed) 7.54 kB — 🟢 -7.54 kB 🟢 -2.36 kB 🟢 -2.05 kB
assets/CloudForgotPasswordView-C7WLmIka.js (new) — 5.94 kB 🔴 +5.94 kB 🔴 +2.1 kB 🔴 +1.84 kB
assets/CloudForgotPasswordView-CErRand8.js (removed) 5.94 kB — 🟢 -5.94 kB 🟢 -2.09 kB 🟢 -1.84 kB
assets/CloudAuthTimeoutView-C5lffjuv.js (removed) 5.31 kB — 🟢 -5.31 kB 🟢 -1.93 kB 🟢 -1.68 kB
assets/CloudAuthTimeoutView-DR8z3B3x.js (new) — 5.31 kB 🔴 +5.31 kB 🔴 +1.93 kB 🔴 +1.69 kB
assets/CloudSubscriptionRedirectView-CLRXKUaY.js (new) — 5.08 kB 🔴 +5.08 kB 🔴 +1.91 kB 🔴 +1.69 kB
assets/CloudSubscriptionRedirectView-D7fScG3w.js (removed) 5.08 kB — 🟢 -5.08 kB 🟢 -1.91 kB 🟢 -1.7 kB
assets/UserSelectView-Bcd78qy9.js (removed) 4.71 kB — 🟢 -4.71 kB 🟢 -1.74 kB 🟢 -1.54 kB
assets/UserSelectView-DAZxLAsp.js (new) — 4.71 kB 🔴 +4.71 kB 🔴 +1.75 kB 🔴 +1.54 kB

Status: 9 added / 9 removed / 2 unchanged

Panels & Settings — 482 kB (baseline 482 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-CioTaSY-.js (removed) 46.6 kB — 🟢 -46.6 kB 🟢 -9.52 kB 🟢 -8.46 kB
assets/KeybindingPanel-CRTHbPcX.js (new) — 46.6 kB 🔴 +46.6 kB 🔴 +9.53 kB 🔴 +8.46 kB
assets/SecretsPanel-Cv0sJQBw.js (new) — 22.4 kB 🔴 +22.4 kB 🔴 +5.42 kB 🔴 +4.76 kB
assets/SecretsPanel-CzX5q7fA.js (removed) 22.4 kB — 🟢 -22.4 kB 🟢 -5.42 kB 🟢 -4.77 kB
assets/LegacyCreditsPanel-7tBourL-.js (removed) 21.5 kB — 🟢 -21.5 kB 🟢 -5.81 kB 🟢 -5.14 kB
assets/LegacyCreditsPanel-D0EHcv8N.js (new) — 21.5 kB 🔴 +21.5 kB 🔴 +5.82 kB 🔴 +5.13 kB
assets/SubscriptionPanel-9KNQb9FU.js (new) — 19.7 kB 🔴 +19.7 kB 🔴 +5 kB 🔴 +4.39 kB
assets/SubscriptionPanel-CPv92APh.js (removed) 19.7 kB — 🟢 -19.7 kB 🟢 -5 kB 🟢 -4.4 kB
assets/AboutPanel-BSaDiXiS.js (new) — 12 kB 🔴 +12 kB 🔴 +3.33 kB 🔴 +2.98 kB
assets/AboutPanel-D7O3rOVw.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.33 kB 🟢 -2.99 kB
assets/ExtensionPanel-DWCpeSZj.js (new) — 9.78 kB 🔴 +9.78 kB 🔴 +2.83 kB 🔴 +2.51 kB
assets/ExtensionPanel-DxTNMkxl.js (removed) 9.78 kB — 🟢 -9.78 kB 🟢 -2.83 kB 🟢 -2.5 kB
assets/ServerConfigPanel-D5BovfU6.js (new) — 6.85 kB 🔴 +6.85 kB 🔴 +2.27 kB 🔴 +2.03 kB
assets/ServerConfigPanel-k4VduSMW.js (removed) 6.85 kB — 🟢 -6.85 kB 🟢 -2.27 kB 🟢 -2.03 kB
assets/UserPanel-C_LTLGVY.js (new) — 6.56 kB 🔴 +6.56 kB 🔴 +2.15 kB 🔴 +1.88 kB
assets/UserPanel-CKfemSuM.js (removed) 6.56 kB — 🟢 -6.56 kB 🟢 -2.15 kB 🟢 -1.9 kB
assets/cloudRemoteConfig-C48OiTuQ.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +906 B 🔴 +788 B
assets/cloudRemoteConfig-xr-aQ3Nb.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -902 B 🟢 -799 B
assets/refreshRemoteConfig-Cu_5ZSlU.js (removed) 1.45 kB — 🟢 -1.45 kB 🟢 -648 B 🟢 -557 B
assets/refreshRemoteConfig-CYGjzG17.js (new) — 1.45 kB 🔴 +1.45 kB 🔴 +649 B 🔴 +551 B

Status: 10 added / 10 removed / 11 unchanged

User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/auth-B2rxJ1qy.js (new) — 3.57 kB 🔴 +3.57 kB 🔴 +1.26 kB 🔴 +1.07 kB
assets/auth-DQzgPXzp.js (removed) 3.57 kB — 🟢 -3.57 kB 🟢 -1.26 kB 🟢 -1.07 kB
assets/SignUpForm-804WXn8D.js (removed) 3.16 kB — 🟢 -3.16 kB 🟢 -1.29 kB 🟢 -1.14 kB
assets/SignUpForm-Dv6zPB-2.js (new) — 3.16 kB 🔴 +3.16 kB 🔴 +1.28 kB 🔴 +1.14 kB
assets/UpdatePasswordContent-BwmFidLf.js (removed) 2.66 kB — 🟢 -2.66 kB 🟢 -1.19 kB 🟢 -1.05 kB
assets/UpdatePasswordContent-DKEP-9-7.js (new) — 2.66 kB 🔴 +2.66 kB 🔴 +1.19 kB 🔴 +1.05 kB
assets/authStore-D8WYRGJE.js (new) — 989 B 🔴 +989 B 🔴 +482 B 🔴 +425 B
assets/authStore-XKxkFd78.js (removed) 989 B — 🟢 -989 B 🟢 -481 B 🟢 -423 B
assets/auth-B_QJVyhW.js (new) — 348 B 🔴 +348 B 🔴 +217 B 🔴 +186 B
assets/auth-CU5MLktJ.js (removed) 348 B — 🟢 -348 B 🟢 -216 B 🟢 -189 B

Status: 5 added / 5 removed / 2 unchanged

Editors & Dialogs — 109 kB (baseline 109 kB) • 🔴 +2 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useShareDialog-CVQfp7IT.js (new) — 108 kB 🔴 +108 kB 🔴 +22.4 kB 🔴 +18.9 kB
assets/useShareDialog-9egK_Fvn.js (removed) 108 kB — 🟢 -108 kB 🟢 -22.4 kB 🟢 -18.9 kB
assets/useSubscriptionDialog-4ZHUjDfM.js (removed) 969 B — 🟢 -969 B 🟢 -475 B 🟢 -413 B
assets/useSubscriptionDialog-Dv4HFwso.js (new) — 969 B 🔴 +969 B 🔴 +476 B 🔴 +415 B

Status: 2 added / 2 removed

UI Components — 60.3 kB (baseline 60.3 kB) • 🔴 +1 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-D4QvZv14.js (new) — 13.5 kB 🔴 +13.5 kB 🔴 +3.79 kB 🔴 +3.38 kB
assets/ComfyQueueButton-CY8jzgAQ.js (removed) 13.5 kB — 🟢 -13.5 kB 🟢 -3.79 kB 🟢 -3.39 kB
assets/useTerminalTabs-D-RTHqCH.js (removed) 10.7 kB — 🟢 -10.7 kB 🟢 -3.6 kB 🟢 -3.16 kB
assets/useTerminalTabs-gBK9YRxr.js (new) — 10.7 kB 🔴 +10.7 kB 🔴 +3.6 kB 🔴 +3.16 kB
assets/SubscribeButton-CZYxCwlF.js (new) — 2.42 kB 🔴 +2.42 kB 🔴 +1.05 kB 🔴 +918 B
assets/SubscribeButton-Dgnw0jSE.js (removed) 2.42 kB — 🟢 -2.42 kB 🟢 -1.05 kB 🟢 -927 B
assets/cloudFeedbackTopbarButton-BccsSg3i.js (new) — 1.64 kB 🔴 +1.64 kB 🔴 +859 B 🔴 +751 B
assets/cloudFeedbackTopbarButton-BrgBmzaF.js (removed) 1.64 kB — 🟢 -1.64 kB 🟢 -857 B 🟢 -750 B
assets/ComfyQueueButton-2r-tkDUh.js (new) — 1.03 kB 🔴 +1.03 kB 🔴 +489 B 🔴 +440 B
assets/ComfyQueueButton-DPExph_T.js (removed) 1.03 kB — 🟢 -1.03 kB 🟢 -488 B 🟢 -437 B

Status: 5 added / 5 removed / 8 unchanged

Data & Services — 3 MB (baseline 2.98 MB) • 🔴 +10.5 kB

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/dialogService-CQh4OW5B.js (new) — 1.95 MB 🔴 +1.95 MB 🔴 +449 kB 🔴 +340 kB
assets/dialogService-ymQ3R6dd.js (removed) 1.94 MB — 🟢 -1.94 MB 🟢 -448 kB 🟢 -339 kB
assets/api-DCAYAwS-.js (new) — 887 kB 🔴 +887 kB 🔴 +212 kB 🔴 +167 kB
assets/api--8EZePnq.js (removed) 886 kB — 🟢 -886 kB 🟢 -212 kB 🟢 -167 kB
assets/load3dService-DS-_20ao.js (new) — 96.5 kB 🔴 +96.5 kB 🔴 +20.5 kB 🔴 +17.7 kB
assets/load3dService-Z1xEqOU3.js (removed) 96.5 kB — 🟢 -96.5 kB 🟢 -20.5 kB 🟢 -17.7 kB
assets/workflowShareService-D_UtlZ8Q.js (removed) 16.6 kB — 🟢 -16.6 kB 🟢 -4.88 kB 🟢 -4.33 kB
assets/workflowShareService-Db0N8P2U.js (new) — 16.6 kB 🔴 +16.6 kB 🔴 +4.88 kB 🔴 +4.33 kB
assets/keybindingService-BLZInfNF.js (removed) 13.8 kB — 🟢 -13.8 kB 🟢 -3.67 kB 🟢 -3.21 kB
assets/keybindingService-DXQ9DIu0.js (new) — 13.8 kB 🔴 +13.8 kB 🔴 +3.67 kB 🔴 +3.22 kB
assets/releaseStore-BSfVxkmd.js (new) — 8.12 kB 🔴 +8.12 kB 🔴 +2.28 kB 🔴 +2 kB
assets/releaseStore-Dhc1aLb2.js (removed) 8.12 kB — 🟢 -8.12 kB 🟢 -2.28 kB 🟢 -2 kB
assets/userStore-CzLCu5qJ.js (new) — 2.24 kB 🔴 +2.24 kB 🔴 +870 B 🔴 +762 B
assets/userStore-Dj39Kxt8.js (removed) 2.24 kB — 🟢 -2.24 kB 🟢 -870 B 🟢 -761 B
assets/audioService-BDOLqYcY.js (removed) 1.8 kB — 🟢 -1.8 kB 🟢 -877 B 🟢 -757 B
assets/audioService-mBfa5piC.js (new) — 1.8 kB 🔴 +1.8 kB 🔴 +875 B 🔴 +762 B
assets/releaseStore-DCBERn3e.js (new) — 993 B 🔴 +993 B 🔴 +481 B 🔴 +426 B
assets/releaseStore-Dn6uMrJl.js (removed) 993 B — 🟢 -993 B 🟢 -480 B 🟢 -423 B
assets/workflowDraftStore-C2Wskbwh.js (removed) 969 B — 🟢 -969 B 🟢 -473 B 🟢 -416 B
assets/workflowDraftStore-DwVt-cuD.js (new) — 969 B 🔴 +969 B 🔴 +475 B 🔴 +422 B
assets/dialogService-CPuqxASw.js (removed) 958 B — 🟢 -958 B 🟢 -467 B 🟢 -418 B
assets/dialogService-Uoq1E4PJ.js (new) — 958 B 🔴 +958 B 🔴 +469 B 🔴 +413 B
assets/settingStore-Dwt9MVSW.js (new) — 956 B 🔴 +956 B 🔴 +471 B 🔴 +412 B
assets/settingStore-qVdjaW6Y.js (removed) 956 B — 🟢 -956 B 🟢 -469 B 🟢 -412 B
assets/assetsStore-BbHN7O0I.js (removed) 955 B — 🟢 -955 B 🟢 -469 B 🟢 -414 B
assets/assetsStore-EJvT8TRc.js (new) — 955 B 🔴 +955 B 🔴 +470 B 🔴 +414 B

Status: 13 added / 13 removed / 4 unchanged

Utilities & Hooks — 344 kB (baseline 344 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-BpqWL23P.js (removed) 232 kB — 🟢 -232 kB 🟢 -51.3 kB 🟢 -41.8 kB
assets/useConflictDetection-DuP6Wqz4.js (new) — 232 kB 🔴 +232 kB 🔴 +51.3 kB 🔴 +41.8 kB
assets/useLoad3d-DJkR8cHw.js (removed) 20.2 kB — 🟢 -20.2 kB 🟢 -4.7 kB 🟢 -4.16 kB
assets/useLoad3d-DR_eO71w.js (new) — 20.2 kB 🔴 +20.2 kB 🔴 +4.7 kB 🔴 +4.17 kB
assets/useLoad3dViewer-CrgGJLj6.js (removed) 18.7 kB — 🟢 -18.7 kB 🟢 -4.44 kB 🟢 -3.87 kB
assets/useLoad3dViewer-DvO8X_3l.js (new) — 18.7 kB 🔴 +18.7 kB 🔴 +4.44 kB 🔴 +3.87 kB
assets/useFeatureFlags-CoGhBKOn.js (new) — 5.78 kB 🔴 +5.78 kB 🔴 +1.75 kB 🔴 +1.48 kB
assets/useFeatureFlags-v-xWduoI.js (removed) 5.78 kB — 🟢 -5.78 kB 🟢 -1.75 kB 🟢 -1.48 kB
assets/useCopyToClipboard-B_eB73_r.js (new) — 5.29 kB 🔴 +5.29 kB 🔴 +1.86 kB 🔴 +1.57 kB
assets/useCopyToClipboard-D6jmCaAR.js (removed) 5.29 kB — 🟢 -5.29 kB 🟢 -1.86 kB 🟢 -1.57 kB
assets/downloadUtil-B1A5IpPm.js (new) — 4.68 kB 🔴 +4.68 kB 🔴 +1.85 kB 🔴 +1.54 kB
assets/downloadUtil-BZDfrxuW.js (removed) 4.68 kB — 🟢 -4.68 kB 🟢 -1.85 kB 🟢 -1.54 kB
assets/useWorkspaceUI-CKJ-BQIS.js (removed) 3.34 kB — 🟢 -3.34 kB 🟢 -982 B 🟢 -813 B
assets/useWorkspaceUI-IuM1EEI-.js (new) — 3.34 kB 🔴 +3.34 kB 🔴 +981 B 🔴 +811 B
assets/useExternalLink-BrZEslYK.js (removed) 3.04 kB — 🟢 -3.04 kB 🟢 -1.17 kB 🟢 -1.01 kB
assets/useExternalLink-wo-HYyEF.js (new) — 3.04 kB 🔴 +3.04 kB 🔴 +1.17 kB 🔴 +1.04 kB
assets/subscriptionCheckoutUtil-DI_3goki.js (removed) 2.97 kB — 🟢 -2.97 kB 🟢 -1.31 kB 🟢 -1.14 kB
assets/subscriptionCheckoutUtil-y6_pJBWI.js (new) — 2.97 kB 🔴 +2.97 kB 🔴 +1.31 kB 🔴 +1.14 kB
assets/assetPreviewUtil-B_MhEVnS.js (new) — 2.27 kB 🔴 +2.27 kB 🔴 +959 B 🔴 +841 B
assets/assetPreviewUtil-CTIH1Pku.js (removed) 2.27 kB — 🟢 -2.27 kB 🟢 -958 B 🟢 -833 B
assets/useUpstreamValue-BoTX3Ecn.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +807 B 🔴 +708 B
assets/useUpstreamValue-Tgkh8Cr0.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -804 B 🟢 -713 B
assets/useErrorHandling-B-VnqrQb.js (removed) 1.54 kB — 🟢 -1.54 kB 🟢 -647 B 🟢 -546 B
assets/useErrorHandling-DPN0ZGP9.js (new) — 1.54 kB 🔴 +1.54 kB 🔴 +649 B 🔴 +551 B
assets/useLoad3d-8Bi5zNSY.js (removed) 1.13 kB — 🟢 -1.13 kB 🟢 -539 B 🟢 -476 B
assets/useLoad3d-DGAmJhKG.js (new) — 1.13 kB 🔴 +1.13 kB 🔴 +540 B 🔴 +480 B
assets/useLoad3dViewer-BXARq0ix.js (removed) 1.07 kB — 🟢 -1.07 kB 🟢 -505 B 🟢 -451 B
assets/useLoad3dViewer-mMIbLTlN.js (new) — 1.07 kB 🔴 +1.07 kB 🔴 +506 B 🔴 +455 B
assets/useCurrentUser-DFA5otMU.js (removed) 955 B — 🟢 -955 B 🟢 -469 B 🟢 -413 B
assets/useCurrentUser-DOwJ6GJD.js (new) — 955 B 🔴 +955 B 🔴 +471 B 🔴 +413 B
assets/useWorkspaceSwitch-BYiN4AiZ.js (removed) 747 B — 🟢 -747 B 🟢 -381 B 🟢 -330 B
assets/useWorkspaceSwitch-CMBSkwRb.js (new) — 747 B 🔴 +747 B 🔴 +383 B 🔴 +331 B

Status: 16 added / 16 removed / 11 unchanged

Vendor & Third-Party — 9.86 MB (baseline 9.86 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 8.56 MB (baseline 8.56 MB) • 🔴 +65 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/i18n-CP0r7EY3.js (new) — 573 kB 🔴 +573 kB 🔴 +112 kB 🔴 +87.8 kB
assets/i18n-D01zfRlu.js (removed) 573 kB — 🟢 -573 kB 🟢 -112 kB 🟢 -87.8 kB
assets/core-DcYS0UfO.js (new) — 77 kB 🔴 +77 kB 🔴 +19.9 kB 🔴 +17 kB
assets/core-DrAW2xcv.js (removed) 77 kB — 🟢 -77 kB 🟢 -19.9 kB 🟢 -17 kB
assets/groupNode-Dan3BA8-.js (removed) 74 kB — 🟢 -74 kB 🟢 -18.5 kB 🟢 -16.3 kB
assets/groupNode-DQpe77QK.js (new) — 74 kB 🔴 +74 kB 🔴 +18.5 kB 🔴 +16.3 kB
assets/WidgetSelect-BpC7-LAx.js (new) — 64.8 kB 🔴 +64.8 kB 🔴 +14 kB 🔴 +12.1 kB
assets/WidgetSelect-D9SJkf6i.js (removed) 64.8 kB — 🟢 -64.8 kB 🟢 -14 kB 🟢 -12.1 kB
assets/SubscriptionRequiredDialogContentWorkspace-BaDst2wc.js (removed) 48.9 kB — 🟢 -48.9 kB 🟢 -9.3 kB 🟢 -7.94 kB
assets/SubscriptionRequiredDialogContentWorkspace-DJBFJ22M.js (new) — 48.9 kB 🔴 +48.9 kB 🔴 +9.3 kB 🔴 +7.94 kB
assets/Load3DControls-BepLGrd-.js (removed) 40.2 kB — 🟢 -40.2 kB 🟢 -6.88 kB 🟢 -6.01 kB
assets/Load3DControls-BtMBt22-.js (new) — 40.2 kB 🔴 +40.2 kB 🔴 +6.88 kB 🔴 +6.01 kB
assets/WidgetPainter-BJLnPb9u.js (removed) 33.6 kB — 🟢 -33.6 kB 🟢 -8.2 kB 🟢 -7.27 kB
assets/WidgetPainter-DoiA3p3a.js (new) — 33.6 kB 🔴 +33.6 kB 🔴 +8.19 kB 🔴 +7.28 kB
assets/WorkspacePanelContent-ChrudfQi.js (removed) 32.6 kB — 🟢 -32.6 kB 🟢 -6.93 kB 🟢 -6.13 kB
assets/WorkspacePanelContent-D-dA-3El.js (new) — 32.6 kB 🔴 +32.6 kB 🔴 +6.93 kB 🔴 +6.13 kB
assets/SubscriptionRequiredDialogContent-3SwEaspB.js (new) — 28.2 kB 🔴 +28.2 kB 🔴 +7.17 kB 🔴 +6.3 kB
assets/SubscriptionRequiredDialogContent-BAazY3LZ.js (removed) 28.2 kB — 🟢 -28.2 kB 🟢 -7.17 kB 🟢 -6.31 kB
assets/Load3dViewerContent-BQQ6s4Zh.js (removed) 24.5 kB — 🟢 -24.5 kB 🟢 -5.36 kB 🟢 -4.66 kB
assets/Load3dViewerContent-CiUnnHq7.js (new) — 24.5 kB 🔴 +24.5 kB 🔴 +5.36 kB 🔴 +4.66 kB
assets/WidgetImageCrop-CleHlFXL.js (removed) 23.4 kB — 🟢 -23.4 kB 🟢 -5.86 kB 🟢 -5.18 kB
assets/WidgetImageCrop-vnvYOkrN.js (new) — 23.4 kB 🔴 +23.4 kB 🔴 +5.87 kB 🔴 +5.18 kB
assets/SubscriptionPanelContentWorkspace-Bb-pzrNp.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.18 kB 🟢 -4.56 kB
assets/SubscriptionPanelContentWorkspace-Bo54Cry7.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.18 kB 🔴 +4.57 kB
assets/SignInContent-CeE25FF7.js (new) — 20.4 kB 🔴 +20.4 kB 🔴 +5.29 kB 🔴 +4.62 kB
assets/SignInContent-DaIKyiN4.js (removed) 20.4 kB — 🟢 -20.4 kB 🟢 -5.29 kB 🟢 -4.64 kB
assets/CurrentUserPopoverWorkspace-3XLjtkfy.js (removed) 20.4 kB — 🟢 -20.4 kB 🟢 -4.83 kB 🟢 -4.33 kB
assets/CurrentUserPopoverWorkspace-C2OitdeO.js (new) — 20.4 kB 🔴 +20.4 kB 🔴 +4.83 kB 🔴 +4.32 kB
assets/WidgetInputNumber-Cvv4sjEk.js (new) — 19.1 kB 🔴 +19.1 kB 🔴 +4.84 kB 🔴 +4.31 kB
assets/WidgetInputNumber-DCMo1em6.js (removed) 19.1 kB — 🟢 -19.1 kB 🟢 -4.84 kB 🟢 -4.31 kB
assets/WidgetRecordAudio-DK4m7PkF.js (removed) 17.2 kB — 🟢 -17.2 kB 🟢 -4.92 kB 🟢 -4.41 kB
assets/WidgetRecordAudio-omsKn0Zc.js (new) — 17.2 kB 🔴 +17.2 kB 🔴 +4.92 kB 🔴 +4.4 kB
assets/Load3D-DxbI6Ygc.js (new) — 17 kB 🔴 +17 kB 🔴 +4.13 kB 🔴 +3.62 kB
assets/Load3D-hXjlrYK-.js (removed) 17 kB — 🟢 -17 kB 🟢 -4.14 kB 🟢 -3.62 kB
assets/WidgetRange-Bbcx6IHS.js (removed) 16.9 kB — 🟢 -16.9 kB 🟢 -4.53 kB 🟢 -4.06 kB
assets/WidgetRange-BWBH0dyn.js (new) — 16.9 kB 🔴 +16.9 kB 🔴 +4.54 kB 🔴 +4.05 kB
assets/load3d-Bph0p4wF.js (new) — 15 kB 🔴 +15 kB 🔴 +4.32 kB 🔴 +3.73 kB
assets/load3d-DwcM_6UA.js (removed) 15 kB — 🟢 -15 kB 🟢 -4.32 kB 🟢 -3.74 kB
assets/WaveAudioPlayer-C658boRl.js (new) — 13.4 kB 🔴 +13.4 kB 🔴 +3.69 kB 🔴 +3.23 kB
assets/WaveAudioPlayer-DjWYWXbN.js (removed) 13.4 kB — 🟢 -13.4 kB 🟢 -3.69 kB 🟢 -3.23 kB
assets/WidgetCurve-CsncjBvr.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.87 kB 🟢 -3.51 kB
assets/WidgetCurve-D75U_KOw.js (new) — 12 kB 🔴 +12 kB 🔴 +3.87 kB 🔴 +3.5 kB
assets/TeamWorkspacesDialogContent-Bu6Es-RR.js (removed) 11.1 kB — 🟢 -11.1 kB 🟢 -3.33 kB 🟢 -2.97 kB
assets/TeamWorkspacesDialogContent-DvOwRVli.js (new) — 11.1 kB 🔴 +11.1 kB 🔴 +3.34 kB 🔴 +2.99 kB
assets/AudioPreviewPlayer-CNR72NDZ.js (new) — 10.8 kB 🔴 +10.8 kB 🔴 +3.13 kB 🔴 +2.8 kB
assets/AudioPreviewPlayer-KyFTyOLc.js (removed) 10.8 kB — 🟢 -10.8 kB 🟢 -3.13 kB 🟢 -2.8 kB
assets/nodeTemplates-B3-FL3kN.js (new) — 9.58 kB 🔴 +9.58 kB 🔴 +3.38 kB 🔴 +2.96 kB
assets/nodeTemplates-BgJAk7k0.js (removed) 9.58 kB — 🟢 -9.58 kB 🟢 -3.37 kB 🟢 -2.97 kB
assets/InviteMemberDialogContent-BaTi9OWL.js (removed) 7.77 kB — 🟢 -7.77 kB 🟢 -2.45 kB 🟢 -2.15 kB
assets/InviteMemberDialogContent-CoVNR08Z.js (new) — 7.77 kB 🔴 +7.77 kB 🔴 +2.45 kB 🔴 +2.15 kB
assets/Load3DConfiguration-8uHb_WHI.js (new) — 7.22 kB 🔴 +7.22 kB 🔴 +2.2 kB 🔴 +1.92 kB
assets/Load3DConfiguration-DiH4aT_o.js (removed) 7.22 kB — 🟢 -7.22 kB 🟢 -2.2 kB 🟢 -1.92 kB
assets/onboardingCloudRoutes-DE6EeDkW.js (new) — 6.53 kB 🔴 +6.53 kB 🔴 +2.03 kB 🔴 +1.75 kB
assets/onboardingCloudRoutes-VPB5B0cs.js (removed) 6.53 kB — 🟢 -6.53 kB 🟢 -2.03 kB 🟢 -1.74 kB
assets/WidgetWithControl-BDWWBUib.js (removed) 5.99 kB — 🟢 -5.99 kB 🟢 -2.38 kB 🟢 -2.13 kB
assets/WidgetWithControl-Dt56pueW.js (new) — 5.99 kB 🔴 +5.99 kB 🔴 +2.38 kB 🔴 +2.12 kB
assets/CreateWorkspaceDialogContent-Cp3Aj0SI.js (removed) 5.95 kB — 🟢 -5.95 kB 🟢 -2.15 kB 🟢 -1.87 kB
assets/CreateWorkspaceDialogContent-pCIFZAND.js (new) — 5.95 kB 🔴 +5.95 kB 🔴 +2.15 kB 🔴 +1.88 kB
assets/FreeTierDialogContent-aU9I0VH7.js (new) — 5.82 kB 🔴 +5.82 kB 🔴 +2.04 kB 🔴 +1.81 kB
assets/FreeTierDialogContent-DyLfGpGF.js (removed) 5.82 kB — 🟢 -5.82 kB 🟢 -2.04 kB 🟢 -1.81 kB
assets/EditWorkspaceDialogContent-BOMw1uDL.js (new) — 5.75 kB 🔴 +5.75 kB 🔴 +2.11 kB 🔴 +1.84 kB
assets/EditWorkspaceDialogContent-kLmCu4h_.js (removed) 5.75 kB — 🟢 -5.75 kB 🟢 -2.11 kB 🟢 -1.85 kB
assets/WidgetTextarea-CKdRs_XC.js (removed) 5.53 kB — 🟢 -5.53 kB 🟢 -2.17 kB 🟢 -1.92 kB
assets/WidgetTextarea-DJpZkRDq.js (new) — 5.53 kB 🔴 +5.53 kB 🔴 +2.17 kB 🔴 +1.92 kB
assets/Preview3d-BrfMwPqa.js (removed) 5.39 kB — 🟢 -5.39 kB 🟢 -1.8 kB 🟢 -1.57 kB
assets/Preview3d-Tu5yNMRs.js (new) — 5.39 kB 🔴 +5.39 kB 🔴 +1.81 kB 🔴 +1.57 kB
assets/ValueControlPopover-BIeufsrq.js (new) — 5.33 kB 🔴 +5.33 kB 🔴 +1.93 kB 🔴 +1.72 kB
assets/ValueControlPopover-DIJOA5v-.js (removed) 5.33 kB — 🟢 -5.33 kB 🟢 -1.92 kB 🟢 -1.71 kB
assets/CancelSubscriptionDialogContent-BBAMUDDZ.js (removed) 5.22 kB — 🟢 -5.22 kB 🟢 -1.95 kB 🟢 -1.7 kB
assets/CancelSubscriptionDialogContent-DSpjdnP-.js (new) — 5.22 kB 🔴 +5.22 kB 🔴 +1.95 kB 🔴 +1.7 kB
assets/DeleteWorkspaceDialogContent-Er6JztSk.js (new) — 4.65 kB 🔴 +4.65 kB 🔴 +1.79 kB 🔴 +1.55 kB
assets/DeleteWorkspaceDialogContent-XZC7ogIF.js (removed) 4.65 kB — 🟢 -4.65 kB 🟢 -1.78 kB 🟢 -1.55 kB
assets/LeaveWorkspaceDialogContent-CbZ8b4Ov.js (removed) 4.48 kB — 🟢 -4.48 kB 🟢 -1.73 kB 🟢 -1.51 kB
assets/LeaveWorkspaceDialogContent-Dgz24Kk2.js (new) — 4.48 kB 🔴 +4.48 kB 🔴 +1.73 kB 🔴 +1.51 kB
assets/RemoveMemberDialogContent-DoQZfo2D.js (new) — 4.46 kB 🔴 +4.46 kB 🔴 +1.69 kB 🔴 +1.47 kB
assets/RemoveMemberDialogContent-DwCQLzfu.js (removed) 4.46 kB — 🟢 -4.46 kB 🟢 -1.68 kB 🟢 -1.47 kB
assets/tierBenefits-CvpyuO0E.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.57 kB 🔴 +1.36 kB
assets/tierBenefits-vXZjF4pJ.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.58 kB 🟢 -1.36 kB
assets/RevokeInviteDialogContent-BBgywAnL.js (removed) 4.37 kB — 🟢 -4.37 kB 🟢 -1.7 kB 🟢 -1.48 kB
assets/RevokeInviteDialogContent-BR0JZnc7.js (new) — 4.37 kB 🔴 +4.37 kB 🔴 +1.7 kB 🔴 +1.48 kB
assets/InviteMemberUpsellDialogContent-C4cEIHgY.js (removed) 4.27 kB — 🟢 -4.27 kB 🟢 -1.56 kB 🟢 -1.37 kB
assets/InviteMemberUpsellDialogContent-DotTE2bd.js (new) — 4.27 kB 🔴 +4.27 kB 🔴 +1.56 kB 🔴 +1.36 kB
assets/cloudSessionCookie-4HtQpUQj.js (removed) 4.12 kB — 🟢 -4.12 kB 🟢 -1.49 kB 🟢 -1.29 kB
assets/cloudSessionCookie-CmX2v2A-.js (new) — 4.12 kB 🔴 +4.12 kB 🔴 +1.49 kB 🔴 +1.29 kB
assets/saveMesh-D-EqBDiq.js (removed) 3.92 kB — 🟢 -3.92 kB 🟢 -1.68 kB 🟢 -1.48 kB
assets/saveMesh-ldBI3eqW.js (new) — 3.92 kB 🔴 +3.92 kB 🔴 +1.69 kB 🔴 +1.48 kB
assets/Media3DTop-BVTBmoz5.js (new) — 3.85 kB 🔴 +3.85 kB 🔴 +1.63 kB 🔴 +1.42 kB
assets/Media3DTop-DV1djIaE.js (removed) 3.85 kB — 🟢 -3.85 kB 🟢 -1.62 kB 🟢 -1.42 kB
assets/GlobalToast-BzZyfVjh.js (removed) 3.05 kB — 🟢 -3.05 kB 🟢 -1.26 kB 🟢 -1.08 kB
assets/GlobalToast-D1EAB5F-.js (new) — 3.05 kB 🔴 +3.05 kB 🔴 +1.26 kB 🔴 +1.11 kB
assets/ApiNodesSignInContent-DVg-rLeN.js (new) — 2.86 kB 🔴 +2.86 kB 🔴 +1.1 kB 🔴 +966 B
assets/ApiNodesSignInContent-IX2j_eMe.js (removed) 2.86 kB — 🟢 -2.86 kB 🟢 -1.1 kB 🟢 -964 B
assets/SubscribeToRun-D9TI8Abd.js (removed) 2.13 kB — 🟢 -2.13 kB 🟢 -981 B 🟢 -879 B
assets/SubscribeToRun-dxwZTt2I.js (new) — 2.13 kB 🔴 +2.13 kB 🔴 +982 B 🔴 +885 B
assets/MediaAudioTop-Cpyr0nRo.js (removed) 2.02 kB — 🟢 -2.02 kB 🟢 -979 B 🟢 -878 B
assets/MediaAudioTop-t1i_2Vje.js (new) — 2.02 kB 🔴 +2.02 kB 🔴 +978 B 🔴 +878 B
assets/CloudRunButtonWrapper-CrcNAKxE.js (new) — 1.99 kB 🔴 +1.99 kB 🔴 +912 B 🔴 +807 B
assets/CloudRunButtonWrapper-DaUmienR.js (removed) 1.99 kB — 🟢 -1.99 kB 🟢 -908 B 🟢 -806 B
assets/graphHasMissingNodes-CobBzvQR.js (new) — 1.83 kB 🔴 +1.83 kB 🔴 +861 B 🔴 +756 B
assets/graphHasMissingNodes-Cp85FN3L.js (removed) 1.83 kB — 🟢 -1.83 kB 🟢 -862 B 🟢 -762 B
assets/cloudBadges-DK15wkGN.js (new) — 1.77 kB 🔴 +1.77 kB 🔴 +894 B 🔴 +786 B
assets/cloudBadges-Dnzjm14X.js (removed) 1.77 kB — 🟢 -1.77 kB 🟢 -892 B 🟢 -786 B
assets/cloudSubscription-eHrDITSf.js (new) — 1.68 kB 🔴 +1.68 kB 🔴 +813 B 🔴 +703 B
assets/cloudSubscription-T5uJdxrQ.js (removed) 1.68 kB — 🟢 -1.68 kB 🟢 -815 B 🟢 -707 B
assets/signInSchema-9GXvkPyZ.js (removed) 1.6 kB — 🟢 -1.6 kB 🟢 -585 B 🟢 -547 B
assets/signInSchema-DdwewsL_.js (new) — 1.6 kB 🔴 +1.6 kB 🔴 +583 B 🔴 +517 B
assets/previousFullPath-CKwo2QUG.js (new) — 1.53 kB 🔴 +1.53 kB 🔴 +694 B 🔴 +613 B
assets/previousFullPath-DCc2-1VJ.js (removed) 1.53 kB — 🟢 -1.53 kB 🟢 -694 B 🟢 -600 B
assets/Load3D-12vp-kSt.js (removed) 1.34 kB — 🟢 -1.34 kB 🟢 -616 B 🟢 -542 B
assets/Load3D-BTiVG-PN.js (new) — 1.34 kB 🔴 +1.34 kB 🔴 +615 B 🔴 +541 B
assets/nightlyBadges-BWKzTXY_.js (new) — 1.29 kB 🔴 +1.29 kB 🔴 +660 B 🔴 +584 B
assets/nightlyBadges-DAV0cej5.js (removed) 1.29 kB — 🟢 -1.29 kB 🟢 -658 B 🟢 -580 B
assets/Load3dViewerContent-Bmctnmtc.js (removed) 1.23 kB — 🟢 -1.23 kB 🟢 -567 B 🟢 -499 B
assets/Load3dViewerContent-CyPjjxpt.js (new) — 1.23 kB 🔴 +1.23 kB 🔴 +565 B 🔴 +497 B
assets/SubscriptionPanelContentWorkspace-BsHcsGsv.js (new) — 1.15 kB 🔴 +1.15 kB 🔴 +535 B 🔴 +469 B
assets/SubscriptionPanelContentWorkspace-DXR2-nPO.js (removed) 1.15 kB — 🟢 -1.15 kB 🟢 -536 B 🟢 -467 B
assets/WidgetLegacy-BWcrbJeN.js (new) — 978 B 🔴 +978 B 🔴 +483 B 🔴 +424 B
assets/WidgetLegacy-CmneTTGs.js (removed) 978 B — 🟢 -978 B 🟢 -481 B 🟢 -421 B
assets/changeTracker-rb3wVRj6.js (new) — 953 B 🔴 +953 B 🔴 +471 B 🔴 +406 B
assets/changeTracker-BzCAoZpo.js (removed) 952 B — 🟢 -952 B 🟢 -469 B 🟢 -411 B
assets/i18n-CKcFbSIC.js (new) — 137 B 🔴 +137 B 🔴 +122 B 🔴 +114 B
assets/i18n-D5xAxaU_.js (removed) 137 B — 🟢 -137 B 🟢 -122 B 🟢 -108 B

Status: 61 added / 61 removed / 74 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 42.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 47.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 47.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 1030ms TBT · 160.9 MB heap
vue-large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 143.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 46.4 MB heap

⚠️ 1 regression detected

Metric Baseline PR (median) Δ Sig
workflow-execution: layout duration 1ms 2ms +66% ⚠️ z=2.7
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms +1% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 10ms 9ms -12% z=-2.2
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 11 10 -9% z=-2.1
canvas-idle: task duration 333ms 355ms +7% z=-1.3
canvas-idle: script duration 19ms 24ms +24% z=-0.6
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 60.2 MB 42.4 MB -30% —
canvas-idle: DOM nodes 22 20 -9% z=-2.0
canvas-idle: event listeners 6 6 +0% z=-1.2
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 4ms 4ms +6% z=1.2
canvas-mouse-sweep: style recalc duration 45ms 43ms -5% z=0.2
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 81 80 -1% z=0.6
canvas-mouse-sweep: task duration 999ms 772ms -23% z=-1.6
canvas-mouse-sweep: script duration 139ms 123ms -12% z=-1.9
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 56.4 MB 57.4 MB +2% —
canvas-mouse-sweep: DOM nodes 66 65 -2% z=1.0
canvas-mouse-sweep: event listeners 6 4 -33% z=-1.1
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=0.5
canvas-zoom-sweep: p95 frame time 17ms 17ms +1% —
canvas-zoom-sweep: layout duration 1ms 1ms +23% z=0.5
canvas-zoom-sweep: style recalc duration 16ms 18ms +9% z=-1.1
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 32 30 -6% z=-2.8
canvas-zoom-sweep: task duration 285ms 303ms +6% z=-1.0
canvas-zoom-sweep: script duration 24ms 25ms +6% z=-0.6
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 64.4 MB 64.2 MB -0% —
canvas-zoom-sweep: DOM nodes 79 79 +0% z=-0.3
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
dom-widget-clipping: p95 frame time 17ms 17ms +0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 10ms 8ms -18% z=-1.9
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 13 12 -8% z=-2.2
dom-widget-clipping: task duration 338ms 342ms +1% z=-1.4
dom-widget-clipping: script duration 64ms 63ms -1% z=-1.4
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 47.1 MB 47.3 MB +0% —
dom-widget-clipping: DOM nodes 22 20 -9% z=-1.5
dom-widget-clipping: event listeners 2 2 +0% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=-1.0
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 10ms 9ms -12% z=-3.3
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 11 11 +0% z=-1.9
large-graph-idle: task duration 526ms 554ms +5% z=0.2
large-graph-idle: script duration 95ms 91ms -4% z=-1.1
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 53.4 MB 52.2 MB -2% —
large-graph-idle: DOM nodes -256 -256 +0% z=-310.6
large-graph-idle: event listeners -125 -125 +0% z=-24.8
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms +1% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 16ms 15ms -6% z=-2.3
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 69 69 +0% z=-0.9
large-graph-pan: task duration 1098ms 1074ms -2% z=-0.2
large-graph-pan: script duration 402ms 369ms -8% z=-2.0
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 69.2 MB 65.6 MB -5% —
large-graph-pan: DOM nodes -259 -260 +0% z=-169.1
large-graph-pan: event listeners -125 -125 +0% z=-156.9
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms -1% —
large-graph-zoom: layout duration 7ms 8ms +6% —
large-graph-zoom: style recalc duration 16ms 15ms -4% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 66 66 +0% —
large-graph-zoom: task duration 1308ms 1288ms -2% —
large-graph-zoom: script duration 491ms 450ms -8% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 60.7 MB 59.3 MB -2% —
large-graph-zoom: DOM nodes -264 -261 -1% —
large-graph-zoom: event listeners -125 -123 -2% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms -1% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 9ms 8ms -10% z=-1.8
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 10 11 +10% z=2.1
minimap-idle: task duration 519ms 549ms +6% z=0.5
minimap-idle: script duration 92ms 92ms +0% z=-0.6
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 53.9 MB 54.8 MB +2% —
minimap-idle: DOM nodes -257 -259 +1% z=-203.4
minimap-idle: event listeners -125 -125 +0% z=-196.2
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.9
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms -0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 12ms 11ms -6% z=-1.6
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 48 48 +0% z=0.1
subgraph-dom-widget-clipping: task duration 375ms 341ms -9% z=-2.0
subgraph-dom-widget-clipping: script duration 137ms 117ms -15% z=-1.8
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 47.2 MB 47.4 MB +0% —
subgraph-dom-widget-clipping: DOM nodes 19 21 +11% z=-1.1
subgraph-dom-widget-clipping: event listeners 8 8 +0% z=-1.4
subgraph-idle: avg frame time 17ms 17ms +0% z=0.4
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 9ms 8ms -12% z=-2.7
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 10 11 +10% z=0.2
subgraph-idle: task duration 330ms 350ms +6% z=-0.6
subgraph-idle: script duration 17ms 20ms +14% z=-0.2
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 60.2 MB 60.5 MB +1% —
subgraph-idle: DOM nodes 20 22 +10% z=0.1
subgraph-idle: event listeners 6 6 +0% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms +1% —
subgraph-mouse-sweep: layout duration 4ms 5ms +4% z=-0.3
subgraph-mouse-sweep: style recalc duration 45ms 43ms -4% z=0.2
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 83 83 +0% z=1.5
subgraph-mouse-sweep: task duration 873ms 902ms +3% z=2.0
subgraph-mouse-sweep: script duration 97ms 90ms -7% z=-1.6
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 52.5 MB 52.5 MB +0% —
subgraph-mouse-sweep: DOM nodes 72 71 -1% z=1.8
subgraph-mouse-sweep: event listeners 6 6 +0% variance too high
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 42ms 46ms +9% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 252 251 -0% —
viewport-pan-sweep: task duration 3677ms 3627ms -1% —
viewport-pan-sweep: script duration 1222ms 1188ms -3% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 73.0 MB 72.3 MB -1% —
viewport-pan-sweep: DOM nodes -257 -253 -2% —
viewport-pan-sweep: event listeners -111 -107 -4% —
vue-large-graph-idle: avg frame time 17ms 17ms -0% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 9ms 4ms -54% —
vue-large-graph-idle: style recalc duration 30ms 17ms -43% —
vue-large-graph-idle: layout count 2 1 -50% —
vue-large-graph-idle: style recalc count 3 1 -67% —
vue-large-graph-idle: task duration 12615ms 10873ms -14% —
vue-large-graph-idle: script duration 560ms 561ms +0% —
vue-large-graph-idle: TBT 882ms 1030ms +17% —
vue-large-graph-idle: heap used 150.6 MB 160.9 MB +7% —
vue-large-graph-idle: DOM nodes -4992 -8329 +67% —
vue-large-graph-idle: event listeners 3530 -14702 -516% —
vue-large-graph-pan: avg frame time 18ms 17ms -6% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 14ms 14ms +1% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 67 67 +0% —
vue-large-graph-pan: task duration 14038ms 12545ms -11% —
vue-large-graph-pan: script duration 852ms 801ms -6% —
vue-large-graph-pan: TBT 0ms 0ms +0% —
vue-large-graph-pan: heap used 153.2 MB 143.7 MB -6% —
vue-large-graph-pan: DOM nodes -8331 -9850 +18% —
vue-large-graph-pan: event listeners -16462 -23985 +46% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.6
workflow-execution: p95 frame time 17ms 17ms +0% —
workflow-execution: layout duration 1ms 2ms +66% ⚠️ z=2.7
workflow-execution: style recalc duration 23ms 29ms +26% z=1.9
workflow-execution: layout count 5 6 +20% z=1.9
workflow-execution: style recalc count 19 20 +5% z=1.1
workflow-execution: task duration 119ms 138ms +17% z=1.4
workflow-execution: script duration 27ms 33ms +21% z=1.3
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 46.9 MB 46.4 MB -1% —
workflow-execution: DOM nodes 159 158 -1% z=-0.4
workflow-execution: event listeners 71 71 +0% z=4.4
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-04-13T08:58:25.214Z",
  "gitSha": "3f029548c9511a20208b5bd25173e98db9a9a59e",
  "branch": "feat/muted-bypass-missing-asset-filter",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2015.6800000000032,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.629999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 362.323,
      "heapDeltaBytes": -4618448,
      "heapUsedBytes": 44464104,
      "domNodes": 20,
      "jsHeapTotalBytes": 24641536,
      "scriptDurationMs": 25.257999999999996,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2004.8440000000483,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.376000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 345.31,
      "heapDeltaBytes": 20705948,
      "heapUsedBytes": 65181980,
      "domNodes": 20,
      "jsHeapTotalBytes": 22806528,
      "scriptDurationMs": 16.745000000000005,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2005.4810000000316,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.847999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 354.784,
      "heapDeltaBytes": -4610076,
      "heapUsedBytes": 44427760,
      "domNodes": 22,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 23.858000000000004,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2034.5439999999826,
      "styleRecalcs": 85,
      "styleRecalcDurationMs": 43.296,
      "layouts": 12,
      "layoutDurationMs": 3.0360000000000005,
      "taskDurationMs": 968.0179999999999,
      "heapDeltaBytes": 16359204,
      "heapUsedBytes": 59013692,
      "domNodes": 67,
      "jsHeapTotalBytes": 23330816,
      "scriptDurationMs": 122.44199999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1899.3560000000116,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 45.445,
      "layouts": 12,
      "layoutDurationMs": 4.152,
      "taskDurationMs": 772.485,
      "heapDeltaBytes": 16336376,
      "heapUsedBytes": 60202768,
      "domNodes": 65,
      "jsHeapTotalBytes": 22806528,
      "scriptDurationMs": 123.34800000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1843.0399999999736,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 39.994,
      "layouts": 12,
      "layoutDurationMs": 3.8520000000000003,
      "taskDurationMs": 754.0440000000001,
      "heapDeltaBytes": 16683508,
      "heapUsedBytes": 60518584,
      "domNodes": 61,
      "jsHeapTotalBytes": 23330816,
      "scriptDurationMs": 122.92800000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1726.6529999999989,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.374,
      "layouts": 6,
      "layoutDurationMs": 0.5839999999999999,
      "taskDurationMs": 298.824,
      "heapDeltaBytes": 24662060,
      "heapUsedBytes": 68774796,
      "domNodes": 79,
      "jsHeapTotalBytes": 20709376,
      "scriptDurationMs": 23.687999999999995,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1732.073000000014,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 17.519,
      "layouts": 6,
      "layoutDurationMs": 0.6640000000000001,
      "taskDurationMs": 339.515,
      "heapDeltaBytes": 15759316,
      "heapUsedBytes": 66867336,
      "domNodes": 78,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 25.238000000000003,
      "eventListeners": 23,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1730.4169999999885,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 18.008999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.7770000000000001,
      "taskDurationMs": 302.767,
      "heapDeltaBytes": 24711016,
      "heapUsedBytes": 67301328,
      "domNodes": 81,
      "jsHeapTotalBytes": 20447232,
      "scriptDurationMs": 28.552,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 628.6660000000097,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.337000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 374.08200000000005,
      "heapDeltaBytes": 7352564,
      "heapUsedBytes": 52167212,
      "domNodes": 20,
      "jsHeapTotalBytes": 12320768,
      "scriptDurationMs": 68.31700000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 556.8850000000225,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.375,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 342.28999999999996,
      "heapDeltaBytes": 6532988,
      "heapUsedBytes": 49549492,
      "domNodes": 20,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 63.32,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 527.7439999999842,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.857000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 326.63800000000003,
      "heapDeltaBytes": 6191944,
      "heapUsedBytes": 49404316,
      "domNodes": 20,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 53.501,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.024000000012,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 15.151,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 554.371,
      "heapDeltaBytes": 3907620,
      "heapUsedBytes": 54689200,
      "domNodes": -256,
      "jsHeapTotalBytes": 16023552,
      "scriptDurationMs": 91.30099999999999,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2051.9590000000107,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.823,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 566.0050000000001,
      "heapDeltaBytes": -19898868,
      "heapUsedBytes": 50352604,
      "domNodes": -253,
      "jsHeapTotalBytes": 17784832,
      "scriptDurationMs": 111.829,
      "eventListeners": -121,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2021.50400000005,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.582999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 543.153,
      "heapDeltaBytes": 4506324,
      "heapUsedBytes": 65129716,
      "domNodes": -256,
      "jsHeapTotalBytes": 16818176,
      "scriptDurationMs": 90.342,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2147.975000000002,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.880999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1051.983,
      "heapDeltaBytes": 16740360,
      "heapUsedBytes": 68837456,
      "domNodes": -260,
      "jsHeapTotalBytes": 17694720,
      "scriptDurationMs": 368.91999999999996,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2128.031999999962,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.882,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1106.8020000000001,
      "heapDeltaBytes": -6706164,
      "heapUsedBytes": 47938312,
      "domNodes": -259,
      "jsHeapTotalBytes": 21741568,
      "scriptDurationMs": 397.909,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2122.2950000000083,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.483,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1073.7669999999998,
      "heapDeltaBytes": 16402528,
      "heapUsedBytes": 70569108,
      "domNodes": -260,
      "jsHeapTotalBytes": 18481152,
      "scriptDurationMs": 369.08599999999996,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3147.350999999986,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 15.23,
      "layouts": 60,
      "layoutDurationMs": 8.103,
      "taskDurationMs": 1289.16,
      "heapDeltaBytes": 1569864,
      "heapUsedBytes": 59163220,
      "domNodes": -261,
      "jsHeapTotalBytes": 16678912,
      "scriptDurationMs": 446.12,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3131.885000000011,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 15.465,
      "layouts": 60,
      "layoutDurationMs": 7.670999999999999,
      "taskDurationMs": 1288.309,
      "heapDeltaBytes": 7971848,
      "heapUsedBytes": 64163956,
      "domNodes": -263,
      "jsHeapTotalBytes": 17022976,
      "scriptDurationMs": 459.751,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3164.5950000000767,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 16.054,
      "layouts": 60,
      "layoutDurationMs": 7.507999999999999,
      "taskDurationMs": 1280.583,
      "heapDeltaBytes": 7414216,
      "heapUsedBytes": 62150516,
      "domNodes": -261,
      "jsHeapTotalBytes": 17489920,
      "scriptDurationMs": 450.154,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2022.0569999999611,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.541000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 521.9130000000001,
      "heapDeltaBytes": 3177152,
      "heapUsedBytes": 57481608,
      "domNodes": -260,
      "jsHeapTotalBytes": 15654912,
      "scriptDurationMs": 80.99999999999999,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2007.7440000000024,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.049000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 548.8009999999999,
      "heapDeltaBytes": 4039132,
      "heapUsedBytes": 56371372,
      "domNodes": -256,
      "jsHeapTotalBytes": 16703488,
      "scriptDurationMs": 92.25,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2043.965000000071,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 561.243,
      "heapDeltaBytes": 4367816,
      "heapUsedBytes": 57846352,
      "domNodes": -259,
      "jsHeapTotalBytes": 15163392,
      "scriptDurationMs": 92.74499999999999,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 592.7119999999775,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.530999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 373.43799999999993,
      "heapDeltaBytes": 6532600,
      "heapUsedBytes": 49769736,
      "domNodes": 21,
      "jsHeapTotalBytes": 13107200,
      "scriptDurationMs": 122.69499999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 537.7300000000105,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.392999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 340.56699999999995,
      "heapDeltaBytes": -2070696,
      "heapUsedBytes": 49380708,
      "domNodes": 20,
      "jsHeapTotalBytes": 15466496,
      "scriptDurationMs": 117.133,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 539.2839999999524,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 11.212,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 338.81300000000005,
      "heapDeltaBytes": 6503524,
      "heapUsedBytes": 49694296,
      "domNodes": 23,
      "jsHeapTotalBytes": 13631488,
      "scriptDurationMs": 114.25799999999998,
      "eventListeners": 12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1997.8010000000097,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.232999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 339.89599999999996,
      "heapDeltaBytes": 20171136,
      "heapUsedBytes": 64986896,
      "domNodes": 20,
      "jsHeapTotalBytes": 22806528,
      "scriptDurationMs": 17.211,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1996.4299999999753,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.296000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 350.494,
      "heapDeltaBytes": 20316092,
      "heapUsedBytes": 63414456,
      "domNodes": 22,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 20.532,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1998.4460000000581,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.854,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 350.584,
      "heapDeltaBytes": 20638456,
      "heapUsedBytes": 63394556,
      "domNodes": 25,
      "jsHeapTotalBytes": 23068672,
      "scriptDurationMs": 19.660999999999998,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1704.4099999999958,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 36.333999999999996,
      "layouts": 16,
      "layoutDurationMs": 4.589,
      "taskDurationMs": 637.005,
      "heapDeltaBytes": 11856464,
      "heapUsedBytes": 55162500,
      "domNodes": 64,
      "jsHeapTotalBytes": 22544384,
      "scriptDurationMs": 87.404,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1962.3880000000327,
      "styleRecalcs": 83,
      "styleRecalcDurationMs": 43.03,
      "layouts": 16,
      "layoutDurationMs": 4.8549999999999995,
      "taskDurationMs": 905.9359999999999,
      "heapDeltaBytes": 11912104,
      "heapUsedBytes": 55037260,
      "domNodes": 71,
      "jsHeapTotalBytes": 22806528,
      "scriptDurationMs": 92.626,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1963.1059999999252,
      "styleRecalcs": 83,
      "styleRecalcDurationMs": 47.885,
      "layouts": 16,
      "layoutDurationMs": 4.381,
      "taskDurationMs": 901.659,
      "heapDeltaBytes": 11823472,
      "heapUsedBytes": 55078796,
      "domNodes": 72,
      "jsHeapTotalBytes": 22806528,
      "scriptDurationMs": 90.488,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8167.25199999999,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 46.001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3657.4370000000004,
      "heapDeltaBytes": 25495120,
      "heapUsedBytes": 75820044,
      "domNodes": -253,
      "jsHeapTotalBytes": 20316160,
      "scriptDurationMs": 1188.3329999999999,
      "eventListeners": -107,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8209.116000000051,
      "styleRecalcs": 253,
      "styleRecalcDurationMs": 46.288000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3626.786,
      "heapDeltaBytes": 9109596,
      "heapUsedBytes": 80857324,
      "domNodes": -249,
      "jsHeapTotalBytes": 22589440,
      "scriptDurationMs": 1188.196,
      "eventListeners": -103,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8137.0059999999285,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 43.581,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3606.8830000000003,
      "heapDeltaBytes": 18849068,
      "heapUsedBytes": 69595472,
      "domNodes": -257,
      "jsHeapTotalBytes": 20840448,
      "scriptDurationMs": 1176.013,
      "eventListeners": -107,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12168.503999999984,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 41.09299999999999,
      "layouts": 2,
      "layoutDurationMs": 8.436,
      "taskDurationMs": 12147.103,
      "heapDeltaBytes": 4906788,
      "heapUsedBytes": 168727108,
      "domNodes": -4992,
      "jsHeapTotalBytes": 66412544,
      "scriptDurationMs": 561.0930000000001,
      "eventListeners": 5292,
      "totalBlockingTimeMs": 1030,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10842.26000000001,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 17.32700000000001,
      "layouts": 1,
      "layoutDurationMs": 4.392000000000007,
      "taskDurationMs": 10822.373000000001,
      "heapDeltaBytes": -24905560,
      "heapUsedBytes": 168210300,
      "domNodes": -8330,
      "jsHeapTotalBytes": 37576704,
      "scriptDurationMs": 563.046,
      "eventListeners": -14702,
      "totalBlockingTimeMs": 1030,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10891.910000000053,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 14.984999999999998,
      "layouts": 1,
      "layoutDurationMs": 4.0950000000000015,
      "taskDurationMs": 10872.89,
      "heapDeltaBytes": -26289064,
      "heapUsedBytes": 168841968,
      "domNodes": -8329,
      "jsHeapTotalBytes": 37576704,
      "scriptDurationMs": 534.729,
      "eventListeners": -14702,
      "totalBlockingTimeMs": 1049,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 12601,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 14.000999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12579.845,
      "heapDeltaBytes": -68833452,
      "heapUsedBytes": 150710136,
      "domNodes": -9848,
      "jsHeapTotalBytes": -13279232,
      "scriptDurationMs": 831.469,
      "eventListeners": -23985,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 12254.917999999976,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.862000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12235.080000000002,
      "heapDeltaBytes": -40879452,
      "heapUsedBytes": 176264648,
      "domNodes": -9850,
      "jsHeapTotalBytes": 26480640,
      "scriptDurationMs": 801.005,
      "eventListeners": -23961,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 12564.395000000104,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 14.105000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12545.482,
      "heapDeltaBytes": -66134780,
      "heapUsedBytes": 150010072,
      "domNodes": -9850,
      "jsHeapTotalBytes": -11182080,
      "scriptDurationMs": 794.723,
      "eventListeners": -23985,
      "totalBlockingTimeMs": 27,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 472.88000000003194,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 28.508,
      "layouts": 5,
      "layoutDurationMs": 1.98,
      "taskDurationMs": 144.044,
      "heapDeltaBytes": 4789228,
      "heapUsedBytes": 48802948,
      "domNodes": 191,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 29.118000000000006,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 456.1879999999974,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 25.544,
      "layouts": 6,
      "layoutDurationMs": 1.6,
      "taskDurationMs": 137.687,
      "heapDeltaBytes": 4546976,
      "heapUsedBytes": 48548740,
      "domNodes": 156,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 32.926,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 457.320999999979,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 28.524999999999995,
      "layouts": 6,
      "layoutDurationMs": 1.9469999999999998,
      "taskDurationMs": 138.40600000000003,
      "heapDeltaBytes": 4573284,
      "heapUsedBytes": 48656544,
      "domNodes": 158,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 33.303,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (3)
src/platform/missingModel/missingModelScan.ts (1)

73-92: ⚠️ Potential issue | 🟠 Major

Disconnected loaders are still treated as executable.

The linked issue explicitly calls out not-connected loaders, but this scan only filters on mode, so any active-but-unconnected loader still reaches scanNodeModelCandidates(). The same loose predicate is reused by hasActiveNodes, so workflow-level embedded models can also be materialized when the graph has no executable path. The original disconnected-loader false positive from #13256 is still reproducible here.

Also applies to: 233-238

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/platform/missingModel/missingModelScan.ts` around lines 73 - 92, The loop
currently treats any node with an active mode as executable even if it is not
connected; update the predicate before calling scanNodeModelCandidates to also
require the node be connected (e.g., has at least one incoming or outgoing
connection/edge) in addition to the existing mode checks and subgraph check —
apply the same connectivity requirement inside hasActiveNodes so workflow-level
embedded models are not treated as active when there is no executable path;
reference the node properties used here (node.mode, node.isSubgraphNode,
node.widgets) and the functions scanNodeModelCandidates and hasActiveNodes to
locate where to add the connectivity check.
src/platform/workflow/core/services/workflowService.ts (1)

251-265: ⚠️ Potential issue | 🟠 Major

Tab switches can leak the previous workflow's missing-model/media state.

openWorkflow() now skips asset rescans for already-loaded tabs, so showPendingWarnings() is the only sync point on tab restore. In the empty-cache case it leaves both asset stores untouched, which means switching from a workflow with missing assets to one without them can still show the old cards.

💡 Proposed fix
-    showPendingWarnings(undefined, { silent: !loadFromRemote })
+    showPendingWarnings(undefined, {
+      silent: !loadFromRemote,
+      syncAssetStores: !loadFromRemote
+    })
-  function showPendingWarnings(
-    workflow?: ComfyWorkflow | null,
-    options?: { silent?: boolean }
-  ) {
+  function showPendingWarnings(
+    workflow?: ComfyWorkflow | null,
+    options?: { silent?: boolean; syncAssetStores?: boolean }
+  ) {
     const wf = workflow ?? workflowStore.activeWorkflow
     if (!wf) return

     const { missingNodeTypes, missingModelCandidates, missingMediaCandidates } =
       wf.pendingWarnings ?? {}

@@
-    if (missingModelCandidates?.length) {
-      useMissingModelStore().setMissingModels(missingModelCandidates)
-    }
-    if (missingMediaCandidates?.length) {
-      useMissingMediaStore().setMissingMedia(missingMediaCandidates)
-    }
+    if (options?.syncAssetStores) {
+      useMissingModelStore().setMissingModels(missingModelCandidates ?? [])
+      useMissingMediaStore().setMissingMedia(missingMediaCandidates ?? [])
+    } else {
+      if (missingModelCandidates?.length) {
+        useMissingModelStore().setMissingModels(missingModelCandidates)
+      }
+      if (missingMediaCandidates?.length) {
+        useMissingMediaStore().setMissingMedia(missingMediaCandidates)
+      }
+    }

Also applies to: 578-615

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/platform/workflow/core/services/workflowService.ts` around lines 251 -
265, openWorkflow() can leak the previous workflow's missing-model/media state
because when loadGraphData is called with skipAssetScans: true the asset stores
are left untouched and showPendingWarnings() will surface stale cards; fix by
clearing the relevant missing-asset state before calling showPendingWarnings().
Specifically, in the openWorkflow() / workflow restore path where
app.loadGraphData(..., { skipAssetScans: true, ... }) is invoked, call the app
or workflow-level method that resets pending asset warnings (e.g.,
clearPendingWarnings(), resetMissingModels(), resetMissingMedia(), or clear
asset-manager scan caches) right after loadGraphData returns and before
showPendingWarnings() is called so the warning UI only reflects the newly-loaded
workflow. Ensure the same change is applied to the other restore location noted
(lines ~578-615).
src/scripts/app.ts (1)

1129-1145: ⚠️ Potential issue | 🔴 Critical

Dead options: showMissingNodes and showMissingModels are accepted but never used.

The options interface still declares showMissingNodes and showMissingModels (lines 1130–1131), but they are not destructured or referenced anywhere in the function body. Callers (workflowService.ts:257–258 and changeTracker.ts:168–169) pass these options expecting them to control whether missing node/model errors are surfaced, but the values are silently ignored.

The actual suppression mechanism uses silentAssetErrors instead (passed to runMissingModelPipeline at line 1438 and runMissingMediaPipeline at line 1441).

Either remove these deprecated options from the type signature or extract and use them consistently across callers.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/scripts/app.ts` around lines 1129 - 1145, The options interface declares
showMissingNodes and showMissingModels but they are never read; either remove
these deprecated properties from the function signature and update callers to
stop passing them, or explicitly extract them from options (e.g., const {
showMissingNodes, showMissingModels, silentAssetErrors = false, ... } = options)
and use them when invoking the suppression logic (pass the appropriate flag(s)
into runMissingModelPipeline and runMissingMediaPipeline in place of or
alongside silentAssetErrors so callers’ expectations are honored). Ensure
references to showMissingNodes and showMissingModels are added where missing (or
removed from callers) and keep silentAssetErrors behavior consistent with the
chosen approach.
🧹 Nitpick comments (4)
src/platform/missingModel/missingModelStore.ts (1)

131-138: Consider cleaning up interaction state when removing candidates by nodeId.

Unlike removeMissingMediaByNodeId in missingMediaStore.ts (lines 124-141), this function does not clean up associated interaction state (modelExpandState, urlInputs, fileSizes, etc.) for removed candidates. This could leave stale UI state in the store.

While clearMissingModels() handles full cleanup on workflow/tab changes, incremental removals (e.g., when a node is deleted or bypassed) may leave orphaned entries.

♻️ Suggested cleanup pattern (mirroring missingMediaStore)
 function removeMissingModelsByNodeId(nodeId: string) {
   if (!missingModelCandidates.value) return
+  const removedKeys = new Set(
+    missingModelCandidates.value
+      .filter((m) => String(m.nodeId) === nodeId)
+      .map((m) => getModelStateKey(m.name, m.directory, m.isAssetSupported))
+  )
   missingModelCandidates.value = missingModelCandidates.value.filter(
     (m) => String(m.nodeId) !== nodeId
   )
+  for (const key of removedKeys) {
+    if (!missingModelCandidates.value.some(
+      (m) => getModelStateKey(m.name, m.directory, m.isAssetSupported) === key
+    )) {
+      delete modelExpandState.value[key]
+      delete urlInputs.value[key]
+      // ... other state cleanup as needed
+    }
+  }
   if (!missingModelCandidates.value.length)
     missingModelCandidates.value = null
 }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/platform/missingModel/missingModelStore.ts` around lines 131 - 138,
removeMissingModelsByNodeId currently only updates missingModelCandidates and
can leave stale interaction state; update it to mirror
removeMissingMediaByNodeId by identifying which candidate nodeIds were removed
(compare prior missingModelCandidates to the filtered result or collect them
during filter) and then delete/clean corresponding entries from
modelExpandState, urlInputs, fileSizes (and any other per-candidate maps), and
if those maps become empty set them to null; also ensure behavior remains
consistent with clearMissingModels and use the existing symbols
removeMissingModelsByNodeId, missingModelCandidates, modelExpandState,
urlInputs, fileSizes, and clearMissingModels to locate and implement the
cleanup.
src/platform/missingMedia/missingMediaStore.ts (1)

143-149: Consider making addMissingMedia idempotent to avoid duplicate candidates.

Appending blindly can duplicate the same candidate on repeated incremental scans, inflating counts and duplicate UI rows. Deduping by a stable key (e.g., nodeId + widgetName + name) would make updates safer.

♻️ Suggested refactor
 function addMissingMedia(media: MissingMediaCandidate[]) {
   if (!media.length) return
-  missingMediaCandidates.value = [
-    ...(missingMediaCandidates.value ?? []),
-    ...media
-  ]
+  const deduped = new Map<string, MissingMediaCandidate>()
+  for (const item of [...(missingMediaCandidates.value ?? []), ...media]) {
+    const key = `${String(item.nodeId)}::${item.widgetName}::${item.name}`
+    deduped.set(key, item)
+  }
+  missingMediaCandidates.value = [...deduped.values()]
 }

As per coding guidelines "Every entity state change must be a serializable, idempotent, deterministic command (replayable, undoable, transmittable over CRDT) per ADR 0003 + ADR 0008".

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/platform/missingMedia/missingMediaStore.ts` around lines 143 - 149, The
addMissingMedia function currently appends candidates blindly and can create
duplicates; make it idempotent by deduplicating new entries against existing
missingMediaCandidates using a stable key (e.g., nodeId + widgetName + name). In
the addMissingMedia implementation, compute the stable key for each incoming
MissingMediaCandidate, build a Set of existing keys from
missingMediaCandidates.value, filter incoming media to only those whose key is
not present, then append those filtered candidates (or replace the array with a
deterministically ordered union) and update missingMediaCandidates.value. Ensure
the dedupe logic references addMissingMedia and missingMediaCandidates so state
changes remain serializable and deterministic.
src/scripts/app.ts (2)

1602-1616: Minor duplication in pendingWarnings cleanup logic.

The null-cleanup logic (lines 1609-1615) is duplicated with runMissingModelPipeline (lines 1521-1526). Consider extracting a helper function.

♻️ Optional: Extract cleanup helper
private cleanupPendingWarnings(wf: ComfyWorkflow) {
  if (
    !wf.pendingWarnings?.missingNodeTypes &&
    !wf.pendingWarnings?.missingModelCandidates &&
    !wf.pendingWarnings?.missingMediaCandidates
  ) {
    wf.pendingWarnings = null
  }
}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/scripts/app.ts` around lines 1602 - 1616, The pendingWarnings
null-cleanup is duplicated between cacheModelCandidates and
runMissingModelPipeline; extract a helper like cleanupPendingWarnings(wf:
ComfyWorkflow) that checks wf.pendingWarnings?.missingNodeTypes,
.missingModelCandidates, and .missingMediaCandidates and sets wf.pendingWarnings
= null when all are falsy, then replace the duplicated block in
cacheModelCandidates and runMissingModelPipeline with a call to
cleanupPendingWarnings(wf) to remove duplication and centralize the logic.

1231-1256: Use LGraphEventMode enum constants instead of magic numbers for node modes.

The logic correctly filters muted/bypassed nodes from the error list while still sanitizing their names. However, the magic numbers 2 and 4 for node modes reduce readability. Replace them with the LGraphEventMode enum constants that are already exported from the litegraph module.

♻️ Suggested improvement: Use named constants
import {
  LGraph,
  LGraphCanvas,
  LGraphNode,
  LiteGraph,
+ LGraphEventMode
} from '@/lib/litegraph/src/litegraph'

-          const isMuted = n.mode === 2 || n.mode === 4
+          const isMuted = n.mode === LGraphEventMode.NEVER || n.mode === LGraphEventMode.BYPASS
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/scripts/app.ts` around lines 1231 - 1256, The code uses magic numbers 2
and 4 to detect muted/bypassed nodes (n.mode === 2 || n.mode === 4); replace
those with the named enum constants exported from litegraph
(LGraphEventMode.BYPASS and LGraphEventMode.MUTED or the exact enum member names
provided by litegraph) so the condition reads something like n.mode ===
LGraphEventMode.X || n.mode === LGraphEventMode.Y; update the check near where
missingNodeTypes is pushed (referencing n.mode,
nodeReplacementStore.getReplacementFor, getCnrIdFromProperties,
sanitizeNodeName) to use the enum constants instead of the numeric literals and
keep the rest of the logic unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/composables/graph/useErrorClearingHooks.ts`:
- Around line 305-319: The onNodeRemoved handler currently only deletes exact
execId entries and can miss descendants and cases where getExecutionIdByNode
returns null after LiteGraph detaches the node; update graph.onNodeRemoved to
(1) derive a fallback execId when getExecutionIdByNode(app.rootGraph, node) is
null for subgraph root deletions (e.g., fallback to String(node.id) when node is
a SubgraphNode or node.type indicates a subgraph) and (2) call the stores' broad
removal helper (removeNodeErrors) instead of the exact-id removers so descendant
keys like `${execId}:...` are cleared—adjust calls to
useMissingModelStore().removeNodeErrors(execId),
useMissingMediaStore().removeNodeErrors(execId), and
useMissingNodesErrorStore().removeNodeErrors(execId) inside graph.onNodeRemoved
alongside the existing logic (refer to graph.onNodeRemoved,
getExecutionIdByNode, and the removeNodeErrors methods).

---

Outside diff comments:
In `@src/platform/missingModel/missingModelScan.ts`:
- Around line 73-92: The loop currently treats any node with an active mode as
executable even if it is not connected; update the predicate before calling
scanNodeModelCandidates to also require the node be connected (e.g., has at
least one incoming or outgoing connection/edge) in addition to the existing mode
checks and subgraph check — apply the same connectivity requirement inside
hasActiveNodes so workflow-level embedded models are not treated as active when
there is no executable path; reference the node properties used here (node.mode,
node.isSubgraphNode, node.widgets) and the functions scanNodeModelCandidates and
hasActiveNodes to locate where to add the connectivity check.

In `@src/platform/workflow/core/services/workflowService.ts`:
- Around line 251-265: openWorkflow() can leak the previous workflow's
missing-model/media state because when loadGraphData is called with
skipAssetScans: true the asset stores are left untouched and
showPendingWarnings() will surface stale cards; fix by clearing the relevant
missing-asset state before calling showPendingWarnings(). Specifically, in the
openWorkflow() / workflow restore path where app.loadGraphData(..., {
skipAssetScans: true, ... }) is invoked, call the app or workflow-level method
that resets pending asset warnings (e.g., clearPendingWarnings(),
resetMissingModels(), resetMissingMedia(), or clear asset-manager scan caches)
right after loadGraphData returns and before showPendingWarnings() is called so
the warning UI only reflects the newly-loaded workflow. Ensure the same change
is applied to the other restore location noted (lines ~578-615).

In `@src/scripts/app.ts`:
- Around line 1129-1145: The options interface declares showMissingNodes and
showMissingModels but they are never read; either remove these deprecated
properties from the function signature and update callers to stop passing them,
or explicitly extract them from options (e.g., const { showMissingNodes,
showMissingModels, silentAssetErrors = false, ... } = options) and use them when
invoking the suppression logic (pass the appropriate flag(s) into
runMissingModelPipeline and runMissingMediaPipeline in place of or alongside
silentAssetErrors so callers’ expectations are honored). Ensure references to
showMissingNodes and showMissingModels are added where missing (or removed from
callers) and keep silentAssetErrors behavior consistent with the chosen
approach.

---

Nitpick comments:
In `@src/platform/missingMedia/missingMediaStore.ts`:
- Around line 143-149: The addMissingMedia function currently appends candidates
blindly and can create duplicates; make it idempotent by deduplicating new
entries against existing missingMediaCandidates using a stable key (e.g., nodeId
+ widgetName + name). In the addMissingMedia implementation, compute the stable
key for each incoming MissingMediaCandidate, build a Set of existing keys from
missingMediaCandidates.value, filter incoming media to only those whose key is
not present, then append those filtered candidates (or replace the array with a
deterministically ordered union) and update missingMediaCandidates.value. Ensure
the dedupe logic references addMissingMedia and missingMediaCandidates so state
changes remain serializable and deterministic.

In `@src/platform/missingModel/missingModelStore.ts`:
- Around line 131-138: removeMissingModelsByNodeId currently only updates
missingModelCandidates and can leave stale interaction state; update it to
mirror removeMissingMediaByNodeId by identifying which candidate nodeIds were
removed (compare prior missingModelCandidates to the filtered result or collect
them during filter) and then delete/clean corresponding entries from
modelExpandState, urlInputs, fileSizes (and any other per-candidate maps), and
if those maps become empty set them to null; also ensure behavior remains
consistent with clearMissingModels and use the existing symbols
removeMissingModelsByNodeId, missingModelCandidates, modelExpandState,
urlInputs, fileSizes, and clearMissingModels to locate and implement the
cleanup.

In `@src/scripts/app.ts`:
- Around line 1602-1616: The pendingWarnings null-cleanup is duplicated between
cacheModelCandidates and runMissingModelPipeline; extract a helper like
cleanupPendingWarnings(wf: ComfyWorkflow) that checks
wf.pendingWarnings?.missingNodeTypes, .missingModelCandidates, and
.missingMediaCandidates and sets wf.pendingWarnings = null when all are falsy,
then replace the duplicated block in cacheModelCandidates and
runMissingModelPipeline with a call to cleanupPendingWarnings(wf) to remove
duplication and centralize the logic.
- Around line 1231-1256: The code uses magic numbers 2 and 4 to detect
muted/bypassed nodes (n.mode === 2 || n.mode === 4); replace those with the
named enum constants exported from litegraph (LGraphEventMode.BYPASS and
LGraphEventMode.MUTED or the exact enum member names provided by litegraph) so
the condition reads something like n.mode === LGraphEventMode.X || n.mode ===
LGraphEventMode.Y; update the check near where missingNodeTypes is pushed
(referencing n.mode, nodeReplacementStore.getReplacementFor,
getCnrIdFromProperties, sanitizeNodeName) to use the enum constants instead of
the numeric literals and keep the rest of the logic unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c8211583-5310-41bc-9459-0c1d8cecf852

📥 Commits

Reviewing files that changed from the base of the PR and between 6c1bf7a and a436c40.

📒 Files selected for processing (24)
  • src/components/rightSidePanel/RightSidePanel.vue
  • src/components/rightSidePanel/errors/TabErrors.vue
  • src/components/rightSidePanel/errors/useErrorGroups.ts
  • src/composables/graph/useErrorClearingHooks.ts
  • src/platform/missingMedia/missingMediaScan.test.ts
  • src/platform/missingMedia/missingMediaScan.ts
  • src/platform/missingMedia/missingMediaStore.test.ts
  • src/platform/missingMedia/missingMediaStore.ts
  • src/platform/missingModel/components/MissingModelRow.vue
  • src/platform/missingModel/missingModelScan.test.ts
  • src/platform/missingModel/missingModelScan.ts
  • src/platform/missingModel/missingModelStore.test.ts
  • src/platform/missingModel/missingModelStore.ts
  • src/platform/nodeReplacement/missingNodeScan.test.ts
  • src/platform/nodeReplacement/missingNodeScan.ts
  • src/platform/nodeReplacement/missingNodesErrorStore.test.ts
  • src/platform/nodeReplacement/missingNodesErrorStore.ts
  • src/platform/workflow/core/services/workflowService.test.ts
  • src/platform/workflow/core/services/workflowService.ts
  • src/platform/workflow/management/stores/comfyWorkflow.ts
  • src/scripts/app.ts
  • src/scripts/changeTracker.ts
  • src/stores/executionErrorStore.test.ts
  • src/stores/executionErrorStore.ts

- Replace magic numbers (2, 4) with LGraphEventMode.NEVER/BYPASS
- Remove unused showMissingNodes/showMissingModels options from
  loadGraphData and all callers
- Make addMissingModels/addMissingMedia idempotent (deduplicate by
  nodeId::widgetName::name key)
- Extract cleanupPendingWarnings helper to eliminate duplication
  across cacheModelCandidates, cacheMediaCandidates, and
  runMissingModelPipeline
- Clean interaction state (expandState, urlInputs, fileSizes, etc.)
  in removeMissingModelsByNodeId, mirroring missingMediaStore pattern
- Fix subgraph deletion edge case: use removeNodeErrors (prefix-based
  removal) in onNodeRemoved; add fallback execId for detached nodes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/scripts/app.ts`:
- Around line 1610-1628: cacheModelCandidates and cacheMediaCandidates read
useWorkspaceStore().workflow.activeWorkflow at call time, risking writing
pendingWarnings into a different workflow after async operations; change these
helpers to accept the workflow (or its stable id) captured at scan start and use
that passed-in wf when setting wf.pendingWarnings and calling
cleanupPendingWarnings so they no longer call
useWorkspaceStore().workflow.activeWorkflow inside the helper — update all call
sites (the async callbacks around lines where the scan starts) to pass the
captured wf (or wf.id) into cacheModelCandidates/cacheMediaCandidates and
cleanupPendingWarnings.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3eae40dc-7a11-4bbc-ba97-a7c7a230e642

📥 Commits

Reviewing files that changed from the base of the PR and between a436c40 and edfa38c.

📒 Files selected for processing (6)
  • src/composables/graph/useErrorClearingHooks.ts
  • src/platform/missingMedia/missingMediaStore.ts
  • src/platform/missingModel/missingModelStore.ts
  • src/platform/workflow/core/services/workflowService.ts
  • src/scripts/app.ts
  • src/scripts/changeTracker.ts
✅ Files skipped from review due to trivial changes (1)
  • src/composables/graph/useErrorClearingHooks.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • src/platform/missingMedia/missingMediaStore.ts
  • src/platform/missingModel/missingModelStore.ts
  • src/platform/workflow/core/services/workflowService.ts

Comment thread src/scripts/app.ts Resolved
cacheModelCandidates/cacheMediaCandidates previously read
activeWorkflow at callback time, which could target the wrong
workflow after an async tab switch. Now both pipelines capture
the workflow reference at start and pass it to cache helpers.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/scripts/app.ts (1)

1528-1540: ⚠️ Potential issue | 🟡 Minor

Mark these detached promise chains with void.

Both calls at lines 1528–1540 and 1559–1577 are intentionally fire-and-forget but lack the void prefix, which violates the repo's Oxlint typescript/no-floating-promises error rule (enforced in .oxlintrc.json). Line 1648 already demonstrates the correct pattern. Add void to suppress the linter:

Suggested fix
-        verifyAssetSupportedCandidates(enrichedCandidates, controller.signal)
+        void verifyAssetSupportedCandidates(enrichedCandidates, controller.signal)
           .then(() => {
             if (controller.signal.aborted) return
             const confirmed = enrichedCandidates.filter(
               (c) => c.isMissing === true
             )
             if (confirmed.length) {
               useExecutionErrorStore().surfaceMissingModels(confirmed, {
                 silent
               })
             }
             this.cacheModelCandidates(activeWf, confirmed)
           })
-          api
+          void api
             .getFolderPaths()
             .then((paths) => {
               if (controller.signal.aborted) return
               missingModelStore.setFolderPaths(paths)
             })
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/scripts/app.ts` around lines 1528 - 1540, The promise chains that call
verifyAssetSupportedCandidates(...) (the block that then filters
enrichedCandidates, calls useExecutionErrorStore().surfaceMissingModels(...),
and this.cacheModelCandidates(...)) and the similar fire-and-forget chain later
must be prefixed with void to mark them intentionally detached; update the call
sites so they use void verifyAssetSupportedCandidates(...).then(...) (and the
analogous second call) to satisfy the typescript/no-floating-promises rule and
match the pattern used at the existing correctly-marked example.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/scripts/app.ts`:
- Around line 1435-1448: The early return when skipAssetScans is true prevents
the only update to wf.pendingWarnings that lives inside runMissingModelPipeline,
causing stale warnings; ensure pending warnings are updated even when asset
scans are skipped by extracting or invoking the pending-warnings update logic
outside runMissingModelPipeline. Concretely, either (A) move the code that
writes to wf.pendingWarnings from runMissingModelPipeline into a shared helper
and call it here after recomputing missingNodeTypes, or (B) call
runMissingModelPipeline with a lightweight flag/variant (e.g.,
runMissingModelPipeline(..., { updateOnly: true })) that performs only the
pending-warnings write when skipAssetScans is true; reference
runMissingModelPipeline, runMissingMediaPipeline, skipAssetScans and
useWorkflowService().showPendingWarnings/wf.pendingWarnings when making the
change.

---

Outside diff comments:
In `@src/scripts/app.ts`:
- Around line 1528-1540: The promise chains that call
verifyAssetSupportedCandidates(...) (the block that then filters
enrichedCandidates, calls useExecutionErrorStore().surfaceMissingModels(...),
and this.cacheModelCandidates(...)) and the similar fire-and-forget chain later
must be prefixed with void to mark them intentionally detached; update the call
sites so they use void verifyAssetSupportedCandidates(...).then(...) (and the
analogous second call) to satisfy the typescript/no-floating-promises rule and
match the pattern used at the existing correctly-marked example.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8ec41664-7be6-40dc-9215-cc8b7b4d3aea

📥 Commits

Reviewing files that changed from the base of the PR and between edfa38c and f1cbc15.

📒 Files selected for processing (1)
  • src/scripts/app.ts

Comment thread src/scripts/app.ts Resolved
@codecov

codecov Bot commented Apr 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.41048% with 163 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/scripts/app.ts 0.00% 67 Missing ⚠️
...components/rightSidePanel/errors/useErrorGroups.ts 10.16% 51 Missing and 2 partials ⚠️
src/composables/graph/useErrorClearingHooks.ts 83.49% 17 Missing ⚠️
...atform/missingModel/components/MissingModelRow.vue 0.00% 9 Missing ⚠️
src/components/rightSidePanel/RightSidePanel.vue 0.00% 8 Missing ⚠️
...platform/workflow/core/services/workflowService.ts 78.37% 6 Missing and 2 partials ⚠️
src/platform/missingMedia/missingMediaScan.ts 95.83% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main   #10856      +/-   ##
==========================================
+ Coverage   43.36%   43.64%   +0.27%     
==========================================
  Files        1347     1349       +2     
  Lines       68470    69149     +679     
  Branches    18052    19159    +1107     
==========================================
+ Hits        29694    30181     +487     
- Misses      38186    38370     +184     
- Partials      590      598       +8     
Files with missing lines Coverage Δ
src/components/rightSidePanel/errors/TabErrors.vue 55.90% <100.00%> (ø)
src/platform/missingMedia/missingMediaStore.ts 93.13% <100.00%> (+4.07%) ⬆️
src/platform/missingModel/missingModelScan.ts 96.13% <100.00%> (+5.34%) ⬆️
src/platform/missingModel/missingModelStore.ts 88.07% <100.00%> (+5.55%) ⬆️
src/platform/nodeReplacement/missingNodeScan.ts 100.00% <100.00%> (ø)
...platform/nodeReplacement/missingNodesErrorStore.ts 75.38% <100.00%> (+6.15%) ⬆️
...atform/workflow/management/stores/comfyWorkflow.ts 77.92% <ø> (ø)
src/scripts/changeTracker.ts 10.55% <ø> (ø)
src/stores/executionErrorStore.ts 70.19% <100.00%> (+4.42%) ⬆️
src/utils/graphTraversalUtil.ts 87.55% <100.00%> (+0.73%) ⬆️
... and 7 more

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jaeone94 and others added 5 commits April 10, 2026 13:57
- Update missing_models.json fixture to include an active node so
  the hasActiveNodes filter passes, with matching directory for URL
  enrichment
- Split workflow tab-switch test into two: verify overlay stays
  silent and verify missing nodes data restores in errors tab
- Add openErrorsTab helper to ErrorsTabHelper for reusable
  properties panel errors tab access
- Add errorsTabModeAware.spec.ts covering bypass/activate, deletion,
  undo/redo, paste, node selection filtering, and subgraph scenarios
  for missing models, media, and nodes
- Add bypassed variant fixtures for missing models and media
- Add subgraph fixture with interior CheckpointLoaderSimple
- Add data-testid to RightSidePanel tabs for stable selectors
- Update ErrorsTabHelper to use test-id based openErrorsTab helper
- Fix missing_models_with_nodes fixture directory mismatch
- Move error-related TestIds from dialogs to errorsTab namespace
- Remove unused TestIdValue type
- Extract cleanupFakeModel to shared ErrorsTabHelper
- Rename openErrorsTabViaSeeErrors to loadWorkflowAndOpenErrorsTab
- Move workflow-switching error tests from workflows.spec.ts to
  errorsTabModeAware.spec.ts
- Add afterEach cleanup for fake model tests
- Add missing model deletion and undo/redo tests
- Remove explicit timeout: 3000 on negative visibility assertions
- Add aria-label to pencil edit button and subgraph toggle
- Add i18n keys for editTitle and editSubgraph
- Add JSDoc comment on cleanupFakeModel explaining fixture URLs
- Replace selectAll+bypass with node-specific click+bypass in
  missing media tests for deterministic behavior
- Move media fixture nodes from y:50 to y:200 to avoid top menu overlap
- Replace deselectAll evaluate with canvas.click at empty position

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts (2)

50-64: Consider extracting repeated bypass/un-bypass assertions into a helper

The bypass toggle + isBypassed polling + group visibility checks are repeated across multiple tests. Moving this to ErrorsTabHelper would reduce duplication and future drift.

Also applies to: 103-113, 262-272, 193-207

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts` around lines
50 - 64, Extract the repeated sequence that toggles bypass and asserts state
into a helper on ErrorsTabHelper: create a method (e.g., toggleAndAssertBypass)
that accepts the nodeRef (from comfyPage.nodeOps.getNodeRefById), the action to
perform (bypass/undo/redo via comfyPage.keyboard.bypass/undo/redo or a string
enum), and expected booleans for node.isBypassed and visibility of
missingNodeGroup/errorOverlay; replace the repeated blocks (the ones using
node.click('title'), comfyPage.keyboard.bypass/undo/redo, expect.poll(() =>
node.isBypassed()), expect(missingNodeGroup).(not.)toBeVisible(),
expect(errorOverlay).(not.)toBeVisible()) with calls to
ErrorsTabHelper.toggleAndAssertBypass and keep openErrorsTab calls where needed.
Ensure the helper polls node.isBypassed and performs both visibility assertions
so all duplicated sequences (lines referenced) use this single helper.

324-324: Avoid fixed canvas coordinates for deselection

Line 324 hard-codes a click position, which can become flaky with viewport/layout drift. Prefer a non-positional deselect action (same pattern already used elsewhere in this file).

Proposed change
-      await comfyPage.canvas.click({ position: { x: 400, y: 600 } })
+      await comfyPage.canvas.click()
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts` at line 324,
Replace the hard-coded positional click in the test (the call to
comfyPage.canvas.click({ position: { x: 400, y: 600 } })) with a non-positional
deselect action used elsewhere in this spec file—e.g., call
comfyPage.canvas.click() without a position (or the file’s existing deselect
helper if present) so the test does not rely on fixed canvas coordinates.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts`:
- Around line 50-64: Extract the repeated sequence that toggles bypass and
asserts state into a helper on ErrorsTabHelper: create a method (e.g.,
toggleAndAssertBypass) that accepts the nodeRef (from
comfyPage.nodeOps.getNodeRefById), the action to perform (bypass/undo/redo via
comfyPage.keyboard.bypass/undo/redo or a string enum), and expected booleans for
node.isBypassed and visibility of missingNodeGroup/errorOverlay; replace the
repeated blocks (the ones using node.click('title'),
comfyPage.keyboard.bypass/undo/redo, expect.poll(() => node.isBypassed()),
expect(missingNodeGroup).(not.)toBeVisible(),
expect(errorOverlay).(not.)toBeVisible()) with calls to
ErrorsTabHelper.toggleAndAssertBypass and keep openErrorsTab calls where needed.
Ensure the helper polls node.isBypassed and performs both visibility assertions
so all duplicated sequences (lines referenced) use this single helper.
- Line 324: Replace the hard-coded positional click in the test (the call to
comfyPage.canvas.click({ position: { x: 400, y: 600 } })) with a non-positional
deselect action used elsewhere in this spec file—e.g., call
comfyPage.canvas.click() without a position (or the file’s existing deselect
helper if present) so the test does not rely on fixed canvas coordinates.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2a8d3d12-8db8-45fc-9d21-22d8a2765d7f

📥 Commits

Reviewing files that changed from the base of the PR and between 2fc44ae and 4d29505.

📒 Files selected for processing (17)
  • browser_tests/assets/missing/missing_media_bypassed.json
  • browser_tests/assets/missing/missing_media_multiple.json
  • browser_tests/assets/missing/missing_media_single.json
  • browser_tests/assets/missing/missing_models.json
  • browser_tests/assets/missing/missing_models_bypassed.json
  • browser_tests/assets/missing/missing_models_in_subgraph.json
  • browser_tests/assets/missing/missing_models_with_nodes.json
  • browser_tests/fixtures/selectors.ts
  • browser_tests/tests/errorOverlay.spec.ts
  • browser_tests/tests/propertiesPanel/ErrorsTabHelper.ts
  • browser_tests/tests/propertiesPanel/errorsTab.spec.ts
  • browser_tests/tests/propertiesPanel/errorsTabExecution.spec.ts
  • browser_tests/tests/propertiesPanel/errorsTabMissingMedia.spec.ts
  • browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts
  • browser_tests/tests/propertiesPanel/errorsTabMissingNodes.spec.ts
  • browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts
  • browser_tests/tests/sidebar/workflows.spec.ts
💤 Files with no reviewable changes (1)
  • browser_tests/tests/sidebar/workflows.spec.ts
✅ Files skipped from review due to trivial changes (7)
  • browser_tests/assets/missing/missing_media_single.json
  • browser_tests/assets/missing/missing_media_multiple.json
  • browser_tests/assets/missing/missing_models_with_nodes.json
  • browser_tests/assets/missing/missing_models.json
  • browser_tests/assets/missing/missing_media_bypassed.json
  • browser_tests/assets/missing/missing_models_bypassed.json
  • browser_tests/assets/missing/missing_models_in_subgraph.json

coderabbitai[bot]
coderabbitai Bot previously approved these changes Apr 10, 2026
- Move overlay non-resurface test to errorOverlay.spec.ts Persistence
- Add sidebar setup for workflow switching test
- Fix copy-name button click intercepted by copy-url button
- Add void prefix to floating promise chains in app.ts
@jaeone94 jaeone94 added the New Browser Test Expectations New browser test screenshot should be set by github action label Apr 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Updating Playwright Expectations

@jaeone94

Copy link
Copy Markdown
Collaborator Author

Nodes in mute or bypass mode are now excluded from the "missing model" error, which causes some failures in the screenshot test. To resolve this, a new screenshot is captured.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Backport to core/1.43 failed

Reason: Merge conflicts detected during cherry-pick of 521019d

📄 Conflicting files
browser_tests/tests/errorOverlay.spec.ts
browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts
🤖 Prompt for AI Agents
Backport PR #10856 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/10856) to core/1.43.
Cherry-pick merge commit 521019d173907536ae8032f110473ae7d0f15930 onto new branch
backport-10856-to-core-1.43 from origin/core/1.43.
Resolve conflicts in: browser_tests/tests/errorOverlay.spec.ts browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts .
For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport core/1.43] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @jaeone94

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Backport to cloud/1.43 failed

Reason: Merge conflicts detected during cherry-pick of 521019d

📄 Conflicting files
browser_tests/tests/errorOverlay.spec.ts
browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts
🤖 Prompt for AI Agents
Backport PR #10856 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/10856) to cloud/1.43.
Cherry-pick merge commit 521019d173907536ae8032f110473ae7d0f15930 onto new branch
backport-10856-to-cloud-1.43 from origin/cloud/1.43.
Resolve conflicts in: browser_tests/tests/errorOverlay.spec.ts browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts .
For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport cloud/1.43] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @jaeone94

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Backport to core/1.43 failed

Reason: Merge conflicts detected during cherry-pick of 521019d

📄 Conflicting files
browser_tests/tests/errorOverlay.spec.ts
browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts
🤖 Prompt for AI Agents
Backport PR #10856 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/10856) to core/1.43.
Cherry-pick merge commit 521019d173907536ae8032f110473ae7d0f15930 onto new branch
backport-10856-to-core-1.43 from origin/core/1.43.
Resolve conflicts in: browser_tests/tests/errorOverlay.spec.ts browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts .
For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport core/1.43] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @jaeone94

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Backport to cloud/1.43 failed

Reason: Merge conflicts detected during cherry-pick of 521019d

📄 Conflicting files
browser_tests/tests/errorOverlay.spec.ts
browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts
🤖 Prompt for AI Agents
Backport PR #10856 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/10856) to cloud/1.43.
Cherry-pick merge commit 521019d173907536ae8032f110473ae7d0f15930 onto new branch
backport-10856-to-cloud-1.43 from origin/cloud/1.43.
Resolve conflicts in: browser_tests/tests/errorOverlay.spec.ts browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts .
For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport cloud/1.43] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @jaeone94

jaeone94 added a commit that referenced this pull request Apr 14, 2026
…sset detection (#10856)

Cherry-pick of 521019d onto core/1.43.

Manual conflict resolution on two files, both limited to the
`cleanupFakeModel` helper extraction:
- browser_tests/tests/errorOverlay.spec.ts
- browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts

core/1.43 base still had the inline `expect(cleanupOk).toBeTruthy()`
implementation; main's version (post-#10967) uses `expect.poll()`
inline; #10856 replaced both with `await cleanupFakeModel(comfyPage)`
calling the new helper in ErrorsTabHelper.ts. Conflict resolved by
accepting the PR version (helper call) on both files, since the new
helper is added in this same commit.
jaeone94 added a commit that referenced this pull request Apr 14, 2026
…asset detection (#10856)

Cherry-pick of 521019d onto cloud/1.43.

Manual conflict resolution on two files (same root cause as the
core/1.43 backport), both limited to the `cleanupFakeModel` helper
extraction:
- browser_tests/tests/errorOverlay.spec.ts
- browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts

cloud/1.43 base still had the inline `expect(cleanupOk).toBeTruthy()`
implementation; #10856 replaced both sites with `await cleanupFakeModel(comfyPage)`
calling the new helper in ErrorsTabHelper.ts. Conflict resolved by
accepting the PR version (helper call); the helper itself is added
in this same commit.
jaeone94 added a commit that referenced this pull request Apr 14, 2026
1. ErrorOverlay count reflected node-selection filtering.
useErrorGroups exposed filteredMissingModelGroups under the name
missingModelGroups. ErrorOverlay read that alias for its model count
label, so selecting a node shrunk the overlay's total. Expose both
unfiltered (missingModelGroups / missingMediaGroups) and filtered
variants so ErrorOverlay gets the true total and the errors tab still
gets selection-scoped groups. TabErrors renamed its destructure.

2. bypass/un-bypass of a missing-model node dropped url/hash metadata.
Realtime scanNodeModelCandidates only reads widget values, so
un-bypass produced a fresh candidate without the url that
enrichWithEmbeddedMetadata had previously attached from
graphData.models. Add enrichCandidateFromNodeProperties which copies
url/hash/directory from the node's own properties.models (persistent
across mode toggles). Applies to every call site of the per-node
scan, so paste, un-bypass, and mode change all restore the metadata.

3. Initial full scan surfaced interior errors of muted/bypassed
subgraph containers. scanAllModelCandidates, scanAllMediaCandidates,
and the JSON missing-node scan only check each node's own mode;
interior nodes whose parent container is bypassed passed through.
Runtime handleNodeModeChange already filters correctly — the bug
was scoped to the initial-load path. Add isAncestorPathActive to
graphTraversalUtil and post-filter the three pipelines in
runMissingModelPipeline / runMissingMediaPipeline /
loadGraphData before the results are cached or surfaced.
github-merge-queue Bot pushed a commit that referenced this pull request Apr 15, 2026
Follow-up to #10856. Four correctness issues and their regression tests.

## Bugs fixed

### 1. ErrorOverlay model count reflected node selection

`useErrorGroups` exposed `filteredMissingModelGroups` under the public
name `missingModelGroups`. `ErrorOverlay.vue` read that alias to compute
its model count label, so selecting a node shrank the overlay total. The
overlay must always show the whole workflow's errors.

Exposed both shapes explicitly: `missingModelGroups` /
`missingMediaGroups` (unfiltered totals) and
`filteredMissingModelGroups` / `filteredMissingMediaGroups`
(selection-scoped). `TabErrors.vue` destructures the filtered variant
with an alias.


Before 


https://github.com/user-attachments/assets/eb848c5f-d092-4a4f-b86f-d22bb4408003

After 


https://github.com/user-attachments/assets/75e67819-c9f2-45ec-9241-74023eca6120



### 2. Bypass → un-bypass dropped url/hash metadata

Realtime `scanNodeModelCandidates` only reads widget values, so
un-bypass produced a fresh candidate without the url that
`enrichWithEmbeddedMetadata` had previously attached from
`graphData.models`. `MissingModelRow`'s download/copy-url buttons
disappeared after a bypass/un-bypass cycle.

Added `enrichCandidateFromNodeProperties` that copies
`url`/`hash`/`directory` from the node's own `properties.models` — which
persists across mode toggles — into each scanned candidate. Applied to
every call site of the per-node scan. A later fix in the same branch
also enforces directory agreement to prevent a same-name /
different-directory collision from stamping the wrong metadata.

Before 


https://github.com/user-attachments/assets/39039d83-4d55-41a9-9d01-dec40843741b

After 


https://github.com/user-attachments/assets/047a603b-fb52-4320-886d-dfeed457d833



### 3. Initial full scan surfaced interior errors of a muted/bypassed
subgraph container

`scanAllModelCandidates`, `scanAllMediaCandidates`, and the JSON-based
missing-node scan only check each node's own mode. Interior nodes whose
parent container was bypassed passed the filter.

Added `isAncestorPathActive(rootGraph, executionId)` to
`graphTraversalUtil` and post-filter the three pipelines in `app.ts`
after the live rootGraph is configured. The filter uses the execution-ID
path (`"65:63"` → check node 65's mode) so it handles both
live-scan-produced and JSON-enrichment-produced candidates.

Before


https://github.com/user-attachments/assets/3032d46b-81cd-420e-ab8e-f58392267602

After 


https://github.com/user-attachments/assets/02a01931-951d-4a48-986c-06424044fbf8




### 4. Bypassed subgraph entry re-surfaced interior errors

`useGraphNodeManager` replays `graph.onNodeAdded` for each existing
interior node when the Vue node manager initializes on subgraph entry.
That chain reached `scanSingleNodeErrors` via
`installErrorClearingHooks`' `onNodeAdded` override. Each interior
node's own mode was active, so the caller guards passed and the scan
re-introduced the error that the initial pipeline had correctly
suppressed.

Added an ancestor-activity gate at the top of `scanSingleNodeErrors`,
the single entry point shared by paste, un-bypass, subgraph entry, and
subgraph container activation. A later commit also hardens this guard
against detached nodes (null execution ID → skip) and applies the same
ancestor check to `isCandidateStillActive` in the realtime verification
callback.

Before


https://github.com/user-attachments/assets/fe44862d-f1d6-41ed-982d-614a7e83d441

After


https://github.com/user-attachments/assets/497a76ce-3caa-479f-9024-4cd0f7bd20a4



## Tests

- 6 unit tests for `isAncestorPathActive` (root, active,
immediate-bypass, deep-nested mute, unresolvable ancestor, null
rootGraph)
- 4 unit tests for `enrichCandidateFromNodeProperties` (enrichment,
no-overwrite, name mismatch, directory mismatch)
- 1 unit test for `scanSingleNodeErrors` ancestor guard (subgraph entry
replaying onNodeAdded)
- 2 unit tests for `useErrorGroups` dual export + ErrorOverlay contract
- 4 E2E tests:
- ErrorOverlay model count stays constant when a node is selected (new
fixture `missing_models_distinct.json`)
- Bypass/un-bypass cycle preserves Copy URL button (uses
`missing_models_from_node_properties`)
- Loading a workflow with bypassed subgraph suppresses interior missing
model error (new fixture `missing_models_in_bypassed_subgraph.json`)
- Entering a bypassed subgraph does not resurface interior missing model
error (shares the above fixture)

`pnpm typecheck`, `pnpm lint`, 206 related unit tests passing.

## Follow-up

Several items raised by code review are deferred as pre-existing tech
debt or scope-avoided refactors. Tracked via comments on #11215 and
#11216.

---
Follows up on #10856.
christian-byrne added a commit that referenced this pull request Apr 20, 2026
…sset detection (#10856) (#11217)

Manual backport of #10856 to `core/1.43`.

## Conflicts resolved

Two files had trivial conflicts from the same root cause — #10856
extracted the inline `cleanup_fake_model` block into a shared
`cleanupFakeModel` helper in
`browser_tests/tests/propertiesPanel/ErrorsTabHelper.ts`:

- `browser_tests/tests/errorOverlay.spec.ts`
- `browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts`

`core/1.43` still carries the original inline
`expect(cleanupOk).toBeTruthy()` form. main's version (post-#10967) uses
an inline `expect.poll()` instead. #10856 replaces both with `await
cleanupFakeModel(comfyPage)` calling the helper added by this same PR.

Resolution: accepted the PR version (helper call) on both conflict
sites. The helper itself is added as part of this backport, so no
runtime behavior is lost.

## Verification

- No residual conflict markers
- Cherry-picked commit carries the entire #10856 squash (45 files,
+3596/-209)

## Original PR summary

See #10856 for full behavioral description, test plan, and screenshots.

---
Fixes Comfy-Org/ComfyUI#13256 on core/1.43

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-11217-backport-core-1-43-fix-exclude-muted-bypassed-nodes-from-missing-asset-detection-10-3426d73d365081f0becbcf7d909f0021)
by [Unito](https://www.unito.io)

Co-authored-by: Christian Byrne <cbyrne@comfy.org>
christian-byrne added a commit that referenced this pull request Apr 20, 2026
…asset detection (#10856) (#11218)

Manual backport of #10856 to `cloud/1.43`.

Paired with core/1.43 backport #11217.

## Conflicts resolved

Same two files, same root cause as the core/1.43 backport — #10856
extracted the inline `cleanup_fake_model` block into a shared
`cleanupFakeModel` helper in
`browser_tests/tests/propertiesPanel/ErrorsTabHelper.ts`:

- `browser_tests/tests/errorOverlay.spec.ts`
- `browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts`

`cloud/1.43` still carries the original inline
`expect(cleanupOk).toBeTruthy()` form. #10856 replaces both with `await
cleanupFakeModel(comfyPage)` calling the helper added by this same PR.

Resolution: accepted the PR version (helper call) on both conflict
sites. The helper itself is added as part of this backport, so no
runtime behavior is lost.

## Verification

- No residual conflict markers
- Cherry-picked commit carries the entire #10856 squash (45 files,
+3596/-209)

## Original PR summary

See #10856 for full behavioral description, test plan, and screenshots.

---
Fixes Comfy-Org/ComfyUI#13256 on cloud/1.43

┆Issue is synchronized with this [Notion
page](https://app.notion.com/p/PR-11218-backport-cloud-1-43-fix-exclude-muted-bypassed-nodes-from-missing-asset-detection-1-3426d73d3650811e9a27d4a334c74de8)
by [Unito](https://www.unito.io)

Co-authored-by: Christian Byrne <cbyrne@comfy.org>
github-actions Bot pushed a commit that referenced this pull request Apr 20, 2026
Follow-up to #10856. Four correctness issues and their regression tests.

## Bugs fixed

### 1. ErrorOverlay model count reflected node selection

`useErrorGroups` exposed `filteredMissingModelGroups` under the public
name `missingModelGroups`. `ErrorOverlay.vue` read that alias to compute
its model count label, so selecting a node shrank the overlay total. The
overlay must always show the whole workflow's errors.

Exposed both shapes explicitly: `missingModelGroups` /
`missingMediaGroups` (unfiltered totals) and
`filteredMissingModelGroups` / `filteredMissingMediaGroups`
(selection-scoped). `TabErrors.vue` destructures the filtered variant
with an alias.


Before 


https://github.com/user-attachments/assets/eb848c5f-d092-4a4f-b86f-d22bb4408003

After 


https://github.com/user-attachments/assets/75e67819-c9f2-45ec-9241-74023eca6120



### 2. Bypass → un-bypass dropped url/hash metadata

Realtime `scanNodeModelCandidates` only reads widget values, so
un-bypass produced a fresh candidate without the url that
`enrichWithEmbeddedMetadata` had previously attached from
`graphData.models`. `MissingModelRow`'s download/copy-url buttons
disappeared after a bypass/un-bypass cycle.

Added `enrichCandidateFromNodeProperties` that copies
`url`/`hash`/`directory` from the node's own `properties.models` — which
persists across mode toggles — into each scanned candidate. Applied to
every call site of the per-node scan. A later fix in the same branch
also enforces directory agreement to prevent a same-name /
different-directory collision from stamping the wrong metadata.

Before 


https://github.com/user-attachments/assets/39039d83-4d55-41a9-9d01-dec40843741b

After 


https://github.com/user-attachments/assets/047a603b-fb52-4320-886d-dfeed457d833



### 3. Initial full scan surfaced interior errors of a muted/bypassed
subgraph container

`scanAllModelCandidates`, `scanAllMediaCandidates`, and the JSON-based
missing-node scan only check each node's own mode. Interior nodes whose
parent container was bypassed passed the filter.

Added `isAncestorPathActive(rootGraph, executionId)` to
`graphTraversalUtil` and post-filter the three pipelines in `app.ts`
after the live rootGraph is configured. The filter uses the execution-ID
path (`"65:63"` → check node 65's mode) so it handles both
live-scan-produced and JSON-enrichment-produced candidates.

Before


https://github.com/user-attachments/assets/3032d46b-81cd-420e-ab8e-f58392267602

After 


https://github.com/user-attachments/assets/02a01931-951d-4a48-986c-06424044fbf8




### 4. Bypassed subgraph entry re-surfaced interior errors

`useGraphNodeManager` replays `graph.onNodeAdded` for each existing
interior node when the Vue node manager initializes on subgraph entry.
That chain reached `scanSingleNodeErrors` via
`installErrorClearingHooks`' `onNodeAdded` override. Each interior
node's own mode was active, so the caller guards passed and the scan
re-introduced the error that the initial pipeline had correctly
suppressed.

Added an ancestor-activity gate at the top of `scanSingleNodeErrors`,
the single entry point shared by paste, un-bypass, subgraph entry, and
subgraph container activation. A later commit also hardens this guard
against detached nodes (null execution ID → skip) and applies the same
ancestor check to `isCandidateStillActive` in the realtime verification
callback.

Before


https://github.com/user-attachments/assets/fe44862d-f1d6-41ed-982d-614a7e83d441

After


https://github.com/user-attachments/assets/497a76ce-3caa-479f-9024-4cd0f7bd20a4



## Tests

- 6 unit tests for `isAncestorPathActive` (root, active,
immediate-bypass, deep-nested mute, unresolvable ancestor, null
rootGraph)
- 4 unit tests for `enrichCandidateFromNodeProperties` (enrichment,
no-overwrite, name mismatch, directory mismatch)
- 1 unit test for `scanSingleNodeErrors` ancestor guard (subgraph entry
replaying onNodeAdded)
- 2 unit tests for `useErrorGroups` dual export + ErrorOverlay contract
- 4 E2E tests:
- ErrorOverlay model count stays constant when a node is selected (new
fixture `missing_models_distinct.json`)
- Bypass/un-bypass cycle preserves Copy URL button (uses
`missing_models_from_node_properties`)
- Loading a workflow with bypassed subgraph suppresses interior missing
model error (new fixture `missing_models_in_bypassed_subgraph.json`)
- Entering a bypassed subgraph does not resurface interior missing model
error (shares the above fixture)

`pnpm typecheck`, `pnpm lint`, 206 related unit tests passing.

## Follow-up

Several items raised by code review are deferred as pre-existing tech
debt or scope-avoided refactors. Tracked via comments on #11215 and
#11216.

---
Follows up on #10856.
github-actions Bot pushed a commit that referenced this pull request Apr 20, 2026
Follow-up to #10856. Four correctness issues and their regression tests.

## Bugs fixed

### 1. ErrorOverlay model count reflected node selection

`useErrorGroups` exposed `filteredMissingModelGroups` under the public
name `missingModelGroups`. `ErrorOverlay.vue` read that alias to compute
its model count label, so selecting a node shrank the overlay total. The
overlay must always show the whole workflow's errors.

Exposed both shapes explicitly: `missingModelGroups` /
`missingMediaGroups` (unfiltered totals) and
`filteredMissingModelGroups` / `filteredMissingMediaGroups`
(selection-scoped). `TabErrors.vue` destructures the filtered variant
with an alias.


Before 


https://github.com/user-attachments/assets/eb848c5f-d092-4a4f-b86f-d22bb4408003

After 


https://github.com/user-attachments/assets/75e67819-c9f2-45ec-9241-74023eca6120



### 2. Bypass → un-bypass dropped url/hash metadata

Realtime `scanNodeModelCandidates` only reads widget values, so
un-bypass produced a fresh candidate without the url that
`enrichWithEmbeddedMetadata` had previously attached from
`graphData.models`. `MissingModelRow`'s download/copy-url buttons
disappeared after a bypass/un-bypass cycle.

Added `enrichCandidateFromNodeProperties` that copies
`url`/`hash`/`directory` from the node's own `properties.models` — which
persists across mode toggles — into each scanned candidate. Applied to
every call site of the per-node scan. A later fix in the same branch
also enforces directory agreement to prevent a same-name /
different-directory collision from stamping the wrong metadata.

Before 


https://github.com/user-attachments/assets/39039d83-4d55-41a9-9d01-dec40843741b

After 


https://github.com/user-attachments/assets/047a603b-fb52-4320-886d-dfeed457d833



### 3. Initial full scan surfaced interior errors of a muted/bypassed
subgraph container

`scanAllModelCandidates`, `scanAllMediaCandidates`, and the JSON-based
missing-node scan only check each node's own mode. Interior nodes whose
parent container was bypassed passed the filter.

Added `isAncestorPathActive(rootGraph, executionId)` to
`graphTraversalUtil` and post-filter the three pipelines in `app.ts`
after the live rootGraph is configured. The filter uses the execution-ID
path (`"65:63"` → check node 65's mode) so it handles both
live-scan-produced and JSON-enrichment-produced candidates.

Before


https://github.com/user-attachments/assets/3032d46b-81cd-420e-ab8e-f58392267602

After 


https://github.com/user-attachments/assets/02a01931-951d-4a48-986c-06424044fbf8




### 4. Bypassed subgraph entry re-surfaced interior errors

`useGraphNodeManager` replays `graph.onNodeAdded` for each existing
interior node when the Vue node manager initializes on subgraph entry.
That chain reached `scanSingleNodeErrors` via
`installErrorClearingHooks`' `onNodeAdded` override. Each interior
node's own mode was active, so the caller guards passed and the scan
re-introduced the error that the initial pipeline had correctly
suppressed.

Added an ancestor-activity gate at the top of `scanSingleNodeErrors`,
the single entry point shared by paste, un-bypass, subgraph entry, and
subgraph container activation. A later commit also hardens this guard
against detached nodes (null execution ID → skip) and applies the same
ancestor check to `isCandidateStillActive` in the realtime verification
callback.

Before


https://github.com/user-attachments/assets/fe44862d-f1d6-41ed-982d-614a7e83d441

After


https://github.com/user-attachments/assets/497a76ce-3caa-479f-9024-4cd0f7bd20a4



## Tests

- 6 unit tests for `isAncestorPathActive` (root, active,
immediate-bypass, deep-nested mute, unresolvable ancestor, null
rootGraph)
- 4 unit tests for `enrichCandidateFromNodeProperties` (enrichment,
no-overwrite, name mismatch, directory mismatch)
- 1 unit test for `scanSingleNodeErrors` ancestor guard (subgraph entry
replaying onNodeAdded)
- 2 unit tests for `useErrorGroups` dual export + ErrorOverlay contract
- 4 E2E tests:
- ErrorOverlay model count stays constant when a node is selected (new
fixture `missing_models_distinct.json`)
- Bypass/un-bypass cycle preserves Copy URL button (uses
`missing_models_from_node_properties`)
- Loading a workflow with bypassed subgraph suppresses interior missing
model error (new fixture `missing_models_in_bypassed_subgraph.json`)
- Entering a bypassed subgraph does not resurface interior missing model
error (shares the above fixture)

`pnpm typecheck`, `pnpm lint`, 206 related unit tests passing.

## Follow-up

Several items raised by code review are deferred as pre-existing tech
debt or scope-avoided refactors. Tracked via comments on #11215 and
#11216.

---
Follows up on #10856.
comfy-pr-bot added a commit that referenced this pull request Apr 20, 2026
…10856 (#11466)

Backport of #11233 to `core/1.43`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-11466-backport-core-1-43-fix-missing-asset-correctness-follow-ups-from-10856-3486d73d365081bd94f4e9b8822a8320)
by [Unito](https://www.unito.io)

Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
comfy-pr-bot added a commit that referenced this pull request Apr 20, 2026
…10856 (#11467)

Backport of #11233 to `cloud/1.43`

Automatically created by backport workflow.

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-11467-backport-cloud-1-43-fix-missing-asset-correctness-follow-ups-from-10856-3486d73d3650811985a7ffef55c0810d)
by [Unito](https://www.unito.io)

Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
snomiao pushed a commit that referenced this pull request Apr 22, 2026
## Summary

Muted and bypassed nodes are excluded from execution but were still
triggering missing model/media/node warnings. This PR makes the error
system mode-aware: muted/bypassed nodes no longer produce missing asset
errors, and all error lifecycle events (mode toggle, deletion, paste,
undo, tab switch) are handled consistently.

- Fixes Comfy-Org/ComfyUI#13256

## Behavioral notes

- **Tab switch overlay suppression (intentional)**: Switching back to a
workflow with missing assets no longer re-shows the error overlay. This
reverses the behavior introduced in #10190. The error state is still
restored silently in the errors tab — users can access it via the
properties panel without being interrupted by the overlay on every tab
switch.

## Changes

### 1. Scan filtering

- `scanAllModelCandidates`, `scanAllMediaCandidates`,
`scanMissingNodes`: skip nodes with `mode === NEVER || BYPASS`
- `collectMissingNodes` (serialized data): skip error reporting for
muted/bypassed nodes while still calling `sanitizeNodeName` for safe
`configure()`
- `collectEmbeddedModelsWithSource`: skip muted/bypassed nodes;
workflow-level `graphData.models` only create candidates when active
nodes exist
- `enrichWithEmbeddedMetadata`: filter unmatched workflow-level models
when all referencing nodes are inactive

### 2. Realtime mode change handling

- `useErrorClearingHooks.ts` chains `graph.onTrigger` to detect
`node:property:changed` (mode)
- Deactivation (active → muted/bypassed): remove missing
model/media/node errors for the node
- Activation (muted/bypassed → active): scan the node and add confirmed
errors, show overlay
- Subgraph container deactivation: remove all interior node errors
(execution ID prefix match)
- Subgraph container activation: scan all active interior nodes
recursively
- Subgraph interior mode change: resolve node via
`localGraph.getNodeById()` then compute execution ID from root graph

### 3. Node deletion

- `graph.onNodeRemoved`: remove missing model/media/node errors for the
deleted node
- Handle `node.graph === null` at callback time by using
`String(node.id)` for root-level nodes

### 4. Node paste/duplicate

- `graph.onNodeAdded`: scan via `queueMicrotask` (deferred until after
`node.configure()` restores widget values)
- Guard: skip during `ChangeTracker.isLoadingGraph` (undo/redo/tab
switch handled by pipeline)
- Guard: skip muted/bypassed nodes

### 5. Workflow tab switch optimization

- `skipAssetScans` option in `loadGraphData`: skip full pipeline on tab
switch
- Cache missing model/media/node state per workflow via
`PendingWarnings`
- `beforeLoadNewGraph`: save current store state to outgoing workflow's
`pendingWarnings`
- `showPendingWarnings`: restore cached errors silently (no overlay),
always sync missing nodes store (even when null)
- Preserve UI state (`fileSizes`, `urlInputs`) on tab switch by using
`setMissingModels([])` instead of `clearMissingModels()`
- `MissingModelRow.vue`: fetch file size on mount via
`fetchModelMetadata` memory cache

### 6. Undo/redo overlay suppression

- `silentAssetErrors` option propagated through pipeline →
`surfaceMissingModels`/`surfaceMissingMedia` `{ silent }` option
- `showPendingWarnings` `{ silent }` option for missing nodes overlay
- `changeTracker.ts`: pass `silentAssetErrors: true` on undo/redo

### 7. Error tab node filtering

- Selected node filters missing model/media card contents (not just
group visibility)
- `isAssetErrorInSelection`: resolve execution ID → graph node for
selection matching
- Missing nodes intentionally unfiltered (pack-level scope)
- `hasMissingMediaSelected` added to `RightSidePanel.vue` error tab
visibility
- Download All button: show only when 2+ downloadable models exist

### 8. New store functions

- `missingModelStore`: `addMissingModels`, `removeMissingModelsByNodeId`
- `missingMediaStore`: `addMissingMedia`, `removeMissingMediaByNodeId`
- `missingNodesErrorStore`: `removeMissingNodesByNodeId`
- `missingModelScan`: `scanNodeModelCandidates` (extracted single-node
scan)
- `missingMediaScan`: `scanNodeMediaCandidates` (extracted single-node
scan)

### 9. Test infrastructure improvements

- `data-testid` on `RightSidePanel.vue` tabs (`panel-tab-{value}`)
- Error-related TestIds moved from `dialogs` to `errorsTab` namespace in
`selectors.ts`
- Removed unused `TestIdValue` type
- Extracted `cleanupFakeModel` to shared `ErrorsTabHelper.ts`
- Renamed `openErrorsTabViaSeeErrors` → `loadWorkflowAndOpenErrorsTab`
- Added `aria-label` to pencil edit button and subgraph toggle button

## Test plan

### Unit tests (41 new)

- Store functions: `addMissing*`, `removeMissing*ByNodeId`
- `executionErrorStore`: `surfaceMissing*` silent option
- Scan functions: muted/bypassed filtering, `scanNodeModelCandidates`,
`scanNodeMediaCandidates`
- `workflowService`: `showPendingWarnings` silent, `beforeLoadNewGraph`
caching

### E2E tests (17 new in `errorsTabModeAware.spec.ts`)

**Missing nodes**
- [x] Deleting a missing node removes its error from the errors tab
- [x] Undo after bypass restores error without showing overlay

**Missing models**
- [x] Loading a workflow with all nodes bypassed shows no errors
- [x] Bypassing a node hides its error, un-bypassing restores it
- [x] Deleting a node with missing model removes its error
- [x] Undo after bypass restores error without showing overlay
- [x] Pasting a node with missing model increases referencing node count
- [x] Pasting a bypassed node does not add a new error
- [x] Selecting a node filters errors tab to only that node

**Missing media**
- [x] Loading a workflow with all nodes bypassed shows no errors
- [x] Bypassing a node hides its error, un-bypassing restores it
- [x] Pasting a bypassed node does not add a new error
- [x] Selecting a node filters errors tab to only that node

**Subgraph**
- [x] Bypassing a subgraph hides interior errors, un-bypassing restores
them
- [x] Bypassing a node inside a subgraph hides its error, un-bypassing
restores it

**Workflow switching**
- [x] Does not resurface error overlay when switching back to workflow
with missing nodes
- [x] Restores missing nodes in errors tab when switching back to
workflow

# Screenshots


https://github.com/user-attachments/assets/e0a5bcb8-69ba-4120-ab7f-5c83e4cfc3c5



## Follow-up work

- Extract error-detection computed properties from `RightSidePanel.vue`
into a composable (e.g. `useErrorsTabVisibility`)

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: GitHub Action <action@github.com>
snomiao pushed a commit that referenced this pull request Apr 22, 2026
Follow-up to #10856. Four correctness issues and their regression tests.

## Bugs fixed

### 1. ErrorOverlay model count reflected node selection

`useErrorGroups` exposed `filteredMissingModelGroups` under the public
name `missingModelGroups`. `ErrorOverlay.vue` read that alias to compute
its model count label, so selecting a node shrank the overlay total. The
overlay must always show the whole workflow's errors.

Exposed both shapes explicitly: `missingModelGroups` /
`missingMediaGroups` (unfiltered totals) and
`filteredMissingModelGroups` / `filteredMissingMediaGroups`
(selection-scoped). `TabErrors.vue` destructures the filtered variant
with an alias.


Before 


https://github.com/user-attachments/assets/eb848c5f-d092-4a4f-b86f-d22bb4408003

After 


https://github.com/user-attachments/assets/75e67819-c9f2-45ec-9241-74023eca6120



### 2. Bypass → un-bypass dropped url/hash metadata

Realtime `scanNodeModelCandidates` only reads widget values, so
un-bypass produced a fresh candidate without the url that
`enrichWithEmbeddedMetadata` had previously attached from
`graphData.models`. `MissingModelRow`'s download/copy-url buttons
disappeared after a bypass/un-bypass cycle.

Added `enrichCandidateFromNodeProperties` that copies
`url`/`hash`/`directory` from the node's own `properties.models` — which
persists across mode toggles — into each scanned candidate. Applied to
every call site of the per-node scan. A later fix in the same branch
also enforces directory agreement to prevent a same-name /
different-directory collision from stamping the wrong metadata.

Before 


https://github.com/user-attachments/assets/39039d83-4d55-41a9-9d01-dec40843741b

After 


https://github.com/user-attachments/assets/047a603b-fb52-4320-886d-dfeed457d833



### 3. Initial full scan surfaced interior errors of a muted/bypassed
subgraph container

`scanAllModelCandidates`, `scanAllMediaCandidates`, and the JSON-based
missing-node scan only check each node's own mode. Interior nodes whose
parent container was bypassed passed the filter.

Added `isAncestorPathActive(rootGraph, executionId)` to
`graphTraversalUtil` and post-filter the three pipelines in `app.ts`
after the live rootGraph is configured. The filter uses the execution-ID
path (`"65:63"` → check node 65's mode) so it handles both
live-scan-produced and JSON-enrichment-produced candidates.

Before


https://github.com/user-attachments/assets/3032d46b-81cd-420e-ab8e-f58392267602

After 


https://github.com/user-attachments/assets/02a01931-951d-4a48-986c-06424044fbf8




### 4. Bypassed subgraph entry re-surfaced interior errors

`useGraphNodeManager` replays `graph.onNodeAdded` for each existing
interior node when the Vue node manager initializes on subgraph entry.
That chain reached `scanSingleNodeErrors` via
`installErrorClearingHooks`' `onNodeAdded` override. Each interior
node's own mode was active, so the caller guards passed and the scan
re-introduced the error that the initial pipeline had correctly
suppressed.

Added an ancestor-activity gate at the top of `scanSingleNodeErrors`,
the single entry point shared by paste, un-bypass, subgraph entry, and
subgraph container activation. A later commit also hardens this guard
against detached nodes (null execution ID → skip) and applies the same
ancestor check to `isCandidateStillActive` in the realtime verification
callback.

Before


https://github.com/user-attachments/assets/fe44862d-f1d6-41ed-982d-614a7e83d441

After


https://github.com/user-attachments/assets/497a76ce-3caa-479f-9024-4cd0f7bd20a4



## Tests

- 6 unit tests for `isAncestorPathActive` (root, active,
immediate-bypass, deep-nested mute, unresolvable ancestor, null
rootGraph)
- 4 unit tests for `enrichCandidateFromNodeProperties` (enrichment,
no-overwrite, name mismatch, directory mismatch)
- 1 unit test for `scanSingleNodeErrors` ancestor guard (subgraph entry
replaying onNodeAdded)
- 2 unit tests for `useErrorGroups` dual export + ErrorOverlay contract
- 4 E2E tests:
- ErrorOverlay model count stays constant when a node is selected (new
fixture `missing_models_distinct.json`)
- Bypass/un-bypass cycle preserves Copy URL button (uses
`missing_models_from_node_properties`)
- Loading a workflow with bypassed subgraph suppresses interior missing
model error (new fixture `missing_models_in_bypassed_subgraph.json`)
- Entering a bypassed subgraph does not resurface interior missing model
error (shares the above fixture)

`pnpm typecheck`, `pnpm lint`, 206 related unit tests passing.

## Follow-up

Several items raised by code review are deferred as pre-existing tech
debt or scope-avoided refactors. Tracked via comments on #11215 and
#11216.

---
Follows up on #10856.
snomiao pushed a commit that referenced this pull request Apr 24, 2026
## Summary

Muted and bypassed nodes are excluded from execution but were still
triggering missing model/media/node warnings. This PR makes the error
system mode-aware: muted/bypassed nodes no longer produce missing asset
errors, and all error lifecycle events (mode toggle, deletion, paste,
undo, tab switch) are handled consistently.

- Fixes Comfy-Org/ComfyUI#13256

## Behavioral notes

- **Tab switch overlay suppression (intentional)**: Switching back to a
workflow with missing assets no longer re-shows the error overlay. This
reverses the behavior introduced in #10190. The error state is still
restored silently in the errors tab — users can access it via the
properties panel without being interrupted by the overlay on every tab
switch.

## Changes

### 1. Scan filtering

- `scanAllModelCandidates`, `scanAllMediaCandidates`,
`scanMissingNodes`: skip nodes with `mode === NEVER || BYPASS`
- `collectMissingNodes` (serialized data): skip error reporting for
muted/bypassed nodes while still calling `sanitizeNodeName` for safe
`configure()`
- `collectEmbeddedModelsWithSource`: skip muted/bypassed nodes;
workflow-level `graphData.models` only create candidates when active
nodes exist
- `enrichWithEmbeddedMetadata`: filter unmatched workflow-level models
when all referencing nodes are inactive

### 2. Realtime mode change handling

- `useErrorClearingHooks.ts` chains `graph.onTrigger` to detect
`node:property:changed` (mode)
- Deactivation (active → muted/bypassed): remove missing
model/media/node errors for the node
- Activation (muted/bypassed → active): scan the node and add confirmed
errors, show overlay
- Subgraph container deactivation: remove all interior node errors
(execution ID prefix match)
- Subgraph container activation: scan all active interior nodes
recursively
- Subgraph interior mode change: resolve node via
`localGraph.getNodeById()` then compute execution ID from root graph

### 3. Node deletion

- `graph.onNodeRemoved`: remove missing model/media/node errors for the
deleted node
- Handle `node.graph === null` at callback time by using
`String(node.id)` for root-level nodes

### 4. Node paste/duplicate

- `graph.onNodeAdded`: scan via `queueMicrotask` (deferred until after
`node.configure()` restores widget values)
- Guard: skip during `ChangeTracker.isLoadingGraph` (undo/redo/tab
switch handled by pipeline)
- Guard: skip muted/bypassed nodes

### 5. Workflow tab switch optimization

- `skipAssetScans` option in `loadGraphData`: skip full pipeline on tab
switch
- Cache missing model/media/node state per workflow via
`PendingWarnings`
- `beforeLoadNewGraph`: save current store state to outgoing workflow's
`pendingWarnings`
- `showPendingWarnings`: restore cached errors silently (no overlay),
always sync missing nodes store (even when null)
- Preserve UI state (`fileSizes`, `urlInputs`) on tab switch by using
`setMissingModels([])` instead of `clearMissingModels()`
- `MissingModelRow.vue`: fetch file size on mount via
`fetchModelMetadata` memory cache

### 6. Undo/redo overlay suppression

- `silentAssetErrors` option propagated through pipeline →
`surfaceMissingModels`/`surfaceMissingMedia` `{ silent }` option
- `showPendingWarnings` `{ silent }` option for missing nodes overlay
- `changeTracker.ts`: pass `silentAssetErrors: true` on undo/redo

### 7. Error tab node filtering

- Selected node filters missing model/media card contents (not just
group visibility)
- `isAssetErrorInSelection`: resolve execution ID → graph node for
selection matching
- Missing nodes intentionally unfiltered (pack-level scope)
- `hasMissingMediaSelected` added to `RightSidePanel.vue` error tab
visibility
- Download All button: show only when 2+ downloadable models exist

### 8. New store functions

- `missingModelStore`: `addMissingModels`, `removeMissingModelsByNodeId`
- `missingMediaStore`: `addMissingMedia`, `removeMissingMediaByNodeId`
- `missingNodesErrorStore`: `removeMissingNodesByNodeId`
- `missingModelScan`: `scanNodeModelCandidates` (extracted single-node
scan)
- `missingMediaScan`: `scanNodeMediaCandidates` (extracted single-node
scan)

### 9. Test infrastructure improvements

- `data-testid` on `RightSidePanel.vue` tabs (`panel-tab-{value}`)
- Error-related TestIds moved from `dialogs` to `errorsTab` namespace in
`selectors.ts`
- Removed unused `TestIdValue` type
- Extracted `cleanupFakeModel` to shared `ErrorsTabHelper.ts`
- Renamed `openErrorsTabViaSeeErrors` → `loadWorkflowAndOpenErrorsTab`
- Added `aria-label` to pencil edit button and subgraph toggle button

## Test plan

### Unit tests (41 new)

- Store functions: `addMissing*`, `removeMissing*ByNodeId`
- `executionErrorStore`: `surfaceMissing*` silent option
- Scan functions: muted/bypassed filtering, `scanNodeModelCandidates`,
`scanNodeMediaCandidates`
- `workflowService`: `showPendingWarnings` silent, `beforeLoadNewGraph`
caching

### E2E tests (17 new in `errorsTabModeAware.spec.ts`)

**Missing nodes**
- [x] Deleting a missing node removes its error from the errors tab
- [x] Undo after bypass restores error without showing overlay

**Missing models**
- [x] Loading a workflow with all nodes bypassed shows no errors
- [x] Bypassing a node hides its error, un-bypassing restores it
- [x] Deleting a node with missing model removes its error
- [x] Undo after bypass restores error without showing overlay
- [x] Pasting a node with missing model increases referencing node count
- [x] Pasting a bypassed node does not add a new error
- [x] Selecting a node filters errors tab to only that node

**Missing media**
- [x] Loading a workflow with all nodes bypassed shows no errors
- [x] Bypassing a node hides its error, un-bypassing restores it
- [x] Pasting a bypassed node does not add a new error
- [x] Selecting a node filters errors tab to only that node

**Subgraph**
- [x] Bypassing a subgraph hides interior errors, un-bypassing restores
them
- [x] Bypassing a node inside a subgraph hides its error, un-bypassing
restores it

**Workflow switching**
- [x] Does not resurface error overlay when switching back to workflow
with missing nodes
- [x] Restores missing nodes in errors tab when switching back to
workflow

# Screenshots


https://github.com/user-attachments/assets/e0a5bcb8-69ba-4120-ab7f-5c83e4cfc3c5



## Follow-up work

- Extract error-detection computed properties from `RightSidePanel.vue`
into a composable (e.g. `useErrorsTabVisibility`)

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: GitHub Action <action@github.com>
snomiao pushed a commit that referenced this pull request Apr 24, 2026
Follow-up to #10856. Four correctness issues and their regression tests.

## Bugs fixed

### 1. ErrorOverlay model count reflected node selection

`useErrorGroups` exposed `filteredMissingModelGroups` under the public
name `missingModelGroups`. `ErrorOverlay.vue` read that alias to compute
its model count label, so selecting a node shrank the overlay total. The
overlay must always show the whole workflow's errors.

Exposed both shapes explicitly: `missingModelGroups` /
`missingMediaGroups` (unfiltered totals) and
`filteredMissingModelGroups` / `filteredMissingMediaGroups`
(selection-scoped). `TabErrors.vue` destructures the filtered variant
with an alias.


Before 


https://github.com/user-attachments/assets/eb848c5f-d092-4a4f-b86f-d22bb4408003

After 


https://github.com/user-attachments/assets/75e67819-c9f2-45ec-9241-74023eca6120



### 2. Bypass → un-bypass dropped url/hash metadata

Realtime `scanNodeModelCandidates` only reads widget values, so
un-bypass produced a fresh candidate without the url that
`enrichWithEmbeddedMetadata` had previously attached from
`graphData.models`. `MissingModelRow`'s download/copy-url buttons
disappeared after a bypass/un-bypass cycle.

Added `enrichCandidateFromNodeProperties` that copies
`url`/`hash`/`directory` from the node's own `properties.models` — which
persists across mode toggles — into each scanned candidate. Applied to
every call site of the per-node scan. A later fix in the same branch
also enforces directory agreement to prevent a same-name /
different-directory collision from stamping the wrong metadata.

Before 


https://github.com/user-attachments/assets/39039d83-4d55-41a9-9d01-dec40843741b

After 


https://github.com/user-attachments/assets/047a603b-fb52-4320-886d-dfeed457d833



### 3. Initial full scan surfaced interior errors of a muted/bypassed
subgraph container

`scanAllModelCandidates`, `scanAllMediaCandidates`, and the JSON-based
missing-node scan only check each node's own mode. Interior nodes whose
parent container was bypassed passed the filter.

Added `isAncestorPathActive(rootGraph, executionId)` to
`graphTraversalUtil` and post-filter the three pipelines in `app.ts`
after the live rootGraph is configured. The filter uses the execution-ID
path (`"65:63"` → check node 65's mode) so it handles both
live-scan-produced and JSON-enrichment-produced candidates.

Before


https://github.com/user-attachments/assets/3032d46b-81cd-420e-ab8e-f58392267602

After 


https://github.com/user-attachments/assets/02a01931-951d-4a48-986c-06424044fbf8




### 4. Bypassed subgraph entry re-surfaced interior errors

`useGraphNodeManager` replays `graph.onNodeAdded` for each existing
interior node when the Vue node manager initializes on subgraph entry.
That chain reached `scanSingleNodeErrors` via
`installErrorClearingHooks`' `onNodeAdded` override. Each interior
node's own mode was active, so the caller guards passed and the scan
re-introduced the error that the initial pipeline had correctly
suppressed.

Added an ancestor-activity gate at the top of `scanSingleNodeErrors`,
the single entry point shared by paste, un-bypass, subgraph entry, and
subgraph container activation. A later commit also hardens this guard
against detached nodes (null execution ID → skip) and applies the same
ancestor check to `isCandidateStillActive` in the realtime verification
callback.

Before


https://github.com/user-attachments/assets/fe44862d-f1d6-41ed-982d-614a7e83d441

After


https://github.com/user-attachments/assets/497a76ce-3caa-479f-9024-4cd0f7bd20a4



## Tests

- 6 unit tests for `isAncestorPathActive` (root, active,
immediate-bypass, deep-nested mute, unresolvable ancestor, null
rootGraph)
- 4 unit tests for `enrichCandidateFromNodeProperties` (enrichment,
no-overwrite, name mismatch, directory mismatch)
- 1 unit test for `scanSingleNodeErrors` ancestor guard (subgraph entry
replaying onNodeAdded)
- 2 unit tests for `useErrorGroups` dual export + ErrorOverlay contract
- 4 E2E tests:
- ErrorOverlay model count stays constant when a node is selected (new
fixture `missing_models_distinct.json`)
- Bypass/un-bypass cycle preserves Copy URL button (uses
`missing_models_from_node_properties`)
- Loading a workflow with bypassed subgraph suppresses interior missing
model error (new fixture `missing_models_in_bypassed_subgraph.json`)
- Entering a bypassed subgraph does not resurface interior missing model
error (shares the above fixture)

`pnpm typecheck`, `pnpm lint`, 206 related unit tests passing.

## Follow-up

Several items raised by code review are deferred as pre-existing tech
debt or scope-avoided refactors. Tracked via comments on #11215 and
#11216.

---
Follows up on #10856.
@comfy-pr-bot comfy-pr-bot added the released:cloud PR has been released to cloud label May 6, 2026
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

⚠️ Backport to core/1.43 failed

Reason: Merge conflicts detected during cherry-pick of 521019d

📄 Conflicting files
browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts
browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png
browser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png
src/components/rightSidePanel/errors/TabErrors.vue
src/components/rightSidePanel/errors/useErrorGroups.ts
src/composables/graph/useErrorClearingHooks.test.ts
src/composables/graph/useErrorClearingHooks.ts
src/platform/missingMedia/missingMediaScan.test.ts
src/platform/missingMedia/missingMediaScan.ts
src/platform/missingModel/missingModelScan.test.ts
src/platform/missingModel/missingModelScan.ts
src/platform/workflow/core/services/workflowService.ts
src/scripts/app.ts
src/utils/graphTraversalUtil.test.ts
src/utils/graphTraversalUtil.ts
🤖 Prompt for AI Agents
Backport PR #10856 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/10856) to core/1.43.
Cherry-pick merge commit 521019d173907536ae8032f110473ae7d0f15930 onto new branch
backport-10856-to-core-1.43 from origin/core/1.43.
Resolve conflicts in: browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png browser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png src/components/rightSidePanel/errors/TabErrors.vue src/components/rightSidePanel/errors/useErrorGroups.ts src/composables/graph/useErrorClearingHooks.test.ts src/composables/graph/useErrorClearingHooks.ts src/platform/missingMedia/missingMediaScan.test.ts src/platform/missingMedia/missingMediaScan.ts src/platform/missingModel/missingModelScan.test.ts src/platform/missingModel/missingModelScan.ts src/platform/workflow/core/services/workflowService.ts src/scripts/app.ts src/utils/graphTraversalUtil.test.ts src/utils/graphTraversalUtil.ts .
For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport core/1.43] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @jaeone94

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

⚠️ Backport to cloud/1.43 failed

Reason: Merge conflicts detected during cherry-pick of 521019d

📄 Conflicting files
browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts
browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png
browser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png
src/components/rightSidePanel/RightSidePanel.vue
src/components/rightSidePanel/errors/TabErrors.vue
src/components/rightSidePanel/errors/useErrorGroups.ts
src/composables/graph/useErrorClearingHooks.test.ts
src/composables/graph/useErrorClearingHooks.ts
src/platform/missingMedia/missingMediaScan.test.ts
src/platform/missingMedia/missingMediaScan.ts
src/platform/missingModel/missingModelScan.test.ts
src/platform/missingModel/missingModelScan.ts
src/platform/workflow/core/services/workflowService.ts
src/scripts/app.ts
src/utils/graphTraversalUtil.test.ts
src/utils/graphTraversalUtil.ts
🤖 Prompt for AI Agents
Backport PR #10856 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/10856) to cloud/1.43.
Cherry-pick merge commit 521019d173907536ae8032f110473ae7d0f15930 onto new branch
backport-10856-to-cloud-1.43 from origin/cloud/1.43.
Resolve conflicts in: browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png browser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png src/components/rightSidePanel/RightSidePanel.vue src/components/rightSidePanel/errors/TabErrors.vue src/components/rightSidePanel/errors/useErrorGroups.ts src/composables/graph/useErrorClearingHooks.test.ts src/composables/graph/useErrorClearingHooks.ts src/platform/missingMedia/missingMediaScan.test.ts src/platform/missingMedia/missingMediaScan.ts src/platform/missingModel/missingModelScan.test.ts src/platform/missingModel/missingModelScan.ts src/platform/workflow/core/services/workflowService.ts src/scripts/app.ts src/utils/graphTraversalUtil.test.ts src/utils/graphTraversalUtil.ts .
For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport cloud/1.43] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @jaeone94

@comfy-pr-bot comfy-pr-bot added the released:core PR has been released to core label May 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Backport to core/1.43 failed

Reason: Merge conflicts detected during cherry-pick of 521019d

📄 Conflicting files
browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts
browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png
browser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png
src/components/rightSidePanel/errors/TabErrors.vue
src/components/rightSidePanel/errors/useErrorGroups.ts
src/composables/graph/useErrorClearingHooks.test.ts
src/composables/graph/useErrorClearingHooks.ts
src/platform/missingMedia/missingMediaScan.test.ts
src/platform/missingMedia/missingMediaScan.ts
src/platform/missingModel/missingModelScan.test.ts
src/platform/missingModel/missingModelScan.ts
src/platform/workflow/core/services/workflowService.ts
src/scripts/app.ts
src/utils/graphTraversalUtil.test.ts
src/utils/graphTraversalUtil.ts
🤖 Prompt for AI Agents
Backport PR #10856 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/10856) to core/1.43.
Cherry-pick merge commit 521019d173907536ae8032f110473ae7d0f15930 onto new branch
backport-10856-to-core-1.43 from origin/core/1.43.
Resolve conflicts in: browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png browser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png src/components/rightSidePanel/errors/TabErrors.vue src/components/rightSidePanel/errors/useErrorGroups.ts src/composables/graph/useErrorClearingHooks.test.ts src/composables/graph/useErrorClearingHooks.ts src/platform/missingMedia/missingMediaScan.test.ts src/platform/missingMedia/missingMediaScan.ts src/platform/missingModel/missingModelScan.test.ts src/platform/missingModel/missingModelScan.ts src/platform/workflow/core/services/workflowService.ts src/scripts/app.ts src/utils/graphTraversalUtil.test.ts src/utils/graphTraversalUtil.ts .
For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport core/1.43] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @jaeone94

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Backport to cloud/1.43 failed

Reason: Merge conflicts detected during cherry-pick of 521019d

📄 Conflicting files
browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts
browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png
browser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png
src/components/rightSidePanel/RightSidePanel.vue
src/components/rightSidePanel/errors/TabErrors.vue
src/components/rightSidePanel/errors/useErrorGroups.ts
src/composables/graph/useErrorClearingHooks.test.ts
src/composables/graph/useErrorClearingHooks.ts
src/platform/missingMedia/missingMediaScan.test.ts
src/platform/missingMedia/missingMediaScan.ts
src/platform/missingModel/missingModelScan.test.ts
src/platform/missingModel/missingModelScan.ts
src/platform/workflow/core/services/workflowService.ts
src/scripts/app.ts
src/utils/graphTraversalUtil.test.ts
src/utils/graphTraversalUtil.ts
🤖 Prompt for AI Agents
Backport PR #10856 (https://github.com/Comfy-Org/ComfyUI_frontend/pull/10856) to cloud/1.43.
Cherry-pick merge commit 521019d173907536ae8032f110473ae7d0f15930 onto new branch
backport-10856-to-cloud-1.43 from origin/cloud/1.43.
Resolve conflicts in: browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts browser_tests/tests/vueNodes/nodeStates/bypass.spec.ts-snapshots/vue-node-bypassed-state-chromium-linux.png browser_tests/tests/vueNodes/nodeStates/mute.spec.ts-snapshots/vue-node-muted-state-chromium-linux.png src/components/rightSidePanel/RightSidePanel.vue src/components/rightSidePanel/errors/TabErrors.vue src/components/rightSidePanel/errors/useErrorGroups.ts src/composables/graph/useErrorClearingHooks.test.ts src/composables/graph/useErrorClearingHooks.ts src/platform/missingMedia/missingMediaScan.test.ts src/platform/missingMedia/missingMediaScan.ts src/platform/missingModel/missingModelScan.test.ts src/platform/missingModel/missingModelScan.ts src/platform/workflow/core/services/workflowService.ts src/scripts/app.ts src/utils/graphTraversalUtil.test.ts src/utils/graphTraversalUtil.ts .
For test snapshots (browser_tests/**/*-snapshots/), accept PR version if
changed in original PR, else keep target. For package.json versions, keep
target branch. For pnpm-lock.yaml, regenerate with pnpm install.
Ask user for non-obvious conflicts.
Create PR titled "[backport cloud/1.43] <original title>" with label "backport".
See .github/workflows/pr-backport.yaml for workflow details.

cc @jaeone94

dante01yoon pushed a commit that referenced this pull request Jul 27, 2026
## Summary

Muted and bypassed nodes are excluded from execution but were still
triggering missing model/media/node warnings. This PR makes the error
system mode-aware: muted/bypassed nodes no longer produce missing asset
errors, and all error lifecycle events (mode toggle, deletion, paste,
undo, tab switch) are handled consistently.

- Fixes Comfy-Org/ComfyUI#13256

## Behavioral notes

- **Tab switch overlay suppression (intentional)**: Switching back to a
workflow with missing assets no longer re-shows the error overlay. This
reverses the behavior introduced in #10190. The error state is still
restored silently in the errors tab — users can access it via the
properties panel without being interrupted by the overlay on every tab
switch.

## Changes

### 1. Scan filtering

- `scanAllModelCandidates`, `scanAllMediaCandidates`,
`scanMissingNodes`: skip nodes with `mode === NEVER || BYPASS`
- `collectMissingNodes` (serialized data): skip error reporting for
muted/bypassed nodes while still calling `sanitizeNodeName` for safe
`configure()`
- `collectEmbeddedModelsWithSource`: skip muted/bypassed nodes;
workflow-level `graphData.models` only create candidates when active
nodes exist
- `enrichWithEmbeddedMetadata`: filter unmatched workflow-level models
when all referencing nodes are inactive

### 2. Realtime mode change handling

- `useErrorClearingHooks.ts` chains `graph.onTrigger` to detect
`node:property:changed` (mode)
- Deactivation (active → muted/bypassed): remove missing
model/media/node errors for the node
- Activation (muted/bypassed → active): scan the node and add confirmed
errors, show overlay
- Subgraph container deactivation: remove all interior node errors
(execution ID prefix match)
- Subgraph container activation: scan all active interior nodes
recursively
- Subgraph interior mode change: resolve node via
`localGraph.getNodeById()` then compute execution ID from root graph

### 3. Node deletion

- `graph.onNodeRemoved`: remove missing model/media/node errors for the
deleted node
- Handle `node.graph === null` at callback time by using
`String(node.id)` for root-level nodes

### 4. Node paste/duplicate

- `graph.onNodeAdded`: scan via `queueMicrotask` (deferred until after
`node.configure()` restores widget values)
- Guard: skip during `ChangeTracker.isLoadingGraph` (undo/redo/tab
switch handled by pipeline)
- Guard: skip muted/bypassed nodes

### 5. Workflow tab switch optimization

- `skipAssetScans` option in `loadGraphData`: skip full pipeline on tab
switch
- Cache missing model/media/node state per workflow via
`PendingWarnings`
- `beforeLoadNewGraph`: save current store state to outgoing workflow's
`pendingWarnings`
- `showPendingWarnings`: restore cached errors silently (no overlay),
always sync missing nodes store (even when null)
- Preserve UI state (`fileSizes`, `urlInputs`) on tab switch by using
`setMissingModels([])` instead of `clearMissingModels()`
- `MissingModelRow.vue`: fetch file size on mount via
`fetchModelMetadata` memory cache

### 6. Undo/redo overlay suppression

- `silentAssetErrors` option propagated through pipeline →
`surfaceMissingModels`/`surfaceMissingMedia` `{ silent }` option
- `showPendingWarnings` `{ silent }` option for missing nodes overlay
- `changeTracker.ts`: pass `silentAssetErrors: true` on undo/redo

### 7. Error tab node filtering

- Selected node filters missing model/media card contents (not just
group visibility)
- `isAssetErrorInSelection`: resolve execution ID → graph node for
selection matching
- Missing nodes intentionally unfiltered (pack-level scope)
- `hasMissingMediaSelected` added to `RightSidePanel.vue` error tab
visibility
- Download All button: show only when 2+ downloadable models exist

### 8. New store functions

- `missingModelStore`: `addMissingModels`, `removeMissingModelsByNodeId`
- `missingMediaStore`: `addMissingMedia`, `removeMissingMediaByNodeId`
- `missingNodesErrorStore`: `removeMissingNodesByNodeId`
- `missingModelScan`: `scanNodeModelCandidates` (extracted single-node
scan)
- `missingMediaScan`: `scanNodeMediaCandidates` (extracted single-node
scan)

### 9. Test infrastructure improvements

- `data-testid` on `RightSidePanel.vue` tabs (`panel-tab-{value}`)
- Error-related TestIds moved from `dialogs` to `errorsTab` namespace in
`selectors.ts`
- Removed unused `TestIdValue` type
- Extracted `cleanupFakeModel` to shared `ErrorsTabHelper.ts`
- Renamed `openErrorsTabViaSeeErrors` → `loadWorkflowAndOpenErrorsTab`
- Added `aria-label` to pencil edit button and subgraph toggle button

## Test plan

### Unit tests (41 new)

- Store functions: `addMissing*`, `removeMissing*ByNodeId`
- `executionErrorStore`: `surfaceMissing*` silent option
- Scan functions: muted/bypassed filtering, `scanNodeModelCandidates`,
`scanNodeMediaCandidates`
- `workflowService`: `showPendingWarnings` silent, `beforeLoadNewGraph`
caching

### E2E tests (17 new in `errorsTabModeAware.spec.ts`)

**Missing nodes**
- [x] Deleting a missing node removes its error from the errors tab
- [x] Undo after bypass restores error without showing overlay

**Missing models**
- [x] Loading a workflow with all nodes bypassed shows no errors
- [x] Bypassing a node hides its error, un-bypassing restores it
- [x] Deleting a node with missing model removes its error
- [x] Undo after bypass restores error without showing overlay
- [x] Pasting a node with missing model increases referencing node count
- [x] Pasting a bypassed node does not add a new error
- [x] Selecting a node filters errors tab to only that node

**Missing media**
- [x] Loading a workflow with all nodes bypassed shows no errors
- [x] Bypassing a node hides its error, un-bypassing restores it
- [x] Pasting a bypassed node does not add a new error
- [x] Selecting a node filters errors tab to only that node

**Subgraph**
- [x] Bypassing a subgraph hides interior errors, un-bypassing restores
them
- [x] Bypassing a node inside a subgraph hides its error, un-bypassing
restores it

**Workflow switching**
- [x] Does not resurface error overlay when switching back to workflow
with missing nodes
- [x] Restores missing nodes in errors tab when switching back to
workflow

# Screenshots


https://github.com/user-attachments/assets/e0a5bcb8-69ba-4120-ab7f-5c83e4cfc3c5



## Follow-up work

- Extract error-detection computed properties from `RightSidePanel.vue`
into a composable (e.g. `useErrorsTabVisibility`)

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: GitHub Action <action@github.com>
dante01yoon pushed a commit that referenced this pull request Jul 27, 2026
Follow-up to #10856. Four correctness issues and their regression tests.

## Bugs fixed

### 1. ErrorOverlay model count reflected node selection

`useErrorGroups` exposed `filteredMissingModelGroups` under the public
name `missingModelGroups`. `ErrorOverlay.vue` read that alias to compute
its model count label, so selecting a node shrank the overlay total. The
overlay must always show the whole workflow's errors.

Exposed both shapes explicitly: `missingModelGroups` /
`missingMediaGroups` (unfiltered totals) and
`filteredMissingModelGroups` / `filteredMissingMediaGroups`
(selection-scoped). `TabErrors.vue` destructures the filtered variant
with an alias.


Before 


https://github.com/user-attachments/assets/eb848c5f-d092-4a4f-b86f-d22bb4408003

After 


https://github.com/user-attachments/assets/75e67819-c9f2-45ec-9241-74023eca6120



### 2. Bypass → un-bypass dropped url/hash metadata

Realtime `scanNodeModelCandidates` only reads widget values, so
un-bypass produced a fresh candidate without the url that
`enrichWithEmbeddedMetadata` had previously attached from
`graphData.models`. `MissingModelRow`'s download/copy-url buttons
disappeared after a bypass/un-bypass cycle.

Added `enrichCandidateFromNodeProperties` that copies
`url`/`hash`/`directory` from the node's own `properties.models` — which
persists across mode toggles — into each scanned candidate. Applied to
every call site of the per-node scan. A later fix in the same branch
also enforces directory agreement to prevent a same-name /
different-directory collision from stamping the wrong metadata.

Before 


https://github.com/user-attachments/assets/39039d83-4d55-41a9-9d01-dec40843741b

After 


https://github.com/user-attachments/assets/047a603b-fb52-4320-886d-dfeed457d833



### 3. Initial full scan surfaced interior errors of a muted/bypassed
subgraph container

`scanAllModelCandidates`, `scanAllMediaCandidates`, and the JSON-based
missing-node scan only check each node's own mode. Interior nodes whose
parent container was bypassed passed the filter.

Added `isAncestorPathActive(rootGraph, executionId)` to
`graphTraversalUtil` and post-filter the three pipelines in `app.ts`
after the live rootGraph is configured. The filter uses the execution-ID
path (`"65:63"` → check node 65's mode) so it handles both
live-scan-produced and JSON-enrichment-produced candidates.

Before


https://github.com/user-attachments/assets/3032d46b-81cd-420e-ab8e-f58392267602

After 


https://github.com/user-attachments/assets/02a01931-951d-4a48-986c-06424044fbf8




### 4. Bypassed subgraph entry re-surfaced interior errors

`useGraphNodeManager` replays `graph.onNodeAdded` for each existing
interior node when the Vue node manager initializes on subgraph entry.
That chain reached `scanSingleNodeErrors` via
`installErrorClearingHooks`' `onNodeAdded` override. Each interior
node's own mode was active, so the caller guards passed and the scan
re-introduced the error that the initial pipeline had correctly
suppressed.

Added an ancestor-activity gate at the top of `scanSingleNodeErrors`,
the single entry point shared by paste, un-bypass, subgraph entry, and
subgraph container activation. A later commit also hardens this guard
against detached nodes (null execution ID → skip) and applies the same
ancestor check to `isCandidateStillActive` in the realtime verification
callback.

Before


https://github.com/user-attachments/assets/fe44862d-f1d6-41ed-982d-614a7e83d441

After


https://github.com/user-attachments/assets/497a76ce-3caa-479f-9024-4cd0f7bd20a4



## Tests

- 6 unit tests for `isAncestorPathActive` (root, active,
immediate-bypass, deep-nested mute, unresolvable ancestor, null
rootGraph)
- 4 unit tests for `enrichCandidateFromNodeProperties` (enrichment,
no-overwrite, name mismatch, directory mismatch)
- 1 unit test for `scanSingleNodeErrors` ancestor guard (subgraph entry
replaying onNodeAdded)
- 2 unit tests for `useErrorGroups` dual export + ErrorOverlay contract
- 4 E2E tests:
- ErrorOverlay model count stays constant when a node is selected (new
fixture `missing_models_distinct.json`)
- Bypass/un-bypass cycle preserves Copy URL button (uses
`missing_models_from_node_properties`)
- Loading a workflow with bypassed subgraph suppresses interior missing
model error (new fixture `missing_models_in_bypassed_subgraph.json`)
- Entering a bypassed subgraph does not resurface interior missing model
error (shares the above fixture)

`pnpm typecheck`, `pnpm lint`, 206 related unit tests passing.

## Follow-up

Several items raised by code review are deferred as pre-existing tech
debt or scope-avoided refactors. Tracked via comments on #11215 and
#11216.

---
Follows up on #10856.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch released:cloud PR has been released to cloud released:core PR has been released to core size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing model error for disconnected and bypassed loader nodes

4 participants