Repository navigation
fix: exclude muted/bypassed nodes from missing asset detection - #10856
Conversation
- Skip muted (NEVER) and bypassed (BYPASS) nodes in missing model, media, and node scans across all code paths (live graph, embedded metadata enrichment, serialized graph collection) - React to node mode changes: remove errors when deactivated, rescan when activated - Remove missing asset errors on node deletion - Scan pasted/duplicated nodes for missing assets (deferred to microtask so widget values are configured) - Cache missing model/media/node state per workflow via PendingWarnings for tab-switch restore without rescanning - Skip full scan pipeline on workflow tab switch (skipAssetScans); restore cached results silently (no error overlay) - Suppress error overlay on undo/redo (silentAssetErrors) while still updating error state - Filter error tab groups by selected node so only relevant missing asset cards are shown - Add hasMissingMediaSelected check to RightSidePanel error tab visibility Fixes Comfy-Org/ComfyUI#13256
When a node is selected, missing node/model/media error cards now show only the entries relevant to that node instead of all entries. Filtered computed properties regroup candidates per selection.
- Filter missing model/media card contents by selected node; missing nodes are intentionally unfiltered (pack-level scope) - Show Download All button only when 2+ downloadable models exist - Fetch file sizes on MissingModelRow mount so tab-switch cache restores display sizes via fetchModelMetadata memory cache - Preserve UI state (fileSizes, urlInputs) on tab switch by using setMissingModels([]) instead of clearMissingModels()
- Always sanitize unregistered node types before configure, even for bypassed nodes, to prevent placeholder errors on subgraph entry - Skip scanning bypassed nodes in onNodeAdded (triggered by useGraphNodeManager init on subgraph entry) - Resolve mode change events using the local graph that fired the event, not the root graph, so subgraph interior nodes are found - Remove interior node errors when a subgraph container is bypassed (prefix match on execution ID) - Scan all active interior nodes when a subgraph container is activated
showPendingWarnings early-returned when pendingWarnings was null, skipping the surfaceMissingNodes([]) call needed to clear stale missing node entries from the store after undo.
- missingModelStore: addMissingModels, removeMissingModelsByNodeId - missingMediaStore: addMissingMedia, removeMissingMediaByNodeId - missingNodesErrorStore: removeMissingNodesByNodeId - executionErrorStore: surfaceMissingModels/Media silent option - missingNodeScan: muted/bypassed node filtering - missingModelScan: scanNodeModelCandidates direct tests - missingMediaScan: scanNodeMediaCandidates direct tests - workflowService: showPendingWarnings silent, beforeLoadNewGraph cache
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds node-mode–aware scanning and per-node scanner helpers, selection-aware filtering for missing models/media, store actions to add/remove candidates by node ID, hooks to rescan/clear on node changes, pipeline/UI changes to cache/surface pending warnings with a silent option, and updated tests and fixtures. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Graph as LiteGraph
participant Hooks as ErrorClearingHooks
participant Scanner as MissingAssetScanner
participant Store as MissingAssetStore
participant UI as RightSidePanel
User->>Graph: add/modify node (add or mode change)
Graph->>Hooks: emit node add / onTrigger / remove
Hooks->>Scanner: scanNode*Candidates(root, node, ...)
alt node became inactive (NEVER/BYPASS)
Hooks->>Store: removeMissing*ByNodeId(nodeId)
Store-->>Hooks: confirm removal
else node added or active
Scanner-->>Hooks: return missing candidates
Hooks->>Store: addMissing*(candidates)
Store-->>Hooks: updated state
end
Store->>UI: state updated (missingModel/media)
UI->>UI: apply selection-aware filtering
UI-->>User: update Errors tab visibility and buttons
sequenceDiagram
participant Workflow
participant App as ComfyApp
participant Graph as LiteGraph
participant Scanner as MissingAssetScanner
participant Store as MissingAssetStore
participant Errors as ExecutionErrorStore
Workflow->>App: loadGraphData(skipAssetScans?, silentAssetErrors?)
App->>Graph: load graph
alt skipAssetScans = false
Graph->>Scanner: scanAll*Candidates (skips NEVER/BYPASS)
Scanner-->>Store: setMissing*(candidates)
Store-->>Workflow: cache in pendingWarnings
Workflow->>Errors: surfaceMissing*(candidates, { silent: silentAssetErrors })
else skipAssetScans = true
App->>Store: setMissing*([]) or reset state
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1101 passed, 0 failed · 1 flaky📊 Browser Reports
|
📦 Bundle: 5.15 MB gzip 🔴 +3.94 kBDetailsSummary
Category Glance App Entry Points — 22.3 kB (baseline 22.3 kB) • 🔴 +1 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.22 MB (baseline 1.21 MB) • 🔴 +9.89 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 482 kB (baseline 482 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 109 kB (baseline 109 kB) • 🔴 +2 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 60.3 kB (baseline 60.3 kB) • 🔴 +1 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 3 MB (baseline 2.98 MB) • 🔴 +10.5 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 344 kB (baseline 344 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 11 unchanged Vendor & Third-Party — 9.86 MB (baseline 9.86 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.56 MB (baseline 8.56 MB) • 🔴 +65 BBundles that do not match a named category
Status: 61 added / 61 removed / 74 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-04-13T08:58:25.214Z",
"gitSha": "3f029548c9511a20208b5bd25173e98db9a9a59e",
"branch": "feat/muted-bypass-missing-asset-filter",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.6800000000032,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.629999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.323,
"heapDeltaBytes": -4618448,
"heapUsedBytes": 44464104,
"domNodes": 20,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 25.257999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2004.8440000000483,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.376000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.31,
"heapDeltaBytes": 20705948,
"heapUsedBytes": 65181980,
"domNodes": 20,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 16.745000000000005,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2005.4810000000316,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.847999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.784,
"heapDeltaBytes": -4610076,
"heapUsedBytes": 44427760,
"domNodes": 22,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 23.858000000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2034.5439999999826,
"styleRecalcs": 85,
"styleRecalcDurationMs": 43.296,
"layouts": 12,
"layoutDurationMs": 3.0360000000000005,
"taskDurationMs": 968.0179999999999,
"heapDeltaBytes": 16359204,
"heapUsedBytes": 59013692,
"domNodes": 67,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 122.44199999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1899.3560000000116,
"styleRecalcs": 80,
"styleRecalcDurationMs": 45.445,
"layouts": 12,
"layoutDurationMs": 4.152,
"taskDurationMs": 772.485,
"heapDeltaBytes": 16336376,
"heapUsedBytes": 60202768,
"domNodes": 65,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 123.34800000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1843.0399999999736,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.994,
"layouts": 12,
"layoutDurationMs": 3.8520000000000003,
"taskDurationMs": 754.0440000000001,
"heapDeltaBytes": 16683508,
"heapUsedBytes": 60518584,
"domNodes": 61,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 122.92800000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.6529999999989,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.374,
"layouts": 6,
"layoutDurationMs": 0.5839999999999999,
"taskDurationMs": 298.824,
"heapDeltaBytes": 24662060,
"heapUsedBytes": 68774796,
"domNodes": 79,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 23.687999999999995,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1732.073000000014,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.519,
"layouts": 6,
"layoutDurationMs": 0.6640000000000001,
"taskDurationMs": 339.515,
"heapDeltaBytes": 15759316,
"heapUsedBytes": 66867336,
"domNodes": 78,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 25.238000000000003,
"eventListeners": 23,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.4169999999885,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.008999999999997,
"layouts": 6,
"layoutDurationMs": 0.7770000000000001,
"taskDurationMs": 302.767,
"heapDeltaBytes": 24711016,
"heapUsedBytes": 67301328,
"domNodes": 81,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 28.552,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 628.6660000000097,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.337000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.08200000000005,
"heapDeltaBytes": 7352564,
"heapUsedBytes": 52167212,
"domNodes": 20,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 68.31700000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 556.8850000000225,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.375,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 342.28999999999996,
"heapDeltaBytes": 6532988,
"heapUsedBytes": 49549492,
"domNodes": 20,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 63.32,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 527.7439999999842,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.857000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.63800000000003,
"heapDeltaBytes": 6191944,
"heapUsedBytes": 49404316,
"domNodes": 20,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 53.501,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2039.024000000012,
"styleRecalcs": 11,
"styleRecalcDurationMs": 15.151,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.371,
"heapDeltaBytes": 3907620,
"heapUsedBytes": 54689200,
"domNodes": -256,
"jsHeapTotalBytes": 16023552,
"scriptDurationMs": 91.30099999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2051.9590000000107,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.823,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.0050000000001,
"heapDeltaBytes": -19898868,
"heapUsedBytes": 50352604,
"domNodes": -253,
"jsHeapTotalBytes": 17784832,
"scriptDurationMs": 111.829,
"eventListeners": -121,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2021.50400000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.582999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.153,
"heapDeltaBytes": 4506324,
"heapUsedBytes": 65129716,
"domNodes": -256,
"jsHeapTotalBytes": 16818176,
"scriptDurationMs": 90.342,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2147.975000000002,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.880999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1051.983,
"heapDeltaBytes": 16740360,
"heapUsedBytes": 68837456,
"domNodes": -260,
"jsHeapTotalBytes": 17694720,
"scriptDurationMs": 368.91999999999996,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2128.031999999962,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.882,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1106.8020000000001,
"heapDeltaBytes": -6706164,
"heapUsedBytes": 47938312,
"domNodes": -259,
"jsHeapTotalBytes": 21741568,
"scriptDurationMs": 397.909,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2122.2950000000083,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.483,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1073.7669999999998,
"heapDeltaBytes": 16402528,
"heapUsedBytes": 70569108,
"domNodes": -260,
"jsHeapTotalBytes": 18481152,
"scriptDurationMs": 369.08599999999996,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3147.350999999986,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.23,
"layouts": 60,
"layoutDurationMs": 8.103,
"taskDurationMs": 1289.16,
"heapDeltaBytes": 1569864,
"heapUsedBytes": 59163220,
"domNodes": -261,
"jsHeapTotalBytes": 16678912,
"scriptDurationMs": 446.12,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3131.885000000011,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.465,
"layouts": 60,
"layoutDurationMs": 7.670999999999999,
"taskDurationMs": 1288.309,
"heapDeltaBytes": 7971848,
"heapUsedBytes": 64163956,
"domNodes": -263,
"jsHeapTotalBytes": 17022976,
"scriptDurationMs": 459.751,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3164.5950000000767,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.054,
"layouts": 60,
"layoutDurationMs": 7.507999999999999,
"taskDurationMs": 1280.583,
"heapDeltaBytes": 7414216,
"heapUsedBytes": 62150516,
"domNodes": -261,
"jsHeapTotalBytes": 17489920,
"scriptDurationMs": 450.154,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.0569999999611,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.541000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.9130000000001,
"heapDeltaBytes": 3177152,
"heapUsedBytes": 57481608,
"domNodes": -260,
"jsHeapTotalBytes": 15654912,
"scriptDurationMs": 80.99999999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2007.7440000000024,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.049000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.8009999999999,
"heapDeltaBytes": 4039132,
"heapUsedBytes": 56371372,
"domNodes": -256,
"jsHeapTotalBytes": 16703488,
"scriptDurationMs": 92.25,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.965000000071,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.243,
"heapDeltaBytes": 4367816,
"heapUsedBytes": 57846352,
"domNodes": -259,
"jsHeapTotalBytes": 15163392,
"scriptDurationMs": 92.74499999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.7119999999775,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.530999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.43799999999993,
"heapDeltaBytes": 6532600,
"heapUsedBytes": 49769736,
"domNodes": 21,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 122.69499999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 537.7300000000105,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.392999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.56699999999995,
"heapDeltaBytes": -2070696,
"heapUsedBytes": 49380708,
"domNodes": 20,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 117.133,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 539.2839999999524,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.212,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.81300000000005,
"heapDeltaBytes": 6503524,
"heapUsedBytes": 49694296,
"domNodes": 23,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 114.25799999999998,
"eventListeners": 12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1997.8010000000097,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.232999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.89599999999996,
"heapDeltaBytes": 20171136,
"heapUsedBytes": 64986896,
"domNodes": 20,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 17.211,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1996.4299999999753,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.296000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.494,
"heapDeltaBytes": 20316092,
"heapUsedBytes": 63414456,
"domNodes": 22,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 20.532,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1998.4460000000581,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.854,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.584,
"heapDeltaBytes": 20638456,
"heapUsedBytes": 63394556,
"domNodes": 25,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 19.660999999999998,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.4099999999958,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.333999999999996,
"layouts": 16,
"layoutDurationMs": 4.589,
"taskDurationMs": 637.005,
"heapDeltaBytes": 11856464,
"heapUsedBytes": 55162500,
"domNodes": 64,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 87.404,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1962.3880000000327,
"styleRecalcs": 83,
"styleRecalcDurationMs": 43.03,
"layouts": 16,
"layoutDurationMs": 4.8549999999999995,
"taskDurationMs": 905.9359999999999,
"heapDeltaBytes": 11912104,
"heapUsedBytes": 55037260,
"domNodes": 71,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 92.626,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1963.1059999999252,
"styleRecalcs": 83,
"styleRecalcDurationMs": 47.885,
"layouts": 16,
"layoutDurationMs": 4.381,
"taskDurationMs": 901.659,
"heapDeltaBytes": 11823472,
"heapUsedBytes": 55078796,
"domNodes": 72,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 90.488,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8167.25199999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 46.001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3657.4370000000004,
"heapDeltaBytes": 25495120,
"heapUsedBytes": 75820044,
"domNodes": -253,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 1188.3329999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8209.116000000051,
"styleRecalcs": 253,
"styleRecalcDurationMs": 46.288000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3626.786,
"heapDeltaBytes": 9109596,
"heapUsedBytes": 80857324,
"domNodes": -249,
"jsHeapTotalBytes": 22589440,
"scriptDurationMs": 1188.196,
"eventListeners": -103,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8137.0059999999285,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.581,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3606.8830000000003,
"heapDeltaBytes": 18849068,
"heapUsedBytes": 69595472,
"domNodes": -257,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 1176.013,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12168.503999999984,
"styleRecalcs": 3,
"styleRecalcDurationMs": 41.09299999999999,
"layouts": 2,
"layoutDurationMs": 8.436,
"taskDurationMs": 12147.103,
"heapDeltaBytes": 4906788,
"heapUsedBytes": 168727108,
"domNodes": -4992,
"jsHeapTotalBytes": 66412544,
"scriptDurationMs": 561.0930000000001,
"eventListeners": 5292,
"totalBlockingTimeMs": 1030,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10842.26000000001,
"styleRecalcs": 1,
"styleRecalcDurationMs": 17.32700000000001,
"layouts": 1,
"layoutDurationMs": 4.392000000000007,
"taskDurationMs": 10822.373000000001,
"heapDeltaBytes": -24905560,
"heapUsedBytes": 168210300,
"domNodes": -8330,
"jsHeapTotalBytes": 37576704,
"scriptDurationMs": 563.046,
"eventListeners": -14702,
"totalBlockingTimeMs": 1030,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10891.910000000053,
"styleRecalcs": 1,
"styleRecalcDurationMs": 14.984999999999998,
"layouts": 1,
"layoutDurationMs": 4.0950000000000015,
"taskDurationMs": 10872.89,
"heapDeltaBytes": -26289064,
"heapUsedBytes": 168841968,
"domNodes": -8329,
"jsHeapTotalBytes": 37576704,
"scriptDurationMs": 534.729,
"eventListeners": -14702,
"totalBlockingTimeMs": 1049,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 12601,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.000999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12579.845,
"heapDeltaBytes": -68833452,
"heapUsedBytes": 150710136,
"domNodes": -9848,
"jsHeapTotalBytes": -13279232,
"scriptDurationMs": 831.469,
"eventListeners": -23985,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 12254.917999999976,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.862000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12235.080000000002,
"heapDeltaBytes": -40879452,
"heapUsedBytes": 176264648,
"domNodes": -9850,
"jsHeapTotalBytes": 26480640,
"scriptDurationMs": 801.005,
"eventListeners": -23961,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12564.395000000104,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.105000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12545.482,
"heapDeltaBytes": -66134780,
"heapUsedBytes": 150010072,
"domNodes": -9850,
"jsHeapTotalBytes": -11182080,
"scriptDurationMs": 794.723,
"eventListeners": -23985,
"totalBlockingTimeMs": 27,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 472.88000000003194,
"styleRecalcs": 22,
"styleRecalcDurationMs": 28.508,
"layouts": 5,
"layoutDurationMs": 1.98,
"taskDurationMs": 144.044,
"heapDeltaBytes": 4789228,
"heapUsedBytes": 48802948,
"domNodes": 191,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 29.118000000000006,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 456.1879999999974,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.544,
"layouts": 6,
"layoutDurationMs": 1.6,
"taskDurationMs": 137.687,
"heapDeltaBytes": 4546976,
"heapUsedBytes": 48548740,
"domNodes": 156,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.926,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 457.320999999979,
"styleRecalcs": 20,
"styleRecalcDurationMs": 28.524999999999995,
"layouts": 6,
"layoutDurationMs": 1.9469999999999998,
"taskDurationMs": 138.40600000000003,
"heapDeltaBytes": 4573284,
"heapUsedBytes": 48656544,
"domNodes": 158,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.303,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
src/platform/missingModel/missingModelScan.ts (1)
73-92:⚠️ Potential issue | 🟠 MajorDisconnected loaders are still treated as executable.
The linked issue explicitly calls out not-connected loaders, but this scan only filters on
mode, so any active-but-unconnected loader still reachesscanNodeModelCandidates(). The same loose predicate is reused byhasActiveNodes, so workflow-level embedded models can also be materialized when the graph has no executable path. The original disconnected-loader false positive from#13256is still reproducible here.Also applies to: 233-238
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/platform/missingModel/missingModelScan.ts` around lines 73 - 92, The loop currently treats any node with an active mode as executable even if it is not connected; update the predicate before calling scanNodeModelCandidates to also require the node be connected (e.g., has at least one incoming or outgoing connection/edge) in addition to the existing mode checks and subgraph check — apply the same connectivity requirement inside hasActiveNodes so workflow-level embedded models are not treated as active when there is no executable path; reference the node properties used here (node.mode, node.isSubgraphNode, node.widgets) and the functions scanNodeModelCandidates and hasActiveNodes to locate where to add the connectivity check.src/platform/workflow/core/services/workflowService.ts (1)
251-265:⚠️ Potential issue | 🟠 MajorTab switches can leak the previous workflow's missing-model/media state.
openWorkflow()now skips asset rescans for already-loaded tabs, soshowPendingWarnings()is the only sync point on tab restore. In the empty-cache case it leaves both asset stores untouched, which means switching from a workflow with missing assets to one without them can still show the old cards.💡 Proposed fix
- showPendingWarnings(undefined, { silent: !loadFromRemote }) + showPendingWarnings(undefined, { + silent: !loadFromRemote, + syncAssetStores: !loadFromRemote + })- function showPendingWarnings( - workflow?: ComfyWorkflow | null, - options?: { silent?: boolean } - ) { + function showPendingWarnings( + workflow?: ComfyWorkflow | null, + options?: { silent?: boolean; syncAssetStores?: boolean } + ) { const wf = workflow ?? workflowStore.activeWorkflow if (!wf) return const { missingNodeTypes, missingModelCandidates, missingMediaCandidates } = wf.pendingWarnings ?? {} @@ - if (missingModelCandidates?.length) { - useMissingModelStore().setMissingModels(missingModelCandidates) - } - if (missingMediaCandidates?.length) { - useMissingMediaStore().setMissingMedia(missingMediaCandidates) - } + if (options?.syncAssetStores) { + useMissingModelStore().setMissingModels(missingModelCandidates ?? []) + useMissingMediaStore().setMissingMedia(missingMediaCandidates ?? []) + } else { + if (missingModelCandidates?.length) { + useMissingModelStore().setMissingModels(missingModelCandidates) + } + if (missingMediaCandidates?.length) { + useMissingMediaStore().setMissingMedia(missingMediaCandidates) + } + }Also applies to: 578-615
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/platform/workflow/core/services/workflowService.ts` around lines 251 - 265, openWorkflow() can leak the previous workflow's missing-model/media state because when loadGraphData is called with skipAssetScans: true the asset stores are left untouched and showPendingWarnings() will surface stale cards; fix by clearing the relevant missing-asset state before calling showPendingWarnings(). Specifically, in the openWorkflow() / workflow restore path where app.loadGraphData(..., { skipAssetScans: true, ... }) is invoked, call the app or workflow-level method that resets pending asset warnings (e.g., clearPendingWarnings(), resetMissingModels(), resetMissingMedia(), or clear asset-manager scan caches) right after loadGraphData returns and before showPendingWarnings() is called so the warning UI only reflects the newly-loaded workflow. Ensure the same change is applied to the other restore location noted (lines ~578-615).src/scripts/app.ts (1)
1129-1145:⚠️ Potential issue | 🔴 CriticalDead options:
showMissingNodesandshowMissingModelsare accepted but never used.The options interface still declares
showMissingNodesandshowMissingModels(lines 1130–1131), but they are not destructured or referenced anywhere in the function body. Callers (workflowService.ts:257–258andchangeTracker.ts:168–169) pass these options expecting them to control whether missing node/model errors are surfaced, but the values are silently ignored.The actual suppression mechanism uses
silentAssetErrorsinstead (passed torunMissingModelPipelineat line 1438 andrunMissingMediaPipelineat line 1441).Either remove these deprecated options from the type signature or extract and use them consistently across callers.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/scripts/app.ts` around lines 1129 - 1145, The options interface declares showMissingNodes and showMissingModels but they are never read; either remove these deprecated properties from the function signature and update callers to stop passing them, or explicitly extract them from options (e.g., const { showMissingNodes, showMissingModels, silentAssetErrors = false, ... } = options) and use them when invoking the suppression logic (pass the appropriate flag(s) into runMissingModelPipeline and runMissingMediaPipeline in place of or alongside silentAssetErrors so callers’ expectations are honored). Ensure references to showMissingNodes and showMissingModels are added where missing (or removed from callers) and keep silentAssetErrors behavior consistent with the chosen approach.
🧹 Nitpick comments (4)
src/platform/missingModel/missingModelStore.ts (1)
131-138: Consider cleaning up interaction state when removing candidates by nodeId.Unlike
removeMissingMediaByNodeIdinmissingMediaStore.ts(lines 124-141), this function does not clean up associated interaction state (modelExpandState,urlInputs,fileSizes, etc.) for removed candidates. This could leave stale UI state in the store.While
clearMissingModels()handles full cleanup on workflow/tab changes, incremental removals (e.g., when a node is deleted or bypassed) may leave orphaned entries.♻️ Suggested cleanup pattern (mirroring missingMediaStore)
function removeMissingModelsByNodeId(nodeId: string) { if (!missingModelCandidates.value) return + const removedKeys = new Set( + missingModelCandidates.value + .filter((m) => String(m.nodeId) === nodeId) + .map((m) => getModelStateKey(m.name, m.directory, m.isAssetSupported)) + ) missingModelCandidates.value = missingModelCandidates.value.filter( (m) => String(m.nodeId) !== nodeId ) + for (const key of removedKeys) { + if (!missingModelCandidates.value.some( + (m) => getModelStateKey(m.name, m.directory, m.isAssetSupported) === key + )) { + delete modelExpandState.value[key] + delete urlInputs.value[key] + // ... other state cleanup as needed + } + } if (!missingModelCandidates.value.length) missingModelCandidates.value = null }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/platform/missingModel/missingModelStore.ts` around lines 131 - 138, removeMissingModelsByNodeId currently only updates missingModelCandidates and can leave stale interaction state; update it to mirror removeMissingMediaByNodeId by identifying which candidate nodeIds were removed (compare prior missingModelCandidates to the filtered result or collect them during filter) and then delete/clean corresponding entries from modelExpandState, urlInputs, fileSizes (and any other per-candidate maps), and if those maps become empty set them to null; also ensure behavior remains consistent with clearMissingModels and use the existing symbols removeMissingModelsByNodeId, missingModelCandidates, modelExpandState, urlInputs, fileSizes, and clearMissingModels to locate and implement the cleanup.src/platform/missingMedia/missingMediaStore.ts (1)
143-149: Consider makingaddMissingMediaidempotent to avoid duplicate candidates.Appending blindly can duplicate the same candidate on repeated incremental scans, inflating counts and duplicate UI rows. Deduping by a stable key (e.g.,
nodeId + widgetName + name) would make updates safer.♻️ Suggested refactor
function addMissingMedia(media: MissingMediaCandidate[]) { if (!media.length) return - missingMediaCandidates.value = [ - ...(missingMediaCandidates.value ?? []), - ...media - ] + const deduped = new Map<string, MissingMediaCandidate>() + for (const item of [...(missingMediaCandidates.value ?? []), ...media]) { + const key = `${String(item.nodeId)}::${item.widgetName}::${item.name}` + deduped.set(key, item) + } + missingMediaCandidates.value = [...deduped.values()] }As per coding guidelines "Every entity state change must be a serializable, idempotent, deterministic command (replayable, undoable, transmittable over CRDT) per ADR 0003 + ADR 0008".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/platform/missingMedia/missingMediaStore.ts` around lines 143 - 149, The addMissingMedia function currently appends candidates blindly and can create duplicates; make it idempotent by deduplicating new entries against existing missingMediaCandidates using a stable key (e.g., nodeId + widgetName + name). In the addMissingMedia implementation, compute the stable key for each incoming MissingMediaCandidate, build a Set of existing keys from missingMediaCandidates.value, filter incoming media to only those whose key is not present, then append those filtered candidates (or replace the array with a deterministically ordered union) and update missingMediaCandidates.value. Ensure the dedupe logic references addMissingMedia and missingMediaCandidates so state changes remain serializable and deterministic.src/scripts/app.ts (2)
1602-1616: Minor duplication in pendingWarnings cleanup logic.The null-cleanup logic (lines 1609-1615) is duplicated with
runMissingModelPipeline(lines 1521-1526). Consider extracting a helper function.♻️ Optional: Extract cleanup helper
private cleanupPendingWarnings(wf: ComfyWorkflow) { if ( !wf.pendingWarnings?.missingNodeTypes && !wf.pendingWarnings?.missingModelCandidates && !wf.pendingWarnings?.missingMediaCandidates ) { wf.pendingWarnings = null } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/scripts/app.ts` around lines 1602 - 1616, The pendingWarnings null-cleanup is duplicated between cacheModelCandidates and runMissingModelPipeline; extract a helper like cleanupPendingWarnings(wf: ComfyWorkflow) that checks wf.pendingWarnings?.missingNodeTypes, .missingModelCandidates, and .missingMediaCandidates and sets wf.pendingWarnings = null when all are falsy, then replace the duplicated block in cacheModelCandidates and runMissingModelPipeline with a call to cleanupPendingWarnings(wf) to remove duplication and centralize the logic.
1231-1256: UseLGraphEventModeenum constants instead of magic numbers for node modes.The logic correctly filters muted/bypassed nodes from the error list while still sanitizing their names. However, the magic numbers
2and4for node modes reduce readability. Replace them with theLGraphEventModeenum constants that are already exported from the litegraph module.♻️ Suggested improvement: Use named constants
import { LGraph, LGraphCanvas, LGraphNode, LiteGraph, + LGraphEventMode } from '@/lib/litegraph/src/litegraph' - const isMuted = n.mode === 2 || n.mode === 4 + const isMuted = n.mode === LGraphEventMode.NEVER || n.mode === LGraphEventMode.BYPASS🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/scripts/app.ts` around lines 1231 - 1256, The code uses magic numbers 2 and 4 to detect muted/bypassed nodes (n.mode === 2 || n.mode === 4); replace those with the named enum constants exported from litegraph (LGraphEventMode.BYPASS and LGraphEventMode.MUTED or the exact enum member names provided by litegraph) so the condition reads something like n.mode === LGraphEventMode.X || n.mode === LGraphEventMode.Y; update the check near where missingNodeTypes is pushed (referencing n.mode, nodeReplacementStore.getReplacementFor, getCnrIdFromProperties, sanitizeNodeName) to use the enum constants instead of the numeric literals and keep the rest of the logic unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/composables/graph/useErrorClearingHooks.ts`:
- Around line 305-319: The onNodeRemoved handler currently only deletes exact
execId entries and can miss descendants and cases where getExecutionIdByNode
returns null after LiteGraph detaches the node; update graph.onNodeRemoved to
(1) derive a fallback execId when getExecutionIdByNode(app.rootGraph, node) is
null for subgraph root deletions (e.g., fallback to String(node.id) when node is
a SubgraphNode or node.type indicates a subgraph) and (2) call the stores' broad
removal helper (removeNodeErrors) instead of the exact-id removers so descendant
keys like `${execId}:...` are cleared—adjust calls to
useMissingModelStore().removeNodeErrors(execId),
useMissingMediaStore().removeNodeErrors(execId), and
useMissingNodesErrorStore().removeNodeErrors(execId) inside graph.onNodeRemoved
alongside the existing logic (refer to graph.onNodeRemoved,
getExecutionIdByNode, and the removeNodeErrors methods).
---
Outside diff comments:
In `@src/platform/missingModel/missingModelScan.ts`:
- Around line 73-92: The loop currently treats any node with an active mode as
executable even if it is not connected; update the predicate before calling
scanNodeModelCandidates to also require the node be connected (e.g., has at
least one incoming or outgoing connection/edge) in addition to the existing mode
checks and subgraph check — apply the same connectivity requirement inside
hasActiveNodes so workflow-level embedded models are not treated as active when
there is no executable path; reference the node properties used here (node.mode,
node.isSubgraphNode, node.widgets) and the functions scanNodeModelCandidates and
hasActiveNodes to locate where to add the connectivity check.
In `@src/platform/workflow/core/services/workflowService.ts`:
- Around line 251-265: openWorkflow() can leak the previous workflow's
missing-model/media state because when loadGraphData is called with
skipAssetScans: true the asset stores are left untouched and
showPendingWarnings() will surface stale cards; fix by clearing the relevant
missing-asset state before calling showPendingWarnings(). Specifically, in the
openWorkflow() / workflow restore path where app.loadGraphData(..., {
skipAssetScans: true, ... }) is invoked, call the app or workflow-level method
that resets pending asset warnings (e.g., clearPendingWarnings(),
resetMissingModels(), resetMissingMedia(), or clear asset-manager scan caches)
right after loadGraphData returns and before showPendingWarnings() is called so
the warning UI only reflects the newly-loaded workflow. Ensure the same change
is applied to the other restore location noted (lines ~578-615).
In `@src/scripts/app.ts`:
- Around line 1129-1145: The options interface declares showMissingNodes and
showMissingModels but they are never read; either remove these deprecated
properties from the function signature and update callers to stop passing them,
or explicitly extract them from options (e.g., const { showMissingNodes,
showMissingModels, silentAssetErrors = false, ... } = options) and use them when
invoking the suppression logic (pass the appropriate flag(s) into
runMissingModelPipeline and runMissingMediaPipeline in place of or alongside
silentAssetErrors so callers’ expectations are honored). Ensure references to
showMissingNodes and showMissingModels are added where missing (or removed from
callers) and keep silentAssetErrors behavior consistent with the chosen
approach.
---
Nitpick comments:
In `@src/platform/missingMedia/missingMediaStore.ts`:
- Around line 143-149: The addMissingMedia function currently appends candidates
blindly and can create duplicates; make it idempotent by deduplicating new
entries against existing missingMediaCandidates using a stable key (e.g., nodeId
+ widgetName + name). In the addMissingMedia implementation, compute the stable
key for each incoming MissingMediaCandidate, build a Set of existing keys from
missingMediaCandidates.value, filter incoming media to only those whose key is
not present, then append those filtered candidates (or replace the array with a
deterministically ordered union) and update missingMediaCandidates.value. Ensure
the dedupe logic references addMissingMedia and missingMediaCandidates so state
changes remain serializable and deterministic.
In `@src/platform/missingModel/missingModelStore.ts`:
- Around line 131-138: removeMissingModelsByNodeId currently only updates
missingModelCandidates and can leave stale interaction state; update it to
mirror removeMissingMediaByNodeId by identifying which candidate nodeIds were
removed (compare prior missingModelCandidates to the filtered result or collect
them during filter) and then delete/clean corresponding entries from
modelExpandState, urlInputs, fileSizes (and any other per-candidate maps), and
if those maps become empty set them to null; also ensure behavior remains
consistent with clearMissingModels and use the existing symbols
removeMissingModelsByNodeId, missingModelCandidates, modelExpandState,
urlInputs, fileSizes, and clearMissingModels to locate and implement the
cleanup.
In `@src/scripts/app.ts`:
- Around line 1602-1616: The pendingWarnings null-cleanup is duplicated between
cacheModelCandidates and runMissingModelPipeline; extract a helper like
cleanupPendingWarnings(wf: ComfyWorkflow) that checks
wf.pendingWarnings?.missingNodeTypes, .missingModelCandidates, and
.missingMediaCandidates and sets wf.pendingWarnings = null when all are falsy,
then replace the duplicated block in cacheModelCandidates and
runMissingModelPipeline with a call to cleanupPendingWarnings(wf) to remove
duplication and centralize the logic.
- Around line 1231-1256: The code uses magic numbers 2 and 4 to detect
muted/bypassed nodes (n.mode === 2 || n.mode === 4); replace those with the
named enum constants exported from litegraph (LGraphEventMode.BYPASS and
LGraphEventMode.MUTED or the exact enum member names provided by litegraph) so
the condition reads something like n.mode === LGraphEventMode.X || n.mode ===
LGraphEventMode.Y; update the check near where missingNodeTypes is pushed
(referencing n.mode, nodeReplacementStore.getReplacementFor,
getCnrIdFromProperties, sanitizeNodeName) to use the enum constants instead of
the numeric literals and keep the rest of the logic unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c8211583-5310-41bc-9459-0c1d8cecf852
📒 Files selected for processing (24)
src/components/rightSidePanel/RightSidePanel.vuesrc/components/rightSidePanel/errors/TabErrors.vuesrc/components/rightSidePanel/errors/useErrorGroups.tssrc/composables/graph/useErrorClearingHooks.tssrc/platform/missingMedia/missingMediaScan.test.tssrc/platform/missingMedia/missingMediaScan.tssrc/platform/missingMedia/missingMediaStore.test.tssrc/platform/missingMedia/missingMediaStore.tssrc/platform/missingModel/components/MissingModelRow.vuesrc/platform/missingModel/missingModelScan.test.tssrc/platform/missingModel/missingModelScan.tssrc/platform/missingModel/missingModelStore.test.tssrc/platform/missingModel/missingModelStore.tssrc/platform/nodeReplacement/missingNodeScan.test.tssrc/platform/nodeReplacement/missingNodeScan.tssrc/platform/nodeReplacement/missingNodesErrorStore.test.tssrc/platform/nodeReplacement/missingNodesErrorStore.tssrc/platform/workflow/core/services/workflowService.test.tssrc/platform/workflow/core/services/workflowService.tssrc/platform/workflow/management/stores/comfyWorkflow.tssrc/scripts/app.tssrc/scripts/changeTracker.tssrc/stores/executionErrorStore.test.tssrc/stores/executionErrorStore.ts
- Replace magic numbers (2, 4) with LGraphEventMode.NEVER/BYPASS - Remove unused showMissingNodes/showMissingModels options from loadGraphData and all callers - Make addMissingModels/addMissingMedia idempotent (deduplicate by nodeId::widgetName::name key) - Extract cleanupPendingWarnings helper to eliminate duplication across cacheModelCandidates, cacheMediaCandidates, and runMissingModelPipeline - Clean interaction state (expandState, urlInputs, fileSizes, etc.) in removeMissingModelsByNodeId, mirroring missingMediaStore pattern - Fix subgraph deletion edge case: use removeNodeErrors (prefix-based removal) in onNodeRemoved; add fallback execId for detached nodes
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/scripts/app.ts`:
- Around line 1610-1628: cacheModelCandidates and cacheMediaCandidates read
useWorkspaceStore().workflow.activeWorkflow at call time, risking writing
pendingWarnings into a different workflow after async operations; change these
helpers to accept the workflow (or its stable id) captured at scan start and use
that passed-in wf when setting wf.pendingWarnings and calling
cleanupPendingWarnings so they no longer call
useWorkspaceStore().workflow.activeWorkflow inside the helper — update all call
sites (the async callbacks around lines where the scan starts) to pass the
captured wf (or wf.id) into cacheModelCandidates/cacheMediaCandidates and
cleanupPendingWarnings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3eae40dc-7a11-4bbc-ba97-a7c7a230e642
📒 Files selected for processing (6)
src/composables/graph/useErrorClearingHooks.tssrc/platform/missingMedia/missingMediaStore.tssrc/platform/missingModel/missingModelStore.tssrc/platform/workflow/core/services/workflowService.tssrc/scripts/app.tssrc/scripts/changeTracker.ts
✅ Files skipped from review due to trivial changes (1)
- src/composables/graph/useErrorClearingHooks.ts
🚧 Files skipped from review as they are similar to previous changes (3)
- src/platform/missingMedia/missingMediaStore.ts
- src/platform/missingModel/missingModelStore.ts
- src/platform/workflow/core/services/workflowService.ts
cacheModelCandidates/cacheMediaCandidates previously read activeWorkflow at callback time, which could target the wrong workflow after an async tab switch. Now both pipelines capture the workflow reference at start and pass it to cache helpers.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/scripts/app.ts (1)
1528-1540:⚠️ Potential issue | 🟡 MinorMark these detached promise chains with
void.Both calls at lines 1528–1540 and 1559–1577 are intentionally fire-and-forget but lack the
voidprefix, which violates the repo's Oxlinttypescript/no-floating-promiseserror rule (enforced in.oxlintrc.json). Line 1648 already demonstrates the correct pattern. Addvoidto suppress the linter:Suggested fix
- verifyAssetSupportedCandidates(enrichedCandidates, controller.signal) + void verifyAssetSupportedCandidates(enrichedCandidates, controller.signal) .then(() => { if (controller.signal.aborted) return const confirmed = enrichedCandidates.filter( (c) => c.isMissing === true ) if (confirmed.length) { useExecutionErrorStore().surfaceMissingModels(confirmed, { silent }) } this.cacheModelCandidates(activeWf, confirmed) })- api + void api .getFolderPaths() .then((paths) => { if (controller.signal.aborted) return missingModelStore.setFolderPaths(paths) })🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/scripts/app.ts` around lines 1528 - 1540, The promise chains that call verifyAssetSupportedCandidates(...) (the block that then filters enrichedCandidates, calls useExecutionErrorStore().surfaceMissingModels(...), and this.cacheModelCandidates(...)) and the similar fire-and-forget chain later must be prefixed with void to mark them intentionally detached; update the call sites so they use void verifyAssetSupportedCandidates(...).then(...) (and the analogous second call) to satisfy the typescript/no-floating-promises rule and match the pattern used at the existing correctly-marked example.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/scripts/app.ts`:
- Around line 1435-1448: The early return when skipAssetScans is true prevents
the only update to wf.pendingWarnings that lives inside runMissingModelPipeline,
causing stale warnings; ensure pending warnings are updated even when asset
scans are skipped by extracting or invoking the pending-warnings update logic
outside runMissingModelPipeline. Concretely, either (A) move the code that
writes to wf.pendingWarnings from runMissingModelPipeline into a shared helper
and call it here after recomputing missingNodeTypes, or (B) call
runMissingModelPipeline with a lightweight flag/variant (e.g.,
runMissingModelPipeline(..., { updateOnly: true })) that performs only the
pending-warnings write when skipAssetScans is true; reference
runMissingModelPipeline, runMissingMediaPipeline, skipAssetScans and
useWorkflowService().showPendingWarnings/wf.pendingWarnings when making the
change.
---
Outside diff comments:
In `@src/scripts/app.ts`:
- Around line 1528-1540: The promise chains that call
verifyAssetSupportedCandidates(...) (the block that then filters
enrichedCandidates, calls useExecutionErrorStore().surfaceMissingModels(...),
and this.cacheModelCandidates(...)) and the similar fire-and-forget chain later
must be prefixed with void to mark them intentionally detached; update the call
sites so they use void verifyAssetSupportedCandidates(...).then(...) (and the
analogous second call) to satisfy the typescript/no-floating-promises rule and
match the pattern used at the existing correctly-marked example.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8ec41664-7be6-40dc-9215-cc8b7b4d3aea
📒 Files selected for processing (1)
src/scripts/app.ts
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #10856 +/- ##
==========================================
+ Coverage 43.36% 43.64% +0.27%
==========================================
Files 1347 1349 +2
Lines 68470 69149 +679
Branches 18052 19159 +1107
==========================================
+ Hits 29694 30181 +487
- Misses 38186 38370 +184
- Partials 590 598 +8
... and 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
- Update missing_models.json fixture to include an active node so the hasActiveNodes filter passes, with matching directory for URL enrichment - Split workflow tab-switch test into two: verify overlay stays silent and verify missing nodes data restores in errors tab - Add openErrorsTab helper to ErrorsTabHelper for reusable properties panel errors tab access
- Add errorsTabModeAware.spec.ts covering bypass/activate, deletion, undo/redo, paste, node selection filtering, and subgraph scenarios for missing models, media, and nodes - Add bypassed variant fixtures for missing models and media - Add subgraph fixture with interior CheckpointLoaderSimple - Add data-testid to RightSidePanel tabs for stable selectors - Update ErrorsTabHelper to use test-id based openErrorsTab helper - Fix missing_models_with_nodes fixture directory mismatch
- Move error-related TestIds from dialogs to errorsTab namespace - Remove unused TestIdValue type - Extract cleanupFakeModel to shared ErrorsTabHelper - Rename openErrorsTabViaSeeErrors to loadWorkflowAndOpenErrorsTab - Move workflow-switching error tests from workflows.spec.ts to errorsTabModeAware.spec.ts - Add afterEach cleanup for fake model tests - Add missing model deletion and undo/redo tests - Remove explicit timeout: 3000 on negative visibility assertions - Add aria-label to pencil edit button and subgraph toggle - Add i18n keys for editTitle and editSubgraph - Add JSDoc comment on cleanupFakeModel explaining fixture URLs
- Replace selectAll+bypass with node-specific click+bypass in missing media tests for deterministic behavior - Move media fixture nodes from y:50 to y:200 to avoid top menu overlap - Replace deselectAll evaluate with canvas.click at empty position
There was a problem hiding this comment.
🧹 Nitpick comments (2)
browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts (2)
50-64: Consider extracting repeated bypass/un-bypass assertions into a helperThe bypass toggle +
isBypassedpolling + group visibility checks are repeated across multiple tests. Moving this toErrorsTabHelperwould reduce duplication and future drift.Also applies to: 103-113, 262-272, 193-207
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts` around lines 50 - 64, Extract the repeated sequence that toggles bypass and asserts state into a helper on ErrorsTabHelper: create a method (e.g., toggleAndAssertBypass) that accepts the nodeRef (from comfyPage.nodeOps.getNodeRefById), the action to perform (bypass/undo/redo via comfyPage.keyboard.bypass/undo/redo or a string enum), and expected booleans for node.isBypassed and visibility of missingNodeGroup/errorOverlay; replace the repeated blocks (the ones using node.click('title'), comfyPage.keyboard.bypass/undo/redo, expect.poll(() => node.isBypassed()), expect(missingNodeGroup).(not.)toBeVisible(), expect(errorOverlay).(not.)toBeVisible()) with calls to ErrorsTabHelper.toggleAndAssertBypass and keep openErrorsTab calls where needed. Ensure the helper polls node.isBypassed and performs both visibility assertions so all duplicated sequences (lines referenced) use this single helper.
324-324: Avoid fixed canvas coordinates for deselectionLine 324 hard-codes a click position, which can become flaky with viewport/layout drift. Prefer a non-positional deselect action (same pattern already used elsewhere in this file).
Proposed change
- await comfyPage.canvas.click({ position: { x: 400, y: 600 } }) + await comfyPage.canvas.click()🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts` at line 324, Replace the hard-coded positional click in the test (the call to comfyPage.canvas.click({ position: { x: 400, y: 600 } })) with a non-positional deselect action used elsewhere in this spec file—e.g., call comfyPage.canvas.click() without a position (or the file’s existing deselect helper if present) so the test does not rely on fixed canvas coordinates.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@browser_tests/tests/propertiesPanel/errorsTabModeAware.spec.ts`:
- Around line 50-64: Extract the repeated sequence that toggles bypass and
asserts state into a helper on ErrorsTabHelper: create a method (e.g.,
toggleAndAssertBypass) that accepts the nodeRef (from
comfyPage.nodeOps.getNodeRefById), the action to perform (bypass/undo/redo via
comfyPage.keyboard.bypass/undo/redo or a string enum), and expected booleans for
node.isBypassed and visibility of missingNodeGroup/errorOverlay; replace the
repeated blocks (the ones using node.click('title'),
comfyPage.keyboard.bypass/undo/redo, expect.poll(() => node.isBypassed()),
expect(missingNodeGroup).(not.)toBeVisible(),
expect(errorOverlay).(not.)toBeVisible()) with calls to
ErrorsTabHelper.toggleAndAssertBypass and keep openErrorsTab calls where needed.
Ensure the helper polls node.isBypassed and performs both visibility assertions
so all duplicated sequences (lines referenced) use this single helper.
- Line 324: Replace the hard-coded positional click in the test (the call to
comfyPage.canvas.click({ position: { x: 400, y: 600 } })) with a non-positional
deselect action used elsewhere in this spec file—e.g., call
comfyPage.canvas.click() without a position (or the file’s existing deselect
helper if present) so the test does not rely on fixed canvas coordinates.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2a8d3d12-8db8-45fc-9d21-22d8a2765d7f
📒 Files selected for processing (17)
browser_tests/assets/missing/missing_media_bypassed.jsonbrowser_tests/assets/missing/missing_media_multiple.jsonbrowser_tests/assets/missing/missing_media_single.jsonbrowser_tests/assets/missing/missing_models.jsonbrowser_tests/assets/missing/missing_models_bypassed.jsonbrowser_tests/assets/missing/missing_models_in_subgraph.jsonbrowser_tests/assets/missing/missing_models_with_nodes.jsonbrowser_tests/fixtures/selectors.tsbrowser_tests/tests/errorOverlay.spec.tsbrowser_tests/tests/propertiesPanel/ErrorsTabHelper.tsbrowser_tests/tests/propertiesPanel/errorsTab.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabExecution.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabMissingMedia.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabMissingNodes.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabModeAware.spec.tsbrowser_tests/tests/sidebar/workflows.spec.ts
💤 Files with no reviewable changes (1)
- browser_tests/tests/sidebar/workflows.spec.ts
✅ Files skipped from review due to trivial changes (7)
- browser_tests/assets/missing/missing_media_single.json
- browser_tests/assets/missing/missing_media_multiple.json
- browser_tests/assets/missing/missing_models_with_nodes.json
- browser_tests/assets/missing/missing_models.json
- browser_tests/assets/missing/missing_media_bypassed.json
- browser_tests/assets/missing/missing_models_bypassed.json
- browser_tests/assets/missing/missing_models_in_subgraph.json
- Move overlay non-resurface test to errorOverlay.spec.ts Persistence - Add sidebar setup for workflow switching test - Fix copy-name button click intercepted by copy-url button - Add void prefix to floating promise chains in app.ts
|
Updating Playwright Expectations |
|
Nodes in mute or bypass mode are now excluded from the "missing model" error, which causes some failures in the screenshot test. To resolve this, a new screenshot is captured. |
|
|
|
|
…sset detection (#10856) Cherry-pick of 521019d onto core/1.43. Manual conflict resolution on two files, both limited to the `cleanupFakeModel` helper extraction: - browser_tests/tests/errorOverlay.spec.ts - browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts core/1.43 base still had the inline `expect(cleanupOk).toBeTruthy()` implementation; main's version (post-#10967) uses `expect.poll()` inline; #10856 replaced both with `await cleanupFakeModel(comfyPage)` calling the new helper in ErrorsTabHelper.ts. Conflict resolved by accepting the PR version (helper call) on both files, since the new helper is added in this same commit.
…asset detection (#10856) Cherry-pick of 521019d onto cloud/1.43. Manual conflict resolution on two files (same root cause as the core/1.43 backport), both limited to the `cleanupFakeModel` helper extraction: - browser_tests/tests/errorOverlay.spec.ts - browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts cloud/1.43 base still had the inline `expect(cleanupOk).toBeTruthy()` implementation; #10856 replaced both sites with `await cleanupFakeModel(comfyPage)` calling the new helper in ErrorsTabHelper.ts. Conflict resolved by accepting the PR version (helper call); the helper itself is added in this same commit.
1. ErrorOverlay count reflected node-selection filtering. useErrorGroups exposed filteredMissingModelGroups under the name missingModelGroups. ErrorOverlay read that alias for its model count label, so selecting a node shrunk the overlay's total. Expose both unfiltered (missingModelGroups / missingMediaGroups) and filtered variants so ErrorOverlay gets the true total and the errors tab still gets selection-scoped groups. TabErrors renamed its destructure. 2. bypass/un-bypass of a missing-model node dropped url/hash metadata. Realtime scanNodeModelCandidates only reads widget values, so un-bypass produced a fresh candidate without the url that enrichWithEmbeddedMetadata had previously attached from graphData.models. Add enrichCandidateFromNodeProperties which copies url/hash/directory from the node's own properties.models (persistent across mode toggles). Applies to every call site of the per-node scan, so paste, un-bypass, and mode change all restore the metadata. 3. Initial full scan surfaced interior errors of muted/bypassed subgraph containers. scanAllModelCandidates, scanAllMediaCandidates, and the JSON missing-node scan only check each node's own mode; interior nodes whose parent container is bypassed passed through. Runtime handleNodeModeChange already filters correctly — the bug was scoped to the initial-load path. Add isAncestorPathActive to graphTraversalUtil and post-filter the three pipelines in runMissingModelPipeline / runMissingMediaPipeline / loadGraphData before the results are cached or surfaced.
Follow-up to #10856. Four correctness issues and their regression tests. ## Bugs fixed ### 1. ErrorOverlay model count reflected node selection `useErrorGroups` exposed `filteredMissingModelGroups` under the public name `missingModelGroups`. `ErrorOverlay.vue` read that alias to compute its model count label, so selecting a node shrank the overlay total. The overlay must always show the whole workflow's errors. Exposed both shapes explicitly: `missingModelGroups` / `missingMediaGroups` (unfiltered totals) and `filteredMissingModelGroups` / `filteredMissingMediaGroups` (selection-scoped). `TabErrors.vue` destructures the filtered variant with an alias. Before https://github.com/user-attachments/assets/eb848c5f-d092-4a4f-b86f-d22bb4408003 After https://github.com/user-attachments/assets/75e67819-c9f2-45ec-9241-74023eca6120 ### 2. Bypass → un-bypass dropped url/hash metadata Realtime `scanNodeModelCandidates` only reads widget values, so un-bypass produced a fresh candidate without the url that `enrichWithEmbeddedMetadata` had previously attached from `graphData.models`. `MissingModelRow`'s download/copy-url buttons disappeared after a bypass/un-bypass cycle. Added `enrichCandidateFromNodeProperties` that copies `url`/`hash`/`directory` from the node's own `properties.models` — which persists across mode toggles — into each scanned candidate. Applied to every call site of the per-node scan. A later fix in the same branch also enforces directory agreement to prevent a same-name / different-directory collision from stamping the wrong metadata. Before https://github.com/user-attachments/assets/39039d83-4d55-41a9-9d01-dec40843741b After https://github.com/user-attachments/assets/047a603b-fb52-4320-886d-dfeed457d833 ### 3. Initial full scan surfaced interior errors of a muted/bypassed subgraph container `scanAllModelCandidates`, `scanAllMediaCandidates`, and the JSON-based missing-node scan only check each node's own mode. Interior nodes whose parent container was bypassed passed the filter. Added `isAncestorPathActive(rootGraph, executionId)` to `graphTraversalUtil` and post-filter the three pipelines in `app.ts` after the live rootGraph is configured. The filter uses the execution-ID path (`"65:63"` → check node 65's mode) so it handles both live-scan-produced and JSON-enrichment-produced candidates. Before https://github.com/user-attachments/assets/3032d46b-81cd-420e-ab8e-f58392267602 After https://github.com/user-attachments/assets/02a01931-951d-4a48-986c-06424044fbf8 ### 4. Bypassed subgraph entry re-surfaced interior errors `useGraphNodeManager` replays `graph.onNodeAdded` for each existing interior node when the Vue node manager initializes on subgraph entry. That chain reached `scanSingleNodeErrors` via `installErrorClearingHooks`' `onNodeAdded` override. Each interior node's own mode was active, so the caller guards passed and the scan re-introduced the error that the initial pipeline had correctly suppressed. Added an ancestor-activity gate at the top of `scanSingleNodeErrors`, the single entry point shared by paste, un-bypass, subgraph entry, and subgraph container activation. A later commit also hardens this guard against detached nodes (null execution ID → skip) and applies the same ancestor check to `isCandidateStillActive` in the realtime verification callback. Before https://github.com/user-attachments/assets/fe44862d-f1d6-41ed-982d-614a7e83d441 After https://github.com/user-attachments/assets/497a76ce-3caa-479f-9024-4cd0f7bd20a4 ## Tests - 6 unit tests for `isAncestorPathActive` (root, active, immediate-bypass, deep-nested mute, unresolvable ancestor, null rootGraph) - 4 unit tests for `enrichCandidateFromNodeProperties` (enrichment, no-overwrite, name mismatch, directory mismatch) - 1 unit test for `scanSingleNodeErrors` ancestor guard (subgraph entry replaying onNodeAdded) - 2 unit tests for `useErrorGroups` dual export + ErrorOverlay contract - 4 E2E tests: - ErrorOverlay model count stays constant when a node is selected (new fixture `missing_models_distinct.json`) - Bypass/un-bypass cycle preserves Copy URL button (uses `missing_models_from_node_properties`) - Loading a workflow with bypassed subgraph suppresses interior missing model error (new fixture `missing_models_in_bypassed_subgraph.json`) - Entering a bypassed subgraph does not resurface interior missing model error (shares the above fixture) `pnpm typecheck`, `pnpm lint`, 206 related unit tests passing. ## Follow-up Several items raised by code review are deferred as pre-existing tech debt or scope-avoided refactors. Tracked via comments on #11215 and #11216. --- Follows up on #10856.
…sset detection (#10856) (#11217) Manual backport of #10856 to `core/1.43`. ## Conflicts resolved Two files had trivial conflicts from the same root cause — #10856 extracted the inline `cleanup_fake_model` block into a shared `cleanupFakeModel` helper in `browser_tests/tests/propertiesPanel/ErrorsTabHelper.ts`: - `browser_tests/tests/errorOverlay.spec.ts` - `browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts` `core/1.43` still carries the original inline `expect(cleanupOk).toBeTruthy()` form. main's version (post-#10967) uses an inline `expect.poll()` instead. #10856 replaces both with `await cleanupFakeModel(comfyPage)` calling the helper added by this same PR. Resolution: accepted the PR version (helper call) on both conflict sites. The helper itself is added as part of this backport, so no runtime behavior is lost. ## Verification - No residual conflict markers - Cherry-picked commit carries the entire #10856 squash (45 files, +3596/-209) ## Original PR summary See #10856 for full behavioral description, test plan, and screenshots. --- Fixes Comfy-Org/ComfyUI#13256 on core/1.43 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11217-backport-core-1-43-fix-exclude-muted-bypassed-nodes-from-missing-asset-detection-10-3426d73d365081f0becbcf7d909f0021) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
…asset detection (#10856) (#11218) Manual backport of #10856 to `cloud/1.43`. Paired with core/1.43 backport #11217. ## Conflicts resolved Same two files, same root cause as the core/1.43 backport — #10856 extracted the inline `cleanup_fake_model` block into a shared `cleanupFakeModel` helper in `browser_tests/tests/propertiesPanel/ErrorsTabHelper.ts`: - `browser_tests/tests/errorOverlay.spec.ts` - `browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts` `cloud/1.43` still carries the original inline `expect(cleanupOk).toBeTruthy()` form. #10856 replaces both with `await cleanupFakeModel(comfyPage)` calling the helper added by this same PR. Resolution: accepted the PR version (helper call) on both conflict sites. The helper itself is added as part of this backport, so no runtime behavior is lost. ## Verification - No residual conflict markers - Cherry-picked commit carries the entire #10856 squash (45 files, +3596/-209) ## Original PR summary See #10856 for full behavioral description, test plan, and screenshots. --- Fixes Comfy-Org/ComfyUI#13256 on cloud/1.43 ┆Issue is synchronized with this [Notion page](https://app.notion.com/p/PR-11218-backport-cloud-1-43-fix-exclude-muted-bypassed-nodes-from-missing-asset-detection-1-3426d73d3650811e9a27d4a334c74de8) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Follow-up to #10856. Four correctness issues and their regression tests. ## Bugs fixed ### 1. ErrorOverlay model count reflected node selection `useErrorGroups` exposed `filteredMissingModelGroups` under the public name `missingModelGroups`. `ErrorOverlay.vue` read that alias to compute its model count label, so selecting a node shrank the overlay total. The overlay must always show the whole workflow's errors. Exposed both shapes explicitly: `missingModelGroups` / `missingMediaGroups` (unfiltered totals) and `filteredMissingModelGroups` / `filteredMissingMediaGroups` (selection-scoped). `TabErrors.vue` destructures the filtered variant with an alias. Before https://github.com/user-attachments/assets/eb848c5f-d092-4a4f-b86f-d22bb4408003 After https://github.com/user-attachments/assets/75e67819-c9f2-45ec-9241-74023eca6120 ### 2. Bypass → un-bypass dropped url/hash metadata Realtime `scanNodeModelCandidates` only reads widget values, so un-bypass produced a fresh candidate without the url that `enrichWithEmbeddedMetadata` had previously attached from `graphData.models`. `MissingModelRow`'s download/copy-url buttons disappeared after a bypass/un-bypass cycle. Added `enrichCandidateFromNodeProperties` that copies `url`/`hash`/`directory` from the node's own `properties.models` — which persists across mode toggles — into each scanned candidate. Applied to every call site of the per-node scan. A later fix in the same branch also enforces directory agreement to prevent a same-name / different-directory collision from stamping the wrong metadata. Before https://github.com/user-attachments/assets/39039d83-4d55-41a9-9d01-dec40843741b After https://github.com/user-attachments/assets/047a603b-fb52-4320-886d-dfeed457d833 ### 3. Initial full scan surfaced interior errors of a muted/bypassed subgraph container `scanAllModelCandidates`, `scanAllMediaCandidates`, and the JSON-based missing-node scan only check each node's own mode. Interior nodes whose parent container was bypassed passed the filter. Added `isAncestorPathActive(rootGraph, executionId)` to `graphTraversalUtil` and post-filter the three pipelines in `app.ts` after the live rootGraph is configured. The filter uses the execution-ID path (`"65:63"` → check node 65's mode) so it handles both live-scan-produced and JSON-enrichment-produced candidates. Before https://github.com/user-attachments/assets/3032d46b-81cd-420e-ab8e-f58392267602 After https://github.com/user-attachments/assets/02a01931-951d-4a48-986c-06424044fbf8 ### 4. Bypassed subgraph entry re-surfaced interior errors `useGraphNodeManager` replays `graph.onNodeAdded` for each existing interior node when the Vue node manager initializes on subgraph entry. That chain reached `scanSingleNodeErrors` via `installErrorClearingHooks`' `onNodeAdded` override. Each interior node's own mode was active, so the caller guards passed and the scan re-introduced the error that the initial pipeline had correctly suppressed. Added an ancestor-activity gate at the top of `scanSingleNodeErrors`, the single entry point shared by paste, un-bypass, subgraph entry, and subgraph container activation. A later commit also hardens this guard against detached nodes (null execution ID → skip) and applies the same ancestor check to `isCandidateStillActive` in the realtime verification callback. Before https://github.com/user-attachments/assets/fe44862d-f1d6-41ed-982d-614a7e83d441 After https://github.com/user-attachments/assets/497a76ce-3caa-479f-9024-4cd0f7bd20a4 ## Tests - 6 unit tests for `isAncestorPathActive` (root, active, immediate-bypass, deep-nested mute, unresolvable ancestor, null rootGraph) - 4 unit tests for `enrichCandidateFromNodeProperties` (enrichment, no-overwrite, name mismatch, directory mismatch) - 1 unit test for `scanSingleNodeErrors` ancestor guard (subgraph entry replaying onNodeAdded) - 2 unit tests for `useErrorGroups` dual export + ErrorOverlay contract - 4 E2E tests: - ErrorOverlay model count stays constant when a node is selected (new fixture `missing_models_distinct.json`) - Bypass/un-bypass cycle preserves Copy URL button (uses `missing_models_from_node_properties`) - Loading a workflow with bypassed subgraph suppresses interior missing model error (new fixture `missing_models_in_bypassed_subgraph.json`) - Entering a bypassed subgraph does not resurface interior missing model error (shares the above fixture) `pnpm typecheck`, `pnpm lint`, 206 related unit tests passing. ## Follow-up Several items raised by code review are deferred as pre-existing tech debt or scope-avoided refactors. Tracked via comments on #11215 and #11216. --- Follows up on #10856.
Follow-up to #10856. Four correctness issues and their regression tests. ## Bugs fixed ### 1. ErrorOverlay model count reflected node selection `useErrorGroups` exposed `filteredMissingModelGroups` under the public name `missingModelGroups`. `ErrorOverlay.vue` read that alias to compute its model count label, so selecting a node shrank the overlay total. The overlay must always show the whole workflow's errors. Exposed both shapes explicitly: `missingModelGroups` / `missingMediaGroups` (unfiltered totals) and `filteredMissingModelGroups` / `filteredMissingMediaGroups` (selection-scoped). `TabErrors.vue` destructures the filtered variant with an alias. Before https://github.com/user-attachments/assets/eb848c5f-d092-4a4f-b86f-d22bb4408003 After https://github.com/user-attachments/assets/75e67819-c9f2-45ec-9241-74023eca6120 ### 2. Bypass → un-bypass dropped url/hash metadata Realtime `scanNodeModelCandidates` only reads widget values, so un-bypass produced a fresh candidate without the url that `enrichWithEmbeddedMetadata` had previously attached from `graphData.models`. `MissingModelRow`'s download/copy-url buttons disappeared after a bypass/un-bypass cycle. Added `enrichCandidateFromNodeProperties` that copies `url`/`hash`/`directory` from the node's own `properties.models` — which persists across mode toggles — into each scanned candidate. Applied to every call site of the per-node scan. A later fix in the same branch also enforces directory agreement to prevent a same-name / different-directory collision from stamping the wrong metadata. Before https://github.com/user-attachments/assets/39039d83-4d55-41a9-9d01-dec40843741b After https://github.com/user-attachments/assets/047a603b-fb52-4320-886d-dfeed457d833 ### 3. Initial full scan surfaced interior errors of a muted/bypassed subgraph container `scanAllModelCandidates`, `scanAllMediaCandidates`, and the JSON-based missing-node scan only check each node's own mode. Interior nodes whose parent container was bypassed passed the filter. Added `isAncestorPathActive(rootGraph, executionId)` to `graphTraversalUtil` and post-filter the three pipelines in `app.ts` after the live rootGraph is configured. The filter uses the execution-ID path (`"65:63"` → check node 65's mode) so it handles both live-scan-produced and JSON-enrichment-produced candidates. Before https://github.com/user-attachments/assets/3032d46b-81cd-420e-ab8e-f58392267602 After https://github.com/user-attachments/assets/02a01931-951d-4a48-986c-06424044fbf8 ### 4. Bypassed subgraph entry re-surfaced interior errors `useGraphNodeManager` replays `graph.onNodeAdded` for each existing interior node when the Vue node manager initializes on subgraph entry. That chain reached `scanSingleNodeErrors` via `installErrorClearingHooks`' `onNodeAdded` override. Each interior node's own mode was active, so the caller guards passed and the scan re-introduced the error that the initial pipeline had correctly suppressed. Added an ancestor-activity gate at the top of `scanSingleNodeErrors`, the single entry point shared by paste, un-bypass, subgraph entry, and subgraph container activation. A later commit also hardens this guard against detached nodes (null execution ID → skip) and applies the same ancestor check to `isCandidateStillActive` in the realtime verification callback. Before https://github.com/user-attachments/assets/fe44862d-f1d6-41ed-982d-614a7e83d441 After https://github.com/user-attachments/assets/497a76ce-3caa-479f-9024-4cd0f7bd20a4 ## Tests - 6 unit tests for `isAncestorPathActive` (root, active, immediate-bypass, deep-nested mute, unresolvable ancestor, null rootGraph) - 4 unit tests for `enrichCandidateFromNodeProperties` (enrichment, no-overwrite, name mismatch, directory mismatch) - 1 unit test for `scanSingleNodeErrors` ancestor guard (subgraph entry replaying onNodeAdded) - 2 unit tests for `useErrorGroups` dual export + ErrorOverlay contract - 4 E2E tests: - ErrorOverlay model count stays constant when a node is selected (new fixture `missing_models_distinct.json`) - Bypass/un-bypass cycle preserves Copy URL button (uses `missing_models_from_node_properties`) - Loading a workflow with bypassed subgraph suppresses interior missing model error (new fixture `missing_models_in_bypassed_subgraph.json`) - Entering a bypassed subgraph does not resurface interior missing model error (shares the above fixture) `pnpm typecheck`, `pnpm lint`, 206 related unit tests passing. ## Follow-up Several items raised by code review are deferred as pre-existing tech debt or scope-avoided refactors. Tracked via comments on #11215 and #11216. --- Follows up on #10856.
…10856 (#11466) Backport of #11233 to `core/1.43` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11466-backport-core-1-43-fix-missing-asset-correctness-follow-ups-from-10856-3486d73d365081bd94f4e9b8822a8320) by [Unito](https://www.unito.io) Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
…10856 (#11467) Backport of #11233 to `cloud/1.43` Automatically created by backport workflow. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11467-backport-cloud-1-43-fix-missing-asset-correctness-follow-ups-from-10856-3486d73d3650811985a7ffef55c0810d) by [Unito](https://www.unito.io) Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
## Summary Muted and bypassed nodes are excluded from execution but were still triggering missing model/media/node warnings. This PR makes the error system mode-aware: muted/bypassed nodes no longer produce missing asset errors, and all error lifecycle events (mode toggle, deletion, paste, undo, tab switch) are handled consistently. - Fixes Comfy-Org/ComfyUI#13256 ## Behavioral notes - **Tab switch overlay suppression (intentional)**: Switching back to a workflow with missing assets no longer re-shows the error overlay. This reverses the behavior introduced in #10190. The error state is still restored silently in the errors tab — users can access it via the properties panel without being interrupted by the overlay on every tab switch. ## Changes ### 1. Scan filtering - `scanAllModelCandidates`, `scanAllMediaCandidates`, `scanMissingNodes`: skip nodes with `mode === NEVER || BYPASS` - `collectMissingNodes` (serialized data): skip error reporting for muted/bypassed nodes while still calling `sanitizeNodeName` for safe `configure()` - `collectEmbeddedModelsWithSource`: skip muted/bypassed nodes; workflow-level `graphData.models` only create candidates when active nodes exist - `enrichWithEmbeddedMetadata`: filter unmatched workflow-level models when all referencing nodes are inactive ### 2. Realtime mode change handling - `useErrorClearingHooks.ts` chains `graph.onTrigger` to detect `node:property:changed` (mode) - Deactivation (active → muted/bypassed): remove missing model/media/node errors for the node - Activation (muted/bypassed → active): scan the node and add confirmed errors, show overlay - Subgraph container deactivation: remove all interior node errors (execution ID prefix match) - Subgraph container activation: scan all active interior nodes recursively - Subgraph interior mode change: resolve node via `localGraph.getNodeById()` then compute execution ID from root graph ### 3. Node deletion - `graph.onNodeRemoved`: remove missing model/media/node errors for the deleted node - Handle `node.graph === null` at callback time by using `String(node.id)` for root-level nodes ### 4. Node paste/duplicate - `graph.onNodeAdded`: scan via `queueMicrotask` (deferred until after `node.configure()` restores widget values) - Guard: skip during `ChangeTracker.isLoadingGraph` (undo/redo/tab switch handled by pipeline) - Guard: skip muted/bypassed nodes ### 5. Workflow tab switch optimization - `skipAssetScans` option in `loadGraphData`: skip full pipeline on tab switch - Cache missing model/media/node state per workflow via `PendingWarnings` - `beforeLoadNewGraph`: save current store state to outgoing workflow's `pendingWarnings` - `showPendingWarnings`: restore cached errors silently (no overlay), always sync missing nodes store (even when null) - Preserve UI state (`fileSizes`, `urlInputs`) on tab switch by using `setMissingModels([])` instead of `clearMissingModels()` - `MissingModelRow.vue`: fetch file size on mount via `fetchModelMetadata` memory cache ### 6. Undo/redo overlay suppression - `silentAssetErrors` option propagated through pipeline → `surfaceMissingModels`/`surfaceMissingMedia` `{ silent }` option - `showPendingWarnings` `{ silent }` option for missing nodes overlay - `changeTracker.ts`: pass `silentAssetErrors: true` on undo/redo ### 7. Error tab node filtering - Selected node filters missing model/media card contents (not just group visibility) - `isAssetErrorInSelection`: resolve execution ID → graph node for selection matching - Missing nodes intentionally unfiltered (pack-level scope) - `hasMissingMediaSelected` added to `RightSidePanel.vue` error tab visibility - Download All button: show only when 2+ downloadable models exist ### 8. New store functions - `missingModelStore`: `addMissingModels`, `removeMissingModelsByNodeId` - `missingMediaStore`: `addMissingMedia`, `removeMissingMediaByNodeId` - `missingNodesErrorStore`: `removeMissingNodesByNodeId` - `missingModelScan`: `scanNodeModelCandidates` (extracted single-node scan) - `missingMediaScan`: `scanNodeMediaCandidates` (extracted single-node scan) ### 9. Test infrastructure improvements - `data-testid` on `RightSidePanel.vue` tabs (`panel-tab-{value}`) - Error-related TestIds moved from `dialogs` to `errorsTab` namespace in `selectors.ts` - Removed unused `TestIdValue` type - Extracted `cleanupFakeModel` to shared `ErrorsTabHelper.ts` - Renamed `openErrorsTabViaSeeErrors` → `loadWorkflowAndOpenErrorsTab` - Added `aria-label` to pencil edit button and subgraph toggle button ## Test plan ### Unit tests (41 new) - Store functions: `addMissing*`, `removeMissing*ByNodeId` - `executionErrorStore`: `surfaceMissing*` silent option - Scan functions: muted/bypassed filtering, `scanNodeModelCandidates`, `scanNodeMediaCandidates` - `workflowService`: `showPendingWarnings` silent, `beforeLoadNewGraph` caching ### E2E tests (17 new in `errorsTabModeAware.spec.ts`) **Missing nodes** - [x] Deleting a missing node removes its error from the errors tab - [x] Undo after bypass restores error without showing overlay **Missing models** - [x] Loading a workflow with all nodes bypassed shows no errors - [x] Bypassing a node hides its error, un-bypassing restores it - [x] Deleting a node with missing model removes its error - [x] Undo after bypass restores error without showing overlay - [x] Pasting a node with missing model increases referencing node count - [x] Pasting a bypassed node does not add a new error - [x] Selecting a node filters errors tab to only that node **Missing media** - [x] Loading a workflow with all nodes bypassed shows no errors - [x] Bypassing a node hides its error, un-bypassing restores it - [x] Pasting a bypassed node does not add a new error - [x] Selecting a node filters errors tab to only that node **Subgraph** - [x] Bypassing a subgraph hides interior errors, un-bypassing restores them - [x] Bypassing a node inside a subgraph hides its error, un-bypassing restores it **Workflow switching** - [x] Does not resurface error overlay when switching back to workflow with missing nodes - [x] Restores missing nodes in errors tab when switching back to workflow # Screenshots https://github.com/user-attachments/assets/e0a5bcb8-69ba-4120-ab7f-5c83e4cfc3c5 ## Follow-up work - Extract error-detection computed properties from `RightSidePanel.vue` into a composable (e.g. `useErrorsTabVisibility`) --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: GitHub Action <action@github.com>
Follow-up to #10856. Four correctness issues and their regression tests. ## Bugs fixed ### 1. ErrorOverlay model count reflected node selection `useErrorGroups` exposed `filteredMissingModelGroups` under the public name `missingModelGroups`. `ErrorOverlay.vue` read that alias to compute its model count label, so selecting a node shrank the overlay total. The overlay must always show the whole workflow's errors. Exposed both shapes explicitly: `missingModelGroups` / `missingMediaGroups` (unfiltered totals) and `filteredMissingModelGroups` / `filteredMissingMediaGroups` (selection-scoped). `TabErrors.vue` destructures the filtered variant with an alias. Before https://github.com/user-attachments/assets/eb848c5f-d092-4a4f-b86f-d22bb4408003 After https://github.com/user-attachments/assets/75e67819-c9f2-45ec-9241-74023eca6120 ### 2. Bypass → un-bypass dropped url/hash metadata Realtime `scanNodeModelCandidates` only reads widget values, so un-bypass produced a fresh candidate without the url that `enrichWithEmbeddedMetadata` had previously attached from `graphData.models`. `MissingModelRow`'s download/copy-url buttons disappeared after a bypass/un-bypass cycle. Added `enrichCandidateFromNodeProperties` that copies `url`/`hash`/`directory` from the node's own `properties.models` — which persists across mode toggles — into each scanned candidate. Applied to every call site of the per-node scan. A later fix in the same branch also enforces directory agreement to prevent a same-name / different-directory collision from stamping the wrong metadata. Before https://github.com/user-attachments/assets/39039d83-4d55-41a9-9d01-dec40843741b After https://github.com/user-attachments/assets/047a603b-fb52-4320-886d-dfeed457d833 ### 3. Initial full scan surfaced interior errors of a muted/bypassed subgraph container `scanAllModelCandidates`, `scanAllMediaCandidates`, and the JSON-based missing-node scan only check each node's own mode. Interior nodes whose parent container was bypassed passed the filter. Added `isAncestorPathActive(rootGraph, executionId)` to `graphTraversalUtil` and post-filter the three pipelines in `app.ts` after the live rootGraph is configured. The filter uses the execution-ID path (`"65:63"` → check node 65's mode) so it handles both live-scan-produced and JSON-enrichment-produced candidates. Before https://github.com/user-attachments/assets/3032d46b-81cd-420e-ab8e-f58392267602 After https://github.com/user-attachments/assets/02a01931-951d-4a48-986c-06424044fbf8 ### 4. Bypassed subgraph entry re-surfaced interior errors `useGraphNodeManager` replays `graph.onNodeAdded` for each existing interior node when the Vue node manager initializes on subgraph entry. That chain reached `scanSingleNodeErrors` via `installErrorClearingHooks`' `onNodeAdded` override. Each interior node's own mode was active, so the caller guards passed and the scan re-introduced the error that the initial pipeline had correctly suppressed. Added an ancestor-activity gate at the top of `scanSingleNodeErrors`, the single entry point shared by paste, un-bypass, subgraph entry, and subgraph container activation. A later commit also hardens this guard against detached nodes (null execution ID → skip) and applies the same ancestor check to `isCandidateStillActive` in the realtime verification callback. Before https://github.com/user-attachments/assets/fe44862d-f1d6-41ed-982d-614a7e83d441 After https://github.com/user-attachments/assets/497a76ce-3caa-479f-9024-4cd0f7bd20a4 ## Tests - 6 unit tests for `isAncestorPathActive` (root, active, immediate-bypass, deep-nested mute, unresolvable ancestor, null rootGraph) - 4 unit tests for `enrichCandidateFromNodeProperties` (enrichment, no-overwrite, name mismatch, directory mismatch) - 1 unit test for `scanSingleNodeErrors` ancestor guard (subgraph entry replaying onNodeAdded) - 2 unit tests for `useErrorGroups` dual export + ErrorOverlay contract - 4 E2E tests: - ErrorOverlay model count stays constant when a node is selected (new fixture `missing_models_distinct.json`) - Bypass/un-bypass cycle preserves Copy URL button (uses `missing_models_from_node_properties`) - Loading a workflow with bypassed subgraph suppresses interior missing model error (new fixture `missing_models_in_bypassed_subgraph.json`) - Entering a bypassed subgraph does not resurface interior missing model error (shares the above fixture) `pnpm typecheck`, `pnpm lint`, 206 related unit tests passing. ## Follow-up Several items raised by code review are deferred as pre-existing tech debt or scope-avoided refactors. Tracked via comments on #11215 and #11216. --- Follows up on #10856.
## Summary Muted and bypassed nodes are excluded from execution but were still triggering missing model/media/node warnings. This PR makes the error system mode-aware: muted/bypassed nodes no longer produce missing asset errors, and all error lifecycle events (mode toggle, deletion, paste, undo, tab switch) are handled consistently. - Fixes Comfy-Org/ComfyUI#13256 ## Behavioral notes - **Tab switch overlay suppression (intentional)**: Switching back to a workflow with missing assets no longer re-shows the error overlay. This reverses the behavior introduced in #10190. The error state is still restored silently in the errors tab — users can access it via the properties panel without being interrupted by the overlay on every tab switch. ## Changes ### 1. Scan filtering - `scanAllModelCandidates`, `scanAllMediaCandidates`, `scanMissingNodes`: skip nodes with `mode === NEVER || BYPASS` - `collectMissingNodes` (serialized data): skip error reporting for muted/bypassed nodes while still calling `sanitizeNodeName` for safe `configure()` - `collectEmbeddedModelsWithSource`: skip muted/bypassed nodes; workflow-level `graphData.models` only create candidates when active nodes exist - `enrichWithEmbeddedMetadata`: filter unmatched workflow-level models when all referencing nodes are inactive ### 2. Realtime mode change handling - `useErrorClearingHooks.ts` chains `graph.onTrigger` to detect `node:property:changed` (mode) - Deactivation (active → muted/bypassed): remove missing model/media/node errors for the node - Activation (muted/bypassed → active): scan the node and add confirmed errors, show overlay - Subgraph container deactivation: remove all interior node errors (execution ID prefix match) - Subgraph container activation: scan all active interior nodes recursively - Subgraph interior mode change: resolve node via `localGraph.getNodeById()` then compute execution ID from root graph ### 3. Node deletion - `graph.onNodeRemoved`: remove missing model/media/node errors for the deleted node - Handle `node.graph === null` at callback time by using `String(node.id)` for root-level nodes ### 4. Node paste/duplicate - `graph.onNodeAdded`: scan via `queueMicrotask` (deferred until after `node.configure()` restores widget values) - Guard: skip during `ChangeTracker.isLoadingGraph` (undo/redo/tab switch handled by pipeline) - Guard: skip muted/bypassed nodes ### 5. Workflow tab switch optimization - `skipAssetScans` option in `loadGraphData`: skip full pipeline on tab switch - Cache missing model/media/node state per workflow via `PendingWarnings` - `beforeLoadNewGraph`: save current store state to outgoing workflow's `pendingWarnings` - `showPendingWarnings`: restore cached errors silently (no overlay), always sync missing nodes store (even when null) - Preserve UI state (`fileSizes`, `urlInputs`) on tab switch by using `setMissingModels([])` instead of `clearMissingModels()` - `MissingModelRow.vue`: fetch file size on mount via `fetchModelMetadata` memory cache ### 6. Undo/redo overlay suppression - `silentAssetErrors` option propagated through pipeline → `surfaceMissingModels`/`surfaceMissingMedia` `{ silent }` option - `showPendingWarnings` `{ silent }` option for missing nodes overlay - `changeTracker.ts`: pass `silentAssetErrors: true` on undo/redo ### 7. Error tab node filtering - Selected node filters missing model/media card contents (not just group visibility) - `isAssetErrorInSelection`: resolve execution ID → graph node for selection matching - Missing nodes intentionally unfiltered (pack-level scope) - `hasMissingMediaSelected` added to `RightSidePanel.vue` error tab visibility - Download All button: show only when 2+ downloadable models exist ### 8. New store functions - `missingModelStore`: `addMissingModels`, `removeMissingModelsByNodeId` - `missingMediaStore`: `addMissingMedia`, `removeMissingMediaByNodeId` - `missingNodesErrorStore`: `removeMissingNodesByNodeId` - `missingModelScan`: `scanNodeModelCandidates` (extracted single-node scan) - `missingMediaScan`: `scanNodeMediaCandidates` (extracted single-node scan) ### 9. Test infrastructure improvements - `data-testid` on `RightSidePanel.vue` tabs (`panel-tab-{value}`) - Error-related TestIds moved from `dialogs` to `errorsTab` namespace in `selectors.ts` - Removed unused `TestIdValue` type - Extracted `cleanupFakeModel` to shared `ErrorsTabHelper.ts` - Renamed `openErrorsTabViaSeeErrors` → `loadWorkflowAndOpenErrorsTab` - Added `aria-label` to pencil edit button and subgraph toggle button ## Test plan ### Unit tests (41 new) - Store functions: `addMissing*`, `removeMissing*ByNodeId` - `executionErrorStore`: `surfaceMissing*` silent option - Scan functions: muted/bypassed filtering, `scanNodeModelCandidates`, `scanNodeMediaCandidates` - `workflowService`: `showPendingWarnings` silent, `beforeLoadNewGraph` caching ### E2E tests (17 new in `errorsTabModeAware.spec.ts`) **Missing nodes** - [x] Deleting a missing node removes its error from the errors tab - [x] Undo after bypass restores error without showing overlay **Missing models** - [x] Loading a workflow with all nodes bypassed shows no errors - [x] Bypassing a node hides its error, un-bypassing restores it - [x] Deleting a node with missing model removes its error - [x] Undo after bypass restores error without showing overlay - [x] Pasting a node with missing model increases referencing node count - [x] Pasting a bypassed node does not add a new error - [x] Selecting a node filters errors tab to only that node **Missing media** - [x] Loading a workflow with all nodes bypassed shows no errors - [x] Bypassing a node hides its error, un-bypassing restores it - [x] Pasting a bypassed node does not add a new error - [x] Selecting a node filters errors tab to only that node **Subgraph** - [x] Bypassing a subgraph hides interior errors, un-bypassing restores them - [x] Bypassing a node inside a subgraph hides its error, un-bypassing restores it **Workflow switching** - [x] Does not resurface error overlay when switching back to workflow with missing nodes - [x] Restores missing nodes in errors tab when switching back to workflow # Screenshots https://github.com/user-attachments/assets/e0a5bcb8-69ba-4120-ab7f-5c83e4cfc3c5 ## Follow-up work - Extract error-detection computed properties from `RightSidePanel.vue` into a composable (e.g. `useErrorsTabVisibility`) --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: GitHub Action <action@github.com>
Follow-up to #10856. Four correctness issues and their regression tests. ## Bugs fixed ### 1. ErrorOverlay model count reflected node selection `useErrorGroups` exposed `filteredMissingModelGroups` under the public name `missingModelGroups`. `ErrorOverlay.vue` read that alias to compute its model count label, so selecting a node shrank the overlay total. The overlay must always show the whole workflow's errors. Exposed both shapes explicitly: `missingModelGroups` / `missingMediaGroups` (unfiltered totals) and `filteredMissingModelGroups` / `filteredMissingMediaGroups` (selection-scoped). `TabErrors.vue` destructures the filtered variant with an alias. Before https://github.com/user-attachments/assets/eb848c5f-d092-4a4f-b86f-d22bb4408003 After https://github.com/user-attachments/assets/75e67819-c9f2-45ec-9241-74023eca6120 ### 2. Bypass → un-bypass dropped url/hash metadata Realtime `scanNodeModelCandidates` only reads widget values, so un-bypass produced a fresh candidate without the url that `enrichWithEmbeddedMetadata` had previously attached from `graphData.models`. `MissingModelRow`'s download/copy-url buttons disappeared after a bypass/un-bypass cycle. Added `enrichCandidateFromNodeProperties` that copies `url`/`hash`/`directory` from the node's own `properties.models` — which persists across mode toggles — into each scanned candidate. Applied to every call site of the per-node scan. A later fix in the same branch also enforces directory agreement to prevent a same-name / different-directory collision from stamping the wrong metadata. Before https://github.com/user-attachments/assets/39039d83-4d55-41a9-9d01-dec40843741b After https://github.com/user-attachments/assets/047a603b-fb52-4320-886d-dfeed457d833 ### 3. Initial full scan surfaced interior errors of a muted/bypassed subgraph container `scanAllModelCandidates`, `scanAllMediaCandidates`, and the JSON-based missing-node scan only check each node's own mode. Interior nodes whose parent container was bypassed passed the filter. Added `isAncestorPathActive(rootGraph, executionId)` to `graphTraversalUtil` and post-filter the three pipelines in `app.ts` after the live rootGraph is configured. The filter uses the execution-ID path (`"65:63"` → check node 65's mode) so it handles both live-scan-produced and JSON-enrichment-produced candidates. Before https://github.com/user-attachments/assets/3032d46b-81cd-420e-ab8e-f58392267602 After https://github.com/user-attachments/assets/02a01931-951d-4a48-986c-06424044fbf8 ### 4. Bypassed subgraph entry re-surfaced interior errors `useGraphNodeManager` replays `graph.onNodeAdded` for each existing interior node when the Vue node manager initializes on subgraph entry. That chain reached `scanSingleNodeErrors` via `installErrorClearingHooks`' `onNodeAdded` override. Each interior node's own mode was active, so the caller guards passed and the scan re-introduced the error that the initial pipeline had correctly suppressed. Added an ancestor-activity gate at the top of `scanSingleNodeErrors`, the single entry point shared by paste, un-bypass, subgraph entry, and subgraph container activation. A later commit also hardens this guard against detached nodes (null execution ID → skip) and applies the same ancestor check to `isCandidateStillActive` in the realtime verification callback. Before https://github.com/user-attachments/assets/fe44862d-f1d6-41ed-982d-614a7e83d441 After https://github.com/user-attachments/assets/497a76ce-3caa-479f-9024-4cd0f7bd20a4 ## Tests - 6 unit tests for `isAncestorPathActive` (root, active, immediate-bypass, deep-nested mute, unresolvable ancestor, null rootGraph) - 4 unit tests for `enrichCandidateFromNodeProperties` (enrichment, no-overwrite, name mismatch, directory mismatch) - 1 unit test for `scanSingleNodeErrors` ancestor guard (subgraph entry replaying onNodeAdded) - 2 unit tests for `useErrorGroups` dual export + ErrorOverlay contract - 4 E2E tests: - ErrorOverlay model count stays constant when a node is selected (new fixture `missing_models_distinct.json`) - Bypass/un-bypass cycle preserves Copy URL button (uses `missing_models_from_node_properties`) - Loading a workflow with bypassed subgraph suppresses interior missing model error (new fixture `missing_models_in_bypassed_subgraph.json`) - Entering a bypassed subgraph does not resurface interior missing model error (shares the above fixture) `pnpm typecheck`, `pnpm lint`, 206 related unit tests passing. ## Follow-up Several items raised by code review are deferred as pre-existing tech debt or scope-avoided refactors. Tracked via comments on #11215 and #11216. --- Follows up on #10856.
|
|
|
|
## Summary Muted and bypassed nodes are excluded from execution but were still triggering missing model/media/node warnings. This PR makes the error system mode-aware: muted/bypassed nodes no longer produce missing asset errors, and all error lifecycle events (mode toggle, deletion, paste, undo, tab switch) are handled consistently. - Fixes Comfy-Org/ComfyUI#13256 ## Behavioral notes - **Tab switch overlay suppression (intentional)**: Switching back to a workflow with missing assets no longer re-shows the error overlay. This reverses the behavior introduced in #10190. The error state is still restored silently in the errors tab — users can access it via the properties panel without being interrupted by the overlay on every tab switch. ## Changes ### 1. Scan filtering - `scanAllModelCandidates`, `scanAllMediaCandidates`, `scanMissingNodes`: skip nodes with `mode === NEVER || BYPASS` - `collectMissingNodes` (serialized data): skip error reporting for muted/bypassed nodes while still calling `sanitizeNodeName` for safe `configure()` - `collectEmbeddedModelsWithSource`: skip muted/bypassed nodes; workflow-level `graphData.models` only create candidates when active nodes exist - `enrichWithEmbeddedMetadata`: filter unmatched workflow-level models when all referencing nodes are inactive ### 2. Realtime mode change handling - `useErrorClearingHooks.ts` chains `graph.onTrigger` to detect `node:property:changed` (mode) - Deactivation (active → muted/bypassed): remove missing model/media/node errors for the node - Activation (muted/bypassed → active): scan the node and add confirmed errors, show overlay - Subgraph container deactivation: remove all interior node errors (execution ID prefix match) - Subgraph container activation: scan all active interior nodes recursively - Subgraph interior mode change: resolve node via `localGraph.getNodeById()` then compute execution ID from root graph ### 3. Node deletion - `graph.onNodeRemoved`: remove missing model/media/node errors for the deleted node - Handle `node.graph === null` at callback time by using `String(node.id)` for root-level nodes ### 4. Node paste/duplicate - `graph.onNodeAdded`: scan via `queueMicrotask` (deferred until after `node.configure()` restores widget values) - Guard: skip during `ChangeTracker.isLoadingGraph` (undo/redo/tab switch handled by pipeline) - Guard: skip muted/bypassed nodes ### 5. Workflow tab switch optimization - `skipAssetScans` option in `loadGraphData`: skip full pipeline on tab switch - Cache missing model/media/node state per workflow via `PendingWarnings` - `beforeLoadNewGraph`: save current store state to outgoing workflow's `pendingWarnings` - `showPendingWarnings`: restore cached errors silently (no overlay), always sync missing nodes store (even when null) - Preserve UI state (`fileSizes`, `urlInputs`) on tab switch by using `setMissingModels([])` instead of `clearMissingModels()` - `MissingModelRow.vue`: fetch file size on mount via `fetchModelMetadata` memory cache ### 6. Undo/redo overlay suppression - `silentAssetErrors` option propagated through pipeline → `surfaceMissingModels`/`surfaceMissingMedia` `{ silent }` option - `showPendingWarnings` `{ silent }` option for missing nodes overlay - `changeTracker.ts`: pass `silentAssetErrors: true` on undo/redo ### 7. Error tab node filtering - Selected node filters missing model/media card contents (not just group visibility) - `isAssetErrorInSelection`: resolve execution ID → graph node for selection matching - Missing nodes intentionally unfiltered (pack-level scope) - `hasMissingMediaSelected` added to `RightSidePanel.vue` error tab visibility - Download All button: show only when 2+ downloadable models exist ### 8. New store functions - `missingModelStore`: `addMissingModels`, `removeMissingModelsByNodeId` - `missingMediaStore`: `addMissingMedia`, `removeMissingMediaByNodeId` - `missingNodesErrorStore`: `removeMissingNodesByNodeId` - `missingModelScan`: `scanNodeModelCandidates` (extracted single-node scan) - `missingMediaScan`: `scanNodeMediaCandidates` (extracted single-node scan) ### 9. Test infrastructure improvements - `data-testid` on `RightSidePanel.vue` tabs (`panel-tab-{value}`) - Error-related TestIds moved from `dialogs` to `errorsTab` namespace in `selectors.ts` - Removed unused `TestIdValue` type - Extracted `cleanupFakeModel` to shared `ErrorsTabHelper.ts` - Renamed `openErrorsTabViaSeeErrors` → `loadWorkflowAndOpenErrorsTab` - Added `aria-label` to pencil edit button and subgraph toggle button ## Test plan ### Unit tests (41 new) - Store functions: `addMissing*`, `removeMissing*ByNodeId` - `executionErrorStore`: `surfaceMissing*` silent option - Scan functions: muted/bypassed filtering, `scanNodeModelCandidates`, `scanNodeMediaCandidates` - `workflowService`: `showPendingWarnings` silent, `beforeLoadNewGraph` caching ### E2E tests (17 new in `errorsTabModeAware.spec.ts`) **Missing nodes** - [x] Deleting a missing node removes its error from the errors tab - [x] Undo after bypass restores error without showing overlay **Missing models** - [x] Loading a workflow with all nodes bypassed shows no errors - [x] Bypassing a node hides its error, un-bypassing restores it - [x] Deleting a node with missing model removes its error - [x] Undo after bypass restores error without showing overlay - [x] Pasting a node with missing model increases referencing node count - [x] Pasting a bypassed node does not add a new error - [x] Selecting a node filters errors tab to only that node **Missing media** - [x] Loading a workflow with all nodes bypassed shows no errors - [x] Bypassing a node hides its error, un-bypassing restores it - [x] Pasting a bypassed node does not add a new error - [x] Selecting a node filters errors tab to only that node **Subgraph** - [x] Bypassing a subgraph hides interior errors, un-bypassing restores them - [x] Bypassing a node inside a subgraph hides its error, un-bypassing restores it **Workflow switching** - [x] Does not resurface error overlay when switching back to workflow with missing nodes - [x] Restores missing nodes in errors tab when switching back to workflow # Screenshots https://github.com/user-attachments/assets/e0a5bcb8-69ba-4120-ab7f-5c83e4cfc3c5 ## Follow-up work - Extract error-detection computed properties from `RightSidePanel.vue` into a composable (e.g. `useErrorsTabVisibility`) --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: GitHub Action <action@github.com>
Follow-up to #10856. Four correctness issues and their regression tests. ## Bugs fixed ### 1. ErrorOverlay model count reflected node selection `useErrorGroups` exposed `filteredMissingModelGroups` under the public name `missingModelGroups`. `ErrorOverlay.vue` read that alias to compute its model count label, so selecting a node shrank the overlay total. The overlay must always show the whole workflow's errors. Exposed both shapes explicitly: `missingModelGroups` / `missingMediaGroups` (unfiltered totals) and `filteredMissingModelGroups` / `filteredMissingMediaGroups` (selection-scoped). `TabErrors.vue` destructures the filtered variant with an alias. Before https://github.com/user-attachments/assets/eb848c5f-d092-4a4f-b86f-d22bb4408003 After https://github.com/user-attachments/assets/75e67819-c9f2-45ec-9241-74023eca6120 ### 2. Bypass → un-bypass dropped url/hash metadata Realtime `scanNodeModelCandidates` only reads widget values, so un-bypass produced a fresh candidate without the url that `enrichWithEmbeddedMetadata` had previously attached from `graphData.models`. `MissingModelRow`'s download/copy-url buttons disappeared after a bypass/un-bypass cycle. Added `enrichCandidateFromNodeProperties` that copies `url`/`hash`/`directory` from the node's own `properties.models` — which persists across mode toggles — into each scanned candidate. Applied to every call site of the per-node scan. A later fix in the same branch also enforces directory agreement to prevent a same-name / different-directory collision from stamping the wrong metadata. Before https://github.com/user-attachments/assets/39039d83-4d55-41a9-9d01-dec40843741b After https://github.com/user-attachments/assets/047a603b-fb52-4320-886d-dfeed457d833 ### 3. Initial full scan surfaced interior errors of a muted/bypassed subgraph container `scanAllModelCandidates`, `scanAllMediaCandidates`, and the JSON-based missing-node scan only check each node's own mode. Interior nodes whose parent container was bypassed passed the filter. Added `isAncestorPathActive(rootGraph, executionId)` to `graphTraversalUtil` and post-filter the three pipelines in `app.ts` after the live rootGraph is configured. The filter uses the execution-ID path (`"65:63"` → check node 65's mode) so it handles both live-scan-produced and JSON-enrichment-produced candidates. Before https://github.com/user-attachments/assets/3032d46b-81cd-420e-ab8e-f58392267602 After https://github.com/user-attachments/assets/02a01931-951d-4a48-986c-06424044fbf8 ### 4. Bypassed subgraph entry re-surfaced interior errors `useGraphNodeManager` replays `graph.onNodeAdded` for each existing interior node when the Vue node manager initializes on subgraph entry. That chain reached `scanSingleNodeErrors` via `installErrorClearingHooks`' `onNodeAdded` override. Each interior node's own mode was active, so the caller guards passed and the scan re-introduced the error that the initial pipeline had correctly suppressed. Added an ancestor-activity gate at the top of `scanSingleNodeErrors`, the single entry point shared by paste, un-bypass, subgraph entry, and subgraph container activation. A later commit also hardens this guard against detached nodes (null execution ID → skip) and applies the same ancestor check to `isCandidateStillActive` in the realtime verification callback. Before https://github.com/user-attachments/assets/fe44862d-f1d6-41ed-982d-614a7e83d441 After https://github.com/user-attachments/assets/497a76ce-3caa-479f-9024-4cd0f7bd20a4 ## Tests - 6 unit tests for `isAncestorPathActive` (root, active, immediate-bypass, deep-nested mute, unresolvable ancestor, null rootGraph) - 4 unit tests for `enrichCandidateFromNodeProperties` (enrichment, no-overwrite, name mismatch, directory mismatch) - 1 unit test for `scanSingleNodeErrors` ancestor guard (subgraph entry replaying onNodeAdded) - 2 unit tests for `useErrorGroups` dual export + ErrorOverlay contract - 4 E2E tests: - ErrorOverlay model count stays constant when a node is selected (new fixture `missing_models_distinct.json`) - Bypass/un-bypass cycle preserves Copy URL button (uses `missing_models_from_node_properties`) - Loading a workflow with bypassed subgraph suppresses interior missing model error (new fixture `missing_models_in_bypassed_subgraph.json`) - Entering a bypassed subgraph does not resurface interior missing model error (shares the above fixture) `pnpm typecheck`, `pnpm lint`, 206 related unit tests passing. ## Follow-up Several items raised by code review are deferred as pre-existing tech debt or scope-avoided refactors. Tracked via comments on #11215 and #11216. --- Follows up on #10856.
Summary
Muted and bypassed nodes are excluded from execution but were still triggering missing model/media/node warnings. This PR makes the error system mode-aware: muted/bypassed nodes no longer produce missing asset errors, and all error lifecycle events (mode toggle, deletion, paste, undo, tab switch) are handled consistently.
Behavioral notes
Changes
1. Scan filtering
scanAllModelCandidates,scanAllMediaCandidates,scanMissingNodes: skip nodes withmode === NEVER || BYPASScollectMissingNodes(serialized data): skip error reporting for muted/bypassed nodes while still callingsanitizeNodeNamefor safeconfigure()collectEmbeddedModelsWithSource: skip muted/bypassed nodes; workflow-levelgraphData.modelsonly create candidates when active nodes existenrichWithEmbeddedMetadata: filter unmatched workflow-level models when all referencing nodes are inactive2. Realtime mode change handling
useErrorClearingHooks.tschainsgraph.onTriggerto detectnode:property:changed(mode)localGraph.getNodeById()then compute execution ID from root graph3. Node deletion
graph.onNodeRemoved: remove missing model/media/node errors for the deleted nodenode.graph === nullat callback time by usingString(node.id)for root-level nodes4. Node paste/duplicate
graph.onNodeAdded: scan viaqueueMicrotask(deferred until afternode.configure()restores widget values)ChangeTracker.isLoadingGraph(undo/redo/tab switch handled by pipeline)5. Workflow tab switch optimization
skipAssetScansoption inloadGraphData: skip full pipeline on tab switchPendingWarningsbeforeLoadNewGraph: save current store state to outgoing workflow'spendingWarningsshowPendingWarnings: restore cached errors silently (no overlay), always sync missing nodes store (even when null)fileSizes,urlInputs) on tab switch by usingsetMissingModels([])instead ofclearMissingModels()MissingModelRow.vue: fetch file size on mount viafetchModelMetadatamemory cache6. Undo/redo overlay suppression
silentAssetErrorsoption propagated through pipeline →surfaceMissingModels/surfaceMissingMedia{ silent }optionshowPendingWarnings{ silent }option for missing nodes overlaychangeTracker.ts: passsilentAssetErrors: trueon undo/redo7. Error tab node filtering
isAssetErrorInSelection: resolve execution ID → graph node for selection matchinghasMissingMediaSelectedadded toRightSidePanel.vueerror tab visibility8. New store functions
missingModelStore:addMissingModels,removeMissingModelsByNodeIdmissingMediaStore:addMissingMedia,removeMissingMediaByNodeIdmissingNodesErrorStore:removeMissingNodesByNodeIdmissingModelScan:scanNodeModelCandidates(extracted single-node scan)missingMediaScan:scanNodeMediaCandidates(extracted single-node scan)9. Test infrastructure improvements
data-testidonRightSidePanel.vuetabs (panel-tab-{value})dialogstoerrorsTabnamespace inselectors.tsTestIdValuetypecleanupFakeModelto sharedErrorsTabHelper.tsopenErrorsTabViaSeeErrors→loadWorkflowAndOpenErrorsTabaria-labelto pencil edit button and subgraph toggle buttonTest plan
Unit tests (41 new)
addMissing*,removeMissing*ByNodeIdexecutionErrorStore:surfaceMissing*silent optionscanNodeModelCandidates,scanNodeMediaCandidatesworkflowService:showPendingWarningssilent,beforeLoadNewGraphcachingE2E tests (17 new in
errorsTabModeAware.spec.ts)Missing nodes
Missing models
Missing media
Subgraph
Workflow switching
Screenshots
2026-04-12.7.14.23.mov
Follow-up work
RightSidePanel.vueinto a composable (e.g.useErrorsTabVisibility)