Repository navigation
fix: remove redundant and counterproductive e2e timeout overrides - #11110
Conversation
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1026 passed, 0 failed · 3 flaky📊 Browser Reports
|
📦 Bundle: 5.13 MB gzip 🟢 -21 BDetailsSummary
Category Glance App Entry Points — 22.3 kB (baseline 22.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.2 MB (baseline 1.2 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 482 kB (baseline 482 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 109 kB (baseline 109 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 60.3 kB (baseline 60.3 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 2.98 MB (baseline 2.98 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 339 kB (baseline 339 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 14 unchanged Vendor & Third-Party — 9.8 MB (baseline 9.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.55 MB (baseline 8.55 MB) • ⚪ 0 BBundles that do not match a named category
Status: 56 added / 56 removed / 79 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-04-10T19:47:37.092Z",
"gitSha": "184c7c33c61f098e31f988b99e2a1564479f4c94",
"branch": "fix/remove-redundant-e2e-timeouts",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2000.9100000000046,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.585000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.79800000000006,
"heapDeltaBytes": 19942892,
"heapUsedBytes": 63136908,
"domNodes": 16,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 14.387000000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2070.133999999996,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.55,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.043,
"heapDeltaBytes": 20415856,
"heapUsedBytes": 62924692,
"domNodes": 22,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 28.744000000000007,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2036.5939999999227,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.534,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.842,
"heapDeltaBytes": 20312828,
"heapUsedBytes": 63141360,
"domNodes": 23,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 21.455,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1955.3530000000023,
"styleRecalcs": 78,
"styleRecalcDurationMs": 46.96,
"layouts": 12,
"layoutDurationMs": 3.8699999999999997,
"taskDurationMs": 839.5550000000001,
"heapDeltaBytes": 16197424,
"heapUsedBytes": 61011164,
"domNodes": 62,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 142.228,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.3710000000324,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.852000000000004,
"layouts": 12,
"layoutDurationMs": 3.920999999999999,
"taskDurationMs": 781.518,
"heapDeltaBytes": 15933236,
"heapUsedBytes": 58798632,
"domNodes": 59,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 141.447,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1916.7139999999563,
"styleRecalcs": 76,
"styleRecalcDurationMs": 42.89399999999999,
"layouts": 12,
"layoutDurationMs": 3.9210000000000007,
"taskDurationMs": 862.902,
"heapDeltaBytes": 7452664,
"heapUsedBytes": 59150408,
"domNodes": 60,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 141.53000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.984999999971,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.054000000000002,
"layouts": 6,
"layoutDurationMs": 0.5990000000000001,
"taskDurationMs": 325.224,
"heapDeltaBytes": 15346372,
"heapUsedBytes": 67176884,
"domNodes": 80,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 27.081999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.3869999999933,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.23,
"layouts": 6,
"layoutDurationMs": 0.6050000000000001,
"taskDurationMs": 398.54599999999994,
"heapDeltaBytes": 15113484,
"heapUsedBytes": 66918072,
"domNodes": 79,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 32.934000000000005,
"eventListeners": 23,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.424000000061,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.502000000000002,
"layouts": 6,
"layoutDurationMs": 0.7359999999999999,
"taskDurationMs": 307.89700000000005,
"heapDeltaBytes": 15697876,
"heapUsedBytes": 67136928,
"domNodes": 78,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 25.514000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 575.2099999999984,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.931,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.923,
"heapDeltaBytes": 6535268,
"heapUsedBytes": 49324876,
"domNodes": 21,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 68.61399999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 573.4530000000291,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.008999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.892,
"heapDeltaBytes": 6563736,
"heapUsedBytes": 49346588,
"domNodes": 22,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 69.82100000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 583.6940000000368,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.716000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.039,
"heapDeltaBytes": -2370660,
"heapUsedBytes": 49503128,
"domNodes": 22,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 70.37299999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2014.1820000000052,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.855,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.728,
"heapDeltaBytes": 3981772,
"heapUsedBytes": 55242804,
"domNodes": -257,
"jsHeapTotalBytes": 15659008,
"scriptDurationMs": 95.783,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.8129999999574,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.099000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.5550000000001,
"heapDeltaBytes": 5191576,
"heapUsedBytes": 55929116,
"domNodes": -259,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 125.722,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2079.114000000004,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.216999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 672.4230000000001,
"heapDeltaBytes": 4330408,
"heapUsedBytes": 52087488,
"domNodes": -253,
"jsHeapTotalBytes": 15835136,
"scriptDurationMs": 149.052,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2156.4010000000167,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.896000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1076.052,
"heapDeltaBytes": 18797280,
"heapUsedBytes": 71117224,
"domNodes": -258,
"jsHeapTotalBytes": 18485248,
"scriptDurationMs": 405.73099999999994,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2139.0989999999874,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.056999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1169.372,
"heapDeltaBytes": 15101872,
"heapUsedBytes": 68683344,
"domNodes": -265,
"jsHeapTotalBytes": 17960960,
"scriptDurationMs": 414.188,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2143.010000000004,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.081000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1157.857,
"heapDeltaBytes": 19178388,
"heapUsedBytes": 71285916,
"domNodes": -261,
"jsHeapTotalBytes": 18747392,
"scriptDurationMs": 414.017,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3166.6380000000345,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.637999999999998,
"layouts": 60,
"layoutDurationMs": 7.316,
"taskDurationMs": 1352.316,
"heapDeltaBytes": 4001712,
"heapUsedBytes": 59083608,
"domNodes": -264,
"jsHeapTotalBytes": 17231872,
"scriptDurationMs": 509.138,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3249.4760000000156,
"styleRecalcs": 66,
"styleRecalcDurationMs": 17.28,
"layouts": 60,
"layoutDurationMs": 7.617000000000001,
"taskDurationMs": 1536.381,
"heapDeltaBytes": -5716416,
"heapUsedBytes": 50679096,
"domNodes": -263,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 624.071,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3200.548000000026,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.037999999999997,
"layouts": 60,
"layoutDurationMs": 7.693,
"taskDurationMs": 1412.1629999999998,
"heapDeltaBytes": 9283896,
"heapUsedBytes": 64337076,
"domNodes": -263,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 528.2520000000001,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.911999999967,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.370000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.5369999999999,
"heapDeltaBytes": 2208524,
"heapUsedBytes": 56200908,
"domNodes": -262,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 103.53700000000002,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2031.9860000000176,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.655000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 621.969,
"heapDeltaBytes": 3047320,
"heapUsedBytes": 56891716,
"domNodes": -263,
"jsHeapTotalBytes": 15659008,
"scriptDurationMs": 112.59099999999998,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.3829999999534,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.524000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.786,
"heapDeltaBytes": 4941440,
"heapUsedBytes": 57772096,
"domNodes": -259,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 98.025,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 600.0339999999937,
"styleRecalcs": 50,
"styleRecalcDurationMs": 15.237,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.64200000000005,
"heapDeltaBytes": 7006928,
"heapUsedBytes": 49747484,
"domNodes": 25,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 130.752,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 554.5430000000238,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.886,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.865,
"heapDeltaBytes": 6362812,
"heapUsedBytes": 49557300,
"domNodes": 20,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 128.674,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.7150000000438,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.103,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.17600000000004,
"heapDeltaBytes": 6485952,
"heapUsedBytes": 49617972,
"domNodes": 20,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 124.069,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2036.598999999967,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.326999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.916,
"heapDeltaBytes": 19963308,
"heapUsedBytes": 63085764,
"domNodes": 20,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 18.792999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.8370000000145,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.467,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.66200000000003,
"heapDeltaBytes": 20355360,
"heapUsedBytes": 63147572,
"domNodes": 22,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 27.709999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1995.0959999999895,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.047,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.387,
"heapDeltaBytes": 19783428,
"heapUsedBytes": 62954336,
"domNodes": 20,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 18.534000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1684.6560000000181,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.043000000000006,
"layouts": 16,
"layoutDurationMs": 4.278,
"taskDurationMs": 640.7740000000001,
"heapDeltaBytes": 12202888,
"heapUsedBytes": 55089756,
"domNodes": 62,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 94.04599999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.3909999999682,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.712999999999994,
"layouts": 16,
"layoutDurationMs": 4.752,
"taskDurationMs": 708.819,
"heapDeltaBytes": 2469520,
"heapUsedBytes": 54594556,
"domNodes": 65,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 106.017,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1973.3939999999848,
"styleRecalcs": 84,
"styleRecalcDurationMs": 43.022999999999996,
"layouts": 16,
"layoutDurationMs": 4.025,
"taskDurationMs": 889.899,
"heapDeltaBytes": 11563780,
"heapUsedBytes": 54739972,
"domNodes": 73,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 99.24199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8200.750000000027,
"styleRecalcs": 251,
"styleRecalcDurationMs": 43.969,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3680.253,
"heapDeltaBytes": 27011084,
"heapUsedBytes": 77763500,
"domNodes": -260,
"jsHeapTotalBytes": 18485248,
"scriptDurationMs": 1267.6000000000001,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8199.978999999985,
"styleRecalcs": 251,
"styleRecalcDurationMs": 45.085,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3984.1499999999996,
"heapDeltaBytes": 575640,
"heapUsedBytes": 51478120,
"domNodes": -256,
"jsHeapTotalBytes": 18542592,
"scriptDurationMs": 1325.647,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8155.010999999945,
"styleRecalcs": 251,
"styleRecalcDurationMs": 45.127,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3826.6910000000003,
"heapDeltaBytes": 25697440,
"heapUsedBytes": 75914464,
"domNodes": -256,
"jsHeapTotalBytes": 20320256,
"scriptDurationMs": 1312.6060000000002,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12327.985999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12313.1,
"heapDeltaBytes": -31168984,
"heapUsedBytes": 165665508,
"domNodes": -8331,
"jsHeapTotalBytes": 27615232,
"scriptDurationMs": 608.081,
"eventListeners": -16468,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12545.961000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12531.327000000001,
"heapDeltaBytes": -39450240,
"heapUsedBytes": 158275796,
"domNodes": -8330,
"jsHeapTotalBytes": 17391616,
"scriptDurationMs": 619.121,
"eventListeners": -16466,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12133.142000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12121.554000000002,
"heapDeltaBytes": -40485004,
"heapUsedBytes": 166874140,
"domNodes": -8331,
"jsHeapTotalBytes": 28925952,
"scriptDurationMs": 596.089,
"eventListeners": -16468,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14699.468000000024,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.839999999999964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14665.646999999999,
"heapDeltaBytes": -44428232,
"heapUsedBytes": 149397520,
"domNodes": -8331,
"jsHeapTotalBytes": -5939200,
"scriptDurationMs": 920.2900000000001,
"eventListeners": -16486,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14764.854000000014,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.807000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14742.587,
"heapDeltaBytes": -50780808,
"heapUsedBytes": 159715948,
"domNodes": -8333,
"jsHeapTotalBytes": -3317760,
"scriptDurationMs": 909.471,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14803.333000000066,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.403,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14774.950999999997,
"heapDeltaBytes": -34176788,
"heapUsedBytes": 172415820,
"domNodes": -8331,
"jsHeapTotalBytes": 24907776,
"scriptDurationMs": 910.2179999999998,
"eventListeners": -16458,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 456.28499999997985,
"styleRecalcs": 19,
"styleRecalcDurationMs": 27.110999999999997,
"layouts": 6,
"layoutDurationMs": 1.9220000000000002,
"taskDurationMs": 137.04,
"heapDeltaBytes": 4802068,
"heapUsedBytes": 49087124,
"domNodes": 167,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.93500000000001,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 450.4660000000058,
"styleRecalcs": 16,
"styleRecalcDurationMs": 21.586000000000002,
"layouts": 5,
"layoutDurationMs": 1.3219999999999998,
"taskDurationMs": 117.98899999999999,
"heapDeltaBytes": 4502132,
"heapUsedBytes": 48917980,
"domNodes": 156,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 28.418999999999997,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 446.3980000000447,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.587000000000003,
"layouts": 5,
"layoutDurationMs": 1.418,
"taskDurationMs": 121.346,
"heapDeltaBytes": 4472908,
"heapUsedBytes": 48858428,
"domNodes": 158,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 26.704,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
- Remove ~120 redundant timeout overrides from auto-retrying assertions (toBeVisible, toBeHidden, toHaveCount, toBeEnabled, toHaveAttribute, toContainText, expect.poll) where 5000ms is already the Playwright default - Remove sub-5s timeouts (1s, 2s, 3s) from assertions that were needlessly tighter than the default, encouraging flaky failures - Raise absurdly short timeouts in customMatchers.ts (250ms toPass -> 5000ms, 256ms poll default -> removed to use 5000ms default) - Preserve timeouts on .toPass() (defaults to 0), .waitFor(), .waitForRequest(), waitForFunction(), intentionally-short assertion timeouts inside retry loops, and conditional .isVisible()/.catch() checks Amp-Thread-ID: https://ampcode.com/threads/T-019d7558-e8be-7099-b026-367fa10d97ca Co-authored-by: Amp <amp@ampcode.com>
c124a1e to
117c473
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR removes many explicit per-assertion timeouts and simplifies Playwright polling call signatures across the browser_tests suite; it also increases a custom matcher retry default and adjusts one matcher parameter and a few helper waits. No exported/public API signatures were changed. (39 words) Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #11110 +/- ##
=======================================
Coverage 43.28% 43.28%
=======================================
Files 1342 1342
Lines 68431 68431
Branches 18051 18051
=======================================
Hits 29618 29618
Misses 38223 38223
Partials 590 590 🚀 New features to boost your workflow:
|
…d cloud-asset-default Amp-Thread-ID: https://ampcode.com/threads/T-019d7686-b4d9-700e-b24d-9e1b716dca1a Co-authored-by: Amp <amp@ampcode.com>
The collapse() method toggles flags.collapsed, which is unreliable when DOM widget overlays interfere. Set flags.collapsed = false directly to deterministically expand the node. Amp-Thread-ID: https://ampcode.com/threads/T-019d78aa-fa43-711e-98b1-4a438120851d Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
browser_tests/tests/interaction.spec.ts (1)
328-364: Test name now overstates interaction coverage.After this change, reopen is no longer a user interaction (it’s a direct
page.evaluatestate mutation), so the test doesn’t fully validate “toggle … open/closed” behavior end-to-end. Please either rename this test to reflect the workaround, or split it and keep a follow-up interaction test tied to#11006once click-to-expand is stable.As per coding guidelines: "Use Playwright best practices and do not use waitForTimeout; use Locator actions and retrying assertions instead."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/interaction.spec.ts` around lines 328 - 364, The test named 'Can toggle dom widget node open/closed' no longer performs a full user interaction to re-open the node because the reopen step uses comfyPage.page.evaluate to set node.flags.collapsed = false; either rename the test to reflect that it only verifies collapse via click-and-programmatic-reopen (e.g., 'Can collapse via toggler and be reopened programmatically') or split into two tests: one that clicks the toggler and asserts collapsed state (keep the existing click and expect.poll on targetNode.isCollapsed()), and a separate follow-up interaction test (tied to `#11006`) that will later verify click-to-expand behavior when fixed; update any test title string used in the test declaration and ensure all references (DefaultGraphPositions.textEncodeNodeToggler, comfyPage.canvas.click, targetNode.isCollapsed, and the page.evaluate block that mutates node.flags.collapsed) reflect the new split/rename, keeping Playwright best practices (use locator actions and retrying assertions) and avoiding waitForTimeout.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@browser_tests/tests/interaction.spec.ts`:
- Around line 328-364: The test named 'Can toggle dom widget node open/closed'
no longer performs a full user interaction to re-open the node because the
reopen step uses comfyPage.page.evaluate to set node.flags.collapsed = false;
either rename the test to reflect that it only verifies collapse via
click-and-programmatic-reopen (e.g., 'Can collapse via toggler and be reopened
programmatically') or split into two tests: one that clicks the toggler and
asserts collapsed state (keep the existing click and expect.poll on
targetNode.isCollapsed()), and a separate follow-up interaction test (tied to
`#11006`) that will later verify click-to-expand behavior when fixed; update any
test title string used in the test declaration and ensure all references
(DefaultGraphPositions.textEncodeNodeToggler, comfyPage.canvas.click,
targetNode.isCollapsed, and the page.evaluate block that mutates
node.flags.collapsed) reflect the new split/rename, keeping Playwright best
practices (use locator actions and retrying assertions) and avoiding
waitForTimeout.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d0bf2449-3ea9-4dcd-9c54-761ea27ce5a4
📒 Files selected for processing (1)
browser_tests/tests/interaction.spec.ts
Two rapid clicks at the same canvas position within 300ms are treated as a double-click by CanvasPointer, firing onDoubleClick instead of onClick (which toggles collapse). Poll until the double-click window has expired before the second click. Amp-Thread-ID: https://ampcode.com/threads/T-019d78aa-fa43-711e-98b1-4a438120851d Co-authored-by: Amp <amp@ampcode.com>
3d71c83
artokun
left a comment
There was a problem hiding this comment.
Man, this is a good one. Net -115 lines, 38 files touched, and not a single new feature in sight. That's the kind of restraint that ages well.
The real win here is customMatchers.ts. The 250ms toPass and 256ms toHaveFocus defaults — those weren't timeouts, those were traps. A 250ms window to assert node state on a CI machine that might be breathing heavy is just setting yourself up to blame 'flakiness' for what is actually a poorly-aimed gun. Bumping to 5000ms and the framework default respectively is the correct call.
The mass { timeout: 5000 } removal on auto-retrying assertions — yeah, that's just noise. Playwright's expect.timeout config already sets the default. Writing it out explicitly everywhere doesn't make the tests more robust, it just makes future readers wonder if you knew something they don't. Clean it up.
One thing worth double-checking: Topbar.ts:107 — you removed timeout: 500 from a .waitFor({ state: 'hidden' }). Your review notes say you kept the .waitFor() timeouts, but 500ms was genuinely too tight for a dialog close animation, so removing it (falling back to the default) is probably better behavior. Small inconsistency with what you described, but the change itself is correct. Just make sure that's intentional.
remove.spec.ts — "Node count should remain the same" was polling with timeout: 1000. That's a stability assertion — you're checking nothing changed. poll hits on the first successful check so 1s vs 5s doesn't really matter here (it passes immediately if count matches), but the 5s default won't slow the suite down on the happy path. Fine.
actionbar.spec.ts being untouched — appreciate that the negative assertions (confirming no response arrives) kept their tight timeouts. That's the correct read.
Approve. Less code, more chill. That's the right direction.
…1110) ## Summary Alright, alright, alright. These e2e tests have been runnin' around like they're late for somethin', settin' tight little timeouts like the world's gonna end in 250 milliseconds. Man, you gotta *breathe*. Let the framework do its thing. Go slow to go fast, that's what I always say. ## Changes - **What**: Removed ~120 redundant timeout overrides from auto-retrying Playwright assertions (`toBeVisible`, `toBeHidden`, `toHaveCount`, `toBeEnabled`, `toHaveAttribute`, `toContainText`, `expect.poll`) where 5000ms is already the default. Also removed sub-5s timeouts (1s, 2s, 3s) that were just *begging* for flaky failures — like wearin' a belt and suspenders and also holdin' your pants up with both hands. Raised the absurdly short timeouts in `customMatchers.ts` (250ms `toPass` → 5000ms, 256ms poll → default). Kept `timeout: 5000` on `.toPass()` calls (defaults to 0), `.waitFor()`, `waitForRequest`, `waitForFunction`, intentionally-short timeouts inside retry loops, and conditional `.isVisible()/.catch()` checks — those fellas actually need the help. ## Review Focus Every remaining timeout in the diff is there for a *reason*. The ones on `.toPass()` stay because that API defaults to zero — it won't retry at all without one. The ones on `.waitFor()` and `waitForRequest` stay because those are locator actions, not auto-retrying assertions. The intentionally-short ones inside `toPass` retry loops (`interaction.spec.ts`) and the negative assertions (`actionbar.spec.ts` confirming no response arrives) — those are *supposed* to be tight. The short timeouts on regular assertions were actively *encouragin'* flaky failures. That's like settin' your alarm for 4 AM and then gettin' mad you're tired. Just... don't do that, man. Let things take the time they need. 38 files, net -115 lines. Less code, more chill. That's livin'. --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
Alright, alright, alright. These e2e tests have been runnin' around like they're late for somethin', settin' tight little timeouts like the world's gonna end in 250 milliseconds. Man, you gotta breathe. Let the framework do its thing. Go slow to go fast, that's what I always say.
Changes
toBeVisible,toBeHidden,toHaveCount,toBeEnabled,toHaveAttribute,toContainText,expect.poll) where 5000ms is already the default. Also removed sub-5s timeouts (1s, 2s, 3s) that were just begging for flaky failures — like wearin' a belt and suspenders and also holdin' your pants up with both hands. Raised the absurdly short timeouts incustomMatchers.ts(250mstoPass→ 5000ms, 256ms poll → default). Kepttimeout: 5000on.toPass()calls (defaults to 0),.waitFor(),waitForRequest,waitForFunction, intentionally-short timeouts inside retry loops, and conditional.isVisible()/.catch()checks — those fellas actually need the help.Review Focus
Every remaining timeout in the diff is there for a reason. The ones on
.toPass()stay because that API defaults to zero — it won't retry at all without one. The ones on.waitFor()andwaitForRequeststay because those are locator actions, not auto-retrying assertions. The intentionally-short ones insidetoPassretry loops (interaction.spec.ts) and the negative assertions (actionbar.spec.tsconfirming no response arrives) — those are supposed to be tight.The short timeouts on regular assertions were actively encouragin' flaky failures. That's like settin' your alarm for 4 AM and then gettin' mad you're tired. Just... don't do that, man. Let things take the time they need.
38 files, net -115 lines. Less code, more chill. That's livin'.