Repository navigation
[backport core/1.43] fix: disable pointer events on non-visible DOM widget overlays (#11063) - #11859
Conversation
…idget overlays (#11063) Manual backport of #11063 to `core/1.43`. Cherry-picked merge commit `4cf160d66`. ## Conflict resolution - `browser_tests/tests/interaction.spec.ts`: PR #11063 modified the 'Can toggle dom widget node open/closed' test by removing a programmatic-collapse workaround introduced in unrelated PR #10967 (which is not on `core/1.43`). On `core/1.43` the test uses an older `delay(1000) + click` form that does not need adjustment — the source fix in `DomWidget.vue` makes the second click reliable on its own. Skipped the test file change; kept the source + unit-test changes. ## Validation - `pnpm typecheck` passes --- ## Problem When a node with DOM widget overlays (e.g. CLIPTextEncode) is collapsed, the overlay elements can intercept pointer events intended for the canvas collapse toggler, making click-to-expand unreliable. ## Root Cause `updateWidgets()` runs during `onDrawForeground` (canvas render cycle) and sets `widgetState.visible = false` for collapsed nodes. `v-show` then hides the element with `display: none`. However, there is a timing gap between the canvas state change and Vue's DOM update — during this gap the widget overlay still intercepts pointer events. ## Fix Add `!widgetState.visible` to the `pointerEvents` condition in `composeStyle()`. This immediately sets `pointer-events: none` when the widget becomes invisible, preventing event interception before `v-show` applies `display: none`. Also restores click-to-expand in the E2E test, removing the programmatic `node.collapse()` workaround from PR #10967. - Fixes #11006 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11063-fix-disable-pointer-events-on-non-visible-DOM-widget-overlays-33e6d73d36508179a83cd47121cf933f) by [Unito](https://www.unito.io)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1044 passed, 0 failed · 2 flaky📊 Browser Reports
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.43 #11859 +/- ##
===========================================
Coverage 44.15% 44.15%
===========================================
Files 1341 1341
Lines 68841 68843 +2
Branches 19066 18200 -866
===========================================
+ Hits 30399 30400 +1
- Misses 37847 37848 +1
Partials 595 595
🚀 New features to boost your workflow:
|
📦 Bundle Size
⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-03T04:57:40.874Z",
"gitSha": "6000c1d6b695da7a6238c7d1ecb5a11271943950",
"branch": "glary/backport-1.43-11063",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2035.1370000000202,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.327999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.183,
"heapDeltaBytes": 20941068,
"heapUsedBytes": 63879096,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 21.844,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.3789999999908,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.876,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.81100000000004,
"heapDeltaBytes": 20407240,
"heapUsedBytes": 63256488,
"domNodes": 22,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 20.087999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2031.733000000031,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.774999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.40000000000003,
"heapDeltaBytes": 20422664,
"heapUsedBytes": 64320080,
"domNodes": 22,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 21.571,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2051.300000000026,
"styleRecalcs": 84,
"styleRecalcDurationMs": 45.678000000000004,
"layouts": 12,
"layoutDurationMs": 3.7169999999999996,
"taskDurationMs": 998.634,
"heapDeltaBytes": 17991172,
"heapUsedBytes": 66993248,
"domNodes": 67,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 137.219,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1999.1289999999822,
"styleRecalcs": 81,
"styleRecalcDurationMs": 40.399,
"layouts": 12,
"layoutDurationMs": 3.4140000000000006,
"taskDurationMs": 909.827,
"heapDeltaBytes": 16755316,
"heapUsedBytes": 59331824,
"domNodes": 67,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 128.402,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2013.3489999999483,
"styleRecalcs": 84,
"styleRecalcDurationMs": 41.315,
"layouts": 12,
"layoutDurationMs": 3.3690000000000007,
"taskDurationMs": 940.8910000000001,
"heapDeltaBytes": 16277420,
"heapUsedBytes": 59326516,
"domNodes": 65,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 133.38,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.5099999999575,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.96,
"layouts": 6,
"layoutDurationMs": 0.533,
"taskDurationMs": 281.03000000000003,
"heapDeltaBytes": 24996980,
"heapUsedBytes": 67684100,
"domNodes": 80,
"jsHeapTotalBytes": 20185088,
"scriptDurationMs": 22.798,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.7900000000277,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.368000000000002,
"layouts": 6,
"layoutDurationMs": 0.642,
"taskDurationMs": 292.087,
"heapDeltaBytes": 25047456,
"heapUsedBytes": 67937256,
"domNodes": 79,
"jsHeapTotalBytes": 21233664,
"scriptDurationMs": 25.1,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.2639999998964,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.225000000000005,
"layouts": 6,
"layoutDurationMs": 0.546,
"taskDurationMs": 283.18399999999997,
"heapDeltaBytes": 24987156,
"heapUsedBytes": 67710848,
"domNodes": 80,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 23.633,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 641.0419999999988,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.087999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.908,
"heapDeltaBytes": 8676876,
"heapUsedBytes": 57747800,
"domNodes": 22,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 72.42399999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 548.007000000041,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.441999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.31100000000004,
"heapDeltaBytes": 6474028,
"heapUsedBytes": 49420260,
"domNodes": 20,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 62.293000000000006,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 567.1329999998989,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.666999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.529,
"heapDeltaBytes": 6517372,
"heapUsedBytes": 49414488,
"domNodes": 19,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 66.58200000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2060.74000000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.241,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.215,
"heapDeltaBytes": 5174084,
"heapUsedBytes": 56264716,
"domNodes": -255,
"jsHeapTotalBytes": 16969728,
"scriptDurationMs": 95.08100000000002,
"eventListeners": -121,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2004.9690000000169,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.468,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.475,
"heapDeltaBytes": 4542720,
"heapUsedBytes": 56010120,
"domNodes": -259,
"jsHeapTotalBytes": 16707584,
"scriptDurationMs": 89.69999999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2052.9580000001033,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.516999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.9630000000001,
"heapDeltaBytes": 4679324,
"heapUsedBytes": 56280800,
"domNodes": -258,
"jsHeapTotalBytes": 16551936,
"scriptDurationMs": 96.82099999999998,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2148.262999999986,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.523999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1098.691,
"heapDeltaBytes": -4955192,
"heapUsedBytes": 48383444,
"domNodes": -259,
"jsHeapTotalBytes": 21221376,
"scriptDurationMs": 432.816,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2104.0219999999863,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.307999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1021.015,
"heapDeltaBytes": 17165504,
"heapUsedBytes": 70926424,
"domNodes": -260,
"jsHeapTotalBytes": 18223104,
"scriptDurationMs": 373.13199999999995,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2119.556999999986,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.039,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1025.7849999999999,
"heapDeltaBytes": 17093464,
"heapUsedBytes": 70910552,
"domNodes": -259,
"jsHeapTotalBytes": 18223104,
"scriptDurationMs": 382.872,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3160.898999999972,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.328,
"layouts": 60,
"layoutDurationMs": 6.889,
"taskDurationMs": 1254.151,
"heapDeltaBytes": 7013752,
"heapUsedBytes": 61909840,
"domNodes": -264,
"jsHeapTotalBytes": 17756160,
"scriptDurationMs": 471.66200000000003,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3145.9710000000314,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.397000000000002,
"layouts": 60,
"layoutDurationMs": 6.947000000000001,
"taskDurationMs": 1282.4279999999999,
"heapDeltaBytes": 7618908,
"heapUsedBytes": 62589676,
"domNodes": -261,
"jsHeapTotalBytes": 16969728,
"scriptDurationMs": 485.17199999999997,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3152.2410000000036,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.33,
"layouts": 60,
"layoutDurationMs": 6.896999999999999,
"taskDurationMs": 1241.1270000000002,
"heapDeltaBytes": 9245824,
"heapUsedBytes": 64519416,
"domNodes": -264,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 466.11699999999996,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.6359999999913,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.504000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.5880000000001,
"heapDeltaBytes": 3927036,
"heapUsedBytes": 56577848,
"domNodes": -258,
"jsHeapTotalBytes": 15659008,
"scriptDurationMs": 95.128,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2039.3660000000295,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.421999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.7990000000001,
"heapDeltaBytes": 2838904,
"heapUsedBytes": 56912624,
"domNodes": -261,
"jsHeapTotalBytes": 15396864,
"scriptDurationMs": 87.241,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2018.511999999987,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.214,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.615,
"heapDeltaBytes": 4004612,
"heapUsedBytes": 56567236,
"domNodes": -260,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 94.499,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 536.2190000000169,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.547999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.9,
"heapDeltaBytes": 6764520,
"heapUsedBytes": 49495340,
"domNodes": 24,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 124.996,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 569.9210000000221,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.314,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.434,
"heapDeltaBytes": 6697464,
"heapUsedBytes": 49760844,
"domNodes": 22,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 130.14100000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 522.640000000024,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.514999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.248,
"heapDeltaBytes": 6424004,
"heapUsedBytes": 50820812,
"domNodes": 23,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 115.647,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2010.8119999999872,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.213,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.04,
"heapDeltaBytes": 19937224,
"heapUsedBytes": 63212424,
"domNodes": 22,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 18.468999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1998.942999999997,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.831,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.51300000000003,
"heapDeltaBytes": 20682000,
"heapUsedBytes": 63394520,
"domNodes": 24,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 19.643,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2003.545000000031,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.293,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.291,
"heapDeltaBytes": 20014556,
"heapUsedBytes": 63088860,
"domNodes": 22,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 18.124,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1961.6919999999993,
"styleRecalcs": 83,
"styleRecalcDurationMs": 43.02,
"layouts": 16,
"layoutDurationMs": 4.649,
"taskDurationMs": 881.332,
"heapDeltaBytes": 11844696,
"heapUsedBytes": 55030596,
"domNodes": 72,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 97.44,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.4590000000085,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.347,
"layouts": 16,
"layoutDurationMs": 4.2170000000000005,
"taskDurationMs": 629.0799999999999,
"heapDeltaBytes": 11551992,
"heapUsedBytes": 54757108,
"domNodes": 61,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 94.561,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1966.8060000000196,
"styleRecalcs": 84,
"styleRecalcDurationMs": 41.317,
"layouts": 16,
"layoutDurationMs": 3.914,
"taskDurationMs": 871.6869999999999,
"heapDeltaBytes": 11907972,
"heapUsedBytes": 55042268,
"domNodes": 74,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 95.966,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8160.02199999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 41.728,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3504.697,
"heapDeltaBytes": 25767040,
"heapUsedBytes": 76417400,
"domNodes": -254,
"jsHeapTotalBytes": 20582400,
"scriptDurationMs": 1221.7389999999998,
"eventListeners": -105,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8153.366000000005,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.312,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3647.9970000000003,
"heapDeltaBytes": 3188896,
"heapUsedBytes": 56217888,
"domNodes": -259,
"jsHeapTotalBytes": 22212608,
"scriptDurationMs": 1342.984,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8143.342999999959,
"styleRecalcs": 251,
"styleRecalcDurationMs": 41.840999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3700.9890000000005,
"heapDeltaBytes": 31749008,
"heapUsedBytes": 83094560,
"domNodes": -254,
"jsHeapTotalBytes": 23728128,
"scriptDurationMs": 1350.4340000000002,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11288.044000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11278.729,
"heapDeltaBytes": -54947356,
"heapUsedBytes": 160133180,
"domNodes": -9852,
"jsHeapTotalBytes": 17653760,
"scriptDurationMs": 552.948,
"eventListeners": -23961,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11473.631999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11458.268,
"heapDeltaBytes": -32168396,
"heapUsedBytes": 167774116,
"domNodes": -9848,
"jsHeapTotalBytes": 23945216,
"scriptDurationMs": 569.378,
"eventListeners": -23961,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11289.273999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11277.701000000001,
"heapDeltaBytes": -33947884,
"heapUsedBytes": 168446292,
"domNodes": -9848,
"jsHeapTotalBytes": 24469504,
"scriptDurationMs": 558.693,
"eventListeners": -23965,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13937.104999999974,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.524000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13907.015000000001,
"heapDeltaBytes": -33427128,
"heapUsedBytes": 181761976,
"domNodes": -9848,
"jsHeapTotalBytes": -6025216,
"scriptDurationMs": 845.0249999999999,
"eventListeners": -23983,
"totalBlockingTimeMs": 45,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14079.360000000008,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.674000000000019,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14059.042,
"heapDeltaBytes": -21672080,
"heapUsedBytes": 173718052,
"domNodes": -9850,
"jsHeapTotalBytes": -13103104,
"scriptDurationMs": 835.4619999999999,
"eventListeners": -23955,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13796.345000000088,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.431999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13776.971,
"heapDeltaBytes": -66232728,
"heapUsedBytes": 149904144,
"domNodes": -9848,
"jsHeapTotalBytes": -11968512,
"scriptDurationMs": 845.5640000000001,
"eventListeners": -23983,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 439.19199999999137,
"styleRecalcs": 16,
"styleRecalcDurationMs": 21.339999999999996,
"layouts": 5,
"layoutDurationMs": 1.316,
"taskDurationMs": 116.60200000000002,
"heapDeltaBytes": 4714848,
"heapUsedBytes": 49152804,
"domNodes": 167,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.473,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 428.09600000009596,
"styleRecalcs": 17,
"styleRecalcDurationMs": 19.807000000000002,
"layouts": 4,
"layoutDurationMs": 0.9740000000000001,
"taskDurationMs": 101.61399999999998,
"heapDeltaBytes": 4373024,
"heapUsedBytes": 49014236,
"domNodes": 156,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 22.828,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 453.3729999999423,
"styleRecalcs": 16,
"styleRecalcDurationMs": 24.823,
"layouts": 5,
"layoutDurationMs": 1.453,
"taskDurationMs": 133.392,
"heapDeltaBytes": 4569020,
"heapUsedBytes": 48674040,
"domNodes": 156,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 33.107,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
PR Created by the Glary-Bot Agent
Manual backport of #11063 to
core/1.43for inclusion inv1.43.16. Cherry-picked from upstream merge commit4cf160d66.Why
When a node with DOM widget overlays (e.g. CLIPTextEncode) is collapsed, the overlay elements can intercept pointer events intended for the canvas collapse toggler, making click-to-expand unreliable. Adds
!widgetState.visibleto thepointerEventscondition incomposeStyle(), immediately settingpointer-events: nonewhen the widget becomes invisible — closing the timing gap beforev-showappliesdisplay: none. Fixes upstream issue #11006.Conflict resolution
browser_tests/tests/interaction.spec.ts. PR fix: disable pointer events on non-visible DOM widget overlays #11063 removed a programmatic-collapse workaround introduced by unrelated PR test: harden 82 Playwright specs for deterministic CI runs #10967 (which is not oncore/1.43). On 1.43 the test uses an olderdelay(1000) + clickform that doesn't need adjustment — the source fix inDomWidget.vuemakes the second click reliable on its own. Kept the source + unit-test changes.Validation
pnpm typecheck✅pnpm test:unit -- run src/components/graph/widgets/DomWidget.test.ts✅ (2/2 passing)pnpm exec eslint <changed files>✅ (0 errors)pnpm exec oxfmt --check✅ (clean)Manual end-to-end verification not performed — DOM widget pointer-event timing requires live canvas+widget interaction, not feasible to reproduce reliably in headless. Source identical to upstream
4cf160d66, baking onmainfor ~3 weeks throughv1.44.x.Original PR: #11063 / Original commit:
4cf160d66┆Issue is synchronized with this Notion page by Unito