Repository navigation
[backport core/1.43] fix: exclude muted/bypassed nodes from missing asset detection (#10856) - #11217
Conversation
…sset detection (#10856) Cherry-pick of 521019d onto core/1.43. Manual conflict resolution on two files, both limited to the `cleanupFakeModel` helper extraction: - browser_tests/tests/errorOverlay.spec.ts - browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts core/1.43 base still had the inline `expect(cleanupOk).toBeTruthy()` implementation; main's version (post-#10967) uses `expect.poll()` inline; #10856 replaced both with `await cleanupFakeModel(comfyPage)` calling the new helper in ErrorsTabHelper.ts. Conflict resolved by accepting the PR version (helper call) on both files, since the new helper is added in this same commit.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1014 passed, 0 failed · 2 flaky📊 Browser Reports
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.43 #11217 +/- ##
=============================================
+ Coverage 43.30% 43.49% +0.18%
=============================================
Files 1333 1333
Lines 68209 68598 +389
Branches 17969 18134 +165
=============================================
+ Hits 29539 29834 +295
- Misses 38078 38168 +90
- Partials 592 596 +4
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
📦 Bundle Size
⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-04-20T01:49:18.136Z",
"gitSha": "91047892ac513df75b54f258af920a387afab3d0",
"branch": "backport/core-1.43/10856",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2032.1880000000192,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.822000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.21799999999996,
"heapDeltaBytes": -4832964,
"heapUsedBytes": 44344872,
"domNodes": 22,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 24.766,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2024.8230000000262,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.523000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.655,
"heapDeltaBytes": 21050264,
"heapUsedBytes": 63528756,
"domNodes": 22,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 28.543000000000006,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2014.6650000000363,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.884000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.29400000000004,
"heapDeltaBytes": 20387632,
"heapUsedBytes": 62987736,
"domNodes": 22,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 27.812,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2030.7690000000207,
"styleRecalcs": 81,
"styleRecalcDurationMs": 43.173,
"layouts": 12,
"layoutDurationMs": 3.1859999999999995,
"taskDurationMs": 994.5329999999999,
"heapDeltaBytes": 16250892,
"heapUsedBytes": 59093252,
"domNodes": 66,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 129.28199999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2028.3890000000042,
"styleRecalcs": 85,
"styleRecalcDurationMs": 46.214999999999996,
"layouts": 12,
"layoutDurationMs": 3.402,
"taskDurationMs": 1038.931,
"heapDeltaBytes": 16359372,
"heapUsedBytes": 58852940,
"domNodes": 68,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 128.92399999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2025.6610000000137,
"styleRecalcs": 84,
"styleRecalcDurationMs": 42.452999999999996,
"layouts": 12,
"layoutDurationMs": 3.5419999999999994,
"taskDurationMs": 981.1120000000001,
"heapDeltaBytes": 16733244,
"heapUsedBytes": 59346180,
"domNodes": 65,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 126.806,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.3299999999622,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.957,
"layouts": 6,
"layoutDurationMs": 0.7309999999999999,
"taskDurationMs": 346.39599999999996,
"heapDeltaBytes": 15344316,
"heapUsedBytes": 67211244,
"domNodes": 80,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 27.897000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1748.8540000000512,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.958,
"layouts": 6,
"layoutDurationMs": 0.6409999999999999,
"taskDurationMs": 335.11999999999995,
"heapDeltaBytes": 24732552,
"heapUsedBytes": 67339264,
"domNodes": 79,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 28.033,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.3679999999658,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.665,
"layouts": 6,
"layoutDurationMs": 0.588,
"taskDurationMs": 322.72,
"heapDeltaBytes": -244612,
"heapUsedBytes": 48721628,
"domNodes": 80,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 26.814999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 577.1419999999807,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.288,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.059,
"heapDeltaBytes": 6226860,
"heapUsedBytes": 49059888,
"domNodes": 23,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 61.547,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 598.1969999999706,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.149,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.359,
"heapDeltaBytes": 6573128,
"heapUsedBytes": 49386720,
"domNodes": 19,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 65.07000000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 580.6690000000572,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.741000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.418,
"heapDeltaBytes": 6550164,
"heapUsedBytes": 49376144,
"domNodes": 20,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 66.973,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2054.3879999999604,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.900000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.4939999999999,
"heapDeltaBytes": 4707208,
"heapUsedBytes": 55929772,
"domNodes": -257,
"jsHeapTotalBytes": 16969728,
"scriptDurationMs": 97.86200000000001,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2033.2009999999627,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.241999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.062,
"heapDeltaBytes": 4291040,
"heapUsedBytes": 55955232,
"domNodes": -261,
"jsHeapTotalBytes": 15659008,
"scriptDurationMs": 99.189,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.5899999999656,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.076,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.0630000000001,
"heapDeltaBytes": 3071600,
"heapUsedBytes": 55927176,
"domNodes": -261,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 94.24100000000001,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2148.160999999959,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.559,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1140.024,
"heapDeltaBytes": 19419584,
"heapUsedBytes": 71201144,
"domNodes": -260,
"jsHeapTotalBytes": 19009536,
"scriptDurationMs": 393.92199999999997,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2178.128000000015,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.501999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1181.102,
"heapDeltaBytes": 18102956,
"heapUsedBytes": 71569456,
"domNodes": -262,
"jsHeapTotalBytes": 19271680,
"scriptDurationMs": 402.464,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2144.9969999999894,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.732,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1117.492,
"heapDeltaBytes": 18120376,
"heapUsedBytes": 71419040,
"domNodes": -259,
"jsHeapTotalBytes": 17436672,
"scriptDurationMs": 389.115,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3184.847999999988,
"styleRecalcs": 66,
"styleRecalcDurationMs": 17.905,
"layouts": 60,
"layoutDurationMs": 7.91,
"taskDurationMs": 1367.7290000000003,
"heapDeltaBytes": 642460,
"heapUsedBytes": 55245112,
"domNodes": -264,
"jsHeapTotalBytes": 16969728,
"scriptDurationMs": 483.6460000000001,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3182.7149999999165,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.675000000000004,
"layouts": 60,
"layoutDurationMs": 8.029,
"taskDurationMs": 1372.18,
"heapDeltaBytes": 9718944,
"heapUsedBytes": 64701280,
"domNodes": -265,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 478.881,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3150.2830000000586,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.958000000000002,
"layouts": 60,
"layoutDurationMs": 7.708000000000001,
"taskDurationMs": 1317.58,
"heapDeltaBytes": 6838808,
"heapUsedBytes": 61982884,
"domNodes": -262,
"jsHeapTotalBytes": 17231872,
"scriptDurationMs": 462.051,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2013.3280000000013,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.272000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.3689999999999,
"heapDeltaBytes": -52684,
"heapUsedBytes": 52867232,
"domNodes": -259,
"jsHeapTotalBytes": 15396864,
"scriptDurationMs": 97.90099999999998,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.4420000000082,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.222,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.9340000000001,
"heapDeltaBytes": 3142112,
"heapUsedBytes": 56874948,
"domNodes": -259,
"jsHeapTotalBytes": 15659008,
"scriptDurationMs": 91.027,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.9039999999977,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.883999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.485,
"heapDeltaBytes": 4628440,
"heapUsedBytes": 56868992,
"domNodes": -258,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 102.19800000000001,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.4440000000186,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.925999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.0920000000001,
"heapDeltaBytes": -2007744,
"heapUsedBytes": 49341228,
"domNodes": 22,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 119.51699999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.680999999955,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.891,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.28099999999995,
"heapDeltaBytes": 6243344,
"heapUsedBytes": 49307680,
"domNodes": 22,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 123.18400000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 599.2899999999963,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.299999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.391,
"heapDeltaBytes": -2009080,
"heapUsedBytes": 49791748,
"domNodes": 23,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 128.739,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2004.2169999999828,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.438,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.88499999999993,
"heapDeltaBytes": 20145932,
"heapUsedBytes": 63008004,
"domNodes": 22,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 25.016000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.461999999985,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.27,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.031,
"heapDeltaBytes": 19923384,
"heapUsedBytes": 63065244,
"domNodes": 22,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 23.942999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1995.2640000000201,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.77,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.30800000000005,
"heapDeltaBytes": 20303036,
"heapUsedBytes": 63470776,
"domNodes": 20,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 21.484999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.7649999999749,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.593,
"layouts": 16,
"layoutDurationMs": 4.695,
"taskDurationMs": 718.491,
"heapDeltaBytes": 12285892,
"heapUsedBytes": 55319672,
"domNodes": 62,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 92.326,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.0500000000338,
"styleRecalcs": 78,
"styleRecalcDurationMs": 41.776,
"layouts": 16,
"layoutDurationMs": 4.498,
"taskDurationMs": 730.3159999999999,
"heapDeltaBytes": 11830596,
"heapUsedBytes": 55138456,
"domNodes": 66,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 97.26400000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1960.3859999999713,
"styleRecalcs": 84,
"styleRecalcDurationMs": 43.611,
"layouts": 16,
"layoutDurationMs": 3.93,
"taskDurationMs": 917.0699999999999,
"heapDeltaBytes": 11808688,
"heapUsedBytes": 54999704,
"domNodes": 73,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 95.063,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8186.479000000019,
"styleRecalcs": 252,
"styleRecalcDurationMs": 47.03699999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3890.61,
"heapDeltaBytes": 18333108,
"heapUsedBytes": 68855936,
"domNodes": -256,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 1245.9150000000002,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8200.89399999995,
"styleRecalcs": 252,
"styleRecalcDurationMs": 46.163999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3994.394,
"heapDeltaBytes": 27286788,
"heapUsedBytes": 78200856,
"domNodes": -255,
"jsHeapTotalBytes": 18485248,
"scriptDurationMs": 1272.702,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8175.617999999986,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.477999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3846.7290000000003,
"heapDeltaBytes": 25472496,
"heapUsedBytes": 75819252,
"domNodes": -259,
"jsHeapTotalBytes": 19009536,
"scriptDurationMs": 1223.2350000000001,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10687.679000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10671.493999999999,
"heapDeltaBytes": -58985468,
"heapUsedBytes": 160627644,
"domNodes": -9850,
"jsHeapTotalBytes": 21061632,
"scriptDurationMs": 569.5550000000001,
"eventListeners": -23963,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10688.083000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10674.556,
"heapDeltaBytes": -39435056,
"heapUsedBytes": 159184548,
"domNodes": -9848,
"jsHeapTotalBytes": 13983744,
"scriptDurationMs": 574.18,
"eventListeners": -23965,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10640.480999999909,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10626.482,
"heapDeltaBytes": -54571596,
"heapUsedBytes": 160180452,
"domNodes": -9848,
"jsHeapTotalBytes": 17653760,
"scriptDurationMs": 532.0769999999999,
"eventListeners": -23965,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12851.525999999978,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.340999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12827.845,
"heapDeltaBytes": -58417764,
"heapUsedBytes": 149621548,
"domNodes": -9848,
"jsHeapTotalBytes": -10395648,
"scriptDurationMs": 846.194,
"eventListeners": -23957,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 12784.189000000082,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.189000000000036,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12763.225000000002,
"heapDeltaBytes": -41397524,
"heapUsedBytes": 173742484,
"domNodes": -9848,
"jsHeapTotalBytes": -17559552,
"scriptDurationMs": 825.895,
"eventListeners": -23961,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 12981.625000000007,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.434999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12962.207,
"heapDeltaBytes": -41823652,
"heapUsedBytes": 173712996,
"domNodes": -9850,
"jsHeapTotalBytes": -14413824,
"scriptDurationMs": 851.3839999999999,
"eventListeners": -23959,
"totalBlockingTimeMs": 42,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 468.39999999997417,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.26,
"layouts": 6,
"layoutDurationMs": 1.925,
"taskDurationMs": 150.591,
"heapDeltaBytes": 4811364,
"heapUsedBytes": 49057204,
"domNodes": 167,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.505,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 460.9850000000506,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.361999999999995,
"layouts": 5,
"layoutDurationMs": 1.4899999999999998,
"taskDurationMs": 134.73800000000003,
"heapDeltaBytes": 4510100,
"heapUsedBytes": 48693152,
"domNodes": 159,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.759,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 450.55999999999585,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.773000000000003,
"layouts": 4,
"layoutDurationMs": 1.054,
"taskDurationMs": 116.96100000000001,
"heapDeltaBytes": 4471788,
"heapUsedBytes": 49157540,
"domNodes": 156,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 24.576,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…asset detection (#10856) (#11218) Manual backport of #10856 to `cloud/1.43`. Paired with core/1.43 backport #11217. ## Conflicts resolved Same two files, same root cause as the core/1.43 backport — #10856 extracted the inline `cleanup_fake_model` block into a shared `cleanupFakeModel` helper in `browser_tests/tests/propertiesPanel/ErrorsTabHelper.ts`: - `browser_tests/tests/errorOverlay.spec.ts` - `browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts` `cloud/1.43` still carries the original inline `expect(cleanupOk).toBeTruthy()` form. #10856 replaces both with `await cleanupFakeModel(comfyPage)` calling the helper added by this same PR. Resolution: accepted the PR version (helper call) on both conflict sites. The helper itself is added as part of this backport, so no runtime behavior is lost. ## Verification - No residual conflict markers - Cherry-picked commit carries the entire #10856 squash (45 files, +3596/-209) ## Original PR summary See #10856 for full behavioral description, test plan, and screenshots. --- Fixes Comfy-Org/ComfyUI#13256 on cloud/1.43 ┆Issue is synchronized with this [Notion page](https://app.notion.com/p/PR-11218-backport-cloud-1-43-fix-exclude-muted-bypassed-nodes-from-missing-asset-detection-1-3426d73d3650811e9a27d4a334c74de8) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Manual backport of #10856 to
core/1.43.Conflicts resolved
Two files had trivial conflicts from the same root cause — #10856 extracted the inline
cleanup_fake_modelblock into a sharedcleanupFakeModelhelper inbrowser_tests/tests/propertiesPanel/ErrorsTabHelper.ts:browser_tests/tests/errorOverlay.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.tscore/1.43still carries the original inlineexpect(cleanupOk).toBeTruthy()form. main's version (post-#10967) uses an inlineexpect.poll()instead. #10856 replaces both withawait cleanupFakeModel(comfyPage)calling the helper added by this same PR.Resolution: accepted the PR version (helper call) on both conflict sites. The helper itself is added as part of this backport, so no runtime behavior is lost.
Verification
Original PR summary
See #10856 for full behavioral description, test plan, and screenshots.
Fixes Comfy-Org/ComfyUI#13256 on core/1.43
┆Issue is synchronized with this Notion page by Unito