Repository navigation
test: Simplify vue node/menu test setup - #11184
Conversation
- add vue-nodes tag to auto enable nodes 2.0
🎭 Playwright: ✅ 1099 passed, 0 failed · 2 flaky📊 Browser Reports
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (5)
📝 WalkthroughWalkthroughThe PR refactors browser test infrastructure by centralizing Vue node enablement logic into the ComfyPage fixture based on Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook |
📦 Bundle: 5.15 MB gzip 🔴 +127 BDetailsSummary
Category Glance App Entry Points — 22.3 kB (baseline 22.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.22 MB (baseline 1.22 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 482 kB (baseline 482 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 109 kB (baseline 109 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 60.3 kB (baseline 60.3 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 3 MB (baseline 3 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 344 kB (baseline 344 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 14 unchanged Vendor & Third-Party — 9.86 MB (baseline 9.86 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BBundles that do not match a named category
Status: 56 added / 56 removed / 79 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-04-13T19:09:07.535Z",
"gitSha": "5f6489f52c5bc84f200326a051bf913113af0107",
"branch": "pysssss/simplify-test-settings",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.9839999999933,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.169000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.582,
"heapDeltaBytes": 20019676,
"heapUsedBytes": 63253436,
"domNodes": 13,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 14.890999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2019.8729999999614,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.399000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.974,
"heapDeltaBytes": 11473936,
"heapUsedBytes": 64597520,
"domNodes": 20,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 28.865999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.3909999999132,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.089,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.79200000000003,
"heapDeltaBytes": 20019600,
"heapUsedBytes": 63211740,
"domNodes": 18,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 20.908,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2022.517999999991,
"styleRecalcs": 84,
"styleRecalcDurationMs": 42.902,
"layouts": 12,
"layoutDurationMs": 3.7689999999999997,
"taskDurationMs": 948.429,
"heapDeltaBytes": 15986808,
"heapUsedBytes": 58894812,
"domNodes": 66,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 132.105,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2031.7450000000008,
"styleRecalcs": 80,
"styleRecalcDurationMs": 44.2,
"layouts": 12,
"layoutDurationMs": 3.2540000000000004,
"taskDurationMs": 983.0889999999999,
"heapDeltaBytes": 16159372,
"heapUsedBytes": 60966784,
"domNodes": 66,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 136.686,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2042.2989999999572,
"styleRecalcs": 83,
"styleRecalcDurationMs": 50.111000000000004,
"layouts": 12,
"layoutDurationMs": 3.8,
"taskDurationMs": 995.817,
"heapDeltaBytes": 15979556,
"heapUsedBytes": 58991216,
"domNodes": 68,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 141.672,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1749.2819999999938,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.801000000000002,
"layouts": 6,
"layoutDurationMs": 0.5970000000000001,
"taskDurationMs": 312.577,
"heapDeltaBytes": 24731024,
"heapUsedBytes": 67322504,
"domNodes": 80,
"jsHeapTotalBytes": 20185088,
"scriptDurationMs": 25.286999999999995,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1747.8010000000381,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.117,
"layouts": 6,
"layoutDurationMs": 0.5369999999999999,
"taskDurationMs": 314.42900000000003,
"heapDeltaBytes": 24687968,
"heapUsedBytes": 67251528,
"domNodes": 81,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 26.377000000000006,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.0099999999647,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.687,
"layouts": 6,
"layoutDurationMs": 0.6330000000000001,
"taskDurationMs": 298.15000000000003,
"heapDeltaBytes": -411536,
"heapUsedBytes": 48643012,
"domNodes": 79,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 22.677999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 608.4900000000175,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.214,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.297,
"heapDeltaBytes": 7651404,
"heapUsedBytes": 51845760,
"domNodes": 22,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 73.702,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 591.4690000000178,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.247,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.90099999999995,
"heapDeltaBytes": 6523840,
"heapUsedBytes": 49083092,
"domNodes": 22,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 68.75,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 593.8239999999269,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.672999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.45799999999997,
"heapDeltaBytes": 6734624,
"heapUsedBytes": 49567400,
"domNodes": 22,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 68.56599999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2042.5950000000057,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.780000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.404,
"heapDeltaBytes": 4601180,
"heapUsedBytes": 55621988,
"domNodes": -257,
"jsHeapTotalBytes": 16441344,
"scriptDurationMs": 94.007,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2073.0689999999754,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.616999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.223,
"heapDeltaBytes": 4677948,
"heapUsedBytes": 55906044,
"domNodes": -259,
"jsHeapTotalBytes": 15761408,
"scriptDurationMs": 100.30699999999999,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.3319999999112,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.645,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.895,
"heapDeltaBytes": 3861136,
"heapUsedBytes": 55414064,
"domNodes": -257,
"jsHeapTotalBytes": 16179200,
"scriptDurationMs": 106.34599999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2141.7229999999845,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.771,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1159.615,
"heapDeltaBytes": 15653460,
"heapUsedBytes": 69556440,
"domNodes": -263,
"jsHeapTotalBytes": 19791872,
"scriptDurationMs": 442.64599999999996,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2095.006000000012,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.130000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1080.745,
"heapDeltaBytes": 16892604,
"heapUsedBytes": 71585208,
"domNodes": -266,
"jsHeapTotalBytes": 17432576,
"scriptDurationMs": 417.131,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2152.319000000034,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.782,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1160.91,
"heapDeltaBytes": 17833152,
"heapUsedBytes": 71491872,
"domNodes": -261,
"jsHeapTotalBytes": 18219008,
"scriptDurationMs": 419.307,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3167.60400000004,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.36,
"layouts": 60,
"layoutDurationMs": 7.336,
"taskDurationMs": 1292.351,
"heapDeltaBytes": 6863944,
"heapUsedBytes": 61978896,
"domNodes": -263,
"jsHeapTotalBytes": 16441344,
"scriptDurationMs": 490.03700000000003,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3149.562000000003,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.002999999999995,
"layouts": 60,
"layoutDurationMs": 6.984000000000001,
"taskDurationMs": 1329.408,
"heapDeltaBytes": 7986600,
"heapUsedBytes": 63335332,
"domNodes": -267,
"jsHeapTotalBytes": 17752064,
"scriptDurationMs": 513.112,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3185.795999999982,
"styleRecalcs": 66,
"styleRecalcDurationMs": 17.781000000000002,
"layouts": 60,
"layoutDurationMs": 7.683,
"taskDurationMs": 1413.8310000000001,
"heapDeltaBytes": 3762072,
"heapUsedBytes": 59195412,
"domNodes": -264,
"jsHeapTotalBytes": 18014208,
"scriptDurationMs": 532.3530000000001,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2048.5510000000318,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.862,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.6750000000001,
"heapDeltaBytes": 3937252,
"heapUsedBytes": 56837944,
"domNodes": -258,
"jsHeapTotalBytes": 16441344,
"scriptDurationMs": 96.86500000000001,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2026.313000000016,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.791999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.1590000000001,
"heapDeltaBytes": 3696884,
"heapUsedBytes": 56634540,
"domNodes": -259,
"jsHeapTotalBytes": 16441344,
"scriptDurationMs": 98.40400000000002,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.8539999999666,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.247999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.375,
"heapDeltaBytes": 2212152,
"heapUsedBytes": 56587396,
"domNodes": -262,
"jsHeapTotalBytes": 14868480,
"scriptDurationMs": 92.24200000000002,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 550.4530000000045,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.499999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.4,
"heapDeltaBytes": 6708672,
"heapUsedBytes": 51183468,
"domNodes": 22,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 127.414,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 554.3659999999591,
"styleRecalcs": 47,
"styleRecalcDurationMs": 16.569,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.62899999999996,
"heapDeltaBytes": 6173136,
"heapUsedBytes": 49306432,
"domNodes": 20,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 129.146,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 566.1580000000868,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.149999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.57099999999997,
"heapDeltaBytes": 6224644,
"heapUsedBytes": 49344632,
"domNodes": 20,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 131.493,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2016.0889999999938,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.597000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.868,
"heapDeltaBytes": 19868236,
"heapUsedBytes": 64432128,
"domNodes": 20,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 17.106,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2036.6820000000416,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.534999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.07899999999995,
"heapDeltaBytes": 19928244,
"heapUsedBytes": 63094384,
"domNodes": 22,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 17.412,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.5389999999898,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.683,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.24100000000004,
"heapDeltaBytes": 19868788,
"heapUsedBytes": 63095048,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 18.881,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2063.2720000000118,
"styleRecalcs": 84,
"styleRecalcDurationMs": 49.30499999999999,
"layouts": 16,
"layoutDurationMs": 4.9350000000000005,
"taskDurationMs": 1037.0159999999998,
"heapDeltaBytes": 12247800,
"heapUsedBytes": 55750808,
"domNodes": 72,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 104.696,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1698.2139999999504,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.031,
"layouts": 16,
"layoutDurationMs": 4.49,
"taskDurationMs": 678.989,
"heapDeltaBytes": 11771992,
"heapUsedBytes": 55880312,
"domNodes": 66,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 100.227,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2013.9619999999923,
"styleRecalcs": 88,
"styleRecalcDurationMs": 48.308,
"layouts": 16,
"layoutDurationMs": 4.6499999999999995,
"taskDurationMs": 945.509,
"heapDeltaBytes": 2404312,
"heapUsedBytes": 53842268,
"domNodes": 73,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 106.65299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8171.008000000029,
"styleRecalcs": 252,
"styleRecalcDurationMs": 44.318999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3580.916,
"heapDeltaBytes": 25542352,
"heapUsedBytes": 75742968,
"domNodes": -255,
"jsHeapTotalBytes": 18743296,
"scriptDurationMs": 1240.467,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8182.773999999995,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.177,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3686.4109999999996,
"heapDeltaBytes": 24364648,
"heapUsedBytes": 75834824,
"domNodes": -259,
"jsHeapTotalBytes": 19529728,
"scriptDurationMs": 1263.3670000000002,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8183.903999999984,
"styleRecalcs": 250,
"styleRecalcDurationMs": 42.988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3749.074,
"heapDeltaBytes": 25909704,
"heapUsedBytes": 76863860,
"domNodes": -261,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 1265.711,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12741.406999999981,
"styleRecalcs": 1,
"styleRecalcDurationMs": 19.60999999999999,
"layouts": 1,
"layoutDurationMs": 4.943000000000003,
"taskDurationMs": 12720.757000000001,
"heapDeltaBytes": -25302428,
"heapUsedBytes": 168416280,
"domNodes": -8329,
"jsHeapTotalBytes": 36265984,
"scriptDurationMs": 625.54,
"eventListeners": -14696,
"totalBlockingTimeMs": 1204,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12612.896000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12597.275,
"heapDeltaBytes": -48807776,
"heapUsedBytes": 168098012,
"domNodes": -9850,
"jsHeapTotalBytes": 26566656,
"scriptDurationMs": 610.8100000000001,
"eventListeners": -23957,
"totalBlockingTimeMs": 305,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12051.919999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12035.103,
"heapDeltaBytes": -38051284,
"heapUsedBytes": 159979888,
"domNodes": -9850,
"jsHeapTotalBytes": 15294464,
"scriptDurationMs": 581.0280000000001,
"eventListeners": -23959,
"totalBlockingTimeMs": 306,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14373.617999999966,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.395999999999963,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14350.592000000002,
"heapDeltaBytes": -22364948,
"heapUsedBytes": 174173764,
"domNodes": -9850,
"jsHeapTotalBytes": -16248832,
"scriptDurationMs": 852.19,
"eventListeners": -23955,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14644.560999999954,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.307000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14617.926999999998,
"heapDeltaBytes": -64405884,
"heapUsedBytes": 150102560,
"domNodes": -9850,
"jsHeapTotalBytes": -10133504,
"scriptDurationMs": 885.2609999999999,
"eventListeners": -23983,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14225.164999999946,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.631000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14204.863,
"heapDeltaBytes": -46879456,
"heapUsedBytes": 167543192,
"domNodes": -9848,
"jsHeapTotalBytes": 26828800,
"scriptDurationMs": 873.096,
"eventListeners": -23955,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 437.23799999997937,
"styleRecalcs": 17,
"styleRecalcDurationMs": 23.616999999999997,
"layouts": 4,
"layoutDurationMs": 1.1369999999999998,
"taskDurationMs": 112.822,
"heapDeltaBytes": 4619396,
"heapUsedBytes": 49086468,
"domNodes": 165,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 23.455000000000005,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 102.45999999995092,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.267000000000001,
"layouts": 4,
"layoutDurationMs": 1.146,
"taskDurationMs": 80.502,
"heapDeltaBytes": 2489600,
"heapUsedBytes": 48490472,
"domNodes": 142,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 21.141000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 442.99999999998363,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.295,
"layouts": 6,
"layoutDurationMs": 1.604,
"taskDurationMs": 124.34199999999998,
"heapDeltaBytes": 4523840,
"heapUsedBytes": 55115872,
"domNodes": 156,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.180999999999997,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #11184 +/- ##
=======================================
Coverage 43.68% 43.68%
=======================================
Files 1349 1349
Lines 69149 69149
Branches 19159 19159
=======================================
Hits 30211 30211
Misses 38340 38340
Partials 598 598 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts (1)
446-469: Extract the reroute insertion block into a helper.These two
page.evaluate()blocks are identical. Pulling them into a shared helper next toconnectSlots()would keep the graph lookup and coordinate-conversion logic in one place and make future changes much less error-prone.Also applies to: 541-564
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts` around lines 446 - 469, Extract the duplicated page.evaluate() reroute-insertion logic into a reusable helper (e.g., createRerouteAt or insertRerouteAt) placed alongside connectSlots(); the helper should accept (page, targetNodeId, targetSlot, clientPoint) and inside evaluate perform the same graph lookup (app?.canvas?.graph ?? app?.graph), node/input/link retrieval, convert clientPoint via app.canvas.ds.convertCanvasToOffset and call graph.createReroute(linkPos, link). Replace both inline comfyPage.page.evaluate blocks with calls to this helper to centralize conversion and error checks (references: connectSlots, graph.createReroute, app.canvas.ds.convertCanvasToOffset).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@browser_tests/tests/pasteImageContextMenu.spec.ts`:
- Around line 18-23: The test currently right-clicks the node directly which can
yield an empty/wrong context menu; first select the node before opening the
context menu by invoking the selection helper (e.g., call
vueNodes.selectNode(loadImageNode.id) or use the node element's left-click like
nodeRef.click('title')) and then perform the right-click on
comfyPage.page.locator(`[data-node-id="${loadImageNode.id}"]`); ensure the menu
locator '.p-contextmenu' is awaited after the right-click to validate the
correct menu contents.
In `@browser_tests/tests/vueNodes/interactions/node/remove.spec.ts`:
- Around line 91-112: Add a call to wait for Vue nodes to render before querying
inputs: in the test "Delete key does not delete node when typing in Vue node
widgets" invoke comfyPage.vueNodes.waitForNodes() (or the existing wait helper)
after setup and before locating the text widget, so the locator
comfyPage.page.locator('input[type="text"], textarea').first() targets a
rendered Vue node widget rather than racing the render; this ensures the Delete
key presses operate on the correct input.
---
Nitpick comments:
In `@browser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.ts`:
- Around line 446-469: Extract the duplicated page.evaluate() reroute-insertion
logic into a reusable helper (e.g., createRerouteAt or insertRerouteAt) placed
alongside connectSlots(); the helper should accept (page, targetNodeId,
targetSlot, clientPoint) and inside evaluate perform the same graph lookup
(app?.canvas?.graph ?? app?.graph), node/input/link retrieval, convert
clientPoint via app.canvas.ds.convertCanvasToOffset and call
graph.createReroute(linkPos, link). Replace both inline comfyPage.page.evaluate
blocks with calls to this helper to centralize conversion and error checks
(references: connectSlots, graph.createReroute,
app.canvas.ds.convertCanvasToOffset).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3e24677e-5505-40f8-8208-1c808d96b316
📒 Files selected for processing (91)
browser_tests/fixtures/ComfyPage.tsbrowser_tests/fixtures/components/OutputHistory.tsbrowser_tests/fixtures/helpers/ExecutionHelper.tsbrowser_tests/tests/actionbar.spec.tsbrowser_tests/tests/appModePruning.spec.tsbrowser_tests/tests/bottomPanelLogs.spec.tsbrowser_tests/tests/bottomPanelShortcuts.spec.tsbrowser_tests/tests/browserTabTitle.spec.tsbrowser_tests/tests/changeTracker.spec.tsbrowser_tests/tests/cloud.spec.tsbrowser_tests/tests/collapsedNodeLinks.spec.tsbrowser_tests/tests/customIcons.spec.tsbrowser_tests/tests/defaultKeybindings.spec.tsbrowser_tests/tests/dialog.spec.tsbrowser_tests/tests/dialogs/signInDialog.spec.tsbrowser_tests/tests/domWidget.spec.tsbrowser_tests/tests/errorOverlay.spec.tsbrowser_tests/tests/execution.spec.tsbrowser_tests/tests/extensionAPI.spec.tsbrowser_tests/tests/focusMode.spec.tsbrowser_tests/tests/groupNode.spec.tsbrowser_tests/tests/imageCompare.spec.tsbrowser_tests/tests/interaction.spec.tsbrowser_tests/tests/jobHistoryActions.spec.tsbrowser_tests/tests/linearMode.spec.tsbrowser_tests/tests/maskEditor.spec.tsbrowser_tests/tests/menu.spec.tsbrowser_tests/tests/minimap.spec.tsbrowser_tests/tests/nodeHelp.spec.tsbrowser_tests/tests/nodeLibraryEssentials.spec.tsbrowser_tests/tests/outputHistory.spec.tsbrowser_tests/tests/painter.spec.tsbrowser_tests/tests/pasteImageContextMenu.spec.tsbrowser_tests/tests/primitiveNode.spec.tsbrowser_tests/tests/propertiesPanel/errorsTab.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabExecution.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabMissingMedia.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.tsbrowser_tests/tests/propertiesPanel/errorsTabMissingNodes.spec.tsbrowser_tests/tests/propertiesPanel/nodeSettings.spec.tsbrowser_tests/tests/releaseNotifications.spec.tsbrowser_tests/tests/remoteWidgets.spec.tsbrowser_tests/tests/rerouteNode.spec.tsbrowser_tests/tests/resultGallery.spec.tsbrowser_tests/tests/rightSidePanelTabs.spec.tsbrowser_tests/tests/saveImageAndWebp.spec.tsbrowser_tests/tests/selectionRectangle.spec.tsbrowser_tests/tests/selectionToolboxActions.spec.tsbrowser_tests/tests/sidebar/nodeLibrary.spec.tsbrowser_tests/tests/sidebar/nodeLibraryV2.spec.tsbrowser_tests/tests/sidebar/sidebarSplitterWidth.spec.tsbrowser_tests/tests/sidebar/workflows.spec.tsbrowser_tests/tests/subgraph/subgraphDuplicateIndependentValues.spec.tsbrowser_tests/tests/subgraph/subgraphLifecycle.spec.tsbrowser_tests/tests/subgraph/subgraphNavigation.spec.tsbrowser_tests/tests/subgraph/subgraphPromotion.spec.tsbrowser_tests/tests/subgraph/subgraphPromotionDom.spec.tsbrowser_tests/tests/subgraph/subgraphSearch.spec.tsbrowser_tests/tests/subgraph/subgraphZeroUuid.spec.tsbrowser_tests/tests/subgraphPromotedWidgetPanel.spec.tsbrowser_tests/tests/templates.spec.tsbrowser_tests/tests/toastNotifications.spec.tsbrowser_tests/tests/topbar/workflowTabs.spec.tsbrowser_tests/tests/versionMismatchWarnings.spec.tsbrowser_tests/tests/vueNodes/groups/groups.spec.tsbrowser_tests/tests/vueNodes/interactions/canvas/pan.spec.tsbrowser_tests/tests/vueNodes/interactions/canvas/zoom.spec.tsbrowser_tests/tests/vueNodes/interactions/links/linkInteraction.spec.tsbrowser_tests/tests/vueNodes/interactions/node/bringToFront.spec.tsbrowser_tests/tests/vueNodes/interactions/node/contextMenu.spec.tsbrowser_tests/tests/vueNodes/interactions/node/imagePreview.spec.tsbrowser_tests/tests/vueNodes/interactions/node/move.spec.tsbrowser_tests/tests/vueNodes/interactions/node/remove.spec.tsbrowser_tests/tests/vueNodes/interactions/node/rename.spec.tsbrowser_tests/tests/vueNodes/interactions/node/resize.spec.tsbrowser_tests/tests/vueNodes/interactions/node/select.spec.tsbrowser_tests/tests/vueNodes/nodeStates/bypass.spec.tsbrowser_tests/tests/vueNodes/nodeStates/collapse.spec.tsbrowser_tests/tests/vueNodes/nodeStates/colors.spec.tsbrowser_tests/tests/vueNodes/nodeStates/error.spec.tsbrowser_tests/tests/vueNodes/nodeStates/mute.spec.tsbrowser_tests/tests/vueNodes/nodeStates/pin.spec.tsbrowser_tests/tests/vueNodes/rerouteNodeSize.spec.tsbrowser_tests/tests/vueNodes/widgets/advancedWidgets.spec.tsbrowser_tests/tests/vueNodes/widgets/imageCrop.spec.tsbrowser_tests/tests/vueNodes/widgets/int/integerWidget.spec.tsbrowser_tests/tests/vueNodes/widgets/load/uploadWidgets.spec.tsbrowser_tests/tests/vueNodes/widgets/text/multilineStringWidget.spec.tsbrowser_tests/tests/vueNodes/widgets/widgetReactivity.spec.tsbrowser_tests/tests/widgetCopyButton.spec.tsbrowser_tests/tests/workflowTabThumbnail.spec.ts
💤 Files with no reviewable changes (48)
- browser_tests/tests/rightSidePanelTabs.spec.ts
- browser_tests/tests/focusMode.spec.ts
- browser_tests/tests/minimap.spec.ts
- browser_tests/tests/releaseNotifications.spec.ts
- browser_tests/tests/customIcons.spec.ts
- browser_tests/tests/menu.spec.ts
- browser_tests/tests/bottomPanelLogs.spec.ts
- browser_tests/tests/subgraph/subgraphLifecycle.spec.ts
- browser_tests/tests/extensionAPI.spec.ts
- browser_tests/tests/propertiesPanel/errorsTabMissingNodes.spec.ts
- browser_tests/tests/subgraph/subgraphPromotionDom.spec.ts
- browser_tests/tests/sidebar/sidebarSplitterWidth.spec.ts
- browser_tests/tests/rerouteNode.spec.ts
- browser_tests/tests/toastNotifications.spec.ts
- browser_tests/tests/dialog.spec.ts
- browser_tests/tests/templates.spec.ts
- browser_tests/tests/subgraph/subgraphNavigation.spec.ts
- browser_tests/tests/actionbar.spec.ts
- browser_tests/tests/versionMismatchWarnings.spec.ts
- browser_tests/tests/primitiveNode.spec.ts
- browser_tests/tests/dialogs/signInDialog.spec.ts
- browser_tests/tests/subgraph/subgraphSearch.spec.ts
- browser_tests/tests/subgraphPromotedWidgetPanel.spec.ts
- browser_tests/tests/workflowTabThumbnail.spec.ts
- browser_tests/tests/topbar/workflowTabs.spec.ts
- browser_tests/tests/sidebar/nodeLibraryV2.spec.ts
- browser_tests/tests/sidebar/workflows.spec.ts
- browser_tests/tests/groupNode.spec.ts
- browser_tests/tests/propertiesPanel/errorsTabMissingMedia.spec.ts
- browser_tests/tests/nodeLibraryEssentials.spec.ts
- browser_tests/tests/execution.spec.ts
- browser_tests/tests/errorOverlay.spec.ts
- browser_tests/tests/changeTracker.spec.ts
- browser_tests/tests/browserTabTitle.spec.ts
- browser_tests/tests/bottomPanelShortcuts.spec.ts
- browser_tests/tests/linearMode.spec.ts
- browser_tests/tests/remoteWidgets.spec.ts
- browser_tests/tests/propertiesPanel/errorsTabMissingModels.spec.ts
- browser_tests/tests/jobHistoryActions.spec.ts
- browser_tests/tests/propertiesPanel/errorsTab.spec.ts
- browser_tests/tests/domWidget.spec.ts
- browser_tests/tests/propertiesPanel/errorsTabExecution.spec.ts
- browser_tests/tests/defaultKeybindings.spec.ts
- browser_tests/tests/nodeHelp.spec.ts
- browser_tests/tests/selectionToolboxActions.spec.ts
- browser_tests/tests/interaction.spec.ts
- browser_tests/tests/subgraph/subgraphPromotion.spec.ts
- browser_tests/tests/sidebar/nodeLibrary.spec.ts
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| @@ -478,7 +478,6 @@ test.describe( | |||
| comfyPage | |||
| }) => { | |||
| await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top') | |||
| @@ -116,7 +116,6 @@ test.describe('Subgraph Promotion DOM', { tag: ['@subgraph'] }, () => { | |||
| comfyPage | |||
| }) => { | |||
| await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top') | |||
There was a problem hiding this comment.
| await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top') |
| @@ -523,7 +522,6 @@ test.describe( | |||
| comfyPage | |||
| }) => { | |||
| await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top') | |||
There was a problem hiding this comment.
| await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top') |
| @@ -478,7 +478,6 @@ test.describe( | |||
| comfyPage | |||
| }) => { | |||
| await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top') | |||
There was a problem hiding this comment.
| await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top') |
| test.setTimeout(30000) // Extend timeout as we need to reload the page an additional time | ||
| await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true) | ||
| await comfyPage.page.reload() // Reload page as we need to enter in Vue mode | ||
| await comfyPage.page.reload() // Reload page to ensure Vue mode is active |
| test.beforeEach(async ({ comfyPage }) => { | ||
| await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true) | ||
| await comfyPage.settings.setSetting('LiteGraph.Canvas.MinFontSizeForLOD', 8) | ||
| await comfyPage.vueNodes.waitForNodes() |
There was a problem hiding this comment.
Nit: Can this one be removed, or is it necessary because of the setting change?
| await comfyPage.vueNodes.waitForNodes() |
| await comfyPage.setup() | ||
| await comfyPage.vueNodes.waitForNodes() |
There was a problem hiding this comment.
Same for these, are they still required?
| await comfyPage.setup() | ||
| await comfyPage.vueNodes.waitForNodes() |
| test.describe('Vue Integer Widget', { tag: '@vue-nodes' }, () => { | ||
| test.beforeEach(async ({ comfyPage }) => { | ||
| await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true) | ||
| await comfyPage.setup() |
| node.pos = [500, 200] | ||
| window.app!.graph.add(node) | ||
| }) | ||
| await comfyPage.vueNodes.waitForNodes() |
There was a problem hiding this comment.
I mean, it's probably not harmful...
| await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true) | ||
| await comfyPage.settings.setSetting('Comfy.Minimap.Visible', false) | ||
| await comfyPage.workflow.loadWorkflow('links/single_connected_reroute_node') | ||
| await comfyPage.vueNodes.waitForNodes() |
There was a problem hiding this comment.
But if we can get rid of them...
| test.beforeEach(async ({ comfyPage }) => { | ||
| await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true) | ||
| await comfyPage.workflow.loadWorkflow('default') | ||
| await comfyPage.vueNodes.waitForNodes() |
| @@ -103,7 +103,6 @@ test.describe('Support', () => { | |||
| comfyPage | |||
| }) => { | |||
| await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top') | |||
There was a problem hiding this comment.
| await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top') |
| test.beforeEach(async ({ comfyPage }) => { | ||
| await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top') | ||
| await comfyPage.setup() | ||
| }) |
| test.beforeEach(async ({ comfyPage }) => { | ||
| await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true) | ||
| await comfyPage.workflow.loadWorkflow('widgets/image_compare_widget') | ||
| await comfyPage.vueNodes.waitForNodes() |
There was a problem hiding this comment.
Why is this one going the other direction?
| @@ -88,7 +88,6 @@ async function setLocaleAndWaitForWorkflowReload( | |||
| test.describe('Node Help', { tag: ['@slow', '@ui'] }, () => { | |||
| test.beforeEach(async ({ comfyPage }) => { | |||
| await comfyPage.setup() | |||
There was a problem hiding this comment.
+1, assuming this always happens via the fixture.
DrJKL
left a comment
There was a problem hiding this comment.
If you want to do the extra beforeEach/setup/waitForNodes cleanup as a follow-up, that's cool too.
|
Will double check all the remaining ones and other feedback in a follow up, I think they were all required due to nested describes |
## Summary Simplifies test setup for common settings ## Changes - **What**: - add vue-nodes tag to auto enable nodes 2.0 - remove UseNewMenu Top as this is default ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11184-test-Simplify-vue-node-menu-test-setup-3416d73d3650815487e0c357d28761fe) by [Unito](https://www.unito.io)
…re (#11195) ## Summary Follow-up cleanup for #11184 — removes redundant test setup calls that the `@vue-nodes` fixture now handles. ## Changes - **What**: Remove 40 lines of redundant `setSetting`, `setup()`, and `waitForNodes()` calls across 11 test files - `UseNewMenu: 'Top'` calls (already fixture default) - `setup()` + `waitForNodes()` on default workflow (fixture already does this for `@vue-nodes`) - Page reload in `subgraphZeroUuid` (fixture applies VueNodes.Enabled server-side before navigation) ## Review Focus Each removal was verified against the fixture's `setupSettings()` defaults (ComfyPage.ts:420-442) and the `@vue-nodes` auto-setup (lines 454-456). Tests that call `setup()`/`waitForNodes()` after `loadWorkflow()` or `page.evaluate()` were intentionally kept. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11195-test-remove-redundant-setup-settings-now-handled-by-vue-nodes-fixture-3416d73d36508154827df116a97e9130) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
… tag, retrying assertion
- Replace manual page.evaluate subgraph navigation with enterSubgraph('5')
- Use @vue-nodes tag (from #11184) instead of manual beforeEach setting
- Replace expect.poll with comfyExpect retrying assertion per Playwright best practices
## Summary Simplifies test setup for common settings ## Changes - **What**: - add vue-nodes tag to auto enable nodes 2.0 - remove UseNewMenu Top as this is default ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11184-test-Simplify-vue-node-menu-test-setup-3416d73d3650815487e0c357d28761fe) by [Unito](https://www.unito.io)
…re (#11195) ## Summary Follow-up cleanup for #11184 — removes redundant test setup calls that the `@vue-nodes` fixture now handles. ## Changes - **What**: Remove 40 lines of redundant `setSetting`, `setup()`, and `waitForNodes()` calls across 11 test files - `UseNewMenu: 'Top'` calls (already fixture default) - `setup()` + `waitForNodes()` on default workflow (fixture already does this for `@vue-nodes`) - Page reload in `subgraphZeroUuid` (fixture applies VueNodes.Enabled server-side before navigation) ## Review Focus Each removal was verified against the fixture's `setupSettings()` defaults (ComfyPage.ts:420-442) and the `@vue-nodes` auto-setup (lines 454-456). Tests that call `setup()`/`waitForNodes()` after `loadWorkflow()` or `page.evaluate()` were intentionally kept. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11195-test-remove-redundant-setup-settings-now-handled-by-vue-nodes-fixture-3416d73d36508154827df116a97e9130) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
## Summary Simplifies test setup for common settings ## Changes - **What**: - add vue-nodes tag to auto enable nodes 2.0 - remove UseNewMenu Top as this is default ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11184-test-Simplify-vue-node-menu-test-setup-3416d73d3650815487e0c357d28761fe) by [Unito](https://www.unito.io)
…re (#11195) ## Summary Follow-up cleanup for #11184 — removes redundant test setup calls that the `@vue-nodes` fixture now handles. ## Changes - **What**: Remove 40 lines of redundant `setSetting`, `setup()`, and `waitForNodes()` calls across 11 test files - `UseNewMenu: 'Top'` calls (already fixture default) - `setup()` + `waitForNodes()` on default workflow (fixture already does this for `@vue-nodes`) - Page reload in `subgraphZeroUuid` (fixture applies VueNodes.Enabled server-side before navigation) ## Review Focus Each removal was verified against the fixture's `setupSettings()` defaults (ComfyPage.ts:420-442) and the `@vue-nodes` auto-setup (lines 454-456). Tests that call `setup()`/`waitForNodes()` after `loadWorkflow()` or `page.evaluate()` were intentionally kept. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11195-test-remove-redundant-setup-settings-now-handled-by-vue-nodes-fixture-3416d73d36508154827df116a97e9130) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
## Summary Simplifies test setup for common settings ## Changes - **What**: - add vue-nodes tag to auto enable nodes 2.0 - remove UseNewMenu Top as this is default ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11184-test-Simplify-vue-node-menu-test-setup-3416d73d3650815487e0c357d28761fe) by [Unito](https://www.unito.io)
…re (#11195) ## Summary Follow-up cleanup for #11184 — removes redundant test setup calls that the `@vue-nodes` fixture now handles. ## Changes - **What**: Remove 40 lines of redundant `setSetting`, `setup()`, and `waitForNodes()` calls across 11 test files - `UseNewMenu: 'Top'` calls (already fixture default) - `setup()` + `waitForNodes()` on default workflow (fixture already does this for `@vue-nodes`) - Page reload in `subgraphZeroUuid` (fixture applies VueNodes.Enabled server-side before navigation) ## Review Focus Each removal was verified against the fixture's `setupSettings()` defaults (ComfyPage.ts:420-442) and the `@vue-nodes` auto-setup (lines 454-456). Tests that call `setup()`/`waitForNodes()` after `loadWorkflow()` or `page.evaluate()` were intentionally kept. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11195-test-remove-redundant-setup-settings-now-handled-by-vue-nodes-fixture-3416d73d36508154827df116a97e9130) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
Summary
Simplifies test setup for common settings
Changes
┆Issue is synchronized with this Notion page by Unito