Repository navigation
fix: disable pointer events on non-visible DOM widget overlays - #11063
Conversation
When a node is collapsed, DOM widget overlays could intercept pointer events during the timing gap between canvas state update and Vue DOM update. Adding !widgetState.visible to the pointerEvents condition in composeStyle() prevents this by immediately setting pointer-events to none when the widget becomes invisible. Also restores click-to-expand in the E2E test, removing the programmatic workaround from PR #10967. Fixes #11006
📝 WalkthroughWalkthroughThe changes fix an issue where DOM widget overlays intercept pointer events on collapsed nodes. They update the DOM widget styling to disable pointer events when a widget is not visible, removing the need for a programmatic workaround in the interaction test. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1027 passed, 0 failed · 2 flaky📊 Browser Reports
|
📦 Bundle: 5.13 MB gzip 🟢 -176 BDetailsSummary
Category Glance App Entry Points — 22.3 kB (baseline 22.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.2 MB (baseline 1.2 MB) • 🔴 +32 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 482 kB (baseline 482 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 109 kB (baseline 109 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 60.3 kB (baseline 60.3 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 2.98 MB (baseline 2.98 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 339 kB (baseline 339 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 14 unchanged Vendor & Third-Party — 9.8 MB (baseline 9.8 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.55 MB (baseline 8.55 MB) • ⚪ 0 BBundles that do not match a named category
Status: 56 added / 56 removed / 79 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-04-10T05:46:30.202Z",
"gitSha": "c7667ae977aa1101c334eeb3b291315d8431baac",
"branch": "fix/11006-collapsed-dom-widget-pointer",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.3379999999433,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.127999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.76000000000005,
"heapDeltaBytes": 20088828,
"heapUsedBytes": 62584532,
"domNodes": 14,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 15.093000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2002.6659999999765,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.1,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.25500000000005,
"heapDeltaBytes": 20334104,
"heapUsedBytes": 63164084,
"domNodes": 22,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 22.005,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2004.3130000001383,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.345999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.527,
"heapDeltaBytes": 20015660,
"heapUsedBytes": 63191172,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 13.922999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2018.7120000000505,
"styleRecalcs": 82,
"styleRecalcDurationMs": 43.533,
"layouts": 12,
"layoutDurationMs": 3.648,
"taskDurationMs": 951.468,
"heapDeltaBytes": 16707904,
"heapUsedBytes": 59156256,
"domNodes": 66,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 131.132,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1987.5869999999622,
"styleRecalcs": 80,
"styleRecalcDurationMs": 40.172,
"layouts": 12,
"layoutDurationMs": 3.311,
"taskDurationMs": 922.434,
"heapDeltaBytes": 16671816,
"heapUsedBytes": 59170008,
"domNodes": 66,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 128.922,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2017.090000000053,
"styleRecalcs": 81,
"styleRecalcDurationMs": 40.416999999999994,
"layouts": 12,
"layoutDurationMs": 3.119,
"taskDurationMs": 928.4559999999999,
"heapDeltaBytes": 16693252,
"heapUsedBytes": 59273164,
"domNodes": 67,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 129.73100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1712.3820000000478,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.584999999999997,
"layouts": 6,
"layoutDurationMs": 0.7280000000000001,
"taskDurationMs": 290.06200000000007,
"heapDeltaBytes": 15690312,
"heapUsedBytes": 67210568,
"domNodes": 78,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 22.875,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1743.7009999999873,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.448999999999998,
"layouts": 6,
"layoutDurationMs": 0.66,
"taskDurationMs": 289.62100000000004,
"heapDeltaBytes": 24691416,
"heapUsedBytes": 67474832,
"domNodes": 77,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 22.701000000000008,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1749.7799999998733,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.262,
"layouts": 6,
"layoutDurationMs": 0.6589999999999998,
"taskDurationMs": 293.98999999999995,
"heapDeltaBytes": 24941260,
"heapUsedBytes": 67895068,
"domNodes": 79,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 22.558999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 561.2919999999804,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.622,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.624,
"heapDeltaBytes": 6538452,
"heapUsedBytes": 49347976,
"domNodes": 20,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 64.808,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 513.5119999999915,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.406999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.52500000000003,
"heapDeltaBytes": 6143196,
"heapUsedBytes": 49082936,
"domNodes": 22,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 64.207,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 533.5270000000492,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.908,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.66599999999994,
"heapDeltaBytes": 6561444,
"heapUsedBytes": 49068720,
"domNodes": 21,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 64.819,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2020.64299999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.315,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.56199999999995,
"heapDeltaBytes": 13662308,
"heapUsedBytes": 67510640,
"domNodes": -258,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 88.37700000000001,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2030.7150000001002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.431000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.4000000000001,
"heapDeltaBytes": 3326152,
"heapUsedBytes": 55865672,
"domNodes": -261,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 86.08499999999998,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2055.7699999999386,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.447000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.7760000000001,
"heapDeltaBytes": 4607536,
"heapUsedBytes": 55354412,
"domNodes": -255,
"jsHeapTotalBytes": 15659008,
"scriptDurationMs": 99.23500000000001,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2134.9870000000237,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.048000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1049.1399999999999,
"heapDeltaBytes": 18607860,
"heapUsedBytes": 70680892,
"domNodes": -257,
"jsHeapTotalBytes": 17960960,
"scriptDurationMs": 393.337,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2144.1330000000107,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.316999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1085.7009999999998,
"heapDeltaBytes": 17721676,
"heapUsedBytes": 71439816,
"domNodes": -260,
"jsHeapTotalBytes": 18485248,
"scriptDurationMs": 419.897,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2122.583000000077,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.576000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1041.4080000000001,
"heapDeltaBytes": 18026020,
"heapUsedBytes": 75568824,
"domNodes": -261,
"jsHeapTotalBytes": 19038208,
"scriptDurationMs": 382.168,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3167.1709999999393,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.319999999999997,
"layouts": 60,
"layoutDurationMs": 7.33,
"taskDurationMs": 1259.504,
"heapDeltaBytes": 11042612,
"heapUsedBytes": 66887796,
"domNodes": -263,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 474.029,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3162.9159999999956,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.566,
"layouts": 60,
"layoutDurationMs": 7.107,
"taskDurationMs": 1324.554,
"heapDeltaBytes": 11321388,
"heapUsedBytes": 67505080,
"domNodes": -262,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 506.9110000000001,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3168.3959999998024,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.56,
"layouts": 60,
"layoutDurationMs": 7.119,
"taskDurationMs": 1286.17,
"heapDeltaBytes": 10995544,
"heapUsedBytes": 67074596,
"domNodes": -265,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 485.546,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2070.10200000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.727000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.56199999999995,
"heapDeltaBytes": 3619932,
"heapUsedBytes": 57759892,
"domNodes": -260,
"jsHeapTotalBytes": 15503360,
"scriptDurationMs": 88.35199999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2027.9359999999542,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.328999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.278,
"heapDeltaBytes": 4140040,
"heapUsedBytes": 56784328,
"domNodes": -259,
"jsHeapTotalBytes": 16707584,
"scriptDurationMs": 93.839,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2073.079000000007,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.838000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.8850000000001,
"heapDeltaBytes": 4601076,
"heapUsedBytes": 57770600,
"domNodes": -259,
"jsHeapTotalBytes": 15822848,
"scriptDurationMs": 99.928,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.8589999999685,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.467000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.853,
"heapDeltaBytes": 6998136,
"heapUsedBytes": 49700644,
"domNodes": 22,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 114.809,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 552.1299999999201,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.107,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 342.671,
"heapDeltaBytes": 6512100,
"heapUsedBytes": 49729612,
"domNodes": 23,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 120.955,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 524.9360000000252,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.303999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.971,
"heapDeltaBytes": 6744740,
"heapUsedBytes": 49551060,
"domNodes": 24,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 118.26999999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2021.178999999961,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.593000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.377,
"heapDeltaBytes": 20170384,
"heapUsedBytes": 63325816,
"domNodes": 23,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 18.694999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2003.1920000000127,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.277,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.298,
"heapDeltaBytes": 19847352,
"heapUsedBytes": 63127136,
"domNodes": 22,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 17.337000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.3930000000837,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.827999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.72,
"heapDeltaBytes": 19883924,
"heapUsedBytes": 62975772,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 16.628999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2022.3320000000058,
"styleRecalcs": 89,
"styleRecalcDurationMs": 48.42,
"layouts": 16,
"layoutDurationMs": 4.534,
"taskDurationMs": 922.782,
"heapDeltaBytes": 11785520,
"heapUsedBytes": 56245676,
"domNodes": 75,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 100.268,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2014.9379999999155,
"styleRecalcs": 88,
"styleRecalcDurationMs": 48.173,
"layouts": 16,
"layoutDurationMs": 4.632,
"taskDurationMs": 920.2780000000001,
"heapDeltaBytes": 11857968,
"heapUsedBytes": 54964264,
"domNodes": 74,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 101.832,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1967.3090000001139,
"styleRecalcs": 84,
"styleRecalcDurationMs": 45.65,
"layouts": 16,
"layoutDurationMs": 4.332,
"taskDurationMs": 877.3919999999999,
"heapDeltaBytes": 13493296,
"heapUsedBytes": 62849128,
"domNodes": 73,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 94.652,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8236.247000000049,
"styleRecalcs": 251,
"styleRecalcDurationMs": 42.971999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3714.683,
"heapDeltaBytes": 23588716,
"heapUsedBytes": 74280596,
"domNodes": -254,
"jsHeapTotalBytes": 21368832,
"scriptDurationMs": 1311.5030000000002,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8169.617000000017,
"styleRecalcs": 251,
"styleRecalcDurationMs": 42.108999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3486.081,
"heapDeltaBytes": 26384592,
"heapUsedBytes": 76312268,
"domNodes": -255,
"jsHeapTotalBytes": 20582400,
"scriptDurationMs": 1231.192,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8163.0889999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 42.60999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3570.079,
"heapDeltaBytes": 26128272,
"heapUsedBytes": 76518300,
"domNodes": -258,
"jsHeapTotalBytes": 20320256,
"scriptDurationMs": 1239.1450000000002,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 11696.552999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11687.044,
"heapDeltaBytes": -36328036,
"heapUsedBytes": 160092232,
"domNodes": -8331,
"jsHeapTotalBytes": 20537344,
"scriptDurationMs": 571.8399999999999,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11608.838999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11598.471,
"heapDeltaBytes": -48689152,
"heapUsedBytes": 159624268,
"domNodes": -8332,
"jsHeapTotalBytes": 19488768,
"scriptDurationMs": 553.7030000000001,
"eventListeners": -16463,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11591.35399999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11581.335000000001,
"heapDeltaBytes": -45985512,
"heapUsedBytes": 159176344,
"domNodes": -8333,
"jsHeapTotalBytes": 17915904,
"scriptDurationMs": 569.78,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14162.499000000025,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.873000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14144.203,
"heapDeltaBytes": -33527332,
"heapUsedBytes": 175239396,
"domNodes": -8331,
"jsHeapTotalBytes": 27529216,
"scriptDurationMs": 901.3689999999999,
"eventListeners": -16463,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14115.608000000066,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.174999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14098.412999999999,
"heapDeltaBytes": -45865248,
"heapUsedBytes": 148173428,
"domNodes": -8333,
"jsHeapTotalBytes": -1482752,
"scriptDurationMs": 893.289,
"eventListeners": -16486,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13810.375000000022,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.979999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13791.156,
"heapDeltaBytes": -33676368,
"heapUsedBytes": 173714844,
"domNodes": -8337,
"jsHeapTotalBytes": 25432064,
"scriptDurationMs": 832.5749999999999,
"eventListeners": -16457,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 471.11099999995076,
"styleRecalcs": 24,
"styleRecalcDurationMs": 27.993000000000002,
"layouts": 5,
"layoutDurationMs": 1.8570000000000002,
"taskDurationMs": 136.06400000000002,
"heapDeltaBytes": 4742508,
"heapUsedBytes": 49331572,
"domNodes": 191,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 32.117000000000004,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 104.1170000000875,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.847999999999999,
"layouts": 4,
"layoutDurationMs": 1.0510000000000004,
"taskDurationMs": 84.25399999999999,
"heapDeltaBytes": 2492476,
"heapUsedBytes": 46495416,
"domNodes": 142,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 23.706,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 115.04199999990306,
"styleRecalcs": 11,
"styleRecalcDurationMs": 16.986,
"layouts": 5,
"layoutDurationMs": 1.234,
"taskDurationMs": 97.79400000000001,
"heapDeltaBytes": 2826812,
"heapUsedBytes": 46775088,
"domNodes": 145,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 24.397000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #11063 +/- ##
=======================================
Coverage 43.23% 43.23%
=======================================
Files 1342 1342
Lines 68409 68411 +2
Branches 18901 18903 +2
=======================================
+ Hits 29574 29575 +1
- Misses 38245 38246 +1
Partials 590 590
🚀 New features to boost your workflow:
|
|
|
|
|
…idget overlays (#11063) (#11859) *PR Created by the Glary-Bot Agent* --- Manual backport of #11063 to `core/1.43` for inclusion in `v1.43.16`. Cherry-picked from upstream merge commit `4cf160d66`. ## Why When a node with DOM widget overlays (e.g. CLIPTextEncode) is collapsed, the overlay elements can intercept pointer events intended for the canvas collapse toggler, making click-to-expand unreliable. Adds `!widgetState.visible` to the `pointerEvents` condition in `composeStyle()`, immediately setting `pointer-events: none` when the widget becomes invisible — closing the timing gap before `v-show` applies `display: none`. Fixes upstream issue #11006. ## Conflict resolution - Skipped the change to `browser_tests/tests/interaction.spec.ts`. PR #11063 removed a programmatic-collapse workaround introduced by unrelated PR #10967 (which is **not** on `core/1.43`). On 1.43 the test uses an older `delay(1000) + click` form that doesn't need adjustment — the source fix in `DomWidget.vue` makes the second click reliable on its own. Kept the source + unit-test changes. ## Validation - `pnpm typecheck` ✅ - `pnpm test:unit -- run src/components/graph/widgets/DomWidget.test.ts` ✅ (2/2 passing) - `pnpm exec eslint <changed files>` ✅ (0 errors) - `pnpm exec oxfmt --check` ✅ (clean) Manual end-to-end verification not performed — DOM widget pointer-event timing requires live canvas+widget interaction, not feasible to reproduce reliably in headless. Source identical to upstream `4cf160d66`, baking on `main` for ~3 weeks through `v1.44.x`. Original PR: #11063 / Original commit: `4cf160d66` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11859-backport-core-1-43-fix-disable-pointer-events-on-non-visible-DOM-widget-overlays-11-3556d73d365081cab95ef32c17c0401e) by [Unito](https://www.unito.io) Co-authored-by: Christian Byrne <cbyrne@comfy.org>
## Problem When a node with DOM widget overlays (e.g. CLIPTextEncode) is collapsed, the overlay elements can intercept pointer events intended for the canvas collapse toggler, making click-to-expand unreliable. ## Root Cause `updateWidgets()` runs during `onDrawForeground` (canvas render cycle) and sets `widgetState.visible = false` for collapsed nodes. `v-show` then hides the element with `display: none`. However, there is a timing gap between the canvas state change and Vue's DOM update — during this gap the widget overlay still intercepts pointer events. ## Fix Add `!widgetState.visible` to the `pointerEvents` condition in `composeStyle()`. This immediately sets `pointer-events: none` when the widget becomes invisible, preventing event interception before `v-show` applies `display: none`. Also restores click-to-expand in the E2E test, removing the programmatic `node.collapse()` workaround from PR #10967. - Fixes #11006 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11063-fix-disable-pointer-events-on-non-visible-DOM-widget-overlays-33e6d73d36508179a83cd47121cf933f) by [Unito](https://www.unito.io) (cherry picked from commit 4cf160d)
## Problem When a node with DOM widget overlays (e.g. CLIPTextEncode) is collapsed, the overlay elements can intercept pointer events intended for the canvas collapse toggler, making click-to-expand unreliable. ## Root Cause `updateWidgets()` runs during `onDrawForeground` (canvas render cycle) and sets `widgetState.visible = false` for collapsed nodes. `v-show` then hides the element with `display: none`. However, there is a timing gap between the canvas state change and Vue's DOM update — during this gap the widget overlay still intercepts pointer events. ## Fix Add `!widgetState.visible` to the `pointerEvents` condition in `composeStyle()`. This immediately sets `pointer-events: none` when the widget becomes invisible, preventing event interception before `v-show` applies `display: none`. Also restores click-to-expand in the E2E test, removing the programmatic `node.collapse()` workaround from PR #10967. - Fixes #11006 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11063-fix-disable-pointer-events-on-non-visible-DOM-widget-overlays-33e6d73d36508179a83cd47121cf933f) by [Unito](https://www.unito.io) (cherry picked from commit 4cf160d)
…1926) *PR Created by the Glary-Bot Agent* --- ## Summary Consolidated backport of bug fixes from `origin/main` (which feeds `v1.44.16`) onto `cloud/1.43`. Cherry-picks every applicable `fix:` commit identified in the prior backport-gap audit so `cloud/1.43` doesn't keep falling further behind. - **35 fixes cherry-picked** (out of 49 audited; 14 dropped — see "Dropped commits" below). - Verification (run on this branch): `pnpm typecheck` clean, `pnpm knip` clean, `pnpm lint` 0 errors (warning count 2976 vs cloud/1.43 baseline 2877 — delta is from new test files brought in by the picks, not new lint errors), `pnpm test:unit` 7842 passed / 8 skipped. This is a single consolidated PR per request — not a per-fix backport stream. Each commit has the original SHA recorded via `cherry picked from commit ...` so individual reverts remain possible. ## Picked fixes (35) App / runtime stability - `#10995` auto fit-to-view on first subgraph entry - `#11240` re-sync collapsed node slot positions after subgraph fitView - `#10849` store promoted widget values per SubgraphNode instance - `#10361` place cloned node above original in Vue renderer - `#9935` trigger Vue reactivity on output slot type changes in matchType - `#11541` stop duplicate node creation when dropping image on Vue nodes - `#11779` ensure escape key/graph navigation cancels ghost node placement - `#11063` disable pointer events on non-visible DOM widget overlays - `#11295` include focusMode in splitter refresh key to prevent panel resize - `#11487` render edit pencil icon correctly in properties panel header - `#11296` remove hover dimming overlay on image nodes - `#11542` keep finished badge fully opaque in ProgressToastItem - `#11713` search bar layout and autocomplete clipping on Desktop at small sizes - `#11570` dedupe keybinding modifier display - `#11144` fix(vite): hide git rev-parse window on Windows Cloud / subscription / workspace - `#11130` track workspace subscription success on immediate subscribe - `#11622` dedupe pending checkout attempt construction - `#11463` show credits in legacy user popover on non-cloud distributions - `#11636` enable Chrome password autofill on signup form - `#11520` fix(manager): migrate 4 endpoints GET→POST for CSRF hardening (security) - `#11425` remove deleted workflow from search results in sidebar Assets / blueprints - `#11700` route context menu Download through downloadMultipleAssets - `#11502` render asset fixtures in AssetBrowserModal stories - `#11759` hide blueprint node id in search - `#11573` translate blueprint label Telemetry / progress / feature flags - `#11174` guard progress_text before canvas init - `#11384` route progress_text feature flag check through getDevOverride - `#11417` reset file input value after selection to allow same-file reupload Load3D - `#11265` fix(load3d): restore missed hover state when viewer init is async - `#11546` load3d used wrong i18n key, add test - `#11359` chain Load3D node lifecycle callbacks to preserve widget cleanup GLSL preview - `#11010` resolve incorrect GLSL live preview for non-primitive widget types - `#11517` add GLSL live update when custom size is changed Misc - `#10374` consolidate `--color-coral-red` variables into `--color-coral` - `#11283` reduce noise in coverage Slack notifications ## Dropped commits (14) — need separate manual backport These cherry-picks pulled in code that depends on infrastructure not present on `cloud/1.43`, or required permissions a bot account does not hold. Individual backport tickets recommended: | PR | Subject | Blocker | |---|---|---| | #11224 | fix(ci): resolve pnpm version in release workflow for frontend/ checkout path | touches `.github/workflows/release-biweekly-comfyui.yaml` — bot lacks `workflows` permission. Also depends on prerequisite #11223 (patch-release support) not on cloud/1.43. Needs human-authored backport. | | #11329 | prevent duplicate prepareForSave + conflicting is_new telemetry on self-overwrite Save As | depends on `ChangeTracker.prepareForSave` API added by #10816 / #11328 (refactors not on cloud/1.43) | | #11358 | render dates in Secrets panel for timestamps with >3 fractional-second digits | depends on `formatToISOWithSeconds` and other utils in `dateTimeUtil.ts` not on cloud/1.43 | | #11539 | cancel-subscription dialog renders Invalid Date for ISO fractional seconds | depends on `parseIsoDateSafe` from #11358 | | #11480 | avoid escaped secret date labels | builds on #11358's SecretListItem changes | | #11524 | localize secret date labels | builds on #11358's SecretListItem changes | | #11321 | show asset display names in bulk delete confirmation | brings in `useMediaAssetActions.test.ts` requiring `downloadAssets` API not on cloud/1.43 | | #11610 | naming strategy for multi-job asset exports | same `useMediaAssetActions` test infrastructure | | #11737 | report total file count, not job count, in ZIP export toast | same `useMediaAssetActions` test infrastructure | | #11538 | resolve mesh widget thumbnails via asset preview API | depends on `FormDropdownMenuItemProps` type, `useWidgetSelectItems` not on cloud/1.43 | | #11492 | use getAssetFilename in asset browser to avoid showing hashes | same `useWidgetSelectItems` infrastructure | | #11836 | fix(load3d): dispose THREE.Points GPU resources in clearModel() | brings in `SceneModelManager.test.ts` referencing `ModelAdapter` infrastructure not on cloud/1.43 (memory-leak fix — manual backport recommended) | | #11807 | fix(load3d): suppress error toast on 404 when loading output model file | brings in `LoaderManager.ts` rewritten on main with `ModelAdapter` not on cloud/1.43 | | #11164 | enable playwright/no-force-option lint rule | requires oxlint upgrade with playwright plugin not pinned in cloud/1.43 | ## Conflict resolution notes Most picks applied cleanly. Conflicts encountered: - **Test-only / snapshot-only conflicts** — resolved with `-X theirs` (cloud/1.43 just doesn't have those test files yet). - **Modify/delete conflicts** (test file deleted on cloud/1.43, modified by the fix on main) — accepted the incoming version. - **`src/components/searchbox/v2/NodeSearchListItem.test.ts`** — pulled in by #11759 but referenced `ComfyNodeDefImpl` shape only on main. Removed the test file from the backport commit so the runtime fix lands; test should be rewritten/backported separately if desired. - **`browser_tests/tests/vueNodes/glslPreview.spec.ts` and `browser_tests/tests/subgraph/subgraphBreadcrumb.spec.ts`** — pulled in by #11517 / #11573 but reference helpers (`@e2e/fixtures/helpers/ExecutionHelper`, `SubgraphBreadcrumbHelper`) not on cloud/1.43. Removed the spec files from the respective backport commits; runtime fixes preserved. ## Out-of-scope review note Code review flagged a behavioral concern in `subgraphNavigationStore.ts:142-153,173-177` (`restoreViewport()` may auto-fit on first root-graph load even when the workflow already had a viewport). This is **pre-existing on `main`** (the cherry-picked code is identical to `origin/main` for that file region) — not introduced by this PR. Filing a separate ticket is recommended; not in scope for a backport batch. ## How to validate locally ```bash git checkout glary/cloud-1.43-batch-backport-fixes pnpm install --frozen-lockfile pnpm typecheck # clean pnpm knip # clean pnpm lint # 0 errors pnpm test:unit # 7842 passed, 8 skipped ``` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11926-backport-cloud-1-43-consolidated-bug-fixes-from-main-v1-44-16-3566d73d3650812393d3e0ea79ab9a14) by [Unito](https://www.unito.io) --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Terry Jia <terryjia88@gmail.com> Co-authored-by: Dante <bunggl@naver.com> Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com> Co-authored-by: dante <dante@danteui-MacStudio.local> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: guill <jacob.e.segal@gmail.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: pythongosssss <125205205+pythongosssss@users.noreply.github.com> Co-authored-by: Simon Pinfold <synap5e@users.noreply.github.com> Co-authored-by: comfydesigner <alextov@comfy.org> Co-authored-by: Alex <alex@Mac.lan> Co-authored-by: Robin Huang <robin.j.huang@gmail.com> Co-authored-by: Kelly Yang <124ykl@gmail.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Dr.Lt.Data <128333288+ltdrdata@users.noreply.github.com>
|
|
## Problem When a node with DOM widget overlays (e.g. CLIPTextEncode) is collapsed, the overlay elements can intercept pointer events intended for the canvas collapse toggler, making click-to-expand unreliable. ## Root Cause `updateWidgets()` runs during `onDrawForeground` (canvas render cycle) and sets `widgetState.visible = false` for collapsed nodes. `v-show` then hides the element with `display: none`. However, there is a timing gap between the canvas state change and Vue's DOM update — during this gap the widget overlay still intercepts pointer events. ## Fix Add `!widgetState.visible` to the `pointerEvents` condition in `composeStyle()`. This immediately sets `pointer-events: none` when the widget becomes invisible, preventing event interception before `v-show` applies `display: none`. Also restores click-to-expand in the E2E test, removing the programmatic `node.collapse()` workaround from PR #10967. - Fixes #11006 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11063-fix-disable-pointer-events-on-non-visible-DOM-widget-overlays-33e6d73d36508179a83cd47121cf933f) by [Unito](https://www.unito.io)
Problem
When a node with DOM widget overlays (e.g. CLIPTextEncode) is collapsed, the overlay elements can intercept pointer events intended for the canvas collapse toggler, making click-to-expand unreliable.
Root Cause
updateWidgets()runs duringonDrawForeground(canvas render cycle) and setswidgetState.visible = falsefor collapsed nodes.v-showthen hides the element withdisplay: none. However, there is a timing gap between the canvas state change and Vue's DOM update — during this gap the widget overlay still intercepts pointer events.Fix
Add
!widgetState.visibleto thepointerEventscondition incomposeStyle(). This immediately setspointer-events: nonewhen the widget becomes invisible, preventing event interception beforev-showappliesdisplay: none.Also restores click-to-expand in the E2E test, removing the programmatic
node.collapse()workaround from PR #10967.┆Issue is synchronized with this Notion page by Unito