Skip to content

style: neutral gray palette for the dark theme - #1996

Merged
benceruleanlu merged 1 commit into
Comfy-Org:mainfrom
mariana953:mar/graphite-palette
Nov 11, 2026
Merged

benceruleanlu merged 1 commit into
Comfy-Org:mainfrom
mariana953:mar/graphite-palette

Conversation

@mariana953

@mariana953 mariana953 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

PR stack

main → #1996 (this PR) → #1992 → #1998 → #1999 → #2000 → #2001 → #2002 → #2003

Base: main. Next: #1992.

Restacked onto current main after #2009 added Home. The closed #1981 is no longer a dependency; its Home/Apps placeholders and Generated Files gallery are excluded. This PR keeps its original UI changes.

These PRs originate in Mar's fork. Each dependent PR targets a matching upstream branch at the preceding PR's head so GitHub shows only its own changes. Merge in the order above. After merging a parent, rebase the remaining stack onto main and retarget its first PR to main. After any parent changes, restack its descendants and update the matching upstream base branches.

ELI5

The app's dark grays had a faint blue tint, like a white shirt washed with a blue sock. This PR removes the tint so the grays are truly neutral, matching the final design palette, without making anything lighter or darker.

Summary

  • Dark theme grays move from the tinted palette (hue 285, small chroma) to pure neutral gray: every oklch(L C 285) becomes oklch(L 0 0), keeping the same lightness.
  • Title bar and panel background go from #050506 to #050505 for the same reason.
  • Colors only. No layout, behavior or light theme changes.

Changes

  • src/renderer/src/assets/design-system-theme.css: background, foreground, card, popover, muted/subtle foreground, window/sidebar/content backgrounds, card hover.
  • src/renderer/src/assets/main.css: the dark --neutral-* scale and --terminal-bg.
  • src/main/lib/theme.ts, src/renderer/panel.html: title bar / panel background.

Before / after

Historical screenshots captured before this PR was restacked onto main.

Builds before Builds after
Apps before Apps after

Test plan

  • Typecheck, Prettier and unit tests pass (TitlePopupApp.test.ts flaked once in three runs, unrelated to colors)
  • Captured Home, Apps, Builds and Build details on feat(ui): add an Assets page to the sidebar with a generated files gallery #1981 with and without this PR: sampled pixels go from blue-leaning (b−r = 1–2) to neutral (b−r = 0), same lightness
  • Open the app in dark mode and check the sidebar, content and cards read as neutral gray
  • Light theme unchanged
  • Not behind a feature flag: a color token adjustment with no new behavior

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

Biome (2.5.15)

src/renderer/src/assets/design-system-theme.css

File contains syntax errors that prevent linting: Line 18: Tailwind-specific syntax is disabled.; Line 121: Tailwind-specific syntax is disabled.

@mariana953
mariana953 changed the base branch from main to PabloWiedemann/sidebar-tabs-assets November 10, 2026 17:05
@mariana953
mariana953 marked this pull request as ready for review November 11, 2026 01:21
@mariana953
mariana953 requested review from a team as code owners November 11, 2026 01:21
Drop the hue-285 tint from the dark grays (same lightness, zero chroma) so the app reads as the Graphite palette the design uses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants