Skip to content

feat(ui): ⋯ button and grouped actions for More on the build page - #1998

Merged
benceruleanlu merged 3 commits into
Comfy-Org:codex/mar-restack-1992from
mariana953:mar/build-details-header
Nov 11, 2026
Merged

benceruleanlu merged 3 commits into
Comfy-Org:codex/mar-restack-1992from
mariana953:mar/build-details-header

Conversation

@mariana953

@mariana953 mariana953 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

PR stack

main → #1996 → #1992 → #1998 (this PR) → #1999 → #2000 → #2001 → #2002 → #2003

Base: #1992 (codex/mar-restack-1992). Next: #1999.

Restacked onto current main after #2009 added Home. The closed #1981 is no longer a dependency; its Home/Apps placeholders and Generated Files gallery are excluded. This PR keeps its original UI changes.

These PRs originate in Mar's fork. Each dependent PR targets a matching upstream branch at the preceding PR's head so GitHub shows only its own changes. Merge in the order above. After merging a parent, rebase the remaining stack onto main and retarget its first PR to main. After any parent changes, restack its descendants and update the matching upstream base branches.

ELI5

On a build's page, the menu next to Start was a wide "More ▾" button. The design uses a small ⋯ button instead, the same one the Builds page already uses on each build, so the header is lighter and consistent. The menu it opens has the same actions; only Uninstall stays red, with a divider above Forget and Uninstall.

Summary

  • Build details header: the More menu trigger becomes a ⋯ icon button (size="icon", Ellipsis), keeping its aria-label "More".
  • The picker popup still shows the labelled "More ▾" button: the change only applies on the page (isPage).
  • In the menu, Forget no longer shows in red (only Uninstall does) and a divider separates Forget and Uninstall from the rest, as in the design.
  • In page mode the tabs no longer render an empty icon slot, so each label sits centred in its pill.
  • Menu items, order, conditions and behaviour are unchanged.

Before / after

Historical screenshots captured before this PR was restacked onto main.

Header before Header after
Menu open before Menu open after

Test plan

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 37f9e247-a5a5-419f-9422-c529b7d03dde

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@mariana953 mariana953 changed the title feat(ui): use an icon button for More on the build page feat(ui): ⋯ button and grouped actions for More on the build page Nov 10, 2026
@mariana953
mariana953 marked this pull request as ready for review November 11, 2026 01:21
@mariana953
mariana953 requested review from a team as code owners November 11, 2026 01:21
mariana953 and others added 3 commits November 11, 2026 08:13
On the build details page the header's More menu now opens from a ⋯ icon
button, matching the design. The menu, its actions and the picker popup's
labelled More button are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e menu

Forget reads as a normal action; Uninstall stays the only red item.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@benceruleanlu
benceruleanlu merged commit ebd7a00 into Comfy-Org:codex/mar-restack-1992 Nov 11, 2026
4 checks passed
benceruleanlu added a commit that referenced this pull request Nov 11, 2026
… main (#2013)

* feat(ui): show icons in the build actions menu

The Builds page menu now draws an icon beside each action, matching the
design: Manage, Update, Migrate, Duplicate, Show in Finder, Export and
Restore Snapshot, Promote to workspace, Stop and Uninstall. Items, order,
conditions and behaviour are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(ui): use an icon button for More on the build page

On the build details page the header's More menu now opens from a ⋯ icon
button, matching the design. The menu, its actions and the picker popup's
labelled More button are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(ui): group Forget and Uninstall under a divider in the build More menu

Forget reads as a normal action; Uninstall stays the only red item.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(ui): center the labels in the build page tabs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Mariana Martinho <mariana@comfy.org>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
mariana953 added a commit to mariana953/Comfy-Desktop that referenced this pull request Nov 12, 2026
…rg#1992, Comfy-Org#1998)

The Builds ⋯ menu and the build page's More say Duplicate, not
Duplicate Instance, and More draws it with Desktop's copy icon.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants