Repository navigation
feat(ui): ⋯ button and grouped actions for More on the build page - #1998
Merged
benceruleanlu merged 3 commits intoNov 11, 2026
Merged
benceruleanlu merged 3 commits into
benceruleanlu merged 3 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
mariana953
marked this pull request as ready for review
November 11, 2026 01:21
3 of 6 tasks
On the build details page the header's More menu now opens from a ⋯ icon button, matching the design. The menu, its actions and the picker popup's labelled More button are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e menu Forget reads as a normal action; Uninstall stays the only red item. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
benceruleanlu
force-pushed
the
mar/build-details-header
branch
from
November 11, 2026 16:13
c3c056a to
2432366
Compare
This was referenced Nov 11, 2026
benceruleanlu
changed the base branch from
PabloWiedemann/sidebar-tabs-assets
to
codex/mar-restack-1992
November 11, 2026 16:14
This was referenced Nov 11, 2026
benceruleanlu
approved these changes
Nov 11, 2026
benceruleanlu
merged commit Nov 11, 2026
ebd7a00
into
Comfy-Org:codex/mar-restack-1992
4 checks passed
benceruleanlu
added a commit
that referenced
this pull request
Nov 11, 2026
… main (#2013) * feat(ui): show icons in the build actions menu The Builds page menu now draws an icon beside each action, matching the design: Manage, Update, Migrate, Duplicate, Show in Finder, Export and Restore Snapshot, Promote to workspace, Stop and Uninstall. Items, order, conditions and behaviour are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(ui): use an icon button for More on the build page On the build details page the header's More menu now opens from a ⋯ icon button, matching the design. The menu, its actions and the picker popup's labelled More button are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(ui): group Forget and Uninstall under a divider in the build More menu Forget reads as a normal action; Uninstall stays the only red item. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(ui): center the labels in the build page tabs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Mariana Martinho <mariana@comfy.org> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
mariana953
added a commit
to mariana953/Comfy-Desktop
that referenced
this pull request
Nov 12, 2026
…rg#1992, Comfy-Org#1998) The Builds ⋯ menu and the build page's More say Duplicate, not Duplicate Instance, and More draws it with Desktop's copy icon. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR stack
main→ #1996 → #1992 → #1998 (this PR) → #1999 → #2000 → #2001 → #2002 → #2003Base: #1992 (
codex/mar-restack-1992). Next: #1999.Restacked onto current main after #2009 added Home. The closed #1981 is no longer a dependency; its Home/Apps placeholders and Generated Files gallery are excluded. This PR keeps its original UI changes.
These PRs originate in Mar's fork. Each dependent PR targets a matching upstream branch at the preceding PR's head so GitHub shows only its own changes. Merge in the order above. After merging a parent, rebase the remaining stack onto
mainand retarget its first PR tomain. After any parent changes, restack its descendants and update the matching upstream base branches.ELI5
On a build's page, the menu next to Start was a wide "More ▾" button. The design uses a small ⋯ button instead, the same one the Builds page already uses on each build, so the header is lighter and consistent. The menu it opens has the same actions; only Uninstall stays red, with a divider above Forget and Uninstall.
Summary
size="icon",Ellipsis), keeping itsaria-label"More".isPage).Before / after
Historical screenshots captured before this PR was restacked onto main.
Test plan
TitlePopupApp.test.tsis flaky on feat(ui): add an Assets page to the sidebar with a generated files gallery #1981 too, unrelated)🤖 Generated with Claude Code