Skip to content

feat(ui): move tools into the ☰ menu and the ☰ to the right - #2007

Closed
mariana953 wants to merge 5 commits into
Comfy-Org:PabloWiedemann/sidebar-tabs-assetsfrom
mariana953:mar/tools-in-menu
Closed

mariana953 wants to merge 5 commits into
Comfy-Org:PabloWiedemann/sidebar-tabs-assetsfrom
mariana953:mar/tools-in-menu

Conversation

@mariana953

@mariana953 mariana953 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

Performance Tests and Benchmarks are developer tools, not places most people go every day. They had been promoted to their own "Tools" group in the sidebar; this puts them back in the ☰ menu where they used to live, so the sidebar only shows the main places: Home, Apps and Builds. The ☰ button also moves to the right end of the title bar, next to notifications, feedback and downloads.

Summary

  • Restore Performance Tests and Benchmarks in the title-bar ☰ menu, in their own group under Open Dashboard (same items, labels and handler they had before the platform redesign, Merge Desktop platform redesign into main #1976).
  • Move the ☰ button from the left of the title bar to its right end, after downloads, as in the design. Same button, same menu; the popup already clamps to the window edge.
  • Remove the Tools group from the dashboard sidebar. The sidebar keeps Home, Apps and Builds.
  • Drop the now unused sidebar.tools string (en, zh).
  • ☰ menu items match the filter menus on Apps and Benchmarks: design system item spacing and hover, labels start at the left edge, and a check shows on the right only for a checked item instead of reserving an empty column on the left.
  • Tests: menu item order, sidebar rows, and the What's New e2e now opens Performance Tests with navigatePanel instead of the sidebar row.

Context

Design decision from Mar and Pablo: tools go back to the ☰ menu, not the sidebar, and the ☰ sits on the right. Stacked on #1981 because that PR owns the sidebar rows.

Before / after

Before is the base branch (#1981). Screenshots use main's gray palette (#1996) applied locally: this branch is stacked on #1981, which predates it. The branch does not change the palette, so on main it renders gray.

Before After
Dashboard before after
☰ menu open before after

No functionality added or removed

  • The pages, routes and the menu handler (openChooserHostWindow(id)) are unchanged. As before the redesign, picking a tool from the menu opens it in a dashboard window; the existing tests that pin that behaviour stay as they are.

Test plan

  • comfyTitlePopup and popups suites (237)
  • TitleBarApp.test.ts (selectors now target the ☰ button by aria-haspopup, since it is no longer the first icon button), titlePopup.test.ts, AppSidebar.test.ts, PanelApp.test.ts (181), eslint, prettier, typecheck
  • e2e whats-new-keeps-page passes on macOS
  • Captured in the built app
  • Open both tools from the ☰ menu on the dashboard and on a running build

🤖 Generated with Claude Code

The platform redesign put both tools in a Tools group in the dashboard
sidebar and dropped them from the title-bar menu. Put them back in the menu
(same items and handler as before the redesign) and drop the Tools group,
so the sidebar keeps Home, Apps and Builds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@mariana953 mariana953 changed the title feat(ui): move Performance Tests and Benchmarks back to the title menu feat(ui): move tools into the ☰ menu and the ☰ to the right Nov 11, 2026
mariana953 and others added 2 commits November 11, 2026 05:16
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Items use the design system menu item spacing and hover, and the check
sits on the right only when an item is checked, so labels no longer
indent behind an empty icon column.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mariana953 mariana953 mentioned this pull request Nov 11, 2026
10 tasks done
@mariana953

Copy link
Copy Markdown
Contributor Author

Moved to #2016, based on main now that #1981 is closed. Same change.

@mariana953 mariana953 closed this Nov 11, 2026
benceruleanlu added a commit to mariana953/Comfy-Desktop that referenced this pull request Nov 12, 2026
* feat(ui): move tools into the ☰ menu and the ☰ to the right

Same change as Comfy-Org#2007, now based on main instead of the closed Comfy-Org#1981.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(ui): prevent compact title-bar controls overlapping the center pill

Allow the leading spacer to shrink in icons-only mode while keeping a 200px center track and a 16px gap before the trailing controls. Preserve the existing centered layout whenever there is enough room.

Validated formatting, targeted lint, renderer typecheck, 206 targeted tests, and 20 Chromium layout cases covering 800-1280px widths with and without zoom reset.

* fix(ui): keep the ☰ on the left and drop Open Dashboard from it

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(ui): open Performance Tests and Benchmarks in place on the dashboard

The ☰ items opened a new dashboard window on every click, even from the
dashboard itself, while the sidebar rows they replace switched the page in
place. On the dashboard they now switch the page; from a build window they
still open a dashboard window on that tool. Opening a tool from the
dashboard emits comfy.desktop.view.opened again, as the sidebar did.

Drop the install-flow routing in the ☰ handler (new-install, track,
load-snapshot, quick-install): no menu has produced those ids since Comfy-Org#767.

The new chooser e2e opens both tools through the real ☰ popup and checks
that no second window appears; it fails against the previous routing with 2
windows. The What's New spec reaches Performance Tests through the menu
instead of calling navigatePanel.

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>
Chroma01 pushed a commit to Chroma01/Comfy-Desktop that referenced this pull request Nov 13, 2026
…Org#2042)

* feat(ui): move tools into the ☰ menu and the ☰ to the right

Same change as Comfy-Org#2007, now based on main instead of the closed Comfy-Org#1981.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(ui): prevent compact title-bar controls overlapping the center pill

Allow the leading spacer to shrink in icons-only mode while keeping a 200px center track and a 16px gap before the trailing controls. Preserve the existing centered layout whenever there is enough room.

Validated formatting, targeted lint, renderer typecheck, 206 targeted tests, and 20 Chromium layout cases covering 800-1280px widths with and without zoom reset.

* fix(ui): keep the ☰ on the left and drop Open Dashboard from it

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(sidebar): list each build under Builds and open its page

The sidebar's Builds row becomes a group, as in the New UI proposal
(Comfy-Org#1903): an uppercase title that opens the Builds page, a + for New
build, and every build of the selected workspace below it, most
recently used first (the order Home and the build picker use).

A build row opens that build's page and never launches it. From
Performance Tests or Benchmarks it switches to the Builds screen first,
so the panel switch does not close the page it just opened. The open
build's row is the only lit row; on the Builds page the title is.

Each row shows the build's mark (laptop or cloud) and its name. A green
dot on the mark means live (Running, Always on); a red one means it
failed to start, with the reason in the row's tooltip. With no builds in
the workspace the group says "No builds yet". The collapsed rail keeps
the single Builds icon.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(sidebar): say when a build crashed, and close a build page that leaves scope

- The red dot's tooltip said "Failed to start" for every error, including
  builds that crashed after running. Crashes now read "Crashed (exit code N)"
  or "Crashed (SIGNAL)"; launch failures keep "Failed to start: reason".
- Switching workspace while a build page is open left that page up with no
  sidebar row or title lit. The page now closes and the Builds title is lit.
- A removed build's id stayed set, so if the build came back (a cloud
  refetch) its page reopened on its own. The id is now cleared when the build
  is gone or out of the selected workspace.
- Each row's status is computed once per render instead of four times.

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant