Skip to content

style(downloads): uppercase label and no divider lines in the downloads popup - #2012

Closed
mariana953 wants to merge 1 commit into
Comfy-Org:PabloWiedemann/sidebar-tabs-assetsfrom
mariana953:mar/downloads-popup
Closed

mariana953 wants to merge 1 commit into
Comfy-Org:PabloWiedemann/sidebar-tabs-assetsfrom
mariana953:mar/downloads-popup

Conversation

@mariana953

@mariana953 mariana953 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

The downloads popup was the only popup still drawn the old way: a bold title with a line under it and a line over the footer. Now it reads like the rest of the new UI: a small uppercase label on top, no divider lines, and the footer link behaves like a menu row.

Summary

  • Title becomes an uppercase section label (11px, letter-spaced, muted), the same style as the other section titles.
  • No divider lines under the header or over the footer; space separates them, per the "no lines" rule.
  • "View All Downloads" is a menu-style row: 32px high, 13px, same hover fill and radius as the ☰ menu items.
  • Download rows, progress, retry, close and the empty state are unchanged.

Context

Stacked on #1981 (Pablo's sidebar/tabs PR), like the other design-alignment PRs. Only DownloadsView.vue changes; the popup height is still measured from the header, list and footer, so it shrinks to fit.

Before / after

Before is the base branch (#1981). Screenshots use main's gray palette (#1996) applied locally: this branch is stacked on #1981, which predates it. The branch does not change the palette, so on main it renders gray.

Before After
before after

No functionality added or removed

Same markup hooks (.downloads-head, .downloads-title, .downloads-foot, .downloads-link), same handlers, same strings.

Test plan

  • comfyTitlePopup tests pass (107), eslint, prettier
  • Captured in the built app
  • With active and finished downloads, rows and progress look as before
  • View All Downloads opens the full downloads view

🤖 Generated with Claude Code

…ds popup

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 11, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@mariana953

Copy link
Copy Markdown
Contributor Author

Moved to #2017, based on main now that #1981 is closed. Same change.

@mariana953 mariana953 closed this Nov 11, 2026
benceruleanlu pushed a commit to mariana953/Comfy-Desktop that referenced this pull request Nov 11, 2026
…ds popup (Comfy-Org#2017)

Same change as Comfy-Org#2012, now based on main instead of the closed Comfy-Org#1981.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant