Skip to content

style(sidebar): one landscape on the log-in card, shorter line - #2003

Merged
benceruleanlu merged 2 commits into
Comfy-Org:mainfrom
mariana953:mar/signin-card-landscape
Nov 11, 2026
Merged

benceruleanlu merged 2 commits into
Comfy-Org:mainfrom
mariana953:mar/signin-card-landscape

Conversation

@mariana953

@mariana953 mariana953 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Base

Targets main directly and contains only this PR's changes. The changes from #1992 and #1998 are already on main through #2013. No temporary mirror branch is required.

ELI5

When you're logged out, the bottom of the sidebar invites you to log in. That card showed three pink-tinted portraits and a long sentence. Now it shows one landscape in its real colours and a short line, the version the design settled on.

Summary

  • The log-in card's picture is one landscape (hills-sunset.jpg, already in the repo) at 72px tall, in colour. It replaces the three-portrait strip with its multiply/lighten tint.
  • Hover keeps the same feel: the picture drifts up slightly and the Comfy mark lifts, with reduced-motion respected.
  • Copy: "Sync your work and run it on Comfy Cloud." becomes "Sync and run on Comfy Cloud" (en + zh).
  • The two portrait images it no longer uses are removed. Nothing else references them.
  • UI only: same sign-in action, same collapsed icon, same test ids.

Before / After

Before After
before after

Test plan

  • panel unit tests (162 passed), eslint, prettier
  • Captured in the built app
  • Log in from the card; the collapsed sidebar still shows the log-in icon

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

The signed-out card at the sidebar's foot shows one landscape in
colour instead of three tinted portraits, and its line reads 'Sync and
run on Comfy Cloud', as in the New UI proposal. The two portraits it
no longer uses are removed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@benceruleanlu
benceruleanlu force-pushed the mar/signin-card-landscape branch from 6e1df5c to 652824f Compare November 11, 2026 16:23
@benceruleanlu
benceruleanlu changed the base branch from codex/mar-restack-2002 to main November 11, 2026 16:24
h-18 is the spacing-scale class for the same 72px height, so the card keeps its size and follows --spacing.
@benceruleanlu
benceruleanlu added this pull request to the merge queue Nov 11, 2026
@coderabbitai
coderabbitai Bot requested a review from benceruleanlu November 11, 2026 18:15
Merged via the queue into Comfy-Org:main with commit d979548 Nov 11, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants