Skip to content

feat(ui): show icons in the build actions menu - #1992

Merged
benceruleanlu merged 1 commit into
Comfy-Org:codex/mar-restack-1996from
mariana953:mar/design-align-menu-icons
Nov 11, 2026
Merged

benceruleanlu merged 1 commit into
Comfy-Org:codex/mar-restack-1996from
mariana953:mar/design-align-menu-icons

Conversation

@mariana953

@mariana953 mariana953 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

PR stack

main → #1996 → #1992 (this PR) → #1998 → #1999 → #2000 → #2001 → #2002 → #2003

Base: #1996 (codex/mar-restack-1996). Next: #1998.

Restacked onto current main after #2009 added Home. The closed #1981 is no longer a dependency; its Home/Apps placeholders and Generated Files gallery are excluded. This PR keeps its original UI changes.

These PRs originate in Mar's fork. Each dependent PR targets a matching upstream branch at the preceding PR's head so GitHub shows only its own changes. Merge in the order above. After merging a parent, rebase the remaining stack onto main and retarget its first PR to main. After any parent changes, restack its descendants and update the matching upstream base branches.

ELI5

Each build's ⋯ menu on the Builds page was a plain list of words. This puts a small picture next to each action, like the labels on a toolbox drawer, so people find "Show in Finder" or "Uninstall" at a glance. Nothing the menu does changes.

Summary

  • Each action in the build actions menu (Builds page ⋯ / right-click) now shows its icon from the design: Manage, Update, Migrate, Duplicate, Show in Finder, Export Snapshot, Restore Snapshot, Promote to workspace, Stop and Uninstall.
  • ContextMenu.vue draws an item's icon only when the item has one, so the console terminal menu, which sets none, looks the same.
  • ContextMenuItem.icon was an unused string; it now takes a component.

Before / after

Historical screenshots captured before this PR was restacked onto main.

Build ⋯ menu before Build ⋯ menu after

Test plan

  • pnpm lint, pnpm format:check, pnpm typecheck
  • pnpm test (330 files, 7635 tests)
  • Built the app, opened a build's ⋯ menu on the Builds page: icons show, danger items keep their red
  • Open the menu on a build with an update and on a running build: Update and Stop show their icons
  • No feature flag: visual only, no new behaviour

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 52958c78-750a-45cb-b026-a2fd5a181d50

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@mariana953
mariana953 force-pushed the mar/design-align-menu-icons branch from 8f92440 to 18cb42b Compare November 10, 2026 17:55
@mariana953
mariana953 changed the base branch from main to PabloWiedemann/sidebar-tabs-assets November 10, 2026 17:55
@mariana953
mariana953 marked this pull request as ready for review November 11, 2026 01:21
@mariana953
mariana953 requested review from a team as code owners November 11, 2026 01:21
The Builds page menu now draws an icon beside each action, matching the
design: Manage, Update, Migrate, Duplicate, Show in Finder, Export and
Restore Snapshot, Promote to workspace, Stop and Uninstall. Items, order,
conditions and behaviour are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@benceruleanlu

Copy link
Copy Markdown
Member

Love the screenshots, keep it up!

@benceruleanlu
benceruleanlu merged commit fc469a7 into Comfy-Org:codex/mar-restack-1996 Nov 11, 2026
4 checks passed
benceruleanlu added a commit that referenced this pull request Nov 11, 2026
… main (#2013)

* feat(ui): show icons in the build actions menu

The Builds page menu now draws an icon beside each action, matching the
design: Manage, Update, Migrate, Duplicate, Show in Finder, Export and
Restore Snapshot, Promote to workspace, Stop and Uninstall. Items, order,
conditions and behaviour are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(ui): use an icon button for More on the build page

On the build details page the header's More menu now opens from a ⋯ icon
button, matching the design. The menu, its actions and the picker popup's
labelled More button are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* feat(ui): group Forget and Uninstall under a divider in the build More menu

Forget reads as a normal action; Uninstall stays the only red item.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(ui): center the labels in the build page tabs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Mariana Martinho <mariana@comfy.org>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
mariana953 added a commit to mariana953/Comfy-Desktop that referenced this pull request Nov 12, 2026
…rg#1992, Comfy-Org#1998)

The Builds ⋯ menu and the build page's More say Duplicate, not
Duplicate Instance, and More draws it with Desktop's copy icon.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants