Repository navigation
style: neutral snapshot ring color - #2014
Closed
mariana953 wants to merge 1 commit into
Closed
mariana953 wants to merge 1 commit into
mariana953 wants to merge 1 commit into
Conversation
The last dark gray token with a blue tint. Same lightness, no hue. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25. Or wait 32 minutes for your next included review. View limit details
|
mariana953
marked this pull request as ready for review
November 11, 2026 18:15
Contributor
Author
|
No longer needed: #1999 removed the snapshot ring token, so main has no tinted gray left. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
The dark theme went fully neutral gray in #1996. One leftover color, the ring around the dots on the Snapshots timeline, still had a faint blue tint. This makes it the same gray with no tint.
Summary
--color-snapshot-ring:#262729to#272727(same lightness, no hue).main: the older tinted values inmain.css(--border,--border-hover,--surface,--secondary-background, the legacy--neutral-*scale,--modal-surface-bg,--tooltip-border) are all overridden later in the same file by the neutral block from style: neutral gray palette for the dark theme #1996, so they do not render. This was the only tinted gray still in effect.Before / after
--color-snapshot-ring#262729(R 38, G 39, B 41)#272727(R 39, G 39, B 39)The difference is a few units on one channel; no visible layout or contrast change.
Test plan
SnapshotsViewtests pass, prettier🤖 Generated with Claude Code