Skip to content

style: neutral snapshot ring color - #2014

Closed
mariana953 wants to merge 1 commit into
Comfy-Org:mainfrom
mariana953:mar/neutral-legacy-tokens
Closed

mariana953 wants to merge 1 commit into
Comfy-Org:mainfrom
mariana953:mar/neutral-legacy-tokens

Conversation

@mariana953

Copy link
Copy Markdown
Contributor

ELI5

The dark theme went fully neutral gray in #1996. One leftover color, the ring around the dots on the Snapshots timeline, still had a faint blue tint. This makes it the same gray with no tint.

Summary

  • --color-snapshot-ring: #262729 to #272727 (same lightness, no hue).
  • Audit result on main: the older tinted values in main.css (--border, --border-hover, --surface, --secondary-background, the legacy --neutral-* scale, --modal-surface-bg, --tooltip-border) are all overridden later in the same file by the neutral block from style: neutral gray palette for the dark theme #1996, so they do not render. This was the only tinted gray still in effect.
  • UI only, one token.

Before / after

Before After
--color-snapshot-ring #262729 (R 38, G 39, B 41) #272727 (R 39, G 39, B 39)

The difference is a few units on one channel; no visible layout or contrast change.

Test plan

  • SnapshotsView tests pass, prettier
  • Snapshots tab: ring around the timeline dots reads neutral

🤖 Generated with Claude Code

The last dark gray token with a blue tint. Same lightness, no hue.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

Or wait 32 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7a068c4a-e5e4-4598-8538-926262e4f788
Commits

Reviewing files that changed from the base of the PR and between 54c916b and accadc3.

Files selected for processing: 1

  • src/renderer/src/assets/design-system-theme.css
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@mariana953
mariana953 marked this pull request as ready for review November 11, 2026 18:15
@mariana953
mariana953 requested review from a team as code owners November 11, 2026 18:15
@mariana953

Copy link
Copy Markdown
Contributor Author

No longer needed: #1999 removed the snapshot ring token, so main has no tinted gray left.

@mariana953 mariana953 closed this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant