Repository navigation
fix(responses): carry incomplete reasons, terminal refusals, offline continuation tests and MiMo envelope repair (#7122, #7152, #7068, #7214) - #7218
Conversation
Carried from #7122. Co-authored-by: Bortlesboat <169967362+Bortlesboat@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Cover envelope endings, opaque valid JSON, rejected shapes, replay, and content-free diagnostics. Co-authored-by: shirruy <shirruy@users.noreply.github.com>
Covers the outstanding source review case with the bounded parse alternatives. Co-authored-by: shirruy <shirruy@users.noreply.github.com>
Consolidate the affected retry and history repair paragraphs without dropping contract detail. Co-authored-by: Bortlesboat <169967362+Bortlesboat@users.noreply.github.com> Co-authored-by: shirruy <shirruy@users.noreply.github.com>
641ae5d to
0f00e6d
Compare
|
✅ Deterministic PR hygiene checks passed. |
# Conflicts: # scripts/test-layout/layout.json # tests/fixtures/test-layout-expected.json
|
Maintainer integration decision (dev, MAINTAINERS.md maintainer-integration policy): landing this PR at head 74f8067 as part of the 2026-10-16 PR-reduction batch. Hosted GitHub Actions are stalled (runs sit queued), and the maintainer ruled out local test runs for this round, so the evidence is remote and exact-tree:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Responses clients now receive canonical incomplete reasons, stop retrying explicit terminal upstream refusals, and can reconnect when idle WebSockets consume the connection limit. Offline continuation coverage pins tool-call linkage. MiMo history repair preserves usable arguments without logging tool argument content.
Carried onto
dev, each in its own authored commit:main; this carry correctly targetsdev. Separate credited follow-ups remove raw argument diagnostics, handle escaped terminal quotes and braces inside strings, and add bounded-repair/replay/privacy coverage.Excluded: #7095 by @YayoiNanoka (coordinator, after remote validation). On mini (Windows) its own tests/responses/ws-capacity-tool-ownership.test.ts and ws-capacity-reclamation.test.ts fail deterministically at head 641ae5d, both in the full union run and when run alone (15 pass / 3 fail: "Upstream stream ended before response terminal event" and a 5.6 s disconnect-admission timeout); lidge passes. #7095 stays open for a Windows fix. Current dev behavior is retained in conflict resolutions. All 11 new test files appear in both layout maps; capped passthrough tests are unchanged. The wire-shapes contract remains within the 600-line structure budget. No GUI, locale, CLI capability or provider preset counts change.
Verification
Final head:
641ae5d74cf1a949151128d9b1964abd01c42586.Local tests, typechecks, builds, lint and docs builds were NOT RUN, by explicit user rule. Hosted GitHub CI is unavailable and is not claimed as passing.
Full typecheck + full suite requested on both hosts for this pushed head:
L3-641ae5dL3-641ae5dCommands:
Compare each host's failures with its own
~/ocx-lane/logs/base-dev-4ae49360b.summaryand full log. Evidence will be updated after both runs complete. Superseded queued L3 requests were stopped before test execution.Static inspection: file-size caps and structure document budgets checked without running repository tooling; new test registration checked in both maps;
git diff --checkclean. Source review comments inspected. Source #7214's raw argument logging and escaped-quote defects are corrected in credited follow-up commits. Docs builds remain unverified.Checklist
Co-authored-by: Bortlesboat 169967362+Bortlesboat@users.noreply.github.com
Co-authored-by: AK info@atelier-sai.jp
Co-authored-by: Claude Opus 5.5 noreply@anthropic.com
Co-authored-by: Aditya Rawat adirwt852@gmail.com
Co-authored-by: shirruy shirruy@users.noreply.github.com