feat(advisor): carry bounded retention and adaptive consultation (#7134, #7124)

[lidge-jun]

Summary

Carry the two Advisor follow-ups onto current dev while preserving the Subagents sidebar grouping, collapsed disclosures, current model selector, consent requirements, and optional subsystem boundaries.

• fix(advisor): bound retained stream and replay state #7134 by @luvs01: independently bound retained Advisor stream/reconstruction/replay state and pass request translator budgets through all translated delivery and retry paths.
• feat(advisor): add activity and evidence-based adaptive consultation #7124 by @Flowershangfromthebranches: expose bounded consultation activity and an opt-in adaptive policy using failed-validation → completed-edit → failed-validation evidence, with durable task allowances, CLI/API access, and translated GUI/docs.
• No source PR excluded. Each source is its own authored commit; a separate attributed fix registers the retention owner in the Responses source inventory, addressing the source-author follow-up on fix(advisor): bound retained stream and replay state #7134.
• Resolve test-layout registrations and source/doc conflicts by retaining both intents and existing dev behavior. Four new backend test files are registered in both layout maps; all 11 locale catalogs are updated. No existing file-size cap is changed; no capped file is touched. The CLI surface map is current and capability counts are unchanged.

Verification

Final head: 15449421757f097cd2d9723f181872d5acf521e3; base: 4ae49360b794f8d829f75019a3c49b5fba39e12b.

Both full-suite runs are queued on the final head; this draft will be updated with the completed host-specific baseline comparison before being marked ready.

Host	Label	Head	Typecheck	Full suite
mini (Windows)	L6a-1544942	15449421757f097cd2d9723f181872d5acf521e3	pending	pending
lidge (Linux)	L6a-1544942	15449421757f097cd2d9723f181872d5acf521e3	pending	pending

Commands: ssh mini 'OCX_LANE_SLOTS=3 ~/bin/ocx-lane-ci2.sh 15449421757f097cd2d9723f181872d5acf521e3 L6a-1544942' and the same on ssh lidge with OCX_LANE_SLOTS=2. Baseline label on both hosts: base-dev-4ae49360b.

Local tests, typechecks, builds, lint, and dependency installation were not run, by the user's explicit rule. Hosted GitHub Actions are stalled and are not represented as passing.

Additional remote checks on lidge passed on 7acbbb1172a448146dd9c4adae1155377119fa4f, whose tree cbb8cba16d450f0abd59d5ed10668290514baf78 is identical to the final head (only #7124's carry commit title was reworded):

• GUI Advisor file: bun test --isolate tests/advisor-save-feedback.test.tsx — 12 pass / 0 fail; GUI lint and i18n lint — exit 0. GUI TypeScript/Vite build passed during remote runner setup, also on the final SHA.
• bun run structure:check, bun run privacy:scan, bun run skill:surface:check — exit 0.
• Docs frozen install + build — exit 0; 577 pages and 81,333 internal links checked.
• No live paid-provider consultation, deployment, or release was run. Maintainer security review of the new activity read and capability-gated diagnostics remains a separate pre-merge responsibility; this carry does not claim independent security approval.

Reused screenshot evidence from #7124 (source images, not new final-head browser evidence):

Checklist

• Scope stays focused and avoids unrelated cleanup.
• Docs or release notes were updated when needed.
• Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Co-authored-by: Epinephrine luvs01@hanmail.net
Co-authored-by: Flowershangfromthebranches 152056395+Flowershangfromthebranches@users.noreply.github.com

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

• Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: db4971a9-c45f-425a-bab0-dbb1563ef8b8

📥 Commits

Reviewing files that changed from the base of the PR and between 3785915 and 35aa6ad.

📒 Files selected for processing: 61

• docs-site/src/content/docs/fr/reference/configuration/advisor.md
• docs-site/src/content/docs/ja/reference/configuration/advisor.md
• docs-site/src/content/docs/ko/reference/configuration/advisor.md
• docs-site/src/content/docs/reference/configuration/advisor.md
• docs-site/src/content/docs/ru/reference/configuration/advisor.md
• docs-site/src/content/docs/tr/reference/configuration/advisor.md
• docs-site/src/content/docs/zh-cn/reference/configuration/advisor.md
• docs-site/src/content/docs/zh-tw/reference/configuration/advisor.md
• gui/src/i18n/de.ts
• gui/src/i18n/en.ts
• gui/src/i18n/fr.ts
• gui/src/i18n/ja.ts
• gui/src/i18n/ko.ts
• gui/src/i18n/pt.ts
• gui/src/i18n/ru.ts
• gui/src/i18n/tr.ts
• gui/src/i18n/vi.ts
• gui/src/i18n/zh-TW.ts
• gui/src/i18n/zh.ts
• gui/src/pages/Advisor.tsx
• gui/src/pages/advisor/AdvisorActivity.tsx
• gui/src/pages/advisor/advisor.css
• gui/tests/advisor-save-feedback.test.tsx
• scripts/test-layout/layout.json
• skills/ocx/references/01_surface_agents-routing.md
• src/advisor/activity.ts
• src/advisor/budget.ts
• src/advisor/consult.ts
• src/advisor/context.ts
• src/advisor/evidence-tool.ts
• src/advisor/evidence.ts
• src/advisor/runtime.ts
• src/advisor/settings.ts
• src/cli/advisor.ts
• src/cli/capabilities-agents-routing.ts
• src/server/chat-completions.ts
• src/server/chat-native.ts
• src/server/inference/advisor-diagnostics.ts
• src/server/management/advisor-routes.ts
• src/server/management/companion-routes.ts
• src/server/management/route-registry.ts
• src/server/responses/adapter-continuation.ts
• src/server/responses/adapter-delivery.ts
• src/server/responses/advisor-retention.ts
• src/server/responses/advisor-slot.ts
• src/types/config.ts
• src/types/request.ts
• structure/INDEX.md
• structure/advisor.md
• structure/gui-and-management-api.md
• structure/manifest.json
• structure/transports/byte-accounting.md
• tests/advisor/advisor-adaptive.test.ts
• tests/advisor/advisor-budget.test.ts
• tests/advisor/advisor-evidence.test.ts
• tests/advisor/advisor-responses-wiring.test.ts
• tests/advisor/advisor-retention.test.ts
• tests/advisor/advisor-settings.test.ts
• tests/fixtures/test-layout-expected.json
• tests/helpers/responses-core-source.ts
• tests/server/advisor-routes.test.ts

+-------------------------------------------------------------------+
| That's not technical debt - that's technical *predatory lending*. |
+-------------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

✅ Deterministic PR hygiene checks passed.

[lidge-jun]

Maintainer integration decision (dev, MAINTAINERS.md maintainer-integration policy): landing this PR at head 35aa6ad as part of the 2026-10-16 PR-reduction batch.

Hosted GitHub Actions are stalled (runs sit queued), and the maintainer ruled out local test runs for this round, so the evidence is remote and exact-tree:

• Union candidate codex/prr-integ-6 = dev 4ae4936 + fix(providers): carry Zed, Qoder, and OpenCode Gemini compatibility #7216, fix(catalog): carry Ultra Fast discovery, vision sidecar, model alias ids and auto-review override (#7115, #7126, #7173, #6867) #7220, fix(service): carry log rotation identities, Windows lock folder and remote-list RFC (#7186, #7203, #6157) #7215, fix(responses): carry incomplete reasons, terminal refusals, offline continuation tests and MiMo envelope repair (#7122, #7152, #7068, #7214) #7218, feat(advisor): carry bounded retention and adaptive consultation (#7134, #7124) #7219, feat(antigravity): preserve diagnostic per-model quota evidence (carry #6718) #7163, feat(providers): carry opt-in API key round-robin and per-key pacing (#6937) #7135, refactor(proxy): share opaque transport with desktop relay #7120 (commit 368006f, tree 27fdc37), typecheck + full suite on both hosts, compared with the same host's run of dev 4ae4936:
  • lidge (Linux, Bun 1.4.3): typecheck 0; 47973 tests / 2395 files; no new failing test except one parameter of the wire default survives the handleResponses replay, whose sibling parameter times out at 5000 ms on base dev on the same host.
  • mini (Windows, Bun 1.4.3): typecheck 0; 47984 tests / 2395 files. Two failures absent from the base full run: native Anthropic passthrough returns 502 when the upstream connection is refused (reject-path activation) fails identically on base dev 4ae4936 in isolated same-host runs (2/2); GET /api/storage > returns the scan report with buckets and totals is an untouched test whose CODEX_HOME inventory raced live coordination files, and it passes 2/2 isolated at the union head (coordinator judgment, recorded here as a deviation from the strict same-host rule). Three added skips are fix(service): guard log rotation file identities #7186's symlink cases, skipped on Windows by design.
• Per-bundle lidge runs localized and fixed earlier failures (see the PR description); fix commits after those runs were re-verified with focused runs and are contained in the union tree.
• After the batch lands, origin/dev^{tree} is checked against the validated union tree.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-16T03:49:25.533094Z	35aa6ad	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.