Repository navigation
[Fix] Users settings become unavailable after a failed read - #3494
Open
roomote-roomote[bot] wants to merge 3 commits into
Open
roomote-roomote[bot] wants to merge 3 commits into
roomote-roomote[bot] wants to merge 3 commits into
Conversation
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 16, 2026 05:36
Contributor
|
No new code issues found. See session The latest commit merges The updated PR description now reports completed exact-head desktop/mobile checks and includes screenshots. This sync pass does not independently verify those visual checks or grant approval. Reviewed dde015a |
This was referenced Oct 16, 2026
This was referenced Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal settings recovery follow-up; no separate issue.
Why this PR exists
What changed
Users settings and independent account-linking help offer actual Retry after initial/background read failures. Cached controls, invite forms/one-time links and unsaved help drafts remain available. Existing query state and compact UI patterns preserve ordinary Save/Reset and invite creation/revocation; no backend state or dependency added.
How it was tested
71ee50caindependently aborts each read into an error with no Retry. Exact headdde015aa6577306c0dfa0107c80cae45387fe668recovers the identical real request through Retry after fault removal, without reload.Screenshots
Actual 1440×1000 and 390×844 local UI. Read-transport aborts induce failures; successful data/mutations use the real backend. No hardcoded responses, DOM/query-state simulation, source changes or pixel edits.
Main Users initial error
Independent help initial error
Main background error with cached controls
Help background error with editable draft and Save/Reset
Related PRs
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally (normal broad fast equivalents passed)pnpm changeset(settings recovery)