Skip to content

[Fix] Users settings become unavailable after a failed read - #3494

Open
roomote-roomote[bot] wants to merge 3 commits into
developfrom
fix/users-settings-read-recovery-0dds4qgl9nmxe
Open

roomote-roomote[bot] wants to merge 3 commits into
developfrom
fix/users-settings-read-recovery-0dds4qgl9nmxe

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

​Opened on behalf of Daniel Riccio. Follow up by mentioning @roomote-roomote, in the web UI, or in Telegram.

Related issue

Internal settings recovery follow-up; no separate issue.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

Users settings and independent account-linking help offer actual Retry after initial/background read failures. Cached controls, invite forms/one-time links and unsaved help drafts remain available. Existing query state and compact UI patterns preserve ordinary Save/Reset and invite creation/revocation; no backend state or dependency added.

How it was tested

  • Current develop 71ee50ca independently aborts each read into an error with no Retry. Exact head dde015aa6577306c0dfa0107c80cae45387fe668 recovers the identical real request through Retry after fault removal, without reload.
  • Actual local dev-login/tRPC/PostgreSQL: initial/cached errors for both reads, invite creation with failed refresh and one-time Copy recovery, retained next-invite/help drafts, help Save/Reset and revoke dialogs. Fixtures revoked/help restored, routes removed; fresh reload verifies cleanup.
  • All 21 client tests, direct web types and normal hooks pass. Conflict-free develop sync preserves the original three-file net diff. All applicable exact-head hosted gates pass/skip; exact-head review clean/zero threads and MERGEABLE before Ready.
  • Eight final desktop/mobile images personally inspected and independently checked against the matching shipped diff. Screenshots prove the visible error/Retry/cached controls, not recovery timing, persistence or Copy. Desktop cached Users shows the invite draft; mobile shows retained License controls while its invite draft is below frame. Only light theme and stated sizes inspected; no device/speech/hosted parity claim.

Screenshots

Actual 1440×1000 and 390×844 local UI. Read-transport aborts induce failures; successful data/mutations use the real backend. No hardcoded responses, DOM/query-state simulation, source changes or pixel edits.

Main Users initial error

Users initial desktop
Users initial mobile

Independent help initial error

Help initial desktop
Help initial mobile

Main background error with cached controls

Users cached desktop and invite draft
Users cached mobile and License controls

Help background error with editable draft and Save/Reset

Help cached desktop
Help cached mobile

Related PRs

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally (normal broad fast equivalents passed)
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset (settings recovery)

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review October 16, 2026 05:36
@roomote-community

roomote-community Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

No new code issues found. See session

The latest commit merges develop; all three PR files are byte-identical to the previously reviewed 50b7736. Carried forward that completed clean review; no prior findings or review threads remain. Current-head lint, typecheck, Knip and upgrade compatibility checks passed; tests, app Docker build and JavaScript/TypeScript analysis were still running at inspection. Existing validation suites were left to CI.

The updated PR description now reports completed exact-head desktop/mobile checks and includes screenshots. This sync pass does not independently verify those visual checks or grant approval.

Reviewed dde015a

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant