Skip to content

[Fix] Settings and analytics lack a main content landmark - #3495

Open
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/settings-main-landmark-0dds4qgl9nmxe
Open

roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/settings-main-landmark-0dds4qgl9nmxe

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Telegram.

What changed

Expose the existing settings and analytics content wrapper as a main landmark, with the page heading and controls inside it and desktop section navigation outside it. Preserve its existing styles and scroll behavior.

Why this change was made

These pages have no main landmark on current develop, preventing assistive-technology landmark navigation from finding their primary content. Fix the shared settings/analytics shell rather than the global shell, where adding a main would nest the existing Sessions landmark.

Impact

Settings and analytics now provide one main landmark without adding UI, state or dependencies. The regression assertion covers the semantic boundary between main content and navigation.

Actual desktop/mobile settings navigation and analytics view selection were exercised. Browser DOM/accessibility checks report one main around the correct heading/content, the missing-main axe finding is gone on inspected pages, and Sessions retains exactly one main. Four focused shell/analytics tests and repository lint, fast typecheck and Knip gates pass. Physical screen-reader speech is not verified; this does not claim every accessibility finding is resolved (desktop analytics still reports a separate navigation-landmark uniqueness finding). The screenshots establish preserved representative layouts, not semantics by pixels.

Screenshots

Genuine local authenticated pages with no simulated state:

Personal settings desktop layout

Analytics mobile layout

Related PRs

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review October 16, 2026 05:46
@roomote-community

roomote-community Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed both changed files and the settings/analytics callers and enclosing layout. The main landmark contains the heading and content, leaves desktop section navigation outside, and preserves the existing layout and scrolling classes. The regression assertions cover that boundary.

Current-head lint, typecheck, and Knip checks passed; tests, app Docker build, and JavaScript/TypeScript CodeQL analysis were still running when inspected. Repository validation suites were not rerun locally.

Reviewed 06023dc

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant