Repository navigation
[Fix] Shared package edits reuse stale successful checks - #3606
Open
roomote-roomote[bot] wants to merge 2 commits into
Open
roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
|
No new code issues found. See session The latest update only merges Reviewed 5081dca |
This was referenced Oct 27, 2026
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 27, 2026 05:57
5 of 8 tasks
…-cache-inputs-1pn0qy1hk5krr
This was referenced Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal developer-workflow follow-up; no separate issue.
Why this PR exists
What changed
Include shared package sources, manifests and TypeScript/ESLint configuration in Turbo's global cache inputs. Consumer tests/typechecks rerun after imported shared code changes instead of returning stale successful checks. Six input additions preserve commands, assertions and task ordering. Conservative invalidation intentionally costs more cold work; unchanged inputs still reuse cache. This is check correctness, not a speed claim.
How it was tested
71ee50ca: actual Turbo returns cached success after a temporary shared provider-ID or compiler-type fault, while the identical direct Vitest/tsgo stimulus fails.5081dcac55a83719d9f6c02a56e8c3db1942f658: identical faults genuinely miss/rerun/fail. Unchanged inputs and restored sources hit healthy cache. Temporary faults and isolated caches removed; no checker/CI responses simulated.Related PRs
Independent companions: foreground deadlines, review debounce, Users recovery, native watcher, credential fixture isolation.
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally (normal broad fast equivalents passed)pnpm changeset(developer/CI configuration)