Skip to content

[Fix] Shared package edits reuse stale successful checks - #3606

Open
roomote-roomote[bot] wants to merge 2 commits into
developfrom
fix/shared-package-cache-inputs-1pn0qy1hk5krr
Open

roomote-roomote[bot] wants to merge 2 commits into
developfrom
fix/shared-package-cache-inputs-1pn0qy1hk5krr

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

​Opened on behalf of Daniel Riccio. Follow up by mentioning @roomote-roomote, in the web UI, or in Telegram.

Related issue

Internal developer-workflow follow-up; no separate issue.

Why this PR exists

  • A maintainer explicitly invited this PR in the linked issue or discussion
  • I am a maintainer / this is internal Roomote work

What changed

Include shared package sources, manifests and TypeScript/ESLint configuration in Turbo's global cache inputs. Consumer tests/typechecks rerun after imported shared code changes instead of returning stale successful checks. Six input additions preserve commands, assertions and task ordering. Conservative invalidation intentionally costs more cold work; unchanged inputs still reuse cache. This is check correctness, not a speed claim.

How it was tested

  • Current develop 71ee50ca: actual Turbo returns cached success after a temporary shared provider-ID or compiler-type fault, while the identical direct Vitest/tsgo stimulus fails.
  • Exact head 5081dcac55a83719d9f6c02a56e8c3db1942f658: identical faults genuinely miss/rerun/fail. Unchanged inputs and restored sources hit healthy cache. Temporary faults and isolated caches removed; no checker/CI responses simulated.
  • Normal push hooks pass, including 27 fresh type tasks. Full forced serial repository suite: 27/27 tasks, zero cache hits, 14m37.496s. Exact-head hosted Test (14m) and all applicable gates pass/skip; exact-head review clean/zero threads, MERGEABLE before Ready. Browser proof not applicable.
  • Conflict-free develop sync incorporates independent merged [Chore] Align runtime configuration tests with shipped Kimi routes #3603; only six cache inputs remain in the net diff. A separate combined-diff experiment later exposed path/load-sensitive fixtures and credential-test contamination; its first cold-root run was not green. [Fix] Credential tests fail when shared grants overlap #3610 addresses that independently reproduced test isolation gap; no runtime or fixture repair is bundled here.

Related PRs

Independent companions: foreground deadlines, review debounce, Users recovery, native watcher, credential fixture isolation.

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally (normal broad fast equivalents passed)
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset (developer/CI configuration)

@roomote-community

roomote-community Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

No new code issues found. See session

The latest update only merges develop; the PR’s six turbo.json cache-input additions are unchanged from the previous clean review. The two test-file changes since the prior review come from the base branch and are outside this PR’s diff. No prior findings remain. Current-head CI lint, Knip, and CodeQL passed; tests and type checks were still running at review time.

Reviewed 5081dca

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant