Repository navigation
[Fix] Credential tests fail when shared grants overlap - #3610
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
No code issues found. See session Reviewed the project inclusion/exclusion rules, serial scheduling, and both credential suites’ shared-grant assertions and cleanup. Both files remain included in Reviewed b4e830d |
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 28, 2026 06:28
This was referenced Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal CI reliability follow-up; no separate issue.
Why this PR exists
What changed
Run the two credential fixture suites in the SDK's existing serial global-database-state project. Their deployment-visible test grants intentionally appear to other actors, so running both files in parallel contaminates valid assertions about visible grants and substitutes.
Only two existing file memberships and an explanatory comment change. Every assertion, fixture and production credential policy stays intact; ordinary SDK suites retain their parallel project. This trades a small amount of fixture concurrency for reliable checks, without introducing a new runner or timing budget.
How it was tested
71ee50ca: identical real-PostgreSQL Vitest command selecting both files with--maxWorkers=2failed all three runs, with 1, 4 and 1 failures out of 42 cases. The failures contained another file's deliberately deployment-visible grant.b4e830d46fc0a9f95a3aa12bfe5627e9c26da08c: the identical command passed 42/42 on all three runs. Verbose adjacent execution confirms both files usesdk-global-db-stateafter the ordinary project, rather than merely hiding failures./tmp; neither is changed or claimed repaired here. This PR fixes only the independently reproduced cross-file credential contamination.Reproduction:
Related PRs
Independent work from the same shift: shared-check cache correctness, foreground deadlines, review debounce, Users recovery, native development watcher.
Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locally (normal broad fast equivalents and affected direct typecheck passed)pnpm changeset(test configuration only)