Skip to content

[Fix] Personal instructions drafts disappear after settings refresh - #3491

Open
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/personal-instructions-draft-0dds4qgl9nmxe
Open

roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/personal-instructions-draft-0dds4qgl9nmxe

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Telegram.

What changed

Preserve unsaved personal instructions when a background refresh brings in newer settings, including the refresh after a failed Save. An empty draft is preserved too. Clean editors continue following saved settings, and successful Save or Reset returns the editor to that clean state.

Why this change was made

On current develop, editing instructions in one browser tab and saving different instructions in another lets the first tab's ordinary refresh silently replace the unsaved text. Keep the local draft separate from the query result so refreshing saved settings cannot erase ongoing edits.

Impact

Users can finish and save their personal instructions after a concurrent update or failed save. This adds no controls, dependencies or server state; versioned writes, initial-load recovery, and the learning-toggle behavior are preserved.

Verified the two-tab stimulus on the actual Personal settings page with local dev-login, tRPC and PostgreSQL: desktop retained and saved its draft; mobile retained its draft after a real stale-version failure and saved it on retry. Reset and learning off/on also persisted correctly. The focused 15-test suite and repository lint, fast typecheck and Knip gates pass. Screenshots show the inspected desktop/mobile layout and draft state; the interaction/readback checks establish ordering and persistence. Hosted deployment parity is not claimed.

Screenshots

Desktop editor with the retained draft and Save available:

Personal instructions draft on desktop

Mobile editor with an unsaved draft and compact controls:

Personal instructions draft on mobile

Related PRs

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review October 16, 2026 05:22
@roomote-community

roomote-community Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 940e4d0

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant