Repository navigation
[Fix] Personal instructions drafts disappear after settings refresh - #3491
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 16, 2026 05:22
Contributor
This was referenced Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Preserve unsaved personal instructions when a background refresh brings in newer settings, including the refresh after a failed Save. An empty draft is preserved too. Clean editors continue following saved settings, and successful Save or Reset returns the editor to that clean state.
Why this change was made
On current develop, editing instructions in one browser tab and saving different instructions in another lets the first tab's ordinary refresh silently replace the unsaved text. Keep the local draft separate from the query result so refreshing saved settings cannot erase ongoing edits.
Impact
Users can finish and save their personal instructions after a concurrent update or failed save. This adds no controls, dependencies or server state; versioned writes, initial-load recovery, and the learning-toggle behavior are preserved.
Verified the two-tab stimulus on the actual Personal settings page with local dev-login, tRPC and PostgreSQL: desktop retained and saved its draft; mobile retained its draft after a real stale-version failure and saved it on retry. Reset and learning off/on also persisted correctly. The focused 15-test suite and repository lint, fast typecheck and Knip gates pass. Screenshots show the inspected desktop/mobile layout and draft state; the interaction/readback checks establish ordering and persistence. Hosted deployment parity is not claimed.
Screenshots
Desktop editor with the retained draft and Save available:
Mobile editor with an unsaved draft and compact controls:
Related PRs