Skip to content

[Fix] Password reset links push the Copy control off mobile screens - #3498

Open
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/reset-link-mobile-wrap-0dds4qgl9nmxe
Open

roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/reset-link-mobile-wrap-0dds4qgl9nmxe

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Opened on behalf of @daniel-lxs. Follow up by mentioning @roomote-roomote, in the web UI, or in Telegram.

What changed

Wrap the password-reset result URL inside the Users dialog so its Copy control remains reachable on narrow screens.

Why this change was made

A genuinely generated reset link forced the mobile dialog's content to 485px, even at 320px and 390px viewport widths. At 320px, the Copy control's right edge was 449px—outside the screen. Allowing the URL to break within long segments fixes the overflow.

Impact

The result fits at 320px and 390px while preserving the compact desktop dialog. This adds one wrapping utility, with no new controls, state, dependencies or authentication behavior.

Verified actual password setup and admin reset-link generation with a disposable local account. On the exact committed head, genuine client/scroll widths are 318/318px at a 320px viewport, 388/388px at 390px, and 510/510px on desktop; Copy is within the viewport and its actual click succeeded. All 16 existing base UsersSettings tests, web typecheck and repository pre-push gates pass. No CSS-class assertion tests were added.

Screenshots

Sanitized rendered-layout evidence: only opaque token characters were replaced in the actual dialog before capture, preserving text length, punctuation and line-break opportunities. These screenshots prove layout only, not a real reset credential, backend behavior or authorization. Genuine generation, geometry and Copy were checked separately before sanitization; no generated credential was captured.

Password reset result at 320px with sanitized token

Password reset result at 390px with sanitized token

Desktop password reset result with sanitized token

Related PRs

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review October 16, 2026 06:27
@roomote-community

roomote-community Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed the URL wrapping change in context with the dialog layout and Copy control. The added break-all allows long URL segments to wrap without altering the copied value. Current-head lint, typecheck, Knip, app build and CodeQL checks passed; the test job was still running when checked. No local validation suites were run.

Reviewed a2773d0

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant