Repository navigation
[Fix] Password reset links push the Copy control off mobile screens - #3498
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
October 16, 2026 06:27
Contributor
|
No code issues found. See task Reviewed the URL wrapping change in context with the dialog layout and Copy control. The added Reviewed a2773d0 |
This was referenced Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Wrap the password-reset result URL inside the Users dialog so its Copy control remains reachable on narrow screens.
Why this change was made
A genuinely generated reset link forced the mobile dialog's content to 485px, even at 320px and 390px viewport widths. At 320px, the Copy control's right edge was 449px—outside the screen. Allowing the URL to break within long segments fixes the overflow.
Impact
The result fits at 320px and 390px while preserving the compact desktop dialog. This adds one wrapping utility, with no new controls, state, dependencies or authentication behavior.
Verified actual password setup and admin reset-link generation with a disposable local account. On the exact committed head, genuine client/scroll widths are 318/318px at a 320px viewport, 388/388px at 390px, and 510/510px on desktop; Copy is within the viewport and its actual click succeeded. All 16 existing base UsersSettings tests, web typecheck and repository pre-push gates pass. No CSS-class assertion tests were added.
Screenshots
Sanitized rendered-layout evidence: only opaque token characters were replaced in the actual dialog before capture, preserving text length, punctuation and line-break opportunities. These screenshots prove layout only, not a real reset credential, backend behavior or authorization. Genuine generation, geometry and Copy were checked separately before sanitization; no generated credential was captured.
Related PRs