Repository navigation
Agent: collapse the sidebar to a rail and unify the header - #1236
Conversation
8476c42 to
f2a64d6
Compare
|
Can we keep the Settings icon in the sidebar when collapsed? |
menu-collapse-animation.movwhat do you think about the collapse/expand animating? I can stack on PR on top of this one. I'm fixing the Settings button not being centered in its space. |
|
I built the animation and kept the settings button on screen. it’s in a separate PR that is stacked on this one. Open to feedback or to ditch it completely. |
0af2712 to
6f9604c
Compare
6f9604c to
22cc8d5
Compare
22cc8d5 to
53ba779
Compare
Replace the floating collapsed-sidebar controls with a 48 px rail. Keep the Maple mark at exactly the expanded wordmark M position and scale by sharing row geometry and SVG viewport sizing, so collapsing removes only the rest of the wordmark. Keep one Toggle sidebar button fixed beside the window controls in both sidebar states. Show New task and a divider before the title when collapsed. Tab and Shift-Tab traverse the controls; Enter and Space activate them without changing unsent composer text. Use the sidebar background across the header in both sidebar states. Round the content panel at its top-left corner while keeping its own background and a square top-right edge. Reuse the merged action icon button helper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
53ba779 to
b8bfdd1
Compare
|
Stack 1 UI testing completed on October 26, 2026. Manual UI testing: passed (human tester approval of the refreshed Dev build). Automated computer-use UI testing: passed for the scoped Stack 1 flows, using Codex-driven native pointer/keyboard interactions, screenshots and accessibility observations. Tested the combined macOS Dev build at Rail/header coverage in that combined build passed:
The shared testing report on #1248 records the full environment, cross-stack coverage and limits. It also retains two out-of-scope observations—narrow-window composer clipping and cached sidebar accessibility omissions—for possible future issues. They are treated as likely pre-existing; baseline regression status is unconfirmed, and no issues have been opened. No unit/integration test suites or test-running hooks ran. |
AnthonyRonning
left a comment
There was a problem hiding this comment.
Reviewed at b8bfdd13bc217f8570390f9edb30d60afc0ad437. Rail/header changes preserve existing sidebar state and reuse the shared GPUI action and keyboard controls.
No substantive blockers found. Hosted Agent CI passed, and the combined stack passed the local human smoke test, including Vim mode.
Stack 1 sync — 2026-10-26: #1236 → #1282 → #1248 is rebased onto
masteratd35ea98d. The previous combined head1bdec838was manually tested and approved. The refreshed 0.0.8 Dev debug build passed through the pinned Agent Nix workflow; focused manual recheck is pending. GitHub now reports all three layers as mergeable. No local automated tests or test-running hooks were run. Earlier check results below refer to prior revisions.Why
What this PR adds
Scroll sideways to compare. Click an image for full size.
Remote: the rail and unified header behave the same when connected to a paired computer; collapsing keeps the sidebar's computer and browse state.
Details for reviewers (design, scope, checks)
Files (under
apps/maple-agent/app)src/ui/chat/mod.rs,src/ui/chat/composer.rs,src/ui/chat/sidebar.rs,src/ui/widgets.rs,src/assets.rsassets/icons/maple-mark.svg(the wordmark's "M" on its own)src/ui/chat/tests.rsDesign
widgets::icon_button_for_actionfrom Agent: give the lightbox close button one tooltip #1235 with the live keymap shortcuts in their tooltips. They stop mouse-down propagation so they don't start a window drag.theme::bg_sidebar()in both states; the content panel keepstheme::bg_app()and rounds only its top-left corner withtheme::RADIUS_LG.Checks
6f9604c1. Base:e5c06a56. Seven files: production +214 / −86; tests +289 / −0.cargo fmt --all: passed.cargo clippy -p maple-agent-app --all-targets --locked -- -D warnings: passed.cargo test -p maple-agent-app --locked -- collapsed_sidebar: 7 passed, including exact M alignment, toolbar order, fixed-toggle bounds, mouse activation, and Tab/Enter/Space behavior with composer text unchanged.cargo test -p maple-agent-app --lockedon the final head: 909 passed, 2 ignored. Two of master's new pane-wheel tests (agent: scroll the transcript from the side margins #1253) wheeled at x = 40 px, which is now the collapsed rail; they now wheel just past it (x = 80 px). The rail itself doesn't scroll the transcript.MAPLE_HOOK_SKIP=1as requested.Full-size images
🤖 Generated with Claude Code