Repository navigation
Agent: a Search row instead of an always-visible search field - #1282
Conversation
4ed21cc to
900630a
Compare
900630a to
c8f258c
Compare
Keep the expanded header clear and place Search below New Task. Replace the row with the focused field in the same box, reveal it for the shortcut, and return to the row when an empty search ends. Clicking away drops the input focus while retaining a nonempty filter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
c8f258c to
902e891
Compare
|
Stack 1 UI testing completed on October 26, 2026. Manual UI testing: passed (human tester approval of the refreshed Dev build). Automated computer-use UI testing: passed for the scoped Stack 1 flows, using Codex-driven native pointer/keyboard interactions, screenshots and accessibility observations. Tested the combined macOS Dev build at Search coverage passed:
The shared testing report on #1248 records the full environment, cross-stack coverage and limits. It also retains two out-of-scope observations—narrow-window composer clipping and cached sidebar accessibility omissions—for possible future issues. They are treated as likely pre-existing; baseline regression status is unconfirmed, and no issues have been opened. No unit/integration test suites or test-running hooks ran. |
AnthonyRonning
left a comment
There was a problem hiding this comment.
Reviewed at 902e891cea1c16fa1304e6cb00a06c16afc7b9fe. Search retains the existing filtering and command paths; its added visibility/focus state is transient. The Cmd/Ctrl-F default shortcut change is understood.
No substantive blockers found. Hosted Agent CI passed, and the combined stack passed the local human smoke test, including Vim mode.
Stack 1 sync — 2026-10-26: #1236 → #1282 → #1248 is rebased onto
masteratd35ea98d. The previous combined head1bdec838was manually tested and approved. The refreshed 0.0.8 Dev debug build passed through the pinned Agent Nix workflow; focused manual recheck is pending. GitHub now reports all three layers as mergeable. No local automated tests or test-running hooks were run. Earlier check results below refer to prior revisions.Why
What this PR adds
Scroll sideways to compare. Click an image for full size.
Related: stacked on #1236 (collapsed rail and unified header); this PR's diff is the one commit on top of it and should land after #1236. Independent of #1278, #1280 and #1281; all touch the sidebar, so whichever lands later gets a small rebase.
Remote: the Search row also leads the paired-computer list, and filtering covers computer, project and task names across computers.
Details for reviewers (design, scope, checks)
Files (under
apps/maple-agent/app)src/keymap.rs,src/ui/chat/{commands,composer,navigation,sidebar,sidebar_computers,tests}.rsDesign
FocusSearchcommand. Its catalog default changes from ⌘K to ⌘F (Ctrl-F on other platforms); no transcript Find binding conflicts. Saved user bindings still control the tooltip and command.widgets::icon_button_for_action. Both use the existing Space guard so activation does not type into the composer.Size: one commit on #1236's head
6f9604c1; 7 files, +385 / −90 (production +202 / −84, tests +183 / −6, 4 added tests).Checks (component Nix shell, Xcode 26.5)
cargo fmt --all -- --check: passed.cargo clippy -p maple-agent-app --all-targets --locked -- -D warnings: passed.cargo test -p maple-agent-app --locked: 913 passed, 2 ignored.MAPLE_HOOK_SKIP=1) because of the existing updater testinstaller::tests::reads_native_release_tar_format_and_preserves_bundle_modes, which fails only on this machine.Full-size images
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.