Repository navigation
Agent: animate sidebar transitions and keep Settings visible - #1248
Conversation
f4b9a06 to
1bdec83
Compare
1bdec83 to
eeb7509
Compare
|
Stack 1 UI testing completed on October 26, 2026. Manual UI testing: passed. The refreshed Dev build was manually tested and approved by the human tester. Automated computer-use UI testing: passed for the scoped Stack 1 flows. Codex drove the native app through pointer and keyboard interactions and verified results with screenshots and accessibility observations. Tested the combined stack #1236 → #1282 → #1248, at Coverage relevant to this PR passed:
The synthetic attachment was removed before sending the separate QA prompt. The QA task was archived, Search cleared, and the original window size restored. Out-of-scope observations for possible future issues These are retained separately from this stack's acceptance scope. Source evidence suggests they may predate this stack; no running baseline comparison was performed. No issues have been opened.
No unit/integration suites or test-running hooks ran. Light appearance, OS reduced motion, VoiceOver, large/deeply scrolled lists, other platforms, actual attachment sending and release frame-time performance were not exercised. |
AnthonyRonning
left a comment
There was a problem hiding this comment.
Reviewed at eeb75093b7979a553c6637000d5d4c61967d1423. The bounded, reversible sidebar transition honors reduced motion and preserves cached sidebar ownership. The always-visible Settings control reuses the existing Settings path and adds no persistence contract.
No substantive blockers found. Hosted Agent CI passed, and the combined stack passed the local human smoke test, including Vim mode.
The merge-base changed after approval.
Stacked on #1282 (Search), which builds on #1236 (rail/header).
Animate sidebar collapse and expansion over 200 ms while keeping the single sidebar toggle fixed beside the window controls. New task, Search, the divider and title spacing follow the transition. Reversing direction continues from the current position; reduced-motion settings switch layouts immediately.
Keep Settings visible throughout the transition and in both settled layouts, centered within the 48 px collapsed rail. Search keeps its existing command/focus behavior; Settings has its own keyboard tab position. Existing endpoint tests opt into reduced motion so their layout assertions remain immediate.
Sync with current master preserves the new draft-attachment/upload state alongside the sidebar animation state. No attachment behavior is changed by this PR.
Validation (2026-10-26): the prior combined stack at
1bdec838was manually tested and approved. After syncing ontod35ea98d, the pinned Agent Dev debug build passed (9m 21s), with development attestation and hosted Dev API/billing settings.Need help on this PR? Tag
@codesmith-botwith what you need.