Repository navigation
Agent: calmer sidebar rows and section headings - #1278
Conversation
45a3ebd to
d6b62c0
Compare
d6b62c0 to
45fa4a1
Compare
Keep sidebar highlights equally inset without moving their text. Share six-pixel corners and one-pixel vertical margins across task, section, and computer rows. Co-Authored-By: Codex GPT-6.1-Sol <noreply@openai.com>
Distinguish hovering a selected task from its resting selection. Paint hover actions and other computers' selected rows with the same theme token. Co-Authored-By: Codex GPT-6.1-Sol <noreply@openai.com>
Use a dedicated sidebar text color in both themes. Keep New Task in the same plain color as task rows, and let selection and project headings use regular weight. Co-Authored-By: Codex GPT-6.1-Sol <noreply@openai.com>
Use sentence case and regular muted text for section labels, with chevrons after them. Put top spacing on heading rows, and remove it between adjacent folded sections while retaining the gap after expanded task rows. Co-Authored-By: Codex GPT-6.1-Sol <noreply@openai.com>
45fa4a1 to
2b71655
Compare
|
UI testing summary — October 27, 2026 Completed 50 live computer-use UI checks across the combined #1278 → #1289 development build: 46 passed, 4 failed. The tested local revision was No defects were attributed to this PR’s sidebar visual polish. The four findings concern the project/grouping and remote integration covered by #1289: overwritten remote folder selection, stale remote pin state, missing Archived access in Status/List, and Connection grouping resetting after restart. Reproduction details and testing limits are in the UI testing report on #1289. The findings remain unfixed pending discussion. |
|
Published refinements — October 27, 2026 Updated This layer contains the calmer row highlights, selected-hover colors, softer typography, section headings/spacing, consistent wordmark color, and the additional 8 px clearance beside the window controls for the sidebar toggle. Project/grouping, task/project menus, connection controls and remote-project selection refinements belong to #1289. Validation used the combined macOS Debug stack against Dev during human refinement and computer-use UI checks. No visual-polish defect was attributed to this layer. The latest formatting/build and focused checks ran at The four bugs in the earlier testing report were fixed in #1289 and received targeted regression checks. Full local unit/integration suites, |
Computer Use UI test report — October 27, 2026Completed native macOS UI testing of the combined #1278 / #1289 stack against Dev with a paired remote Mac. 66 recorded checks: 65 passed and one pre-existing, non-blocking issue. No major regressions found in the tested workflows. Coverage included all four grouping modes with both sort options, empty projects, search, project/task/connection reordering, popup actions and separators, keyboard navigation, sidebar appearance and collapse, local/remote project pickers, new-task placement, draft/attachment retention, and two full app restarts. All four prior bug fixes passed regression checks: remote pins while viewing a local task, immediate visibility of the first archived task, grouping/manual-order persistence after restart, and retaining the selected remote project after a cold launch. Tested source is identical to the published stack tip Scope limits: macOS Debug/Dev only; destructive actions, offline/account transitions, large-history paging, other platforms and full VoiceOver testing were not covered. Drag results were verified; the Computer Use API does not expose a held-drag screenshot for checking the orange line mid-drag. Non-blocking issue — pre-existing and separate from this PRVery narrow windows can clip the main header and composer controls. At approximately 602 × 502 logical pixels, opening the sidebar leaves controls, including Send, off the right edge. Collapsing the sidebar exposes them again. This predates the sidebar work and is outside this PR's scope. Source comparison with master |
|
Tested manually and ready for review. |
AnthonyRonning
left a comment
There was a problem hiding this comment.
Approving as part of stack #1304 (merged together with #1289, which also covers the Vim-off row inset).
Current implementation
This PR gives Maple Work's sidebar calmer visuals so task titles remain the main focus. It is the visual foundation of GitHub stack #1304:
master→ #1278 → #1289.Hands-on testing with local tasks and remote computers led us to simplify the organization model as the stack evolved. This section describes the final implementation. The earlier description, screenshots, and author notes are retained below for historical reference and are superseded by this summary.
Scope of this PR
The organization redesign lives in #1289: Group tasks by: Project, Connection, Status, In one list and Sort tasks by: Last updated, Manual order, together with remote-aware project creation, Pinned placement, drag ordering, and menu refinements. Those behaviors are described in the dependent PR rather than attributed to this visual foundation.
Validation
The combined macOS Debug stack was exercised against Dev with local tasks and a paired remote Mac. The Computer Use report records 66 checks: 65 passed and one pre-existing, nonblocking narrow-window clipping issue outside this PR's scope. This is combined-stack evidence, not a separate final-head run of this layer.
Later layout/pinning refinements received focused Computer Use checks in #1289. The latest combined build at
beeb0f56passed formatting, native compilation, and debug packaging and was launched for manual testing; the final cursor-only change did not rerun the UI suite. Full local unit/integration suites and test-running hooks were skipped during the refinement at the user's request.Foundation head:
9bccfe8a. Base:master.Historical reference
The material below is preserved as a record of earlier designs, screenshots, implementation notes, and checks. It is superseded by the current implementation and validation above.
Previous description and original author material
Current GitHub stack — October 27, 2026
Native GitHub stack #1304: master → #1278 → #1289.
Head:
9bccfe8a1e4b72c905a1f8c779ce0aa24253252f. Base branch:master; tested fork point:1df4cf70.This foundation adds inset row highlights, a clearer selected-hover state, quieter typography and section headings, consistent collapsed/expanded wordmark color, and 8 px more clearance between the window controls and sidebar toggle. Project grouping, ordering, menus, connection controls and device selection are in #1289 above this layer.
Validation: human refinement and computer-use checks exercised the combined macOS Debug stack against Dev. No visual-polish defect was attributed to this layer. The latest formatting/build and focused UI checks passed at
52fdf95b; its Git tree is identical to published combined tip3de538cfafter moving the spacing commit into this foundation. This layer was not separately relaunched after restacking. The four integration bugs from the earlier combined pass were fixed and checked in #1289.Full local unit/integration suites,
just ciand test-running hooks were skipped as requested (MAPLE_HOOK_SKIP=1). Later refinements received targeted UI checks rather than another full UI suite. Historical original-author checks and screenshots below predate this refinement. See the current change/testing comment.Why
What this PR adds
Scroll sideways to compare. Click an image for full size.
Related: foundation of native GitHub stack #1304, with #1289 directly above it. Stack 1 is now included through merged master.
Remote: the same insets, colors and headings apply to other computers' rows and headings.
Details for reviewers (commits, design, files, checks)
Commits
Design
0xbcbdc8dark,0x45454blight); New Task in plain text color; regular weight for the selected task and project headings.mt_3), dropped when another folded heading sits directly above. Gaps are cached when entries rebuild, and a retained boundary heading is remeasured when its predecessor changes, including off-screen headings. Nothing is computed in render.Files (under
apps/maple-agent/app/src/ui):theme.rs,chat/mod.rs,chat/sidebar.rs,chat/sidebar_computers.rs. Four files.Original author checks (historical, before the current rebase; component Nix shell, Xcode 26.5)
cargo fmt --all -- --check: passed, and on each commit individually.cargo clippy -p maple-agent-app --all-targets --locked -- -D warnings: passed.cargo test -p maple-agent-app --locked: 945 passed, 2 ignored on mastere5870485, including a new regression for folding with an off-screen heading.MAPLE_HOOK_SKIP=1) because of the existing updater testinstaller::tests::reads_native_release_tar_format_and_preserves_bundle_modes, which fails only on this machine.Full-size images
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.