Repository navigation
Conversation
doowta
marked this pull request as ready for review
October 25, 2026 18:40
A row clips its title to one line, and nothing in the sidebar says when
a task last changed. Hovering a row now shows a card beside it, like
the Tauri app's and Codex's: the title up to three lines, the
time since the task's last activity ("5m", "3h") at the top right, and
the project with its folder underneath. Pressing the folder opens it in
the file manager when the tasks are on this computer. The row's
accessible description gains the local date and time of the last
activity, so the keyboard and screen readers get it too; an absolute
time never goes stale, and new activity rewrites only its own row's
description.
The pointer can move onto the card, so it is a real floating panel and
goes through popup.rs: a new hover_panel draws it beside its row (new
Placement::Beside) the way menus are drawn, with a hitbox and without
taking focus, so the keyboard stays in the list. The card stays while
the pointer is on the row or the card and goes 200 ms after it leaves
both, enough to cross the gap and shorter than a tooltip's delay. On
the row's buttons the card gives way to their tooltips.
gpui reports hover only when the pointer moves, so rows that move under
a still pointer would leave the card on the wrong task. A scroll (by
wheel or a keyboard reveal), a reorder that moves the hovered row, a
menu, a rename, collapsing the sidebar, or the window losing focus
ends the hover; every pointer
move over a row claims it again, also while another app is in front,
as in other Mac apps. A one-minute timer keeps the age
current, owned by the hover, so it stops whenever the hover ends.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Anchor the details card to the inset task highlight while preserving content alignment. Give hover panels a fixed six-pixel gap and preserve menu spacing and window-edge clamping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
doowta
force-pushed
the
ux/card-release
branch
from
October 25, 2026 20:16
82bedb8 to
6f2904d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
What this PR adds
Scroll sideways to compare. Click an image for full size.
Related: includes the same task-row inset as #1278 (calmer rows), because the card lines up with the row highlight; whichever lands second drops the duplicate. Independent of #1236 (collapsed rail); both touch the sidebar, so the later one gets a small rebase.
Remote: when connected to a paired computer the card's folder line is plain text, with no local Finder; other computers' rows get no card until you switch to that computer.
Details for reviewers (commits, design, files, checks)
Commits
Design
popup::hover_panelusesPlacement::Besideand the shared floating-element measurement and occlusion. It takes no focus, sits 6 px from the highlight, flips left when needed and stays inside the window's 8 px margin.Files (under
apps/maple-agent/app/src):ui/chat/sidebar.rs,ui/chat/mod.rs,ui/chat/navigation.rs,ui/chat/sidebar_paging.rs,ui/chat/tests.rs,ui/popup.rs. 6 files, +821 / −26 (tests +338 / −3, 8 net added tests).Checks (component Nix shell, Xcode 26.5)
cargo fmt --all -- --check: passed.cargo clippy -p maple-agent-app --all-targets --locked -- -D warnings: passed.cargo test -p maple-agent-app --locked: 952 passed, 2 ignored on mastere5870485. The first run had one failure in the unrelatedhost::recovery_tests::quit_accepts_a_missing_owner_but_not_an_unreachable_live_owner, which passed on retry.MAPLE_HOOK_SKIP=1) because of the existing updater testinstaller::tests::reads_native_release_tar_format_and_preserves_bundle_modes, which fails only on this machine.Full-size images
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.