Repository navigation
fix(widgets): restore numeric and boolean strings as typed widget values (PM-2173) - #21246
Conversation
📦 Bundle: 11.6 MB gzip 🔴 +325 BDetailsSummary
Category Glance App Entry Points — 6.92 kB (baseline 6.92 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.39 MB (baseline 3.39 MB) • 🔴 +211 BGraph editor runtime, canvas, workflow orchestration
Status: 3 added / 3 removed / 1 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 9 unchanged Panels & Settings — 784 kB (baseline 784 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed / 28 unchanged User & Accounts — 153 kB (baseline 153 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 12 unchanged Editors & Dialogs — 362 kB (baseline 362 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 6 unchanged UI Components — 225 kB (baseline 225 kB) • ⚪ 0 BReusable component library chunks
Status: 9 added / 9 removed / 21 unchanged Data & Services — 1.2 MB (baseline 1.2 MB) • 🔴 +100 BStores, services, APIs, and repositories
Status: 19 added / 19 removed / 24 unchanged Utilities & Hooks — 1.01 MB (baseline 1.01 MB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 23 added / 23 removed / 54 unchanged Vendor & Third-Party — 24.7 MB (baseline 24.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 20.6 MB (baseline 20.6 MB) • 🔴 +1.4 kBBundles that do not match a named category
Status: 76 added / 76 removed / 611 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-19T15:30:21.315Z",
"gitSha": "aeba6a21b3e224a9c23d271973d5c779c966cf80",
"branch": "glary/coerce-widget-values-on-load",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2019.553000000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.836,
"layouts": 10,
"layoutDurationMs": 2.68,
"taskDurationMs": 383.60499999999996,
"heapDeltaBytes": 4661472,
"heapUsedBytes": 94413748,
"domNodes": -201,
"jsHeapTotalBytes": -266240,
"scriptDurationMs": 9.088999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.9649999999656,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.246,
"layouts": 10,
"layoutDurationMs": 2.033,
"taskDurationMs": 256.78900000000004,
"heapDeltaBytes": -10059300,
"heapUsedBytes": 94053600,
"domNodes": -200,
"jsHeapTotalBytes": 1740800,
"scriptDurationMs": 6.604,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.4329999999752,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.816999999999998,
"layouts": 10,
"layoutDurationMs": 2.4250000000000003,
"taskDurationMs": 564.6669999999999,
"heapDeltaBytes": -12055496,
"heapUsedBytes": 91618804,
"domNodes": -200,
"jsHeapTotalBytes": 6721536,
"scriptDurationMs": 111.12899999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.5279999999716,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.443999999999999,
"layouts": 10,
"layoutDurationMs": 2.184,
"taskDurationMs": 498.54099999999994,
"heapDeltaBytes": -3291124,
"heapUsedBytes": 95950304,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 93.28999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.472999999984,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.974000000000001,
"layouts": 12,
"layoutDurationMs": 3.0730000000000004,
"taskDurationMs": 272.68499999999995,
"heapDeltaBytes": 21587660,
"heapUsedBytes": 109886408,
"domNodes": 47,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 11.747000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.631000000039,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.2059999999999995,
"layouts": 13,
"layoutDurationMs": 2.653,
"taskDurationMs": 180.172,
"heapDeltaBytes": 4917668,
"heapUsedBytes": 108187936,
"domNodes": 47,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 7.5939999999999985,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 533.758000000006,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.1870000000000003,
"layouts": 10,
"layoutDurationMs": 2.5320000000000005,
"taskDurationMs": 348.176,
"heapDeltaBytes": 7645496,
"heapUsedBytes": 114366792,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 110.33,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.20645161290323,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 466.13300000001345,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.916,
"layouts": 11,
"layoutDurationMs": 2.6169999999999995,
"taskDurationMs": 315.442,
"heapDeltaBytes": 6480004,
"heapUsedBytes": 110612392,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 109.41499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 906.7430000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.313,
"heapDeltaBytes": -8398256,
"heapUsedBytes": 102224716,
"domNodes": -230,
"jsHeapTotalBytes": 9351168,
"scriptDurationMs": 37.835,
"eventListeners": -168,
"totalBlockingTimeMs": 260,
"frameDurationMs": 25.463888888888896,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 880.1900000000273,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.809,
"heapDeltaBytes": -7947884,
"heapUsedBytes": 102239024,
"domNodes": -210,
"jsHeapTotalBytes": 9875456,
"scriptDurationMs": 34.579,
"eventListeners": -168,
"totalBlockingTimeMs": 250,
"frameDurationMs": 25.23714285714285,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 698.9550000000122,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.80199999999996,
"heapDeltaBytes": -4246768,
"heapUsedBytes": 96702048,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 93.55400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 89,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 671.846999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 233.59600000000034,
"heapDeltaBytes": -5845068,
"heapUsedBytes": 95469592,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 80.54899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 79,
"frameDurationMs": 20.09999999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6836.384000000009,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8660000000000004,
"layouts": 3,
"layoutDurationMs": 0.6979999999999998,
"taskDurationMs": 5697.127,
"heapDeltaBytes": 21362244,
"heapUsedBytes": 142762828,
"domNodes": -296,
"jsHeapTotalBytes": 34246656,
"scriptDurationMs": 4335.088,
"eventListeners": -130,
"totalBlockingTimeMs": 47,
"frameDurationMs": 19.97982456140351,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5906.510000000026,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8590000000000004,
"layouts": 3,
"layoutDurationMs": 0.6759999999999999,
"taskDurationMs": 4993.821,
"heapDeltaBytes": 18568720,
"heapUsedBytes": 139660840,
"domNodes": -276,
"jsHeapTotalBytes": 30314496,
"scriptDurationMs": 3801.394,
"eventListeners": -130,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.87432024169184,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6576.77000000001,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8669999999999998,
"layouts": 3,
"layoutDurationMs": 0.692,
"taskDurationMs": 5433.007999999999,
"heapDeltaBytes": 10328700,
"heapUsedBytes": 132369144,
"domNodes": -296,
"jsHeapTotalBytes": 29265920,
"scriptDurationMs": 4066.852,
"eventListeners": -130,
"totalBlockingTimeMs": 28,
"frameDurationMs": 18.702272727272728,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5482.240000000047,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8219999999999998,
"layouts": 3,
"layoutDurationMs": 0.7050000000000003,
"taskDurationMs": 4540.2519999999995,
"heapDeltaBytes": 11338592,
"heapUsedBytes": 132441376,
"domNodes": -276,
"jsHeapTotalBytes": 23498752,
"scriptDurationMs": 3565.995,
"eventListeners": -130,
"totalBlockingTimeMs": 19,
"frameDurationMs": 17.406984126984128,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-combo-open",
"durationMs": 138.32800000000134,
"styleRecalcs": 20,
"styleRecalcDurationMs": 11.893,
"layouts": 11,
"layoutDurationMs": 2.8100000000000005,
"taskDurationMs": 99.949,
"heapDeltaBytes": 13225704,
"heapUsedBytes": 118065180,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.132000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.428571428571427,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 129.8659999999927,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.229000000000001,
"layouts": 12,
"layoutDurationMs": 2.6310000000000002,
"taskDurationMs": 94.192,
"heapDeltaBytes": 13267512,
"heapUsedBytes": 118166060,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.438000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2010.1469999999892,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.546,
"layouts": 9,
"layoutDurationMs": 2.292,
"taskDurationMs": 342.218,
"heapDeltaBytes": 8330144,
"heapUsedBytes": 110207768,
"domNodes": -276,
"jsHeapTotalBytes": -5599232,
"scriptDurationMs": 28.132,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2009.3709999999874,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.8839999999999995,
"layouts": 9,
"layoutDurationMs": 1.5939999999999999,
"taskDurationMs": 296.028,
"heapDeltaBytes": 1946716,
"heapUsedBytes": 104179132,
"domNodes": -296,
"jsHeapTotalBytes": -5337088,
"scriptDurationMs": 24.661999999999995,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2166.5479999999775,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.1,
"layouts": 8,
"layoutDurationMs": 2.047,
"taskDurationMs": 1115.8709999999999,
"heapDeltaBytes": 686204,
"heapUsedBytes": 104104532,
"domNodes": -296,
"jsHeapTotalBytes": -393216,
"scriptDurationMs": 554.851,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66641221374046,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2189.3349999999714,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.078,
"layouts": 8,
"layoutDurationMs": 1.7239999999999998,
"taskDurationMs": 1062.3819999999998,
"heapDeltaBytes": -2047404,
"heapUsedBytes": 99140748,
"domNodes": -297,
"jsHeapTotalBytes": -393216,
"scriptDurationMs": 510.8950000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-zoom",
"durationMs": 3604.7790000000077,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.173000000000002,
"layouts": 67,
"layoutDurationMs": 12.389,
"taskDurationMs": 1279.4769999999999,
"heapDeltaBytes": -18596492,
"heapUsedBytes": 95340972,
"domNodes": -272,
"jsHeapTotalBytes": -1691648,
"scriptDurationMs": 520.6229999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3139.427000000012,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.712000000000002,
"layouts": 66,
"layoutDurationMs": 10.574,
"taskDurationMs": 1073.9099999999999,
"heapDeltaBytes": 6980784,
"heapUsedBytes": 111202864,
"domNodes": 24,
"jsHeapTotalBytes": 4984832,
"scriptDurationMs": 486.26699999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137568,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3051.9820000000095,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.823,
"layouts": 7,
"layoutDurationMs": 1.8190000000000002,
"taskDurationMs": 1461.321,
"heapDeltaBytes": 23163712,
"heapUsedBytes": 127280076,
"domNodes": 0,
"jsHeapTotalBytes": 5926912,
"scriptDurationMs": 701.175,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75714285714286,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2137.569000000042,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.145,
"layouts": 7,
"layoutDurationMs": 1.5739999999999998,
"taskDurationMs": 1072.354,
"heapDeltaBytes": 14890600,
"heapUsedBytes": 118690908,
"domNodes": 0,
"jsHeapTotalBytes": 5140480,
"scriptDurationMs": 589.8919999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666406249999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2005.2759999999807,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7339999999999995,
"layouts": 9,
"layoutDurationMs": 2.2729999999999997,
"taskDurationMs": 351.72499999999997,
"heapDeltaBytes": 4038960,
"heapUsedBytes": 107109224,
"domNodes": -296,
"jsHeapTotalBytes": -4812800,
"scriptDurationMs": 27.802999999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "minimap-idle",
"durationMs": 2005.4660000000126,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.8509999999999993,
"layouts": 9,
"layoutDurationMs": 1.652,
"taskDurationMs": 370.81899999999996,
"heapDeltaBytes": -1200596,
"heapUsedBytes": 102733264,
"domNodes": -276,
"jsHeapTotalBytes": -1863680,
"scriptDurationMs": 19.37,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 480.6120000000078,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.918999999999999,
"layouts": 10,
"layoutDurationMs": 2.575,
"taskDurationMs": 311.517,
"heapDeltaBytes": 2706644,
"heapUsedBytes": 108369936,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 99.246,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 431.1569999999847,
"styleRecalcs": 50,
"styleRecalcDurationMs": 5.457,
"layouts": 11,
"layoutDurationMs": 2.6290000000000004,
"taskDurationMs": 282.595,
"heapDeltaBytes": -83028,
"heapUsedBytes": 101689064,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 93.53500000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.7079999999844,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.189000000000001,
"layouts": 10,
"layoutDurationMs": 2.709,
"taskDurationMs": 353.031,
"heapDeltaBytes": 4560852,
"heapUsedBytes": 97165928,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.090000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.2089999999985,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.213,
"layouts": 10,
"layoutDurationMs": 1.8470000000000002,
"taskDurationMs": 336.31600000000003,
"heapDeltaBytes": -8495820,
"heapUsedBytes": 97232056,
"domNodes": -198,
"jsHeapTotalBytes": 1740800,
"scriptDurationMs": 5.877999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1943.8330000000121,
"styleRecalcs": 85,
"styleRecalcDurationMs": 14.777000000000001,
"layouts": 10,
"layoutDurationMs": 2.462,
"taskDurationMs": 817.766,
"heapDeltaBytes": -6569584,
"heapUsedBytes": 93972152,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 88.854,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66581196581197,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.2259999999496,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.322999999999999,
"layouts": 10,
"layoutDurationMs": 1.898,
"taskDurationMs": 531.4610000000001,
"heapDeltaBytes": -13465956,
"heapUsedBytes": 92374032,
"domNodes": -190,
"jsHeapTotalBytes": 3313664,
"scriptDurationMs": 73.24600000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 766.5049999999951,
"styleRecalcs": 21,
"styleRecalcDurationMs": 15.056,
"layouts": 5,
"layoutDurationMs": 9.107000000000001,
"taskDurationMs": 469.174,
"heapDeltaBytes": 35751872,
"heapUsedBytes": 139908384,
"domNodes": 15950,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 17.935,
"eventListeners": 3244,
"totalBlockingTimeMs": 71,
"frameDurationMs": 19.165,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8904.888000000028,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.519000000000005,
"layouts": 9,
"layoutDurationMs": 2.3309999999999995,
"taskDurationMs": 4315.7300000000005,
"heapDeltaBytes": 1312772,
"heapUsedBytes": 103720728,
"domNodes": -296,
"jsHeapTotalBytes": -917504,
"scriptDurationMs": 1923.959,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666168224299064,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8136.329999999987,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.541000000000004,
"layouts": 9,
"layoutDurationMs": 1.9000000000000001,
"taskDurationMs": 3256.236,
"heapDeltaBytes": 639256,
"heapUsedBytes": 103252612,
"domNodes": -297,
"jsHeapTotalBytes": -393216,
"scriptDurationMs": 1767.3190000000002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618852459016,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12579.573000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11633.67,
"heapDeltaBytes": -24884596,
"heapUsedBytes": 295029672,
"domNodes": -3337,
"jsHeapTotalBytes": 35901440,
"scriptDurationMs": 196.47199999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.25472972972973,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 14618.570999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13663.130999999998,
"heapDeltaBytes": -35233080,
"heapUsedBytes": 299049856,
"domNodes": -3337,
"jsHeapTotalBytes": 25415680,
"scriptDurationMs": 168.016,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.77305084745763,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 17452.00600000004,
"styleRecalcs": 144,
"styleRecalcDurationMs": 15.828000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17095.881,
"heapDeltaBytes": -12271576,
"heapUsedBytes": 288605988,
"domNodes": -3337,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 610.3729999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.55466417910448,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 14218.127000000039,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.357000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13570.127,
"heapDeltaBytes": -3964872,
"heapUsedBytes": 301859636,
"domNodes": -3341,
"jsHeapTotalBytes": 25153536,
"scriptDurationMs": 656.424,
"eventListeners": -651,
"totalBlockingTimeMs": 68,
"frameDurationMs": 25.10194003527337,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4155.147999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 39.134,
"layouts": 20,
"layoutDurationMs": 18.724000000000004,
"taskDurationMs": 3993.1169999999997,
"heapDeltaBytes": -6626012,
"heapUsedBytes": 299109196,
"domNodes": -3337,
"jsHeapTotalBytes": 30920704,
"scriptDurationMs": 61.19199999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.12674418604652,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4202.2739999999885,
"styleRecalcs": 20,
"styleRecalcDurationMs": 41.24999999999998,
"layouts": 20,
"layoutDurationMs": 18.67300000000001,
"taskDurationMs": 4064.0599999999995,
"heapDeltaBytes": -27577056,
"heapUsedBytes": 282321072,
"domNodes": -3337,
"jsHeapTotalBytes": 34328576,
"scriptDurationMs": 62.73999999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.13735632183908,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7329.897000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6880.385,
"heapDeltaBytes": 10778548,
"heapUsedBytes": 289915824,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 86.15499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.027645051194533,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7391.5250000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6973.324,
"heapDeltaBytes": 109112,
"heapUsedBytes": 270330048,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 83.53300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.112244897959183,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 436.0510000000204,
"styleRecalcs": 15,
"styleRecalcDurationMs": 7.589,
"layouts": 12,
"layoutDurationMs": 2.9920000000000004,
"taskDurationMs": 86.90999999999998,
"heapDeltaBytes": -8613520,
"heapUsedBytes": 92141892,
"domNodes": 98,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 7.766,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 76.50200000000495,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.545000000000001,
"layouts": 6,
"layoutDurationMs": 1.9950000000000003,
"taskDurationMs": 52.290000000000006,
"heapDeltaBytes": 4681880,
"heapUsedBytes": 106458528,
"domNodes": 117,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.458000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 184.65900000001056,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.5670000000000001,
"layouts": 76,
"layoutDurationMs": 8.779,
"taskDurationMs": 139.16899999999998,
"heapDeltaBytes": 9002848,
"heapUsedBytes": 96466892,
"domNodes": 4,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 58.433,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.672727272727283,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 181.04799999991883,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.575,
"layouts": 76,
"layoutDurationMs": 8.885,
"taskDurationMs": 145.232,
"heapDeltaBytes": 9258036,
"heapUsedBytes": 96480516,
"domNodes": 4,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 61.931,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.672727272727283,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 232.95099999995728,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.165,
"layouts": 76,
"layoutDurationMs": 8.45,
"taskDurationMs": 191.43900000000002,
"heapDeltaBytes": -6849428,
"heapUsedBytes": 108320944,
"domNodes": 4,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 63.92099999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 229.94900000003327,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.1640000000000001,
"layouts": 76,
"layoutDurationMs": 9.058,
"taskDurationMs": 190.89899999999997,
"heapDeltaBytes": -2090104,
"heapUsedBytes": 117829560,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 63.787,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2950 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 561d24e7642cc272eb87415a511c45d91169549e
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (104)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
|
This is CodeRabbit's "review in progress" placeholder. It contains no findings yet, so I made no changes. I'll address any findings once the review lands. |
|
Thanks. This review approved the PR without any specific comments, so I made no code changes. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21246 +/- ##
==========================================
+ Coverage 86.66% 87.50% +0.84%
==========================================
Files 3776 2700 -1076
Lines 178636 150060 -28576
Branches 47282 41251 -6031
==========================================
- Hits 154809 131317 -23492
+ Misses 21768 18353 -3415
+ Partials 2059 390 -1669
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1106 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 2 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
There was a problem hiding this comment.
Verdict: ready for human review. The coercion is correct at every restore path I traced, and what remains is P3 test gaps and small simplifications.
I traced each wiring site the description lists: positional and named configure, addCustomWidget during configure, PrimitiveNode, promoted-widget restore, legacy migration, quarantine, and the DynamicGroup row-count guard. Reverting the coercion at any one of the eight sites turns its new test red. The six changed suites pass at 00e2a77 (231 tests), and every check that ran at this head passed.
There are no pre-merge blockers. I left nine inline comments, each with a committable suggestion:
- P3: the decimal regex backtracks quadratically on long rejected digit runs. The suggested grouping accepts and rejects the same strings.
- P3: three table rows the coercion tests miss: a string-backed colour, the largest safe integer, and
1e400overflow. Each matches a mutation that currently passes all 22 cases. - P3: two test simplifications. One drops a call-history assertion the throwing stub already covers. The other folds the duplicated legacy-migration test into the test above it.
- P3 / Nit: a duplicated
widgetIdguard, onesetValueconvention for store writes, and reuse of the existingsetupPromotedWidgetfixture.
Findings without an anchorable line
- P3, browser regression coverage. This PR changes no file under
browser_tests/. The black-box test for PM-2173 is in #21247, which is still open and targets this branch, notmain..coderabbit.yamlasks fix PRs to add or update a browser regression. Please land the two together, or fold the spec into this PR, so the fix does not reachmainwithout its end-to-end check.
Existing findings confirmed or contested
- Confirmed as addressed: the radix-literal finding (discussion_r4305286430). At
00e2a77,coerceNumericStringrejects anything outside the decimal/exponent grammar before it callsNumber(widget.ts:46), and the hex, binary, and octal rows pin it. Removing the regex fails those rows. - Contested: the INT-fraction nit (discussion_r4305286437). The mismatch is real (
'1536.5'restores as 1536.5,toFixed(0)shows 1537, and Pythonint()gives 1536). But an already-numeric saved1536.5goes down the same path today, so this PR does not introduce it.useIntWidget.tsanduseFloatWidget.tsboth producenumber/slider/knobwidgets, and FLOAT can use precision 0, so rounding here would corrupt the pinned29.97case. I agree with leaving it. Theoptionsparameter is still needed because the colour branch readsoptions.format.
Checked and cleared
- Direct
state.value =inSubgraphNodeskips store behavior: no.setValueis lookup, assign, and returntrue(widgetValueStore.ts:327-332). The registered accessor emits intent, not the action. The inline Nit is about keeping one convention, not a bug. setRestoredInputValuechanges success semantics in migration: no. Missing state still returnsfalse, and the hole branch is unchanged.- DynamicGroup guard compares the wrong value: no. The saved value is coerced with the same controller before the equality check, and a missing value is still
undefined, which never equals the finite numeric setter input. - PrimitiveNode target default overwrites the restored value: no. The coerced saved value is applied after the target value is copied.
- Grammar edge cases: padded numbers,
1.,+5,-0,.5,5.,NaN,1_000, radix text, unsafe integers, and underflow all behave as the description states. - Fallow reports two new warning-level boundary imports into
utils/widget.ts, fromLGraphNode.tsandproxyWidgetMigration.ts. Neither adds a new zone direction:LGraphNodealready imports./widgets/BaseWidgetand./widgets/widgetMap, andproxyWidgetMigrationalready importsuseWidgetValueStore. The PR description discloses both. - The diff adds one comment block, the JSDoc on the exported
coerceRestoredWidgetValue. It states the contract in two lines, which the comment policy allows. The deleted comments are in functions the PR modifies, which the guidance requires. - The diff adds no methods to
LGraphNode,SubgraphNode, or the other god objects, and it adds no barrel re-exports,any, casts, or positional flag parameters. - The
precisioncolumn in the coercion table is unread by the code, but it is not noise. The29.97at precision 0 row and the unsafe-integer-without-precision row fail if someone later rounds or gates by precision.
Coverage
Depth standard. Ran the correctness, maintainability, and tests lanes over all 12 files, with blast-radius, regression-risk, boundary-discipline, root-cause, shared-state, ponytail, no-comments, reader-load, legacy-API, type-discipline, designing-test-suites, reviewing-unit-tests, and mock-quality lenses. Fallow audit ran against the merge base. I applied every suggestion together in a scratch copy and ran the six suites: 233 passed, formatted clean. The open-PR overlap search hit its 1,000-result cap. I checked the relevant hunks of #20880, #20877, #21041, #20055, #14955 and others and found no conflicting coercion policy, but the list is not exhaustive. I did not run the #21247 Playwright spec.
Review record
Round 1 at 00e2a77 (this review): M1 regex backtracking (P3), M2 duplicate widgetId guard (P3), M3 store-write convention (Nit), T1 to T3 missing table rows (P3), T4 redundant call assertion (P3), T5 fixture reuse (Nit), T6 duplicate migration test (P3), B1 browser coverage in #21247 (P3). All open.
Checks at this head: six changed Vitest suites, 231 passed. Eight per-site coercion reverts each went red. Three parser mutations survive (colour gate, safe-integer bound, finite check), which T1 to T3 cover. CI: 92 succeeded, 30 skipped, 0 failed.
|
@dante01yoon could you take a look? This is widgets rather than agent, but it needs a The bug: a workflow that saved an INT or FLOAT widget value as a string keeps the string after loading. The fix puts restored values through one helper, Those two exclusions, and whether the six restoration paths are the complete set, are the parts worth a second opinion. #21247 is the matching browser test that loads stringified values and asserts the queued prompt contains numbers. |
00e2a77 to
ea1fc3b
Compare
|
All review findings are addressed in ea1fc3b. The browser regression from #21247 is now folded into this PR: it verifies that saved numeric strings queue as numbers and captures the restored boolean visibly changing from false to true. Focused mutations fail when numeric coercion, boolean coercion, or the click is removed. @DrJKL, could you take a look once the new CI run finishes? |
Addresses review feedback: #21246 (comment)
Addresses review feedback: #21246 (comment)
Addresses review feedback: #21246 (comment)
Addresses review feedback: #21246 (comment)
The queued-prompt assertion now covers the restored boolean too, so the title no longer says numbers only. Follows review feedback: #21246 (comment)
There was a problem hiding this comment.
Verdict: ready for human review. Every round-2 finding except the unverified fixture-size note is fixed at 7bc18a7, and the browser spec now passes in CI against a real backend.
The spec is down to one test: one workflow load, one queue, and a prompt assertion that checks the numeric and boolean values. The redundant polls, the synthetic job-ID match, the second boolean test, its @screenshot tag, both baselines, and the unknown-keys unit test are gone. CI at this head: 96 succeeded, 31 skipped, 0 failed. e2e-status and every playwright-tests shard succeeded. You answered every thread, so I added no thread replies.
One P3 item is still open, and it doesn't block:
- P3, unverified:
browser_tests/assets/widgets/stringified_typed_widget_values.jsonstill carries the full text-to-image graph (eight nodes, nine links), while the spec reads only nodes 3, 5 and 10.ExecutionHelper.runintercepts/api/prompt, so the extra nodes likely aren't needed. Running the spec against a three-node version of the asset would settle it.
Review record
Round 1, review 5561141565 at 00e2a77:
- P3, regex backtracking: fixed at
ea1fc3b, reply. - P3, duplicate
widgetIdguard: fixed atea1fc3b, reply. - Nit, write through
setValue: fixed atea1fc3b, reply. - P3, largest safe integer row: fixed at
ea1fc3b, reply. - P3,
1e400overflow row: fixed atea1fc3b, reply. - P3, string-backed colour row: fixed at
ea1fc3b, reply. - P3, redundant
not.toHaveBeenCalled: fixed atea1fc3b, reply. - Nit, reuse
setupPromotedWidget: fixed atea1fc3b, reply. - P3, fold duplicate legacy-migration test: fixed at
ea1fc3b, reply. - P3, browser regression lived in #21247: fixed at
ea26f7e. - The radix-literal finding from the cursor panel was fixed before round 1. I contested its INT-fraction nit, and you kept the behavior.
Round 2, review 5571589349 at ea1fc3b:
- P2, fold the boolean test into the prompt assertion: fixed at
0dd2f72,6f80985and6a5ff45, reply, CI confirmation. - P3, redundant widget polls: fixed at
bc4ece9, reply. - P3, synthetic job-ID match: fixed at
69b35b8, reply. - P3, unknown-keys unit test: fixed at
85a241d, reply. - P3 (unverified), shrink the fixture: open, carried above.
Round 3, this review at 7bc18a7: no new findings. I read the delta inline (spec, two deleted baselines, one deleted unit test). Checks at this head: CI 96 succeeded, 31 skipped, 0 failed, including e2e-status and all playwright-tests shards.
Resolve the widgetInputs.ts import conflict with Comfy-Org#21246: keep IWidgetLocator from types/widgets alongside main's new coerceRestoredWidgetValue import.
PR #21246 added coerceRestoredWidgetValue at six restore call sites plus a re-coercion in the DynamicGroup row-count guard. Move the policy into a pure module (utils/restoredWidgetValue.ts) and apply it in exactly one owner: - getRestoredWidgetValue now takes the widget and returns its saved value already converted, so LGraphNode.configure, addCustomWidget, PrimitiveNode and the DynamicGroup guard read a typed value with no local coercion. - New restoreValue action sets a widget to a saved value through the same policy; promoted-widget restore and both legacy proxyWidgets migration arms use it instead of getWidget + setValue + coerce. - PrimitiveNode reads its saved value after the widget exists, so the store has the widget's type. - The policy module is classified as node-widgets/domain, which removes the boundary warnings #21246 introduced (LGraphNode -> utils/widget, proxyWidgetMigration -> utils/widget). No behavior change: the existing per-path tests pass unchanged, and each one goes red if the store stops converting. Refs FE-3504
… max (#21441) Manual backport of #21264 to `core/1.57`. The cherry-pick conflicted in `dynamicGroupWidget.test.ts` because #21246 is not on this branch. The test `rejects an unsupported saved row count stored as a numeric string` is left out: it depends on #21246 converting numeric strings, and without that change a numeric string is never read as a row count, so there is nothing for the guard to refuse. `dynamicGroupWidget.test.ts` and `dynamicGroupDiagnostics.test.ts` pass (73 tests), and `pnpm typecheck` passes.
…e max (#21442) Manual backport of #21264 to `cloud/1.57`. The cherry-pick conflicted in `dynamicGroupWidget.test.ts` because #21246 is not on this branch. The test `rejects an unsupported saved row count stored as a numeric string` is left out: it depends on #21246 converting numeric strings, and without that change a numeric string is never read as a row count, so there is nothing for the guard to refuse. `dynamicGroupWidget.test.ts` and `dynamicGroupDiagnostics.test.ts` pass (73 tests), and `pnpm typecheck` passes.
… max (#21443) Manual backport of #21264 to `core/1.58`. The cherry-pick conflicted in `dynamicGroupWidget.test.ts` because #21246 is not on this branch. The test `rejects an unsupported saved row count stored as a numeric string` is left out: it depends on #21246 converting numeric strings, and without that change a numeric string is never read as a row count, so there is nothing for the guard to refuse. `dynamicGroupWidget.test.ts` and `dynamicGroupDiagnostics.test.ts` pass (73 tests), and `pnpm typecheck` passes.
…e max (#21444) Manual backport of #21264 to `cloud/1.58`. The cherry-pick conflicted in `dynamicGroupWidget.test.ts` because #21246 is not on this branch. The test `rejects an unsupported saved row count stored as a numeric string` is left out: it depends on #21246 converting numeric strings, and without that change a numeric string is never read as a row count, so there is nothing for the guard to refuse. `dynamicGroupWidget.test.ts` and `dynamicGroupDiagnostics.test.ts` pass (73 tests), and `pnpm typecheck` passes.
…-Org#21378) ## Summary Stacked on Comfy-Org#21246. That PR fixed PM-2173 by calling `coerceRestoredWidgetValue` at six restore call sites plus a re-coercion in the DynamicGroup guard. This moves the conversion into `widgetValueStore`, so it has one production caller: - `getRestoredWidgetValue` takes the widget and returns its saved value already converted. `LGraphNode.configure`, `addCustomWidget`, PrimitiveNode and the DynamicGroup guard drop their local coercion. - A new `restoreValue(widgetId, saved)` action replaces `getWidget` + `setValue` + coerce in promoted-widget restore and both legacy `proxyWidgets` migration arms. - PrimitiveNode now reads its saved value after creating the widget, so the store knows the widget's type. - The pure policy moves to `utils/restoredWidgetValue.ts`, classified as node-widgets/domain. This removes the two Fallow boundary warnings Comfy-Org#21246 added. Leaving it in `utils/widget.ts` would create a type-only import cycle with the store. Not covered: API-format prompt import in `app.ts` still assigns raw values. It is a separate boundary, tracked in FE-3504. Refs FE-3504 ## Verification - No behavior change. The Comfy-Org#21246 per-path tests pass unchanged, and all eight go red when the store stops converting (mutation run). - The coercion table moved with the function to `restoredWidgetValue.test.ts`. - Vitest across utils, widgets, migration, PrimitiveNode, LGraphNode, subgraph and widgetValueStore suites: 992 passed. - Pre-commit (oxfmt, oxlint, eslint, `typecheck:app`) and pre-push (deps:audit, knip, fallow audit) hooks passed. `architecture:check` passed.
#21246 merged stringifiedTypedWidgetValues.spec.ts with the fix, and its queued-prompt assertion already covers everything this PR's queue half checked, against an asset that differs from this PR's only by one boolean node. Review on #21247 asked whether a second spec and a near-duplicate 234-line fixture were deliberate. They were not, so both are removed. The one assertion that was not redundant is kept, inside the existing test: after load, the canvas widgets themselves hold 512, 768, 20 and 7.5. The queued-prompt assertion cannot see that. Mutation evidence on a local CPU backend: with restore-time coercion bypassed and coercion moved into graphToPrompt instead, the merged spec passes 2/2 while this check fails with "512" etc. on the canvas, which is the state that makes step arrows concatenate ("1536" + 128 -> "1536128"). Bypassing coercion entirely fails both. Unmutated: 5/5 passed.
…ly in the queued prompt (PM-2173) (Comfy-Org#21247) *PR Created by the Glary-Bot Agent; narrowed 2026-10-26 after review.* --- Follow-up to Comfy-Org#21246, which merged the PM-2173 fix on 2026-10-19 together with `stringifiedTypedWidgetValues.spec.ts`. That spec loads a workflow with stringified numeric and boolean widget values and checks the queued `/api/prompt` body. This PR now adds one check to that existing test. It no longer adds its own spec or fixture. ## What After the workflow loads, and before anything is queued, the canvas widgets must hold numbers: `EmptyLatentImage` width `512` and height `768`, and `KSampler` steps `20` and cfg `7.5`. The queued-prompt assertion can't see this. If coercion ran only on the way to `/api/prompt`, the prompt would be correct while the canvas still held `"512"`. In that state step arrows join strings instead of adding (`"1536" + 128` becomes `"1536128"`), which is the user-visible PM-2173 symptom. ## Removed `stringifiedNumericWidgetValues.spec.ts` and `stringified_numeric_widget_values.json`. Its queue assertion was a strict subset of the merged spec's. Its fixture was the merged fixture minus the boolean node. Folding the check in adds no browser case and no fixture. ## Verification Local Chromium, exact-head Vite dev server, real local CPU ComfyUI backend (`comfyui-ci-container:0.0.28`): | Source state | Merged spec on `main` | This PR's spec | |---|---|---| | Unmutated | pass | 5/5 pass | | Restore coercion bypassed (`coerceRestoredWidgetValue` returns its input) | fail | fail (canvas check) | | Restore coercion bypassed, coercion moved into `graphToPrompt` | **2/2 pass** | **fail**: canvas holds `"512"`, `"768"`, `"20"`, `"7.5"` | The third row is the regression only this check catches. `typecheck:browser`, oxfmt, oxlint, and the pre-commit and pre-push hooks passed. ## Related - Comfy-Org#21246: the fix and the merged spec. - workflow_templates#1361 fixes the templates; workflow_templates#1360 adds a CI check. --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
…d to be converted (Comfy-Org#22468) ## Summary A workflow that stores a number or boolean as text (`"1536"`) has been converted silently on load since Comfy-Org#21246, so template authors and bug reports can't see that the file is wrong. This logs one console warning per load. ## Changes - **What**: `widgetValueStore` collects each conversion from `getRestoredWidgetValue` and `restoreValue`, and logs them as one `console.warn` listing node, input and stored value. Conversions in one synchronous load share a warning, flushed on a microtask. The returned values don't change. - **Not included**: no user-facing toast, per the ticket. ## Review Focus Whether a microtask is the right boundary for "one load". A load spread across several ticks logs one warning per tick, which is noisy but harmless. Fixes FRONT-3660. Follow-up from PM-2173.
PR Created by the Glary-Bot Agent
Summary
Workflows that saved an INT or FLOAT value as a string, like
"1536"forTrellis2UpsampleStage.target_resolutionin the Pixal3D templates (PM-2173), kept the string after loading. The prompt then sent"1536", and step arrows joined strings instead of adding:"1536" + 128became"1536128"and was clamped to the 2048 max.Restored values now go through
coerceRestoredWidgetValue:"true"and"false"values to booleans.The helper runs at each saved-value restoration path covered here: ordinary positional and named widget values, custom widgets created during configure, PrimitiveNode widgets, current promoted subgraph widgets, and both legacy
proxyWidgetsmigration arms. The DynamicGroup saved-row-count guard compares the coerced value so a saved numeric string cannot bypass its maximum.Review repairs
The review found and this PR now addresses:
The browser regression from #21247 is folded into this PR. It loads a workflow containing stringified numeric and boolean values and checks that the queued prompt contains real numbers and a real boolean. Toggling a boolean widget is already covered by
Boolean widget > Can toggleinwidget.spec.ts.Verification
typecheck:appandtypecheck:browserpassed.Related work