Repository navigation
[backport core/1.57] fix: refuse remote DynamicGroup row counts above max - #21441
Conversation
A remote write to a DynamicGroup row count goes straight through the controller setter, which normalizes to `Math.max(min, trunc(value))` and never applies `max`. So `rows = 25` on a `max: 20` group quietly creates 25 rows, and a very large value can freeze the tab adding rows one at a time. The remote apply path now refuses a row count that would grow the group past `max` before touching the setter. Nothing changes on the node, the apply counts as a failure, and the existing remote mismatch report fires. A group restored with more rows than `max` can still re-apply its own count or shrink; only growth past `max(max, current rows, rows the document carries values for)` is refused, so a rollback or undo can bring back rows the doc still holds. The shared setter is left alone on purpose: restoring a saved workflow must keep rows it already has beyond `max`. - Fixes #21095 | Commit | CI Status | Purpose | |--------|-----------|---------| | `test: cover remote DynamicGroup row counts above max` (c76a686) | :red_circle: [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39096366190) | Proves the test catches the bug | | `fix: refuse remote DynamicGroup row counts above max` (a54e8b3) | :green_circle: [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39098010935) | Proves the fix resolves the bug | | `test: cover a remote row count above max on a restored DynamicGroup` (dcf95ae) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39100669923) | A restored group already above `max` still counted the refused write as a success | | `fix: report a refused remote row count even when the group already holds it` (7457a8c) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39101290723) | Above-max requests are always reported as refused | | `test: accept remote row counts that do not grow a restored DynamicGroup` (b027386) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39107083689) | Re-applying or shrinking a restored above-max group was reported as a refusal | | `fix: refuse only remote row counts that grow a DynamicGroup past max` (15db48a) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39107937126) | Only growth past `max(max, current rows)` is refused | | `test: restore rows a remote rollback still documents above max` (32c99ae) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39117022789) | A rollback to rows the doc still holds was refused after a local remove | | `fix: count documented DynamicGroup rows toward the remote row ceiling` (bc77798) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39117879853) | The ceiling also counts rows the document carries values for | - [x] CI red on test-only commit (only the two new above-max cases fail) - [x] CI green on fix commit - Unit coverage for a remote count at `max` (applies), `max + 1` and `1e9` (refused, no row allocated, mismatch reported), a saved workflow with rows above `max` (restored as is), and on such a restored group: re-applying the same count or shrinking applies, growing further is refused, and growing back to rows the doc still carries values for applies. The large-value case spies on `addCustomWidget` so the red commit fails fast instead of hanging. - No E2E: the remote apply path is covered at the `LiveGraphApplier` level with a followed Y.Doc, which is where the refusal lives. (cherry picked from commit f66a36f)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-20T10:58:32.199Z",
"gitSha": "c249348dfeb8215dcd68f15215d4b0ad522b6490",
"branch": "backport-21264-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.214000000019,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.731,
"layouts": 10,
"layoutDurationMs": 3.9120000000000004,
"taskDurationMs": 465.314,
"heapDeltaBytes": 21685064,
"heapUsedBytes": 88070900,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 14.522000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.2760000000235,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.304,
"layouts": 10,
"layoutDurationMs": 3.3550000000000004,
"taskDurationMs": 610.209,
"heapDeltaBytes": -859928,
"heapUsedBytes": 73607024,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 13.196999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.7559999999949,
"styleRecalcs": 79,
"styleRecalcDurationMs": 16.400000000000002,
"layouts": 9,
"layoutDurationMs": 2.6809999999999996,
"taskDurationMs": 933.9280000000001,
"heapDeltaBytes": -7770872,
"heapUsedBytes": 66687176,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 169.397,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2024.6670000000222,
"styleRecalcs": 86,
"styleRecalcDurationMs": 17.212000000000003,
"layouts": 10,
"layoutDurationMs": 3.1610000000000005,
"taskDurationMs": 1177.8619999999999,
"heapDeltaBytes": -16193248,
"heapUsedBytes": 58250220,
"domNodes": -162,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 172.348,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.599000000012,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.23,
"layouts": 11,
"layoutDurationMs": 3.2729999999999997,
"taskDurationMs": 453.84100000000007,
"heapDeltaBytes": -4493164,
"heapUsedBytes": 69940704,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 16.144,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.2680000000282,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.052999999999999,
"layouts": 11,
"layoutDurationMs": 3.646,
"taskDurationMs": 365.227,
"heapDeltaBytes": 18761100,
"heapUsedBytes": 84623380,
"domNodes": 47,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 17.665,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 650.5750000000035,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.766,
"layouts": 8,
"layoutDurationMs": 2.6740000000000004,
"taskDurationMs": 474.263,
"heapDeltaBytes": 25723644,
"heapUsedBytes": 91116604,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 182.07399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 725.9660000000849,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.830000000000001,
"layouts": 9,
"layoutDurationMs": 2.6569999999999996,
"taskDurationMs": 515.4669999999999,
"heapDeltaBytes": 2443168,
"heapUsedBytes": 76934212,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 168.30700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1237.874999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 959.64,
"heapDeltaBytes": 1720024,
"heapUsedBytes": 81565264,
"domNodes": -192,
"jsHeapTotalBytes": 13639680,
"scriptDurationMs": 69.29699999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 554,
"frameDurationMs": 33.335135135135125,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1221.8490000000202,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 932.9359999999999,
"heapDeltaBytes": 533792,
"heapUsedBytes": 80892448,
"domNodes": -192,
"jsHeapTotalBytes": 13639680,
"scriptDurationMs": 72.046,
"eventListeners": -105,
"totalBlockingTimeMs": 527,
"frameDurationMs": 32.881081081081064,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 888.939999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.6259999999997,
"heapDeltaBytes": -3065368,
"heapUsedBytes": 77620592,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 168.435,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.533333333333328,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.8349999999755,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.1460000000002,
"heapDeltaBytes": -5701372,
"heapUsedBytes": 73830040,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 167.612,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9899.79199999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8994.322,
"heapDeltaBytes": -3952452,
"heapUsedBytes": 94924412,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 7500.477,
"eventListeners": -68,
"totalBlockingTimeMs": 1015,
"frameDurationMs": 32.564473684210526,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11033.844999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10172.115,
"heapDeltaBytes": 1656196,
"heapUsedBytes": 95717620,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 8325.576,
"eventListeners": -67,
"totalBlockingTimeMs": 1193,
"frameDurationMs": 31.254674220963178,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10051.012000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9177.529,
"heapDeltaBytes": -15970604,
"heapUsedBytes": 83045604,
"domNodes": -258,
"jsHeapTotalBytes": 9826304,
"scriptDurationMs": 7704.6939999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 1164,
"frameDurationMs": 31.4046875,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10593.620999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9724.178,
"heapDeltaBytes": -23730336,
"heapUsedBytes": 75997076,
"domNodes": -258,
"jsHeapTotalBytes": 9039872,
"scriptDurationMs": 7868.998000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 981,
"frameDurationMs": 31.17529411764706,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 234.7459999999728,
"styleRecalcs": 23,
"styleRecalcDurationMs": 18.799999999999997,
"layouts": 10,
"layoutDurationMs": 3.09,
"taskDurationMs": 180.39300000000003,
"heapDeltaBytes": 13090216,
"heapUsedBytes": 91982252,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.505,
"eventListeners": 195,
"totalBlockingTimeMs": 6,
"frameDurationMs": 25.922222222222242,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 227.96599999992395,
"styleRecalcs": 24,
"styleRecalcDurationMs": 18.776999999999997,
"layouts": 11,
"layoutDurationMs": 3.8909999999999996,
"taskDurationMs": 171.43200000000002,
"heapDeltaBytes": -7619384,
"heapUsedBytes": 80108456,
"domNodes": 917,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 10.104000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 4,
"frameDurationMs": 23.339999999999964,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2025.225999999975,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.849999999999999,
"layouts": 8,
"layoutDurationMs": 2.832,
"taskDurationMs": 720.81,
"heapDeltaBytes": -3656128,
"heapUsedBytes": 75304652,
"domNodes": -278,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 36.331999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.682000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.927,
"layouts": 8,
"layoutDurationMs": 2.5970000000000004,
"taskDurationMs": 714.388,
"heapDeltaBytes": -2446820,
"heapUsedBytes": 76617872,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 34.766000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2382.5580000000173,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.796000000000001,
"layouts": 7,
"layoutDurationMs": 2.1790000000000003,
"taskDurationMs": 1608.4579999999996,
"heapDeltaBytes": -9889892,
"heapUsedBytes": 70481748,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 871.985,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.782394366197185,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2378.268999999932,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.357000000000001,
"layouts": 6,
"layoutDurationMs": 1.45,
"taskDurationMs": 1594.1089999999997,
"heapDeltaBytes": -11822048,
"heapUsedBytes": 67898704,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 841.963,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.902127659574468,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3987.9720000000134,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.282,
"layouts": 64,
"layoutDurationMs": 11.602,
"taskDurationMs": 1956.0020000000002,
"heapDeltaBytes": 12963560,
"heapUsedBytes": 90186100,
"domNodes": -234,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 873.047,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666108786610877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3601.694000000066,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.602000000000001,
"layouts": 64,
"layoutDurationMs": 10.688999999999998,
"taskDurationMs": 1606.232,
"heapDeltaBytes": 1595980,
"heapUsedBytes": 83710072,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 821.465,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74325581395349,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3218.8319999999635,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.131,
"layouts": 4,
"layoutDurationMs": 0.9999999999999996,
"taskDurationMs": 2055.9529999999995,
"heapDeltaBytes": 16395672,
"heapUsedBytes": 94281268,
"domNodes": 0,
"jsHeapTotalBytes": 2777088,
"scriptDurationMs": 1000.61,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.928947368421053,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3206.8249999999807,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.237,
"layouts": 4,
"layoutDurationMs": 1.2910000000000001,
"taskDurationMs": 2085.786,
"heapDeltaBytes": -5981504,
"heapUsedBytes": 77109156,
"domNodes": 0,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 1025.0030000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.2,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2048.010999999974,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.606,
"layouts": 8,
"layoutDurationMs": 2.803,
"taskDurationMs": 575.828,
"heapDeltaBytes": -2176600,
"heapUsedBytes": 79098480,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 35.63600000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2074.2079999999987,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5320000000000005,
"layouts": 7,
"layoutDurationMs": 2.357,
"taskDurationMs": 737.9319999999999,
"heapDeltaBytes": -19247112,
"heapUsedBytes": 79099760,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 38.376,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 679.6410000000037,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.509999999999999,
"layouts": 10,
"layoutDurationMs": 3.0599999999999996,
"taskDurationMs": 474.042,
"heapDeltaBytes": 21645852,
"heapUsedBytes": 88520664,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 151.264,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 615.5120000000807,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.221,
"layouts": 9,
"layoutDurationMs": 2.5370000000000004,
"taskDurationMs": 452.738,
"heapDeltaBytes": 21658264,
"heapUsedBytes": 88556576,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 149.923,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669444444444455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.6809999999869,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.175,
"layouts": 10,
"layoutDurationMs": 3.5380000000000003,
"taskDurationMs": 609.764,
"heapDeltaBytes": 1966580,
"heapUsedBytes": 68694548,
"domNodes": -180,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 12.349,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2030.1030000000537,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2960000000000003,
"layouts": 10,
"layoutDurationMs": 3.1559999999999997,
"taskDurationMs": 621.571,
"heapDeltaBytes": 3920700,
"heapUsedBytes": 80732616,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 12.136,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1961.0500000000002,
"styleRecalcs": 86,
"styleRecalcDurationMs": 18.846,
"layouts": 10,
"layoutDurationMs": 3.4779999999999998,
"taskDurationMs": 1086.8519999999999,
"heapDeltaBytes": -11387476,
"heapUsedBytes": 65588024,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 124.78100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.2570000000833,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.047,
"layouts": 9,
"layoutDurationMs": 2.841,
"taskDurationMs": 705.033,
"heapDeltaBytes": 10287832,
"heapUsedBytes": 77346728,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 118.262,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1453.563000000031,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.322999999999993,
"layouts": 5,
"layoutDurationMs": 16.369000000000003,
"taskDurationMs": 1145.8500000000004,
"heapDeltaBytes": 7817220,
"heapUsedBytes": 101435264,
"domNodes": 15953,
"jsHeapTotalBytes": 19013632,
"scriptDurationMs": 33.114,
"eventListeners": 3244,
"totalBlockingTimeMs": 173,
"frameDurationMs": 19.818918918918925,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10523.64,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.647,
"layouts": 8,
"layoutDurationMs": 2.6500000000000004,
"taskDurationMs": 6375.518999999999,
"heapDeltaBytes": -13505640,
"heapUsedBytes": 83504604,
"domNodes": -258,
"jsHeapTotalBytes": 5599232,
"scriptDurationMs": 2908.073,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.71907790143084,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9806.34699999996,
"styleRecalcs": 248,
"styleRecalcDurationMs": 19.491,
"layouts": 6,
"layoutDurationMs": 1.7040000000000002,
"taskDurationMs": 6085.478,
"heapDeltaBytes": -16995976,
"heapUsedBytes": 79714576,
"domNodes": -258,
"jsHeapTotalBytes": 5861376,
"scriptDurationMs": 2728.079,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.751452991452993,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16980.856000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16311.365000000002,
"heapDeltaBytes": -15425792,
"heapUsedBytes": 268429872,
"domNodes": -3330,
"jsHeapTotalBytes": 23580672,
"scriptDurationMs": 287.198,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.129674099485417,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16807.108999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15731.522,
"heapDeltaBytes": -27207816,
"heapUsedBytes": 269350944,
"domNodes": -3330,
"jsHeapTotalBytes": 22532096,
"scriptDurationMs": 252.92399999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.618909710391822,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 28430.316000000006,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.489000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28066.838999999996,
"heapDeltaBytes": -39876364,
"heapUsedBytes": 255243964,
"domNodes": -3330,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 921.763,
"eventListeners": -651,
"totalBlockingTimeMs": 22,
"frameDurationMs": 52.9463687150838,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 28124.35800000003,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.51900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27740.977000000006,
"heapDeltaBytes": -14866316,
"heapUsedBytes": 286215916,
"domNodes": -3330,
"jsHeapTotalBytes": 9879552,
"scriptDurationMs": 894.8879999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 17,
"frameDurationMs": 52.2592936802974,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8536.541,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.855,
"layouts": 20,
"layoutDurationMs": 24.681999999999995,
"taskDurationMs": 8424.984999999999,
"heapDeltaBytes": -36936488,
"heapUsedBytes": 258701988,
"domNodes": -3330,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 125.72500000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49.99824561403509,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8507.210999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.528,
"layouts": 20,
"layoutDurationMs": 26.01300000000001,
"taskDurationMs": 8307.726999999999,
"heapDeltaBytes": -47272328,
"heapUsedBytes": 248330140,
"domNodes": -3330,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 134.945,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.56971428571428,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11491.34399999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11192.885,
"heapDeltaBytes": -1202736,
"heapUsedBytes": 247176320,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.16800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.57597173144876,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11430.853999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11152.618,
"heapDeltaBytes": -4848544,
"heapUsedBytes": 246339964,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.33300000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.75559322033897,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 149.48500000002696,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.701,
"layouts": 10,
"layoutDurationMs": 4.581,
"taskDurationMs": 111.13800000000002,
"heapDeltaBytes": -10756016,
"heapUsedBytes": 68209960,
"domNodes": 118,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 11.311,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.042857142857105,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "workflow-execution",
"durationMs": 126.83400000003076,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.219000000000001,
"layouts": 8,
"layoutDurationMs": 2.951,
"taskDurationMs": 87.705,
"heapDeltaBytes": 4446512,
"heapUsedBytes": 77607636,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.917,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.05714285714287,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 562.0089999999891,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.116,
"layouts": 76,
"layoutDurationMs": 17.623,
"taskDurationMs": 514.2769999999999,
"heapDeltaBytes": -14255104,
"heapUsedBytes": 80725888,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 241.91299999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 556.6880000000083,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.58,
"layouts": 76,
"layoutDurationMs": 17.538999999999998,
"taskDurationMs": 509.587,
"heapDeltaBytes": -13411120,
"heapUsedBytes": 81623316,
"domNodes": 4,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 246.82,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 629.4279999999617,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.786,
"layouts": 76,
"layoutDurationMs": 16.694,
"taskDurationMs": 596.306,
"heapDeltaBytes": 1051356,
"heapUsedBytes": 119507236,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 247.34699999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 608.2229999999527,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.799,
"layouts": 76,
"layoutDurationMs": 16.726000000000003,
"taskDurationMs": 564.822,
"heapDeltaBytes": 5734556,
"heapUsedBytes": 144741028,
"domNodes": 4,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 217.756,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2280 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0baf6e666328acad27722d0f595b365f4a82fd35
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21441 +/- ##
=============================================
- Coverage 87.19% 86.70% -0.50%
=============================================
Files 2624 2649 +25
Lines 147504 148736 +1232
Branches 38426 40526 +2100
=============================================
+ Hits 128619 128960 +341
- Misses 18497 19388 +891
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 64 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Manual backport of #21264 to
core/1.57.The cherry-pick conflicted in
dynamicGroupWidget.test.tsbecause #21246 is not on this branch. The testrejects an unsupported saved row count stored as a numeric stringis left out: it depends on #21246 converting numeric strings, and without that change a numeric string is never read as a row count, so there is nothing for the guard to refuse.dynamicGroupWidget.test.tsanddynamicGroupDiagnostics.test.tspass (73 tests), andpnpm typecheckpasses.