Repository navigation
[backport cloud/1.57] fix: refuse remote DynamicGroup row counts above max - #21442
Conversation
A remote write to a DynamicGroup row count goes straight through the controller setter, which normalizes to `Math.max(min, trunc(value))` and never applies `max`. So `rows = 25` on a `max: 20` group quietly creates 25 rows, and a very large value can freeze the tab adding rows one at a time. The remote apply path now refuses a row count that would grow the group past `max` before touching the setter. Nothing changes on the node, the apply counts as a failure, and the existing remote mismatch report fires. A group restored with more rows than `max` can still re-apply its own count or shrink; only growth past `max(max, current rows, rows the document carries values for)` is refused, so a rollback or undo can bring back rows the doc still holds. The shared setter is left alone on purpose: restoring a saved workflow must keep rows it already has beyond `max`. - Fixes #21095 | Commit | CI Status | Purpose | |--------|-----------|---------| | `test: cover remote DynamicGroup row counts above max` (c76a686) | :red_circle: [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39096366190) | Proves the test catches the bug | | `fix: refuse remote DynamicGroup row counts above max` (a54e8b3) | :green_circle: [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39098010935) | Proves the fix resolves the bug | | `test: cover a remote row count above max on a restored DynamicGroup` (dcf95ae) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39100669923) | A restored group already above `max` still counted the refused write as a success | | `fix: report a refused remote row count even when the group already holds it` (7457a8c) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39101290723) | Above-max requests are always reported as refused | | `test: accept remote row counts that do not grow a restored DynamicGroup` (b027386) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39107083689) | Re-applying or shrinking a restored above-max group was reported as a refusal | | `fix: refuse only remote row counts that grow a DynamicGroup past max` (15db48a) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39107937126) | Only growth past `max(max, current rows)` is refused | | `test: restore rows a remote rollback still documents above max` (32c99ae) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39117022789) | A rollback to rows the doc still holds was refused after a local remove | | `fix: count documented DynamicGroup rows toward the remote row ceiling` (bc77798) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39117879853) | The ceiling also counts rows the document carries values for | - [x] CI red on test-only commit (only the two new above-max cases fail) - [x] CI green on fix commit - Unit coverage for a remote count at `max` (applies), `max + 1` and `1e9` (refused, no row allocated, mismatch reported), a saved workflow with rows above `max` (restored as is), and on such a restored group: re-applying the same count or shrinking applies, growing further is refused, and growing back to rows the doc still carries values for applies. The large-value case spies on `addCustomWidget` so the red commit fails fast instead of hanging. - No E2E: the remote apply path is covered at the `LiveGraphApplier` level with a followed Y.Doc, which is where the refusal lives. (cherry picked from commit f66a36f)
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-20T10:59:44.737Z",
"gitSha": "3dfa18ea99e058824e2654a55be6fc98b7e96fcb",
"branch": "backport-21264-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.4100000000217,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.412,
"layouts": 8,
"layoutDurationMs": 2.8690000000000007,
"taskDurationMs": 390.234,
"heapDeltaBytes": 22162252,
"heapUsedBytes": 87628052,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 9.790000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2024.5080000000826,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2180000000000004,
"layouts": 9,
"layoutDurationMs": 3.0509999999999993,
"taskDurationMs": 661.471,
"heapDeltaBytes": -903732,
"heapUsedBytes": 74076928,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 15.872,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.3720000000394,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.096,
"layouts": 9,
"layoutDurationMs": 2.5509999999999997,
"taskDurationMs": 891.705,
"heapDeltaBytes": -7270344,
"heapUsedBytes": 68245548,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 168.27599999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1974.8080000000527,
"styleRecalcs": 82,
"styleRecalcDurationMs": 18.73,
"layouts": 10,
"layoutDurationMs": 3.371,
"taskDurationMs": 1023.474,
"heapDeltaBytes": -2954084,
"heapUsedBytes": 71703304,
"domNodes": 0,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 187.56499999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66694915254238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.2140000000177,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.258000000000001,
"layouts": 11,
"layoutDurationMs": 3.1209999999999996,
"taskDurationMs": 424.15,
"heapDeltaBytes": -4558648,
"heapUsedBytes": 70357800,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 13.028999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.6129999999766,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.514999999999999,
"layouts": 11,
"layoutDurationMs": 3.2990000000000004,
"taskDurationMs": 467.935,
"heapDeltaBytes": 18769276,
"heapUsedBytes": 85027608,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 15.510999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 673.7789999999677,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.4450000000000003,
"layouts": 9,
"layoutDurationMs": 2.1229999999999998,
"taskDurationMs": 492.665,
"heapDeltaBytes": 25198524,
"heapUsedBytes": 91006844,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 168.415,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 780.2229999999781,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.3480000000000003,
"layouts": 8,
"layoutDurationMs": 2.9679999999999995,
"taskDurationMs": 556.277,
"heapDeltaBytes": 3860032,
"heapUsedBytes": 78895096,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 179.507,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1234.8179999999616,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 947.64,
"heapDeltaBytes": 818688,
"heapUsedBytes": 81313164,
"domNodes": -192,
"jsHeapTotalBytes": 14426112,
"scriptDurationMs": 81.015,
"eventListeners": -106,
"totalBlockingTimeMs": 545,
"frameDurationMs": 33.33243243243241,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1311.5530000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1005.5640000000001,
"heapDeltaBytes": -12744484,
"heapUsedBytes": 81464748,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 86.679,
"eventListeners": -106,
"totalBlockingTimeMs": 623,
"frameDurationMs": 35.583783783783794,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 872.776999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.79100000000057,
"heapDeltaBytes": -5965656,
"heapUsedBytes": 75109196,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 170.902,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25.48823529411763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 887.5980000000254,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.375,
"heapDeltaBytes": -4008104,
"heapUsedBytes": 76859336,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 179.95299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 25.237142857142835,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12313.469999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11391.135999999999,
"heapDeltaBytes": -18325372,
"heapUsedBytes": 75474872,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 9236.168000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1756,
"frameDurationMs": 33.06317204301076,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10942.207999999937,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10116.308,
"heapDeltaBytes": -10753148,
"heapUsedBytes": 85179092,
"domNodes": -258,
"jsHeapTotalBytes": 6418432,
"scriptDurationMs": 8145.275999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1214,
"frameDurationMs": 31.416379310344833,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10314.677999999958,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06300000000000056,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9418.913,
"heapDeltaBytes": -15510532,
"heapUsedBytes": 83237744,
"domNodes": -258,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 7898.224,
"eventListeners": -68,
"totalBlockingTimeMs": 1228,
"frameDurationMs": 32.440880503144655,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10881.804999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9963.804,
"heapDeltaBytes": -3357304,
"heapUsedBytes": 96006124,
"domNodes": -258,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 8314.263,
"eventListeners": -68,
"totalBlockingTimeMs": 1554,
"frameDurationMs": 32.38928571428572,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-combo-open",
"durationMs": 255.91900000000578,
"styleRecalcs": 24,
"styleRecalcDurationMs": 18.47,
"layouts": 11,
"layoutDurationMs": 3.614,
"taskDurationMs": 210.24,
"heapDeltaBytes": -7624728,
"heapUsedBytes": 79622892,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.952,
"eventListeners": 196,
"totalBlockingTimeMs": 8,
"frameDurationMs": 24.24545454545453,
"p95FrameDurationMs": 100.09999999999945
},
{
"name": "large-combo-open",
"durationMs": 252.0879999999579,
"styleRecalcs": 23,
"styleRecalcDurationMs": 19.461,
"layouts": 11,
"layoutDurationMs": 4.131,
"taskDurationMs": 195.63,
"heapDeltaBytes": -7574780,
"heapUsedBytes": 79760788,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 11.238999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 11,
"frameDurationMs": 25,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "large-graph-idle",
"durationMs": 2024.5600000000081,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.192,
"layouts": 8,
"layoutDurationMs": 2.0380000000000003,
"taskDurationMs": 639.84,
"heapDeltaBytes": -3280764,
"heapUsedBytes": 75685440,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 31.948000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.6800000000185,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6830000000000003,
"layouts": 7,
"layoutDurationMs": 2.4130000000000003,
"taskDurationMs": 611.2449999999999,
"heapDeltaBytes": -1849048,
"heapUsedBytes": 76943352,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 45.11600000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2545.3219999999988,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.164999999999999,
"layouts": 6,
"layoutDurationMs": 1.4969999999999997,
"taskDurationMs": 1777.733,
"heapDeltaBytes": -12363448,
"heapUsedBytes": 68145160,
"domNodes": -278,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 885.3140000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.775657894736838,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2604.782,
"styleRecalcs": 66,
"styleRecalcDurationMs": 6.42,
"layouts": 4,
"layoutDurationMs": 1.1710000000000003,
"taskDurationMs": 1812.679,
"heapDeltaBytes": 3641436,
"heapUsedBytes": 83601004,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 849.2259999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666025641025644,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3616.337000000044,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.911999999999999,
"layouts": 65,
"layoutDurationMs": 11.559,
"taskDurationMs": 1750.4879999999998,
"heapDeltaBytes": -10969052,
"heapUsedBytes": 70664908,
"domNodes": -234,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 860.059,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.743055555555557,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4070.930999999973,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.876999999999999,
"layouts": 63,
"layoutDurationMs": 12.414,
"taskDurationMs": 2017.6060000000002,
"heapDeltaBytes": -31793256,
"heapUsedBytes": 67665928,
"domNodes": -234,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 878.684,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3123.5280000000216,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.9030000000000005,
"layouts": 5,
"layoutDurationMs": 1.487,
"taskDurationMs": 1995.953,
"heapDeltaBytes": 37514136,
"heapUsedBytes": 116021492,
"domNodes": 0,
"jsHeapTotalBytes": 7757824,
"scriptDurationMs": 994.3270000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.20978260869565,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3122.8920000000926,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.6000000000000005,
"layouts": 5,
"layoutDurationMs": 1.2000000000000002,
"taskDurationMs": 1927.505,
"heapDeltaBytes": 16751644,
"heapUsedBytes": 99766448,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 1026.981,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.845161290322583,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.2330000000006,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.954,
"layouts": 6,
"layoutDurationMs": 2.032,
"taskDurationMs": 517.371,
"heapDeltaBytes": -2860660,
"heapUsedBytes": 78109080,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 41.414,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.3960000000534,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.1730000000000005,
"layouts": 8,
"layoutDurationMs": 2.579,
"taskDurationMs": 761.564,
"heapDeltaBytes": -23082080,
"heapUsedBytes": 75243940,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 40.605000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 604.8670000000129,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.024,
"layouts": 8,
"layoutDurationMs": 2.8229999999999995,
"taskDurationMs": 428.07599999999996,
"heapDeltaBytes": 20331676,
"heapUsedBytes": 86670828,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 159.462,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 778.1310000000303,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.861,
"layouts": 8,
"layoutDurationMs": 2.927,
"taskDurationMs": 528.602,
"heapDeltaBytes": -1044032,
"heapUsedBytes": 76365552,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 166.05,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667391304347824,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.7510000000043,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.9309999999999996,
"layouts": 8,
"layoutDurationMs": 2.7279999999999993,
"taskDurationMs": 533.087,
"heapDeltaBytes": 21621108,
"heapUsedBytes": 88982788,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.325,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.9929999999813,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.091999999999999,
"layouts": 9,
"layoutDurationMs": 2.985,
"taskDurationMs": 674.7939999999999,
"heapDeltaBytes": 3925036,
"heapUsedBytes": 81283016,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 15.423999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2003.3680000000231,
"styleRecalcs": 89,
"styleRecalcDurationMs": 17.217999999999996,
"layouts": 8,
"layoutDurationMs": 1.9729999999999999,
"taskDurationMs": 1042.874,
"heapDeltaBytes": 11676380,
"heapUsedBytes": 78534656,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 113.681,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665000000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1785.9879999999748,
"styleRecalcs": 56,
"styleRecalcDurationMs": 16.961999999999996,
"layouts": 7,
"layoutDurationMs": 2.3840000000000003,
"taskDurationMs": 859.5509999999999,
"heapDeltaBytes": 11644800,
"heapUsedBytes": 78744704,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 131.00400000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1519.3060000000287,
"styleRecalcs": 20,
"styleRecalcDurationMs": 30.041999999999998,
"layouts": 5,
"layoutDurationMs": 17.367,
"taskDurationMs": 1239.3670000000002,
"heapDeltaBytes": 2657996,
"heapUsedBytes": 100404732,
"domNodes": 15953,
"jsHeapTotalBytes": 18227200,
"scriptDurationMs": 34.629999999999995,
"eventListeners": 3244,
"totalBlockingTimeMs": 179,
"frameDurationMs": 19.656410256410265,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9450.039000000004,
"styleRecalcs": 249,
"styleRecalcDurationMs": 21.335,
"layouts": 7,
"layoutDurationMs": 2.2230000000000003,
"taskDurationMs": 6366.6230000000005,
"heapDeltaBytes": 14882744,
"heapUsedBytes": 94337544,
"domNodes": -258,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 2957.195,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666077738515902,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10758.297999999968,
"styleRecalcs": 249,
"styleRecalcDurationMs": 24.099000000000004,
"layouts": 6,
"layoutDurationMs": 1.9210000000000005,
"taskDurationMs": 6998.624000000001,
"heapDeltaBytes": -5130272,
"heapUsedBytes": 93060936,
"domNodes": -258,
"jsHeapTotalBytes": 6123520,
"scriptDurationMs": 3133.67,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66594427244582,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 24406.55800000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23807.871,
"heapDeltaBytes": -57311160,
"heapUsedBytes": 252135220,
"domNodes": -3330,
"jsHeapTotalBytes": 5492736,
"scriptDurationMs": 364.573,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.581151832460726,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 24935.28500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24361.881,
"heapDeltaBytes": -23347804,
"heapUsedBytes": 253742040,
"domNodes": -3330,
"jsHeapTotalBytes": 6803456,
"scriptDurationMs": 384.66299999999995,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.97248677248677,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 30443.718999999986,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.361999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 30119.939000000002,
"heapDeltaBytes": -6761728,
"heapUsedBytes": 277981900,
"domNodes": -3330,
"jsHeapTotalBytes": 7852032,
"scriptDurationMs": 1018.003,
"eventListeners": -651,
"totalBlockingTimeMs": 39,
"frameDurationMs": 57.37344632768362,
"p95FrameDurationMs": 116.69999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 29955.591000000026,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.344,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29640.836,
"heapDeltaBytes": -2679844,
"heapUsedBytes": 278980612,
"domNodes": -3330,
"jsHeapTotalBytes": 9424896,
"scriptDurationMs": 966.259,
"eventListeners": -651,
"totalBlockingTimeMs": 102,
"frameDurationMs": 55.874813432835815,
"p95FrameDurationMs": 116.69999999999709
},
{
"name": "vue-node-resize-workload",
"durationMs": 9224.89900000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.09900000000003,
"layouts": 20,
"layoutDurationMs": 27.424000000000003,
"taskDurationMs": 9113.765000000001,
"heapDeltaBytes": -15303996,
"heapUsedBytes": 266102032,
"domNodes": -3330,
"jsHeapTotalBytes": 7589888,
"scriptDurationMs": 144.599,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 53.27341040462427,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8770.883000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 95.68799999999999,
"layouts": 20,
"layoutDurationMs": 28.134999999999994,
"taskDurationMs": 8673.169,
"heapDeltaBytes": -46687836,
"heapUsedBytes": 253486696,
"domNodes": -3330,
"jsHeapTotalBytes": 16506880,
"scriptDurationMs": 145.202,
"eventListeners": -653,
"totalBlockingTimeMs": 1,
"frameDurationMs": 49.2494382022472,
"p95FrameDurationMs": 116.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12441.238999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12193.503999999997,
"heapDeltaBytes": 15433860,
"heapUsedBytes": 257352980,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 189.30599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.37554744525548,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12402.323000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12045.898000000001,
"heapDeltaBytes": 3454360,
"heapUsedBytes": 244787796,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 183.26000000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.406849315068506,
"p95FrameDurationMs": 100
},
{
"name": "workflow-execution",
"durationMs": 151.70999999998003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.64,
"layouts": 9,
"layoutDurationMs": 4.0169999999999995,
"taskDurationMs": 115.905,
"heapDeltaBytes": 4602644,
"heapUsedBytes": 77248348,
"domNodes": 97,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.324000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67777777777782,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 476.24199999995653,
"styleRecalcs": 11,
"styleRecalcDurationMs": 13.411000000000001,
"layouts": 10,
"layoutDurationMs": 4.415000000000001,
"taskDurationMs": 130.993,
"heapDeltaBytes": 6589432,
"heapUsedBytes": 79277016,
"domNodes": 95,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.021999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 544.7229999999763,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.454,
"layouts": 76,
"layoutDurationMs": 18.932000000000002,
"taskDurationMs": 503.963,
"heapDeltaBytes": -13729784,
"heapUsedBytes": 81988128,
"domNodes": 4,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 235.63400000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 625.001999999995,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.0399999999999998,
"layouts": 76,
"layoutDurationMs": 19.229,
"taskDurationMs": 572.194,
"heapDeltaBytes": 12572308,
"heapUsedBytes": 84588896,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 274.669,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 693.9009999999826,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.476,
"layouts": 76,
"layoutDurationMs": 18.31,
"taskDurationMs": 665.7339999999999,
"heapDeltaBytes": 1413256,
"heapUsedBytes": 132789260,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 279.088,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.06190476190477,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 648.6509999999726,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.643,
"layouts": 76,
"layoutDurationMs": 16.543,
"taskDurationMs": 609.011,
"heapDeltaBytes": 1615092,
"heapUsedBytes": 124294984,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 250.585,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.092307692307678,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.5% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2285 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f0acebb826e9ce86097db63213a3bc9e07f1a520
Full docs: ADR-DEVEX-LINT-0015 |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21442 +/- ##
=============================================
Coverage ? 86.73%
=============================================
Files ? 2663
Lines ? 149443
Branches ? 40746
=============================================
Hits ? 129618
Misses ? 19435
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Manual backport of #21264 to
cloud/1.57.The cherry-pick conflicted in
dynamicGroupWidget.test.tsbecause #21246 is not on this branch. The testrejects an unsupported saved row count stored as a numeric stringis left out: it depends on #21246 converting numeric strings, and without that change a numeric string is never read as a row count, so there is nothing for the guard to refuse.dynamicGroupWidget.test.tsanddynamicGroupDiagnostics.test.tspass (73 tests), andpnpm typecheckpasses.